GNU bug report logs - #70828
[PATCH] services: certbot: Add certbot-configuration-package to profile.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70828 in the body.
You can then email your comments to 70828 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: guix-patches <at> gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: [PATCH] services: certbot: Add certbot-configuration-package to
 profile.
Date: Wed,  8 May 2024 08:00:42 -0400

As the manual suggests running a certbot command to view the issued
certificates, add it to the profile.

gnu/services/certbot.scm (certbot-service-type): Extend profile-service-type
with certbot-configuration-package.

Change-Id: I92618597bbdc8d838420b2e0f82de601b0bc609b
---
Hi Guix!

This is just a small enhancement to certbot-service-type to make it
easier to use. The manual suggests running a certbot command to view
the issued certificates ($ certbot certificates). So, adding the
configured certbot package to the profile improves ease of use.

 gnu/services/certbot.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
index f287c8367f..b276c49e0f 100644
--- a/gnu/services/certbot.scm
+++ b/gnu/services/certbot.scm
@@ -350,6 +350,8 @@ (define certbot-service-type
                 (extensions
                  (list (service-extension nginx-service-type
                                           certbot-nginx-server-configurations)
+                       (service-extension profile-service-type
+                                          (compose list certbot-configuration-package))
                        (service-extension activation-service-type
                                           certbot-activation)
                        (service-extension mcron-service-type

base-commit: da41a8f5e85774e2a507d821b5d52e600fb9d1d7
-- 
2.41.0

Message #10 received at 70828-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: 70828-done <at> debbugs.gnu.org
Subject: Re: [bug#70828] [PATCH] services: certbot: Add
 certbot-configuration-package to profile.
Date: Tue, 03 Sep 2024 11:51:14 +0200

Hi,

Richard Sent <richard <at> freakingpenguin.com> skribis:

> As the manual suggests running a certbot command to view the issued
> certificates, add it to the profile.
>
> gnu/services/certbot.scm (certbot-service-type): Extend profile-service-type
> with certbot-configuration-package.
>
> Change-Id: I92618597bbdc8d838420b2e0f82de601b0bc609b
> ---
> Hi Guix!
>
> This is just a small enhancement to certbot-service-type to make it
> easier to use. The manual suggests running a certbot command to view
> the issued certificates ($ certbot certificates). So, adding the
> configured certbot package to the profile improves ease of use.

Makes sense to me.  Finally applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.