Morgan Smith <Morgan.J.Smith@HIDDEN>
to control <at> debbugs.gnu.org
.
Full text available.Received: (at 70894) by debbugs.gnu.org; 19 May 2024 09:22:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 19 05:22:53 2024 Received: from localhost ([127.0.0.1]:35893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s8ckm-00032J-MO for submit <at> debbugs.gnu.org; Sun, 19 May 2024 05:22:53 -0400 Received: from mout.gmx.net ([212.227.17.21]:49677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1s8ckj-000327-Q1 for 70894 <at> debbugs.gnu.org; Sun, 19 May 2024 05:22:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1716110557; x=1716715357; i=rudalics@HIDDEN; bh=vXeofv5poBBhnSxCUOabAcwsHZv7DoowR5lz/DnYYNU=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=I5p9Lqv2W7cQu6smtxTv3Mu/CrHfSurUpxlZl/FLShL6/wZ41PwxV5FoBHRL7Cdh cER9Run78Hl2M1n6s1himLaGemdAWeewdxtHjC5FDyii0X7SVRsQeGOmVmJIyxYzV roNtBpN8UwgV4pXqTYOIXSCnA8CxW/z/pf9/TgojJtbM2xYwTpDJURl5WBnj4rzlA hN1iFmdVHtDoLZOg5twEy1F07Ni3C6D7aGDgr2VqCXqWbWGHpX8fplzb3GiO9E1S+ qjinHtpYS0OLk3vhn1WBlIATJBk53c4poXupYjS1ZFBN1njDNOnV/lFbE0awmAgCh 3t/uWgZU8CyHL6wFVw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([46.125.249.77]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3siG-1sYqkP153Q-00zrax; Sun, 19 May 2024 11:22:37 +0200 Message-ID: <9ce8c102-65eb-4c66-8474-87ce7bb7a55b@HIDDEN> Date: Sun, 19 May 2024 11:22:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation To: Eli Zaretskii <eliz@HIDDEN> References: <CH3PR84MB3424400ADD023A59A6678F83C5E12@HIDDEN> <86jzjre9xh.fsf@HIDDEN> <e1948bbd-2af4-4766-9358-9cb358a59671@HIDDEN> <86le46b4ue.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86le46b4ue.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:DeXn7Nw/NVjM1YmPxq/kEHNpP7K4ypFFHCX6hzjPNDesMIAZ4gz Im3Uodr6wT7ICN3BfRkRZBBUO8BeN8uXNnjMKgeiE3t00BK22cqMXjHgANlozgFla2FiwIb L58NBWx4DVychyffdPQdx/Du9jdwOOPP/gqEeu5BISyO6JBPAsBKJ5ChAtDuO0YiywfHzHB mqR0uruG60+6NiXJaxj1w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:VW+hNd5Y1Yk=;T+In9GA03+hdMXL1J9A5w0CoSuw /wS4mzqOIDR7v26xQm/aX4/hQDNjp3SRdQQyK0dzeECVdMUk2COp+mBITHnQwyYenj7fAHBKs yFrVaVIMlQxulwEbM4NBvVBympFdvFRdYnu9ryhKRr4zp32PprqGADp6EYHJZ9650yaBqfn1v r3RYu+9VK37zsi6EhxrXUYlm4pApEMspTi39dLbdb23cv+l7PVorrIZX5JvnRmrvwBEuirvLg UTeq1q+/Rnob0yHDQAl/QqkYBzI2XYozZmaPbpro1KzSfnaRkscSjR27AdFpUS4UILNWQ8PLj 3w9NRSKSlnY6wXqxDYXaz/6xmbt5JxDe1iqFMjBl44iOhxSjn8HLU6hCMqzTxEcoB3c0cLMXA kLxp/2Nlx9mrFxQ/oNrv8SPIko7lQeAsvP58bUhrfcegywmjth23If5R/BpOeW8/G/K6orHOA PmzUsq1GqkhxPnRDkskd4bLh8t2MY/klcT6OFbgDoGaup6ejZ9nQRf2SjdQwBf4KOACpvk5Z2 4FDzcOrBqvozTI4c1IAL7d9X7fAOjFhAoBTQFjY1V49mNpGy8MPLlnvGOfZsMShlAlTYXugi5 fRC6hISn2c4cM456PIRgpCTKemGy3r9sJ/ZFJnIKtIbXFiPWVmeSzkpbvGQ7X68zOO8imL6GQ qwktGnJsSrJ/kqqmDeLj2/qvweET0THvDCWeo8TZyd06kBqRNu8QIOW/xx7zMPAPSYCbK6gdS z/LY+GE0ucOUWPGxvLyu+CB6BCIncrNxMBqXL7PLtcsaPXGQHEipPlScV9LZAUZLoZXtVCG8A y/tpfK0ZGnf1CNqWFvW/i3z2ZXSW8u7VvxiO1ozyozkPk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70894 Cc: Morgan.J.Smith@HIDDEN, 70894 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > For the last issue: we should use default-font-width/height. But the > question is: would replacing frame-char-width/height by these two fix > that use case, or do we need anything else? It might improve those use cases but won't take care of any extra line spacing. But there are too many unresolved issues there: How would we interpret the MAX/MIN-WIDTH and MAX/MIN-HEIGHT arguments - still in frame character units as we (partially) do now? Note that functions like 'window-min-size' or 'window-safe-min-pixel-height' don't care about window character units, they operate in frame units. And there's always the possibility that intermediate rounding errors sum up and make things only get worse. martin
bug-gnu-emacs@HIDDEN
:bug#70894
; Package emacs
.
Full text available.Received: (at 70894) by debbugs.gnu.org; 19 May 2024 08:09:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 19 04:09:42 2024 Received: from localhost ([127.0.0.1]:35853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s8bby-00027o-JM for submit <at> debbugs.gnu.org; Sun, 19 May 2024 04:09:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s8bbx-00027i-AP for 70894 <at> debbugs.gnu.org; Sun, 19 May 2024 04:09:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s8bbn-0006P2-Ay; Sun, 19 May 2024 04:09:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=C0uUCcCQnHuRAGIcl0W8o5YDdVv8/W97+FEG3vCYFcg=; b=mL2qa9yf0s81 vS+g9QEwCTG9C/njp4pJhJgS8/VUo0mm8FEoxgW65DexvgsIy4ABjkhvOCBdfBWoFqA85lS7QBDcX 6aMyGj0yYQYQ8aviQLG0TJCJdfOMw0Iw1u+yOqf15i09QMJkmmEsdsl3Ex2aCRchaoi38V9hPTHk3 zB1j6cdBwqV5Jj7hGWFKA/73KHUXJ5z64x1A6qmP7LWhfo3u6KKBNW2Z4/spOQbzA+1VLPtpzDJyb lP5xEKPs3sDUr0VrqKyeo65kj9DfLnBinc0A7v/LLUj56s3qbF5BPAi/z2hIf7+ny/+fGluR413E/ s5KfboN1rRiRQxodVJUYhQ==; Date: Sun, 19 May 2024 11:09:29 +0300 Message-Id: <86le46b4ue.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: martin rudalics <rudalics@HIDDEN> In-Reply-To: <e1948bbd-2af4-4766-9358-9cb358a59671@HIDDEN> (message from martin rudalics on Sun, 19 May 2024 09:58:58 +0200) Subject: Re: bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation References: <CH3PR84MB3424400ADD023A59A6678F83C5E12@HIDDEN> <86jzjre9xh.fsf@HIDDEN> <e1948bbd-2af4-4766-9358-9cb358a59671@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70894 Cc: Morgan.J.Smith@HIDDEN, 70894 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sun, 19 May 2024 09:58:58 +0200 > Cc: 70894 <at> debbugs.gnu.org > From: martin rudalics <rudalics@HIDDEN> > > > Martin, any comments? > > Looks good to me. Principally, instead of subtracting the sizes of the > decorations from the initial total width and re-adding them later, they > should have been added to the calculated pixel width as is done when > fitting the height. OK, I installed the patch on master now, thanks. > But mildly spoken, 'fit-window-to-buffer' is a complete mess in the > first place. Calculating sizes in terms of lines/columns doesn't make > sense. If really necessary - minibuffer resizing, for example, does not > care - results should be rounded in a final step. Also, I doubt that > both char-width and char-height are calculated reasonably when buffer > text is scaled or line spacing changed. For the last issue: we should use default-font-width/height. But the question is: would replacing frame-char-width/height by these two fix that use case, or do we need anything else?
bug-gnu-emacs@HIDDEN
:bug#70894
; Package emacs
.
Full text available.Received: (at 70894) by debbugs.gnu.org; 19 May 2024 07:59:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 19 03:59:14 2024 Received: from localhost ([127.0.0.1]:35843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s8bRq-0001z5-4G for submit <at> debbugs.gnu.org; Sun, 19 May 2024 03:59:14 -0400 Received: from mout.gmx.net ([212.227.15.15]:58787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1s8bRo-0001yz-Do for 70894 <at> debbugs.gnu.org; Sun, 19 May 2024 03:59:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1716105539; x=1716710339; i=rudalics@HIDDEN; bh=uJoPOoA6HzJsemxNZ+MN2YL1ha+/8APcuQN4LHQfjas=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=hNS0JeAox6GZfcdG+D0YvcpwF8HISG9o6M1j7YEyMDYfqQ1gZqhIPYjTU8ixoHzA iJdhxf3NKu4Izx+APmrAviWeDwRQvHVsAvU2kzKDIfsv4uFsEyf2Ba8FvsDYrqGRi nV6gtNa3W1Zf3MzjhrGxLlnzkwN6M20APdk3urCGDrsX7pZjeh4KsBw1aRXTWPZG9 dngBfiAxZfqYWBpFhU6lMrS4iGgWMYGrYVe+XM5v8XJRtvmZnkEfJchrU8bo1vITV rOOLAQzR+cDVnK7WoN4on7yzf03kOqsuRUFq/8yaYeU31uE1wcY8FBZHh/qQAhCFj qiDWXlOQ2oseBKrFFA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([46.125.249.126]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MWzk3-1s1kkc1vuD-00WDZu; Sun, 19 May 2024 09:58:59 +0200 Message-ID: <e1948bbd-2af4-4766-9358-9cb358a59671@HIDDEN> Date: Sun, 19 May 2024 09:58:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation To: Eli Zaretskii <eliz@HIDDEN>, Morgan Smith <Morgan.J.Smith@HIDDEN> References: <CH3PR84MB3424400ADD023A59A6678F83C5E12@HIDDEN> <86jzjre9xh.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86jzjre9xh.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:C3qZamv6yO/CotUrnWuVNyEptxsCTBd9a/D7U6KV6Cd0at2+UdI Lx0RrBa4u0iPvNmGcn7l8FPHB/8Rq/AA8fFhhKocYBnMEMMkMB8Opnj/ogVA0X8QADZfmH+ OXar8j6Nf6Ce4Yql+HZgJcTGzn1pP8yQVamoxuHW0Sy2OCIQ8gagngATppdKqSsshMTJT39 uVkjM5d1Sq9av5ibNvPHQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qCV8S1vXko0=;LsDDGbB7OyN32FsoXlzyXs/p1nm B0PrsMBMeTL2k9PwmbAeVHv181MtootYVqQ7RTSEWYF67UVIKs+fjKUtrA1XdNnhcMqDnNZlK XQy93LtQbSO+pJKYtNg6F9cEZwUUPjiPGbrXljrDdUUvK/a/mJ5J5vQrYuXT78VeRvh0grwG/ +INtgoqV4r/SMKw7Ja4wbVlTOF35+TWM3n4cm6Dc+R7/LHxLVKGfygz/2zWuKU3LqpmsdO6Gn NDr0N+X3aPsO4Lc2e/kjKVhOpJbU/PAGt+Gi+O8ZlitDldo0rKhH0ZKc/AWr+QmwI+Svy6BKs 9N3I5N0gu14Sld4hNrKKbgrHCsn/lx0weSsLSMT4cOH0SWzYHxGJUUffuT/vO/wFUDwnuvdyR 99UfJqIhjZCHCEZHpxSPv2g4DIpTsaEp3UqQssucLyxfxY4J3XJd90yHggWXmDR8VzyxIykq7 jlE5yEYKzp4/jymTUVMmcz3nVfij4LAUgJbo8t1U//Www1pil2DI+Zt/zuiuAM8O4LI/NCLZk SPUtpJFEC/RRd/GlYPdREJ2ipBS3JhRkimn0nRlVAySHqd1LxIUdT7Jr9pWvT5T2Jqqqr4NJs EXb35TgNq5ekxA3g0EGlNu5pZdms9zZbVGhNpyIeletl9VxN7tCRjetaqmF4tWG6FBgzzyqY+ /CGBFEpbfEU627g0RbMkAzHvMMMd1eNWGLwC9ui2G3rDJ2u4TSGAx8cGdEaWK0eLuXG7gKVXn 7cT9uCictbm3ug/DPt05x4ZHIyJpa3bdew5LjLqhWAClWX7BbfNmlwCiIzUZLHifgR/kJTLOS HJxdaiN0PbuuWgRoQ1V5JbT8aWLQX1tU2B6qF4/K+YgOo= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70894 Cc: 70894 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > Martin, any comments? Looks good to me. Principally, instead of subtracting the sizes of the decorations from the initial total width and re-adding them later, they should have been added to the calculated pixel width as is done when fitting the height. But mildly spoken, 'fit-window-to-buffer' is a complete mess in the first place. Calculating sizes in terms of lines/columns doesn't make sense. If really necessary - minibuffer resizing, for example, does not care - results should be rounded in a final step. Also, I doubt that both char-width and char-height are calculated reasonably when buffer text is scaled or line spacing changed. martin
bug-gnu-emacs@HIDDEN
:bug#70894
; Package emacs
.
Full text available.Received: (at 70894) by debbugs.gnu.org; 18 May 2024 09:39:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 18 05:39:21 2024 Received: from localhost ([127.0.0.1]:60622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s8GXB-0000Sm-1b for submit <at> debbugs.gnu.org; Sat, 18 May 2024 05:39:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s8GX8-0000Sd-U7 for 70894 <at> debbugs.gnu.org; Sat, 18 May 2024 05:39:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s8GWz-0006xJ-F8; Sat, 18 May 2024 05:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=R2cvCQc6QNkAmtYZrsGsrJhJ5pCfZEdqhWmhg6kwoKE=; b=PQnaCWRq5NIV PItPWluoGBiQEuuJYRjbVXroEGNPHmNeakRV4hSCWaVYkb3UBJT1pV7p00WT/vSL3sCtRZvKPA6HL 2xP7D1whnBBSQaTLx0+aBjK1F3W8hDSloLPgrAfCz4wdlHZe6nj4gjN0d07rZV1VOO12mgDtZn2LL juN9f0HbS380uYBOipg4JUfTHjmOV6pYK91g4peqZUdt9nCytIH3QNAYuF4iUjOwGlsxP4XPlmfuu MvFlHH/lWmNKS8oG7YvOrBYXprqQwniiE+li+6DEaFMdhNKYyGumJy2dGqPA0nIhl7m87JgFckgNB XYGd6g+QesPucQieoSueFg==; Date: Sat, 18 May 2024 12:39:06 +0300 Message-Id: <86jzjre9xh.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Morgan Smith <Morgan.J.Smith@HIDDEN>, martin rudalics <rudalics@HIDDEN> In-Reply-To: <CH3PR84MB3424400ADD023A59A6678F83C5E12@HIDDEN> (message from Morgan Smith on Sun, 12 May 2024 09:25:31 -0400) Subject: Re: bug#70894: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation References: <CH3PR84MB3424400ADD023A59A6678F83C5E12@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70894 Cc: 70894 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Morgan Smith <Morgan.J.Smith@HIDDEN> > Date: Sun, 12 May 2024 09:25:31 -0400 > > I was playing around with `fit-window-to-buffer' after setting > `fit-window-to-buffer-horizontally' to `t'. I noticed that it kept > setting the window too narrow. After a quick investigation, I found > some suspicious looking calculation that mixed pixel and column units. > > Interactively, it looks like this fixes the issue. Thanks. Martin, any comments? > >From f906b1a219ae7c9ec1374edf6e02b46b845ab776 Mon Sep 17 00:00:00 2001 > From: Morgan Smith <Morgan.J.Smith@HIDDEN> > Date: Sun, 12 May 2024 09:19:30 -0400 > Subject: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width > calculation > > When pixelwise is nil, we still calculate width in pixels and > then convert it to columns. However, part of the calculation > was using columns where it should have used pixels. > --- > lisp/window.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/window.el b/lisp/window.el > index 639090752be..f03996fb682 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -9906,8 +9906,8 @@ fit-window-to-buffer > ;; the bottom is wider than the window. > (* (window-body-height window pixelwise) > (if pixelwise 1 char-height)))) > - (- total-width > - (window-body-width window pixelwise))))) > + (- (* total-width (if pixelwise 1 char-width)) > + (window-body-width window t))))) > (unless pixelwise > (setq width (/ (+ width char-width -1) char-width))) > (setq width (max min-width (min max-width width))) > -- > 2.41.0 >
bug-gnu-emacs@HIDDEN
:bug#70894
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 12 May 2024 13:30:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 12 09:30:46 2024 Received: from localhost ([127.0.0.1]:54474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s69Hp-0000yi-IH for submit <at> debbugs.gnu.org; Sun, 12 May 2024 09:30:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:54782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <Morgan.J.Smith@HIDDEN>) id 1s69Hl-0000yc-W1 for submit <at> debbugs.gnu.org; Sun, 12 May 2024 09:30:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>) id 1s69Hl-0000oG-Nz for bug-gnu-emacs@HIDDEN; Sun, 12 May 2024 09:30:41 -0400 Received: from mail-bn8nam12olkn20800.outbound.protection.outlook.com ([2a01:111:f403:2c18::800] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>) id 1s69Hh-0001QS-L4 for bug-gnu-emacs@HIDDEN; Sun, 12 May 2024 09:30:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bhFt9LugBH9QmdHTPeDx6/KL/prxcsmA9/yhMtHyCFQCo6ruuiF2XDVkIiVBxvtsSsnNbp9VxoUWtX+ajoqI6nk/ALFGfW4cvn2kgctf/GJ3nn7wQUbFMn4Q+T7D4MDjE96UokXOmFJw9zKINhJ/NwAGlKclvtgM9R4UbPzzMDxr4/+XmvXp/jBYxt6ipLwnZZvdLZJJy19RNvZ1SA8sqLTgDx0BnFWgugZsPUdk8hCYVftRuzhjAh4sqCLisvCSjzYbMaPSKpozsYXEPQ9m8dpxkhFzJhl2n3YvkfBNLND8j5a53umuWz6mTRqPGWnDNRS1dC0w8Oj9XwWXazywMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rDxooQQIKvs1dSEUqOmfDO9kU6APLmjIahbAdu+heqA=; b=llO6pMAvwbU83oERMaCnb2x4u9OlnAn0cXDvxb8ewOXdD4jYbIi67zvWXe1W3qEa1R9vffxBkk/LIJoraTWLA0FWXMsnNzi0vodR2n0lwePmZPous9zxLP3O0sVkhy8wROvgneyZyjeE4EZ0bZu50eEPySR5ui8EW2GuBu6UnaoKDzmQglIIYf6qHvsgXrOHXni8kG6MVUmvhbfZgaVxT+02w1H6B/XVo0x+CWnZM21Wd5YwyvdlCpVCOOcmnY7EO0yJS46ntUEuZcfzUPZJiGmfusOurcHg0vsuZ0fJGrCWjvaBpKv35yIbynT9aNKtY4hxbCUgAA7M04DvuH0ckA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rDxooQQIKvs1dSEUqOmfDO9kU6APLmjIahbAdu+heqA=; b=kKu7FETdvcnJQj8g1PhgaygYlX3jck6olr/khiiMiBnybqucer3OHAdPo3+MulupIzaXgxR40G8W7HtKRFuvxCv3SEN+7ivFbTo3lOXvKIABNPG9jmSnY/lDJApKkMN2w0zMNGzV+hTUR/SM4FVHxGyVrXeepAwRjogv7dQiHbf5Uj39Zv0lhjqkoajz+4/OnMaz6GNk/p2DT2jFRmfb2v0hBhLpuTB2it8DMdRCEBGaMlFOtp8MYKdegn9zqAfFIt+vfxbOQzOjlMBLpQ/koJrXwivqo3oJOcyEoKyi5Wa9AOeB8WXhqg38/oj8/pIKg2kD9RDnWUShvqzEcBTGcw== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by MW4PR84MB1660.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Sun, 12 May 2024 13:25:32 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::178d:1518:8a49:2a45]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::178d:1518:8a49:2a45%6]) with mapi id 15.20.7544.052; Sun, 12 May 2024 13:25:32 +0000 From: Morgan Smith <Morgan.J.Smith@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation X-Hashcash: 1:20:240512:bug-gnu-emacs@HIDDEN::q9f6jVedLfEdDRPW:1QFL Date: Sun, 12 May 2024 09:25:31 -0400 Message-ID: <CH3PR84MB3424400ADD023A59A6678F83C5E12@HIDDEN> Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [+IR3UjYSmAD2eiWhlQyC8cu4TF6RXGKk] X-ClientProxiedBy: YQBPR0101CA0180.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:f::23) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <878r0fmab8.fsf@HIDDEN> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1660:EE_ X-MS-Office365-Filtering-Correlation-Id: 097ba51e-e009-453c-70fb-08dc7286fffb X-Microsoft-Antispam: BCL:0; ARA:14566002|6092099003|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: W3dos3WrYphz/45a/rMsT9jelKgS6HGmdPW8dl8lX+RXnSBOIhYsLqBRBiiaEdw4shPRuc65EbERlMQZ6Nh4Rg8rSV1ZjDeAUGYNYpCmTcvyAKaOIAqSbNvVHyE7n29BaB3Aa1ls7h3K4FeLrs2KQIDJVT1SK/gaRwF5244HlF54q3nYxAb/I3bBpt4F7aUMeqK8l4SFnTIhdr+AoLEfLVvXG9x5WHsTAWAwUhS47yT0xh7k+RDFRJ9BSol9gKBrWy5AJ/GPQiK6Xy289aZ8vJD3FOXCNTJpdh6KPkX/HGzS2t3Wjs5qJrJiNRKxovUrIw2SbgAdKJSoeMVw8gllM0gQmRZPwjiU9OY8qpy68wVscoPqf+evS/MQO+MD2rB0WluHp7jHyD5w7LbUa6wDqvtpyAni6ItxHfoZFraJiT7ge/VlZjKXVRR1ZMTZoExil+yEUtY4PlzpaTyYh0mPrJTJ+neYDR+hSNK1smct3w5gPgQrmoBOSK0NC48ln23z5Fc6jF62YvHX+XnOYJjti53Ycj0fHyGvpKLh2YdrH/cEVoy/UoTwe+7m61YroOMqb679uwDn66cHQo92eBTjJsNfelIIHPQP2q/1Z/sqlpDg9zStXYrETfMUXSGrUTdx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NG43f4g+ARH0kyJn/0fuTvi2Wa44revck+6U1fXtlQD4P1vUx51uUSBciEwZ?= =?us-ascii?Q?pEU/VFWkAoJAv/w2pswXvx08/a2WsxwCesK5mXOenEsFCPpTKUNOHsXZyrTK?= =?us-ascii?Q?Eg4brRPsEb6FbLvgAjU/v4d3PKyh+3jsHq1mhupbdgOz2T0A0jhs+KdGKIRG?= =?us-ascii?Q?2XuxI3039CCifPce3g8zlYsTu5d/wOtzZ6OEqlDpTmD7vJbMB970igH4vRxd?= =?us-ascii?Q?YK7s9DKhW8oMGlaLnJOYTWInZzPi2BP3chZ3LfbJldb4UuB9BuQ/NKxM+Bh8?= =?us-ascii?Q?UfSABvWB0cobyaPrTQqobwhAW+k9aYHNh73214lVp4Saq6aqWLwlXKM+ZZY7?= =?us-ascii?Q?TKLi/ZbcnHIMe/V3SFHkHxxKOOtIuhoQtX5T4cZFarTLKddTH0eY15xKBH42?= =?us-ascii?Q?UnGHB+5UZoz+vs9nefbl7lv6/9zyYS6gjFVmgsn7EeT7EtaIUou5fLUDcL07?= =?us-ascii?Q?RDZaYmMWcl7UiXNgqqmdLXwpRRCce8biygk31SGhn34xulLsfUG8jYiohcu9?= =?us-ascii?Q?RZxzu7qg/fUYMzbhT6suavxHLGAqR+/musPss/tf1FBNdDhMpZ13HGbuwM7v?= =?us-ascii?Q?1+tGfYsfkXai8JX/BTz46AwYZhEws3DOBeNRYhKFDt7KF0uAKoLGrNU29hYn?= =?us-ascii?Q?/DecdAtVxtspkpymoQ6QXVQVrODkCMrkAUl+xaPgMhyyXIjsNrh8L0vlg5xo?= =?us-ascii?Q?nau4CgWS5y81Xpp6vCzP+THLFWUcRV4wvjx1Y+SsBdkAEm12fputURsviNqz?= =?us-ascii?Q?C4+gGkecdIHHqLBIYPevb5BCa417A7t2jDdlXPGrrME4NjOiRGKfp0f6coeS?= =?us-ascii?Q?zV7+k+pSei4p8+ihaHN3Eje6ptsXJisWyiLuSpR6Ve7NNY4wfVmc9Lrp3m4w?= =?us-ascii?Q?SahzA2SL4TJbSGx+4PeCmqxQjM0mdbK+ZUNWB9ho40CxbN1/SR29+SJBcZHC?= =?us-ascii?Q?DX9JXZLghDZBJ4DSzXTQg22HnIUg5V+GycYUCyvazDo+bPruDwfhrRh5VxQa?= =?us-ascii?Q?t1ERvLarDZj8VGAAkC2P+zif0f0AQAXIn6EtZLawhyOb2qoVBnBqmtHfeMpJ?= =?us-ascii?Q?fLyPKMc2XE804w1yms95kd7ztitRdPIcWedNXNrPwOYtdA++JrkrJ2bfJn4+?= =?us-ascii?Q?ZHGiE1xMBiJNPQNrJfUizdyzOGRTmMI+GkF85JFxoCNTKZYsYnbra1wTEj8p?= =?us-ascii?Q?EufGw0kKw9zxBpPsZpZyE8fw3XicmnQYaug8hIH2wEIc6WRyCpWX7WDxczU1?= =?us-ascii?Q?+nEzTWZ6YtBB0yEQ5MQu?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 097ba51e-e009-453c-70fb-08dc7286fffb X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 13:25:32.8325 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1660 Received-SPF: pass client-ip=2a01:111:f403:2c18::800; envelope-from=Morgan.J.Smith@HIDDEN; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch Hello! I was playing around with `fit-window-to-buffer' after setting `fit-window-to-buffer-horizontally' to `t'. I noticed that it kept setting the window too narrow. After a quick investigation, I found some suspicious looking calculation that mixed pixel and column units. Interactively, it looks like this fixes the issue. Thanks, Morgan --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-window.el-fit-window-to-buffer-Fix-width-calcul.patch From f906b1a219ae7c9ec1374edf6e02b46b845ab776 Mon Sep 17 00:00:00 2001 From: Morgan Smith <Morgan.J.Smith@HIDDEN> Date: Sun, 12 May 2024 09:19:30 -0400 Subject: [PATCH] * lisp/window.el (fit-window-to-buffer): Fix width calculation When pixelwise is nil, we still calculate width in pixels and then convert it to columns. However, part of the calculation was using columns where it should have used pixels. --- lisp/window.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/window.el b/lisp/window.el index 639090752be..f03996fb682 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -9906,8 +9906,8 @@ fit-window-to-buffer ;; the bottom is wider than the window. (* (window-body-height window pixelwise) (if pixelwise 1 char-height)))) - (- total-width - (window-body-width window pixelwise))))) + (- (* total-width (if pixelwise 1 char-width)) + (window-body-width window t))))) (unless pixelwise (setq width (/ (+ width char-width -1) char-width))) (setq width (max min-width (min max-width width))) -- 2.41.0 --=-=-=--
Morgan Smith <Morgan.J.Smith@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#70894
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.