GNU bug report logs - #70906
[PATCH] Send HTTP headers with charset utf-8.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70906 in the body.
You can then email your comments to 70906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: bug-mumi <at> gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH] Send HTTP headers with charset utf-8.
Date: Sun, 12 May 2024 21:38:32 -0700

In most cases, providing HTTP headers with the charset is superior
to (and has precedence over) the declaration in an HTML <meta> tag:

    https://stackoverflow.com/a/26032993

A preview of this code is live at patchwise.org.
---
 mumi/web/render.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mumi/web/render.scm b/mumi/web/render.scm
index ad3ae0e..e867178 100644
--- a/mumi/web/render.scm
+++ b/mumi/web/render.scm
@@ -103,12 +103,12 @@
 
 (define* (render-html sxml #:key (extra-headers '()))
   (values (append extra-headers
-                  '((content-type . (text/html))))
+                  '((content-type . (text/html (charset . "utf-8")))))
           (lambda (port)
             (sxml->html sxml port))))
 
 (define (render-json json)
-  (values '((content-type . (application/json)))
+  (values '((content-type . (application/json (charset . "utf-8"))))
           (lambda (port)
             (scm->json json port))))
 

base-commit: 99416ed5c7d950eaf54d52023a2efd975bccac92
-- 
2.41.0

Message #12 received at 70906-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 70906-done <at> debbugs.gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: Re: [PATCH] Send HTTP headers with charset utf-8.
Date: Fri, 07 Jun 2024 23:43:03 +0100

Applied, thanks!

I made the following modifications:
- The application/json MIME type does not require a charset. See
https://stackoverflow.com/questions/9254891/what-does-content-type-application-json-charset-utf-8-really-mean
So, I dropped that part.
- I removed the Content-Type meta tag from the HTML.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.