GNU logs - #70939, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 14 May 2024 14:06:01 +0000
Resent-Message-ID: <handler.70939.B.171569551021656 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70939 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Ankit Gadiya <ankit@HIDDEN>
Date: Tue, 14 May 2024 19:34:48 +0530
Message-ID: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000c7821c06186a7c4e"
Received-SPF: pass client-ip=2607:f8b0:4864:20::233;
 envelope-from=ankit@HIDDEN; helo=mail-oi1-x233.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--000000000000c7821c06186a7c4e
Content-Type: multipart/alternative; boundary="000000000000c7821a06186a7c4c"

--000000000000c7821a06186a7c4c
Content-Type: text/plain; charset="UTF-8"

Hello folks,

This patch adds two new commands for go-ts-mode to run unit test cases.

The go-ts-mode-test-package command can run all the tests under the package
of
the current buffer. I've tested it to work with both Go module packages and
non-module packages. This command is bound to C-c C-p in the go-ts-mode-map.

The go-ts-mode-test-function-at-point command runs the current test
function. If
region is active then it runs all the test functions under the region. I'm
attaching a sample_test.go file as well for reviewers to test the patch.
This
command is bound to C-c C-t in the go-ts-mode-map.

-- 
Ankit

--000000000000c7821a06186a7c4c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello folks,<br><br>This patch adds two new commands for g=
o-ts-mode to run unit test cases.<br><br>The go-ts-mode-test-package comman=
d can run all the tests under the package of<br>the current buffer. I&#39;v=
e tested it to work with both Go module packages and<br>non-module packages=
. This command is bound to C-c C-p in the go-ts-mode-map.<br><br>The go-ts-=
mode-test-function-at-point command runs the current test function. If<br>r=
egion is active then it runs all the test functions under the region. I&#39=
;m<br>attaching a sample_test.go file as well for reviewers to test the pat=
ch. This<br>command is bound to C-c C-t in the go-ts-mode-map.<br><br>-- <b=
r>Ankit</div>

--000000000000c7821a06186a7c4c--

--000000000000c7821c06186a7c4e
Content-Type: text/x-go; charset="US-ASCII"; name="sample_test.go"
Content-Disposition: attachment; filename="sample_test.go"
Content-Transfer-Encoding: base64
Content-ID: <f_lw6gqsm01>
X-Attachment-Id: f_lw6gqsm01

cGFja2FnZSBzYW1wbGVfdGVzdAoKaW1wb3J0ICJ0ZXN0aW5nIgoKZnVuYyBUZXN0SW5kaXZpZHVh
bCh0ICp0ZXN0aW5nLlQpIHsKCn0KCmZ1bmMgVGVzdE92ZXJsYXBSZWdpb24odCAqdGVzdGluZy5U
KSB7Cgp9Cg==
--000000000000c7821c06186a7c4e
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Disposition: attachment; 
	filename="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lw6gs9tk1>
X-Attachment-Id: f_lw6gs9tk1

RnJvbSA0OTg4ZWY0OTYyYzhmM2ZkZTBjYTBiZTdhMTQ4NTQ4OGM3ZGNhOTIzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmtpdCBSIEdhZGl5YSA8Z2l0QGFyZ3AuaW4+CkRhdGU6IFR1
ZSwgMTQgTWF5IDIwMjQgMDA6MTQ6MDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBBZGQgY29tbWFu
ZHMgdG8gcnVuIHVuaXQgdGVzdHMgaW4gZ28tdHMtbW9kZQoKLS0tCiBldGMvTkVXUyAgICAgICAg
ICAgICAgICAgICAgIHwgMTAgKysrKysrCiBsaXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIHwg
NjMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQs
IDcyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBi
L2V0Yy9ORVdTCmluZGV4IDM0MDUyNzY0ZjVmLi5iOWRmN2ZkY2FmMyAxMDA2NDQKLS0tIGEvZXRj
L05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTEyMzYsNiArMTIzNiwxNiBAQCBUaGlzIGNvbW1hbmQg
YWRkcyBhIGRvY3N0cmluZyBjb21tZW50IHRvIHRoZSBjdXJyZW50IGRlZnVuLiAgSWYgYQogY29t
bWVudCBhbHJlYWR5IGV4aXN0cywgcG9pbnQgaXMgb25seSBtb3ZlZCB0byB0aGUgY29tbWVudC4g
IEl0IGlzCiBib3VuZCB0byAnQy1jIEMtZCcgaW4gJ2dvLXRzLW1vZGUnLgogCisqKiogTmV3IHVu
aXQgdGVzdCBjb21tYW5kcy4KK1R3byBuZXcgY29tbWFuZHMgYXJlIG5vdyBhdmFpbGFibGUgdG8g
cnVuIHVuaXQgdGVzdHMuCisKK1RoZSAnZ28tdHMtbW9kZS10ZXN0LWZ1bmN0aW9uLWF0LXBvaW50
JyBjb21tYW5kIHJ1bnMgdW5pdCB0ZXN0IGF0Citwb2ludC4gSWYgYSByZWdpb24gaXMgYWN0aXZl
LCBpdCBydW5zIGFsbCB0aGUgdW5pdCB0ZXN0cyB1bmRlciB0aGUKK3JlZ2lvbi4gSXQgaXMgYm91
bmQgdG8gJ0MtYyBDLXQnIGluICdnby10cy1tb2RlJy4KKworVGhlICdnby10cy1tb2RlLXRlc3Qt
cGFja2FnZScgY29tbWFuZCBydW5zIGFsbCB1bml0IHRlc3RzIHVuZGVyIHRoZQorcGFja2FnZSBv
ZiB0aGUgY3VycmVudCBidWZmZXIuIEl0IGlzIGJvdW5kIHRvICdDLWMgQy1wJyBpbiAnZ28tdHMt
bW9kZScuCisKICoqIE1hbiBtb2RlCiAKICsrKwpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMv
Z28tdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKaW5kZXggYWVmMjI0
YWIzZmEuLjU1NDBkZGI2MWU2IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2Rl
LmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKQEAgLTIzNyw3ICsyMzcsOSBA
QCBnby10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MKIChkZWZ2YXIta2V5bWFwIGdvLXRzLW1v
ZGUtbWFwCiAgIDpkb2MgIktleW1hcCB1c2VkIGluIEdvIG1vZGUsIHBvd2VyZWQgYnkgdHJlZS1z
aXR0ZXIiCiAgIDpwYXJlbnQgcHJvZy1tb2RlLW1hcAotICAiQy1jIEMtZCIgIydnby10cy1tb2Rl
LWRvY3N0cmluZykKKyAgIkMtYyBDLWQiICMnZ28tdHMtbW9kZS1kb2NzdHJpbmcKKyAgIkMtYyBD
LXQiICMnZ28tdHMtbW9kZS10ZXN0LWZ1bmN0aW9uLWF0LXBvaW50CisgICJDLWMgQy1wIiAjJ2dv
LXRzLW1vZGUtdGVzdC1wYWNrYWdlKQogCiA7OzsjIyNhdXRvbG9hZAogKGRlZmluZS1kZXJpdmVk
LW1vZGUgZ28tdHMtbW9kZSBwcm9nLW1vZGUgIkdvIgpAQCAtMzcwLDYgKzM3Miw2NSBAQCBnby10
cy1tb2RlLS1jb21tZW50LW9uLXByZXZpb3VzLWxpbmUtcAogICAgICAoPD0gKHRyZWVzaXQtbm9k
ZS1zdGFydCBub2RlKSBwb2ludCAodHJlZXNpdC1ub2RlLWVuZCBub2RlKSkKICAgICAgKHN0cmlu
Zy1lcXVhbCAiY29tbWVudCIgKHRyZWVzaXQtbm9kZS10eXBlIG5vZGUpKSkpKQogCisoZGVmdW4g
Z28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZyAoKQorICAiUmV0dXJuIGNvbXBpbGUgZmxh
ZyBmb3IgYnVpbGQgdGFncy4KK1RoaXMgZnVuY3Rpb24gcmVzcGVjdHMgYGdvLWJ1aWxkLXRhZ3Mn
IGJ1ZmZlci1sb2NhbCB2YXJpYWJsZSBmb3IKK3NwZWNpZnlpbmcgYnVpbGQgdGFncy4iCisgIChp
ZiAobG9jYWwtdmFyaWFibGUtcCAnZ28tYnVpbGQtdGFncykKKyAgICAgIChmb3JtYXQgIi10YWdz
ICVzIiBnby1idWlsZC10YWdzKQorICAgICIiKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtLWNvbXBp
bGUtdGVzdCAocmVnZXhwKQorICAiQ29tcGlsZXMgdGhlIHRlc3RzIG1hdGNoaW5nIFJFR0VYUC4K
K1RoaXMgZnVuY3Rpb24gcmVzcGVjdHMgYGdvLWJ1aWxkLXRhZ3MnIGJ1ZmZlci1sb2NhbCB2YXJp
YWJsZSBmb3IKK3NwZWNpZnlpbmcgYnVpbGQgdGFncy4iCisgIChjb21waWxlIChmb3JtYXQgImdv
IHRlc3QgLXYgJXMgLXJ1biAnJXMnIgorICAgICAgICAgICAgICAgICAgIChnby10cy1tb2RlLS1n
ZXQtYnVpbGQtdGFncy1mbGFnKQorICAgICAgICAgICAgICAgICAgIHJlZ2V4cCkpKQorCisoZGVm
dW4gZ28tdHMtbW9kZS0tZmluZC1kZWZ1bi1hdCAoc3RhcnQpCisgICJSZXR1cm4gdGhlIGZpcnN0
IGRlZnVuIG5vZGUgZnJvbSBTVEFSVC4iCisgIChsZXQgKCh0aGluZyAob3IgdHJlZXNpdC1kZWZ1
bi10eXBlLXJlZ2V4cCAnZGVmdW4pKSkKKyAgICAob3IgKHRyZWVzaXQtdGhpbmctYXQgc3RhcnQg
dGhpbmcpCisgICAgICAgICh0cmVlc2l0LXRoaW5nLW5leHQgc3RhcnQgdGhpbmcpKSkpCisKKyhk
ZWZ1biBnby10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlIChzdGFydCBlbmQpCisgICJS
ZXR1cm4gYSBsaXN0IHdpdGggbmFtZXMgb2YgYWxsIGRlZnVucyBpbiB0aGUgcmFuZ2UuIgorICAo
bGV0KiAoKG5vZGUgKGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQgc3RhcnQpKQorCSAobmFtZSAo
dHJlZXNpdC1kZWZ1bi1uYW1lIG5vZGUpKQorICAgICAgICAgKG5vZGUtc3RhcnQgKHRyZWVzaXQt
bm9kZS1zdGFydCBub2RlKSkKKyAgICAgICAgIChub2RlLWVuZCAodHJlZXNpdC1ub2RlLWVuZCBu
b2RlKSkpCisgICAgKGlmIChvciAobm90IG5vZGUpCisgICAgICAgICAgICAoPiBzdGFydCBub2Rl
LWVuZCkKKwkgICAgKDwgZW5kIG5vZGUtc3RhcnQpKQorCW5pbAorICAgICAgKGNvbnMgbmFtZSAo
Z28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9ucy1pbi1yYW5nZSAodHJlZXNpdC1ub2RlLWVuZCBub2Rl
KSBlbmQpKSkpKQorCisoZGVmdW4gZ28tdHMtbW9kZS0tZ2V0LXRlc3QtcmVnZXhwLWF0LXBvaW50
ICgpCisgICJSZXR1cm4gYSByZWd1bGFyIGV4cHJlc3Npb24gZm9yIHRlc3RzIGF0IHBvaW50Lgor
SWYgcmVnaW9uIGlzIGFjdGl2ZSwgdGhlIHJlZ2V4cCB3aWxsIGluY2x1ZGUgYWxsIHRoZSBmdW5j
dGlvbnMgdW5kZXIgdGhlCityZWdpb24uIgorICAoaWYgKHJlZ2lvbi1hY3RpdmUtcCkKKyAgICAg
IChzdHJpbmctam9pbiAoZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9ucy1pbi1yYW5nZSAocmVnaW9u
LWJlZ2lubmluZykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAocmVnaW9uLWVuZCkpCisgICAgICAgICAgICAgICAgICAgInwiKQorICAgICh0
cmVlc2l0LWRlZnVuLW5hbWUgKHRyZWVzaXQtZGVmdW4tYXQtcG9pbnQpKSkpCisKKyhkZWZ1biBn
by10cy1tb2RlLXRlc3QtZnVuY3Rpb24tYXQtcG9pbnQgKCkKKyAgIlJ1biB0aGUgdW5pdCB0ZXN0
IGF0IHBvaW50LgorSWYgdGhlIHBvaW50IGlzIGFueXdoZXJlIGluIHRoZSB0ZXN0IGZ1bmN0aW9u
LCB0aGF0IGZ1bmN0aW9uIHdpbGwgYmUKK3Rlc3RlZC4gIElmIHRoZSByZWdpb24gaXMgc2VsZWN0
ZWQsIGFsbCB0aGUgZnVuY3Rpb25zIHVuZGVyIHRoZSByZWdpb24KK3dpbGwgYmUgcnVuLiIKKyAg
ICAoaW50ZXJhY3RpdmUpCisgICAgKGdvLXRzLW1vZGUtLWNvbXBpbGUtdGVzdCAoZ28tdHMtbW9k
ZS0tZ2V0LXRlc3QtcmVnZXhwLWF0LXBvaW50KSkpCisKKyhkZWZ1biBnby10cy1tb2RlLXRlc3Qt
cGFja2FnZSAoKQorICAiUnVuIGFsbCB0aGUgdW5pdCB0ZXN0cyB1bmRlciBjdXJyZW50IHBhY2th
Z2UuIgorICAoaW50ZXJhY3RpdmUpCisgIChjb21waWxlIChmb3JtYXQgImdvIHRlc3QgLXYgJXMg
LXJ1biAlcyIKKyAgICAgICAgICAgICAgICAgICAoZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3Mt
ZmxhZykKKyAgICAgICAgICAgICAgICAgICBkZWZhdWx0LWRpcmVjdG9yeSkpKQorCiA7OyBnby5t
b2Qgc3VwcG9ydC4KIAogKGRlZnZhciBnby1tb2QtdHMtbW9kZS0tc3ludGF4LXRhYmxlCi0tIAoy
LjM5LjIKCg==
--000000000000c7821c06186a7c4e--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ankit Gadiya <ankit@HIDDEN>
Subject: bug#70939: Acknowledgement ([PATCH] Add commands to run unit
 tests in go-ts-mode)
Message-ID: <handler.70939.B.171569551021656.ack <at> debbugs.gnu.org>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
X-Gnu-PR-Message: ack 70939
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 70939 <at> debbugs.gnu.org
Date: Tue, 14 May 2024 14:06:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 70939 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70939: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70939
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 14 May 2024 16:53:01 +0000
Resent-Message-ID: <handler.70939.B70939.17157055567206 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ankit Gadiya <ankit@HIDDEN>, Randy Taylor <dev@HIDDEN>
Cc: 70939 <at> debbugs.gnu.org
Date: Tue, 14 May 2024 19:52:21 +0300
Message-Id: <86y18cuyii.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 (bug-gnu-emacs@HIDDEN)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Tue, 14 May 2024 19:34:48 +0530
> From:  Ankit Gadiya via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> Hello folks,
> 
> This patch adds two new commands for go-ts-mode to run unit test cases.
> 
> The go-ts-mode-test-package command can run all the tests under the package of
> the current buffer. I've tested it to work with both Go module packages and
> non-module packages. This command is bound to C-c C-p in the go-ts-mode-map.
> 
> The go-ts-mode-test-function-at-point command runs the current test function. If
> region is active then it runs all the test functions under the region. I'm
> attaching a sample_test.go file as well for reviewers to test the patch. This
> command is bound to C-c C-t in the go-ts-mode-map.

Thanks.

Randy, any comments about this?

Ankit, we'd need a copyright assignment from you to accept a large
contribution such as this one.  Would you like to start the assignment
paperwork at this time?  If yes, I will send you the form to fill and
the instructions to go with it.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 14 May 2024 17:26:01 +0000
Resent-Message-ID: <handler.70939.B70939.17157075459238 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Randy Taylor <dev@HIDDEN>, 70939 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86y18cuyii.fsf@HIDDEN>
In-Reply-To: <86y18cuyii.fsf@HIDDEN>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Tue, 14 May 2024 22:54:22 +0530
Message-ID: <CAN7zea2RZOO2UcWiwaLp8LxqFLPiUKpFk__7AJiGsc7=kczbRw@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000007e350b06186d4608"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--0000000000007e350b06186d4608
Content-Type: text/plain; charset="UTF-8"

>
> Ankit, we'd need a copyright assignment from you to accept a large
> contribution such as this one.  Would you like to start the assignment
> paperwork at this time?  If yes, I will send you the form to fill and
> the instructions to go with it.
>

Hello Eli, I've already sent the form to assign@HIDDEN following the
instructions in the CONTRIBUTE file.

--
Ankit

--0000000000007e350b06186d4608
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">Ankit, we&#39;d need a copyright assignment from you to =
accept a large<br>
contribution such as this one.=C2=A0 Would you like to start the assignment=
<br>
paperwork at this time?=C2=A0 If yes, I will send you the form to fill and<=
br>
the instructions to go with it.<br>
</blockquote></div><div><br></div>Hello Eli, I&#39;ve already sent the form=
 to <a href=3D"mailto:assign@HIDDEN">assign@HIDDEN</a> following the<br>i=
nstructions in the CONTRIBUTE file.<br><div><br></div><div>--<br></div><div=
 dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Ankit</div></div></=
div>

--0000000000007e350b06186d4608--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 14 May 2024 18:00:01 +0000
Resent-Message-ID: <handler.70939.B70939.171570959511164 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: dev@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171570959511164
          (code B ref 70939); Tue, 14 May 2024 18:00:01 +0000
Received: (at 70939) by debbugs.gnu.org; 14 May 2024 17:59:55 +0000
Received: from localhost ([127.0.0.1]:40634 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s6wRP-0002u0-A2
	for submit <at> debbugs.gnu.org; Tue, 14 May 2024 13:59:55 -0400
Received: from eggs.gnu.org ([209.51.188.92]:59554)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1s6wRK-0002tr-D7
 for 70939 <at> debbugs.gnu.org; Tue, 14 May 2024 13:59:54 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1s6wRC-0008RJ-Ni; Tue, 14 May 2024 13:59:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=a2htDGSSAtrf2M1VWLphOD9GzA4E/h7zorfnXP8ah50=; b=sE2y85P4GXzm
 jsiPqYPfjgb19O1YYDgYrkpLWCP32z3WN6sb3IgLZDVGmyLMTlPLxfgqc4tsJck4x09HISNYS46Zx
 7CIzION0Z49/AyYvfOgYxwwcU2qUYk3acYaDJtYtRPWvSYciIW5eaSE4SX5Sa2lUsi6w8TdwZdpzD
 pgWZBX1TM3YuCUZz5B+weVYMC88Hh8uTJwNUpYrgVAw52zYLWfcBObcxEqMgktF3dp4WZVztZikoF
 nPOzkKXFsNF5SGPqUj4D6o21JSnkAW/VO1VVuEgVmohK2ZGeG5cAJ5Yq1CEmq6pcRBWYk+yySvkto
 T5mA6oLkfwFavjXxlGz3sg==;
Date: Tue, 14 May 2024 20:59:08 +0300
Message-Id: <86ikzguvf7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAN7zea2RZOO2UcWiwaLp8LxqFLPiUKpFk__7AJiGsc7=kczbRw@HIDDEN>
 (message from Ankit Gadiya on Tue, 14 May 2024 22:54:22 +0530)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86y18cuyii.fsf@HIDDEN>
 <CAN7zea2RZOO2UcWiwaLp8LxqFLPiUKpFk__7AJiGsc7=kczbRw@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Ankit Gadiya <ankit@HIDDEN>
> Date: Tue, 14 May 2024 22:54:22 +0530
> Cc: Randy Taylor <dev@HIDDEN>, 70939 <at> debbugs.gnu.org
> 
>  Ankit, we'd need a copyright assignment from you to accept a large
>  contribution such as this one.  Would you like to start the assignment
>  paperwork at this time?  If yes, I will send you the form to fill and
>  the instructions to go with it.
> 
> Hello Eli, I've already sent the form to assign@HIDDEN following the
> instructions in the CONTRIBUTE file.

Great, thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 15 May 2024 02:37:01 +0000
Resent-Message-ID: <handler.70939.B70939.171574059324994 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171574059324994
          (code B ref 70939); Wed, 15 May 2024 02:37:01 +0000
Received: (at 70939) by debbugs.gnu.org; 15 May 2024 02:36:33 +0000
Received: from localhost ([127.0.0.1]:41691 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s74VM-0006V4-NB
	for submit <at> debbugs.gnu.org; Tue, 14 May 2024 22:36:33 -0400
Received: from mail-40136.proton.ch ([185.70.40.136]:48661)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1s74VH-0006Uv-Ga
 for 70939 <at> debbugs.gnu.org; Tue, 14 May 2024 22:36:31 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1715740580; x=1715999780;
 bh=Rca3skJjF1muQVV92i/xeyxyT7akf8cFiWM42c/140M=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=RmsysIW2Hmzrq7GJ7QTKIfp/Vbqy7oX3o6WhUNQDW4lntC9EczY6iPo0wq8tW6rez
 /QYfg82/RWvSuR/xY0Nj3HCNS0EtcJ5v/qH9Obb1FD9fhtQnvcAT1LmeMJfhs6+B19
 lYFtE+DYGXm2lYdFMeN9gZ6n8Rthcc3jKbpzWzlFvjJY5gLiTuc4ylsTCKjF33cdzx
 AaT3OnF0KQVDga3TdQK+cW07l1mo5fI3KuTXylgXYyZ2j0pDzE2Poz10un6V4YF46w
 x58gYtjiE2YPB2u8liBfAxGqCD2YXYCaHamgB3aE/uSd55bS86ehjWp0v6EZtOskEe
 3R1hkHiRXT35w==
Date: Wed, 15 May 2024 02:36:15 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
In-Reply-To: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 459e439fde3d352b3f5d45d27e023795801f6889
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Tuesday, May 14th, 2024 at 10:04, Ankit Gadiya via "Bug reports for GNU =
Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> wrote:
> Hello folks,
>=20
> This patch adds two new commands for go-ts-mode to run unit test cases.
>=20
> The go-ts-mode-test-package command can run all the tests under the packa=
ge of
> the current buffer. I've tested it to work with both Go module packages a=
nd
> non-module packages. This command is bound to C-c C-p in the go-ts-mode-m=
ap.
>=20
> The go-ts-mode-test-function-at-point command runs the current test funct=
ion. If
> region is active then it runs all the test functions under the region. I'=
m
> attaching a sample_test.go file as well for reviewers to test the patch. =
This
> command is bound to C-c C-t in the go-ts-mode-map.
>=20
> --
> Ankit

Thanks for working on this, it would certainly be a nice addition.

This is going to need a commit log entry. See the "Commit messages" section
in the CONTRIBUTING file.

I'm undecided on the keybinds. I think I would prefer something like:
C-c t p
or
C-c C-t p
so we can keep test-related things together.

I haven't tried this out yet, but here are some comments (mostly nits)
after a quick look:

In NEWS, sentences should be separated by 2 spaces.

+The 'go-ts-mode-test-function-at-point' command runs unit test at
                                                     ^the
+point.

+This function respects `go-build-tags' buffer-local variable
                       ^the

+  "Compiles the tests matching REGEXP.
    ^Compile

+If the point is anywhere in the test function, that function will be
+tested.
^ run (keeps it consistent with the next sentence)

+  "Run all the unit tests under current package."
                                ^the

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 15 May 2024 04:58:02 +0000
Resent-Message-ID: <handler.70939.B70939.171574903931172 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171574903931172
          (code B ref 70939); Wed, 15 May 2024 04:58:02 +0000
Received: (at 70939) by debbugs.gnu.org; 15 May 2024 04:57:19 +0000
Received: from localhost ([127.0.0.1]:41723 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s76hb-00086i-Cv
	for submit <at> debbugs.gnu.org; Wed, 15 May 2024 00:57:19 -0400
Received: from mail-vs1-f47.google.com ([209.85.217.47]:52381)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1s76hU-00086X-PU
 for 70939 <at> debbugs.gnu.org; Wed, 15 May 2024 00:57:16 -0400
Received: by mail-vs1-f47.google.com with SMTP id
 ada2fe7eead31-47eee2a2a87so1831083137.0
 for <70939 <at> debbugs.gnu.org>; Tue, 14 May 2024 21:57:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1715748965; x=1716353765; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=LxyO/SEdlzP7ANlV1wk0Dn5dFi/N/iTDmA0TT5/Kk98=;
 b=N440brULGW4YC5YwhyfLEoEkLTM0jIrF0Eb2GfmBD7Npo0VNGsa1pusAofXkuBQ9Fp
 JL5YfZZm5NjQrbpU0GqdNflr9UHhj2b2zTEPvafxZ2H+j864DSq/JacsiqZUpKJ7xaey
 ZpFlo3S21gkiNWvuQ3YCgVfKDQdyzAEpXq4Lq/1KwWzaoy4qauMIKKoofYo0XcdpvenC
 tuND2nBX5Jlan95auTEhNHsNWJOPCqM83/5fraJBzcS6A+HqrvA2vGNlxnYZf10Qo9LH
 gYDmXF206Xk4g68t6JztaNTUl3vzXkHmZz+lXW3lUkDeT6gGm3PRT+0EMW0FBZ+FmPg+
 8AKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1715748965; x=1716353765;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=LxyO/SEdlzP7ANlV1wk0Dn5dFi/N/iTDmA0TT5/Kk98=;
 b=Y6pRjdLoirtWHqcq6cCNXMeHOrCtzdJdzDFxYi42OYjXUJENQAaR7RlSY5FMZTpeq5
 uqrl9JyptLH3B+6xjtikwC8dNbMA9XNorlBj4QT/XKCjTOpTGkgr3Rcw8wVB10rywa8Y
 Qeb6PnqgKX4rfMXPwxajF+hZQPSl3plAJRrVY0kmajIEcTo91IWLCN9JtYZQohGeOVkd
 2y45F0Bc7C2N5jk57Hlh+Ot/SDN/r2vh0Gvnidqas1ntebwCZ0Vd98rGqKYUaP4+81Ee
 oQ33KwxyNV6I20cvi2zvt4ZfUp8RsckWAQpaf0Prw1oFM29uhBboR8Mckqg6An7HA7Jq
 uy5Q==
X-Gm-Message-State: AOJu0YxVb0z0pcu+ZuR/9TK64E3UMjISNUCYW9XjqS1UjPvYfCEr18Ku
 E3EeeVs4AhxIO8abOUNo4CDtXWRhNYJ3iCbV4A+acsILd/T91rEjltjQ59dddydiv54i7ao+a5Y
 v1qI3X/CqpwzKmaUQy9vs5nmqRG0DQ4SMY4QVWSggmSNg73oJOTytYQ==
X-Google-Smtp-Source: AGHT+IGb/SIyStmmDNJFnK/NVT0v7SkWZxgehRfhWmkEwhXisVWXp2JimQfNMNNae20hjCVv8H3xh6le42o7Axw7Uw4=
X-Received: by 2002:a05:6102:f8b:b0:480:77c8:8d94 with SMTP id
 ada2fe7eead31-48077dce19emr16365264137.1.1715748965501; Tue, 14 May 2024
 21:56:05 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
In-Reply-To: <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Wed, 15 May 2024 10:25:55 +0530
Message-ID: <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> This is going to need a commit log entry. See the "Commit messages" section
> in the CONTRIBUTING file.

I missed it earlier, will add it.

> I'm undecided on the keybinds. I think I would prefer something like:
> C-c t p
> or
> C-c C-t p
> so we can keep test-related things together.

Keeping it under C-c C-t makes sense to me. How about this:

C-c C-t t - go-ts-mode-test-function-at-point
C-c C-t p - go-ts-mode-test-package

> I haven't tried this out yet, but here are some comments (mostly nits)
> after a quick look:
>
> In NEWS, sentences should be separated by 2 spaces.
>
> +The 'go-ts-mode-test-function-at-point' command runs unit test at
>                                                      ^the
> +point.
>
> +This function respects `go-build-tags' buffer-local variable
>                        ^the
>
> +  "Compiles the tests matching REGEXP.
>     ^Compile
>
> +If the point is anywhere in the test function, that function will be
> +tested.
> ^ run (keeps it consistent with the next sentence)
>
> +  "Run all the unit tests under current package."
>                                 ^the

Thanks, I'll update this along with keybinding changes.

-- 
Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 15 May 2024 11:23:02 +0000
Resent-Message-ID: <handler.70939.B70939.171577212420427 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: ankit@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171577212420427
          (code B ref 70939); Wed, 15 May 2024 11:23:02 +0000
Received: (at 70939) by debbugs.gnu.org; 15 May 2024 11:22:04 +0000
Received: from localhost ([127.0.0.1]:42098 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s7Chw-0005JP-Dk
	for submit <at> debbugs.gnu.org; Wed, 15 May 2024 07:22:04 -0400
Received: from eggs.gnu.org ([209.51.188.92]:41928)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1s7Cht-0005Io-FE
 for 70939 <at> debbugs.gnu.org; Wed, 15 May 2024 07:22:02 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1s7Chl-0004di-G9; Wed, 15 May 2024 07:21:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=kmf9zEFIn/6RKiJNHiDZ80f6FF2SHnuZ4uFbU8fLOQM=; b=h8kZkmBW3h2o
 JC6SZQkFFU3I1EchR8rrhOyW21n5UcZKw4ozq/UcIjiWlW3pdHForj4M0bOZFBhtftyAuncVW+iov
 lXDOccRK9E0FGj/O/voe/R6OVu9pdWxlR2UCFrvB3lHfj8On9lQADx3mz7iLO0e4HtIzMpgMf8/Yz
 oPKxHtM5bbygg6u9VAjxzNs1l7IS2lOPKgrdTdlcaMArdKCciMLdoTCoEYh5uMWzPJ1B7V7RXDJmy
 iX91VORFOCUWxAiE1U/PmoSqydMs+Kti6UAoQmskee4QXviKBKj56NUFJJLD2aOIFrseZqjDmUtcQ
 9uvLideV/zMeNJShkQrdxw==;
Date: Wed, 15 May 2024 14:21:43 +0300
Message-Id: <868r0buxq0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 (message from Randy Taylor on Wed, 15 May 2024 02:36:15 +0000)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 15 May 2024 02:36:15 +0000
> From: Randy Taylor <dev@HIDDEN>
> Cc: 70939 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
> 
> I'm undecided on the keybinds. I think I would prefer something like:
> C-c t p
> or
> C-c C-t p
> so we can keep test-related things together.

In general, key bindings that begin with "C-c" and a letter are
reserved for users.  So the second alternative is preferred.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 16 May 2024 01:25:01 +0000
Resent-Message-ID: <handler.70939.B70939.17158227018833 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: ankit@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17158227018833
          (code B ref 70939); Thu, 16 May 2024 01:25:01 +0000
Received: (at 70939) by debbugs.gnu.org; 16 May 2024 01:25:01 +0000
Received: from localhost ([127.0.0.1]:45564 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s7Prg-0002IP-J5
	for submit <at> debbugs.gnu.org; Wed, 15 May 2024 21:25:00 -0400
Received: from mail-4018.proton.ch ([185.70.40.18]:42513)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1s7Prf-0002IF-65
 for 70939 <at> debbugs.gnu.org; Wed, 15 May 2024 21:24:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1715822690; x=1716081890;
 bh=Zi5wBrXCSqCgKXEalmJlJaPnkV3DA4/6lBfCtkACrvA=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=E+zP0scdhSg87U2jTswept13xur1cmDFHNw1KfZsVEKF71kqzdDIWIeYaVXABQ5C/
 nTHGIrViqARDGRKLnWs5hDBGmvADGA1Of10K2+QKVHkF0VuHpZpLbuiHqC3+oG6QIx
 ia/ALmcOiWARKX7+3tYz4Xa0uF7VEVqTeB+vUYiHOExOQjbd9KI9Lq1FnRcEBCi1ON
 hsHQPO4Mpq8YoDjJoQ38Vocyb7trQKDQ5Flq9zGXT3oAZukOQ3KY+pIohyF54yoO3x
 CQ0OxJhJfh9zYn/91kkjXA3RhN28fEJ4AZmNWMagVSvpB62bEEV4+3LusgiQJfunL1
 T+RExKmDHazWQ==
Date: Thu, 16 May 2024 01:24:46 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <HuXF_AKnwqa2eNYszcvYzd5reQRuFApKc3TvtQ8YRkEQYbGUVaq8tgKz1lQhbPL0CrkXGwVG5CgjVzIwUbOXRI9WSKUxoUHQTMDAE8Y4-HM=@rjt.dev>
In-Reply-To: <868r0buxq0.fsf@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <868r0buxq0.fsf@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 95cb814dbd01b9259430b5c7f97c7f49b857db28
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wednesday, May 15th, 2024 at 07:21, Eli Zaretskii <eliz@HIDDEN> wrote:
>=20
>=20
> > Date: Wed, 15 May 2024 02:36:15 +0000
>=20
> > From: Randy Taylor dev@HIDDEN
> > Cc: 70939 <at> debbugs.gnu.org, Eli Zaretskii eliz@HIDDEN
> >=20
> > I'm undecided on the keybinds. I think I would prefer something like:
> > C-c t p
> > or
> > C-c C-t p
> > so we can keep test-related things together.
>=20
>=20
> In general, key bindings that begin with "C-c" and a letter are
> reserved for users. So the second alternative is preferred.

Noted, thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 16 May 2024 02:33:02 +0000
Resent-Message-ID: <handler.70939.B70939.171582677613210 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171582677613210
          (code B ref 70939); Thu, 16 May 2024 02:33:02 +0000
Received: (at 70939) by debbugs.gnu.org; 16 May 2024 02:32:56 +0000
Received: from localhost ([127.0.0.1]:45833 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s7QvP-0003R0-Ll
	for submit <at> debbugs.gnu.org; Wed, 15 May 2024 22:32:55 -0400
Received: from mail-4018.proton.ch ([185.70.40.18]:34597)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1s7QvN-0003Qo-8x
 for 70939 <at> debbugs.gnu.org; Wed, 15 May 2024 22:32:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1715826765; x=1716085965;
 bh=uzRbNQoo6jtTTj+zShutrp6wHFDPANfJyk8KJ05KUsM=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=KiOG2jOawHHDpAhONzeWY4kmLC541J5XGNA5GXBLytxH1EIHphG5gtsO8HcS7wloC
 MC+kU22bhPQgeVwz3+5HvUV7pu9gGxiQfx/fqEseQc7EnMcdm6Z6cHbbLZzz74JtKC
 Bgpw5FirczwmV64ZXVUjRchMa7Sjbz1vXg0CC7FxFy0lue5h4HpGw8bVSTd+8JfvPr
 phxNqhJh4OoRr7iZympNFcSCEEROTZpn/ElfTV0IWYpdCF3aPy+4sh1pVMxTfIwwqR
 ZvXCB8y7h6ue92+G3eARsXAMHIGd9EOSwL89IL1gwvjXVyhYZiwO2so1LrsT7vnzmR
 PE4G9P9vId+3A==
Date: Thu, 16 May 2024 02:32:42 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
In-Reply-To: <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: e77519f380b90caf89a7e1cb47388e3402b00ba5
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wednesday, May 15th, 2024 at 00:55, Ankit Gadiya <ankit@HIDDEN> wrote:
>=20
>=20
> > This is going to need a commit log entry. See the "Commit messages" sec=
tion
>=20
> > in the CONTRIBUTING file.
>=20
>=20
> I missed it earlier, will add it.
>=20
> > I'm undecided on the keybinds. I think I would prefer something like:
> > C-c t p
> > or
> > C-c C-t p
> > so we can keep test-related things together.
>=20
>=20
> Keeping it under C-c C-t makes sense to me. How about this:
>=20
> C-c C-t t - go-ts-mode-test-function-at-point
> C-c C-t p - go-ts-mode-test-package

Sounds good.

I'm wondering If C-c C-t t should be f for "function" but let's leave it as=
 t for now. I do like the t for test which is nice and simple. Decisions, d=
ecisions...

>=20
> > I haven't tried this out yet, but here are some comments (mostly nits)
> > after a quick look:
> >=20
> > In NEWS, sentences should be separated by 2 spaces.
> >=20
> > +The 'go-ts-mode-test-function-at-point' command runs unit test at
> > ^the
> > +point.
> >=20
> > +This function respects `go-build-tags' buffer-local variable
> > ^the
> >=20
> > + "Compiles the tests matching REGEXP.
> > ^Compile
> >=20
> > +If the point is anywhere in the test function, that function will be
> > +tested.
> > ^ run (keeps it consistent with the next sentence)
> >=20
> > + "Run all the unit tests under current package."
> > ^the
>=20
>=20
> Thanks, I'll update this along with keybinding changes.

Great. I'll try to give this a try tomorrow.

Eli, is there a convention regarding local variables?
In the patch we have:
+  (if (local-variable-p 'go-build-tags)
+      (format "-tags %s" go-build-tags)
+    ""))

Should that local variable be prefixed with go-ts-mode, or is it fine as is=
?

>=20
> --
> Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 16 May 2024 08:28:01 +0000
Resent-Message-ID: <handler.70939.B70939.171584807831382 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: ankit@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171584807831382
          (code B ref 70939); Thu, 16 May 2024 08:28:01 +0000
Received: (at 70939) by debbugs.gnu.org; 16 May 2024 08:27:58 +0000
Received: from localhost ([127.0.0.1]:47439 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s7WSz-0008A6-NL
	for submit <at> debbugs.gnu.org; Thu, 16 May 2024 04:27:57 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60634)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1s7WSx-0008A0-4a
 for 70939 <at> debbugs.gnu.org; Thu, 16 May 2024 04:27:56 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1s7WSp-0000cU-6M; Thu, 16 May 2024 04:27:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Pz6dWy9olH6EsvixKa1KSJyZ5JQmNGk+Bbdx0Pz1Lac=; b=XvntgjD3Qa+o
 t8q9BuUyvT/GSaynlivERLjBPMIoM23Uty1uv0OlBZMhDQzlqw1RurMeWMqFCKzJYdILDmH4vqv1S
 TytrK8lOuT7ioQhsWnnyWIvLvZ6n7CYzkaPAM20cgjIzwVbNS8G29ZLcASAGDbT5oKk5vEltYdP1h
 j1zR4FGZB1ts1SRS+ApLjjztRT409fzC1CbnvA+iJKUZTHBoX05VXPtNdYrV6akYCWcU5WillUyTG
 hMDRsWagODKcDNs7u/7C89fT30HU8LrAoOFDE/8ka7fy9aHH1kLrI3AvKxajk3/5W4uPn3Q7b7dbF
 zadIWup8L5JYc2PD+HCBJA==;
Date: Thu, 16 May 2024 11:27:20 +0300
Message-Id: <868r0ajh5j.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 (message from Randy Taylor on Thu, 16 May 2024 02:32:42 +0000)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 16 May 2024 02:32:42 +0000
> From: Randy Taylor <dev@HIDDEN>
> Cc: 70939 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
> 
> Eli, is there a convention regarding local variables?
> In the patch we have:
> +  (if (local-variable-p 'go-build-tags)
> +      (format "-tags %s" go-build-tags)
> +    ""))
> 
> Should that local variable be prefixed with go-ts-mode, or is it fine as is?

If the variable is specific to go-ts-mode, it should indeed be
prefixed with "go-ts-".  But I don't see this variable in
go-ts-mode.el nor in the patch (did I miss something?), and I don't
understand why the above condition insists on using only a
buffer-local value of the variable in the first place?  What's wrong
with having a global value for the variable?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 16 May 2024 15:05:01 +0000
Resent-Message-ID: <handler.70939.B70939.171587189629705 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Randy Taylor <dev@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171587189629705
          (code B ref 70939); Thu, 16 May 2024 15:05:01 +0000
Received: (at 70939) by debbugs.gnu.org; 16 May 2024 15:04:56 +0000
Received: from localhost ([127.0.0.1]:49200 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s7cf9-0007j3-Ol
	for submit <at> debbugs.gnu.org; Thu, 16 May 2024 11:04:56 -0400
Received: from mail-oi1-f174.google.com ([209.85.167.174]:60448)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1s7cf5-0007ix-LO
 for 70939 <at> debbugs.gnu.org; Thu, 16 May 2024 11:04:54 -0400
Received: by mail-oi1-f174.google.com with SMTP id
 5614622812f47-3c9c36db8eeso194245b6e.0
 for <70939 <at> debbugs.gnu.org>; Thu, 16 May 2024 08:04:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1715871824; x=1716476624; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=Jkpo/tSIyka2BXF5p3dwuSEL/A3MPNpusrzpnv/iqEk=;
 b=fSC8Mrsaw/gveaKa2m+qpwqDygSAPERrKTCjqrWflbsVzpMwCBKlaYo3/VBnJboGxJ
 3yL4etoWAsF5JTSvcg73t29uriKR0TFa69Pd4qXlWXvhaK0dqgJI6es9ddt+alPVd9nE
 XXJoi4GkLRTw1VerI0VIQI957XUtdbS/Jo81tk6EgP7MMezMkk81pQXoWJukCoDyogZ/
 7IfI6/HOFPOo5F3rv3802bIWluKVhSCbHXblJvCloQ8n7IyPSs3+R6OHDqHgwyKFuArj
 IEFAAgsBbXEI8XZz5jR2hdvZhIly2Vb/PeM9rQvJ2MSIDYMEtYGigfOAs6ARWjtHjFNR
 A2FQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1715871824; x=1716476624;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=Jkpo/tSIyka2BXF5p3dwuSEL/A3MPNpusrzpnv/iqEk=;
 b=QXzfk8qNzb8H7tolD5DjISVcil/zKxFAny1ibZQE7IQt9fGqtRcYtZoSSczulI0fEs
 oqlgrns7Ukq2RTnVBLeaLnwqaX9EvsaH5iR0DWbO4+lQKaRQ1dCgzkeuErp6EX/EAdem
 mJmDvJe43N3hbfyuypb4dteIJ5RWuUtvI9NUAVGDzRpD6U0XWW6HEmmFNiEb0td3hioK
 Fgf/CrNTyCXfYkhjMRT2sYYAzSrQjGbgICZEoLMfBC6/R+bLlxu9VwgKoc1m8X4JfBkQ
 pnkbDBp/fedB5KK4fQPW0rZeh5e9GaSgJEXG7HtrSfLu3u87mVAPnWMOBIAjLUqhabm4
 Mcfw==
X-Forwarded-Encrypted: i=1;
 AJvYcCWjDVkDVRiwQ9YHrA8KzCD0OMHfwq+7FxxdmCDTcw6M5Eg8/OWPKBJ+f3e1ujwyLSaTO8IQ4ImZh1PXCbJRdPqyZvK9+wU=
X-Gm-Message-State: AOJu0YwIWksnuUHPOalkIpAqAj4ayQEwBpsnCtsKhRTfVjsYdeM8D9Ly
 rYk7G+XpxTT/1j18govKuRMKy61i7E4FrjxZBRPHaLdNRavrAWiSUceF72lyUiTTWSHKvyqs/Tc
 vugDow/aDvSPdF57oNcfoO1Lm6V+HIc1aYmXt5w==
X-Google-Smtp-Source: AGHT+IEHnf1lECEIB+cRp8+5guQwXKD/8bIqdj0Fu/W80Fh0ZdidK+WCJT5+sslb94XBbyXy+u5+PTbMr1SF3pHcQow=
X-Received: by 2002:a05:6808:23c1:b0:3c9:b61d:cda3 with SMTP id
 5614622812f47-3c9b61dcf20mr10016578b6e.11.1715871822305; Thu, 16 May 2024
 08:03:42 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <868r0ajh5j.fsf@HIDDEN>
In-Reply-To: <868r0ajh5j.fsf@HIDDEN>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Thu, 16 May 2024 20:33:31 +0530
Message-ID: <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> > Eli, is there a convention regarding local variables?
> > In the patch we have:
> > +  (if (local-variable-p 'go-build-tags)
> > +      (format "-tags %s" go-build-tags)
> > +    ""))
> >
> > Should that local variable be prefixed with go-ts-mode, or is it fine as is?
>
> If the variable is specific to go-ts-mode, it should indeed be
> prefixed with "go-ts-".  But I don't see this variable in
> go-ts-mode.el nor in the patch (did I miss something?), and I don't
> understand why the above condition insists on using only a
> buffer-local value of the variable in the first place?  What's wrong
> with having a global value for the variable?

I'm not yet familiar with Elisp-idioms but I'll explain my idea and why I used
the variable this way.

The build tags can be unique to the specific project and sometimes even per
go package. So I thought to make it buffer specific rather than a global
variable defined in the init.el. I'm using these changes on my machine and I'm
defining the build tags in the dir-locals file. This way the variable is always
available for the mode commands to access.

But now I'm thinking maybe it makes sense to add it as defvar-local under the
go-ts-mode? Please guide me with what will be the correct way to implement it.

-- 
Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 16 May 2024 16:02:01 +0000
Resent-Message-ID: <handler.70939.B70939.1715875288511 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: dev@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.1715875288511
          (code B ref 70939); Thu, 16 May 2024 16:02:01 +0000
Received: (at 70939) by debbugs.gnu.org; 16 May 2024 16:01:28 +0000
Received: from localhost ([127.0.0.1]:49505 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s7dXr-00008B-RR
	for submit <at> debbugs.gnu.org; Thu, 16 May 2024 12:01:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:38614)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1s7dXp-000083-9U
 for 70939 <at> debbugs.gnu.org; Thu, 16 May 2024 12:01:26 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1s7dXg-0005SU-A9; Thu, 16 May 2024 12:01:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=e4yQ+N1wjx8nRAPy1l0IfnB/1JmTjy5vU54N+gSOGfc=; b=IsDhuksYWrtI
 6rDKUk+L7r58YoqY4qgExh+ykRxHWjwDgAB+TSL4kw+Mt2TiBVeKh1BBweym/xTGPHQDo7pJ80l8o
 GIImzhPQmCOb7BB96a/el3Jey3moHdAA8WYolRC1J4CHmuvzXsY7NXkm1Udap6ynRgw7PvOUUjQWb
 CuxED8ecnSePq7z1+fKimnnDjFtZzTwVxgQoAgu2kj+uX3/nOs9VhhQgpSetG3wKXYPeIa40OG9Ak
 eh09GzaF3igVOPyGVmj6UD1QDkHiymRm7Gy1ssW2gPkoPLBMQyiS3R/zfYzEDG8KzzqyvyVeCl2OU
 eI7cc/tyL6p0p4BwIXoVTw==;
Date: Thu, 16 May 2024 19:01:11 +0300
Message-Id: <86bk55iw54.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 (message from Ankit Gadiya on Thu, 16 May 2024 20:33:31 +0530)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Ankit Gadiya <ankit@HIDDEN>
> Date: Thu, 16 May 2024 20:33:31 +0530
> Cc: Randy Taylor <dev@HIDDEN>, 70939 <at> debbugs.gnu.org
> 
> > If the variable is specific to go-ts-mode, it should indeed be
> > prefixed with "go-ts-".  But I don't see this variable in
> > go-ts-mode.el nor in the patch (did I miss something?), and I don't
> > understand why the above condition insists on using only a
> > buffer-local value of the variable in the first place?  What's wrong
> > with having a global value for the variable?
> 
> I'm not yet familiar with Elisp-idioms but I'll explain my idea and why I used
> the variable this way.
> 
> The build tags can be unique to the specific project and sometimes even per
> go package. So I thought to make it buffer specific rather than a global
> variable defined in the init.el. I'm using these changes on my machine and I'm
> defining the build tags in the dir-locals file. This way the variable is always
> available for the mode commands to access.

It's okay to support buffer-local values, but using the value of the
variable will do that automatically; you don't have to verify it has a
local binding.  What I don't understand is why does your code _reject_
global bindings.  If some user wants to set up a global value for some
reason, or have a default global value and special local values in
some cases, why should we prevent that?

> But now I'm thinking maybe it makes sense to add it as defvar-local under the
> go-ts-mode? Please guide me with what will be the correct way to implement it.

Yes, defvar-local could be what we want.  But I first would like to
understand what is special about this variable that it should be
buffer-local.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 17 May 2024 02:29:01 +0000
Resent-Message-ID: <handler.70939.B70939.171591288830233 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171591288830233
          (code B ref 70939); Fri, 17 May 2024 02:29:01 +0000
Received: (at 70939) by debbugs.gnu.org; 17 May 2024 02:28:08 +0000
Received: from localhost ([127.0.0.1]:52367 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s7nKK-0007rZ-Hm
	for submit <at> debbugs.gnu.org; Thu, 16 May 2024 22:28:08 -0400
Received: from mail-4018.proton.ch ([185.70.40.18]:38243)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1s7nKJ-0007rS-45
 for 70939 <at> debbugs.gnu.org; Thu, 16 May 2024 22:28:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1715912878; x=1716172078;
 bh=yOFE70DhjW8lo0sjPYrS2IA96D8qp8sZKKNJPUWlQro=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=BaBAgAwXRiZ3kPtUbMvInZOujZcCZz073xUgBWQNythMZOL82TYufzLMfelnlJrPj
 2ol/YWeknphF2qZmnSEpikw9PDsGgXv1COotfRIZtSMUYrSTuMAdWHw1jnf9H+Uy6p
 QuQhiWjbTysHPIxRM7vQ46ZHb4kuDqV3EViacXFV4G9TuarSbbN8bSKv+4hv6/zt1n
 wEzhPAUzbhjS2OcWC74gqOXXeStzwY6YdPdjjjWfI8cmtRnpCnSDKSK/fAxK//EBLQ
 IFd79Z53J2uOcMlchraMeemiPhBKK2K+lEx9ypCQ449NhJsXVCSdh1GhUII03LhxM2
 j9K5mLMtENcpg==
Date: Fri, 17 May 2024 02:27:54 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <REEhHKnTx2m2gYQkYFJW6rlQoocxM4MokSaj08GeHLvhzrDcqqR-3q-aV9R_stKkpbtncTY-u90pOCh4voya7duRb3ysG9fto-bcLE23b50=@rjt.dev>
In-Reply-To: <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: fff3978eea8e4a4e893d63eb49aa4fff29039c2d
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wednesday, May 15th, 2024 at 22:32, Randy Taylor <dev@HIDDEN> wrote:
>=20
> Great. I'll try to give this a try tomorrow.

Hi Ankit,

I've played around a little bit and noticed an issue when using go-ts-mode-=
test-function-at-point:
- When there is no region selected, the test could run more than the functi=
on at point
  if any function names are the same but differ in suffixes (e.g. TestQuack=
 and TestQuackMoo
  would both run if invoked inside just TestQuack). The same applies to whe=
n a region is
  selected. Everything within the region is run, and potentially stuff outs=
ide of it too.
  We need to make the regex strictly the functions we want to run with '^Te=
stQuack$'.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 18 May 2024 08:57:02 +0000
Resent-Message-ID: <handler.70939.B70939.171602259831570 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171602259831570
          (code B ref 70939); Sat, 18 May 2024 08:57:02 +0000
Received: (at 70939) by debbugs.gnu.org; 18 May 2024 08:56:38 +0000
Received: from localhost ([127.0.0.1]:60428 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8Frp-0008D8-Qp
	for submit <at> debbugs.gnu.org; Sat, 18 May 2024 04:56:38 -0400
Received: from mail-vs1-f47.google.com ([209.85.217.47]:53756)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1s8Frm-0008Cx-NX
 for 70939 <at> debbugs.gnu.org; Sat, 18 May 2024 04:56:36 -0400
Received: by mail-vs1-f47.google.com with SMTP id
 ada2fe7eead31-481e9c27378so216131137.3
 for <70939 <at> debbugs.gnu.org>; Sat, 18 May 2024 01:56:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1716022525; x=1716627325; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=MalLk9/ddw6+y+TM/0Wo/IFrr9N6XOZvzGSd7ZufC5A=;
 b=edVmO95+J1gnKTWz457RYO5GaMQUTZx82q4rZGsBW1rWla02yWOvtcP9ZVpLsHPfSY
 Z9SLNbyRfJtrVyvBEd41PuzpLW0WcyKUSTD1Sb5KKp9vsL7Zqlip4qmIsiqizgZ+p6o/
 LfDIz5ABjZQOnEAKhPtwyaJJi6B8SbqAUOAmuc+5elhBAqXhYGQuMWioyVxFkswaP1HO
 nTMyNopFBdnrpeJINdx/1IeFJp/T1W0xErMtFmn450T0hZwLe+shmGhBAenzAjkUYIaO
 yDg9nHzghcCK6r/g2ta8DLISZqZ0nj2XgKYmT45IYDymgp5fHd1kUy/203/ePwwrEagJ
 OjoQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716022525; x=1716627325;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=MalLk9/ddw6+y+TM/0Wo/IFrr9N6XOZvzGSd7ZufC5A=;
 b=Bng7ro7Fp5Zp1ZJfLNVOEsA6Lr9zz7TNGkUA03b8w1tnEpZEK73vStBJWDvJPZfIHe
 hE6AcR9ET8dmCN/QLU8QL232VmnEDXbXPuuElbZoWHqhj6kdcilcaMa8iwfOdctSkKSg
 TMUGVH8TwP1vfEKj5b0PubizWDp3VQ88ScpFrGioyFYIlMx2GfwKOXUDqrCjxVtxGocO
 6mbT2Rn/nJdkQBzvDpFscsCNeB7lyhpyQLe5mX21PS5ds6Evy/DyxR8dqbwa2Icu1o7d
 qGm7BGPjqxvU8sav8/2eT4atID2kbd/7L6YacimMguJG7eXBuFUfoLG8QEr8UrvnUFMw
 n/RA==
X-Gm-Message-State: AOJu0YyCsmIb67RrNvMqCJSfUm8FXAKBM+/gXY8pmgFNwcf8MlN6OvXy
 pgRJPq68VrYkNV6ueHsHV8aH0WDZTXBcKqR3lOhJaCKvBl7J8bq+QE6xEOxQFD9y/QpaGPGS3Kn
 UkbpaHqPxsikI/iWdX7cEwWKf5mL5cegZWtwbGw==
X-Google-Smtp-Source: AGHT+IHN1nXi7gEZ9UodbLz+Ww5NUXoW16RsGFjVjrIo5HRkU9B77dcFGNXJxiACI5DyCBk6+nAjC/vSVsatWJN7/ro=
X-Received: by 2002:a05:6102:b08:b0:47b:620b:c2a3 with SMTP id
 ada2fe7eead31-48077eaf06bmr24081983137.32.1716022525340; Sat, 18 May 2024
 01:55:25 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <REEhHKnTx2m2gYQkYFJW6rlQoocxM4MokSaj08GeHLvhzrDcqqR-3q-aV9R_stKkpbtncTY-u90pOCh4voya7duRb3ysG9fto-bcLE23b50=@rjt.dev>
In-Reply-To: <REEhHKnTx2m2gYQkYFJW6rlQoocxM4MokSaj08GeHLvhzrDcqqR-3q-aV9R_stKkpbtncTY-u90pOCh4voya7duRb3ysG9fto-bcLE23b50=@rjt.dev>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Sat, 18 May 2024 14:25:14 +0530
Message-ID: <CAN7zea3t3GVd=TZ1CyCPTsPraiHt1NPqeG6F98Zt=x58_7A7gQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> I've played around a little bit and noticed an issue when using go-ts-mode-test-function-at-point:
> - When there is no region selected, the test could run more than the function at point
>   if any function names are the same but differ in suffixes (e.g. TestQuack and TestQuackMoo
>   would both run if invoked inside just TestQuack). The same applies to when a region is
>   selected. Everything within the region is run, and potentially stuff outside of it too.
>   We need to make the regex strictly the functions we want to run with '^TestQuack$'.

Thanks for trying out the patch. Yes, I now see how it can capture functions
with the same prefix. I will make the regexp stricter and update the
sample_test.go as well with common prefix examples.

--
Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 18 May 2024 09:56:02 +0000
Resent-Message-ID: <handler.70939.B70939.17160261382900 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: dev@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17160261382900
          (code B ref 70939); Sat, 18 May 2024 09:56:02 +0000
Received: (at 70939) by debbugs.gnu.org; 18 May 2024 09:55:38 +0000
Received: from localhost ([127.0.0.1]:60725 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8Gmv-0000ki-67
	for submit <at> debbugs.gnu.org; Sat, 18 May 2024 05:55:37 -0400
Received: from mail-vk1-f179.google.com ([209.85.221.179]:51658)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1s8Gmt-0000kW-HM
 for 70939 <at> debbugs.gnu.org; Sat, 18 May 2024 05:55:36 -0400
Received: by mail-vk1-f179.google.com with SMTP id
 71dfb90a1353d-4affeacaff9so451397e0c.3
 for <70939 <at> debbugs.gnu.org>; Sat, 18 May 2024 02:55:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1716026066; x=1716630866; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=xXKqZSsvZM/VkaKURO9tKvX7dKjnermWGAm1Qh+P3P0=;
 b=Ah3GofFdoPOuFxhC0dIAx+W6EM0TvtQlLwdK5mgdJMXI0Q24B/JwIt4uWr27LEVKxF
 Ni226nVZGnq9okLtjnHfoGQLwSsIKMkhwXX8p42bjOOjspXS8N1gZqsCpd9tar6L4jqs
 5kkv2tGzkznmf1LSSrIT6xBTapDUx9+PsZ+vfEYA6zxNVt/fBlwW7G+zjDY/+GDr2nju
 /5hVvZi2CKiuQUO4Quc9FLUwyqRhiPo0EV5HFJxYNDpjnPYIxchyVEmp7lWH/ZUSV+dP
 SCy0Tk3mo0RW3Kt+JKdxp14xQDK2cffSooAVkSvQmf1H/aaonVMqDiOUCS5jOaPWN1vQ
 lhdg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716026066; x=1716630866;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=xXKqZSsvZM/VkaKURO9tKvX7dKjnermWGAm1Qh+P3P0=;
 b=XMx/McyE6Q5y68ME26gNGugWxostoiv245GFx5p3QvrhOApWSKuXAsZ4LKNvZr08yH
 EEbtii3/+7ZqoTZNxwSjOcS9+76jUrZ57Hq+6Gen2aSqh3RCrjkqVC8knOrYUxnLsv01
 06Ys96/g00p8S3nTXGPTabL8rFa+fHYwe8XyB84GKhsfxBsjOyHwzYG43gfH8kMVoc6W
 DY7P1ekbcaH0ewEh1jH1A6Whrt75EiHTze8g6y0HTN+xbCS0HwmGYF53wSXVtW9K7dXk
 3CUitYjL2LQJ24zXVB0+F+Yy+uGdWZQhssQzD6jrf6o5ry9rSfqfeHGGlS33PV7ndfGK
 Ciwg==
X-Forwarded-Encrypted: i=1;
 AJvYcCVoR3pQ+hIXobUY/cDyDWx2mwBCsJzc8vm602bUzdoc9ad4GB+A8JNY6oEhtO/sS2bVhgfKRKoLKB5S8DPdw7lPsPiEGdk=
X-Gm-Message-State: AOJu0YwJbLPGofFCT6rrM8VL/vBHqlt01QttP4RVQqPjIa8Ouo/Kt15d
 Y5mzUmLoSOhOll5hglv/rjfR0wOPken47w/nCkMHnin+p+wN8xRkgcNNMwCd/FD94ANZhQmLbjN
 r5Mz5B2hWdByMYmSxLEuLG8e8xmVpa7plo3+2rg==
X-Google-Smtp-Source: AGHT+IHPcfXRQir3zh78PE3EIFlp7xdTzvPOgnzqQeE9un15Ja9p40HGMaLm4W0tPALPBjdMEiwQxq4WtQeQCup2IOM=
X-Received: by 2002:a05:6122:411b:b0:4df:2b08:f217 with SMTP id
 71dfb90a1353d-4df882c2bf7mr22591689e0c.6.1716026066081; Sat, 18 May 2024
 02:54:26 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
In-Reply-To: <86bk55iw54.fsf@HIDDEN>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Sat, 18 May 2024 15:24:14 +0530
Message-ID: <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
Content-Type: multipart/mixed; boundary="0000000000001853970618b77488"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000001853970618b77488
Content-Type: text/plain; charset="UTF-8"

> It's okay to support buffer-local values, but using the value of the
> variable will do that automatically; you don't have to verify it has a
> local binding.  What I don't understand is why does your code _reject_
> global bindings.  If some user wants to set up a global value for some
> reason, or have a default global value and special local values in
> some cases, why should we prevent that?

You are absolutely right, now I realize that local-variable-p is overly
conservative. Since I didn't define the variable in the first place I had to do
the check and even then boundp would have been better.

> > But now I'm thinking maybe it makes sense to add it as defvar-local under the
> > go-ts-mode? Please guide me with what will be the correct way to implement it.
>
> Yes, defvar-local could be what we want.  But I first would like to
> understand what is special about this variable that it should be
> buffer-local.

With the improved understanding, I believe defcustom would be better for the
variable. Then I don't even need the the boundp check since the variable is
always present and it can be replaced by just the non-nil check instead.

As an improvement, I'm also changing the variable-type to a list of strings
instead of a single comma separated string.

I'm submitting an updated Patch with the following changes:
* Add commit log
* Fix the text formatting.
* Update the keybindings to use the C-c C-t prefix.
* Improve regexp matching to be more strict.
* Define =go-ts-mode-build-tags= variable in the module and use it in the test
  functions.

-- 
Ankit

--0000000000001853970618b77488
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Disposition: attachment; 
	filename="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lwbxknjb0>
X-Attachment-Id: f_lwbxknjb0

RnJvbSBjYzZiMzI2N2UzNTA4NjEyNzFlMzY2YmIzYTZjMjg5MWNmYTg1NTdlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmtpdCBSIEdhZGl5YSA8Z2l0QGFyZ3AuaW4+CkRhdGU6IFR1
ZSwgMTQgTWF5IDIwMjQgMDA6MTQ6MDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBBZGQgY29tbWFu
ZHMgdG8gcnVuIHVuaXQgdGVzdHMgaW4gZ28tdHMtbW9kZQoKVHdvIG5ldyBjb21tYW5kcyBhcmUg
YWRkZWQgaW4gdGhlIGdvLXRzLW1vZGUgdG8gcnVuIHVuaXQgdGVzdHMuClRoZSBnby10cy1tb2Rl
LXRlc3QtZnVuY3Rpb24tYXQtcG9pbnQgY29tbWFuZCBydW5zIHRoZSBjdXJyZW50CnRlc3QgZnVu
Y3Rpb24gYXQgcG9pbnQgb3IgYWxsIHRoZSBmdW5jdGlvbnMgaW4gdGhlIGFjdGl2ZSByZWdpb24K
d2hlbiByZWdpb24gaXMgYWN0aXZlLiAgSXQgaXMgYm91bmQgdG8gIkMtYyBDLXQgdCIuIFRoZQpn
by10cy1tb2RlLXRlc3QtcGFja2FnZSBjb21tYW5kIHJ1bnMgYWxsIHRlc3RzIGluIHRoZSBjdXJy
ZW50CnBhY2thZ2UuICBJdCBpcyBib3VuZCB0byAiQy1jIEMtdCBwIi4KCiogbGlzcC9wcm9nbW9k
ZXMvZ28tdHMtbW9kZS5lbCAoZ28tdHMtbW9kZS1idWlsZC10YWdzKTogTmV3IHZhcmlhYmxlLgoo
Z28tdHMtbW9kZS1tYXApOiBOZXcgbWFwIHZhcmlhYmxlLgooZ28tdHMtbW9kZS0tZ2V0LWJ1aWxk
LXRhZ3MtZmxhZyk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWNvbXBpbGUtdGVzdCk6IE5l
dyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQpOiBOZXcgZnVuY3Rpb24uCihn
by10cy1tb2RlLS1nZXQtZnVuY3Rpb24tcmVnZXhwKTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9k
ZS0tZ2V0LWZ1bmN0aW9ucy1pbi1yYW5nZSk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWdl
dC10ZXN0LXJlZ2V4cC1hdC1wb2ludCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC1m
dW5jdGlvbi1hdC1wb2ludCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC1wYWNrYWdl
KTogTmV3IGZ1bmN0aW9uLgoqIGV0Yy9ORVdTOiBNZW50aW9uIHRoZSBjaGFuZ2UuCgooQnVnIzcw
OTM5KQotLS0KIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICAgfCAxMyArKysrKysrCiBsaXNw
L3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIHwgNzMgKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDg1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o
LSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDc3YjI3NDlmZTQzLi5j
OTc4Yzc5MzUwMyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTEyMzYs
NiArMTIzNiwxOSBAQCBUaGlzIGNvbW1hbmQgYWRkcyBhIGRvY3N0cmluZyBjb21tZW50IHRvIHRo
ZSBjdXJyZW50IGRlZnVuLiAgSWYgYQogY29tbWVudCBhbHJlYWR5IGV4aXN0cywgcG9pbnQgaXMg
b25seSBtb3ZlZCB0byB0aGUgY29tbWVudC4gIEl0IGlzCiBib3VuZCB0byAnQy1jIEMtZCcgaW4g
J2dvLXRzLW1vZGUnLgogCisqKiogTmV3IHVuaXQgdGVzdCBjb21tYW5kcy4KK1R3byBuZXcgY29t
bWFuZHMgYXJlIG5vdyBhdmFpbGFibGUgdG8gcnVuIHVuaXQgdGVzdHMuCisKK1RoZSAnZ28tdHMt
bW9kZS10ZXN0LWZ1bmN0aW9uLWF0LXBvaW50JyBjb21tYW5kIHJ1bnMgdGhlIHVuaXQgdGVzdCBh
dAorcG9pbnQuICBJZiBhIHJlZ2lvbiBpcyBhY3RpdmUsIGl0IHJ1bnMgYWxsIHRoZSB1bml0IHRl
c3RzIHVuZGVyIHRoZQorcmVnaW9uLiAgSXQgaXMgYm91bmQgdG8gJ0MtYyBDLXQnIGluICdnby10
cy1tb2RlJy4KKworVGhlICdnby10cy1tb2RlLXRlc3QtcGFja2FnZScgY29tbWFuZCBydW5zIGFs
bCB1bml0IHRlc3RzIHVuZGVyIHRoZQorcGFja2FnZSBvZiB0aGUgY3VycmVudCBidWZmZXIuICBJ
dCBpcyBib3VuZCB0byAnQy1jIEMtcCcgaW4gJ2dvLXRzLW1vZGUnLgorCitUaGUgJ2dvLXRzLW1v
ZGUtYnVpbGQtdGFncycgdmFyaWFibGUgaXMgYXZhaWxhYmxlIHRvIHNldCBhIGxpc3Qgb2YgYnVp
bGQKK3RhZ3MgZm9yIHRoZSB0ZXN0IGNvbW1hbmRzLgorCiAqKiBNYW4gbW9kZQogCiArKysKZGlm
ZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9n
by10cy1tb2RlLmVsCmluZGV4IGFlZjIyNGFiM2ZhLi5mNmQ4NzJiNTIxMCAxMDA2NDQKLS0tIGEv
bGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nby10cy1t
b2RlLmVsCkBAIC00Niw2ICs0NiwxMiBAQCBnby10cy1tb2RlLWluZGVudC1vZmZzZXQKICAgOnNh
ZmUgJ2ludGVnZXJwCiAgIDpncm91cCAnZ28pCiAKKyhkZWZjdXN0b20gZ28tdHMtbW9kZS1idWls
ZC10YWdzIG5pbAorICAiTGlzdCBvZiBnbyBidWlsZCB0YWdzIGZvciB0aGUgdGVzdCBjb21tYW5k
cy4iCisgIDp2ZXJzaW9uICIzMC4xIgorICA6dHlwZSAnKHJlcGVhdCBzdHJpbmcpCisgIDpncm91
cCAnZ28pCisKIChkZWZ2YXIgZ28tdHMtbW9kZS0tc3ludGF4LXRhYmxlCiAgIChsZXQgKCh0YWJs
ZSAobWFrZS1zeW50YXgtdGFibGUpKSkKICAgICAobW9kaWZ5LXN5bnRheC1lbnRyeSA/KyAgICIu
IiAgICAgIHRhYmxlKQpAQCAtMjM3LDcgKzI0Myw5IEBAIGdvLXRzLW1vZGUtLWZvbnQtbG9jay1z
ZXR0aW5ncwogKGRlZnZhci1rZXltYXAgZ28tdHMtbW9kZS1tYXAKICAgOmRvYyAiS2V5bWFwIHVz
ZWQgaW4gR28gbW9kZSwgcG93ZXJlZCBieSB0cmVlLXNpdHRlciIKICAgOnBhcmVudCBwcm9nLW1v
ZGUtbWFwCi0gICJDLWMgQy1kIiAjJ2dvLXRzLW1vZGUtZG9jc3RyaW5nKQorICAiQy1jIEMtZCIg
Iydnby10cy1tb2RlLWRvY3N0cmluZworICAiQy1jIEMtdCB0IiAjJ2dvLXRzLW1vZGUtdGVzdC1m
dW5jdGlvbi1hdC1wb2ludAorICAiQy1jIEMtdCBwIiAjJ2dvLXRzLW1vZGUtdGVzdC1wYWNrYWdl
KQogCiA7OzsjIyNhdXRvbG9hZAogKGRlZmluZS1kZXJpdmVkLW1vZGUgZ28tdHMtbW9kZSBwcm9n
LW1vZGUgIkdvIgpAQCAtMzcwLDYgKzM3OCw2OSBAQCBnby10cy1tb2RlLS1jb21tZW50LW9uLXBy
ZXZpb3VzLWxpbmUtcAogICAgICAoPD0gKHRyZWVzaXQtbm9kZS1zdGFydCBub2RlKSBwb2ludCAo
dHJlZXNpdC1ub2RlLWVuZCBub2RlKSkKICAgICAgKHN0cmluZy1lcXVhbCAiY29tbWVudCIgKHRy
ZWVzaXQtbm9kZS10eXBlIG5vZGUpKSkpKQogCisoZGVmdW4gZ28tdHMtbW9kZS0tZ2V0LWJ1aWxk
LXRhZ3MtZmxhZyAoKQorICAiUmV0dXJuIGNvbXBpbGUgZmxhZyBmb3IgYnVpbGQgdGFncy4KK1Ro
aXMgZnVuY3Rpb24gcmVzcGVjdHMgdGhlIGBnby10cy1tb2RlLWJ1aWxkLXRhZ3MnIHZhcmlhYmxl
IGZvcgorc3BlY2lmeWluZyBidWlsZCB0YWdzLiIKKyAgKGlmIGdvLXRzLW1vZGUtYnVpbGQtdGFn
cworICAgICAgKGZvcm1hdCAiLXRhZ3MgJXMiIChzdHJpbmctam9pbiBnby10cy1tb2RlLWJ1aWxk
LXRhZ3MgIiwiKSkKKyAgICAiIikpCisKKyhkZWZ1biBnby10cy1tb2RlLS1jb21waWxlLXRlc3Qg
KHJlZ2V4cCkKKyAgIkNvbXBpbGUgdGhlIHRlc3RzIG1hdGNoaW5nIFJFR0VYUC4KK1RoaXMgZnVu
Y3Rpb24gcmVzcGVjdHMgYGdvLXRzLW1vZGUtYnVpbGQtdGFncycgdmFyaWFibGUgZm9yIHNwZWNp
ZnlpbmcKK2J1aWxkIHRhZ3MuIgorICAoY29tcGlsZSAoZm9ybWF0ICJnbyB0ZXN0IC12ICVzIC1y
dW4gJyVzJyIKKyAgICAgICAgICAgICAgICAgICAoZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3Mt
ZmxhZykKKyAgICAgICAgICAgICAgICAgICByZWdleHApKSkKKworKGRlZnVuIGdvLXRzLW1vZGUt
LWZpbmQtZGVmdW4tYXQgKHN0YXJ0KQorICAiUmV0dXJuIHRoZSBmaXJzdCBkZWZ1biBub2RlIGZy
b20gU1RBUlQuIgorICAobGV0ICgodGhpbmcgKG9yIHRyZWVzaXQtZGVmdW4tdHlwZS1yZWdleHAg
J2RlZnVuKSkpCisgICAgKG9yICh0cmVlc2l0LXRoaW5nLWF0IHN0YXJ0IHRoaW5nKQorICAgICAg
ICAodHJlZXNpdC10aGluZy1uZXh0IHN0YXJ0IHRoaW5nKSkpKQorCisoZGVmdW4gZ28tdHMtbW9k
ZS0tZ2V0LWZ1bmN0aW9uLXJlZ2V4cCAobmFtZSkKKyAgKGZvcm1hdCAiXiVzJCIgbmFtZSkpCisK
KyhkZWZ1biBnby10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlIChzdGFydCBlbmQpCisg
ICJSZXR1cm4gYSBsaXN0IHdpdGggbmFtZXMgb2YgYWxsIGRlZnVucyBpbiB0aGUgcmFuZ2UuIgor
ICAobGV0KiAoKG5vZGUgKGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQgc3RhcnQpKQorCSAobmFt
ZSAodHJlZXNpdC1kZWZ1bi1uYW1lIG5vZGUpKQorICAgICAgICAgKG5vZGUtc3RhcnQgKHRyZWVz
aXQtbm9kZS1zdGFydCBub2RlKSkKKyAgICAgICAgIChub2RlLWVuZCAodHJlZXNpdC1ub2RlLWVu
ZCBub2RlKSkpCisgICAgKGlmIChvciAobm90IG5vZGUpCisgICAgICAgICAgICAoPiBzdGFydCBu
b2RlLWVuZCkKKwkgICAgKDwgZW5kIG5vZGUtc3RhcnQpKQorCW5pbAorICAgICAgKGNvbnMgKGdv
LXRzLW1vZGUtLWdldC1mdW5jdGlvbi1yZWdleHAgbmFtZSkKKyAgICAgICAgICAgIChnby10cy1t
b2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlICh0cmVlc2l0LW5vZGUtZW5kIG5vZGUpIGVuZCkp
KSkpCisKKyhkZWZ1biBnby10cy1tb2RlLS1nZXQtdGVzdC1yZWdleHAtYXQtcG9pbnQgKCkKKyAg
IlJldHVybiBhIHJlZ3VsYXIgZXhwcmVzc2lvbiBmb3IgdGVzdHMgYXQgcG9pbnQuCitJZiByZWdp
b24gaXMgYWN0aXZlLCB0aGUgcmVnZXhwIHdpbGwgaW5jbHVkZSBhbGwgdGhlIGZ1bmN0aW9ucyB1
bmRlciB0aGUKK3JlZ2lvbi4iCisgIChpZiAocmVnaW9uLWFjdGl2ZS1wKQorICAgICAgKHN0cmlu
Zy1qb2luIChnby10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlIChyZWdpb24tYmVnaW5u
aW5nKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIChyZWdpb24tZW5kKSkKKyAgICAgICAgICAgICAgICAgICAifCIpCisgICAgKGdvLXRzLW1v
ZGUtLWdldC1mdW5jdGlvbi1yZWdleHAgKHRyZWVzaXQtZGVmdW4tbmFtZSAodHJlZXNpdC1kZWZ1
bi1hdC1wb2ludCkpKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLXRlc3QtZnVuY3Rpb24tYXQtcG9p
bnQgKCkKKyAgIlJ1biB0aGUgdW5pdCB0ZXN0IGF0IHBvaW50LgorSWYgdGhlIHBvaW50IGlzIGFu
eXdoZXJlIGluIHRoZSB0ZXN0IGZ1bmN0aW9uLCB0aGF0IGZ1bmN0aW9uIHdpbGwgYmUKK3J1bi4g
IElmIHRoZSByZWdpb24gaXMgc2VsZWN0ZWQsIGFsbCB0aGUgZnVuY3Rpb25zIHVuZGVyIHRoZSBy
ZWdpb24gd2lsbAorYmUgcnVuLiIKKyAgICAoaW50ZXJhY3RpdmUpCisgICAgKGdvLXRzLW1vZGUt
LWNvbXBpbGUtdGVzdCAoZ28tdHMtbW9kZS0tZ2V0LXRlc3QtcmVnZXhwLWF0LXBvaW50KSkpCisK
KyhkZWZ1biBnby10cy1tb2RlLXRlc3QtcGFja2FnZSAoKQorICAiUnVuIGFsbCB0aGUgdW5pdCB0
ZXN0cyB1bmRlciB0aGUgY3VycmVudCBwYWNrYWdlLiIKKyAgKGludGVyYWN0aXZlKQorICAoY29t
cGlsZSAoZm9ybWF0ICJnbyB0ZXN0IC12ICVzIC1ydW4gJXMiCisgICAgICAgICAgICAgICAgICAg
KGdvLXRzLW1vZGUtLWdldC1idWlsZC10YWdzLWZsYWcpCisgICAgICAgICAgICAgICAgICAgZGVm
YXVsdC1kaXJlY3RvcnkpKSkKKwogOzsgZ28ubW9kIHN1cHBvcnQuCiAKIChkZWZ2YXIgZ28tbW9k
LXRzLW1vZGUtLXN5bnRheC10YWJsZQotLSAKMi4zOS4yCgo=
--0000000000001853970618b77488
Content-Type: text/x-go; charset="US-ASCII"; name="sample_test.go"
Content-Disposition: attachment; filename="sample_test.go"
Content-Transfer-Encoding: base64
Content-ID: <f_lwbxljag1>
X-Attachment-Id: f_lwbxljag1

cGFja2FnZSBzYW1wbGVfdGVzdAoKaW1wb3J0ICJ0ZXN0aW5nIgoKZnVuYyBUZXN0SW5kaXZpZHVh
bCh0ICp0ZXN0aW5nLlQpIHsKCn0KCmZ1bmMgVGVzdEluZGl2aWR1YWxGb29CYXIodCAqdGVzdGlu
Zy5UKSB7Cgp9CgpmdW5jIFRlc3RPdmVybGFwUmVnaW9uKHQgKnRlc3RpbmcuVCkgewoKfQo=
--0000000000001853970618b77488--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 May 2024 02:37:02 +0000
Resent-Message-ID: <handler.70939.B70939.17166045643715 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17166045643715
          (code B ref 70939); Sat, 25 May 2024 02:37:02 +0000
Received: (at 70939) by debbugs.gnu.org; 25 May 2024 02:36:04 +0000
Received: from localhost ([127.0.0.1]:40458 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sAhGO-0000xr-3j
	for submit <at> debbugs.gnu.org; Fri, 24 May 2024 22:36:04 -0400
Received: from mail-4018.proton.ch ([185.70.40.18]:48149)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sAhGK-0000xS-DT
 for 70939 <at> debbugs.gnu.org; Fri, 24 May 2024 22:36:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1716604546; x=1716863746;
 bh=2WBSbuXfbOMoRD/gTMRS+zgCcvxfmgQvBKc2JD2TaR0=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=i3a4J71jm6VkFyfFIHxWPO0EEtpwjx/GYJa5cW17JV6FZDo2V0Is+1K4Ma0TfNb/X
 8EiKkcJdACWohzP76J+6W+quobv3FLbGAOOhxleBadKBAtzJLcNM7YeZiGKvsy1xTx
 s/5AP3uQB4BUOU6zHJCE6sMAcBbYU/K2Y9MqZHp8qmc3ybc9zOPmecDRpERjxy/5/p
 g1deveuqOzDJp7vEne6FwJmt9XFzL4VQhlcxRsi1JL8+oIIbjVHL6QGSy5bynvP0+3
 UMrfPlRgn1dGLDE2QxPdQowRGdz32BrnGnMZoEev3Qf+I5baagtaI5oWOQMJBxwS51
 +htNFEiVyduOg==
Date: Sat, 25 May 2024 02:35:42 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
In-Reply-To: <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: c6f09e1b47b1bd754105ba1ebad01d840f8683a6
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Saturday, May 18th, 2024 at 05:54, Ankit Gadiya via "Bug reports for GNU=
 Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> wrote=
:
>=20
> [...]
>=20
> I'm submitting an updated Patch with the following changes:
> * Add commit log
> * Fix the text formatting.
> * Update the keybindings to use the C-c C-t prefix.
> * Improve regexp matching to be more strict.
> * Define =3Dgo-ts-mode-build-tags=3D variable in the module and use it in=
 the test
> functions.
>=20
> --
> Ankit

Thanks.

Sorry for the delay in reviewing, I've been having internet troubles since =
last Friday. I'll take a look at this next week.

A few quick things I noticed on a glance:

+  (let* ((node (go-ts-mode--find-defun-at start))
+=09 (name (treesit-defun-name node))

Indentation is off on the name line - looks like a TAB was used? Should onl=
y be spaces everywhere. Double check the rest is OK.

+region.  It is bound to 'C-c C-t' in 'go-ts-mode'.
                         ^ C-c C-t t

+package of the current buffer.  It is bound to 'C-c C-p' in 'go-ts-mode'.
                                                ^ C-c C-t p

+  "List of go build tags for the test commands."
            ^ Go

+  "Return a list with names of all defuns in the range."
We should probably say what the range actually is (START to END) - not sure=
 if we have a convention for that wording already.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 28 May 2024 02:31:02 +0000
Resent-Message-ID: <handler.70939.B70939.171686344014169 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171686344014169
          (code B ref 70939); Tue, 28 May 2024 02:31:02 +0000
Received: (at 70939) by debbugs.gnu.org; 28 May 2024 02:30:40 +0000
Received: from localhost ([127.0.0.1]:45499 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sBmbn-0003gS-QD
	for submit <at> debbugs.gnu.org; Mon, 27 May 2024 22:30:40 -0400
Received: from mail-4317.proton.ch ([185.70.43.17]:43157)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sBmbk-0003gD-1t
 for 70939 <at> debbugs.gnu.org; Mon, 27 May 2024 22:30:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1716863420; x=1717122620;
 bh=8DRACdwWWg1Wg3dNCGkRj52JrVOeTTJLmH26tWLB2E0=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=PQNOPfvrBelWszu9oaM440BN3eRs5e3jctIScWj3Vt4rnEdkKpyvcsOb7V1S7JO6t
 VHcr6zXD4S4R2RvM3tf47VSTvCbH4hVBm0nPpNEIpTpkICii8nBmo06zyY+ZfxvGeg
 NjpnLWvR1doO3DUyLFmUm8wXkwbtEED601GtrcWOOfsoVCqoKw8n7vfB6mKrrZASLB
 tfIhHu7HamNf4II9Dk23TKXR5GsN8tV+YpsW8shrbr2i2Og28aes45mofgITapmvyx
 je2KLg3AIDTCvDI2OQLPBWaTXITCO3okvHkJi3LQ4KTBChdmojHSFaqVpibHXcd7jS
 zMhpRcAsWl5vg==
Date: Tue, 28 May 2024 02:30:18 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
In-Reply-To: <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 988c5a5aca8fb69028c5c94c819eb68be4eed8d6
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Friday, May 24th, 2024 at 22:35, Randy Taylor <dev@HIDDEN> wrote:
>=20
> On Saturday, May 18th, 2024 at 05:54, Ankit Gadiya via "Bug reports for G=
NU Emacs, the Swiss army knife of text editors" bug-gnu-emacs@HIDDEN wrote=
:
>=20
> > [...]
> >=20
> > I'm submitting an updated Patch with the following changes:
> > * Add commit log
> > * Fix the text formatting.
> > * Update the keybindings to use the C-c C-t prefix.
> > * Improve regexp matching to be more strict.
> > * Define =3Dgo-ts-mode-build-tags=3D variable in the module and use it =
in the test
> > functions.
> >=20
> > --
> > Ankit
>=20
>=20
> Thanks.
>=20
> Sorry for the delay in reviewing, I've been having internet troubles sinc=
e last Friday. I'll take a look at this next week.
>=20
> A few quick things I noticed on a glance:
>=20
> + (let* ((node (go-ts-mode--find-defun-at start))
> + (name (treesit-defun-name node))
>=20
> Indentation is off on the name line - looks like a TAB was used? Should o=
nly be spaces everywhere. Double check the rest is OK.
>=20
> +region. It is bound to 'C-c C-t' in 'go-ts-mode'.
> ^ C-c C-t t
>=20
> +package of the current buffer. It is bound to 'C-c C-p' in 'go-ts-mode'.
> ^ C-c C-t p
>=20
> + "List of go build tags for the test commands."
> ^ Go
>=20
> + "Return a list with names of all defuns in the range."
> We should probably say what the range actually is (START to END) - not su=
re if we have a convention for that wording already.

A few more nits:
+  "Return compile flag for build tags.
          ^ the

+This function respects `go-ts-mode-build-tags' variable for specifying
                       ^ the

+  "Return a list with names of all defuns in the range."
                      ^ the

Indentation is also off in go-ts-mode-test-function-at-point.

When we run C-c C-t t outside of a function, we get:
go test -v  -run '^nil$'
Should we maybe not bother running anything at all? What do you think?
Do we know how other packages behave under similar circumstances?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 28 May 2024 20:01:01 +0000
Resent-Message-ID: <handler.70939.B70939.17169264089449 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17169264089449
          (code B ref 70939); Tue, 28 May 2024 20:01:01 +0000
Received: (at 70939) by debbugs.gnu.org; 28 May 2024 20:00:08 +0000
Received: from localhost ([127.0.0.1]:54974 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sC2zQ-0002SK-4v
	for submit <at> debbugs.gnu.org; Tue, 28 May 2024 16:00:08 -0400
Received: from mail-vs1-f46.google.com ([209.85.217.46]:51352)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1sC2zO-0002RY-VR
 for 70939 <at> debbugs.gnu.org; Tue, 28 May 2024 16:00:07 -0400
Received: by mail-vs1-f46.google.com with SMTP id
 ada2fe7eead31-48a39be0e32so383234137.2
 for <70939 <at> debbugs.gnu.org>; Tue, 28 May 2024 12:59:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1716926332; x=1717531132; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=D535+Nz3VWioln+eyCE8hs/AfGGYcnhiRhka4fJZxxU=;
 b=hXMfQ7zYnprarYELSUkagiCJaGamlQt2rzCxZ2LpuQxFDXvbxRjbUCVunYhymeSDLX
 /jkMvpanDowB1pLIlmg6nE00uI0KMnQIR+Dv3fVlpH1DRVXhF0+p7edI4Gw6H/FIpjBz
 IVfh7vEtWK+yp32Kg/eixQq2hoAWWi6dQUrbb2sy56pQlNd/ibD0/0AmzhBF4XaCce9C
 8cExE3kYCokUn9vXfz/MiGKWzyCF10lh9xsdVysf7bCeHn7/MzHn8QcvPEub12EAmbSi
 PoDKOlT0w2yWCUdT5zTuf7+6ryyGvOg0ncoYciMalhvEJQEkTTJfT5p7xwbk/5+6zfWY
 z/Qg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716926332; x=1717531132;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=D535+Nz3VWioln+eyCE8hs/AfGGYcnhiRhka4fJZxxU=;
 b=FB2nUIHuGNW3BgtCrv1PXdl0MR75oFiCGt88/1f+FLRR8d7qs27exC84h2TPBo08GY
 IHRlb3W8bSI4BQI9LICTkc31XBPWpnO/LBi00FyW5dkIG3YnQK249W1jG3xdD0Xd5YAn
 rvh7cxNdCiayrD9y60Z7qsu8t9DxOJ5MGBiQBfolzQGHop1VI/6yLnLbcvsIoLv13XDU
 50m6BIO1cZl8w1jIJHOtVv1XoV83pOOAE+Ky4Uv9OoYqq5Su6OmOEECgrMZv6wUrYMJc
 yjmhs8D4RZJoIn2O9V9WUznGiImgcZCJs2UhcGikpG1A2t2qEa+kIkAf7WIP4m/+XDPk
 q5dQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCXQadGg79Fu/lPo4DI2rEIdf5KJN2XCOjlTv/B7km5vpb2m5ufGsfIdoQ5QR1Hfup9pp8+eVEep9LxuzZXalo5qBXmrHlA=
X-Gm-Message-State: AOJu0Yxv91gR7FPXqLzzbLeBH0BH5rpGD6s0oien8bUtBarHZX2vQy6w
 MCfDGuNPBORNKRdCK2PLVVDT66C7kx78EDSCb3fLdcA0IPwLlVJJJx2ybvi44s+zwnOQQJPobwN
 ZycvuSWa/RlMXjj69uklvDNEOdCZ/pRIikH33inviY8QDHm4v4zV0yw==
X-Google-Smtp-Source: AGHT+IEsHp/6J/a+yd2FQrHCKsnS2B99xcm9vPZmMhYKIFXk2aw7SeE4+HvOzdzF4Cq5YtqIWzlLZQXlJzpxpMCSQZw=
X-Received: by 2002:a05:6102:f11:b0:48a:2e81:6671 with SMTP id
 ada2fe7eead31-48a386ccc4bmr16922545137.34.1716926329891; Tue, 28 May 2024
 12:58:49 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
In-Reply-To: <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Wed, 29 May 2024 01:28:38 +0530
Message-ID: <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> > Sorry for the delay in reviewing, I've been having internet troubles since last Friday. I'll take a look at this next week.

No issues, appreciate the review.

> > A few quick things I noticed on a glance:
> >
> > + (let* ((node (go-ts-mode--find-defun-at start))
> > + (name (treesit-defun-name node))
> >
> > Indentation is off on the name line - looks like a TAB was used? Should only be spaces everywhere. Double check the rest is OK.
> >
> > +region. It is bound to 'C-c C-t' in 'go-ts-mode'.
> > ^ C-c C-t t
> >
> > +package of the current buffer. It is bound to 'C-c C-p' in 'go-ts-mode'.
> > ^ C-c C-t p
> >
> > + "List of go build tags for the test commands."
> > ^ Go
> >
> > + "Return a list with names of all defuns in the range."
> > We should probably say what the range actually is (START to END) - not sure if we have a convention for that wording already.
>
> A few more nits:
> +  "Return compile flag for build tags.
>           ^ the
>
> +This function respects `go-ts-mode-build-tags' variable for specifying
>                        ^ the
>
> +  "Return a list with names of all defuns in the range."
>                       ^ the
>
> Indentation is also off in go-ts-mode-test-function-at-point.

Thanks. I learned about whitespace-mode and checkdoc. I'll be running my changes
through it before sending the path now. Please let me know if there are any
other checks I can do in the future.

> When we run C-c C-t t outside of a function, we get:
> go test -v  -run '^nil$'
> Should we maybe not bother running anything at all? What do you think?
> Do we know how other packages behave under similar circumstances?

I'll check the packages and find out how it is handled elsewhere. One point of
reference can be Doom Emacs configuration. It uses the
re-search-(backward|forward) functions that throw an error if no match is found.

I'm also planning to add a third function to run all the tests in the current
file using the buffer-beginning and buffer-end as the range. I'll submit it in
the next patch along with the suggested fixes.

-- 
Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 19 Jun 2024 18:19:02 +0000
Resent-Message-ID: <handler.70939.B70939.17188211339046 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17188211339046
          (code B ref 70939); Wed, 19 Jun 2024 18:19:02 +0000
Received: (at 70939) by debbugs.gnu.org; 19 Jun 2024 18:18:53 +0000
Received: from localhost ([127.0.0.1]:54073 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sJztU-0002Lq-QD
	for submit <at> debbugs.gnu.org; Wed, 19 Jun 2024 14:18:53 -0400
Received: from mail-vs1-f43.google.com ([209.85.217.43]:57651)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1sJztR-0002LZ-SZ
 for 70939 <at> debbugs.gnu.org; Wed, 19 Jun 2024 14:18:50 -0400
Received: by mail-vs1-f43.google.com with SMTP id
 ada2fe7eead31-48db825a82eso26328137.3
 for <70939 <at> debbugs.gnu.org>; Wed, 19 Jun 2024 11:18:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1718821061; x=1719425861; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=YA85nC5Xar3xd8K2lwMv69NzWkDgmJ5uDaDrNd+J/2A=;
 b=Okj1+QlrL6lQTOXLHuPdwHSrreuqACxCQOqEiiQXxTyJDjk4lqj99L/gLHzslTZLS7
 exTP2J3W8HtqkcciUBGYgBKwXahXhd3cVf8OJBDg1ItHy25idPuNXIumRX2o6CTdEnZd
 mxOusZOSHBVrQi4wWhi44EGfNRHQQnaLNUDd0vEMiKIw0D1/txHDd50nVDkDqXPpFG00
 YTIdFS02pM8VlEHzxcV+tiCUXjeFHPnnK7BOXB2YR28Qhl6xoG4Grq5JXYPtlN2saas0
 vgIoO7L25pShz3/fyuDvMzNz6UexddoB0152VCf6TPFVcDVCNB1wT5dTxyHIqDIVNdli
 IQZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1718821061; x=1719425861;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=YA85nC5Xar3xd8K2lwMv69NzWkDgmJ5uDaDrNd+J/2A=;
 b=nqomyN65srWynksXHIupEff4mJ35VOVIFgeXDnVicCW3P98f5LOHBd+P4B9jmIJ2O6
 Ty2PZfMfgsXtVQXkgz5vzn0+LEf7soP0owVoyAoExIRX0O4i2Lp1+Vq+1BbiosSGulU3
 Q1JIXl+tkCe6vEDi6boBI+6dpQl6MhCq2cQm3zS+wW3Dh5ZBaHyqJOzO60pS3/7X2KKy
 1LqjUvVedOeFsEgK0kd2W0vklz+07OWYxEd37mTZLrpemMnp00nmAN4MyFe+qqH0J/1J
 RaVcoj41Bw+d9O6lP0m0DXUlP40cJrApeisD1KkYrMv7M630riwl2pTfp8ZZl+R+gOhE
 vLJQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCUi8pevEr6DroobGOfGNQVJ8MPZF6xM5ReLDMT+9wJEaFBxZx/omQGbqkFEznL48ppTy/0PMlvNHKQGaDT+vUW4TWUXV5A=
X-Gm-Message-State: AOJu0Yzx9uTKCqKx+KjEh4VlM2pKRIqpMqBjsVwuH5JC1/3JWaCfr7tv
 tdDXAXNJa2TxPPuc5c9vCmpLzn6kPquqB2yD6rJKsA+TElxVlpgX6LADPy5py9Bja8C0WeXzgxk
 XWc9pIQrwqjVtDH7K9QGsQtyU0a8Hc3+pm9G4Xg==
X-Google-Smtp-Source: AGHT+IGwJPFNoBrlxXigjr3GjpdL1tC764GK013qCPBLvIGzqtnJzBt9LLbGCSlPsmVi55YMRdoYEC0PrB4omt8gbRg=
X-Received: by 2002:a05:6122:1da8:b0:4eb:5d30:3fad with SMTP id
 71dfb90a1353d-4ef277e04ddmr3819177e0c.10.1718821060817; Wed, 19 Jun 2024
 11:17:40 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <JXjrwgd58pWaYVvwpko6CD3CuAHikkAj64A9BnUwH06ceusPcTvgDOuIk4RW_3C1qt0Grnvc4s1ZScayEJnc4VjiRuivRNj_4TMVPMDYF-U=@rjt.dev>
 <CAN7zea3bU6NjLrgz=g8FdUrwmBFpq88WGPcg8goROcftivz0Ow@HIDDEN>
 <TGzZdTWKM_xDC3-xh0MWgdcpDpzSyRpismuCvIM_1rpOnhKE9eMr56fCP21LnGkkhcXBMpNCxWOPTBugPkOZt0qXCXuj_9VdSYPb-uRyi9g=@rjt.dev>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
In-Reply-To: <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Wed, 19 Jun 2024 23:47:29 +0530
Message-ID: <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000c370c8061b4236f4"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--000000000000c370c8061b4236f4
Content-Type: text/plain; charset="UTF-8"

Apologies for the delay in response.

> > > A few quick things I noticed on a glance:
> > >
> > > + (let* ((node (go-ts-mode--find-defun-at start))
> > > + (name (treesit-defun-name node))
> > >
> > > Indentation is off on the name line - looks like a TAB was used? Should only be spaces everywhere. Double check the rest is OK.
> > >
> > > +region. It is bound to 'C-c C-t' in 'go-ts-mode'.
> > > ^ C-c C-t t
> > >
> > > +package of the current buffer. It is bound to 'C-c C-p' in 'go-ts-mode'.
> > > ^ C-c C-t p
> > >
> > > + "List of go build tags for the test commands."
> > > ^ Go
> > >
> > > + "Return a list with names of all defuns in the range."
> > > We should probably say what the range actually is (START to END) - not sure if we have a convention for that wording already.
> >
> > A few more nits:
> > +  "Return compile flag for build tags.
> >           ^ the
> >
> > +This function respects `go-ts-mode-build-tags' variable for specifying
> >                        ^ the
> >
> > +  "Return a list with names of all defuns in the range."
> >                       ^ the
> >
> > Indentation is also off in go-ts-mode-test-function-at-point.
>
> Thanks. I learned about whitespace-mode and checkdoc. I'll be running my changes
> through it before sending the path now. Please let me know if there are any
> other checks I can do in the future.

I've incorporated these suggestions in my updated patch.

> > When we run C-c C-t t outside of a function, we get:
> > go test -v  -run '^nil$'
> > Should we maybe not bother running anything at all? What do you think?
> > Do we know how other packages behave under similar circumstances?
>
> I'll check the packages and find out how it is handled elsewhere. One point of
> reference can be Doom Emacs configuration. It uses the
> re-search-(backward|forward) functions that throw an error if no match is found.

I've updated the functions to now raise an error if no function is found at
point or under the region.

> I'm also planning to add a third function to run all the tests in the current
> file using the buffer-beginning and buffer-end as the range. I'll submit it in
> the next patch along with the suggested fixes.

I've added the go-ts-mode-test-file function as well that runs all the unit
tests in the current file.

--
Ankit

--000000000000c370c8061b4236f4
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Disposition: attachment; 
	filename="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lxm5o7gv0>
X-Attachment-Id: f_lxm5o7gv0

RnJvbSBjN2JiNTE0OTFjNTkyNzNmZGMwYjJlZTBlZjM4NTEzMDA3ZDdlYjcwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmtpdCBSIEdhZGl5YSA8Z2l0QGFyZ3AuaW4+CkRhdGU6IFR1
ZSwgMTQgTWF5IDIwMjQgMDA6MTQ6MDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBBZGQgY29tbWFu
ZHMgdG8gcnVuIHVuaXQgdGVzdHMgaW4gZ28tdHMtbW9kZQoKVGhyZWUgbmV3IGNvbW1hbmRzIGFy
ZSBhZGRlZCBpbiB0aGUgZ28tdHMtbW9kZSB0byBydW4gdW5pdCB0ZXN0cy4KVGhlIGdvLXRzLW1v
ZGUtdGVzdC1mdW5jdGlvbi1hdC1wb2ludCBjb21tYW5kIHJ1bnMgdGhlIGN1cnJlbnQKdGVzdCBm
dW5jdGlvbiBhdCBwb2ludCBvciBhbGwgdGhlIGZ1bmN0aW9ucyBpbiB0aGUgYWN0aXZlIHJlZ2lv
bgp3aGVuIHJlZ2lvbiBpcyBhY3RpdmUuICBJdCBpcyBib3VuZCB0byAiQy1jIEMtdCB0Ii4gVGhl
CmdvLXRzLW1vZGUtdGVzdC1maWxlIGNvbW1hbmQgcnVucyBhbGwgdGVzdHMgaW4gdGhlIGN1cnJl
bnQgZmlsZS4gSXQgaXMKYm91bmQgdG8gIkMtYyBDLXQgZiIuIFRoZSBnby10cy1tb2RlLXRlc3Qt
cGFja2FnZSBjb21tYW5kIHJ1bnMgYWxsIHRlc3RzCmluIHRoZSBjdXJyZW50IHBhY2thZ2UuICBJ
dCBpcyBib3VuZCB0byAiQy1jIEMtdCBwIi4KCiogbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5l
bCAoZ28tdHMtbW9kZS1idWlsZC10YWdzKTogTmV3IHZhcmlhYmxlLgooZ28tdHMtbW9kZS1tYXAp
OiBOZXcgbWFwIHZhcmlhYmxlLgooZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZyk6IE5l
dyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWNvbXBpbGUtdGVzdCk6IE5ldyBmdW5jdGlvbi4KKGdv
LXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQpOiBOZXcgZnVuY3Rpb24uCihnby10cy1tb2RlLS1nZXQt
ZnVuY3Rpb24tcmVnZXhwKTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9u
cy1pbi1yYW5nZSk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWdldC10ZXN0LXJlZ2V4cC1h
dC1wb2ludCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC1mdW5jdGlvbi1hdC1wb2lu
dCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC1maWxlKTogTmV3IGZ1bmN0aW9uLgoo
Z28tdHMtbW9kZS10ZXN0LXBhY2thZ2UpOiBOZXcgZnVuY3Rpb24uCiogZXRjL05FV1M6IE1lbnRp
b24gdGhlIGNoYW5nZS4KCihCdWcjNzA5MzkpCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICAg
ICAgICB8IDE2ICsrKysrKysKIGxpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwgfCA4NCArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgOTkgaW5z
ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05F
V1MKaW5kZXggM2IxODk3Mjg2MGYuLjczZmNiNDZmYWQyIDEwMDY0NAotLS0gYS9ldGMvTkVXUwor
KysgYi9ldGMvTkVXUwpAQCAtMTM4OSw2ICsxMzg5LDIyIEBAIFRoaXMgY29tbWFuZCBhZGRzIGEg
ZG9jc3RyaW5nIGNvbW1lbnQgdG8gdGhlIGN1cnJlbnQgZGVmdW4uICBJZiBhCiBjb21tZW50IGFs
cmVhZHkgZXhpc3RzLCBwb2ludCBpcyBvbmx5IG1vdmVkIHRvIHRoZSBjb21tZW50LiAgSXQgaXMK
IGJvdW5kIHRvICdDLWMgQy1kJyBpbiAnZ28tdHMtbW9kZScuCiAKKyoqKiBOZXcgdW5pdCB0ZXN0
IGNvbW1hbmRzLgorVHdvIG5ldyBjb21tYW5kcyBhcmUgbm93IGF2YWlsYWJsZSB0byBydW4gdW5p
dCB0ZXN0cy4KKworVGhlICdnby10cy1tb2RlLXRlc3QtZnVuY3Rpb24tYXQtcG9pbnQnIGNvbW1h
bmQgcnVucyB0aGUgdW5pdCB0ZXN0IGF0Citwb2ludC4gIElmIGEgcmVnaW9uIGlzIGFjdGl2ZSwg
aXQgcnVucyBhbGwgdGhlIHVuaXQgdGVzdHMgdW5kZXIgdGhlCityZWdpb24uICBJdCBpcyBib3Vu
ZCB0byAnQy1jIEMtdCB0JyBpbiAnZ28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS10ZXN0
LWZpbGUnIGNvbW1hbmQgcnVucyBhbGwgdW5pdCB0ZXN0cyBpbiB0aGUgY3VycmVudAorZmlsZS4g
SXQgaXMgYm91bmQgdG8gJ0MtYyBDLXQgZicgaW4gJ2dvLXRzLW1vZGUnLgorCitUaGUgJ2dvLXRz
LW1vZGUtdGVzdC1wYWNrYWdlJyBjb21tYW5kIHJ1bnMgYWxsIHVuaXQgdGVzdHMgdW5kZXIgdGhl
CitwYWNrYWdlIG9mIHRoZSBjdXJyZW50IGJ1ZmZlci4gIEl0IGlzIGJvdW5kIHRvICdDLWMgQy10
IHAnIGluICdnby10cy1tb2RlJy4KKworVGhlICdnby10cy1tb2RlLWJ1aWxkLXRhZ3MnIHZhcmlh
YmxlIGlzIGF2YWlsYWJsZSB0byBzZXQgYSBsaXN0IG9mIGJ1aWxkCit0YWdzIGZvciB0aGUgdGVz
dCBjb21tYW5kcy4KKwogKiogTWFuIG1vZGUKIAogKysrCmRpZmYgLS1naXQgYS9saXNwL3Byb2dt
b2Rlcy9nby10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAppbmRleCAy
ZDNlNmFhYzA5MC4uYjI3NzQyYTA3ODUgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2dvLXRz
LW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbApAQCAtNDYsNiArNDYs
MTIgQEAgZ28tdHMtbW9kZS1pbmRlbnQtb2Zmc2V0CiAgIDpzYWZlICdpbnRlZ2VycAogICA6Z3Jv
dXAgJ2dvKQogCisoZGVmY3VzdG9tIGdvLXRzLW1vZGUtYnVpbGQtdGFncyBuaWwKKyAgIkxpc3Qg
b2YgR28gYnVpbGQgdGFncyBmb3IgdGhlIHRlc3QgY29tbWFuZHMuIgorICA6dmVyc2lvbiAiMzAu
MSIKKyAgOnR5cGUgJyhyZXBlYXQgc3RyaW5nKQorICA6Z3JvdXAgJ2dvKQorCiAoZGVmdmFyIGdv
LXRzLW1vZGUtLXN5bnRheC10YWJsZQogICAobGV0ICgodGFibGUgKG1ha2Utc3ludGF4LXRhYmxl
KSkpCiAgICAgKG1vZGlmeS1zeW50YXgtZW50cnkgPysgICAiLiIgICAgICB0YWJsZSkKQEAgLTI0
Miw3ICsyNDgsMTAgQEAgZ28tdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAoZGVmdmFyLWtl
eW1hcCBnby10cy1tb2RlLW1hcAogICA6ZG9jICJLZXltYXAgdXNlZCBpbiBHbyBtb2RlLCBwb3dl
cmVkIGJ5IHRyZWUtc2l0dGVyIgogICA6cGFyZW50IHByb2ctbW9kZS1tYXAKLSAgIkMtYyBDLWQi
ICMnZ28tdHMtbW9kZS1kb2NzdHJpbmcpCisgICJDLWMgQy1kIiAjJ2dvLXRzLW1vZGUtZG9jc3Ry
aW5nCisgICJDLWMgQy10IHQiICMnZ28tdHMtbW9kZS10ZXN0LWZ1bmN0aW9uLWF0LXBvaW50Cisg
ICJDLWMgQy10IGYiICMnZ28tdHMtbW9kZS10ZXN0LWZpbGUKKyAgIkMtYyBDLXQgcCIgIydnby10
cy1tb2RlLXRlc3QtcGFja2FnZSkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZpbmUtZGVyaXZlZC1t
b2RlIGdvLXRzLW1vZGUgcHJvZy1tb2RlICJHbyIKQEAgLTM3NSw2ICszODQsNzkgQEAgZ28tdHMt
bW9kZS0tY29tbWVudC1vbi1wcmV2aW91cy1saW5lLXAKICAgICAgKDw9ICh0cmVlc2l0LW5vZGUt
c3RhcnQgbm9kZSkgcG9pbnQgKHRyZWVzaXQtbm9kZS1lbmQgbm9kZSkpCiAgICAgIChzdHJpbmct
ZXF1YWwgImNvbW1lbnQiICh0cmVlc2l0LW5vZGUtdHlwZSBub2RlKSkpKSkKIAorKGRlZnVuIGdv
LXRzLW1vZGUtLWdldC1idWlsZC10YWdzLWZsYWcgKCkKKyAgIlJldHVybiB0aGUgY29tcGlsZSBm
bGFnIGZvciBidWlsZCB0YWdzLgorVGhpcyBmdW5jdGlvbiByZXNwZWN0cyB0aGUgYGdvLXRzLW1v
ZGUtYnVpbGQtdGFncycgdmFyaWFibGUgZm9yCitzcGVjaWZ5aW5nIGJ1aWxkIHRhZ3MuIgorICAo
aWYgZ28tdHMtbW9kZS1idWlsZC10YWdzCisgICAgICAoZm9ybWF0ICItdGFncyAlcyIgKHN0cmlu
Zy1qb2luIGdvLXRzLW1vZGUtYnVpbGQtdGFncyAiLCIpKQorICAgICIiKSkKKworKGRlZnVuIGdv
LXRzLW1vZGUtLWNvbXBpbGUtdGVzdCAocmVnZXhwKQorICAiQ29tcGlsZSB0aGUgdGVzdHMgbWF0
Y2hpbmcgUkVHRVhQLgorVGhpcyBmdW5jdGlvbiByZXNwZWN0cyB0aGUgYGdvLXRzLW1vZGUtYnVp
bGQtdGFncycgdmFyaWFibGUgZm9yCitzcGVjaWZ5aW5nIGJ1aWxkIHRhZ3MuIgorICAoY29tcGls
ZSAoZm9ybWF0ICJnbyB0ZXN0IC12ICVzIC1ydW4gJyVzJyIKKyAgICAgICAgICAgICAgICAgICAo
Z28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZykKKyAgICAgICAgICAgICAgICAgICByZWdl
eHApKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQgKHN0YXJ0KQorICAiUmV0
dXJuIHRoZSBmaXJzdCBkZWZ1biBub2RlIGZyb20gU1RBUlQuIgorICAobGV0ICgodGhpbmcgKG9y
IHRyZWVzaXQtZGVmdW4tdHlwZS1yZWdleHAgJ2RlZnVuKSkpCisgICAgKG9yICh0cmVlc2l0LXRo
aW5nLWF0IHN0YXJ0IHRoaW5nKQorICAgICAgICAodHJlZXNpdC10aGluZy1uZXh0IHN0YXJ0IHRo
aW5nKSkpKQorCisoZGVmdW4gZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9uLXJlZ2V4cCAobmFtZSkK
KyAgKGlmIG5hbWUKKyAgICAgIChmb3JtYXQgIl4lcyQiIG5hbWUpCisgICAgKGVycm9yICJObyB0
ZXN0IGZ1bmN0aW9uIGZvdW5kIikpKQorCisoZGVmdW4gZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9u
cy1pbi1yYW5nZSAoc3RhcnQgZW5kKQorICAiUmV0dXJuIGEgbGlzdCB3aXRoIHRoZSBuYW1lcyBv
ZiBhbGwgZGVmdW5zIGluIHRoZSByYW5nZSBTVEFSVCB0byBFTkQuIgorICAobGV0KiAoKG5vZGUg
KGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQgc3RhcnQpKQorICAgICAgICAgKG5hbWUgKHRyZWVz
aXQtZGVmdW4tbmFtZSBub2RlKSkKKyAgICAgICAgIChub2RlLXN0YXJ0ICh0cmVlc2l0LW5vZGUt
c3RhcnQgbm9kZSkpCisgICAgICAgICAobm9kZS1lbmQgKHRyZWVzaXQtbm9kZS1lbmQgbm9kZSkp
KQorICAgIChpZiAob3IgKG5vdCBub2RlKQorICAgICAgICAgICAgKD4gc3RhcnQgbm9kZS1lbmQp
CisgICAgICAgICAgICAoPCBlbmQgbm9kZS1zdGFydCkpCisgICAgICAgIG5pbAorICAgICAgKGNv
bnMgKGdvLXRzLW1vZGUtLWdldC1mdW5jdGlvbi1yZWdleHAgbmFtZSkKKyAgICAgICAgICAgIChn
by10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlICh0cmVlc2l0LW5vZGUtZW5kIG5vZGUp
IGVuZCkpKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLS1nZXQtdGVzdC1yZWdleHAtYXQtcG9pbnQg
KCkKKyAgIlJldHVybiBhIHJlZ3VsYXIgZXhwcmVzc2lvbiBmb3IgdGVzdHMgYXQgcG9pbnQuCitJ
ZiByZWdpb24gaXMgYWN0aXZlLCB0aGUgcmVnZXhwIHdpbGwgaW5jbHVkZSBhbGwgdGhlIGZ1bmN0
aW9ucyB1bmRlciB0aGUKK3JlZ2lvbi4iCisgIChpZiAocmVnaW9uLWFjdGl2ZS1wKQorICAgICAg
KHN0cmluZy1qb2luIChnby10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlIChyZWdpb24t
YmVnaW5uaW5nKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIChyZWdpb24tZW5kKSkKKyAgICAgICAgICAgICAgICAgICAifCIpCisgICAgKGdv
LXRzLW1vZGUtLWdldC1mdW5jdGlvbi1yZWdleHAgKHRyZWVzaXQtZGVmdW4tbmFtZSAodHJlZXNp
dC1kZWZ1bi1hdC1wb2ludCkpKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLXRlc3QtZnVuY3Rpb24t
YXQtcG9pbnQgKCkKKyAgIlJ1biB0aGUgdW5pdCB0ZXN0IGF0IHBvaW50LgorSWYgdGhlIHBvaW50
IGlzIGFueXdoZXJlIGluIHRoZSB0ZXN0IGZ1bmN0aW9uLCB0aGF0IGZ1bmN0aW9uIHdpbGwgYmUK
K3J1bi4gIElmIHRoZSByZWdpb24gaXMgc2VsZWN0ZWQsIGFsbCB0aGUgZnVuY3Rpb25zIHVuZGVy
IHRoZSByZWdpb24gd2lsbAorYmUgcnVuLiIKKyAgICAoaW50ZXJhY3RpdmUpCisgICAgKGdvLXRz
LW1vZGUtLWNvbXBpbGUtdGVzdCAoZ28tdHMtbW9kZS0tZ2V0LXRlc3QtcmVnZXhwLWF0LXBvaW50
KSkpCisKKyhkZWZ1biBnby10cy1tb2RlLXRlc3QtZmlsZSAoKQorICAiUnVuIGFsbCB0aGUgdW5p
dCB0ZXN0cyBpbiB0aGUgY3VycmVudCBmaWxlLiIKKyAgKGludGVyYWN0aXZlKQorICAobGV0ICgo
ZGVmdW5zIChnby10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlIChwb2ludC1taW4pIChw
b2ludC1tYXgpKSkpCisgICAgKGlmIGRlZnVucworICAgICAgICAoZ28tdHMtbW9kZS0tY29tcGls
ZS10ZXN0IChzdHJpbmctam9pbiBkZWZ1bnMgInwiKSkKKyAgICAgIChlcnJvciAiTm8gdGVzdCBm
dW5jdGlvbnMgZm91bmQgaW4gdGhlIGN1cnJlbnQgZmlsZSIpKSkpCisKKyhkZWZ1biBnby10cy1t
b2RlLXRlc3QtcGFja2FnZSAoKQorICAiUnVuIGFsbCB0aGUgdW5pdCB0ZXN0cyB1bmRlciB0aGUg
Y3VycmVudCBwYWNrYWdlLiIKKyAgKGludGVyYWN0aXZlKQorICAoY29tcGlsZSAoZm9ybWF0ICJn
byB0ZXN0IC12ICVzIC1ydW4gJXMiCisgICAgICAgICAgICAgICAgICAgKGdvLXRzLW1vZGUtLWdl
dC1idWlsZC10YWdzLWZsYWcpCisgICAgICAgICAgICAgICAgICAgZGVmYXVsdC1kaXJlY3Rvcnkp
KSkKKwogOzsgZ28ubW9kIHN1cHBvcnQuCiAKIChkZWZ2YXIgZ28tbW9kLXRzLW1vZGUtLXN5bnRh
eC10YWJsZQotLSAKMi4zOS4yCgo=
--000000000000c370c8061b4236f4--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 21 Jun 2024 02:41:01 +0000
Resent-Message-ID: <handler.70939.B70939.171893762917020 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171893762917020
          (code B ref 70939); Fri, 21 Jun 2024 02:41:01 +0000
Received: (at 70939) by debbugs.gnu.org; 21 Jun 2024 02:40:29 +0000
Received: from localhost ([127.0.0.1]:52977 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sKUCS-0004QR-Md
	for submit <at> debbugs.gnu.org; Thu, 20 Jun 2024 22:40:29 -0400
Received: from mail-4317.proton.ch ([185.70.43.17]:25593)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sKUCQ-0004QC-0l
 for 70939 <at> debbugs.gnu.org; Thu, 20 Jun 2024 22:40:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1718937615; x=1719196815;
 bh=xMHD7gdNxNArtHO9L3iSzQliCpZpMPu4vUuO4jPBleQ=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=H9L2Hx6nbXSWpNzqz8BB7GXOt1lGwxYWgxrulvuZupvV3UCblfv0x8C/pT60otY44
 WCAvjPFFNRlWeL8r9S1L1vxvcV+5xzdsxHiYaY9d9o3qea9ikj45lKrCws6tGiaZXa
 NttpmBqoheWViaUDaQyAYnmDzfgiS0AP+SN273JFTLFyTUB3KzKUoykbR18i2us9VS
 ntjkiwNU7jUh4IBjXRnXTnmipZ5NKxr8ALfHpevwCe6NugBN7OSHcHuAHHtNhmszsf
 XvPSadMwptnO0e34LDYcEq9Kl6AVpT6YA3hQcA9saVKcolDqYLD1z/HjvHx7UHJm6H
 p1HIFM65H0VFQ==
Date: Fri, 21 Jun 2024 02:40:12 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
In-Reply-To: <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 3d3ba534671e914c2706e21f9ab3491c754b12ce
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wednesday, June 19th, 2024 at 14:17, Ankit Gadiya via "Bug reports for G=
NU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> wro=
te:
>=20
>=20
> Apologies for the delay in response.
>=20
> > > > A few quick things I noticed on a glance:
> > > >=20
> > > > + (let* ((node (go-ts-mode--find-defun-at start))
> > > > + (name (treesit-defun-name node))
> > > >=20
> > > > Indentation is off on the name line - looks like a TAB was used? Sh=
ould only be spaces everywhere. Double check the rest is OK.
> > > >=20
> > > > +region. It is bound to 'C-c C-t' in 'go-ts-mode'.
> > > > ^ C-c C-t t
> > > >=20
> > > > +package of the current buffer. It is bound to 'C-c C-p' in 'go-ts-=
mode'.
> > > > ^ C-c C-t p
> > > >=20
> > > > + "List of go build tags for the test commands."
> > > > ^ Go
> > > >=20
> > > > + "Return a list with names of all defuns in the range."
> > > > We should probably say what the range actually is (START to END) - =
not sure if we have a convention for that wording already.
> > >=20
> > > A few more nits:
> > > + "Return compile flag for build tags.
> > > ^ the
> > >=20
> > > +This function respects `go-ts-mode-build-tags' variable for specifyi=
ng
> > > ^ the
> > >=20
> > > + "Return a list with names of all defuns in the range."
> > > ^ the
> > >=20
> > > Indentation is also off in go-ts-mode-test-function-at-point.
> >=20
> > Thanks. I learned about whitespace-mode and checkdoc. I'll be running m=
y changes
> > through it before sending the path now. Please let me know if there are=
 any
> > other checks I can do in the future.
>=20
>=20
> I've incorporated these suggestions in my updated patch.
>=20
> > > When we run C-c C-t t outside of a function, we get:
> > > go test -v -run '^nil$'
> > > Should we maybe not bother running anything at all? What do you think=
?
> > > Do we know how other packages behave under similar circumstances?
> >=20
> > I'll check the packages and find out how it is handled elsewhere. One p=
oint of
> > reference can be Doom Emacs configuration. It uses the
> > re-search-(backward|forward) functions that throw an error if no match =
is found.
>=20
>=20
> I've updated the functions to now raise an error if no function is found =
at
> point or under the region.
>=20
> > I'm also planning to add a third function to run all the tests in the c=
urrent
> > file using the buffer-beginning and buffer-end as the range. I'll submi=
t it in
> > the next patch along with the suggested fixes.
>=20
>=20
> I've added the go-ts-mode-test-file function as well that runs all the un=
it
> tests in the current file.
>=20
> --
> Ankit

When running go-ts-mode-test-file, it seems to match things that aren't fun=
ctions like interfaces. I think we should only be matching functions, and m=
ore specifically, shouldn't we only be matching functions starting with "Te=
st"?
We could perhaps extend the error checking to include that as well?

For the commit message, I'm not sure we need that paragraph especially when=
 it's already described in the news. Eli what do you think?

+*** New unit test commands.
+Two new commands are now available to run unit tests.
Three?

I'm also wondering if we should include "current" in the go-ts-mode-test-fi=
le and go-ts-mode-test-package function names. Maybe someone would expect t=
hat they would get prompted to select a file or package to test? Maybe I'm =
overthinking that :). Eli what do you think?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 23 Jun 2024 14:48:01 +0000
Resent-Message-ID: <handler.70939.B70939.171915406225900 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171915406225900
          (code B ref 70939); Sun, 23 Jun 2024 14:48:01 +0000
Received: (at 70939) by debbugs.gnu.org; 23 Jun 2024 14:47:42 +0000
Received: from localhost ([127.0.0.1]:35591 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sLOVK-0006je-4P
	for submit <at> debbugs.gnu.org; Sun, 23 Jun 2024 10:47:42 -0400
Received: from mail-vk1-f181.google.com ([209.85.221.181]:50541)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1sLOVI-0006jI-KO
 for 70939 <at> debbugs.gnu.org; Sun, 23 Jun 2024 10:47:41 -0400
Received: by mail-vk1-f181.google.com with SMTP id
 71dfb90a1353d-4ef52ac0ff5so577728e0c.1
 for <70939 <at> debbugs.gnu.org>; Sun, 23 Jun 2024 07:47:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1719153994; x=1719758794; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=Kjj2NQa6s0xPwDDchzb1dAK0iUZFvJ4yYfEPKCkjXis=;
 b=GnSGy47tWy7G/LOrxrKlzoZvCj3jpVubZ9iJOH+gfF3KUgpRYtRi1wJrFm8oDwRBhZ
 6QuMmJ6dYCeaPy/cVopKKhfZ8E2KLcRR4VExYpShGAX3aXKrGKOsV5+ALKYfX5Fb/m8j
 N9TXOUlbl15HfbxsFwNPvuTN4gNetoLhEWFhbLrYzxfyzajOMQ9uCR7mV5f63Ia8eOVT
 dakppevTYZuoG9/nb158YcAiRC+JpqY3TNEpRtXv05tzLHmbZBmDh78L7DWDN/OmZ2JX
 qEP9qhzi6fLM2RR1X/VkUlweK8fm/oBUXE0teLNuSPpU1xgCC3fVZce2QKgJwRmTSI1E
 GT3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1719153994; x=1719758794;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=Kjj2NQa6s0xPwDDchzb1dAK0iUZFvJ4yYfEPKCkjXis=;
 b=JmhejJMP4e3lrUbzaacKxXd63pp7lHLOtBHtaExdLbisce9CMsXZHAbSAxzT3q902+
 zUZW52qVbYlTEDx6zmxCpmP8G2igAn/jxTwuUk44JtE/TSZzHSHgVxgUc6vgaOXgDqxL
 hlv5EpgMYWDxdlW0E6MY3sQxGc4BziRYLvhKRzsQFjbxAGB/R+/HsxEzndM12JRjTMuo
 6oTrXvoUrRSG5Kje488TkvOeamBJg9OCbG1ClDoIhyf0xB8dKTj3YoGuPWUsWb5RHvAd
 9/SNAuDO9v1O8IlYqudreVJ41LYWVP1w3IUBqoofMQeB/4ClmeIK6FjjXF0VwIx0YtlY
 m0AA==
X-Forwarded-Encrypted: i=1;
 AJvYcCX0Yfz5Ni6o0EZLN30A2l6wIBoSB5ecpodUAj84ISTuPGRZxoAh5M8OvHU+Hx+ui9pF41qgq1gu0kGNACUCx8IpQJrOqz8=
X-Gm-Message-State: AOJu0YwzPgGliBYQTcnS3t9cO7ZmLLRIwupjMjIp6dTLnILAF/eJFZbi
 +Z+T7aP80e41LFJXTUCvNevetO7UbcBIoRHLjSvU70rKNYaLDc8CemRpKEuLf1enqN+kQEd2RDL
 rCRxSakaxlQi+PFrAweiNCZaClxreLlOEgLmbEw==
X-Google-Smtp-Source: AGHT+IEm3GxHYA2bq5wv9Cy+SursBf2YGHSFSfOUozq+vz8UkTlmzaZPsi0vx5983Q92CZypr6/P0eTEEKKaF5EWO6o=
X-Received: by 2002:a67:fc97:0:b0:48f:4686:c2c9 with SMTP id
 ada2fe7eead31-48f529e3a8fmr1802055137.14.1719153994476; Sun, 23 Jun 2024
 07:46:34 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
In-Reply-To: <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Sun, 23 Jun 2024 20:16:23 +0530
Message-ID: <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
Content-Type: multipart/mixed; boundary="00000000000027e526061b8fbbf5"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000027e526061b8fbbf5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> When running go-ts-mode-test-file, it seems to match things that aren't f=
unctions like interfaces. I think we should only be matching functions, and=
 more specifically, shouldn't we only be matching functions starting with "=
Test"?
> We could perhaps extend the error checking to include that as well?

I've updated the patch to include a "function_declaration" and "Test" prefi=
x
check. I also did a minor refactoring to avoid special handling in the case=
 when
the region is not active. I'm also attaching the updated sample file with m=
ore
scenarios for testing.

>
> For the commit message, I'm not sure we need that paragraph especially wh=
en it's already described in the news. Eli what do you think?
>
> +*** New unit test commands.
> +Two new commands are now available to run unit tests.
> Three?
>
> I'm also wondering if we should include "current" in the go-ts-mode-test-=
file and go-ts-mode-test-package function names. Maybe someone would expect=
 that they would get prompted to select a file or package to test? Maybe I'=
m overthinking that :). Eli what do you think?

I'll wait for Eli to reply before incorporating the changes :).

Additionally, I also noticed that the emacs-30 branch is cut. I wanted
to check if I
need to rebase my patch onto master or emacs-30 branch?

--
Ankit

--00000000000027e526061b8fbbf5
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Disposition: attachment; 
	filename="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lxrnq18u0>
X-Attachment-Id: f_lxrnq18u0

RnJvbSAwMDIyMTVmMmVlOTQyNTJlZGQ2NjkwODk2M2E2NmIwMWY2MmMzNmQxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmtpdCBSIEdhZGl5YSA8Z2l0QGFyZ3AuaW4+CkRhdGU6IFR1
ZSwgMTQgTWF5IDIwMjQgMDA6MTQ6MDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBBZGQgY29tbWFu
ZHMgdG8gcnVuIHVuaXQgdGVzdHMgaW4gZ28tdHMtbW9kZQoKVGhyZWUgbmV3IGNvbW1hbmRzIGFy
ZSBhZGRlZCBpbiB0aGUgZ28tdHMtbW9kZSB0byBydW4gdW5pdCB0ZXN0cy4KVGhlIGdvLXRzLW1v
ZGUtdGVzdC1mdW5jdGlvbi1hdC1wb2ludCBjb21tYW5kIHJ1bnMgdGhlIGN1cnJlbnQKdGVzdCBm
dW5jdGlvbiBhdCBwb2ludCBvciBhbGwgdGhlIGZ1bmN0aW9ucyBpbiB0aGUgYWN0aXZlIHJlZ2lv
bgp3aGVuIHJlZ2lvbiBpcyBhY3RpdmUuICBJdCBpcyBib3VuZCB0byAiQy1jIEMtdCB0Ii4gVGhl
CmdvLXRzLW1vZGUtdGVzdC1maWxlIGNvbW1hbmQgcnVucyBhbGwgdGVzdHMgaW4gdGhlIGN1cnJl
bnQgZmlsZS4gSXQgaXMKYm91bmQgdG8gIkMtYyBDLXQgZiIuIFRoZSBnby10cy1tb2RlLXRlc3Qt
cGFja2FnZSBjb21tYW5kIHJ1bnMgYWxsIHRlc3RzCmluIHRoZSBjdXJyZW50IHBhY2thZ2UuICBJ
dCBpcyBib3VuZCB0byAiQy1jIEMtdCBwIi4KCiogbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5l
bCAoZ28tdHMtbW9kZS1idWlsZC10YWdzKTogTmV3IHZhcmlhYmxlLgooZ28tdHMtbW9kZS1tYXAp
OiBOZXcgbWFwIHZhcmlhYmxlLgooZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZyk6IE5l
dyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWNvbXBpbGUtdGVzdCk6IE5ldyBmdW5jdGlvbi4KKGdv
LXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQpOiBOZXcgZnVuY3Rpb24uCihnby10cy1tb2RlLS1nZXQt
ZnVuY3Rpb24tcmVnZXhwKTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9u
cy1pbi1yYW5nZSk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWdldC10ZXN0LXJlZ2V4cC1h
dC1wb2ludCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC1mdW5jdGlvbi1hdC1wb2lu
dCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC1maWxlKTogTmV3IGZ1bmN0aW9uLgoo
Z28tdHMtbW9kZS10ZXN0LXBhY2thZ2UpOiBOZXcgZnVuY3Rpb24uCiogZXRjL05FV1M6IE1lbnRp
b24gdGhlIGNoYW5nZS4KCihCdWcjNzA5MzkpCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICAg
ICAgICB8IDE2ICsrKysrKysKIGxpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwgfCA5MCArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTA1IGlu
c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9O
RVdTCmluZGV4IDNiMTg5NzI4NjBmLi43M2ZjYjQ2ZmFkMiAxMDA2NDQKLS0tIGEvZXRjL05FV1MK
KysrIGIvZXRjL05FV1MKQEAgLTEzODksNiArMTM4OSwyMiBAQCBUaGlzIGNvbW1hbmQgYWRkcyBh
IGRvY3N0cmluZyBjb21tZW50IHRvIHRoZSBjdXJyZW50IGRlZnVuLiAgSWYgYQogY29tbWVudCBh
bHJlYWR5IGV4aXN0cywgcG9pbnQgaXMgb25seSBtb3ZlZCB0byB0aGUgY29tbWVudC4gIEl0IGlz
CiBib3VuZCB0byAnQy1jIEMtZCcgaW4gJ2dvLXRzLW1vZGUnLgogCisqKiogTmV3IHVuaXQgdGVz
dCBjb21tYW5kcy4KK1R3byBuZXcgY29tbWFuZHMgYXJlIG5vdyBhdmFpbGFibGUgdG8gcnVuIHVu
aXQgdGVzdHMuCisKK1RoZSAnZ28tdHMtbW9kZS10ZXN0LWZ1bmN0aW9uLWF0LXBvaW50JyBjb21t
YW5kIHJ1bnMgdGhlIHVuaXQgdGVzdCBhdAorcG9pbnQuICBJZiBhIHJlZ2lvbiBpcyBhY3RpdmUs
IGl0IHJ1bnMgYWxsIHRoZSB1bml0IHRlc3RzIHVuZGVyIHRoZQorcmVnaW9uLiAgSXQgaXMgYm91
bmQgdG8gJ0MtYyBDLXQgdCcgaW4gJ2dvLXRzLW1vZGUnLgorCitUaGUgJ2dvLXRzLW1vZGUtdGVz
dC1maWxlJyBjb21tYW5kIHJ1bnMgYWxsIHVuaXQgdGVzdHMgaW4gdGhlIGN1cnJlbnQKK2ZpbGUu
IEl0IGlzIGJvdW5kIHRvICdDLWMgQy10IGYnIGluICdnby10cy1tb2RlJy4KKworVGhlICdnby10
cy1tb2RlLXRlc3QtcGFja2FnZScgY29tbWFuZCBydW5zIGFsbCB1bml0IHRlc3RzIHVuZGVyIHRo
ZQorcGFja2FnZSBvZiB0aGUgY3VycmVudCBidWZmZXIuICBJdCBpcyBib3VuZCB0byAnQy1jIEMt
dCBwJyBpbiAnZ28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS1idWlsZC10YWdzJyB2YXJp
YWJsZSBpcyBhdmFpbGFibGUgdG8gc2V0IGEgbGlzdCBvZiBidWlsZAordGFncyBmb3IgdGhlIHRl
c3QgY29tbWFuZHMuCisKICoqIE1hbiBtb2RlCiAKICsrKwpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9n
bW9kZXMvZ28tdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKaW5kZXgg
MmQzZTZhYWMwOTAuLjhkMjNiMjMwYzNmIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9nby10
cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKQEAgLTQ2LDYgKzQ2
LDEyIEBAIGdvLXRzLW1vZGUtaW5kZW50LW9mZnNldAogICA6c2FmZSAnaW50ZWdlcnAKICAgOmdy
b3VwICdnbykKIAorKGRlZmN1c3RvbSBnby10cy1tb2RlLWJ1aWxkLXRhZ3MgbmlsCisgICJMaXN0
IG9mIEdvIGJ1aWxkIHRhZ3MgZm9yIHRoZSB0ZXN0IGNvbW1hbmRzLiIKKyAgOnZlcnNpb24gIjMw
LjEiCisgIDp0eXBlICcocmVwZWF0IHN0cmluZykKKyAgOmdyb3VwICdnbykKKwogKGRlZnZhciBn
by10cy1tb2RlLS1zeW50YXgtdGFibGUKICAgKGxldCAoKHRhYmxlIChtYWtlLXN5bnRheC10YWJs
ZSkpKQogICAgIChtb2RpZnktc3ludGF4LWVudHJ5ID8rICAgIi4iICAgICAgdGFibGUpCkBAIC0y
NDIsNyArMjQ4LDEwIEBAIGdvLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogKGRlZnZhci1r
ZXltYXAgZ28tdHMtbW9kZS1tYXAKICAgOmRvYyAiS2V5bWFwIHVzZWQgaW4gR28gbW9kZSwgcG93
ZXJlZCBieSB0cmVlLXNpdHRlciIKICAgOnBhcmVudCBwcm9nLW1vZGUtbWFwCi0gICJDLWMgQy1k
IiAjJ2dvLXRzLW1vZGUtZG9jc3RyaW5nKQorICAiQy1jIEMtZCIgIydnby10cy1tb2RlLWRvY3N0
cmluZworICAiQy1jIEMtdCB0IiAjJ2dvLXRzLW1vZGUtdGVzdC1mdW5jdGlvbi1hdC1wb2ludAor
ICAiQy1jIEMtdCBmIiAjJ2dvLXRzLW1vZGUtdGVzdC1maWxlCisgICJDLWMgQy10IHAiICMnZ28t
dHMtbW9kZS10ZXN0LXBhY2thZ2UpCiAKIDs7OyMjI2F1dG9sb2FkCiAoZGVmaW5lLWRlcml2ZWQt
bW9kZSBnby10cy1tb2RlIHByb2ctbW9kZSAiR28iCkBAIC0zNzUsNiArMzg0LDg1IEBAIGdvLXRz
LW1vZGUtLWNvbW1lbnQtb24tcHJldmlvdXMtbGluZS1wCiAgICAgICg8PSAodHJlZXNpdC1ub2Rl
LXN0YXJ0IG5vZGUpIHBvaW50ICh0cmVlc2l0LW5vZGUtZW5kIG5vZGUpKQogICAgICAoc3RyaW5n
LWVxdWFsICJjb21tZW50IiAodHJlZXNpdC1ub2RlLXR5cGUgbm9kZSkpKSkpCiAKKyhkZWZ1biBn
by10cy1tb2RlLS1nZXQtYnVpbGQtdGFncy1mbGFnICgpCisgICJSZXR1cm4gdGhlIGNvbXBpbGUg
ZmxhZyBmb3IgYnVpbGQgdGFncy4KK1RoaXMgZnVuY3Rpb24gcmVzcGVjdHMgdGhlIGBnby10cy1t
b2RlLWJ1aWxkLXRhZ3MnIHZhcmlhYmxlIGZvcgorc3BlY2lmeWluZyBidWlsZCB0YWdzLiIKKyAg
KGlmIGdvLXRzLW1vZGUtYnVpbGQtdGFncworICAgICAgKGZvcm1hdCAiLXRhZ3MgJXMiIChzdHJp
bmctam9pbiBnby10cy1tb2RlLWJ1aWxkLXRhZ3MgIiwiKSkKKyAgICAiIikpCisKKyhkZWZ1biBn
by10cy1tb2RlLS1jb21waWxlLXRlc3QgKHJlZ2V4cCkKKyAgIkNvbXBpbGUgdGhlIHRlc3RzIG1h
dGNoaW5nIFJFR0VYUC4KK1RoaXMgZnVuY3Rpb24gcmVzcGVjdHMgdGhlIGBnby10cy1tb2RlLWJ1
aWxkLXRhZ3MnIHZhcmlhYmxlIGZvcgorc3BlY2lmeWluZyBidWlsZCB0YWdzLiIKKyAgKGNvbXBp
bGUgKGZvcm1hdCAiZ28gdGVzdCAtdiAlcyAtcnVuICclcyciCisgICAgICAgICAgICAgICAgICAg
KGdvLXRzLW1vZGUtLWdldC1idWlsZC10YWdzLWZsYWcpCisgICAgICAgICAgICAgICAgICAgcmVn
ZXhwKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLS1maW5kLWRlZnVuLWF0IChzdGFydCkKKyAgIlJl
dHVybiB0aGUgZmlyc3QgZGVmdW4gbm9kZSBmcm9tIFNUQVJULiIKKyAgKGxldCAoKHRoaW5nIChv
ciB0cmVlc2l0LWRlZnVuLXR5cGUtcmVnZXhwICdkZWZ1bikpKQorICAgIChvciAodHJlZXNpdC10
aGluZy1hdCBzdGFydCB0aGluZykKKyAgICAgICAgKHRyZWVzaXQtdGhpbmctbmV4dCBzdGFydCB0
aGluZykpKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtLWdldC1mdW5jdGlvbi1yZWdleHAgKG5hbWUp
CisgIChpZiBuYW1lCisgICAgICAoZm9ybWF0ICJeJXMkIiBuYW1lKQorICAgIChlcnJvciAiTm8g
dGVzdCBmdW5jdGlvbiBmb3VuZCIpKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtLWdldC1mdW5jdGlv
bnMtaW4tcmFuZ2UgKHN0YXJ0IGVuZCkKKyAgIlJldHVybiBhIGxpc3Qgd2l0aCB0aGUgbmFtZXMg
b2YgYWxsIGRlZnVucyBpbiB0aGUgcmFuZ2UgU1RBUlQgdG8gRU5ELiIKKyAgKGxldCogKChub2Rl
IChnby10cy1tb2RlLS1maW5kLWRlZnVuLWF0IHN0YXJ0KSkKKyAgICAgICAgIChuYW1lICh0cmVl
c2l0LWRlZnVuLW5hbWUgbm9kZSkpCisgICAgICAgICAobm9kZS1zdGFydCAodHJlZXNpdC1ub2Rl
LXN0YXJ0IG5vZGUpKQorICAgICAgICAgKG5vZGUtZW5kICh0cmVlc2l0LW5vZGUtZW5kIG5vZGUp
KSkKKyAgICAoY29uZCAoKG9yIChub3Qgbm9kZSkKKyAgICAgICAgICAgICAgICg+IHN0YXJ0IG5v
ZGUtZW5kKQorICAgICAgICAgICAgICAgKDwgZW5kIG5vZGUtc3RhcnQpKQorICAgICAgICAgICBu
aWwpCisgICAgICAgICAgKChvciAobm90IChlcXVhbCAodHJlZXNpdC1ub2RlLXR5cGUgbm9kZSkg
ImZ1bmN0aW9uX2RlY2xhcmF0aW9uIikpCisgICAgICAgICAgICAgICAobm90IChzdHJpbmctcHJl
Zml4LXAgIlRlc3QiIG5hbWUpKSkKKyAgICAgICAgICAgKGdvLXRzLW1vZGUtLWdldC1mdW5jdGlv
bnMtaW4tcmFuZ2UgKHRyZWVzaXQtbm9kZS1lbmQgbm9kZSkgZW5kKSkKKyAgICAgICAgICAodAor
ICAgICAgICAgICAoY29ucyAoZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9uLXJlZ2V4cCBuYW1lKQor
ICAgICAgICAgICAgICAgICAoZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9ucy1pbi1yYW5nZSAodHJl
ZXNpdC1ub2RlLWVuZCBub2RlKSBlbmQpKSkpKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtLWdldC10
ZXN0LXJlZ2V4cC1hdC1wb2ludCAoKQorICAiUmV0dXJuIGEgcmVndWxhciBleHByZXNzaW9uIGZv
ciB0ZXN0cyBhdCBwb2ludC4KK0lmIHJlZ2lvbiBpcyBhY3RpdmUsIHRoZSByZWdleHAgd2lsbCBp
bmNsdWRlIGFsbCB0aGUgZnVuY3Rpb25zIHVuZGVyIHRoZQorcmVnaW9uLiIKKyAgKGxldCogKChy
YW5nZSAoaWYgKHJlZ2lvbi1hY3RpdmUtcCkKKyAgICAgICAgICAgICAgICAgICAgKGxpc3QgKHJl
Z2lvbi1iZWdpbm5pbmcpIChyZWdpb24tZW5kKSkKKyAgICAgICAgICAgICAgICAgIChsaXN0IChw
b2ludCkgKHBvaW50KSkpKQorICAgICAgICAgKGZ1bmNzIChhcHBseSAjJ2dvLXRzLW1vZGUtLWdl
dC1mdW5jdGlvbnMtaW4tcmFuZ2UgcmFuZ2UpKSkKKyAgICAoaWYgZnVuY3MKKyAgICAgIChzdHJp
bmctam9pbiBmdW5jcyAifCIpCisgICAgKGVycm9yICJObyB0ZXN0IGZ1bmN0aW9uIGZvdW5kIikp
KSkKKworKGRlZnVuIGdvLXRzLW1vZGUtdGVzdC1mdW5jdGlvbi1hdC1wb2ludCAoKQorICAiUnVu
IHRoZSB1bml0IHRlc3QgYXQgcG9pbnQuCitJZiB0aGUgcG9pbnQgaXMgYW55d2hlcmUgaW4gdGhl
IHRlc3QgZnVuY3Rpb24sIHRoYXQgZnVuY3Rpb24gd2lsbCBiZQorcnVuLiAgSWYgdGhlIHJlZ2lv
biBpcyBzZWxlY3RlZCwgYWxsIHRoZSBmdW5jdGlvbnMgdW5kZXIgdGhlIHJlZ2lvbiB3aWxsCiti
ZSBydW4uIgorICAgIChpbnRlcmFjdGl2ZSkKKyAgICAoZ28tdHMtbW9kZS0tY29tcGlsZS10ZXN0
IChnby10cy1tb2RlLS1nZXQtdGVzdC1yZWdleHAtYXQtcG9pbnQpKSkKKworKGRlZnVuIGdvLXRz
LW1vZGUtdGVzdC1maWxlICgpCisgICJSdW4gYWxsIHRoZSB1bml0IHRlc3RzIGluIHRoZSBjdXJy
ZW50IGZpbGUuIgorICAoaW50ZXJhY3RpdmUpCisgIChsZXQgKChkZWZ1bnMgKGdvLXRzLW1vZGUt
LWdldC1mdW5jdGlvbnMtaW4tcmFuZ2UgKHBvaW50LW1pbikgKHBvaW50LW1heCkpKSkKKyAgICAo
aWYgZGVmdW5zCisgICAgICAgIChnby10cy1tb2RlLS1jb21waWxlLXRlc3QgKHN0cmluZy1qb2lu
IGRlZnVucyAifCIpKQorICAgICAgKGVycm9yICJObyB0ZXN0IGZ1bmN0aW9ucyBmb3VuZCBpbiB0
aGUgY3VycmVudCBmaWxlIikpKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtdGVzdC1wYWNrYWdlICgp
CisgICJSdW4gYWxsIHRoZSB1bml0IHRlc3RzIHVuZGVyIHRoZSBjdXJyZW50IHBhY2thZ2UuIgor
ICAoaW50ZXJhY3RpdmUpCisgIChjb21waWxlIChmb3JtYXQgImdvIHRlc3QgLXYgJXMgLXJ1biAl
cyIKKyAgICAgICAgICAgICAgICAgICAoZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZykK
KyAgICAgICAgICAgICAgICAgICBkZWZhdWx0LWRpcmVjdG9yeSkpKQorCiA7OyBnby5tb2Qgc3Vw
cG9ydC4KIAogKGRlZnZhciBnby1tb2QtdHMtbW9kZS0tc3ludGF4LXRhYmxlCi0tIAoyLjM5LjIK
Cg==
--00000000000027e526061b8fbbf5
Content-Type: text/x-go; charset="US-ASCII"; name="sample_test.go"
Content-Disposition: attachment; filename="sample_test.go"
Content-Transfer-Encoding: base64
Content-ID: <f_lxrnqi6m1>
X-Attachment-Id: f_lxrnqi6m1

cGFja2FnZSBzYW1wbGVfdGVzdAoKaW1wb3J0ICJ0ZXN0aW5nIgoKdHlwZSBGb28gaW50ZXJmYWNl
e30KCnR5cGUgQmFyIHN0cnVjdHt9CgpmdW5jIChiICpCYXIpIE1ldGhvZCgpIHsKfQoKZnVuYyBU
ZXN0SW5kaXZpZHVhbCh0ICp0ZXN0aW5nLlQpIHsKfQoKZnVuYyBUZXN0SW5kaXZpZHVhbEZvb0Jh
cih0ICp0ZXN0aW5nLlQpIHsKfQoKZnVuYyBUZXN0T3ZlcmxhcFJlZ2lvbih0ICp0ZXN0aW5nLlQp
IHsKfQoKZnVuYyB0ZXN0SGVscGVyKCkge30KCmZ1bmMgbm9uVGVzdCgpIHt9CgpmdW5jIFRlc3RO
ZXdPdmVybGFwUmVnaW9uKHQgKnRlc3RpbmcuVCkgewp9Cg==
--00000000000027e526061b8fbbf5--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 23 Jun 2024 14:57:01 +0000
Resent-Message-ID: <handler.70939.B70939.171915457727160 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: ankit@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171915457727160
          (code B ref 70939); Sun, 23 Jun 2024 14:57:01 +0000
Received: (at 70939) by debbugs.gnu.org; 23 Jun 2024 14:56:17 +0000
Received: from localhost ([127.0.0.1]:35945 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sLOdd-00073z-F0
	for submit <at> debbugs.gnu.org; Sun, 23 Jun 2024 10:56:17 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45534)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sLOdb-00073e-FT
 for 70939 <at> debbugs.gnu.org; Sun, 23 Jun 2024 10:56:16 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sLOdT-0006ZO-B0; Sun, 23 Jun 2024 10:56:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=bHH470X49bTpdNxtRgXB+7vUQO6aPtmAcJiOhu57M6s=; b=SsyWE9mp3yUi
 4tXghm+RNuwdQ7txLodB8Psad3UI8ifMTvaTMSicZyRCAfQ1Pw2m51+wTT2A6AzPwyaOEuX0w/3WA
 ikf1iiz6P3m5qHMdlV7EAHxnOMWqL7D9y7tTLZB7Oy12dvnSDeEA0Mo2d91qtzVfEBK1w9R0y8y1Y
 uE2MC87GJxtFj1ZYob2+CmGhflX7twFOpwxOOqHBrMgV1Z1snSRl4euE5Ev+Vg2dIbDkD7VjNjPjB
 Q9SuFHsOYy4dh03NpoQB80bJls/+SWFdXm/qRPPX6yD59yn5NUWa1UuOTjyPo/fF7MvsQr5IvcVmz
 CbejQrwZ6Hc5wmDa8PMRow==;
Date: Sun, 23 Jun 2024 17:56:02 +0300
Message-Id: <861q4nemil.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 (message from Randy Taylor on Fri, 21 Jun 2024 02:40:12 +0000)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <868r0ajh5j.fsf@HIDDEN>
 <CAN7zea1_xU9jbe2F2XaMC4E5y9T8CS=-LR=xt_2zSrsc-UWifg@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Fri, 21 Jun 2024 02:40:12 +0000
> From: Randy Taylor <dev@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
> 
> For the commit message, I'm not sure we need that paragraph especially when it's already described in the news. Eli what do you think?

Yes, the commit log doesn't need to say again what is already in NEWS,
it can be shorter.

> I'm also wondering if we should include "current" in the go-ts-mode-test-file and go-ts-mode-test-package function names. Maybe someone would expect that they would get prompted to select a file or package to test? Maybe I'm overthinking that :). Eli what do you think?

I'd use "this" instead of "current".

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 26 Jun 2024 02:31:01 +0000
Resent-Message-ID: <handler.70939.B70939.171936900120899 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171936900120899
          (code B ref 70939); Wed, 26 Jun 2024 02:31:01 +0000
Received: (at 70939) by debbugs.gnu.org; 26 Jun 2024 02:30:01 +0000
Received: from localhost ([127.0.0.1]:37795 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sMIPw-0005QR-Be
	for submit <at> debbugs.gnu.org; Tue, 25 Jun 2024 22:30:01 -0400
Received: from mail-41103.protonmail.ch ([185.70.41.103]:59757)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sMIPd-0005P4-A1
 for 70939 <at> debbugs.gnu.org; Tue, 25 Jun 2024 22:29:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1719368801; x=1719628001;
 bh=5jMXCaQFOaEu6co2Wz5kU+zzlKdCvLAWVst0PFlePMI=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=sNhc3uiKwq2enY8q3dzBZ8wvDnsGP/aMv8knQHvIqg2nrac4ocz3XvNhZH0TOxMhs
 ku2/YNs34xS/ENHZMJ4e4Ck7Zrno/Xoq7sX4aj+tR8PCI8LOBTW2f9S6HyzRGzzc62
 9ZjjbwdM7pDm+DQIhqbvqetJnF1fZluceCLrmVhGJaI6jZX+iPRDyB596GJctflF+n
 InXBonTXRQRmtuenvrN/gnId+Bm0Yi888MZYZI3LdmcK6lPtvem99xRwk1UxRphkxP
 1yb2LjAqX8tEGGyDuFBxw6lpSbl7crcSks3N0tcXUfakzniW1YVJZzLu+2R4OpiDRK
 SXPW905qAC3Ag==
Date: Wed, 26 Jun 2024 02:26:35 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
In-Reply-To: <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 406104aa6ff2c98f94474526ad451c7456807cef
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Sunday, June 23rd, 2024 at 10:46, Ankit Gadiya <ankit@HIDDEN> wrote:
>=20
>=20
> > When running go-ts-mode-test-file, it seems to match things that aren't=
 functions like interfaces. I think we should only be matching functions, a=
nd more specifically, shouldn't we only be matching functions starting with=
 "Test"?
>=20
> > We could perhaps extend the error checking to include that as well?
>=20
>=20
> I've updated the patch to include a "function_declaration" and "Test" pre=
fix
> check. I also did a minor refactoring to avoid special handling in the ca=
se when
> the region is not active. I'm also attaching the updated sample file with=
 more
> scenarios for testing.

Thanks, the changes look good to me.

>=20
> > For the commit message, I'm not sure we need that paragraph especially =
when it's already described in the news. Eli what do you think?
> >=20
> > +*** New unit test commands.
> > +Two new commands are now available to run unit tests.
> > Three?

This still needs to be updated.

A few more comments:
+(defun go-ts-mode--get-test-regexp-at-point ()
+  "Return a regular expression for tests at point.
                                   ^ the

Could go-ts-mode--get-test-regexp-at-point and go-ts-mode-test-file use if-=
let?

Also, the indentation looks off in go-ts-mode-test-function-at-point (2 ext=
ra spaces methinks).

> >=20
> > I'm also wondering if we should include "current" in the go-ts-mode-tes=
t-file and go-ts-mode-test-package function names. Maybe someone would expe=
ct that they would get prompted to select a file or package to test? Maybe =
I'm overthinking that :). Eli what do you think?
>=20
>=20
> I'll wait for Eli to reply before incorporating the changes :).

And he chimed in - let's go with his suggestions.

>=20
> Additionally, I also noticed that the emacs-30 branch is cut. I wanted
> to check if I
> need to rebase my patch onto master or emacs-30 branch?

I would guess master, but let's see what Eli says.

>=20
> --
> Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 26 Jun 2024 11:28:02 +0000
Resent-Message-ID: <handler.70939.B70939.171940126010661 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: ankit@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171940126010661
          (code B ref 70939); Wed, 26 Jun 2024 11:28:02 +0000
Received: (at 70939) by debbugs.gnu.org; 26 Jun 2024 11:27:40 +0000
Received: from localhost ([127.0.0.1]:38671 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sMQoN-0002lt-Q1
	for submit <at> debbugs.gnu.org; Wed, 26 Jun 2024 07:27:40 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34216)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sMQoM-0002la-AT
 for 70939 <at> debbugs.gnu.org; Wed, 26 Jun 2024 07:27:38 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sMQoE-0001zY-Cw; Wed, 26 Jun 2024 07:27:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=plD6rb3wJfsvoY0LaSxUPrjMgGOVARaOq9/P1nYGe0E=; b=QustSARjv+WK
 yjBxzRJ6Y472yBN4OT+FFwXPWAQY7XAjSRQHRpiABL5Lau4gSIiiJtuC2DG3q8EKetQFsM9DlY9L9
 Q7bJMAymHnMzTCeg5TlYD9ZgxlIq3GQC3F/QmdszoPma/nselUQDlWWNH+WmBJOxrOdwmH29NLxpN
 imXkT+8WdOA9qtXXD7juVAjS730VxtFdtDVgYr5HaHLuUlar25cyKNlmUUycA6TSsQKj2nhvCykvR
 JPORJX5guMDcFIVRRXcZ8RqwqpzRnlbAH00ocQYI9kDIddhwDIdPBmiNSFBacGOPGLBYU0krIU+xO
 zur73Y7SzT38Eluej6gBFQ==;
Date: Wed, 26 Jun 2024 14:27:28 +0300
Message-Id: <8634p09c67.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 (message from Randy Taylor on Wed, 26 Jun 2024 02:26:35 +0000)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 26 Jun 2024 02:26:35 +0000
> From: Randy Taylor <dev@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
> 
> > Additionally, I also noticed that the emacs-30 branch is cut. I wanted
> > to check if I
> > need to rebase my patch onto master or emacs-30 branch?
> 
> I would guess master, but let's see what Eli says.

I don't think it's urgent to have this on the release branch, is it?
If it isn't urgent, then I prefer master.

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 26 Jun 2024 12:32:02 +0000
Resent-Message-ID: <handler.70939.B70939.171940509527472 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: ankit@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.171940509527472
          (code B ref 70939); Wed, 26 Jun 2024 12:32:02 +0000
Received: (at 70939) by debbugs.gnu.org; 26 Jun 2024 12:31:35 +0000
Received: from localhost ([127.0.0.1]:38731 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sMRoF-000791-1e
	for submit <at> debbugs.gnu.org; Wed, 26 Jun 2024 08:31:35 -0400
Received: from mail-4022.proton.ch ([185.70.40.22]:34239)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sMRoC-00078n-CC
 for 70939 <at> debbugs.gnu.org; Wed, 26 Jun 2024 08:31:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1719405083; x=1719664283;
 bh=lHM3tbjwNUnAxtXYtRK3PGKWuXAaW4/JzrxqOwlUj38=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=GB0/0bqJD96B1AvF3aYr8h0givPuAuHF7zlVlYa7BEC1wQ5syA796bZG5HbzMkY1U
 prCGqLvuWYKLdXqCUK2s131kZ8yQXuKwBXB4cPhoRqEi3yQ0rsoyy6UxbvCSQqZpVy
 gSsXOZqX1AqwKqUfEIG76uGhG2hj9lxtMcJF7fXBJIaWy5/32kWdezARorsMVcljI2
 fUHwznMF4OHAmmJZvvUztNWraebUpnkoaZV4/2ZOLpf3c6pJDdUXb1eWzdRojGYtkO
 qNoPlxx0eqFfQFM6jtskT7fUnFSypfPsvdIXKsRhqe6n+4QBXiwTjOsxOSgdof3YeL
 PjY8mANWbD+vQ==
Date: Wed, 26 Jun 2024 12:31:21 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <kgHBtQdzviuwXvRt1AEfOzyfNN-Ht_Oe1qUFKhQcQnPPyjiYp1x_Ne4PX9ZCR0BetxHFy1QbYThu8cn9z-ORBn6I-IBcffWMjKQrCI6LMlY=@rjt.dev>
In-Reply-To: <8634p09c67.fsf@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <8634p09c67.fsf@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: c84e6dcd519e7e73c4c685f43d325f25816f8565
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wednesday, June 26th, 2024 at 07:27, Eli Zaretskii <eliz@HIDDEN> wrote:
>=20
>=20
> > Date: Wed, 26 Jun 2024 02:26:35 +0000
>=20
> > From: Randy Taylor dev@HIDDEN
> > Cc: Eli Zaretskii eliz@HIDDEN, 70939 <at> debbugs.gnu.org
> >=20
> > > Additionally, I also noticed that the emacs-30 branch is cut. I wante=
d
> > > to check if I
> > > need to rebase my patch onto master or emacs-30 branch?
> >=20
> > I would guess master, but let's see what Eli says.
>=20
>=20
> I don't think it's urgent to have this on the release branch, is it?
> If it isn't urgent, then I prefer master.
>=20
> Thanks.

Not urgent at all. Master it is, thanks.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 30 Jun 2024 05:46:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 30 01:46:04 2024
Received: from localhost ([127.0.0.1]:54542 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sNnO0-0006vR-5i
	for submit <at> debbugs.gnu.org; Sun, 30 Jun 2024 01:46:04 -0400
Received: from mail-lj1-f178.google.com ([209.85.208.178]:51685)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1sNnNy-0006fF-8R
 for control <at> debbugs.gnu.org; Sun, 30 Jun 2024 01:46:02 -0400
Received: by mail-lj1-f178.google.com with SMTP id
 38308e7fff4ca-2ec1ac1aed2so22363821fa.3
 for <control <at> debbugs.gnu.org>; Sat, 29 Jun 2024 22:46:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1719726297; x=1720331097; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=xAHILCWsoG5Ume1UHNOwyJJ1ba7f6Bo31aljSMNuAR8=;
 b=XguqMpj8lzwyOB3YhYMq7I76nNcFHYhYtbPw0Arg+RWx1FlxmCemS06ARpR+2srHLb
 /xmsy8lqJzpAP+ky5SO5GlQcmfURxd405O3nt/RnnZ3SHYyn1DzV45VrksHj7CGK5Zym
 gj+3u/eqWD3mm6qsMgLR/djf4BJVgULDVe+MLt7PHv3FGLyAY87GJukFbJurk56oKmGU
 8nfpz8rlviyDhcZJHb1aVEnLxxf1hL3lqfFnc9JAFaxFgAc/M/MTizl3m8X2IEYIEBf/
 fnfR2bQzcYcAzHFKEvrX4hoNiCE0rHwyVge1WQ3z5ERLf7fDNsRdGZDik0j4q3sgnzvx
 NhDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1719726297; x=1720331097;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=xAHILCWsoG5Ume1UHNOwyJJ1ba7f6Bo31aljSMNuAR8=;
 b=BM6GGuL1q7c+agl9Sx7yu3XtFLDIdP3YSn9VC7omBkZqr6JNNiLswhfAIKvBkEDzW7
 EBQzIqpMOvOonHUB/3YBGeVZ7Z3sBV5k3UtzjSGV8/NikIvxzcMETpr99+N4E4surSIJ
 KCnn12ipRKdezQpAP1oAeU+Xl/KUjC+KuQB/p4AT7P1j5vydRHGSfWJ/K3d8ZnJVYyxj
 1lJydrscPu7JZfldNmlEEQFDasbKqP2e2fkZHaGcS7iqDovK9pMF/ZfvW/rbmzlES1iT
 kEf+e5BRYAwvVKdZiBk6dQsDKQyaX/yGW1JBRIgRWSjODW/+6RjSVShp96nF3yIsoSHp
 pBCA==
X-Gm-Message-State: AOJu0Yxm/timTcCk3+OBTJHBaP/yGxPvqtjT2zWyqA5vncjZDK/lehz2
 WaMzDCGKQzMpKlmUIXXsotQN0rcmctyXg6luz5VpYEUexnweiS33tfqUrE/eITW24HVn9NhOgCP
 5GZAnHgg6KLWyrOJDotS5qf8iruAnIHaC2C0=
X-Google-Smtp-Source: AGHT+IEypeB0oXxPCVeWuLVANgOFeduNTkB9hFyqvXpzd5asGBm+eNknqyAIKRGTIIby3QERjdmmUmcHy9UAI/YplYs=
X-Received: by 2002:a2e:8907:0:b0:2ec:18e5:e68f with SMTP id
 38308e7fff4ca-2ee5e6e024amr14596871fa.33.1719726296490; Sat, 29 Jun 2024
 22:44:56 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 29 Jun 2024 22:44:56 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Sat, 29 Jun 2024 22:44:56 -0700
Message-ID: <CADwFkmnDuGDWnb6ACOBXCRcJsuZUPUGzHDTZPwakcEMOo_w7eg@HIDDEN>
Subject: control message for bug #70939
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 70939 wishlist
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 06 Jul 2024 19:46:01 +0000
Resent-Message-ID: <handler.70939.B70939.17202951248851 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17202951248851
          (code B ref 70939); Sat, 06 Jul 2024 19:46:01 +0000
Received: (at 70939) by debbugs.gnu.org; 6 Jul 2024 19:45:24 +0000
Received: from localhost ([127.0.0.1]:46771 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sQBLX-0002Ih-M9
	for submit <at> debbugs.gnu.org; Sat, 06 Jul 2024 15:45:23 -0400
Received: from mail-yw1-f179.google.com ([209.85.128.179]:59826)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1sQBLV-0002IP-Jn
 for 70939 <at> debbugs.gnu.org; Sat, 06 Jul 2024 15:45:22 -0400
Received: by mail-yw1-f179.google.com with SMTP id
 00721157ae682-64f2fe21015so24754787b3.3
 for <70939 <at> debbugs.gnu.org>; Sat, 06 Jul 2024 12:45:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1720295052; x=1720899852; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=cT+y4aHXifScHh+vrW+fN5y9wVgL1n1yHSrsU0ZkpQQ=;
 b=BYzDxjYHiem0XSo2l6r89PjKkdkaA4Rk9wr3MlErc8oQ5VQcE+63PqlOAr+any3ZMF
 KdVRZQWztK6+utSBcYRPN0wS7VWH7K2IbiUTAe4XoDLN57hXro8kmqt9dsMjJsJ5GGs3
 SkPSE0s1usXUvpqJ/Wg2aVdnxpgL3gXkEIxRE5/EBXL3vxV8BQRNoIKBVyyVyZzsTiZu
 IMh4P7QoSHfvab4GYctMl9iEZl6g+ctR4Yr/pMvImq+I4Y1eF5x5KuVJQNH3+vgyFEgE
 vTRe2RZgiCAwgDSgp1aQAdEvqb2SjhyB/OquyVb1mBleEeoRRUrOk6A0NjbTzWy7gNHw
 SY7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1720295052; x=1720899852;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=cT+y4aHXifScHh+vrW+fN5y9wVgL1n1yHSrsU0ZkpQQ=;
 b=XnbrLCRWO140MSUs7IX8G1j77Mch2ErnICDPn6cbfyoVixmlK4snFa/19my9k/7hed
 bDs7vSAlDY4p/i9jwntasdUKq+PUPaoS/iuTp/LVxEDlvz14zfihiF5lydl808SiYvaa
 vA0aTegHmXf2QBHyklH8OBiHKFirgrS3IpzLMDfgBciduuw2Z8ycBAnpSq6cnJN8GIct
 JtLX1HHRqSHLzu7j0tp6aI7J0flGMgMBwnbvGcFJnJWEPAlUrGMRzzO+nHXvXtFrds61
 SNII4xmvF8m/YPPnffCWmc//flcBUUFeWGce5vqr1Q1QGrbZ018u8QRw1XXJ9AcO2qqb
 +1IQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCXiEqFPFh4kMhb3GzfnRoSU964bHNaSAdmUS528jniQZoHGQsGUtjzRkBQ3tcqHH3nTddLJWc9cuAwcP/DKz1aYkWXvv8c=
X-Gm-Message-State: AOJu0YzHx8wyZekrFeFzspHs+Tw0VggKeMF7aDVoEZJTEhHSOXhY2Siy
 1vFmaTVVfvDfQ1R13EaF9s6VwjMKOmLxu79fanc00m4l4IX6EUWvIli3eu17saVq1r9n3AdjLBZ
 Kpmpge607CvfDrFblGNwvCWU5RbuBDCI8Q6z6P+y+zDxOnEOGCZg=
X-Google-Smtp-Source: AGHT+IFYQJHkYmInSH71PXW6ZcIAL/iKUHtyXne2CO8/xjd/QMMeYd6zF7QRNYkGrM10J5VhSAtEi6fs6xDtyi+85io=
X-Received: by 2002:a0d:fc05:0:b0:64b:7e17:b339 with SMTP id
 00721157ae682-655fa53c6bamr11331907b3.15.1720295052133; Sat, 06 Jul 2024
 12:44:12 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
In-Reply-To: <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Sun, 7 Jul 2024 01:14:01 +0530
Message-ID: <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
Content-Type: multipart/mixed; boundary="0000000000007e45af061c9967a1"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000007e45af061c9967a1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Apologies for the delay again.

> > > For the commit message, I'm not sure we need that paragraph especiall=
y when it's already described in the news. Eli what do you think?

Thanks Randy and Eli, I've updated the commit message to be shorter now.

> > > +*** New unit test commands.
> > > +Two new commands are now available to run unit tests.
> > > Three?
>
> This still needs to be updated.

Thanks, I fixed it.

>
> A few more comments:
> +(defun go-ts-mode--get-test-regexp-at-point ()
> +  "Return a regular expression for tests at point.
>                                    ^ the
>
> Could go-ts-mode--get-test-regexp-at-point and go-ts-mode-test-file use i=
f-let?

I wasn't familiar with if-let, thanks for this. Incorporated it in
both the functions.

>
> Also, the indentation looks off in go-ts-mode-test-function-at-point (2 e=
xtra spaces methinks).

Fixed this, thanks.

>
> > >
> > > I'm also wondering if we should include "current" in the go-ts-mode-t=
est-file and go-ts-mode-test-package function names. Maybe someone would ex=
pect that they would get prompted to select a file or package to test? Mayb=
e I'm overthinking that :). Eli what do you think?
> >
> >
> > I'll wait for Eli to reply before incorporating the changes :).
>
> And he chimed in - let's go with his suggestions.

Updated both the function names.
go-ts-mode-test-this-file
go-ts-mode-test-this-package


> > Additionally, I also noticed that the emacs-30 branch is cut. I wanted
> > to check if I
> > need to rebase my patch onto master or emacs-30 branch?
>
> I would guess master, but let's see what Eli says.

I rebased my patch on the master now. Requesting a re-review.

Thanks

--
Ankit

--0000000000007e45af061c9967a1
Content-Type: application/octet-stream; 
	name="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Disposition: attachment; 
	filename="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lyaj8xws0>
X-Attachment-Id: f_lyaj8xws0

RnJvbSA0YmU1NzdkZWZjOTljMDYwOTFmYzBlMjk1NDcwN2NjNTEzNzNiZmVjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmtpdCBSIEdhZGl5YSA8Z2l0QGFyZ3AuaW4+CkRhdGU6IFR1
ZSwgMTQgTWF5IDIwMjQgMDA6MTQ6MDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBBZGQgY29tbWFu
ZHMgdG8gcnVuIHVuaXQgdGVzdHMgaW4gZ28tdHMtbW9kZQoKVGhyZWUgbmV3IGNvbW1hbmRzIGFy
ZSBhZGRlZCBpbiB0aGUgZ28tdHMtbW9kZSB0byBydW4gdW5pdCB0ZXN0cy4KCiogbGlzcC9wcm9n
bW9kZXMvZ28tdHMtbW9kZS5lbCAoZ28tdHMtbW9kZS1idWlsZC10YWdzKTogTmV3IHZhcmlhYmxl
LgooZ28tdHMtbW9kZS1tYXApOiBOZXcgbWFwIHZhcmlhYmxlLgooZ28tdHMtbW9kZS0tZ2V0LWJ1
aWxkLXRhZ3MtZmxhZyk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWNvbXBpbGUtdGVzdCk6
IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQpOiBOZXcgZnVuY3Rpb24u
Cihnby10cy1tb2RlLS1nZXQtZnVuY3Rpb24tcmVnZXhwKTogTmV3IGZ1bmN0aW9uLgooZ28tdHMt
bW9kZS0tZ2V0LWZ1bmN0aW9ucy1pbi1yYW5nZSk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUt
LWdldC10ZXN0LXJlZ2V4cC1hdC1wb2ludCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVz
dC1mdW5jdGlvbi1hdC1wb2ludCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC1maWxl
KTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9kZS10ZXN0LXBhY2thZ2UpOiBOZXcgZnVuY3Rpb24u
CiogZXRjL05FV1M6IE1lbnRpb24gdGhlIGNoYW5nZS4KCihCdWcjNzA5MzkpCi0tLQogZXRjL05F
V1MgICAgICAgICAgICAgICAgICAgICB8IDE5ICsrKysrKysrCiBsaXNwL3Byb2dtb2Rlcy9nby10
cy1tb2RlLmVsIHwgODggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCiAyIGZp
bGVzIGNoYW5nZWQsIDEwNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0
IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBiYTU4ZmE3YjMxOS4uMzVhNzYxZmJlZWIgMTAw
NjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC03MCw2ICs3MCwyNSBAQCBBZHZh
bmNlZCIgbm9kZSBpbiB0aGUgRVdXIG1hbnVhbC4KIEJ5IGN1c3RvbWl6aW5nICdzaHItaW1hZ2Ut
em9vbS1sZXZlbHMnLCB5b3UgY2FuIGNoYW5nZSB0aGUgbGlzdCBvZiB6b29tCiBsZXZlbHMgdGhh
dCBTSFIgY3ljbGVzIHRocm91Z2ggd2hlbiBjYWxsaW5nICdzaHItem9vbS1pbWFnZScuCiAKKyoq
IEdvLXRzIG1vZGUKKworKysrCisqKiogTmV3IHVuaXQgdGVzdCBjb21tYW5kcy4KK1RocmVlIG5l
dyBjb21tYW5kcyBhcmUgbm93IGF2YWlsYWJsZSB0byBydW4gdW5pdCB0ZXN0cy4KKworVGhlICdn
by10cy1tb2RlLXRlc3QtZnVuY3Rpb24tYXQtcG9pbnQnIGNvbW1hbmQgcnVucyB0aGUgdW5pdCB0
ZXN0IGF0Citwb2ludC4gIElmIGEgcmVnaW9uIGlzIGFjdGl2ZSwgaXQgcnVucyBhbGwgdGhlIHVu
aXQgdGVzdHMgdW5kZXIgdGhlCityZWdpb24uICBJdCBpcyBib3VuZCB0byAnQy1jIEMtdCB0JyBp
biAnZ28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS10ZXN0LXRoaXMtZmlsZScgY29tbWFu
ZCBydW5zIGFsbCB1bml0IHRlc3RzIGluIHRoZSBjdXJyZW50CitmaWxlLiBJdCBpcyBib3VuZCB0
byAnQy1jIEMtdCBmJyBpbiAnZ28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS10ZXN0LXRo
aXMtcGFja2FnZScgY29tbWFuZCBydW5zIGFsbCB1bml0IHRlc3RzIHVuZGVyIHRoZQorcGFja2Fn
ZSBvZiB0aGUgY3VycmVudCBidWZmZXIuICBJdCBpcyBib3VuZCB0byAnQy1jIEMtdCBwJyBpbiAn
Z28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS1idWlsZC10YWdzJyB2YXJpYWJsZSBpcyBh
dmFpbGFibGUgdG8gc2V0IGEgbGlzdCBvZiBidWlsZAordGFncyBmb3IgdGhlIHRlc3QgY29tbWFu
ZHMuCisKICoqIEVtYWNzIExpc3AgbW9kZQogCiAtLS0KZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21v
ZGVzL2dvLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCmluZGV4IDJk
M2U2YWFjMDkwLi4zZmU0MjdmYTkxMSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMt
bW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCkBAIC00Niw2ICs0Niwx
MiBAQAogICA6c2FmZSAnaW50ZWdlcnAKICAgOmdyb3VwICdnbykKIAorKGRlZmN1c3RvbSBnby10
cy1tb2RlLWJ1aWxkLXRhZ3MgbmlsCisgICJMaXN0IG9mIEdvIGJ1aWxkIHRhZ3MgZm9yIHRoZSB0
ZXN0IGNvbW1hbmRzLiIKKyAgOnZlcnNpb24gIjMwLjEiCisgIDp0eXBlICcocmVwZWF0IHN0cmlu
ZykKKyAgOmdyb3VwICdnbykKKwogKGRlZnZhciBnby10cy1tb2RlLS1zeW50YXgtdGFibGUKICAg
KGxldCAoKHRhYmxlIChtYWtlLXN5bnRheC10YWJsZSkpKQogICAgIChtb2RpZnktc3ludGF4LWVu
dHJ5ID8rICAgIi4iICAgICAgdGFibGUpCkBAIC0yNDIsNyArMjQ4LDEwIEBACiAoZGVmdmFyLWtl
eW1hcCBnby10cy1tb2RlLW1hcAogICA6ZG9jICJLZXltYXAgdXNlZCBpbiBHbyBtb2RlLCBwb3dl
cmVkIGJ5IHRyZWUtc2l0dGVyIgogICA6cGFyZW50IHByb2ctbW9kZS1tYXAKLSAgIkMtYyBDLWQi
ICMnZ28tdHMtbW9kZS1kb2NzdHJpbmcpCisgICJDLWMgQy1kIiAjJ2dvLXRzLW1vZGUtZG9jc3Ry
aW5nCisgICJDLWMgQy10IHQiICMnZ28tdHMtbW9kZS10ZXN0LWZ1bmN0aW9uLWF0LXBvaW50Cisg
ICJDLWMgQy10IGYiICMnZ28tdHMtbW9kZS10ZXN0LXRoaXMtZmlsZQorICAiQy1jIEMtdCBwIiAj
J2dvLXRzLW1vZGUtdGVzdC10aGlzLXBhY2thZ2UpCiAKIDs7OyMjI2F1dG9sb2FkCiAoZGVmaW5l
LWRlcml2ZWQtbW9kZSBnby10cy1tb2RlIHByb2ctbW9kZSAiR28iCkBAIC0zNzUsNiArMzg0LDgz
IEBAIGNvbW1lbnQgYWxyZWFkeSBleGlzdHMsIGp1bXAgdG8gaXQuIgogICAgICAoPD0gKHRyZWVz
aXQtbm9kZS1zdGFydCBub2RlKSBwb2ludCAodHJlZXNpdC1ub2RlLWVuZCBub2RlKSkKICAgICAg
KHN0cmluZy1lcXVhbCAiY29tbWVudCIgKHRyZWVzaXQtbm9kZS10eXBlIG5vZGUpKSkpKQogCiso
ZGVmdW4gZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZyAoKQorICAiUmV0dXJuIHRoZSBj
b21waWxlIGZsYWcgZm9yIGJ1aWxkIHRhZ3MuCitUaGlzIGZ1bmN0aW9uIHJlc3BlY3RzIHRoZSBg
Z28tdHMtbW9kZS1idWlsZC10YWdzJyB2YXJpYWJsZSBmb3IKK3NwZWNpZnlpbmcgYnVpbGQgdGFn
cy4iCisgIChpZiBnby10cy1tb2RlLWJ1aWxkLXRhZ3MKKyAgICAgIChmb3JtYXQgIi10YWdzICVz
IiAoc3RyaW5nLWpvaW4gZ28tdHMtbW9kZS1idWlsZC10YWdzICIsIikpCisgICAgIiIpKQorCiso
ZGVmdW4gZ28tdHMtbW9kZS0tY29tcGlsZS10ZXN0IChyZWdleHApCisgICJDb21waWxlIHRoZSB0
ZXN0cyBtYXRjaGluZyBSRUdFWFAuCitUaGlzIGZ1bmN0aW9uIHJlc3BlY3RzIHRoZSBgZ28tdHMt
bW9kZS1idWlsZC10YWdzJyB2YXJpYWJsZSBmb3IKK3NwZWNpZnlpbmcgYnVpbGQgdGFncy4iCisg
IChjb21waWxlIChmb3JtYXQgImdvIHRlc3QgLXYgJXMgLXJ1biAnJXMnIgorICAgICAgICAgICAg
ICAgICAgIChnby10cy1tb2RlLS1nZXQtYnVpbGQtdGFncy1mbGFnKQorICAgICAgICAgICAgICAg
ICAgIHJlZ2V4cCkpKQorCisoZGVmdW4gZ28tdHMtbW9kZS0tZmluZC1kZWZ1bi1hdCAoc3RhcnQp
CisgICJSZXR1cm4gdGhlIGZpcnN0IGRlZnVuIG5vZGUgZnJvbSBTVEFSVC4iCisgIChsZXQgKCh0
aGluZyAob3IgdHJlZXNpdC1kZWZ1bi10eXBlLXJlZ2V4cCAnZGVmdW4pKSkKKyAgICAob3IgKHRy
ZWVzaXQtdGhpbmctYXQgc3RhcnQgdGhpbmcpCisgICAgICAgICh0cmVlc2l0LXRoaW5nLW5leHQg
c3RhcnQgdGhpbmcpKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLS1nZXQtZnVuY3Rpb24tcmVnZXhw
IChuYW1lKQorICAoaWYgbmFtZQorICAgICAgKGZvcm1hdCAiXiVzJCIgbmFtZSkKKyAgICAoZXJy
b3IgIk5vIHRlc3QgZnVuY3Rpb24gZm91bmQiKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLS1nZXQt
ZnVuY3Rpb25zLWluLXJhbmdlIChzdGFydCBlbmQpCisgICJSZXR1cm4gYSBsaXN0IHdpdGggdGhl
IG5hbWVzIG9mIGFsbCBkZWZ1bnMgaW4gdGhlIHJhbmdlIFNUQVJUIHRvIEVORC4iCisgIChsZXQq
ICgobm9kZSAoZ28tdHMtbW9kZS0tZmluZC1kZWZ1bi1hdCBzdGFydCkpCisgICAgICAgICAobmFt
ZSAodHJlZXNpdC1kZWZ1bi1uYW1lIG5vZGUpKQorICAgICAgICAgKG5vZGUtc3RhcnQgKHRyZWVz
aXQtbm9kZS1zdGFydCBub2RlKSkKKyAgICAgICAgIChub2RlLWVuZCAodHJlZXNpdC1ub2RlLWVu
ZCBub2RlKSkpCisgICAgKGNvbmQgKChvciAobm90IG5vZGUpCisgICAgICAgICAgICAgICAoPiBz
dGFydCBub2RlLWVuZCkKKyAgICAgICAgICAgICAgICg8IGVuZCBub2RlLXN0YXJ0KSkKKyAgICAg
ICAgICAgbmlsKQorICAgICAgICAgICgob3IgKG5vdCAoZXF1YWwgKHRyZWVzaXQtbm9kZS10eXBl
IG5vZGUpICJmdW5jdGlvbl9kZWNsYXJhdGlvbiIpKQorICAgICAgICAgICAgICAgKG5vdCAoc3Ry
aW5nLXByZWZpeC1wICJUZXN0IiBuYW1lKSkpCisgICAgICAgICAgIChnby10cy1tb2RlLS1nZXQt
ZnVuY3Rpb25zLWluLXJhbmdlICh0cmVlc2l0LW5vZGUtZW5kIG5vZGUpIGVuZCkpCisgICAgICAg
ICAgKHQKKyAgICAgICAgICAgKGNvbnMgKGdvLXRzLW1vZGUtLWdldC1mdW5jdGlvbi1yZWdleHAg
bmFtZSkKKyAgICAgICAgICAgICAgICAgKGdvLXRzLW1vZGUtLWdldC1mdW5jdGlvbnMtaW4tcmFu
Z2UgKHRyZWVzaXQtbm9kZS1lbmQgbm9kZSkgZW5kKSkpKSkpCisKKyhkZWZ1biBnby10cy1tb2Rl
LS1nZXQtdGVzdC1yZWdleHAtYXQtcG9pbnQgKCkKKyAgIlJldHVybiBhIHJlZ3VsYXIgZXhwcmVz
c2lvbiBmb3IgdGhlIHRlc3RzIGF0IHBvaW50LgorSWYgcmVnaW9uIGlzIGFjdGl2ZSwgdGhlIHJl
Z2V4cCB3aWxsIGluY2x1ZGUgYWxsIHRoZSBmdW5jdGlvbnMgdW5kZXIgdGhlCityZWdpb24uIgor
ICAoaWYtbGV0ICgocmFuZ2UgKGlmIChyZWdpb24tYWN0aXZlLXApCisgICAgICAgICAgICAgICAg
ICAgICAgKGxpc3QgKHJlZ2lvbi1iZWdpbm5pbmcpIChyZWdpb24tZW5kKSkKKyAgICAgICAgICAg
ICAgICAgICAgKGxpc3QgKHBvaW50KSAocG9pbnQpKSkpCisgICAgICAgICAgIChmdW5jcyAoYXBw
bHkgIydnby10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlIHJhbmdlKSkpCisgICAgICAo
c3RyaW5nLWpvaW4gZnVuY3MgInwiKQorICAgIChlcnJvciAiTm8gdGVzdCBmdW5jdGlvbiBmb3Vu
ZCIpKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtdGVzdC1mdW5jdGlvbi1hdC1wb2ludCAoKQorICAi
UnVuIHRoZSB1bml0IHRlc3QgYXQgcG9pbnQuCitJZiB0aGUgcG9pbnQgaXMgYW55d2hlcmUgaW4g
dGhlIHRlc3QgZnVuY3Rpb24sIHRoYXQgZnVuY3Rpb24gd2lsbCBiZQorcnVuLiAgSWYgdGhlIHJl
Z2lvbiBpcyBzZWxlY3RlZCwgYWxsIHRoZSBmdW5jdGlvbnMgdW5kZXIgdGhlIHJlZ2lvbiB3aWxs
CitiZSBydW4uIgorICAoaW50ZXJhY3RpdmUpCisgIChnby10cy1tb2RlLS1jb21waWxlLXRlc3Qg
KGdvLXRzLW1vZGUtLWdldC10ZXN0LXJlZ2V4cC1hdC1wb2ludCkpKQorCisoZGVmdW4gZ28tdHMt
bW9kZS10ZXN0LXRoaXMtZmlsZSAoKQorICAiUnVuIGFsbCB0aGUgdW5pdCB0ZXN0cyBpbiB0aGUg
Y3VycmVudCBmaWxlLiIKKyAgKGludGVyYWN0aXZlKQorICAoaWYtbGV0ICgoZGVmdW5zIChnby10
cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJhbmdlIChwb2ludC1taW4pIChwb2ludC1tYXgpKSkp
CisgICAgICAoZ28tdHMtbW9kZS0tY29tcGlsZS10ZXN0IChzdHJpbmctam9pbiBkZWZ1bnMgInwi
KSkKKyAgICAoZXJyb3IgIk5vIHRlc3QgZnVuY3Rpb25zIGZvdW5kIGluIHRoZSBjdXJyZW50IGZp
bGUiKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLXRlc3QtdGhpcy1wYWNrYWdlICgpCisgICJSdW4g
YWxsIHRoZSB1bml0IHRlc3RzIHVuZGVyIHRoZSBjdXJyZW50IHBhY2thZ2UuIgorICAoaW50ZXJh
Y3RpdmUpCisgIChjb21waWxlIChmb3JtYXQgImdvIHRlc3QgLXYgJXMgLXJ1biAlcyIKKyAgICAg
ICAgICAgICAgICAgICAoZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZykKKyAgICAgICAg
ICAgICAgICAgICBkZWZhdWx0LWRpcmVjdG9yeSkpKQorCiA7OyBnby5tb2Qgc3VwcG9ydC4KIAog
KGRlZnZhciBnby1tb2QtdHMtbW9kZS0tc3ludGF4LXRhYmxlCi0tIAoyLjQ1LjIKCg==
--0000000000007e45af061c9967a1--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 06 Jul 2024 22:10:02 +0000
Resent-Message-ID: <handler.70939.B70939.172030379623218 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>, Randy Taylor <dev@HIDDEN>
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.172030379623218
          (code B ref 70939); Sat, 06 Jul 2024 22:10:02 +0000
Received: (at 70939) by debbugs.gnu.org; 6 Jul 2024 22:09:56 +0000
Received: from localhost ([127.0.0.1]:46914 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sQDbP-00062P-OF
	for submit <at> debbugs.gnu.org; Sat, 06 Jul 2024 18:09:56 -0400
Received: from mail-lj1-f178.google.com ([209.85.208.178]:45395)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1sQDbN-00062F-Jk
 for 70939 <at> debbugs.gnu.org; Sat, 06 Jul 2024 18:09:54 -0400
Received: by mail-lj1-f178.google.com with SMTP id
 38308e7fff4ca-2eaa89464a3so28426331fa.3
 for <70939 <at> debbugs.gnu.org>; Sat, 06 Jul 2024 15:09:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1720303728; x=1720908528; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=I1Ur9LuqHeV7MoWCCdvNIP1om6b1kz8vM1oeEM6gxeg=;
 b=JD5p06Vi5r1J86/tsb5a3bAsdknsRWqx8xEG2uaflk4Aw36H9iq6rhrUwjKivD6Hyy
 qoW4dUCh+hJZU9E96IQ5ImtT5kVrD80fkQ29oPi3pVNerZMSo2g4x7ghtBHMkUaEzdSo
 4u54aQlquIbFiDS7ZfcjuoeEWbInu0MES0qJ5e4zLFdrdYEHqtm60tMWSx8Lra+/cTLh
 k3R516Z3WyjhrjHAbArPFCg/rvjWo4Pla3LUYytM+mOE7BHyTmPFa4/Kv18SewcHxYB/
 eCaeZ19IX2ZK4PPycxbXtuQV3Ds6TE7ohocFkRb5RmXmhmGTHuxzbEq95Q1Hxv2VdaP3
 axlQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1720303728; x=1720908528;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=I1Ur9LuqHeV7MoWCCdvNIP1om6b1kz8vM1oeEM6gxeg=;
 b=ZO42tgywV+YKhpWDDWxi9bL2AQo+DZwCKDf3fycKyCJ0zNfvuznD776Ty3B5YvMrN+
 le8K0QPQwLYkm49Hhg3ZlL37Sp/YJWdxIbnApD43lm+eH9NAG8nOlxg7KN8Nn8EtW27+
 Oi9JQeFZhy8NEQaWKlTvxZGah9I+MXHW9fJM+xW8cesaZpzLqJw3pWeeU2KF3zJ+Ejlq
 4BvTPR4Y4H5Z3JOjvxGQ3LWi8vFNrF0iOmNZwolsRXTUhGTsexSKZs/iu/TbsWTfd4X2
 YJOPkbJDFfna5+n7l1DheKjS81JzW9YSXKinHDdHq5xmkwdGkKdZgyhoCro1cobDlEhX
 BpXg==
X-Forwarded-Encrypted: i=1;
 AJvYcCXAUiZiDM+eIq/iYR5/GlTvkA3TpO9vny4inaGagDCGefBh5RWYFUiIo6L5huD+Wav8CyEm3/cILDP+9o9v+roVXfr+1N8=
X-Gm-Message-State: AOJu0Yw/9OKQiYG0nD8XE1QdXBVk5SORTd22aCNcnX3XVzYmBGZJ4e01
 RqKB+Ocq58dLin3o5Q4orpi3lbRcpxgzNX4vdIseby1LpTISU0sxtcm7KxyY/lKPQYHIdEaqsa1
 HWuYTMA9vRtr3gdXIA62Uwh+n0xs=
X-Google-Smtp-Source: AGHT+IFWXIS99EZyxdna8k/SWWR6GAbJ7YiGaWTfjY1+DCYDjGAeparW8uYmbYJjQdTh0GUxJQ2jaunojRNoAs3IKHI=
X-Received: by 2002:a2e:b98f:0:b0:2eb:dd0b:b9ec with SMTP id
 38308e7fff4ca-2ee8ed8c365mr46571791fa.20.1720303728353; Sat, 06 Jul 2024
 15:08:48 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 6 Jul 2024 15:08:47 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
MIME-Version: 1.0
Date: Sat, 6 Jul 2024 15:08:47 -0700
Message-ID: <CADwFkm=vDEXyq90Vwa-PXe=9=Y5r8s9HvE-p77zt0rGrtUk43w@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Ankit Gadiya via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@HIDDEN> writes:

> +*** New unit test commands.
> +Three new commands are now available to run unit tests.
> +
> +The 'go-ts-mode-test-function-at-point' command runs the unit test at
> +point.  If a region is active, it runs all the unit tests under the
> +region.  It is bound to 'C-c C-t t' in 'go-ts-mode'.
> +
> +The 'go-ts-mode-test-this-file' command runs all unit tests in the current
> +file. It is bound to 'C-c C-t f' in 'go-ts-mode'.
> +
> +The 'go-ts-mode-test-this-package' command runs all unit tests under the
> +package of the current buffer.  It is bound to 'C-c C-t p' in 'go-ts-mode'.
> +
> +The 'go-ts-mode-build-tags' variable is available to set a list of build
> +tags for the test commands.

BTW, eventually I think that we want a general command for this in
project.el, e.g.  "project-run-tests" or something like that.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Dmitry Gutov <dmitry@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 06 Jul 2024 22:31:01 +0000
Resent-Message-ID: <handler.70939.B70939.172030504825292 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Stefan Kangas <stefankangas@HIDDEN>, Ankit Gadiya <ankit@HIDDEN>, Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.172030504825292
          (code B ref 70939); Sat, 06 Jul 2024 22:31:01 +0000
Received: (at 70939) by debbugs.gnu.org; 6 Jul 2024 22:30:48 +0000
Received: from localhost ([127.0.0.1]:46925 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sQDvc-0006Zs-6o
	for submit <at> debbugs.gnu.org; Sat, 06 Jul 2024 18:30:48 -0400
Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:33595)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1sQDva-0006Zf-Me
 for 70939 <at> debbugs.gnu.org; Sat, 06 Jul 2024 18:30:47 -0400
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
 by mailfout.nyi.internal (Postfix) with ESMTP id A84301380AD2;
 Sat,  6 Jul 2024 18:30:37 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Sat, 06 Jul 2024 18:30:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm1; t=1720305037;
 x=1720391437; bh=rxYlSuiFpUGhmafAiT2pyTWSlmVjVVyqd8UFWumM8SE=; b=
 c75GXxd9uTv7N3vIsUqCK/uEU4017DRQlX9WEQdfCeh1uaaFPWg541NS/xjtK/Lm
 qbKHLpt1W400CdLjqIvVjJPmIaDtrIfUO8J2LOsJyaT1kg2eF1JWNPfvKDAer0gl
 k91Ha8BZwddTbs+mQydiTITKutLuUsA3B318Y3tBvAFWsksqkVczVYqCZlsdMjV6
 QaC0zIfreaagOfQKsLGRp1qgMT3DEI2m9AJfCNylgV2CbCJiMOz0VqTMtSMn4IfF
 nOeOliWY5DaWiERi/mD8w//imUg5QkobXAXFW2xUR6p8rOyhdz5oFGcq5c8nXu6I
 YPONZ896/81xzRFlyy4PsA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720305037; x=
 1720391437; bh=rxYlSuiFpUGhmafAiT2pyTWSlmVjVVyqd8UFWumM8SE=; b=Y
 Nyww4AXGVOX1zEc8bd3HVgp0ldamXH9VJ5s9wt3sdHjObF5lcLemOpiRPixPL6bS
 xuD9q9DROuFy32+gSIVe6S4xMAWHBlSi7cgRMxkYTL3k5iDUT2l9o3ScZ2FzYNXc
 gSNHpqm0idcOF87id6ZjgqQpBJT+5rD1e9ICzhFnHimij+pEgLUnc4pWPNAZ0Knm
 XFLCo6P+H7nf/GFZojydnJtZH+Ng9YVPfytvLHvncBV7f8GO1F0yCYaRBlrRdqfB
 4tabijzlsB+k+0zGlH358hXVkHPNLqy/WRzSlsd9wgrGxccENxdqSjQGr2LvrXZD
 LpeflQaFr2eTcvcIQDm4w==
X-ME-Sender: <xms:jcWJZjEpUUXe3gMWAAfJWnEA0Q6avDyGhzTtLrZdsKAi0XLMso5gag>
 <xme:jcWJZgWssi2fuvgmTZJeXP1F3uBjWSXr-PNX9gT-_UKQUScdEVVZeRmqh0FiD3IyA
 QwxoVYL0QiR-PskEGU>
X-ME-Received: <xmr:jcWJZlIUnN14etCCNoZ55AfPhV2CZchaNsOM2OR36kjnAJ46aU7FU5WYMnL7N4zBe6Xr>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeggdduvdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihht
 rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth
 gvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveegudej
 heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh
 hithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:jcWJZhG_MbLE903jVj02rnyV-q4rZnCXr9zYXi55ue9fwQJkNBZ9Ig>
 <xmx:jcWJZpVkx65o_mplI4KStk4e69izTpB2Kx0LTeHCrcXyY7GoVmzCjA>
 <xmx:jcWJZsNNhv-LJqODuLbRikA4AXFt6SwZOOBVMbebtaHADB_sK7mAfg>
 <xmx:jcWJZo3fbbJb_lXO6WU6enVMU19efdI9vOWxp01cbbiz3O5L7O5_8w>
 <xmx:jcWJZnfTEgTivpQx2g0iEgGkSaT6zFq9esHOKxC9G6ifBm-6qfH1qOb3>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 6 Jul 2024 18:30:35 -0400 (EDT)
Message-ID: <744804e2-5b02-4d8e-b0b1-6559b837e7b7@HIDDEN>
Date: Sun, 7 Jul 2024 01:30:33 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
 <CADwFkm=vDEXyq90Vwa-PXe=9=Y5r8s9HvE-p77zt0rGrtUk43w@HIDDEN>
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <CADwFkm=vDEXyq90Vwa-PXe=9=Y5r8s9HvE-p77zt0rGrtUk43w@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 07/07/2024 01:08, Stefan Kangas wrote:
> BTW, eventually I think that we want a general command for this in
> project.el, e.g.  "project-run-tests" or something like that.

Some command (or even a set of commands) would indeed be useful. I'm not 
sure it should be tied to 'project', though - IME those commands usually 
only need to find the test root, and that one does not always match the 
project root.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 07 Jul 2024 07:29:02 +0000
Resent-Message-ID: <handler.70939.B70939.17203372893180 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Dmitry Gutov <dmitry@HIDDEN>
Cc: Randy Taylor <dev@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17203372893180
          (code B ref 70939); Sun, 07 Jul 2024 07:29:02 +0000
Received: (at 70939) by debbugs.gnu.org; 7 Jul 2024 07:28:09 +0000
Received: from localhost ([127.0.0.1]:47239 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sQMJc-0000pC-N8
	for submit <at> debbugs.gnu.org; Sun, 07 Jul 2024 03:28:09 -0400
Received: from mail-vk1-f175.google.com ([209.85.221.175]:57529)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1sQMJa-0000p4-Lg
 for 70939 <at> debbugs.gnu.org; Sun, 07 Jul 2024 03:28:07 -0400
Received: by mail-vk1-f175.google.com with SMTP id
 71dfb90a1353d-4f30012ebe8so670642e0c.2
 for <70939 <at> debbugs.gnu.org>; Sun, 07 Jul 2024 00:28:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1720337222; x=1720942022; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=OgsgPKP4wx8DKnMIpVqwduMGP948VUIyWW5ZURe+fn4=;
 b=G3NUQngvH3PfUSwhZtqcR05QTFD55Fv+2fmicUBKFzUVmpbGXWmvjPLUOBn6VNu/EG
 8U0gJAR8J4fVNTJdAsXzRwPJ/4LOnfnTXsI/KU3M8N2s7UJsVW24MZgmVWobqJbZ9mSf
 VRo9AJAV4m+ictueQjMuvgLsOwItnaPkNx6fPx53pqh/0oF3nw3RW2/9VohBojziNLr7
 Xzt+eiBc5AUVo4PvWmbFhUbRo+LNGOnyN9BGwlA/o2+j1czWYjmnYEzGfLNpLWPq8QzU
 59C1eVnc7hzxryL1HAWgJy3deGFdzTAt1fG+3aaw+Z9XV6Dd1VBi+i6gGh/njSfYZUXL
 enWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1720337222; x=1720942022;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=OgsgPKP4wx8DKnMIpVqwduMGP948VUIyWW5ZURe+fn4=;
 b=TDrUK9KbunK5yNbgNxU31ZuPYdi0Ritf57A1/WoyWyR9mIJCQggKX/34r6KuXSt8Zx
 tp/Rsg5YOxj/Y1YTkvL8R3gyFJ62hEYNzNxENNTDK4gJyx1eQ4GQVINA0RwV1FGBxXwN
 u0FzNuor2Lu2oU1ITKZeWkAutDTcmQjZdo/VHijuKbabyg20U1fmTlCngmxQA6kEp1vH
 yiYDDKDLiQmNspIaKxUJLXOZpswmOanEDYDQmfKYH7Id8ZKhyo2FxssttznB5TlXXu/e
 Q/HqO2yJuO2x6M+xhsdO93I6ArfajabKfDXSgzZLPVgQyseDt1nXfwMiDkZ47A8QYeU/
 dDtw==
X-Forwarded-Encrypted: i=1;
 AJvYcCWvifL7hM9gV1BGnq6o6j8+cZh+pUIL1u7iDtyErTgIQq6lw8IeP0VpOnvjaDEyCCut+8cJBeefDjJaEhBFbtv4wNAoFAQ=
X-Gm-Message-State: AOJu0Yz5Em6CCMDwdsneehRNF8d1Qsy9yv7QIbpJcAT3lJPyqWwklsqg
 2GA5CUZp/gfGxsx0TsJ36KkvIISbHtHF2TBIf4opuxAerAdg3nEyUXFizxp7YjYhGIb/2zXTKue
 V3Zc7fJFFcA2yaDq4Wtgsb4ZeZ5J06RC0ulXqpg==
X-Google-Smtp-Source: AGHT+IHrMIxsU2aiFGNvWUtc/Clfnp07j8UlHBX0ov/Z8B3yiBlIp1TK41AbQkFKg59w4CkNUCw6+3+dfbwEDrPvT5A=
X-Received: by 2002:a05:6122:6607:b0:4e4:ed90:27e6 with SMTP id
 71dfb90a1353d-4f2f3e869abmr9893409e0c.5.1720337221919; Sun, 07 Jul 2024
 00:27:01 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <86bk55iw54.fsf@HIDDEN>
 <CAN7zea0JD_fFcVozwXRtx9wkr8aWpx1Dt=AK4vA+aMchD8m_AA@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
 <CADwFkm=vDEXyq90Vwa-PXe=9=Y5r8s9HvE-p77zt0rGrtUk43w@HIDDEN>
 <744804e2-5b02-4d8e-b0b1-6559b837e7b7@HIDDEN>
In-Reply-To: <744804e2-5b02-4d8e-b0b1-6559b837e7b7@HIDDEN>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Sun, 7 Jul 2024 12:56:51 +0530
Message-ID: <CAN7zea1CDWDUnRg8m9X5uODEAKVt8xWuas63LGEnABZOhWv2iA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Sun, 7 Jul 2024 at 04:00, Dmitry Gutov <dmitry@HIDDEN> wrote:
>
> On 07/07/2024 01:08, Stefan Kangas wrote:
> > BTW, eventually I think that we want a general command for this in
> > project.el, e.g.  "project-run-tests" or something like that.
>
> Some command (or even a set of commands) would indeed be useful. I'm not
> sure it should be tied to 'project', though - IME those commands usually
> only need to find the test root, and that one does not always match the
> project root.

It would be good to have a separate module similar to compile.el. Then
mode-specific implementation can register test functions. The project.el
command(s) can then be added to run on project-root.

-- 
Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 10 Jul 2024 23:44:01 +0000
Resent-Message-ID: <handler.70939.B70939.172065503322446 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.172065503322446
          (code B ref 70939); Wed, 10 Jul 2024 23:44:01 +0000
Received: (at 70939) by debbugs.gnu.org; 10 Jul 2024 23:43:53 +0000
Received: from localhost ([127.0.0.1]:50547 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sRgyX-0005py-0K
	for submit <at> debbugs.gnu.org; Wed, 10 Jul 2024 19:43:53 -0400
Received: from mail-4323.proton.ch ([185.70.43.23]:26991)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sRgyR-0005pf-EG
 for 70939 <at> debbugs.gnu.org; Wed, 10 Jul 2024 19:43:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1720655022; x=1720914222;
 bh=dAQa2FkJmW2KV0khu/UviH/ogNvwTK+jbcyxmKUiHIQ=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=vCV/qrU3rLrXBoiagP8Xm9xqm160ATp3tDnVEYD5KuxCOpDS9n9gN0EHZ8Rc2yBqB
 KLwnA20uuKgB5XCdSmDe+b4XhulGnuAov3/UpY0BMSbb97YXrFr3e5VTnu550GpyBi
 vziY4TdUSEIBQuyeotZV4QE127fWmRxTdUQuZK+O2jhHUeRkhNbVBz6BsNgnkikV8x
 7IWy7OgqNBNu0xVcs/BsIZcqLtNH9Tm2y5c6GZ26u9iIZMwM6kd32eOt0bbCFIyvar
 qOPSpYNhWpCupT5IF8pRS/48fcnWH4Cyx9eTpUAf0Zj4zShZEmlm81Z6AT9dszbSQz
 3W3rbnf/DPvjw==
Date: Wed, 10 Jul 2024 23:43:37 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev>
In-Reply-To: <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 408e9205bfa8daf40c75b8411cfd0766fb0f1c13
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Saturday, July 6th, 2024 at 15:44, Ankit Gadiya <ankit@HIDDEN> wrote:
>=20
> Apologies for the delay again.
>=20
> > > > For the commit message, I'm not sure we need that paragraph especia=
lly when it's already described in the news. Eli what do you think?
>=20
>=20
> Thanks Randy and Eli, I've updated the commit message to be shorter now.
>=20
> > > > +*** New unit test commands.
> > > > +Two new commands are now available to run unit tests.
> > > > Three?
> >=20
> > This still needs to be updated.
>=20
>=20
> Thanks, I fixed it.
>=20
> > A few more comments:
> > +(defun go-ts-mode--get-test-regexp-at-point ()
> > + "Return a regular expression for tests at point.
> > ^ the
> >=20
> > Could go-ts-mode--get-test-regexp-at-point and go-ts-mode-test-file use=
 if-let?
>=20
>=20
> I wasn't familiar with if-let, thanks for this. Incorporated it in
> both the functions.
>=20
> > Also, the indentation looks off in go-ts-mode-test-function-at-point (2=
 extra spaces methinks).
>=20
>=20
> Fixed this, thanks.
>=20
> > > > I'm also wondering if we should include "current" in the go-ts-mode=
-test-file and go-ts-mode-test-package function names. Maybe someone would =
expect that they would get prompted to select a file or package to test? Ma=
ybe I'm overthinking that :). Eli what do you think?
> > >=20
> > > I'll wait for Eli to reply before incorporating the changes :).
> >=20
> > And he chimed in - let's go with his suggestions.
>=20
>=20
> Updated both the function names.
> go-ts-mode-test-this-file
> go-ts-mode-test-this-package
>=20
> > > Additionally, I also noticed that the emacs-30 branch is cut. I wante=
d
> > > to check if I
> > > need to rebase my patch onto master or emacs-30 branch?
> >=20
> > I would guess master, but let's see what Eli says.
>=20
>=20
> I rebased my patch on the master now. Requesting a re-review.
>=20
> Thanks
>=20
> --
> Ankit

I only have a few comments about the commit message:

Three new commands are added in the go-ts-mode to run unit tests.
I would just drop this line altogether, personally.

(go-ts-mode-map): New map variable.
This should probably read something like Add new bindings.

(go-ts-mode-test-file): New function.
(go-ts-mode-test-package): New function.
These two need to be updated (...-test-this-...).

Everything else looks good to me. Thanks for working on this, Ankit.

Eli, if you have no further comments please install when you get a chance. =
Thanks in advance.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Jul 2024 07:35:02 +0000
Resent-Message-ID: <handler.70939.B70939.172068328612802 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.172068328612802
          (code B ref 70939); Thu, 11 Jul 2024 07:35:02 +0000
Received: (at 70939) by debbugs.gnu.org; 11 Jul 2024 07:34:46 +0000
Received: from localhost ([127.0.0.1]:50808 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sRoKD-0003KQ-DG
	for submit <at> debbugs.gnu.org; Thu, 11 Jul 2024 03:34:45 -0400
Received: from mail-vs1-f51.google.com ([209.85.217.51]:55774)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1sRoKB-0003KI-Ik
 for 70939 <at> debbugs.gnu.org; Thu, 11 Jul 2024 03:34:44 -0400
Received: by mail-vs1-f51.google.com with SMTP id
 ada2fe7eead31-48ff70394fbso218483137.3
 for <70939 <at> debbugs.gnu.org>; Thu, 11 Jul 2024 00:34:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1720683223; x=1721288023; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=eBqAxSk4eCakyQubSVdV+Ua+9sMvJDwR5HdxsIo4Gg8=;
 b=JSAWSrLfNQllxIAX+72v/pvl8Q1+ammAgfMsBdTz3V1nKNzAjMjakF0crQxeRc+T8k
 zwAPCUQIh8iV0wjfoK0115hex8QhKI1mIxKUtBVh6D1BplbAI4BrenAsw/2JR66L9VFW
 3eJYFhgrRhAGSISOQPq5ZZZZqHqI6maeNywi+Y7BgFbPL23FmGwBL0pvURVaY2fIB6Fb
 X2BVfZayRVEXmxhVNYsGMJLI7lrOLugteYxnj68vR9x39NgsafRfz7iCZHWA0IODRcIW
 9d/MaSGwSGJhpBIw+4IfiFM+Ax53pNopAsV/RwlWj8aDIgJ9gZFRrQ10FJ+R3z9j7gUf
 zLhg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1720683223; x=1721288023;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=eBqAxSk4eCakyQubSVdV+Ua+9sMvJDwR5HdxsIo4Gg8=;
 b=Llff1WTDzLbiMplN0WbDP7Zze1knOWyYcgz1C9OMvBfGRA1n/fx/j9e+phHHJbo4lz
 ERZCG4kiKTjh0y5jtFYRNFQHkEkY6/5/slgEML8G9drRJsFqxHN5umt8clpci2VkY5H3
 X7qdC8CMTbja78nq06AcK3dWF4uV5qgktLhZMec65d4HmPeg3TeMVVfd4l3UZcQEvVY9
 Ngn9PK2KAG/RJ+AkjCFd/FKnFKs+7Dpw4joIXq6wwJAiNhylTNb4EwFsQ+Ph0yRlrFcj
 Cd8/wXsznTAgVwIiF3yiwt/+Vp+cxD5+fNrtH27+gvOnDSANB2xSgET4/JHiUMryTQIf
 Pc/g==
X-Forwarded-Encrypted: i=1;
 AJvYcCW99zd6kLUZ6jAao6VAUMcuEETkuaatUp2Y3UFeFwEE+D5V/+vXFHBGCqnTMoM0W8cTNLdzplqOWgVw3z0ZroTeVeMyqrc=
X-Gm-Message-State: AOJu0YyWz8HCtVi8ssIFAqJEeNFqb0Mj5Fr59eU0E33CAKhSvA/FATYW
 /Kuwrl2MP4GWc5gW6fBiOYaI7SMdsxpeNKpmTLNyCKBqHF6iOSUiFOsO83cOwQhJxydm+iTk2Nn
 frN5X85Wcjzic5HY7r0vSKjCSeHS4igpwjQHo1g==
X-Google-Smtp-Source: AGHT+IFT1cMLoFvmg09VNNpLiZ7qp8MPi9TczYIgpYo1I3eZP1lReQxd5iWkS1z5SYt87PTD/IxaTQbSe/KUK0KPXYg=
X-Received: by 2002:a05:6102:3f9e:b0:48f:9049:a0ba with SMTP id
 ada2fe7eead31-4903220af52mr9702779137.31.1720683223161; Thu, 11 Jul 2024
 00:33:43 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
 <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
 <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev>
In-Reply-To: <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Thu, 11 Jul 2024 13:03:32 +0530
Message-ID: <CAN7zea0EC+ce=Wc+ASM7+7y9ts__c5137ik683uT4-FTaZcZ3w@HIDDEN>
Content-Type: multipart/mixed; boundary="00000000000049e50d061cf3c8b7"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000049e50d061cf3c8b7
Content-Type: text/plain; charset="UTF-8"

> I only have a few comments about the commit message:
>
> Three new commands are added in the go-ts-mode to run unit tests.
> I would just drop this line altogether, personally.
>
> (go-ts-mode-map): New map variable.
> This should probably read something like Add new bindings.
>
> (go-ts-mode-test-file): New function.
> (go-ts-mode-test-package): New function.
> These two need to be updated (...-test-this-...).

Thanks, I'm sending the updated patch with these fixes.

> Everything else looks good to me. Thanks for working on this, Ankit.
>
> Eli, if you have no further comments please install when you get a chance. Thanks in advance.

Thank you for being patient through this review. After this interaction, I feel
encouraged to send more patches in the future.

-- 
Ankit

--00000000000049e50d061cf3c8b7
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Disposition: attachment; 
	filename="0001-Add-commands-to-run-unit-tests-in-go-ts-mode.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lygxz9j10>
X-Attachment-Id: f_lygxz9j10

RnJvbSA3ZjAwMmE2N2Q4YjAyOTM1ZThhZDZiNDBhMTJiMjM5YjljYjg1MTlmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmtpdCBSIEdhZGl5YSA8Z2l0QGFyZ3AuaW4+CkRhdGU6IFR1
ZSwgMTQgTWF5IDIwMjQgMDA6MTQ6MDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBBZGQgY29tbWFu
ZHMgdG8gcnVuIHVuaXQgdGVzdHMgaW4gZ28tdHMtbW9kZQoKKiBsaXNwL3Byb2dtb2Rlcy9nby10
cy1tb2RlLmVsIChnby10cy1tb2RlLWJ1aWxkLXRhZ3MpOiBOZXcgdmFyaWFibGUuCihnby10cy1t
b2RlLW1hcCk6IEFkZCBuZXcgYmluZGluZ3MuCihnby10cy1tb2RlLS1nZXQtYnVpbGQtdGFncy1m
bGFnKTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9kZS0tY29tcGlsZS10ZXN0KTogTmV3IGZ1bmN0
aW9uLgooZ28tdHMtbW9kZS0tZmluZC1kZWZ1bi1hdCk6IE5ldyBmdW5jdGlvbi4KKGdvLXRzLW1v
ZGUtLWdldC1mdW5jdGlvbi1yZWdleHApOiBOZXcgZnVuY3Rpb24uCihnby10cy1tb2RlLS1nZXQt
ZnVuY3Rpb25zLWluLXJhbmdlKTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9kZS0tZ2V0LXRlc3Qt
cmVnZXhwLWF0LXBvaW50KTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9kZS10ZXN0LWZ1bmN0aW9u
LWF0LXBvaW50KTogTmV3IGZ1bmN0aW9uLgooZ28tdHMtbW9kZS10ZXN0LXRoaXMtZmlsZSk6IE5l
dyBmdW5jdGlvbi4KKGdvLXRzLW1vZGUtdGVzdC10aGlzLXBhY2thZ2UpOiBOZXcgZnVuY3Rpb24u
CiogZXRjL05FV1M6IE1lbnRpb24gdGhlIGNoYW5nZS4KCihCdWcjNzA5MzkpCi0tLQogZXRjL05F
V1MgICAgICAgICAgICAgICAgICAgICB8IDE5ICsrKysrKysrCiBsaXNwL3Byb2dtb2Rlcy9nby10
cy1tb2RlLmVsIHwgODggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCiAyIGZp
bGVzIGNoYW5nZWQsIDEwNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0
IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBmMTBmOWFlNGQ2NS4uZGZlMmY1NTczNDcgMTAw
NjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC03Niw2ICs3NiwyNSBAQCBBZHZh
bmNlZCIgbm9kZSBpbiB0aGUgRVdXIG1hbnVhbC4KIEJ5IGN1c3RvbWl6aW5nICdzaHItaW1hZ2Ut
em9vbS1sZXZlbHMnLCB5b3UgY2FuIGNoYW5nZSB0aGUgbGlzdCBvZiB6b29tCiBsZXZlbHMgdGhh
dCBTSFIgY3ljbGVzIHRocm91Z2ggd2hlbiBjYWxsaW5nICdzaHItem9vbS1pbWFnZScuCiAKKyoq
IEdvLXRzIG1vZGUKKworKysrCisqKiogTmV3IHVuaXQgdGVzdCBjb21tYW5kcy4KK1RocmVlIG5l
dyBjb21tYW5kcyBhcmUgbm93IGF2YWlsYWJsZSB0byBydW4gdW5pdCB0ZXN0cy4KKworVGhlICdn
by10cy1tb2RlLXRlc3QtZnVuY3Rpb24tYXQtcG9pbnQnIGNvbW1hbmQgcnVucyB0aGUgdW5pdCB0
ZXN0IGF0Citwb2ludC4gIElmIGEgcmVnaW9uIGlzIGFjdGl2ZSwgaXQgcnVucyBhbGwgdGhlIHVu
aXQgdGVzdHMgdW5kZXIgdGhlCityZWdpb24uICBJdCBpcyBib3VuZCB0byAnQy1jIEMtdCB0JyBp
biAnZ28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS10ZXN0LXRoaXMtZmlsZScgY29tbWFu
ZCBydW5zIGFsbCB1bml0IHRlc3RzIGluIHRoZSBjdXJyZW50CitmaWxlLiBJdCBpcyBib3VuZCB0
byAnQy1jIEMtdCBmJyBpbiAnZ28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS10ZXN0LXRo
aXMtcGFja2FnZScgY29tbWFuZCBydW5zIGFsbCB1bml0IHRlc3RzIHVuZGVyIHRoZQorcGFja2Fn
ZSBvZiB0aGUgY3VycmVudCBidWZmZXIuICBJdCBpcyBib3VuZCB0byAnQy1jIEMtdCBwJyBpbiAn
Z28tdHMtbW9kZScuCisKK1RoZSAnZ28tdHMtbW9kZS1idWlsZC10YWdzJyB2YXJpYWJsZSBpcyBh
dmFpbGFibGUgdG8gc2V0IGEgbGlzdCBvZiBidWlsZAordGFncyBmb3IgdGhlIHRlc3QgY29tbWFu
ZHMuCisKICoqIEVtYWNzIExpc3AgbW9kZQogCiAtLS0KZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21v
ZGVzL2dvLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCmluZGV4IDJk
M2U2YWFjMDkwLi4zZmU0MjdmYTkxMSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMt
bW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCkBAIC00Niw2ICs0Niwx
MiBAQCBnby10cy1tb2RlLWluZGVudC1vZmZzZXQKICAgOnNhZmUgJ2ludGVnZXJwCiAgIDpncm91
cCAnZ28pCiAKKyhkZWZjdXN0b20gZ28tdHMtbW9kZS1idWlsZC10YWdzIG5pbAorICAiTGlzdCBv
ZiBHbyBidWlsZCB0YWdzIGZvciB0aGUgdGVzdCBjb21tYW5kcy4iCisgIDp2ZXJzaW9uICIzMC4x
IgorICA6dHlwZSAnKHJlcGVhdCBzdHJpbmcpCisgIDpncm91cCAnZ28pCisKIChkZWZ2YXIgZ28t
dHMtbW9kZS0tc3ludGF4LXRhYmxlCiAgIChsZXQgKCh0YWJsZSAobWFrZS1zeW50YXgtdGFibGUp
KSkKICAgICAobW9kaWZ5LXN5bnRheC1lbnRyeSA/KyAgICIuIiAgICAgIHRhYmxlKQpAQCAtMjQy
LDcgKzI0OCwxMCBAQCBnby10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MKIChkZWZ2YXIta2V5
bWFwIGdvLXRzLW1vZGUtbWFwCiAgIDpkb2MgIktleW1hcCB1c2VkIGluIEdvIG1vZGUsIHBvd2Vy
ZWQgYnkgdHJlZS1zaXR0ZXIiCiAgIDpwYXJlbnQgcHJvZy1tb2RlLW1hcAotICAiQy1jIEMtZCIg
Iydnby10cy1tb2RlLWRvY3N0cmluZykKKyAgIkMtYyBDLWQiICMnZ28tdHMtbW9kZS1kb2NzdHJp
bmcKKyAgIkMtYyBDLXQgdCIgIydnby10cy1tb2RlLXRlc3QtZnVuY3Rpb24tYXQtcG9pbnQKKyAg
IkMtYyBDLXQgZiIgIydnby10cy1tb2RlLXRlc3QtdGhpcy1maWxlCisgICJDLWMgQy10IHAiICMn
Z28tdHMtbW9kZS10ZXN0LXRoaXMtcGFja2FnZSkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZpbmUt
ZGVyaXZlZC1tb2RlIGdvLXRzLW1vZGUgcHJvZy1tb2RlICJHbyIKQEAgLTM3NSw2ICszODQsODMg
QEAgZ28tdHMtbW9kZS0tY29tbWVudC1vbi1wcmV2aW91cy1saW5lLXAKICAgICAgKDw9ICh0cmVl
c2l0LW5vZGUtc3RhcnQgbm9kZSkgcG9pbnQgKHRyZWVzaXQtbm9kZS1lbmQgbm9kZSkpCiAgICAg
IChzdHJpbmctZXF1YWwgImNvbW1lbnQiICh0cmVlc2l0LW5vZGUtdHlwZSBub2RlKSkpKSkKIAor
KGRlZnVuIGdvLXRzLW1vZGUtLWdldC1idWlsZC10YWdzLWZsYWcgKCkKKyAgIlJldHVybiB0aGUg
Y29tcGlsZSBmbGFnIGZvciBidWlsZCB0YWdzLgorVGhpcyBmdW5jdGlvbiByZXNwZWN0cyB0aGUg
YGdvLXRzLW1vZGUtYnVpbGQtdGFncycgdmFyaWFibGUgZm9yCitzcGVjaWZ5aW5nIGJ1aWxkIHRh
Z3MuIgorICAoaWYgZ28tdHMtbW9kZS1idWlsZC10YWdzCisgICAgICAoZm9ybWF0ICItdGFncyAl
cyIgKHN0cmluZy1qb2luIGdvLXRzLW1vZGUtYnVpbGQtdGFncyAiLCIpKQorICAgICIiKSkKKwor
KGRlZnVuIGdvLXRzLW1vZGUtLWNvbXBpbGUtdGVzdCAocmVnZXhwKQorICAiQ29tcGlsZSB0aGUg
dGVzdHMgbWF0Y2hpbmcgUkVHRVhQLgorVGhpcyBmdW5jdGlvbiByZXNwZWN0cyB0aGUgYGdvLXRz
LW1vZGUtYnVpbGQtdGFncycgdmFyaWFibGUgZm9yCitzcGVjaWZ5aW5nIGJ1aWxkIHRhZ3MuIgor
ICAoY29tcGlsZSAoZm9ybWF0ICJnbyB0ZXN0IC12ICVzIC1ydW4gJyVzJyIKKyAgICAgICAgICAg
ICAgICAgICAoZ28tdHMtbW9kZS0tZ2V0LWJ1aWxkLXRhZ3MtZmxhZykKKyAgICAgICAgICAgICAg
ICAgICByZWdleHApKSkKKworKGRlZnVuIGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQgKHN0YXJ0
KQorICAiUmV0dXJuIHRoZSBmaXJzdCBkZWZ1biBub2RlIGZyb20gU1RBUlQuIgorICAobGV0ICgo
dGhpbmcgKG9yIHRyZWVzaXQtZGVmdW4tdHlwZS1yZWdleHAgJ2RlZnVuKSkpCisgICAgKG9yICh0
cmVlc2l0LXRoaW5nLWF0IHN0YXJ0IHRoaW5nKQorICAgICAgICAodHJlZXNpdC10aGluZy1uZXh0
IHN0YXJ0IHRoaW5nKSkpKQorCisoZGVmdW4gZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9uLXJlZ2V4
cCAobmFtZSkKKyAgKGlmIG5hbWUKKyAgICAgIChmb3JtYXQgIl4lcyQiIG5hbWUpCisgICAgKGVy
cm9yICJObyB0ZXN0IGZ1bmN0aW9uIGZvdW5kIikpKQorCisoZGVmdW4gZ28tdHMtbW9kZS0tZ2V0
LWZ1bmN0aW9ucy1pbi1yYW5nZSAoc3RhcnQgZW5kKQorICAiUmV0dXJuIGEgbGlzdCB3aXRoIHRo
ZSBuYW1lcyBvZiBhbGwgZGVmdW5zIGluIHRoZSByYW5nZSBTVEFSVCB0byBFTkQuIgorICAobGV0
KiAoKG5vZGUgKGdvLXRzLW1vZGUtLWZpbmQtZGVmdW4tYXQgc3RhcnQpKQorICAgICAgICAgKG5h
bWUgKHRyZWVzaXQtZGVmdW4tbmFtZSBub2RlKSkKKyAgICAgICAgIChub2RlLXN0YXJ0ICh0cmVl
c2l0LW5vZGUtc3RhcnQgbm9kZSkpCisgICAgICAgICAobm9kZS1lbmQgKHRyZWVzaXQtbm9kZS1l
bmQgbm9kZSkpKQorICAgIChjb25kICgob3IgKG5vdCBub2RlKQorICAgICAgICAgICAgICAgKD4g
c3RhcnQgbm9kZS1lbmQpCisgICAgICAgICAgICAgICAoPCBlbmQgbm9kZS1zdGFydCkpCisgICAg
ICAgICAgIG5pbCkKKyAgICAgICAgICAoKG9yIChub3QgKGVxdWFsICh0cmVlc2l0LW5vZGUtdHlw
ZSBub2RlKSAiZnVuY3Rpb25fZGVjbGFyYXRpb24iKSkKKyAgICAgICAgICAgICAgIChub3QgKHN0
cmluZy1wcmVmaXgtcCAiVGVzdCIgbmFtZSkpKQorICAgICAgICAgICAoZ28tdHMtbW9kZS0tZ2V0
LWZ1bmN0aW9ucy1pbi1yYW5nZSAodHJlZXNpdC1ub2RlLWVuZCBub2RlKSBlbmQpKQorICAgICAg
ICAgICh0CisgICAgICAgICAgIChjb25zIChnby10cy1tb2RlLS1nZXQtZnVuY3Rpb24tcmVnZXhw
IG5hbWUpCisgICAgICAgICAgICAgICAgIChnby10cy1tb2RlLS1nZXQtZnVuY3Rpb25zLWluLXJh
bmdlICh0cmVlc2l0LW5vZGUtZW5kIG5vZGUpIGVuZCkpKSkpKQorCisoZGVmdW4gZ28tdHMtbW9k
ZS0tZ2V0LXRlc3QtcmVnZXhwLWF0LXBvaW50ICgpCisgICJSZXR1cm4gYSByZWd1bGFyIGV4cHJl
c3Npb24gZm9yIHRoZSB0ZXN0cyBhdCBwb2ludC4KK0lmIHJlZ2lvbiBpcyBhY3RpdmUsIHRoZSBy
ZWdleHAgd2lsbCBpbmNsdWRlIGFsbCB0aGUgZnVuY3Rpb25zIHVuZGVyIHRoZQorcmVnaW9uLiIK
KyAgKGlmLWxldCAoKHJhbmdlIChpZiAocmVnaW9uLWFjdGl2ZS1wKQorICAgICAgICAgICAgICAg
ICAgICAgIChsaXN0IChyZWdpb24tYmVnaW5uaW5nKSAocmVnaW9uLWVuZCkpCisgICAgICAgICAg
ICAgICAgICAgIChsaXN0IChwb2ludCkgKHBvaW50KSkpKQorICAgICAgICAgICAoZnVuY3MgKGFw
cGx5ICMnZ28tdHMtbW9kZS0tZ2V0LWZ1bmN0aW9ucy1pbi1yYW5nZSByYW5nZSkpKQorICAgICAg
KHN0cmluZy1qb2luIGZ1bmNzICJ8IikKKyAgICAoZXJyb3IgIk5vIHRlc3QgZnVuY3Rpb24gZm91
bmQiKSkpCisKKyhkZWZ1biBnby10cy1tb2RlLXRlc3QtZnVuY3Rpb24tYXQtcG9pbnQgKCkKKyAg
IlJ1biB0aGUgdW5pdCB0ZXN0IGF0IHBvaW50LgorSWYgdGhlIHBvaW50IGlzIGFueXdoZXJlIGlu
IHRoZSB0ZXN0IGZ1bmN0aW9uLCB0aGF0IGZ1bmN0aW9uIHdpbGwgYmUKK3J1bi4gIElmIHRoZSBy
ZWdpb24gaXMgc2VsZWN0ZWQsIGFsbCB0aGUgZnVuY3Rpb25zIHVuZGVyIHRoZSByZWdpb24gd2ls
bAorYmUgcnVuLiIKKyAgKGludGVyYWN0aXZlKQorICAoZ28tdHMtbW9kZS0tY29tcGlsZS10ZXN0
IChnby10cy1tb2RlLS1nZXQtdGVzdC1yZWdleHAtYXQtcG9pbnQpKSkKKworKGRlZnVuIGdvLXRz
LW1vZGUtdGVzdC10aGlzLWZpbGUgKCkKKyAgIlJ1biBhbGwgdGhlIHVuaXQgdGVzdHMgaW4gdGhl
IGN1cnJlbnQgZmlsZS4iCisgIChpbnRlcmFjdGl2ZSkKKyAgKGlmLWxldCAoKGRlZnVucyAoZ28t
dHMtbW9kZS0tZ2V0LWZ1bmN0aW9ucy1pbi1yYW5nZSAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkp
KQorICAgICAgKGdvLXRzLW1vZGUtLWNvbXBpbGUtdGVzdCAoc3RyaW5nLWpvaW4gZGVmdW5zICJ8
IikpCisgICAgKGVycm9yICJObyB0ZXN0IGZ1bmN0aW9ucyBmb3VuZCBpbiB0aGUgY3VycmVudCBm
aWxlIikpKQorCisoZGVmdW4gZ28tdHMtbW9kZS10ZXN0LXRoaXMtcGFja2FnZSAoKQorICAiUnVu
IGFsbCB0aGUgdW5pdCB0ZXN0cyB1bmRlciB0aGUgY3VycmVudCBwYWNrYWdlLiIKKyAgKGludGVy
YWN0aXZlKQorICAoY29tcGlsZSAoZm9ybWF0ICJnbyB0ZXN0IC12ICVzIC1ydW4gJXMiCisgICAg
ICAgICAgICAgICAgICAgKGdvLXRzLW1vZGUtLWdldC1idWlsZC10YWdzLWZsYWcpCisgICAgICAg
ICAgICAgICAgICAgZGVmYXVsdC1kaXJlY3RvcnkpKSkKKwogOzsgZ28ubW9kIHN1cHBvcnQuCiAK
IChkZWZ2YXIgZ28tbW9kLXRzLW1vZGUtLXN5bnRheC10YWJsZQotLSAKMi4zOS4yCgo=
--00000000000049e50d061cf3c8b7--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Jul 2024 14:23:02 +0000
Resent-Message-ID: <handler.70939.B70939.17207077342064 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17207077342064
          (code B ref 70939); Thu, 11 Jul 2024 14:23:02 +0000
Received: (at 70939) by debbugs.gnu.org; 11 Jul 2024 14:22:14 +0000
Received: from localhost ([127.0.0.1]:52333 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sRugY-0000XE-Ci
	for submit <at> debbugs.gnu.org; Thu, 11 Jul 2024 10:22:14 -0400
Received: from mail-4323.proton.ch ([185.70.43.23]:52819)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sRugU-0000Wu-Qk
 for 70939 <at> debbugs.gnu.org; Thu, 11 Jul 2024 10:22:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1720707722; x=1720966922;
 bh=JWiUSeBjr0B1w0jYSHFLOdC0aALuUbmMw/kPTg0ELlg=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=qzepEfePnf6AUqe8nbS+xaKX/xtsAIMVv6LYp8bu1cV2dIi2DkLemAnP543oQNx2C
 FlUeJd9uLiuhOp17P4KkJcH3W9m9CDN0eqMsMy174dUoSipVyQWYV7kGi6VJoQOuHs
 HIHffTgien3nSiChh/lcAPLGhHHqsEXAdibafZD07YLCsEb75CnvU5u7Kb0US8w3vZ
 6S2a0tNbWQjmU1DRtEb3T+Lrv7CATmvcs76xLJOkWfmA5oDLufqCAIgi07Wcz+A+sB
 m2ia8AWHi+tzMbbVsS2bJFbUMZkqBop+1gQwTJ28CwW/cY44nJbw234t1BMiqDZjyE
 Zfwl9lqU+GWIg==
Date: Thu, 11 Jul 2024 14:21:59 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <R6pFEanxDujrPihXj3T6sVCM_KWwpjNoVPOhLP_aBw2OrRIsdPDfALnRG1xJzT3i5X_DXIo4cMIoxWTE09gaUqFbAJH1XSxChGpdOzYOs1M=@rjt.dev>
In-Reply-To: <CAN7zea0EC+ce=Wc+ASM7+7y9ts__c5137ik683uT4-FTaZcZ3w@HIDDEN>
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
 <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev>
 <CAN7zea0EC+ce=Wc+ASM7+7y9ts__c5137ik683uT4-FTaZcZ3w@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: d0ba95a8debc525869c1c508bef8e26b9c412cbf
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Thursday, July 11th, 2024 at 03:33, Ankit Gadiya <ankit@HIDDEN> wrote:
>=20
> > I only have a few comments about the commit message:
>=20
> > Three new commands are added in the go-ts-mode to run unit tests.
> > I would just drop this line altogether, personally.
> >=20
> > (go-ts-mode-map): New map variable.
> > This should probably read something like Add new bindings.
> >=20
> > (go-ts-mode-test-file): New function.
> > (go-ts-mode-test-package): New function.
> > These two need to be updated (...-test-this-...).
>=20
>=20
> Thanks, I'm sending the updated patch with these fixes.

Thanks, looks good!

>=20
> > Everything else looks good to me. Thanks for working on this, Ankit.
> >=20
> > Eli, if you have no further comments please install when you get a chan=
ce. Thanks in advance.
>=20
>=20
> Thank you for being patient through this review. After this interaction, =
I feel
> encouraged to send more patches in the future.

Glad to hear that! Thanks for putting up with us :).

>=20
> --
> Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 12 Jul 2024 06:24:02 +0000
Resent-Message-ID: <handler.70939.B70939.17207654304629 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: ankit@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.17207654304629
          (code B ref 70939); Fri, 12 Jul 2024 06:24:02 +0000
Received: (at 70939) by debbugs.gnu.org; 12 Jul 2024 06:23:50 +0000
Received: from localhost ([127.0.0.1]:53025 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sS9h8-0001Ca-0B
	for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 02:23:50 -0400
Received: from eggs.gnu.org ([209.51.188.92]:59718)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sS9h6-0001CN-77
 for 70939 <at> debbugs.gnu.org; Fri, 12 Jul 2024 02:23:48 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sS9gz-0002hu-B0; Fri, 12 Jul 2024 02:23:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=1r+IMyop4dnei4LVMfEI25zXCVzHDr5QF6VTRu7eaes=; b=VXeCYgl79NZE
 PIdhGacWznwXGFvQHKgHphkWVsY0JehQb6HYzPt0zVL50eV4DDbQ5FADcNRF6rGwwwYIVgP6bBfSn
 lE3GbVCGoLyIOiIcq+tMEoVSmnJiZgigAr8K+netBxRd3vnbDsYb6TLDBElsLZChnncG1J9+fnoRz
 PNnkeFNnRsamRbYRcvDeQpqTiOaoicQuT5l7AAfUphRdt+yA3ohoxMFMJix++y7cj+Thvu9Nwjy15
 Obb/j6Ha+BovT7WS3K691HQAIDft/Eo1XKGzgQmAm4MJYbmCBAtVeTllS5FP+8yXI73AkxEdkbZrj
 5xGNagKule6GIvVY0Timbg==;
Date: Fri, 12 Jul 2024 09:23:29 +0300
Message-Id: <86wmlrku1q.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <R6pFEanxDujrPihXj3T6sVCM_KWwpjNoVPOhLP_aBw2OrRIsdPDfALnRG1xJzT3i5X_DXIo4cMIoxWTE09gaUqFbAJH1XSxChGpdOzYOs1M=@rjt.dev>
 (message from Randy Taylor on Thu, 11 Jul 2024 14:21:59 +0000)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
 <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev>
 <CAN7zea0EC+ce=Wc+ASM7+7y9ts__c5137ik683uT4-FTaZcZ3w@HIDDEN>
 <R6pFEanxDujrPihXj3T6sVCM_KWwpjNoVPOhLP_aBw2OrRIsdPDfALnRG1xJzT3i5X_DXIo4cMIoxWTE09gaUqFbAJH1XSxChGpdOzYOs1M=@rjt.dev>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 11 Jul 2024 14:21:59 +0000
> From: Randy Taylor <dev@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
> 
> > > Everything else looks good to me. Thanks for working on this, Ankit.
> > > 
> > > Eli, if you have no further comments please install when you get a chance. Thanks in advance.
> > 
> > 
> > Thank you for being patient through this review. After this interaction, I feel
> > encouraged to send more patches in the future.
> 
> Glad to hear that! Thanks for putting up with us :).

Thank you all.

Ankit, it looks like your legal paperwork of copyright assignment has
stalled?  The last message I have about it is from 2 months ago, where
you were sent the PDF of your assignment and asked to sign and email
it back to the FSF.  Your assignment is still not on file.  Did you
email the signed PDF back to the FSF clerk, and did you subsequently
receive your assignment counter-signed by the FSF?

If you didn't email the signed PDF, please do so now.  If you did,
please ping them saying you didn't receive the counter-signed document
and CC me.  If you received the counter-signed assignment document,
please tell me, because it means the FSF clerk somehow failed to
update the records with your assignment.

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Ankit Gadiya <ankit@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 12 Jul 2024 11:12:01 +0000
Resent-Message-ID: <handler.70939.B70939.172078268111146 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Randy Taylor <dev@HIDDEN>, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.172078268111146
          (code B ref 70939); Fri, 12 Jul 2024 11:12:01 +0000
Received: (at 70939) by debbugs.gnu.org; 12 Jul 2024 11:11:21 +0000
Received: from localhost ([127.0.0.1]:53331 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sSEBM-0002th-MX
	for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 07:11:21 -0400
Received: from mail-vk1-f179.google.com ([209.85.221.179]:49277)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ankit@HIDDEN>) id 1sSEBI-0002tX-PV
 for 70939 <at> debbugs.gnu.org; Fri, 12 Jul 2024 07:11:19 -0400
Received: by mail-vk1-f179.google.com with SMTP id
 71dfb90a1353d-4ef33a09a3aso565967e0c.2
 for <70939 <at> debbugs.gnu.org>; Fri, 12 Jul 2024 04:11:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=argp.in; s=google; t=1720782616; x=1721387416; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=xy352fdFXDaXHhjCboY6js2Gw0v9cB4z88kYLOzYZ5g=;
 b=iLrjBx+KimEQVvk46PEHnVFjtP7FbXzO0khcr+Pj1Tui5W/H/isoWwRvO2CbDCUaMu
 lu3457qrfS+dGunIfPyZEQ704/QaPA9qzYmahRAPPOpGW95qgry6EOvP9nJiQO6E1Rzk
 XJ5+naPRKpJ1Q7KG2jR006/XeU9E3XluwIDqVDxnUW0W07dxlv7wk5N4r/XqjwUcm3Dr
 IXZA7Uujzu8Gx+hc4F1mt0XLQK/JQVHfxbXNWvZnVAGoyah2GXRi65uegJyOylfHN9qY
 aEkXuyxqkwXgYVEAHXQS2R0XoyYVIuiOltb1L/PofeNC1BcRZo+rQCG71YKApyewPcPZ
 m2Cg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1720782616; x=1721387416;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=xy352fdFXDaXHhjCboY6js2Gw0v9cB4z88kYLOzYZ5g=;
 b=Yhr/S+OS/IlqMvwhiE8Rt6lipYdKNSJpOf7DUr2dhIpTW4x0klluLOC97Par16InC7
 OMPrhFvhJNuSIMIQNe0paNX+4AXQz2crR0TVBAP71ZTMDAMhf00URf8u65irQKPlMppb
 Y41fKmB9MO+7fjrqh1WjsRJuPFOReHwYB0eTS5UVxicSdrVdLlAwaDl2cn/m+9SVgqxw
 2xsCkNe09rYOei/ZQmVxM3HjvbbJDvjbN6EJfPeRVrOBue9wola3s0EZ0OsyVjsfu7Ix
 8D+UaETBRtOh+Uos4MfoFevbM+HElHkqqLdZ6z14qHcIfSo0cm15+47Y2wyUY5mGMb/Z
 63uA==
X-Forwarded-Encrypted: i=1;
 AJvYcCUE6tCOgOCVQRmk5HxUAaDENiNn7aXEF+iCJXMY+2mvPv5PuEuPve4mgzs6yrmlRaY/NsC2wnRZybeBVJzz35/l5jhi9Co=
X-Gm-Message-State: AOJu0YyzUMXktAvObqdwaPF+8v7r8U0V7QPiN6lKfRzzNsXEOOdD3qUS
 ZSkd+L/M2LkjtjgP5y39H3cYa0+gCz+IcP4k9pWzmbmi5B/r0xsKHFyJxOwsgdA7SalpQHjEkR9
 MCbiLfvdAoNyA4DleDzcTjvjDthTGy6GaTpnH4g==
X-Google-Smtp-Source: AGHT+IG4eoRMAhuJBNM+F9j5bf+2fl7AOFlQC3eJoDYjJLdbn57MROJHwSO3J4GDHq+AGMaTriqBCauB40eg4PVgjHs=
X-Received: by 2002:a05:6122:2a0b:b0:4d4:21cc:5f4f with SMTP id
 71dfb90a1353d-4f33f2a828cmr12818089e0c.11.1720782615822; Fri, 12 Jul 2024
 04:10:15 -0700 (PDT)
MIME-Version: 1.0
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
 <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev>
 <CAN7zea0EC+ce=Wc+ASM7+7y9ts__c5137ik683uT4-FTaZcZ3w@HIDDEN>
 <R6pFEanxDujrPihXj3T6sVCM_KWwpjNoVPOhLP_aBw2OrRIsdPDfALnRG1xJzT3i5X_DXIo4cMIoxWTE09gaUqFbAJH1XSxChGpdOzYOs1M=@rjt.dev>
 <86wmlrku1q.fsf@HIDDEN>
In-Reply-To: <86wmlrku1q.fsf@HIDDEN>
From: Ankit Gadiya <ankit@HIDDEN>
Date: Fri, 12 Jul 2024 16:40:04 +0530
Message-ID: <CAN7zea3s3j4FRbxM7tsm08n4vY3RZhEaSbiCDh5CBxvpSx=bJA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Fri, 12 Jul 2024 at 11:53, Eli Zaretskii <eliz@HIDDEN> wrote:
>
> > Date: Thu, 11 Jul 2024 14:21:59 +0000
> > From: Randy Taylor <dev@HIDDEN>
> > Cc: Eli Zaretskii <eliz@HIDDEN>, 70939 <at> debbugs.gnu.org
> >
> > > > Everything else looks good to me. Thanks for working on this, Ankit.
> > > >
> > > > Eli, if you have no further comments please install when you get a chance. Thanks in advance.
> > >
> > >
> > > Thank you for being patient through this review. After this interaction, I feel
> > > encouraged to send more patches in the future.
> >
> > Glad to hear that! Thanks for putting up with us :).
>
> Thank you all.
>
> Ankit, it looks like your legal paperwork of copyright assignment has
> stalled?  The last message I have about it is from 2 months ago, where
> you were sent the PDF of your assignment and asked to sign and email
> it back to the FSF.  Your assignment is still not on file.  Did you
> email the signed PDF back to the FSF clerk, and did you subsequently
> receive your assignment counter-signed by the FSF?
>
> If you didn't email the signed PDF, please do so now.  If you did,
> please ping them saying you didn't receive the counter-signed document
> and CC me.  If you received the counter-signed assignment document,
> please tell me, because it means the FSF clerk somehow failed to
> update the records with your assignment.
>
> Thanks.

Hey Eli, I emailed all the requirements for Copyright Assignments 2 months ago.
However, Craig informed me 5 days ago that he accidentally assigned the wrong
person so it stalled. He has fixed it and so I'm hoping the process will
complete soon.

-- 
Ankit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 12 Jul 2024 11:23:01 +0000
Resent-Message-ID: <handler.70939.B70939.172078332512203 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70939
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ankit Gadiya <ankit@HIDDEN>
Cc: dev@HIDDEN, 70939 <at> debbugs.gnu.org
Received: via spool by 70939-submit <at> debbugs.gnu.org id=B70939.172078332512203
          (code B ref 70939); Fri, 12 Jul 2024 11:23:01 +0000
Received: (at 70939) by debbugs.gnu.org; 12 Jul 2024 11:22:05 +0000
Received: from localhost ([127.0.0.1]:53337 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sSELl-0003Al-0T
	for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 07:22:05 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44594)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sSELi-0003AC-P6
 for 70939 <at> debbugs.gnu.org; Fri, 12 Jul 2024 07:22:03 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sSELc-0001Bw-Qg; Fri, 12 Jul 2024 07:21:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=IOsijhabaoiXO3xzb+pQZ1u5HORCn5ohBJjp6CiJ764=; b=YTodm6oNpmYP
 GPzdbwqJzCa0qS7MIHHTN/NNVUJaERf/ygDtbKEm7I8bf2KApBWjGLCo+VHf0sh8KJCoq5a8cRAnx
 Uo1AV0qsAXvWA4hIJcyBeiJQQkwC4ZpdWDwwNpYCNVq3JGBqZPWCBDU9D4tB4DKqFnQQDOEo3LwzQ
 69PT185yFxXaslRw8GWwhN4NyUedK1nNlbCmaxvIEZzDMJz1QeKivDElJGfld+o/5UDZ51BKJI2/O
 kujZqrEX2QYxQ+dMDDfdDczA5JguLE86Jrax74uEQ7g9rl3OvULyyN5M/u6acEue0fPwKWplQERMc
 fwiLKazQUdg0AHRTP7f5mQ==;
Date: Fri, 12 Jul 2024 14:21:53 +0300
Message-Id: <86o772lusu.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAN7zea3s3j4FRbxM7tsm08n4vY3RZhEaSbiCDh5CBxvpSx=bJA@HIDDEN>
 (message from Ankit Gadiya on Fri, 12 Jul 2024 16:40:04 +0530)
References: <CAN7zea06QNQ=w0nYGD2+f1W8D2ecNUWoWEtBpnMrSsjpoQFEEw@HIDDEN>
 <CAN7zea3Ukzx9GacROkO1WVFicwfNhdAmM5y+7AR6H+5qefYAjA@HIDDEN>
 <CAN7zea2AcQLptvQqQJtE96UWbz8wvLPTVvo2D5=BidpG80BcmQ@HIDDEN>
 <NWKc70ruav6iWPGFdtsOLLBuxUSZ231FTvDwmOJErv-v63NlWn0fzynGwnGX0Bo0VpzuSHuhkfKDK4z16zklHTk_18FEtf2mEqFPoQQjMzk=@rjt.dev>
 <CAN7zea1dcQqevakk97zLBj9MNKCQ-QFcG_ZojP37AH6fbr7A7Q@HIDDEN>
 <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev>
 <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@HIDDEN>
 <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev>
 <CAN7zea0EC+ce=Wc+ASM7+7y9ts__c5137ik683uT4-FTaZcZ3w@HIDDEN>
 <R6pFEanxDujrPihXj3T6sVCM_KWwpjNoVPOhLP_aBw2OrRIsdPDfALnRG1xJzT3i5X_DXIo4cMIoxWTE09gaUqFbAJH1XSxChGpdOzYOs1M=@rjt.dev>
 <86wmlrku1q.fsf@HIDDEN>
 <CAN7zea3s3j4FRbxM7tsm08n4vY3RZhEaSbiCDh5CBxvpSx=bJA@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Ankit Gadiya <ankit@HIDDEN>
> Date: Fri, 12 Jul 2024 16:40:04 +0530
> Cc: Randy Taylor <dev@HIDDEN>, 70939 <at> debbugs.gnu.org
> 
> Hey Eli, I emailed all the requirements for Copyright Assignments 2 months ago.
> However, Craig informed me 5 days ago that he accidentally assigned the wrong
> person so it stalled. He has fixed it and so I'm hoping the process will
> complete soon.

OK, thanks for the update.  If this doesn't come to completion in a
week or two, please ping Craig and CC me.

Last modified: Fri, 12 Jul 2024 11:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.