GNU bug report logs - #70963
[PATCH] Add Oklab color space utility functions in color.el.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70963 in the body.
You can then email your comments to 70963 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Church <chrchr <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add Oklab color space utility functions in color.el.
Date: Wed, 15 May 2024 09:58:27 -0700

[Message part 1 (text/plain, inline)]

This patch adds functions to convert to and from the Oklab perceptual color
space to color.el. Oklab preserves the perceived brightness ot a color as
the hue and saturation change. It is especially useful for programmatically
generating color schemes, and can be used directly in CSS in current web
browsers.

Oklab is described here: https://bottosson.github.io/posts/oklab/

[Message part 2 (text/html, inline)]

[0001-Add-Oklab-color-space-utility-functions-in-color.el.patch (application/octet-stream, attachment)]

Message #8 received at 70963 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Robert Church <chrchr <at> gmail.com>
Cc: 70963 <at> debbugs.gnu.org
Subject: Re: bug#70963: [PATCH] Add Oklab color space utility functions in
 color.el.
Date: Wed, 15 May 2024 14:00:08 -0400

Robert Church <chrchr <at> gmail.com> writes:

> This patch adds functions to convert to and from the Oklab perceptual color space to color.el. Oklab preserves the
> perceived brightness ot a color as the hue and saturation change. It is especially useful for programmatically generating
> color schemes, and can be used directly in CSS in current web browsers.
>
> Oklab is described here: https://bottosson.github.io/posts/oklab/

Hi Robert,

thanks for the patch.  Unless I'm wrong you have not the FSF copyright
paperwork done, would you be willg to do it in order to contrubute to
Emacs?

Thanks

  Andrea

Message #11 received at 70963 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Church <chrchr <at> gmail.com>
Cc: 70963 <at> debbugs.gnu.org
Subject: Re: bug#70963: [PATCH] Add Oklab color space utility functions in
 color.el.
Date: Wed, 15 May 2024 21:00:59 +0300

> From: Robert Church <chrchr <at> gmail.com>
> Date: Wed, 15 May 2024 09:58:27 -0700
> 
> This patch adds functions to convert to and from the Oklab perceptual color space to color.el. Oklab
> preserves the perceived brightness ot a color as the hue and saturation change. It is especially useful for
> programmatically generating color schemes, and can be used directly in CSS in current web browsers.
> 
> Oklab is described here: https://bottosson.github.io/posts/oklab/

Thanks.

Would you be willing to assign the copyright for your contribution to
the FSF?  We need this to accept contributions of this size.  If you
agree, I will send you the form to fill and the instructions to go
with the form.

Message #14 received at 70963 <at> debbugs.gnu.org (full text, mbox):

From: Robert Church <chrchr <at> gmail.com>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: 70963 <at> debbugs.gnu.org
Subject: Re: bug#70963: [PATCH] Add Oklab color space utility functions in
 color.el.
Date: Wed, 15 May 2024 11:41:49 -0700

[Message part 1 (text/plain, inline)]

Hi Andrea. I submitted the copyright paperwork to the FSF last month.

On Wed, May 15, 2024, 11:00 AM Andrea Corallo <acorallo <at> gnu.org> wrote:

> Robert Church <chrchr <at> gmail.com> writes:
>
> > This patch adds functions to convert to and from the Oklab perceptual
> color space to color.el. Oklab preserves the
> > perceived brightness ot a color as the hue and saturation change. It is
> especially useful for programmatically generating
> > color schemes, and can be used directly in CSS in current web browsers.
> >
> > Oklab is described here: https://bottosson.github.io/posts/oklab/
>
> Hi Robert,
>
> thanks for the patch.  Unless I'm wrong you have not the FSF copyright
> paperwork done, would you be willg to do it in order to contrubute to
> Emacs?
>
> Thanks
>
>   Andrea
>

[Message part 2 (text/html, inline)]

Message #17 received at 70963 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Robert Church <chrchr <at> gmail.com>, Andrea Corallo <acorallo <at> gnu.org>
Cc: 70963 <at> debbugs.gnu.org
Subject: Re: bug#70963: [PATCH] Add Oklab color space utility functions in
 color.el.
Date: Sat, 18 May 2024 22:16:34 +0000

Robert Church <chrchr <at> gmail.com> writes:

> Hi Andrea. I submitted the copyright paperwork to the FSF last month.

The paperwork has been finalized according to an email from the
FSF copyright clerk on Thu, 16 May 2024 15:56:58 -0400.

Message #22 received at 70963-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Church <chrchr <at> gmail.com>
Cc: 70963-done <at> debbugs.gnu.org
Subject: Re: bug#70963: [PATCH] Add Oklab color space utility functions in
 color.el.
Date: Sun, 19 May 2024 11:25:25 +0300

> From: Robert Church <chrchr <at> gmail.com>
> Date: Wed, 15 May 2024 09:58:27 -0700
> 
> This patch adds functions to convert to and from the Oklab perceptual color space to color.el. Oklab
> preserves the perceived brightness ot a color as the hue and saturation change. It is especially useful for
> programmatically generating color schemes, and can be used directly in CSS in current web browsers.
> 
> Oklab is described here: https://bottosson.github.io/posts/oklab/

Thanks, I installed this on the master branch.

For the future, please try to observe our conventions for patch
submissions:

  . accompany the patches with suitable ChangeLog-style commit log
    messages (you can see the examples in what I actually committed,
    and the instructions are in CONTRIBUTE)
  . leave 2 spaces between sentences in doc strings and comments
  . announce any worthy changes in NEWS and propose changes for the
    manuals when appropriate

I'm closing the bug report with this message.

Message #25 received at 70963 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 70963 <at> debbugs.gnu.org, chrchr <at> gmail.com, acorallo <at> gnu.org
Subject: Re: bug#70963: [PATCH] Add Oklab color space utility functions in
 color.el.
Date: Sun, 19 May 2024 11:25:49 +0300

> Cc: 70963 <at> debbugs.gnu.org
> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sat, 18 May 2024 22:16:34 +0000
> 
> Robert Church <chrchr <at> gmail.com> writes:
> 
> > Hi Andrea. I submitted the copyright paperwork to the FSF last month.
> 
> The paperwork has been finalized according to an email from the
> FSF copyright clerk on Thu, 16 May 2024 15:56:58 -0400.

Right, and so I installed the changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.