GNU bug report logs - #70971
[PATCH 0/3] Update dhewm3

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: James Smith <jsubuntuxp@HIDDEN>; Keywords: patch; Done: Andreas Enge <andreas@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 70971-done <at> debbugs.gnu.org:

Received: (at 70971-done) by debbugs.gnu.org; 30 Jun 2024 10:47:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 30 06:47:36 2024
Received: from localhost ([127.0.0.1]:55255 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sNs5n-0001qo-PG
	for submit <at> debbugs.gnu.org; Sun, 30 Jun 2024 06:47:35 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:40910)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>) id 1sNs5l-0001qP-RQ
 for 70971-done <at> debbugs.gnu.org; Sun, 30 Jun 2024 06:47:34 -0400
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 043071C7;
 Sun, 30 Jun 2024 12:46:58 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id cPx4Vkdo93kn; Sun, 30 Jun 2024 12:46:57 +0200 (CEST)
Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 81CAFF6;
 Sun, 30 Jun 2024 12:46:57 +0200 (CEST)
Date: Sun, 30 Jun 2024 12:46:56 +0200
From: Andreas Enge <andreas@HIDDEN>
To: 70971-done <at> debbugs.gnu.org
Subject: Close
Message-ID: <ZoE3oJnHKthgq62I@jurong>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 70971-done
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

I am closing this bug report, as I think either way, using tarballs or
git repositories, is fine. Now that the switch to git has been applied,
I do not see a compelling reason to revert it.

Andreas

Notification sent to James Smith <jsubuntuxp@HIDDEN>:
bug acknowledged by developer. Full text available.

Reply sent to Andreas Enge <andreas@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 70971 <at> debbugs.gnu.org:

Received: (at 70971) by debbugs.gnu.org; 22 Jun 2024 16:33:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 22 12:33:46 2024
Received: from localhost ([127.0.0.1]:51850 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sL3gP-0003YN-Mu
	for submit <at> debbugs.gnu.org; Sat, 22 Jun 2024 12:33:46 -0400
Received: from mira.cbaines.net ([212.71.252.8]:43872)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1sL3gN-0003YE-TE
 for 70971 <at> debbugs.gnu.org; Sat, 22 Jun 2024 12:33:44 -0400
Received: from localhost (unknown [212.132.255.81])
 by mira.cbaines.net (Postfix) with ESMTPSA id CA4B227BBE2;
 Sat, 22 Jun 2024 17:33:42 +0100 (BST)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 4c080abb;
 Sat, 22 Jun 2024 16:33:41 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: [bug#70971] [PATCH v2 1/3] gnu: dhewm3: Use git repository.
In-Reply-To: <864j9zzm00.fsf@HIDDEN> (James Smith's message of "Tue, 11
 Jun 2024 05:45:19 -0700")
References: <cover.1717739144.git.jsubuntuxp@HIDDEN>
 <5e1af945c5118711bf3d16d10eb0df91d1841cbc.1717739144.git.jsubuntuxp@HIDDEN>
 <87a5jrbw83.fsf@HIDDEN> <864j9zzm00.fsf@HIDDEN>
User-Agent: mu4e 1.12.4; emacs 29.3
Date: Sat, 22 Jun 2024 17:33:39 +0100
Message-ID: <877ceh6ios.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 70971
Cc: 70971 <at> debbugs.gnu.org, James Smith <jsubuntuxp@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

James Smith <jsubuntuxp@HIDDEN> writes:

> Christopher Baines <mail@HIDDEN> writes:
>
>> James Smith via Guix-patches via <guix-patches@HIDDEN> writes:
>>
>>> * gnu/packages/game-development.scm (dhewm3) [source]: Use git repository
>>> instead of downloading a tarball from GitHub.
>>>
>>> Change-Id: I81ff5de0687221d7eec64b0165dbf10c2d041260
>>> ---
>>>  gnu/packages/game-development.scm | 12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> I'm missing why you're making this change? I don't see anything wrong
>> with using these upstream release tarballs.
>
> I noticed that the package was using a tarball from GitHub and assumed
> that it was one that was autogenerated. Upon closer inspection, I see
> that it's a manually pack tarball instead. I can send a new set of
> patches that excludes switching to the git repository if needed.

I tried to apply the patches, but they look to have already been
applied.

I'll leave the issue open until it's been decided whether to keep the
switch to the Git repository or go back to using tarballs.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZ2/ONfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xd3VRAAn9xihzc8Ae2cjhn4aIn8Dlmz7nivFuaS
/3qgfWohmLLayE57TfGIcJza5rTpiEHoQFnS9bHcnKps1cO3SsKXkFIIjp7ZbA5p
7xwD3C1kJvILuBtv/hK2A3OT2cKWBzjDFsFxxy5YfzgybHVZ3npnt1Nq9GjC56UY
z2wxrZLVXMFfzDkt44Yn9ScLZSFMXaZCPxu/N/nnvb8YWa7BY5HBhvuGSCh5pIJO
Qg8sk7aUxbi8/1yR6hSd4EAWNiw6LoGNjLr6n/uSsrIgfsffOA5QnkH6UhmqOzGL
pnAeYDbmtPLC+jmbyxRMIWsES67CfUpy9PWDVAs3BOTQM4W1NB4jfEYu6gKqrIC0
vieWVUIyz0wBTD62g9aKSm07rjPQJBicpl5tLjTFnklbSRiBccUr9UheuVaPscT0
oE3cJTgDIeMyot4SfHLWyS/XIXr4/hJZSrUuxfujNM8jfBiIqyKPLUgjOlxMphjD
XHW6N56ohxZTJ2mP/ncdczHyEMRUdxV4zBaNE7nr6TbRWsqw2nhfSsMzL7V35U3u
MHXElno/rhApqyZnsku14MFGD0S0uqwZ4Pqzrg1rtV6IZruMfQrZ4edHpMXxNk1r
Lvdp0ufFYdmsLyRA8FXXzaDt6mQZSVa1j4uWkEk3K7hnLYaLDP89TzZFSjE9ZCfI
QSUxhhluNXg=
=SQbZ
-----END PGP SIGNATURE-----
--=-=-=--

Information forwarded to guix-patches@HIDDEN:
bug#70971; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 11 Jun 2024 20:33:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 11 16:33:15 2024
Received: from localhost ([127.0.0.1]:36546 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sH8B9-0005uY-DI
	for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 16:33:15 -0400
Received: from lists.gnu.org ([209.51.188.17]:47004)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1sH8B6-0005td-OJ
 for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 16:33:12 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1sGytU-0007hT-PJ
 for guix-patches@HIDDEN; Tue, 11 Jun 2024 06:38:24 -0400
Received: from mira.cbaines.net ([212.71.252.8])
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@HIDDEN>) id 1sGytS-0003qm-Ql
 for guix-patches@HIDDEN; Tue, 11 Jun 2024 06:38:24 -0400
Received: from localhost (unknown [212.132.255.10])
 by mira.cbaines.net (Postfix) with ESMTPSA id 9CE3627BBE2;
 Tue, 11 Jun 2024 11:38:21 +0100 (BST)
Received: from felis (localhost.lan [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id f2f1fac8;
 Tue, 11 Jun 2024 10:38:20 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
To: James Smith via Guix-patches via <guix-patches@HIDDEN>
Subject: Re: [bug#70971] [PATCH v2 1/3] gnu: dhewm3: Use git repository.
In-Reply-To: <5e1af945c5118711bf3d16d10eb0df91d1841cbc.1717739144.git.jsubuntuxp@HIDDEN>
 (James Smith via Guix-patches via's message of "Thu, 6 Jun 2024
 22:45:42 -0700")
References: <cover.1717739144.git.jsubuntuxp@HIDDEN>
 <5e1af945c5118711bf3d16d10eb0df91d1841cbc.1717739144.git.jsubuntuxp@HIDDEN>
User-Agent: mu4e 1.12.4; emacs 29.3
Date: Tue, 11 Jun 2024 11:38:20 +0100
Message-ID: <87a5jrbw83.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@HIDDEN;
 helo=mira.cbaines.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>, 70971 <at> debbugs.gnu.org,
 Adam Faiz <adam.faiz@HIDDEN>, James Smith <jsubuntuxp@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain

James Smith via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/game-development.scm (dhewm3) [source]: Use git repository
> instead of downloading a tarball from GitHub.
>
> Change-Id: I81ff5de0687221d7eec64b0165dbf10c2d041260
> ---
>  gnu/packages/game-development.scm | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

I'm missing why you're making this change? I don't see anything wrong
with using these upstream release tarballs.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZoKRxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdjUA//SqUK91UHrpL8fdfdtywSZMrkdpaGif+y
22D4vZuimqtsMxQQhn/4mbAHSGGhFfB8iANPD5kvU2SnVJg6c536kJrqIuElEWJw
s+UbCoSHTEx+P+goed691p54ygh0jpywMoJ6ch7CLWk5dnZcyIiyZU3MdWQe/Vfe
yZsDJd66CSJvaMvnlUugO9tpfObqoRDi8y2WiKBrS6dgnJqYsjSX1GoI3TCV+Rrq
7neNS6ZxJGM8o1cuYXjV9hnqZ+/iMs2a+Ay3o9BRh0Kj/Q303ekGfZSwJ/AOGp7m
TveflURAzx9lgiT8FUvrg5y25NaBp+iTxnuSPKPjn8rUIa6KvwdgchaAbdUgfbld
wjUNa9JmN7aan8ANSNc2OiI2Jx+jtE31VLnusyoKkr9WNnqALKYRvYZ5hHGryel5
FCGYwW+TIgBIR1QEudmHk4QM0OBPsz5ovhrNjfQrpOD+deLp4YCsfdtSn5bzk1jW
3Lu9T7+rbe9kRuRNajysgmmT3+KKdA7d4eCB/BCOyr/JAGWrgN5mnCczQygZIYzX
SKwgUWuQFiTXAPWnoKw5Ir9pNZuVKKip65srgrW4Tfkaa0XjQqrlKJUlCjvUNuBl
rWo+kUX9ClOmpD0Tlvy2a6NaDKHqGcmZINxJDfPNxE8yTUpwjnGEHChQw7BODtqC
N/dnqeR7UEU=
=Ypog
-----END PGP SIGNATURE-----
--=-=-=--

Information forwarded to guix-patches@HIDDEN:
bug#70971; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 11 Jun 2024 20:32:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 11 16:32:54 2024
Received: from localhost ([127.0.0.1]:36505 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sH8Ao-0005rJ-8p
	for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 16:32:54 -0400
Received: from lists.gnu.org ([209.51.188.17]:33854)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jsubuntuxp@HIDDEN>) id 1sH8Al-0005qv-Js
 for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 16:32:52 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jsubuntuxp@HIDDEN>)
 id 1sH0ta-00067H-BM
 for guix-patches@HIDDEN; Tue, 11 Jun 2024 08:46:38 -0400
Received: from layka.disroot.org ([178.21.23.139])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <jsubuntuxp@HIDDEN>)
 id 1sH0tY-0003Qz-Gf
 for guix-patches@HIDDEN; Tue, 11 Jun 2024 08:46:38 -0400
X-Virus-Scanned: SPAM Filter at disroot.org
From: James Smith <jsubuntuxp@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1718109993; bh=eQNvoJWfsSPLHUl0moQmTNURKegmdrj2HXWW98LJmGY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=fK3uphUsAdc8J7NAOD8kz/2ciGqqCTyJ1WNqR0rMF8LcjEnWD3kFsEEI++eTq41O1
 JS3B0hSHHcmboa5RujuJZsw99VRS3/RfyxAESKq6w9spWfMmOZ2VUSKrcZPOjnANjJ
 OQ+6dy2xmuXfYzIb32Y6ovVbc1Nl4bIL9tizos3UfbCGoPn2ORiItk7/ceEXTyjNMc
 jKDOmnzfh4f6/00srH3m/ddDw0yIw6baDHb819ljYYzXZv6d159VhwQy8yA0gHmAuj
 +RhlA8pGTv69A1tSiM6Hmpt8ltXwdh/mGSHwj6TUylxccHFeIADSEDek8i1mKWC1BD
 X3OFtkp9R1Bcw==
To: Christopher Baines <mail@HIDDEN>
Subject: Re: [bug#70971] [PATCH v2 1/3] gnu: dhewm3: Use git repository.
In-Reply-To: <87a5jrbw83.fsf@HIDDEN> (Christopher Baines's message of
 "Tue, 11 Jun 2024 11:38:20 +0100")
References: <cover.1717739144.git.jsubuntuxp@HIDDEN>
 <5e1af945c5118711bf3d16d10eb0df91d1841cbc.1717739144.git.jsubuntuxp@HIDDEN>
 <87a5jrbw83.fsf@HIDDEN>
Date: Tue, 11 Jun 2024 05:45:19 -0700
Message-ID: <864j9zzm00.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=178.21.23.139;
 envelope-from=jsubuntuxp@HIDDEN; helo=layka.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>, 70971 <at> debbugs.gnu.org,
 Adam Faiz <adam.faiz@HIDDEN>,
 James Smith via Guix-patches via <guix-patches@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

Christopher Baines <mail@HIDDEN> writes:

> James Smith via Guix-patches via <guix-patches@HIDDEN> writes:
>
>> * gnu/packages/game-development.scm (dhewm3) [source]: Use git repository
>> instead of downloading a tarball from GitHub.
>>
>> Change-Id: I81ff5de0687221d7eec64b0165dbf10c2d041260
>> ---
>>  gnu/packages/game-development.scm | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> I'm missing why you're making this change? I don't see anything wrong
> with using these upstream release tarballs.

I noticed that the package was using a tarball from GitHub and assumed
that it was one that was autogenerated. Upon closer inspection, I see
that it's a manually pack tarball instead. I can send a new set of
patches that excludes switching to the git repository if needed.

Information forwarded to guix-patches@HIDDEN:
bug#70971; Package guix-patches. Full text available.

Message received at 70971 <at> debbugs.gnu.org:

Received: (at 70971) by debbugs.gnu.org; 11 Jun 2024 16:36:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 11 12:36:13 2024
Received: from localhost ([127.0.0.1]:36086 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sH4Tl-0004v2-Dz
	for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 12:36:13 -0400
Received: from mira.cbaines.net ([212.71.252.8]:43828)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1sH4Tk-0004ut-18
 for 70971 <at> debbugs.gnu.org; Tue, 11 Jun 2024 12:36:12 -0400
Received: from localhost (unknown [212.132.255.10])
 by mira.cbaines.net (Postfix) with ESMTPSA id 9CE3627BBE2;
 Tue, 11 Jun 2024 11:38:21 +0100 (BST)
Received: from felis (localhost.lan [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id f2f1fac8;
 Tue, 11 Jun 2024 10:38:20 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
To: James Smith via Guix-patches via <guix-patches@HIDDEN>
Subject: Re: [bug#70971] [PATCH v2 1/3] gnu: dhewm3: Use git repository.
In-Reply-To: <5e1af945c5118711bf3d16d10eb0df91d1841cbc.1717739144.git.jsubuntuxp@HIDDEN>
 (James Smith via Guix-patches via's message of "Thu, 6 Jun 2024
 22:45:42 -0700")
References: <cover.1717739144.git.jsubuntuxp@HIDDEN>
 <5e1af945c5118711bf3d16d10eb0df91d1841cbc.1717739144.git.jsubuntuxp@HIDDEN>
User-Agent: mu4e 1.12.4; emacs 29.3
Date: Tue, 11 Jun 2024 11:38:20 +0100
Message-ID: <87a5jrbw83.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 70971
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>, 70971 <at> debbugs.gnu.org,
 Adam Faiz <adam.faiz@HIDDEN>, James Smith <jsubuntuxp@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

James Smith via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/game-development.scm (dhewm3) [source]: Use git repository
> instead of downloading a tarball from GitHub.
>
> Change-Id: I81ff5de0687221d7eec64b0165dbf10c2d041260
> ---
>  gnu/packages/game-development.scm | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

I'm missing why you're making this change? I don't see anything wrong
with using these upstream release tarballs.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZoKRxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdjUA//SqUK91UHrpL8fdfdtywSZMrkdpaGif+y
22D4vZuimqtsMxQQhn/4mbAHSGGhFfB8iANPD5kvU2SnVJg6c536kJrqIuElEWJw
s+UbCoSHTEx+P+goed691p54ygh0jpywMoJ6ch7CLWk5dnZcyIiyZU3MdWQe/Vfe
yZsDJd66CSJvaMvnlUugO9tpfObqoRDi8y2WiKBrS6dgnJqYsjSX1GoI3TCV+Rrq
7neNS6ZxJGM8o1cuYXjV9hnqZ+/iMs2a+Ay3o9BRh0Kj/Q303ekGfZSwJ/AOGp7m
TveflURAzx9lgiT8FUvrg5y25NaBp+iTxnuSPKPjn8rUIa6KvwdgchaAbdUgfbld
wjUNa9JmN7aan8ANSNc2OiI2Jx+jtE31VLnusyoKkr9WNnqALKYRvYZ5hHGryel5
FCGYwW+TIgBIR1QEudmHk4QM0OBPsz5ovhrNjfQrpOD+deLp4YCsfdtSn5bzk1jW
3Lu9T7+rbe9kRuRNajysgmmT3+KKdA7d4eCB/BCOyr/JAGWrgN5mnCczQygZIYzX
SKwgUWuQFiTXAPWnoKw5Ir9pNZuVKKip65srgrW4Tfkaa0XjQqrlKJUlCjvUNuBl
rWo+kUX9ClOmpD0Tlvy2a6NaDKHqGcmZINxJDfPNxE8yTUpwjnGEHChQw7BODtqC
N/dnqeR7UEU=
=Ypog
-----END PGP SIGNATURE-----
--=-=-=--

Information forwarded to guix-patches@HIDDEN:
bug#70971; Package guix-patches. Full text available.

Message received at 70971 <at> debbugs.gnu.org:

Received: (at 70971) by debbugs.gnu.org; 11 Jun 2024 15:51:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 11 11:51:30 2024
Received: from localhost ([127.0.0.1]:35822 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sH3mU-0000gh-If
	for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 11:51:30 -0400
Received: from layka.disroot.org ([178.21.23.139]:44132)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jsubuntuxp@HIDDEN>) id 1sH3mS-0000gY-Mb
 for 70971 <at> debbugs.gnu.org; Tue, 11 Jun 2024 11:51:29 -0400
X-Virus-Scanned: SPAM Filter at disroot.org
From: James Smith <jsubuntuxp@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1718109993; bh=eQNvoJWfsSPLHUl0moQmTNURKegmdrj2HXWW98LJmGY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=fK3uphUsAdc8J7NAOD8kz/2ciGqqCTyJ1WNqR0rMF8LcjEnWD3kFsEEI++eTq41O1
 JS3B0hSHHcmboa5RujuJZsw99VRS3/RfyxAESKq6w9spWfMmOZ2VUSKrcZPOjnANjJ
 OQ+6dy2xmuXfYzIb32Y6ovVbc1Nl4bIL9tizos3UfbCGoPn2ORiItk7/ceEXTyjNMc
 jKDOmnzfh4f6/00srH3m/ddDw0yIw6baDHb819ljYYzXZv6d159VhwQy8yA0gHmAuj
 +RhlA8pGTv69A1tSiM6Hmpt8ltXwdh/mGSHwj6TUylxccHFeIADSEDek8i1mKWC1BD
 X3OFtkp9R1Bcw==
To: Christopher Baines <mail@HIDDEN>
Subject: Re: [bug#70971] [PATCH v2 1/3] gnu: dhewm3: Use git repository.
In-Reply-To: <87a5jrbw83.fsf@HIDDEN> (Christopher Baines's message of
 "Tue, 11 Jun 2024 11:38:20 +0100")
References: <cover.1717739144.git.jsubuntuxp@HIDDEN>
 <5e1af945c5118711bf3d16d10eb0df91d1841cbc.1717739144.git.jsubuntuxp@HIDDEN>
 <87a5jrbw83.fsf@HIDDEN>
Date: Tue, 11 Jun 2024 05:45:19 -0700
Message-ID: <864j9zzm00.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Christopher Baines <mail@HIDDEN> writes: > James Smith
 via Guix-patches via <guix-patches@HIDDEN> writes: > >> *
 gnu/packages/game-development.scm
 (dhewm3) [source]: Use git repository >> instead of downloading a tarball
 from GitHub. >> >> [...] 
 Content analysis details:   (1.1 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.1 DATE_IN_PAST_03_06     Date: is 3 to 6 hours before Received: date
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: 70971
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>, 70971 <at> debbugs.gnu.org,
 Adam Faiz <adam.faiz@HIDDEN>,
 James Smith via Guix-patches via <guix-patches@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.1 (/)

Christopher Baines <mail@HIDDEN> writes:

> James Smith via Guix-patches via <guix-patches@HIDDEN> writes:
>
>> * gnu/packages/game-development.scm (dhewm3) [source]: Use git repository
>> instead of downloading a tarball from GitHub.
>>
>> Change-Id: I81ff5de0687221d7eec64b0165dbf10c2d041260
>> ---
>>  gnu/packages/game-development.scm | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> I'm missing why you're making this change? I don't see anything wrong
> with using these upstream release tarballs.

I noticed that the package was using a tarball from GitHub and assumed
that it was one that was autogenerated. Upon closer inspection, I see
that it's a manually pack tarball instead. I can send a new set of
patches that excludes switching to the git repository if needed.

Information forwarded to guix-patches@HIDDEN:
bug#70971; Package guix-patches. Full text available.