Received: (at 70994) by debbugs.gnu.org; 11 Feb 2025 19:41:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 14:41:26 2025 Received: from localhost ([127.0.0.1]:58800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thw8L-0007gZ-Vz for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:41:26 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:50191) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1thw8J-0007gD-LW for 70994 <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:41:24 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5de7531434fso5061069a12.0 for <70994 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 11:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739302877; x=1739907677; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=BQURDiitjXLDw6b+aN8ERwFUq1yoegZyEXWk2Cwd9Lo=; b=GeiYr5daIdRRIzKT2yefsvRn6avOJa0f1UAVoU1kCtJ6vXfxv+FCawilR5fodhhGTb 4orwg7noBEQvYc6KepaTnLRcIDmm+181x+SPkvUniB88GsjSSPvlrsuBqG9ek89ZG2QU 8Pju3nuiGfMl1MeXeZhVTmVZ8rZ47w4lulzVmRW+8qPnpVJ6PtEv0+4/CW1r91h8hYia 8Qk4+hMuYkvR49/emTSZ2WJIMqA+/vqIAcvkqozGLs7mFOea1o0GVso5Yoz00VqZznM3 gW06t41MsIMibnyrMMixbMRX2cZw3mutsfRvPpuJDus6RGbaeaAgRrGOgaJ7mUW1eYRA d1sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739302877; x=1739907677; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BQURDiitjXLDw6b+aN8ERwFUq1yoegZyEXWk2Cwd9Lo=; b=H+eG3j2KLg1v0mWkICGP/67PpbXKqfEP9kJyiaxYUVC09SBqBeaVuYOsQeeKMPdMlM poNDkMZDDW7iY2C7/NHCfYxzJI+DYjyHByE8kfmdCnd4jxN+qnMdBuE9MgSxr+XuNa1X YSfPzEc9fuJWZLe3VdhvwuCL3pHwWNBdwjcouoIx9ZqN05qlGjM2+KH8r7HVuqNyH9Yl LRHJTQO7w159PNmqnhRyhMnFNue5YFECSsh9+6PnPog3s5tVPa874TtDZVKZ66jwI1Cu Mk9i2GExs5mIeda4mA1supmoGlSKz14QbK0ADzFjxtgJ1bHN3JKdiYMlSVGBqo+WRxEB 3BEQ== X-Forwarded-Encrypted: i=1; AJvYcCXLWaRWPf44Tm2Xoeb0MAZMBFYXia5SBX9Pc59k2Oud+ptYkmDQe1HyKE0vXMntgzoXZjmR9w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyNDROGUttwtkGvjgZ8Nz+siXdpTX9hhesx1C9elP13E3CmhUNu 2uO8+opdcA2Q72HMUKVyHI3IK30qhDavMoZIh/HJVLkVJVV4DEmL1JqGlZA1tQpR3vJWYCidIJy vsborruYlK/W7/8V1KVlmNrxSeag= X-Gm-Gg: ASbGncvaCLLXL3otg5red8vU0tmNYirDIfXWYnzDSbBpPBW7lN5oRQtPRU1BV7uyphQ +yDmV1DkqHYuQ57YPgy2j5pp+bzXoldNZOe/2TY5bdZylwDb/2Ki4iT3r/+ahje+ERP8L772zDw == X-Google-Smtp-Source: AGHT+IEcyObLu3d4c/bmgUjFtakCYnevAMvX6WgVlIglR/t4N7XqZsVI8hardfbFTGvHVswfKkXXJSxzo+gXTy/Tm+s= X-Received: by 2002:a05:6402:a01c:b0:5de:4b81:d3fd with SMTP id 4fb4d7f45d1cf-5deadd7ff5bmr511730a12.13.1739302877324; Tue, 11 Feb 2025 11:41:17 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 11:41:16 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <86le04yliu.fsf@HIDDEN> References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> <87le428xvg.fsf@HIDDEN> <86y182bg9t.fsf@HIDDEN> <87zfsg6lut.fsf@HIDDEN> <865xsbu83j.fsf@HIDDEN> <86plpynx9a.fsf@HIDDEN> <86le0mb7eb.fsf@HIDDEN> <86le04yliu.fsf@HIDDEN> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 11:41:16 -0800 X-Gm-Features: AWEUYZlC7AY81qKJrkW1mINe0o2_sVJfl-7SbkycDAXjAlKLPYw7XBtV2Jp2P7I Message-ID: <CADwFkm=ym2LgO3wNKoowDBj67Sm7C3pDVTizW4y9L=9YUPQ25Q@HIDDEN> Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70994 Cc: eric@HIDDEN, 70994 <at> debbugs.gnu.org, daniel@HIDDEN, James Thomas <jimjoe@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > Ping! Eric, any further comments, or should we install the patch? Friendly ping. > >> From: James Thomas <jimjoe@HIDDEN> >> Cc: eric@HIDDEN, 70994 <at> debbugs.gnu.org, >> stefankangas@HIDDEN, daniel@HIDDEN >> Date: Sat, 24 Aug 2024 14:54:28 +0530 >> >> Eli Zaretskii wrote: >> >> > Ping! Can we make some progress here? >> >> I'd like to confess again that this doesn't seem to be a big deal: >> 'gnus-cache-generate-nov-databases' and 'gnus-cache-generate-active' >> should work regardless. It's only for someone who might accidentally do >> this. >> >> Regards, >> James >> > >> >> Cc: 70994 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>, >> >> Daniel Semyonov <daniel@HIDDEN> >> >> Date: Thu, 08 Aug 2024 06:46:48 +0530 >> >> From: James Thomas via "Bug reports for GNU Emacs, >> >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> >> >> Eric Abrahamsen wrote: >> >> >> >> > James Thomas via "Bug reports for GNU Emacs, the Swiss army knife >> >> > of >> >> > text editors" <bug-gnu-emacs@HIDDEN> writes: >> >> > >> >> >> Eric Abrahamsen wrote: >> >> >> >> >> >>> Stefan Kangas <stefankangas@HIDDEN> writes: >> >> >>> >> >> >>>> James Thomas via "Bug reports for GNU Emacs, the Swiss army >> >> >>>> knife of >> >> >>>> text editors" <bug-gnu-emacs@HIDDEN> writes: >> >> >>>> >> >> >>>>> Reproduction steps for bug: >> >> >>>>> >> >> >>>>> - emacs -Q >> >> >>>>> - (setq gnus-secondary-select-methods >> >> >>>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >> >> >>>>> (setq gnus-select-method '(nnnil "")) >> >> >>>>> - M-x gnus >> >> >>>>> - Open a message in the new group and press * >> >> >>>>> - Add the cache virtual server (info "(gnus) Creating a Virtual= Server") >> >> >>>>> - ^ (server buffer) and: g on the cache >> >> >>>>> - RET to open (fails) >> >> >>>>> >> >> >>>>> This is a possible fix that I've tested only on my (limited) se= tup, for >> >> >>>>> now: >> >> >>>> >> >> >>>> Eric, what do you think of the below patch? >> >> >>> >> >> >>> Thanks for the bump... >> >> >>> >> >> >>> James, wasn't this what bug#69517 was supposed to be fixing? >> >> >> >> >> >> You're right, but that was specifically the 'cache'. In >> >> >> regenerate, all >> >> >> it sees is that the backend is nnml and there's nothing else >> >> >> special >> >> >> about the server. >> >> > >> >> > Okay, thanks. >> >> > >> >> >>> I'm still feeling like we're patching pinhole leaks in a >> >> >>> fundamentally >> >> >>> broken system. >> >> >> >> >> >> Sorry if my patch made you think so, but I don't feel that way >> >> >> =F0=9F=99=82. This >> >> >> feature is just tangential and things like slashes in group names >> >> >> are >> >> >> bound to complicate things. >> >> > >> >> > I wasn't complaining about your code :) Just generally grumbling >> >> > that >> >> > this is so complex. >> >> > >> >> >> But let me see if I can whip up an alternative patch that does >> >> >> things in >> >> >> a simpler way (I did say: 'possible' patch). One thing to decide >> >> >> is >> >> >> whether '%'s are uncommon enough in group names to warrant >> >> >> special >> >> >> treatment in a backend as fundamental as nnml. >> >> >> >> I've gone ahead and assumed the above; so now the patch is way >> >> simpler. >> >> (Btw I meant to say 'nnmail' above, not 'nnml'). It shouldn't be a >> >> problem: think I remember only Gmail using a % at some point - and a >> >> simple renaming fixes that - perhaps there should be a NEWS entry. >> >> >> >> >> >> Note that for this to work with nnatom in the current upstream >> >> you'll >> >> also need (ahem!) my patch in bug#65467: bug#71888 must be >> >> responsible. >> >> >> >> > Without diving into this right now, it seems like this is >> >> > something that >> >> > should be governed by the nnmail abstract backend, from which nnml >> >> > and >> >> > friends inherit. I would dearly, dearly love it if all backends >> >> > that >> >> > might potentially create an on-disk directory from a group name >> >> > would >> >> > use the same code (applying the same user options) to do it, >> >> > essentially >> >> > transparently. It makes me nervous when various functions in >> >> > various >> >> > places repeat similar-but-not-quite-identical routines in encoding >> >> > and >> >> > decoding group names. I suppose that URL encoding/decoding >> >> > functions >> >> > might end up being an okay tool, but I wonder if Elisp doesn't >> >> > already >> >> > have some prior art here. I'll do a bit of reading. >> >> >> >> That's worthwhile of course, but here, for the time being, I've >> >> decided >> >> I'm only grappling with the new allowance of '/'s in group names. >> >> :-) >> >> >> >> (A further improvement involves replacing the '/'s in the code with >> >> '-directory-separator-character', but that's for another report) >> >> >> >> Regards, >> >> James >>
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 7 Sep 2024 07:24:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 03:24:04 2024 Received: from localhost ([127.0.0.1]:54660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1smpng-0000dn-0j for submit <at> debbugs.gnu.org; Sat, 07 Sep 2024 03:24:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1smpnd-0000dG-OQ for 70994 <at> debbugs.gnu.org; Sat, 07 Sep 2024 03:24:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1smpnX-0005pu-9I; Sat, 07 Sep 2024 03:23:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hB4tvvgoOOv5eD9BEk1HveI4LApfaGPlBVunS6OvGJU=; b=NG+NRfCeRF9Jyn0VhJak uu5eirt71apbrBBskFHB0tgGt6cNCe4xs2YIBjyBZp0dlPRY6LvbjxN5AgG4zs0y+yyE/YRBVjSHr QUJem97GnUkT3hugTmw0/TLktnbJFfSoG2A33l2K8ZKbcRt0eWJBEoeU7XsF4BGelmq6M3y31iALJ /czq495Kf1b5kcVGlWcg4WujwoO4lIabv7dJuSZZMOlzJ0Ojb5t8hH4ddYDPfPw/ZD6D1ohbxx9UA i25Rc+aukWyOxXhEzEyDr/0ObmoEGJGguA+imLXvGiQK2Xh5yRLGR4y0F4xIqGWZ5nEi7wyC5PJU5 OBAuYPezVufAjA==; Date: Sat, 07 Sep 2024 10:23:53 +0300 Message-Id: <86le04yliu.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: eric@HIDDEN, James Thomas <jimjoe@HIDDEN> In-Reply-To: <86le0mb7eb.fsf@HIDDEN> (message from James Thomas on Sat, 24 Aug 2024 14:54:28 +0530) Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> <87le428xvg.fsf@HIDDEN> <86y182bg9t.fsf@HIDDEN> <87zfsg6lut.fsf@HIDDEN> <865xsbu83j.fsf@HIDDEN> <86plpynx9a.fsf@HIDDEN> <86le0mb7eb.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70994 Cc: 70994 <at> debbugs.gnu.org, stefankangas@HIDDEN, daniel@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Eric, any further comments, or should we install the patch? > From: James Thomas <jimjoe@HIDDEN> > Cc: eric@HIDDEN, 70994 <at> debbugs.gnu.org, > stefankangas@HIDDEN, daniel@HIDDEN > Date: Sat, 24 Aug 2024 14:54:28 +0530 > > Eli Zaretskii wrote: > > > Ping! Can we make some progress here? > > I'd like to confess again that this doesn't seem to be a big deal: > 'gnus-cache-generate-nov-databases' and 'gnus-cache-generate-active' > should work regardless. It's only for someone who might accidentally do > this. > > Regards, > James > > > >> Cc: 70994 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>, > >> Daniel Semyonov <daniel@HIDDEN> > >> Date: Thu, 08 Aug 2024 06:46:48 +0530 > >> From: James Thomas via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > >> > >> Eric Abrahamsen wrote: > >> > >> > James Thomas via "Bug reports for GNU Emacs, the Swiss army knife > >> > of > >> > text editors" <bug-gnu-emacs@HIDDEN> writes: > >> > > >> >> Eric Abrahamsen wrote: > >> >> > >> >>> Stefan Kangas <stefankangas@HIDDEN> writes: > >> >>> > >> >>>> James Thomas via "Bug reports for GNU Emacs, the Swiss army > >> >>>> knife of > >> >>>> text editors" <bug-gnu-emacs@HIDDEN> writes: > >> >>>> > >> >>>>> Reproduction steps for bug: > >> >>>>> > >> >>>>> - emacs -Q > >> >>>>> - (setq gnus-secondary-select-methods > >> >>>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) > >> >>>>> (setq gnus-select-method '(nnnil "")) > >> >>>>> - M-x gnus > >> >>>>> - Open a message in the new group and press * > >> >>>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Server") > >> >>>>> - ^ (server buffer) and: g on the cache > >> >>>>> - RET to open (fails) > >> >>>>> > >> >>>>> This is a possible fix that I've tested only on my (limited) setup, for > >> >>>>> now: > >> >>>> > >> >>>> Eric, what do you think of the below patch? > >> >>> > >> >>> Thanks for the bump... > >> >>> > >> >>> James, wasn't this what bug#69517 was supposed to be fixing? > >> >> > >> >> You're right, but that was specifically the 'cache'. In > >> >> regenerate, all > >> >> it sees is that the backend is nnml and there's nothing else > >> >> special > >> >> about the server. > >> > > >> > Okay, thanks. > >> > > >> >>> I'm still feeling like we're patching pinhole leaks in a > >> >>> fundamentally > >> >>> broken system. > >> >> > >> >> Sorry if my patch made you think so, but I don't feel that way > >> >> 🙂. This > >> >> feature is just tangential and things like slashes in group names > >> >> are > >> >> bound to complicate things. > >> > > >> > I wasn't complaining about your code :) Just generally grumbling > >> > that > >> > this is so complex. > >> > > >> >> But let me see if I can whip up an alternative patch that does > >> >> things in > >> >> a simpler way (I did say: 'possible' patch). One thing to decide > >> >> is > >> >> whether '%'s are uncommon enough in group names to warrant > >> >> special > >> >> treatment in a backend as fundamental as nnml. > >> > >> I've gone ahead and assumed the above; so now the patch is way > >> simpler. > >> (Btw I meant to say 'nnmail' above, not 'nnml'). It shouldn't be a > >> problem: think I remember only Gmail using a % at some point - and a > >> simple renaming fixes that - perhaps there should be a NEWS entry. > >> > >> > >> Note that for this to work with nnatom in the current upstream > >> you'll > >> also need (ahem!) my patch in bug#65467: bug#71888 must be > >> responsible. > >> > >> > Without diving into this right now, it seems like this is > >> > something that > >> > should be governed by the nnmail abstract backend, from which nnml > >> > and > >> > friends inherit. I would dearly, dearly love it if all backends > >> > that > >> > might potentially create an on-disk directory from a group name > >> > would > >> > use the same code (applying the same user options) to do it, > >> > essentially > >> > transparently. It makes me nervous when various functions in > >> > various > >> > places repeat similar-but-not-quite-identical routines in encoding > >> > and > >> > decoding group names. I suppose that URL encoding/decoding > >> > functions > >> > might end up being an okay tool, but I wonder if Elisp doesn't > >> > already > >> > have some prior art here. I'll do a bit of reading. > >> > >> That's worthwhile of course, but here, for the time being, I've > >> decided > >> I'm only grappling with the new allowance of '/'s in group names. > >> :-) > >> > >> (A further improvement involves replacing the '/'s in the code with > >> '-directory-separator-character', but that's for another report) > >> > >> Regards, > >> James >
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 24 Aug 2024 09:25:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 24 05:25:47 2024 Received: from localhost ([127.0.0.1]:40491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1shn1n-00006m-3t for submit <at> debbugs.gnu.org; Sat, 24 Aug 2024 05:25:47 -0400 Received: from mout.gmx.net ([212.227.15.19]:47833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jimjoe@HIDDEN>) id 1shn1k-00006S-Jy for 70994 <at> debbugs.gnu.org; Sat, 24 Aug 2024 05:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1724491476; x=1725096276; i=jimjoe@HIDDEN; bh=NFtdv7XJqLPbE/4j9N2Bz2XTk1CgHqmuqCFTYX6N4Ok=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=OTJacI5nydtkToBpAf9DZtwYwIpSTDC6aacZmi6yL+53iGzP5tPbGIZsxj0aLHjI x9NG7R2HwtFZtlje36IvZzvUyDNd43ItKLs1Mx8EsfLZNA4A6yau5aDrQnEiTA7Nk DFoMThfJY3Bsf8C9WiNT7zODxFEcop6RF+ct8kAllGLD0FtaY3//f2MtZSdzGvOfT PyFliQI6fnlyKLr27QpoGNuSv1KYGrk8eO9tpvjDtZDQmL+MUH0XnoE9nx5IeqqOE nWVXF109wBu5pNI2xfW9/z/gRehNV8QM9V8HipOQTgZsyHsfw6SG4BxNGNv6QUVzz LIjxiO1o2zt4x61BeQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([120.61.28.248]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MOREi-1sU80T1VrK-00JP0W; Sat, 24 Aug 2024 11:24:36 +0200 From: James Thomas <jimjoe@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / In-Reply-To: <86plpynx9a.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 24 Aug 2024 11:25:05 +0300") References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> <87le428xvg.fsf@HIDDEN> <86y182bg9t.fsf@HIDDEN> <87zfsg6lut.fsf@HIDDEN> <865xsbu83j.fsf@HIDDEN> <86plpynx9a.fsf@HIDDEN> Date: Sat, 24 Aug 2024 14:54:28 +0530 Message-ID: <86le0mb7eb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:CFwEbXV416xnCkKS+JqaC8Z7MSDJ04Uohm5fMh07Lxp5/CCqutD UkLjaJzLZJF4LZl12B8wJuneoEvYbke6azVQ2mzUVwecQEGHqUja5AYpW5pfyt+kpT+Ln8v pJ8omrOzsztWb119/xB8eR54yl9cb3WwhkvNClIzYnjZLt0aOWdfxldouBxdJjM/VF2vClh bMiqtj67vGACn+u432lAQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:H6D5eSiXHOo=;BDAxRhGKdih7wBB21uJQHVRcdaE 2VqVoMITiASSzDY9w36U8X4J17tIWRrp9IdrmUjMg9hKv+h5RCDC5ilMHzJm7cr4myAlN1RB9 Ni2VVWKfkj8LiVs9k3Rq3GkzQ7ujAPQ/4H1YnTtu/Jpvi1Dj5GpXKyWbN1jql0zxPt8/24bkU KSmOZKkxfIpLmZ/qFUShesT6GJxMID14dePMMvuwVCgW2oJOI/BVPM/fBLSfmZ4dKP8Y8webu S9dh2kvHyfiTgsp8xmF6TqAeR4r+3qcwGe5FStlWTTMSWA4ajUPTzLdJwoBW/6JwAofmTLM72 RkoUEbaFM6eyeRRJiikXkqlKjGiEttcQZ6TBps2Nm13vs6Qf0lGu6xH4GrIeccGJzAOxZJfeQ GM3ECuHta14RqmXUFy5sNvBvFN5xnm7LbHmMHzPgHyeI9S7rH2VgEzIueRiiR5Rii8L+JbhUc +4DgFEEjwR52zjv++dJuxjVaLPEdP9jILN2Hvqiy3vJSf31H0pFTVqKosxI10bDteV6ndVDdL s5NlHDvNJOwZZJ6u2cjax6BowtXn3q1EdKOGPEsh/nGlzRkYgK6jTWphJtIgSCPudXhi8j2yQ b2S6SNFTLYzLwxyrYn5XT3KzwcGWWWSplQ4bDCnptYnnxbEksy/AgvupczswnPtRQ9pbmFY56 +AshBNqFG0uujgle+S31xr2CeQ3Gy9tCyI6S6AqlBJZrnQ+14xa/xDd6mHloCwKyzWXLYD0oU 3XZO4MZewVfOrdC5G/iLq2OhOETc+0xrxumPz4iwcLSpRejWo/Jzlk5skKeqwyTv3+jP5rJR1 p41LhGiIKhmrPdFLRDU5+EIA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70994 Cc: eric@HIDDEN, 70994 <at> debbugs.gnu.org, stefankangas@HIDDEN, daniel@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii wrote: > Ping! Can we make some progress here? I'd like to confess again that this doesn't seem to be a big deal: 'gnus-cache-generate-nov-databases' and 'gnus-cache-generate-active' should work regardless. It's only for someone who might accidentally do this. Regards, James > >> Cc: 70994 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>, >> Daniel Semyonov <daniel@HIDDEN> >> Date: Thu, 08 Aug 2024 06:46:48 +0530 >> From: James Thomas via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >>=20 >> Eric Abrahamsen wrote: >>=20 >> > James Thomas via "Bug reports for GNU Emacs, the Swiss army knife >> > of >> > text editors" <bug-gnu-emacs@HIDDEN> writes: >> > >> >> Eric Abrahamsen wrote: >> >> >> >>> Stefan Kangas <stefankangas@HIDDEN> writes: >> >>> >> >>>> James Thomas via "Bug reports for GNU Emacs, the Swiss army >> >>>> knife of >> >>>> text editors" <bug-gnu-emacs@HIDDEN> writes: >> >>>> >> >>>>> Reproduction steps for bug: >> >>>>> >> >>>>> - emacs -Q >> >>>>> - (setq gnus-secondary-select-methods >> >>>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >> >>>>> (setq gnus-select-method '(nnnil "")) >> >>>>> - M-x gnus >> >>>>> - Open a message in the new group and press * >> >>>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Se= rver") >> >>>>> - ^ (server buffer) and: g on the cache >> >>>>> - RET to open (fails) >> >>>>> >> >>>>> This is a possible fix that I've tested only on my (limited) setup= , for >> >>>>> now: >> >>>> >> >>>> Eric, what do you think of the below patch? >> >>> >> >>> Thanks for the bump... >> >>> >> >>> James, wasn't this what bug#69517 was supposed to be fixing? >> >> >> >> You're right, but that was specifically the 'cache'. In >> >> regenerate, all >> >> it sees is that the backend is nnml and there's nothing else >> >> special >> >> about the server. >> > >> > Okay, thanks. >> > >> >>> I'm still feeling like we're patching pinhole leaks in a >> >>> fundamentally >> >>> broken system. >> >> >> >> Sorry if my patch made you think so, but I don't feel that way >> >> =F0=9F=99=82. This >> >> feature is just tangential and things like slashes in group names >> >> are >> >> bound to complicate things. >> > >> > I wasn't complaining about your code :) Just generally grumbling >> > that >> > this is so complex. >> > >> >> But let me see if I can whip up an alternative patch that does >> >> things in >> >> a simpler way (I did say: 'possible' patch). One thing to decide >> >> is >> >> whether '%'s are uncommon enough in group names to warrant >> >> special >> >> treatment in a backend as fundamental as nnml. >>=20 >> I've gone ahead and assumed the above; so now the patch is way >> simpler. >> (Btw I meant to say 'nnmail' above, not 'nnml'). It shouldn't be a >> problem: think I remember only Gmail using a % at some point - and a >> simple renaming fixes that - perhaps there should be a NEWS entry. >>=20 >>=20 >> Note that for this to work with nnatom in the current upstream >> you'll >> also need (ahem!) my patch in bug#65467: bug#71888 must be >> responsible. >>=20 >> > Without diving into this right now, it seems like this is >> > something that >> > should be governed by the nnmail abstract backend, from which nnml >> > and >> > friends inherit. I would dearly, dearly love it if all backends >> > that >> > might potentially create an on-disk directory from a group name >> > would >> > use the same code (applying the same user options) to do it, >> > essentially >> > transparently. It makes me nervous when various functions in >> > various >> > places repeat similar-but-not-quite-identical routines in encoding >> > and >> > decoding group names. I suppose that URL encoding/decoding >> > functions >> > might end up being an okay tool, but I wonder if Elisp doesn't >> > already >> > have some prior art here. I'll do a bit of reading. >>=20 >> That's worthwhile of course, but here, for the time being, I've >> decided >> I'm only grappling with the new allowance of '/'s in group names. >> :-) >>=20 >> (A further improvement involves replacing the '/'s in the code with >> '-directory-separator-character', but that's for another report) >>=20 >> Regards, >> James
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 24 Aug 2024 08:26:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 24 04:26:06 2024 Received: from localhost ([127.0.0.1]:40396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1shm61-0006qK-H6 for submit <at> debbugs.gnu.org; Sat, 24 Aug 2024 04:26:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1shm5z-0006pr-Je for 70994 <at> debbugs.gnu.org; Sat, 24 Aug 2024 04:26:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1shm56-0005pu-Qk; Sat, 24 Aug 2024 04:25:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tRSjOriUT+ZwABQ3KZdsNhowTjJJlhzYM20E+11hFss=; b=Ec7zXEhxjHkfrg2xo926 p7JnkWbKHeHCSrzp66Ckyl7x/H+emr8SU0Fd4CznGj252x6ciAWVLSCw8D44lfgc+4BxobJFVRUmU C0NgD9tiYF+KdvTulkB3uwae9kxK/yNvdK/OuGu+I2/kJUySaZRg7NkUha2Eo8Bbk/3i8nPY0CX8l 89b0by9awrNalTzPDtsMfk4aNpnoIbfjY6UPoiZzfCnKGORWLfOWppEjti5PCITsD/OKRINovVxUa iiEYhOqLkbWlkEz6aecRT90IZFxHa9HDV3mwkM0pEPAWBnZo1TBAfRP62Yye3PNaZ470bDk8GGmFX L6Z6vi5wtgqKmw==; Date: Sat, 24 Aug 2024 11:25:05 +0300 Message-Id: <86plpynx9a.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: eric@HIDDEN, James Thomas <jimjoe@HIDDEN> In-Reply-To: <865xsbu83j.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> <87le428xvg.fsf@HIDDEN> <86y182bg9t.fsf@HIDDEN> <87zfsg6lut.fsf@HIDDEN> <865xsbu83j.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70994 Cc: 70994 <at> debbugs.gnu.org, stefankangas@HIDDEN, daniel@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Can we make some progress here? > Cc: 70994 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>, > Daniel Semyonov <daniel@HIDDEN> > Date: Thu, 08 Aug 2024 06:46:48 +0530 > From: James Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Eric Abrahamsen wrote: > > > James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of > > text editors" <bug-gnu-emacs@HIDDEN> writes: > > > >> Eric Abrahamsen wrote: > >> > >>> Stefan Kangas <stefankangas@HIDDEN> writes: > >>> > >>>> James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of > >>>> text editors" <bug-gnu-emacs@HIDDEN> writes: > >>>> > >>>>> Reproduction steps for bug: > >>>>> > >>>>> - emacs -Q > >>>>> - (setq gnus-secondary-select-methods > >>>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) > >>>>> (setq gnus-select-method '(nnnil "")) > >>>>> - M-x gnus > >>>>> - Open a message in the new group and press * > >>>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Server") > >>>>> - ^ (server buffer) and: g on the cache > >>>>> - RET to open (fails) > >>>>> > >>>>> This is a possible fix that I've tested only on my (limited) setup, for > >>>>> now: > >>>> > >>>> Eric, what do you think of the below patch? > >>> > >>> Thanks for the bump... > >>> > >>> James, wasn't this what bug#69517 was supposed to be fixing? > >> > >> You're right, but that was specifically the 'cache'. In regenerate, all > >> it sees is that the backend is nnml and there's nothing else special > >> about the server. > > > > Okay, thanks. > > > >>> I'm still feeling like we're patching pinhole leaks in a fundamentally > >>> broken system. > >> > >> Sorry if my patch made you think so, but I don't feel that way 🙂. This > >> feature is just tangential and things like slashes in group names are > >> bound to complicate things. > > > > I wasn't complaining about your code :) Just generally grumbling that > > this is so complex. > > > >> But let me see if I can whip up an alternative patch that does things in > >> a simpler way (I did say: 'possible' patch). One thing to decide is > >> whether '%'s are uncommon enough in group names to warrant special > >> treatment in a backend as fundamental as nnml. > > I've gone ahead and assumed the above; so now the patch is way simpler. > (Btw I meant to say 'nnmail' above, not 'nnml'). It shouldn't be a > problem: think I remember only Gmail using a % at some point - and a > simple renaming fixes that - perhaps there should be a NEWS entry. > > > Note that for this to work with nnatom in the current upstream you'll > also need (ahem!) my patch in bug#65467: bug#71888 must be responsible. > > > Without diving into this right now, it seems like this is something that > > should be governed by the nnmail abstract backend, from which nnml and > > friends inherit. I would dearly, dearly love it if all backends that > > might potentially create an on-disk directory from a group name would > > use the same code (applying the same user options) to do it, essentially > > transparently. It makes me nervous when various functions in various > > places repeat similar-but-not-quite-identical routines in encoding and > > decoding group names. I suppose that URL encoding/decoding functions > > might end up being an okay tool, but I wonder if Elisp doesn't already > > have some prior art here. I'll do a bit of reading. > > That's worthwhile of course, but here, for the time being, I've decided > I'm only grappling with the new allowance of '/'s in group names. :-) > > (A further improvement involves replacing the '/'s in the code with > '-directory-separator-character', but that's for another report) > > Regards, > James
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 8 Aug 2024 01:17:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 21:17:40 2024 Received: from localhost ([127.0.0.1]:35240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbrme-0000IA-0j for submit <at> debbugs.gnu.org; Wed, 07 Aug 2024 21:17:40 -0400 Received: from mout.gmx.net ([212.227.15.19]:59329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jimjoe@HIDDEN>) id 1sbrmb-0000Hx-68 for 70994 <at> debbugs.gnu.org; Wed, 07 Aug 2024 21:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1723079813; x=1723684613; i=jimjoe@HIDDEN; bh=PbcnmUh0ozdxaLE+jzQU40PiXD+cETQtxHwuluD8J+E=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=JLaLHlaqX9cLYXmxx5zvPhsbRWpDToWwD8aLsxLDgCylQ+blfGqlNgF133p9kxUS FCpCdNgs1tFhNYmVd0ME82pbo16X4XslqhM4wrjB6Gu924ky1mhdYPQ05CZJ0IKfB r+l1xL9H/tggarQddvQlynXomIeWEaSeY1snZaUd+bMFfA27HmAzGsG9O8r/6OMr5 QebKEyfCFT0+2KtsU+eTvyZjDqvj6wsDijAr6w456Xdp1WidxMxCrVUjzcOuK94In N/w4egMgVykz0XxSdkh9FzoMd6qfePL4ofEZ1kDr4L/0N3fkap8bqqrvs9Hhu1HWH 5M0aNT8dGT3ameWdTQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([117.212.174.36]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1N1OXZ-1sEjC33eMF-012jQj; Thu, 08 Aug 2024 03:16:53 +0200 From: James Thomas <jimjoe@HIDDEN> To: Eric Abrahamsen <eric@HIDDEN> Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / In-Reply-To: <87zfsg6lut.fsf@HIDDEN> (Eric Abrahamsen's message of "Thu, 23 May 2024 18:26:50 -0700") References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> <87le428xvg.fsf@HIDDEN> <86y182bg9t.fsf@HIDDEN> <87zfsg6lut.fsf@HIDDEN> Date: Thu, 08 Aug 2024 06:46:48 +0530 Message-ID: <865xsbu83j.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:hmoASjlSUoG1cTzfYLrybzhrB7EDuSmD7KF8xPZNI9y2/FAEgwb 9HULXr5HjECNrv25UTuvWouKX68pFIYwFDm8esE2/xyzCDRtzUwdHebN3uPusy0lXscm8ik LdYYWt7NVG1WD6LnZaTcIMGMLxsV5KlAlo3MBNmQzqUMdYlRpnauu9AgisJus+8yT4f9qCG XCZaXs8HYUjjQDsSHUc2A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:GNK7KipGGYE=;eVqzvVmSObV1iBrsl3Ll5gVI5li OJOsj2AOz8iFN1CsgtmxM0uGc35rOjuiNhyNPxkqT4GHySMk7TK5ZaKT0VzNSGoURPyGTRtPX n/fYNUFJWkGCewt/INYZHvOMEC3QpRxT7xe64iyXFm/ulyETbuQMe8nH6Tv0W6/55yaQlwuIT DdjUXDeS6151ydhEYRv1V3/SCpczpGzTlMIf7CNKsNMLdcFn5WxdA/TXaSR1KnGzkp2I5HNm8 NtVWni4U/Zr7lMC8fmz/Fhls2Fue7b6cR84hMoTsTZMwhZXwxYe7yNq7KZn91AW6pGu2QsrDW PJxlmgNPWDINZnLpa6SQd5QyEdhQ/BvtvkGCsi0N7UzjrB9ec4lMa+Tyzjnb1GxVz4NIT1pm7 bzKnC1hTom1ktE7ZJyV/9IkrhwbinJ7w9iw5htPPeJug2PyfEgqRL4IYJwG+zY1qWulvkkKmW IfqHrtdg6Tw2t1wZ21utyS/9VdjkbTthpbaVPVXJHHzn+6N0Rcp/9dodVcUWMfMxAcCYatkJa VKbvE0XORIr4jdKYgANfgH62+qx+H4SnhFDl9Ff1XQXEDDwa5BnDh2sdIMh6s5/gdQCUiLZaW MxUH2wC64zH1qBVxuGNLE5ZusfciOuIF31bSlMIl8M3h1yVpCV3CVnGBY+4sjdvGt5a/vJiO2 uXnwl3Zv+8qxXekcNVJIbMVtsKEDEH4c51RzOt6Vrd7wqc6gLDSRO05qXa7vFGRLDinyoBE6D 6htWo9bT7NNs4qs8KoAoAOeZWAWqkr32r6Gvpzv5m/3pR0qqx6PiCJwBvo6MnMWfvGHhmrB3n Rp42fgEVpM4hX6URg8wiRMTaXqDH079qqfVCTz4Rd6fUM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70994 Cc: 70994 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>, Daniel Semyonov <daniel@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eric Abrahamsen wrote: > James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" <bug-gnu-emacs@HIDDEN> writes: > >> Eric Abrahamsen wrote: >> >>> Stefan Kangas <stefankangas@HIDDEN> writes: >>> >>>> James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of >>>> text editors" <bug-gnu-emacs@HIDDEN> writes: >>>> >>>>> Reproduction steps for bug: >>>>> >>>>> - emacs -Q >>>>> - (setq gnus-secondary-select-methods >>>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >>>>> (setq gnus-select-method '(nnnil "")) >>>>> - M-x gnus >>>>> - Open a message in the new group and press * >>>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Serve= r") >>>>> - ^ (server buffer) and: g on the cache >>>>> - RET to open (fails) >>>>> >>>>> This is a possible fix that I've tested only on my (limited) setup, f= or >>>>> now: >>>> >>>> Eric, what do you think of the below patch? >>> >>> Thanks for the bump... >>> >>> James, wasn't this what bug#69517 was supposed to be fixing? >> >> You're right, but that was specifically the 'cache'. In regenerate, all >> it sees is that the backend is nnml and there's nothing else special >> about the server. > > Okay, thanks. > >>> I'm still feeling like we're patching pinhole leaks in a fundamentally >>> broken system. >> >> Sorry if my patch made you think so, but I don't feel that way =F0=9F=99= =82. This >> feature is just tangential and things like slashes in group names are >> bound to complicate things. > > I wasn't complaining about your code :) Just generally grumbling that > this is so complex. > >> But let me see if I can whip up an alternative patch that does things in >> a simpler way (I did say: 'possible' patch). One thing to decide is >> whether '%'s are uncommon enough in group names to warrant special >> treatment in a backend as fundamental as nnml. I've gone ahead and assumed the above; so now the patch is way simpler. (Btw I meant to say 'nnmail' above, not 'nnml'). It shouldn't be a problem: think I remember only Gmail using a % at some point - and a simple renaming fixes that - perhaps there should be a NEWS entry. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Bugfix.patch Content-Description: [PATCH] Bugfix Content-Transfer-Encoding: quoted-printable =46rom dfe4498e361262eb1eb25e288bc7228678ac1a43 Mon Sep 17 00:00:00 2001 From: James Thomas <jimjoe@HIDDEN> Date: Thu, 8 Aug 2024 06:40:15 +0530 Subject: [PATCH] Bugfix * lisp/gnus/nnheader.el (nnheader-file-to-group): Reverse the hexing in bug#69517. =2D-- lisp/gnus/nnheader.el | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lisp/gnus/nnheader.el b/lisp/gnus/nnheader.el index ea679759f3e..db83eebe3cd 100644 =2D-- a/lisp/gnus/nnheader.el +++ b/lisp/gnus/nnheader.el @@ -827,16 +827,17 @@ nnheader-replace-duplicate-chars-in-string (defun nnheader-file-to-group (file &optional top) "Return a group name based on FILE and TOP." - (nnheader-replace-chars-in-string - (if (not top) - file - (condition-case () - (substring (expand-file-name file) - (length - (expand-file-name - (file-name-as-directory top)))) - (error ""))) - nnheader-directory-separator-character ?.)) + (url-unhex-string + (nnheader-replace-chars-in-string + (if (not top) + file + (condition-case () + (substring (expand-file-name file) + (length + (expand-file-name + (file-name-as-directory top)))) + (error ""))) + nnheader-directory-separator-character ?.))) (defun nnheader-message (level &rest args) "Message if the Gnus backends are talkative." =2D- 2.43.0 --=-=-= Content-Type: text/plain Note that for this to work with nnatom in the current upstream you'll also need (ahem!) my patch in bug#65467: bug#71888 must be responsible. > Without diving into this right now, it seems like this is something that > should be governed by the nnmail abstract backend, from which nnml and > friends inherit. I would dearly, dearly love it if all backends that > might potentially create an on-disk directory from a group name would > use the same code (applying the same user options) to do it, essentially > transparently. It makes me nervous when various functions in various > places repeat similar-but-not-quite-identical routines in encoding and > decoding group names. I suppose that URL encoding/decoding functions > might end up being an okay tool, but I wonder if Elisp doesn't already > have some prior art here. I'll do a bit of reading. That's worthwhile of course, but here, for the time being, I've decided I'm only grappling with the new allowance of '/'s in group names. :-) (A further improvement involves replacing the '/'s in the code with '-directory-separator-character', but that's for another report) Regards, James --=-=-=--
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 24 May 2024 01:27:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 23 21:27:11 2024 Received: from localhost ([127.0.0.1]:33977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sAJiA-0001dS-Mv for submit <at> debbugs.gnu.org; Thu, 23 May 2024 21:27:11 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:37260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eric@HIDDEN>) id 1sAJi5-0001d4-EU for 70994 <at> debbugs.gnu.org; Thu, 23 May 2024 21:27:09 -0400 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@HIDDEN) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 44556FA39F; Fri, 24 May 2024 01:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1716514012; bh=hl9WT8GD2XtHe7qjuCIZi5kktun9bbulgDU+uuF8ijo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ts/mCG8VxY/BTfBUA5AJbmbISjdxf+1OHvGt4SpGLV/eQy4d6OCLIO9hf8PxtpStr VIPcfPWxgw7I4ckQhVz2ADH06xUSefVJjyCZaZaNtv6IJ8QCbFZAipgqAuNqbn9luD T96tq7w9W9emR9yDP0rbi3ATJ03b+TZClx6eHsUI= From: Eric Abrahamsen <eric@HIDDEN> To: 70994 <at> debbugs.gnu.org Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / In-Reply-To: <86y182bg9t.fsf@HIDDEN> (James Thomas via's message of "Wed, 22 May 2024 10:21:42 +0530") References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> <87le428xvg.fsf@HIDDEN> <86y182bg9t.fsf@HIDDEN> Date: Thu, 23 May 2024 18:26:50 -0700 Message-ID: <87zfsg6lut.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70994 Cc: Stefan Kangas <stefankangas@HIDDEN>, James Thomas <jimjoe@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > Eric Abrahamsen wrote: > >> Stefan Kangas <stefankangas@HIDDEN> writes: >> >>> James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of >>> text editors" <bug-gnu-emacs@HIDDEN> writes: >>> >>>> Reproduction steps for bug: >>>> >>>> - emacs -Q >>>> - (setq gnus-secondary-select-methods >>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >>>> (setq gnus-select-method '(nnnil "")) >>>> - M-x gnus >>>> - Open a message in the new group and press * >>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Server= ") >>>> - ^ (server buffer) and: g on the cache >>>> - RET to open (fails) >>>> >>>> This is a possible fix that I've tested only on my (limited) setup, for >>>> now: >>> >>> Eric, what do you think of the below patch? >> >> Thanks for the bump... >> >> James, wasn't this what bug#69517 was supposed to be fixing? > > You're right, but that was specifically the 'cache'. In regenerate, all > it sees is that the backend is nnml and there's nothing else special > about the server. Okay, thanks. >> I'm still feeling like we're patching pinhole leaks in a fundamentally >> broken system. > > Sorry if my patch made you think so, but I don't feel that way =F0=9F=99= =82. This > feature is just tangential and things like slashes in group names are > bound to complicate things. I wasn't complaining about your code :) Just generally grumbling that this is so complex. > But let me see if I can whip up an alternative patch that does things in > a simpler way (I did say: 'possible' patch). One thing to decide is > whether '%'s are uncommon enough in group names to warrant special > treatment in a backend as fundamental as nnml. Without diving into this right now, it seems like this is something that should be governed by the nnmail abstract backend, from which nnml and friends inherit. I would dearly, dearly love it if all backends that might potentially create an on-disk directory from a group name would use the same code (applying the same user options) to do it, essentially transparently. It makes me nervous when various functions in various places repeat similar-but-not-quite-identical routines in encoding and decoding group names. I suppose that URL encoding/decoding functions might end up being an okay tool, but I wonder if Elisp doesn't already have some prior art here. I'll do a bit of reading. Thank you for persisting with this stuff! Eric
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 22 May 2024 04:52:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 22 00:52:10 2024 Received: from localhost ([127.0.0.1]:53289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s9dxS-0005UX-6J for submit <at> debbugs.gnu.org; Wed, 22 May 2024 00:52:10 -0400 Received: from mout.gmx.net ([212.227.17.22]:52443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jimjoe@HIDDEN>) id 1s9dxP-0005U9-5l for 70994 <at> debbugs.gnu.org; Wed, 22 May 2024 00:52:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1716353506; x=1716958306; i=jimjoe@HIDDEN; bh=EjzL1604Hh8I/ACO3PNPu2OzPMwjQdDpa0sbIdsH9IA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=XR6oTlFbbM7LIAAeLzhRupqbRD7UL4IG/+lWtZGnAZ5Mul/QWE6Vu0qu3aq+9Pls 8uV9b7oc35HVWAEW2zrimMlnUz9aJjpyb9Xhf0sxqoFULuMU0FYOnL2F/XqsOxcui mvM8GSrhheD2qafzncZu6fsRER9grtEPjlNALEaPoaTz/7t5kCvCJUZyYFfW2TT/q DgytHhCHblvFGmJwKEftnVPZP2qa9kd00pzouuKTENekcFRR7d76XO9G1PMalhZSj +aRBqxJB0Rfui53RxBIAp2RIGMGftF58OU9u4ILFkQ6WeSXBaRZC1NnceMx1PdoLU Cs3z8B36pVXz5wL6Cw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([117.206.142.14]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N8ofO-1sdukB2Tu2-015tVu; Wed, 22 May 2024 06:51:46 +0200 From: James Thomas <jimjoe@HIDDEN> To: 70994 <at> debbugs.gnu.org Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / In-Reply-To: <87le428xvg.fsf@HIDDEN> (Eric Abrahamsen's message of "Tue, 21 May 2024 17:59:47 -0700") References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> <87le428xvg.fsf@HIDDEN> Date: Wed, 22 May 2024 10:21:42 +0530 Message-ID: <86y182bg9t.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:KLYKJx1CTEbb0XgJWk2XAE6Q+Au65CLwwxNsu9fzpyoIzXbOWju RxK/PMBK+n4nJQj1Si4neBSJuCSFysXqoskbgkAKCupqaxjevGUjpPI/L9gVu36SbzpIHvv P+KvzpFmAie+4dr9FFEobMSQCqpYlGtEKpTNAQwBf7m7YAsueKpwQVmlz8vM2eNBhwk7Roo /ZRaCYn9Q4foiL+KBvTig== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:C/tVdam0s4s=;um1ywPN8llnLhpFj4X6rtSUGDt4 P/IN3MXObqWZSHdVByw/K5h8Cer38MNOSR2PRbLLi0cj5DPTbUuutKUU7WCUVdblwyaHl2zfr Y/fElE6XjA5xLanUnpYWiNMCrp7BjXJ6wxueoRy5D5iD/XU8SfLfX3h3KJSSV3dPROEIeMP7O tlTJXCtZ1HWmLz0RufNso5MvFsbrfOq8/5yZkV/bPP6WIj4SE8TNeS1E9dGRhTUJ3Z10rxd+T klyLCIulVTkP+0sFWm3u0DFSEH7L2BNhMsNqf5JUIwvApyAGu3aAexnt1q/MJLWB34+Dz//Yg ZrDjyABTosseA0YrXv94/bxwvbHQ7GS16ydBdNTe7sruDXMh9p2hvvJvnAvpPF/fEAKlV3xof JsmRRAXeY9SaBu9Ic+Zs1gaKS9J+rCgjlH2f7i6IASYobi25CbJfXFJRqx3Z5qDWZlvDq9tQa i/jGnJES0G5GBJXFWIAGdoUcms+0S0fvpbL5OqrmslmBCuLXLz/L2HiTZa9djDLLcibtgFl3x xSAczNFlTU4EzXTPozsMYqBj3CdGJohc3b2a5GxH178heF6oA/FMM16bl+5RGKwj3JKN819Gn WIFipH9ePwpfHoJOFBhyuliJwbBrpkDej4WeyP87EauE4Z+5CxtBWV2VqrYCowk6SHVU2n0IY qaHYSSVWIgl/57e4jjaSdrqnVwjO5MievYLUMdOKRQ2C7ucnoFV2cIczb9M9vQtULgHEmxvrO Z+1Zy3F85tWh6bbUG0iC0UvdQf8U3+4+3EFD2lT4r73Mm5bldSCVYWSzNuBvl6yOfeVr6/qpG W++YfysVAh+UtqLJWnWwu0dbcqNdlNOoOpK55UCNv78iQ= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70994 Cc: Eric Abrahamsen <eric@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eric Abrahamsen wrote: > Stefan Kangas <stefankangas@HIDDEN> writes: > >> James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" <bug-gnu-emacs@HIDDEN> writes: >> >>> Reproduction steps for bug: >>> >>> - emacs -Q >>> - (setq gnus-secondary-select-methods >>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >>> (setq gnus-select-method '(nnnil "")) >>> - M-x gnus >>> - Open a message in the new group and press * >>> - Add the cache virtual server (info "(gnus) Creating a Virtual Server") >>> - ^ (server buffer) and: g on the cache >>> - RET to open (fails) >>> >>> This is a possible fix that I've tested only on my (limited) setup, for >>> now: >> >> Eric, what do you think of the below patch? > > Thanks for the bump... > > James, wasn't this what bug#69517 was supposed to be fixing? You're right, but that was specifically the 'cache'. In regenerate, all it sees is that the backend is nnml and there's nothing else special about the server. > I'm still feeling like we're patching pinhole leaks in a fundamentally > broken system. Sorry if my patch made you think so, but I don't feel that way =F0=9F=99=82= . This feature is just tangential and things like slashes in group names are bound to complicate things. But let me see if I can whip up an alternative patch that does things in a simpler way (I did say: 'possible' patch). One thing to decide is whether '%'s are uncommon enough in group names to warrant special treatment in a backend as fundamental as nnml. Regards, James
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 22 May 2024 01:00:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 21 21:00:07 2024 Received: from localhost ([127.0.0.1]:52330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s9aKt-00039C-DL for submit <at> debbugs.gnu.org; Tue, 21 May 2024 21:00:07 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:58478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eric@HIDDEN>) id 1s9aKr-00038F-1O for 70994 <at> debbugs.gnu.org; Tue, 21 May 2024 21:00:06 -0400 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@HIDDEN) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 51AACFA12D; Wed, 22 May 2024 00:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1716339592; bh=LwwGiMBGzK+h9Lm5h4z99yw1qGxsdozWUaORrBSAS8s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kStAGYmHRyNf5Y20dzQImKFb5GnjeV6OU0ELXYhA8QlMHYUcLDPqw9jdfQIeoVJR6 qdbkOeAXXwBkOrpMOJlkfqsTiU9WzDh5FFiiIDTvg8HUztNKnsLlav443GogQ4Mptu 1abUi1uP6VSmnIYlb4CsdH9uwN7d2w+0ZezAB9sY= From: Eric Abrahamsen <eric@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / In-Reply-To: <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> (Stefan Kangas's message of "Sat, 18 May 2024 22:14:39 +0000") References: <86jzjt11ff.fsf@HIDDEN> <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 21 May 2024 17:59:47 -0700 Message-ID: <87le428xvg.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70994 Cc: 70994 <at> debbugs.gnu.org, James Thomas <jimjoe@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Stefan Kangas <stefankangas@HIDDEN> writes: > James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" <bug-gnu-emacs@HIDDEN> writes: > >> Reproduction steps for bug: >> >> - emacs -Q >> - (setq gnus-secondary-select-methods >> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >> (setq gnus-select-method '(nnnil "")) >> - M-x gnus >> - Open a message in the new group and press * >> - Add the cache virtual server (info "(gnus) Creating a Virtual Server") >> - ^ (server buffer) and: g on the cache >> - RET to open (fails) >> >> This is a possible fix that I've tested only on my (limited) setup, for >> now: > > Eric, what do you think of the below patch? Thanks for the bump... James, wasn't this what bug#69517 was supposed to be fixing? I'm still feeling like we're patching pinhole leaks in a fundamentally broken system. For the cache active file, wouldn't it be easier just to wrap the group name in double quotes?
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.Received: (at 70994) by debbugs.gnu.org; 18 May 2024 22:15:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 18 18:15:53 2024 Received: from localhost ([127.0.0.1]:35551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s8SLI-00068m-IX for submit <at> debbugs.gnu.org; Sat, 18 May 2024 18:15:52 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:44436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1s8SLF-00068g-9t for 70994 <at> debbugs.gnu.org; Sat, 18 May 2024 18:15:50 -0400 Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-56e6a1edecfso8518648a12.1 for <70994 <at> debbugs.gnu.org>; Sat, 18 May 2024 15:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716070480; x=1716675280; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=EXJa8hLaRpof6HKj5cNIg93fXgcbY/bdey3ri3q0S3M=; b=mxV5okk/7bBmK75Y8uwOFLdDa0FQYbymUR+uDzxrOytR68qnpeU3c2rV6XoXTbgsrg 48QsVZI63e3mlK8MnOoqLyGDxkiSxPcNplYTi2pFEnYynq2wW0cLUHyTQ5SErLpVWr4V Dm25D2YEljYrVy08595EU3rLYVTQf+n008ZkHbBKoWXgqkICcIYHSepz6W+BPop5mkXY XrVnJIR2XG/HoGjbpkjy6qLbmFK8Uo3y5kUFAvlV/E0qC2RWdbWZ0FcKdBD76z+AQ0kq Wq1IgxqEisEr2CeA4P48d0x8s224Tpe7tGVIyQlEs0CLtrJ7NwlyP80OYCZe+OVuLoo9 kLGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716070480; x=1716675280; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EXJa8hLaRpof6HKj5cNIg93fXgcbY/bdey3ri3q0S3M=; b=D+AyTltfIVLxHgTqVGY6wnqpQDAgoBrFCUpJMAtQGMPb6S/B2++2rdx0paID8PboUI 9THW6JG4lCRzcxdoqWgGWnYn5BHXaMqtganalvjAU+8RiAiBqfww/YyRhnqHIUa87Hjn HvXJQcKDDzyMudLnRl/lIRbeH+53YPfeiwndG4PcjqWtcC86Nv3sxbxFZYQhk1bRMA2B R8Bz1yPVKxuKunXGqt1/6yJlGv6S+EYTl9pBkPN5fyxn9z1cSt1LO/vLwCDD6OVEwO6R 7cOx3OnLgM0/umPcIOp5uoXiHG2Zh9/mCZVBF4XoriR1cnx63hVm9uoy9E6c0ggxTaol ETCw== X-Forwarded-Encrypted: i=1; AJvYcCVGFjaUo/WWufvWW+uOlTdGNidAegckhegKpHtVRan8vtuPgeLzfFutqXpDEdgr0+hQ9DcdbKsclLqkYfU8KqJ0OKLdrgE= X-Gm-Message-State: AOJu0YxTocg/7Eto8zejIjqMAWzh/qkjSVEromfozzd3tPihzOcvqpJC 4q+0R7EQc8+MypGyPnE1fK10e7Jg+7qi2MFivbp/a1bTPFRkombWp1lNdAn6G/TtheCOOQHzzJr EKB1/VImATs7sZnvyzMEQFgAx4lw= X-Google-Smtp-Source: AGHT+IGOGZSiJsDkwXTXuTHZXu81+9eef4FsZ30oENzokA8DJMz4RvMkpvQLSqTwiwFAdU+6cwqQJfJznqYq2PY2Dts= X-Received: by 2002:a50:a40c:0:b0:56d:c928:ad76 with SMTP id 4fb4d7f45d1cf-5734d67e8d0mr17105208a12.26.1716070479506; Sat, 18 May 2024 15:14:39 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 18 May 2024 22:14:39 +0000 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <86jzjt11ff.fsf@HIDDEN> References: <86jzjt11ff.fsf@HIDDEN> MIME-Version: 1.0 Date: Sat, 18 May 2024 22:14:39 +0000 Message-ID: <CADwFkmnRwYhzQCnWFXH8NkYV7PLj2-JeP0izhgRDEmrL0sLrBA@HIDDEN> Subject: Re: bug#70994: [PATCH] Make cache regeneration work in group names with / To: James Thomas <jimjoe@HIDDEN>, 70994 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70994 Cc: Eric Abrahamsen <eric@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > Reproduction steps for bug: > > - emacs -Q > - (setq gnus-secondary-select-methods > '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) > (setq gnus-select-method '(nnnil "")) > - M-x gnus > - Open a message in the new group and press * > - Add the cache virtual server (info "(gnus) Creating a Virtual Server") > - ^ (server buffer) and: g on the cache > - RET to open (fails) > > This is a possible fix that I've tested only on my (limited) setup, for > now: Eric, what do you think of the below patch? > From 1252b4541b265f6da13c07d9a2ce16fdecd51731 Mon Sep 17 00:00:00 2001 > From: James Thomas <jimjoe@HIDDEN> > Date: Fri, 17 May 2024 10:18:14 +0530 > Subject: [PATCH] Make cache regeneration work in group names with / > > * lisp/gnus/nnheader.el (nnheader-file-to-group): Account for / > in the last part of the group name. > * lisp/gnus/nnmail.el (nnmail-group-pathname): Url-encode only > the last part of the group name. > --- > lisp/gnus/nnheader.el | 25 +++++++++++++++---------- > lisp/gnus/nnmail.el | 19 ++++++++++++++++--- > 2 files changed, 31 insertions(+), 13 deletions(-) > > diff --git a/lisp/gnus/nnheader.el b/lisp/gnus/nnheader.el > index ea679759f3e..85a9f1bd8af 100644 > --- a/lisp/gnus/nnheader.el > +++ b/lisp/gnus/nnheader.el > @@ -827,16 +827,21 @@ nnheader-replace-duplicate-chars-in-string > > (defun nnheader-file-to-group (file &optional top) > "Return a group name based on FILE and TOP." > - (nnheader-replace-chars-in-string > - (if (not top) > - file > - (condition-case () > - (substring (expand-file-name file) > - (length > - (expand-file-name > - (file-name-as-directory top)))) > - (error ""))) > - nnheader-directory-separator-character ?.)) > + (setq file > + (if (not top) > + file > + (condition-case () > + (substring (expand-file-name file) > + (length > + (expand-file-name > + (file-name-as-directory top)))) > + (error "")))) > + ;; The last part could have slashes. > + (concat > + (nnheader-replace-chars-in-string > + (file-name-directory file) > + nnheader-directory-separator-character ?.) > + (url-unhex-string (file-name-nondirectory file)))) > > (defun nnheader-message (level &rest args) > "Message if the Gnus backends are talkative." > diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el > index a9f5b89c6fe..0e1bcf849ce 100644 > --- a/lisp/gnus/nnmail.el > +++ b/lisp/gnus/nnmail.el > @@ -627,9 +627,21 @@ nnmail-group-pathname > "Make file name for GROUP." > (concat > (let ((dir (file-name-as-directory (expand-file-name dir)))) > + (setq group > + ;; The last part is allowed slashes. So url-encode. > + (let ((split-list (split-string group "\\."))) > + (string-join > + (append > + (butlast split-list) > + (list (browse-url-url-encode-chars > + (car (last split-list)) > + (concat "[%" > + (char-to-string > + nnheader-directory-separator-character) > + "]")))) > + "."))) > (setq group (nnheader-replace-duplicate-chars-in-string > - (browse-url-url-encode-chars group "[/%]") > - ?. ?_)) > + group ?. ?_)) > (setq group (nnheader-translate-file-chars group)) > ;; If this directory exists, we use it directly. > (file-name-as-directory > @@ -638,7 +650,8 @@ nnmail-group-pathname > (expand-file-name group dir) > ;; If not, we translate dots into slashes. > (expand-file-name > - (nnheader-replace-chars-in-string group ?. ?/) > + (nnheader-replace-chars-in-string > + group ?. nnheader-directory-separator-character) > dir)))) > (or file ""))) > > -- > 2.40.1 > > > Regards, > James
bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 17 May 2024 04:59:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 17 00:59:27 2024
Received: from localhost ([127.0.0.1]:52979 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s7pgk-0000nB-SW
for submit <at> debbugs.gnu.org; Fri, 17 May 2024 00:59:27 -0400
Received: from lists.gnu.org ([209.51.188.17]:41708)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jimjoe@HIDDEN>) id 1s7pge-0000n5-OE
for submit <at> debbugs.gnu.org; Fri, 17 May 2024 00:59:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jimjoe@HIDDEN>) id 1s7peJ-0003fg-QL
for bug-gnu-emacs@HIDDEN; Fri, 17 May 2024 00:56:55 -0400
Received: from mout.gmx.net ([212.227.17.21])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jimjoe@HIDDEN>) id 1s7peG-0006MD-T8
for bug-gnu-emacs@HIDDEN; Fri, 17 May 2024 00:56:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net;
s=s31663417; t=1715921809; x=1716526609; i=jimjoe@HIDDEN;
bh=LbFNY4vo/kMDGrIenaYGNVNXAdxT3htPuJ1saTzSl0A=;
h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version:
Content-Type:cc:content-transfer-encoding:content-type:date:from:
message-id:mime-version:reply-to:subject:to;
b=nnrmGlPZ9bs8Usqd23AMJqKA1o5mQQhsWMxWHb8xf1iBYkl0sy8INZUhG8FEZ3lo
Ip2pMPO74JMKsfCYEgdY3WKDCVtYPwP2DfHAsM/KEkPetS0QLhlqRtxnzP93BP/ND
BlD1gmasPgaj1YLVcWjkCbkyiid1TRt3dgkEaAY4jLHV14aTu6uoNl/JhdEd8Krv0
rJaMWbO/mmeu0CIfmId5k6XI7k6vAZrx1HQ+zzFBhIRjLzLzgxJ+p4nzvRKJBf97+
8A361lkGA61j9CxAHHbSAjFShp3F17skbH2IuWZohJKMiavVQ0wAPa6+4zORtJ806
MKmERfOIs6yHOvuIFA==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from user-Inspiron-3493 ([117.212.170.99]) by mail.gmx.net (mrgmx105
[212.227.17.174]) with ESMTPSA (Nemesis) id 1M9Fjb-1sAsJb3r5b-006KjJ
for <bug-gnu-emacs@HIDDEN>; Fri, 17 May 2024 06:56:49 +0200
From: James Thomas <jimjoe@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Make cache regeneration work in group names with /
Date: Fri, 17 May 2024 10:26:36 +0530
Message-ID: <86jzjt11ff.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:XhYjI8vk2QB/D2lbIp8MKnwkfOlfkdnr3aZLDsr5X3xAv1RBZlq
EJlnopuz5XtVrRTR/Frg4GvYyIH7pfQYTGz96XFYyKwADfArnbY9TOYiT8SDVJMzonevT03
ZqGytXu9Da4qo0ZRV6WTLSpJjKNq9xe3uthruXwyaKwvubSfomcnUGbVQ+vh8L/zOzQzTks
yTptCcaz1llkjV6pWt8DA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:hnB0VRGGGDU=;xfonDBq7G/3a5qkc/aRmwN7fRTw
6poBYeDWCuZS8mZ4tpMqQDniQoA1bPBMtdCw7QwXAw7M0p0JlpfF8tFHroP5dJTQ1+OeDkcwg
KOVdqroq/isb98aRvaghFUpLA8A4RUTcvG58EcMK7UlblAVY3MTObzq+1ciiOIJ8Br2fWrjEk
0C3I+TOKiMzkKGNBXRmzEyb6ZzJoj4WvHVL14TEEKJoRIkLt8OKxwE9EV3g98WhABVGh5ZkKi
na5mSo1fM5scgw1nD/UvqA0KVpJw9wi1rjW1DDdX2X8cK8fZ4nfi0/0QRAq/WUkAUs3TncYMf
R2+fv6zkknE0rZq1k6eNBFeV1VI6+oTwDCb094kVqtnMlPLBD9ZWzWp/YRs/1xK6gqW2hFJwU
tJi5K6FXuJ069Z9iCUgGBpmt5U+0CpmjYrydSpv6WvpbtVPl1LgNvn5BQYSmU3wkEpqSjK8cZ
XlJNUuStzzndDMFKL5LzeUQFdvVTdrbuntdHWkwVzIQrzYTmGiEPc3iqnoS07SqvSbPzj82S6
nSXPrDH9moWqbXNK8VSWwlxR2WCBRJKvVRmyEH8Snceb9UHs8wQd6wduk0L7qVDv5j4wX7joV
BYGj63C4a7+f0yaQ1maCXjP8lDle7l5/pOuVCNNmzNi9UGKRa4yc+tFiSrLt77XCKW9KMJMMk
9yGGYme2+O7jaZwA21w2/cafwO1xrH3XGxHqf3ztR314FpBIt/87pXXAaxSTSrtmnYJbx27Ej
gcFpTuviOtx9rT2wO4nwZlZxRRCvuyZOM/oDiM4ZPDAtSLr7OcK3HpdzDkSoAzIIU+23yuejD
JtWRiL4HR4cQ4WZlg4yE6paESnz53ke7e6Z89wBaPjY+g=
Received-SPF: pass client-ip=212.227.17.21; envelope-from=jimjoe@HIDDEN;
helo=mout.gmx.net
X-Spam_score_int: -26
X-Spam_score: -2.7
X-Spam_bar: --
X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL=0.141,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Reproduction steps for bug: - emacs -Q - (setq
gnus-secondary-select-methods
'((nnatom "github.com/vedang/pdf-tools/commits.atom"))) (setq
gnus-select-method
'(nnnil "")) - M-x gnus - Open a message in the new group and press * [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL
[117.212.170.99 listed in zen.spamhaus.org]
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
medium trust [209.51.188.17 listed in list.dnswl.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (jimjoe[at]gmx.net)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.0 SPOOFED_FREEMAIL No description available.
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)
--=-=-=
Content-Type: text/plain
Reproduction steps for bug:
- emacs -Q
- (setq gnus-secondary-select-methods
'((nnatom "github.com/vedang/pdf-tools/commits.atom")))
(setq gnus-select-method '(nnnil ""))
- M-x gnus
- Open a message in the new group and press *
- Add the cache virtual server (info "(gnus) Creating a Virtual Server")
- ^ (server buffer) and: g on the cache
- RET to open (fails)
This is a possible fix that I've tested only on my (limited) setup, for
now:
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-Make-cache-regeneration-work-in-group-names-with.patch
Content-Description: [PATCH] Make cache regeneration work in group names with /
Content-Transfer-Encoding: quoted-printable
=46rom 1252b4541b265f6da13c07d9a2ce16fdecd51731 Mon Sep 17 00:00:00 2001
From: James Thomas <jimjoe@HIDDEN>
Date: Fri, 17 May 2024 10:18:14 +0530
Subject: [PATCH] Make cache regeneration work in group names with /
* lisp/gnus/nnheader.el (nnheader-file-to-group): Account for /
in the last part of the group name.
* lisp/gnus/nnmail.el (nnmail-group-pathname): Url-encode only
the last part of the group name.
=2D--
lisp/gnus/nnheader.el | 25 +++++++++++++++----------
lisp/gnus/nnmail.el | 19 ++++++++++++++++---
2 files changed, 31 insertions(+), 13 deletions(-)
diff --git a/lisp/gnus/nnheader.el b/lisp/gnus/nnheader.el
index ea679759f3e..85a9f1bd8af 100644
=2D-- a/lisp/gnus/nnheader.el
+++ b/lisp/gnus/nnheader.el
@@ -827,16 +827,21 @@ nnheader-replace-duplicate-chars-in-string
(defun nnheader-file-to-group (file &optional top)
"Return a group name based on FILE and TOP."
- (nnheader-replace-chars-in-string
- (if (not top)
- file
- (condition-case ()
- (substring (expand-file-name file)
- (length
- (expand-file-name
- (file-name-as-directory top))))
- (error "")))
- nnheader-directory-separator-character ?.))
+ (setq file
+ (if (not top)
+ file
+ (condition-case ()
+ (substring (expand-file-name file)
+ (length
+ (expand-file-name
+ (file-name-as-directory top))))
+ (error ""))))
+ ;; The last part could have slashes.
+ (concat
+ (nnheader-replace-chars-in-string
+ (file-name-directory file)
+ nnheader-directory-separator-character ?.)
+ (url-unhex-string (file-name-nondirectory file))))
(defun nnheader-message (level &rest args)
"Message if the Gnus backends are talkative."
diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el
index a9f5b89c6fe..0e1bcf849ce 100644
=2D-- a/lisp/gnus/nnmail.el
+++ b/lisp/gnus/nnmail.el
@@ -627,9 +627,21 @@ nnmail-group-pathname
"Make file name for GROUP."
(concat
(let ((dir (file-name-as-directory (expand-file-name dir))))
+ (setq group
+ ;; The last part is allowed slashes. So url-encode.
+ (let ((split-list (split-string group "\\.")))
+ (string-join
+ (append
+ (butlast split-list)
+ (list (browse-url-url-encode-chars
+ (car (last split-list))
+ (concat "[%"
+ (char-to-string
+ nnheader-directory-separator-character)
+ "]"))))
+ ".")))
(setq group (nnheader-replace-duplicate-chars-in-string
- (browse-url-url-encode-chars group "[/%]")
- ?. ?_))
+ group ?. ?_))
(setq group (nnheader-translate-file-chars group))
;; If this directory exists, we use it directly.
(file-name-as-directory
@@ -638,7 +650,8 @@ nnmail-group-pathname
(expand-file-name group dir)
;; If not, we translate dots into slashes.
(expand-file-name
- (nnheader-replace-chars-in-string group ?. ?/)
+ (nnheader-replace-chars-in-string
+ group ?. nnheader-directory-separator-character)
dir))))
(or file "")))
=2D-
2.40.1
--=-=-=
Content-Type: text/plain
Regards,
James
--=-=-=--
James Thomas <jimjoe@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70994; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.