Dariqq <dariqq@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 70999) by debbugs.gnu.org; 25 May 2024 14:08:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 25 10:08:54 2024
Received: from localhost ([127.0.0.1]:43647 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sAs4r-0000HJ-Q9
for submit <at> debbugs.gnu.org; Sat, 25 May 2024 10:08:54 -0400
Received: from mout02.posteo.de ([185.67.36.66]:56931)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dariqq@HIDDEN>) id 1sAs4q-0000Gs-4o
for 70999 <at> debbugs.gnu.org; Sat, 25 May 2024 10:08:52 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout02.posteo.de (Postfix) with ESMTPS id 15FB0240103
for <70999 <at> debbugs.gnu.org>; Sat, 25 May 2024 16:08:37 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1716646118; bh=9Lsw3mwnjUcs1iH/1plgU+J6L9fEPnui7FpZ9qJ5kmY=;
h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:
Content-Transfer-Encoding:From;
b=j+82SxCxmB/Zlc9gZAX0MlOCzdkAkP/0ESUqUvemNLB9gF4DqFGmFgY8xBgt82Upn
rCBuyESN7Ug2YVOuJVn4SFBp7D8W1HMTvyN50yX/5knTvakA91l1OWbmwNrWgW0pD7
kohudWTfQCxUp3twoxWkxsIjxw2MMK9/fyqws/KFYkqmccQdxNGV9SbjQw2IdGUdjQ
WQ6zdR8rJSrt2feElZ3Xswi5+H2z7r/xBB5QbdbHNOpcA8vP2VHCUKj+nPULU6qeOK
cC/z9Ohl2UzOd+ZHB84wBO+3QEaGgaHVnXZDs8FfP8xjQ/HABwtd8LHLTd2UCSKuQx
7KuurZ96rqM/g==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4VmkKK2py4z9rxF;
Sat, 25 May 2024 16:08:37 +0200 (CEST)
From: Dariqq <dariqq@HIDDEN>
To: 70999 <at> debbugs.gnu.org
Subject: [PATCH] build-system/meson: Add #:out-of-source? argument to build
system.
Date: Sat, 25 May 2024 14:02:19 +0000
Message-ID: <55230dcd23f65c3caa3ea61ed2b18c672b389211.1716645739.git.dariqq@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70999
Cc: Dariqq <dariqq@HIDDEN>, ludo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Meson currently supports only out-of-source builds. Add the argument out-of-source? with default to #t such that the install-license-files phase searches for the license files in the source directory.
* guix/build-system/meson.scm (meson-build): Add out-of-source? argument.
(meson-cross-build): Likewise.
Change-Id: Ib59d9d93b34fd567f05f5f9a10293f6ab924e399
---
I have tested this with the tio package (both natively building and cross compiling) and seems to work. This will cause a lot of rebuild!
For the position of the argument I've put it above build-type to match the order in cmake-build-system.
guix/build-system/meson.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/guix/build-system/meson.scm b/guix/build-system/meson.scm
index bf9ca15ecc..6c085fa1fe 100644
--- a/guix/build-system/meson.scm
+++ b/guix/build-system/meson.scm
@@ -176,6 +176,7 @@ (define* (meson-build name inputs
(outputs '("out"))
(configure-flags ''())
(search-paths '())
+ (out-of-source? #t)
(build-type "debugoptimized")
(tests? #t)
(test-options ''())
@@ -225,6 +226,7 @@ (define* (meson-build name inputs
#$(if (pair? configure-flags)
(sexp->gexp configure-flags)
configure-flags)
+ #:out-of-source? #$out-of-source?
#:build-type #$build-type
#:tests? #$tests?
#:test-options #$(sexp->gexp test-options)
@@ -257,7 +259,7 @@ (define* (meson-cross-build name
(configure-flags ''())
(search-paths '())
(native-search-paths '())
-
+ (out-of-source? #t)
(build-type "debugoptimized")
(tests? #f)
(test-options ''())
@@ -338,6 +340,7 @@ (define* (meson-cross-build name
,@#$(if (pair? configure-flags)
(sexp->gexp configure-flags)
configure-flags))
+ #:out-of-source? #$out-of-source?
#:build-type #$build-type
#:tests? #$tests?
#:test-options #$(sexp->gexp test-options)
base-commit: 9756d9d6345fb142944261174453ab0a597cc2e7
--
2.41.0
bug-guix@HIDDEN:bug#70999; Package guix.
Full text available.Received: (at 70999) by debbugs.gnu.org; 25 May 2024 09:37:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 25 05:37:31 2024 Received: from localhost ([127.0.0.1]:42390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sAnqE-00058r-T5 for submit <at> debbugs.gnu.org; Sat, 25 May 2024 05:37:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1sAnqD-00058j-3e for 70999 <at> debbugs.gnu.org; Sat, 25 May 2024 05:37:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1sAnq0-000533-9m; Sat, 25 May 2024 05:37:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Q6Jdp9T4L8qWiBEnehNSNi4oNxApuJX1Wf3bPKwkQa8=; b=JcZ4xrO0FhhEyW9bRFe2 8xh4eNqyOt1hBHr3pu37wfstchI9qQLmJlcdbcp5CPC01BO99EXc0dPNXfuRL2AnFtg8A+M3KKMyA Jz42OcRCd4zDq5NejBuFiGaRk1TjIV3ZixPe1dHGymvYfvztYfn132uPh/bq+bMDE1Kl5h1v/4Frk XUjkKVdoqZ4A11A6tMGVscpnsYmosjMcq1BzJ9FcQYgySDhBnqOiLY0jOY9z3RcIMIVkqZQurJ2rJ 96VkBy6kvRkzdZeDEpL7ZA7U1SQXdJ+Z3GRqBViy7n2U53hMAewAoQnLWxpgQ0stPcoMMc1ir+9ly XEJUhkV08rBUWQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Dariqq <dariqq@HIDDEN> Subject: Re: bug#70999: Meson-build system fails to install license files In-Reply-To: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN> (dariqq@HIDDEN's message of "Fri, 17 May 2024 09:26:38 +0000") References: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN> Date: Sat, 25 May 2024 11:37:14 +0200 Message-ID: <87plta2px1.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70999 Cc: 70999 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Dariqq, Dariqq <dariqq@HIDDEN> skribis: > The install-license-files function has an argument for specifying > out-of-source builds and calling it with that set to #t seems to be > able to find license files in the source directory in my limited > testing. Yes, =E2=80=98meson-build-system=E2=80=99 should pass #:out-of-source? #t e= xactly like =E2=80=98cmake-build-system=E2=80=99 does. That should solve the problem. Thanks, Ludo=E2=80=99.
bug-guix@HIDDEN:bug#70999; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 17 May 2024 09:26:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 17 05:26:58 2024 Received: from localhost ([127.0.0.1]:54135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s7tre-000419-H9 for submit <at> debbugs.gnu.org; Fri, 17 May 2024 05:26:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:48614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dariqq@HIDDEN>) id 1s7trZ-000412-GB for submit <at> debbugs.gnu.org; Fri, 17 May 2024 05:26:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dariqq@HIDDEN>) id 1s7trW-0000az-6v for bug-guix@HIDDEN; Fri, 17 May 2024 05:26:50 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dariqq@HIDDEN>) id 1s7trT-0000uF-JH for bug-guix@HIDDEN; Fri, 17 May 2024 05:26:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A9042240028 for <bug-guix@HIDDEN>; Fri, 17 May 2024 11:26:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715938001; bh=I1FokMjpSFv8yQM9UjwQH6bzpQEKc7BQeD5Yc5sabUM=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding:From; b=rjS3GeoaNcJkGKkJB1eY4ZVGs7S/LfnnhgjLUPnJ3jpIdqbPY9EzCOJ5d6IQGkAws IhhscBUw+UXJTrPFscrz3Y96gOtJPtsIxLI69tH6mn5laEtTfzGew49OrQWn0M2t1/ Nw5UXtipVoZaDA4BMz0hXEbBZjX0R+touNIhJ/q0BAZiYSQGuus5HbKW1X7Dek21wF SlToDkKax4Kze8mJZ2UHgaC5aaniu95Z389eppwUj9OywUCycIvvKTv0CzCmcsMEub b1MUMdu5NecLjMrpgjQVp49uoehuqpdG61GtDOFKTCyYH6yT7M5NvayuGGl4rf2FPo K8SfXZmTalwgw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VghRj1W39z9rxM for <bug-guix@HIDDEN>; Fri, 17 May 2024 11:26:40 +0200 (CEST) Message-ID: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN> Date: Fri, 17 May 2024 09:26:38 +0000 MIME-Version: 1.0 Content-Language: en-US To: bug-guix@HIDDEN From: Dariqq <dariqq@HIDDEN> Subject: Meson-build system fails to install license files Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=dariqq@HIDDEN; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) Hi Guix, I was trying to update a package using meson build system to its newest version and noticed in the build log starting phase `install-license-files' installing 0 license files from '.' phase `install-license-files' succeeded after 0.0 seconds Also other packages built using meson don't seem to have license files in the output. I think the problem is that the "." directory is the "build" directory and not the source directory because in meson configure phase we change directory to the build-dir. The install-license-files function has an argument for specifying out-of-source builds and calling it with that set to #t seems to be able to find license files in the source directory in my limited testing. Another option would be to specify the build dir in the ninja invocations without changing to it. As meson only supports out-of-source builds I think this should be changed though I am unsure how to best do this.
Dariqq <dariqq@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#70999; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.