GNU bug report logs - #7101
Please reveal-mode, don't hide my overlays!

Previous Next

Package: emacs;

Reported by: Lennart Borgman <lennart.borgman <at> gmail.com>

Date: Sat, 25 Sep 2010 13:22:02 UTC

Severity: wishlist

Tags: fixed

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7101 in the body.
You can then email your comments to 7101 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7101; Package emacs. (Sat, 25 Sep 2010 13:22:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Lennart Borgman <lennart.borgman <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 25 Sep 2010 13:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Please reveal-mode, don't hide my overlays!
Date: Sat, 25 Sep 2010 15:23:58 +0200
[Message part 1 (text/plain, inline)]
Am I the only one that gets crazy when reveal hides the overlays
again? At least I mostly find it very frustrating when moving around
in a buffer that uses org-mode.

I can see it is useful sometimes though I do not know how to best
separate those times when it is useful and when it is not. So I will
not try that.

Instead in the attached patch I made the automatic hiding optional and
add a new command for hiding
[reveal-dont-hide.diff (application/octet-stream, attachment)]

Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7101; Package emacs. (Sat, 25 Sep 2010 20:56:02 GMT) Full text and rfc822 format available.

Message #8 received at 7101 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: 7101 <at> debbugs.gnu.org
Subject: Re: bug#7101: Please reveal-mode, don't hide my overlays!
Date: Sat, 25 Sep 2010 22:57:27 +0200
> Instead in the attached patch I made the automatic hiding optional and
> add a new command for hiding

If this is accepted then please also change the default of
reveal-at-mark to nil since that seems to be a more useful default
then.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7101; Package emacs. (Thu, 07 Oct 2010 10:20:03 GMT) Full text and rfc822 format available.

Message #11 received at 7101 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 7101 <at> debbugs.gnu.org
Subject: Re: bug#7101: Please reveal-mode, don't hide my overlays!
Date: Thu, 07 Oct 2010 12:23:07 +0200
> Am I the only one that gets crazy when reveal hides the overlays
> again? At least I mostly find it very frustrating when moving around
> in a buffer that uses org-mode.

I love this feature, since it lets me open&close things without ever
having to remember a keybinding: I hide everything in the major mode
hook and then use reveal-mode to hide&show.

> I can see it is useful sometimes though I do not know how to best
> separate those times when it is useful and when it is not. So I will
> not try that.

> Instead in the attached patch I made the automatic hiding optional and
> add a new command for hiding

Maybe I could live with that, and I think it's going in the right
direction (e.g. the reveal-close-revealed functionality sounds good),
but I don't think having it as a defcustom is right: it's something
you'll likely want to change dynamically at run time.

One thing I've considered is to add a "keep-pos/region-shown" command that
would mark the current buffer position (or region) as something that
should stay revealed, so it won't be auto-closed when you move elsewhere.
Of course, it would want to come with something like
reveal-close-revealed to later re-hide them.

Another thing I'd be interested to see is a hook that major/minor modes
can use to have some control over showing/hiding.  The main such use for
me would be to let smerge-mode teach reveal-mode that if one conflict
marker is revealed, all the corresponding markers should also be
revealed (or maybe just: if part of a conflict is revealed, always
reveal the whole conflict).


        Stefan






Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7101; Package emacs. (Thu, 07 Oct 2010 10:31:02 GMT) Full text and rfc822 format available.

Message #14 received at 7101 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 7101 <at> debbugs.gnu.org
Subject: Re: bug#7101: Please reveal-mode, don't hide my overlays!
Date: Thu, 7 Oct 2010 12:33:13 +0200
On Thu, Oct 7, 2010 at 12:23 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>> Am I the only one that gets crazy when reveal hides the overlays
>> again? At least I mostly find it very frustrating when moving around
>> in a buffer that uses org-mode.
>
> I love this feature, since it lets me open&close things without ever
> having to remember a keybinding: I hide everything in the major mode
> hook and then use reveal-mode to hide&show.
>
>> I can see it is useful sometimes though I do not know how to best
>> separate those times when it is useful and when it is not. So I will
>> not try that.
>
>> Instead in the attached patch I made the automatic hiding optional and
>> add a new command for hiding
>
> Maybe I could live with that, and I think it's going in the right
> direction (e.g. the reveal-close-revealed functionality sounds good),
> but I don't think having it as a defcustom is right: it's something
> you'll likely want to change dynamically at run time.


Maybe it should be buffer local most of the time and take default
value from a defcustom?

I wonder whether searching should be made a special case here? I
prefer to see my hits when searching (at least around point), but if
it is the wrong place then I might want to close the revealed overlay
immediately. How about something like that?


> One thing I've considered is to add a "keep-pos/region-shown" command that
> would mark the current buffer position (or region) as something that
> should stay revealed, so it won't be auto-closed when you move elsewhere.
> Of course, it would want to come with something like
> reveal-close-revealed to later re-hide them.


It is similar to my idea above. I think my idea above could be
implemented with something like that.


> Another thing I'd be interested to see is a hook that major/minor modes
> can use to have some control over showing/hiding.  The main such use for
> me would be to let smerge-mode teach reveal-mode that if one conflict
> marker is revealed, all the corresponding markers should also be
> revealed (or maybe just: if part of a conflict is revealed, always
> reveal the whole conflict).


Could also be implemented with the above ideas.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#7101; Package emacs. (Sat, 19 Sep 2020 15:47:02 GMT) Full text and rfc822 format available.

Message #17 received at 7101 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 7101 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#7101: Please reveal-mode, don't hide my overlays!
Date: Sat, 19 Sep 2020 17:46:08 +0200
Lennart Borgman <lennart.borgman <at> gmail.com> writes:

> Am I the only one that gets crazy when reveal hides the overlays
> again? At least I mostly find it very frustrating when moving around
> in a buffer that uses org-mode.
>
> I can see it is useful sometimes though I do not know how to best
> separate those times when it is useful and when it is not. So I will
> not try that.
>
> Instead in the attached patch I made the automatic hiding optional and
> add a new command for hiding

I've reworked your patch a bit (avoiding terms like "close" and
"overlay") and applied it to Emacs 28.

Stefan was concerned that having just a defcustom wouldn't be enough
here -- that auto-reveal should/could be done via a command.  That's a
good point, but I think it's quite likely that people that prefer to
have this off will set the variable from a mode hook or something, so I
think the variable itself is useful.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 19 Sep 2020 15:47:03 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 7101 <at> debbugs.gnu.org and Lennart Borgman <lennart.borgman <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 19 Sep 2020 15:47:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 18 Oct 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 162 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.