GNU bug report logs - #71037
[PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Sat, 18 May 2024 12:41:01 UTC

Severity: normal

Tags: patch

Done: jgart <jgart <at> dismail.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71037 in the body.
You can then email your comments to 71037 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Sat, 18 May 2024 12:41:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Graves <ngraves <at> ngraves.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 18 May 2024 12:41:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Sat, 18 May 2024 14:35:50 +0200
Nicolas Graves (3):
  gnu: python-pydevd: Move to pyproject-build-system.
  gnu: python-pydevd: Update to 2.9.6.
  gnu: python-pydevd: Improve package style.

 gnu/packages/python-xyz.scm | 210 ++++++++++++++++++------------------
 1 file changed, 102 insertions(+), 108 deletions(-)

-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Sat, 18 May 2024 12:44:01 GMT) Full text and rfc822 format available.

Message #8 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 71037 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 1/3] gnu: python-pydevd: Move to pyproject-build-system.
Date: Sat, 18 May 2024 14:43:05 +0200
* gnu/packages/python-xyz.scm (python-pydevd):
  [build-system]: Move to pyproject-build-system.
  [arguments]: Replace 'check phase by 'pre-check phase and
  <#:test-flags>.

Change-Id: I8227ac8b1b6031c30c6d09480cacaa3347df21a7
---
 gnu/packages/python-xyz.scm | 46 ++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 8151355a418..c2039273429 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16717,9 +16717,29 @@ (define-public python-pydevd
          (sha256
           (base32
            "1yd017dh6xgxrqcyf8kk8jrr0a3zw895yfjih0z5jghyf0rck38q"))))
-      (build-system python-build-system)
+      (build-system pyproject-build-system)
       (arguments
        (list
+        #:test-flags
+        #~(list "-n" (number->string (parallel-job-count))
+                "-k"
+                (string-append
+                 ;; The two "break_01" tests have been failing on
+                 ;; Python 3.10:
+                 ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
+                 "not test_set_pydevd_break_01 "
+                 ;; This one fails for unknown reasons.
+                 "and not test_completion_sockets_and_messages "
+                 ;; the GUI event loop requires an X server.
+                 "and not test_gui_event_loop_custom "
+                 ;; This test validates that 'pydevd' is not in the
+                 ;; exception message, but it is due to being part
+                 ;; of the build file name present in the message.
+                 "and not test_evaluate_exception_trace "
+                 ;; These fail on systems with YAMA LSM’s ptrace
+                 ;; scope > 0. Upstream issue:
+                 ;; https://github.com/fabioz/PyDev.Debugger/issues/218
+                 "and not test_attach_to_pid"))
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'fix-tests
@@ -16758,30 +16778,10 @@ (define-public python-pydevd
                 (invoke #+(cxx-for-target) "-shared" "-o" "attach.so"
                         "-fPIC" "-nostartfiles"
                         "pydevd_attach_to_process/linux_and_mac/attach.cpp")))
-            (replace 'check
+            (add-before 'check 'pre-check
               (lambda* (#:key tests? #:allow-other-keys)
                 (when tests?
-                  (setenv "PYDEVD_USE_CYTHON" "YES")
-                  (invoke "pytest" "-vv"
-                          "-n" (number->string (parallel-job-count))
-                          "-k"
-                          (string-append
-                           ;; The two "break_01" tests have been failing on
-                           ;; Python 3.10:
-                           ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
-                           "not test_set_pydevd_break_01 "
-                           ;; This one fails for unknown reasons.
-                           "and not test_completion_sockets_and_messages "
-                           ;; the GUI event loop requires an X server.
-                           "and not test_gui_event_loop_custom "
-                           ;; This test validates that 'pydevd' is not in the
-                           ;; exception message, but it is due to being part
-                           ;; of the build file name present in the message.
-                           "and not test_evaluate_exception_trace "
-                           ;; These fail on systems with YAMA LSM’s ptrace
-                           ;; scope > 0. Upstream issue:
-                           ;; https://github.com/fabioz/PyDev.Debugger/issues/218
-                           "and not test_attach_to_pid")))))
+                  (setenv "PYDEVD_USE_CYTHON" "YES"))))
             (add-after 'install 'install-attach-binary
               (lambda _
                 (install-file "attach.so"
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Sat, 18 May 2024 12:44:02 GMT) Full text and rfc822 format available.

Message #11 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 71037 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 2/3] gnu: python-pydevd: Update to 2.9.6.
Date: Sat, 18 May 2024 14:43:06 +0200
* gnu/packages/python-xyz.scm (python-pydevd): Update to 2.9.6.
  [arguments]<#:test-flags>: Adapt value.

Change-Id: I55cc8129fb78f0ee54519f45b31746a54881d84e
---
 gnu/packages/python-xyz.scm | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index c2039273429..fb12aba967f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16694,19 +16694,17 @@ (define-public python-file
 libmagic.")))
 
 (define-public python-pydevd
-  ;; Use the latest commit, which includes cleanups that removes Python 2
-  ;; syntax that would fail to build.
-  (let ((revision "0")
-        (commit "47e298499ef19563bb2ef5941a57046a35ae6868"))
     (package
       (name "python-pydevd")
-      (version (git-version "2.8.0" revision commit))
+      (version "2.9.6")
       (source
        (origin
          (method git-fetch)
          (uri (git-reference
                (url "https://github.com/fabioz/PyDev.Debugger")
-               (commit commit)))
+               (commit (string-append
+                        "pydev_debugger_"
+                        (string-join (string-split version #\.) "_")))))
          (modules '((guix build utils)))
          (snippet '(begin
                      ;; Delete pre-built binaries.
@@ -16716,7 +16714,7 @@ (define-public python-pydevd
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "1yd017dh6xgxrqcyf8kk8jrr0a3zw895yfjih0z5jghyf0rck38q"))))
+           "1niqb6l3m03arfjh14k9k5i5bi56m8qmc3pyi1qkbvqqp5bkydac"))))
       (build-system pyproject-build-system)
       (arguments
        (list
@@ -16728,18 +16726,14 @@ (define-public python-pydevd
                  ;; Python 3.10:
                  ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
                  "not test_set_pydevd_break_01 "
-                 ;; This one fails for unknown reasons.
-                 "and not test_completion_sockets_and_messages "
                  ;; the GUI event loop requires an X server.
                  "and not test_gui_event_loop_custom "
                  ;; This test validates that 'pydevd' is not in the
                  ;; exception message, but it is due to being part
                  ;; of the build file name present in the message.
                  "and not test_evaluate_exception_trace "
-                 ;; These fail on systems with YAMA LSM’s ptrace
-                 ;; scope > 0. Upstream issue:
-                 ;; https://github.com/fabioz/PyDev.Debugger/issues/218
-                 "and not test_attach_to_pid"))
+                 ;; This test fail with TimeoutError, no message on stderr.
+                 "and not test_soft_terminate "))
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'fix-tests
@@ -16802,7 +16796,7 @@ (define-public python-pydevd
       (synopsis "Python debugger")
       (description "PyDev.Debugger is a capable Python debugger used in PyDev
 and other @acronym{IDEs, Integrated Development Environments}.")
-      (license license:epl1.0))))
+      (license license:epl1.0)))
 
 (define-public python-debugpy
   (package
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Sat, 18 May 2024 12:44:02 GMT) Full text and rfc822 format available.

Message #14 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 71037 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 3/3] gnu: python-pydevd: Improve package style.
Date: Sat, 18 May 2024 14:43:07 +0200
* gnu/packages/python-xyz.scm (python-pydevd): Indent properly.

Change-Id: I854d32943416e5f9b7c8dd3602d975dde0d31153
---
 gnu/packages/python-xyz.scm | 204 ++++++++++++++++++------------------
 1 file changed, 102 insertions(+), 102 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index fb12aba967f..aaca34e0e29 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16694,109 +16694,109 @@ (define-public python-file
 libmagic.")))
 
 (define-public python-pydevd
-    (package
-      (name "python-pydevd")
-      (version "2.9.6")
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/fabioz/PyDev.Debugger")
-               (commit (string-append
-                        "pydev_debugger_"
-                        (string-join (string-split version #\.) "_")))))
-         (modules '((guix build utils)))
-         (snippet '(begin
-                     ;; Delete pre-built binaries.
-                     (for-each delete-file (find-files "." "\\.(so|dylib|dll)"))
-                     ;; This source is generated via Cython.
-                     (delete-file "_pydevd_bundle/pydevd_cython.c")))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "1niqb6l3m03arfjh14k9k5i5bi56m8qmc3pyi1qkbvqqp5bkydac"))))
-      (build-system pyproject-build-system)
-      (arguments
-       (list
-        #:test-flags
-        #~(list "-n" (number->string (parallel-job-count))
-                "-k"
-                (string-append
-                 ;; The two "break_01" tests have been failing on
-                 ;; Python 3.10:
-                 ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
-                 "not test_set_pydevd_break_01 "
-                 ;; the GUI event loop requires an X server.
-                 "and not test_gui_event_loop_custom "
-                 ;; This test validates that 'pydevd' is not in the
-                 ;; exception message, but it is due to being part
-                 ;; of the build file name present in the message.
-                 "and not test_evaluate_exception_trace "
-                 ;; This test fail with TimeoutError, no message on stderr.
-                 "and not test_soft_terminate "))
-        #:phases
-        #~(modify-phases %standard-phases
-            (add-after 'unpack 'fix-tests
-              (lambda _
-                (substitute* "tests_python/test_convert_utilities.py"
-                  ;; Add missing trailing '/'.
-                  (("'\\\\\\\\usr\\\\\\\\bin\\\\\\\\') == '/usr/bin" all)
-                   (string-append all "/")))))
-            (add-after 'unpack 'patch-command-paths
-              (lambda* (#:key inputs #:allow-other-keys)
-                (substitute* "_pydevd_bundle/pydevd_api.py"
-                  (("'kill'")
-                   (format #f "~s" (search-input-file inputs "bin/kill")))
-                  (("'pgrep'")
-                   (format #f "~s" (search-input-file inputs "bin/pgrep"))))))
-            (add-after 'unpack 'generate-sources
-              (lambda _
-                (setenv "PYTHONPATH" (getcwd))
-                (invoke "python" "build_tools/build.py")))
-            (add-after 'unpack 'adjust-attach-binary-name
-              (lambda _
-                (substitute*
-                    '("pydevd_tracing.py"
-                      "pydevd_attach_to_process/add_code_to_python_process.py")
-                  (("def get_(target|python_helper_lib)_filename.*" all)
-                   (format #f "~a    return ~s~%" all
-                           (string-append #$output "/lib/attach.so"))))))
-            (add-after 'unpack 'patch-gdb
-              (lambda* (#:key inputs #:allow-other-keys)
-                (substitute*
-                    "pydevd_attach_to_process/add_code_to_python_process.py"
-                  (("'gdb',")
-                   (format #f "~s," (search-input-file inputs "bin/gdb"))))))
-            (add-after 'build 'build-attach-linux-binary
-              (lambda _
-                (invoke #+(cxx-for-target) "-shared" "-o" "attach.so"
-                        "-fPIC" "-nostartfiles"
-                        "pydevd_attach_to_process/linux_and_mac/attach.cpp")))
-            (add-before 'check 'pre-check
-              (lambda* (#:key tests? #:allow-other-keys)
-                (when tests?
-                  (setenv "PYDEVD_USE_CYTHON" "YES"))))
-            (add-after 'install 'install-attach-binary
-              (lambda _
-                (install-file "attach.so"
-                              (string-append #$output "/lib"))))
-            ;; Some modules aren't designed to be loadable by themselves, such
-            ;; as 'pydev_app_engine_debug_startup' and fail.
-            (delete 'sanity-check))))
-      (native-inputs
-       (list python-cython
-             python-numpy
-             python-psutil
-             python-pytest
-             python-pytest-xdist
-             python-trio
-             python-untangle))
-      (inputs (list coreutils gdb/pinned procps))
-      (home-page "https://github.com/fabioz/PyDev.Debugger/")
-      (synopsis "Python debugger")
-      (description "PyDev.Debugger is a capable Python debugger used in PyDev
+  (package
+    (name "python-pydevd")
+    (version "2.9.6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/fabioz/PyDev.Debugger")
+             (commit (string-append
+                      "pydev_debugger_"
+                      (string-join (string-split version #\.) "_")))))
+       (modules '((guix build utils)))
+       (snippet '(begin
+                   ;; Delete pre-built binaries.
+                   (for-each delete-file (find-files "." "\\.(so|dylib|dll)"))
+                   ;; This source is generated via Cython.
+                   (delete-file "_pydevd_bundle/pydevd_cython.c")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1niqb6l3m03arfjh14k9k5i5bi56m8qmc3pyi1qkbvqqp5bkydac"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:test-flags
+      #~(list "-n" (number->string (parallel-job-count))
+              "-k"
+              (string-append
+               ;; The two "break_01" tests have been failing on
+               ;; Python 3.10:
+               ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
+               "not test_set_pydevd_break_01 "
+               ;; the GUI event loop requires an X server.
+               "and not test_gui_event_loop_custom "
+               ;; This test validates that 'pydevd' is not in the
+               ;; exception message, but it is due to being part
+               ;; of the build file name present in the message.
+               "and not test_evaluate_exception_trace "
+               ;; This test fail with TimeoutError, no message on stderr.
+               "and not test_soft_terminate "))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'fix-tests
+            (lambda _
+              (substitute* "tests_python/test_convert_utilities.py"
+                ;; Add missing trailing '/'.
+                (("'\\\\\\\\usr\\\\\\\\bin\\\\\\\\') == '/usr/bin" all)
+                 (string-append all "/")))))
+          (add-after 'unpack 'patch-command-paths
+            (lambda* (#:key inputs #:allow-other-keys)
+              (substitute* "_pydevd_bundle/pydevd_api.py"
+                (("'kill'")
+                 (format #f "~s" (search-input-file inputs "bin/kill")))
+                (("'pgrep'")
+                 (format #f "~s" (search-input-file inputs "bin/pgrep"))))))
+          (add-after 'unpack 'generate-sources
+            (lambda _
+              (setenv "PYTHONPATH" (getcwd))
+              (invoke "python" "build_tools/build.py")))
+          (add-after 'unpack 'adjust-attach-binary-name
+            (lambda _
+              (substitute*
+                  '("pydevd_tracing.py"
+                    "pydevd_attach_to_process/add_code_to_python_process.py")
+                (("def get_(target|python_helper_lib)_filename.*" all)
+                 (format #f "~a    return ~s~%" all
+                         (string-append #$output "/lib/attach.so"))))))
+          (add-after 'unpack 'patch-gdb
+            (lambda* (#:key inputs #:allow-other-keys)
+              (substitute*
+                  "pydevd_attach_to_process/add_code_to_python_process.py"
+                (("'gdb',")
+                 (format #f "~s," (search-input-file inputs "bin/gdb"))))))
+          (add-after 'build 'build-attach-linux-binary
+            (lambda _
+              (invoke #+(cxx-for-target) "-shared" "-o" "attach.so"
+                      "-fPIC" "-nostartfiles"
+                      "pydevd_attach_to_process/linux_and_mac/attach.cpp")))
+          (add-before 'check 'pre-check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (setenv "PYDEVD_USE_CYTHON" "YES"))))
+          (add-after 'install 'install-attach-binary
+            (lambda _
+              (install-file "attach.so"
+                            (string-append #$output "/lib"))))
+          ;; Some modules aren't designed to be loadable by themselves, such
+          ;; as 'pydev_app_engine_debug_startup' and fail.
+          (delete 'sanity-check))))
+    (native-inputs
+     (list python-cython
+           python-numpy
+           python-psutil
+           python-pytest
+           python-pytest-xdist
+           python-trio
+           python-untangle))
+    (inputs (list coreutils gdb/pinned procps))
+    (home-page "https://github.com/fabioz/PyDev.Debugger/")
+    (synopsis "Python debugger")
+    (description "PyDev.Debugger is a capable Python debugger used in PyDev
 and other @acronym{IDEs, Integrated Development Environments}.")
-      (license license:epl1.0)))
+    (license license:epl1.0)))
 
 (define-public python-debugpy
   (package
-- 
2.41.0





Added blocking bug(s) 70393 Request was from Nicolas Graves <ngraves <at> ngraves.fr> to control <at> debbugs.gnu.org. (Sat, 18 May 2024 12:50:02 GMT) Full text and rfc822 format available.

Added indication that bug 71037 blocks70995 Request was from Nicolas Graves <ngraves <at> ngraves.fr> to control <at> debbugs.gnu.org. (Sat, 18 May 2024 13:09:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Tue, 21 May 2024 02:43:02 GMT) Full text and rfc822 format available.

Message #21 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 71037 <at> debbugs.gnu.org
Subject: Re: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Mon, 20 May 2024 22:40:49 -0400
Hello!

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> Nicolas Graves (3):
>   gnu: python-pydevd: Move to pyproject-build-system.
>   gnu: python-pydevd: Update to 2.9.6.
>   gnu: python-pydevd: Improve package style.
>

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

Also, thanks for refreshing/resubmitting the pydevd patch to upstream!

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Tue, 21 May 2024 07:52:02 GMT) Full text and rfc822 format available.

Message #24 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 71037 <at> debbugs.gnu.org
Subject: Re: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Tue, 21 May 2024 09:51:27 +0200
On 2024-05-20 22:40, Maxim Cournoyer wrote:

> Hello!
>
> Nicolas Graves <ngraves <at> ngraves.fr> writes:
>
>> Nicolas Graves (3):
>>   gnu: python-pydevd: Move to pyproject-build-system.
>>   gnu: python-pydevd: Update to 2.9.6.
>>   gnu: python-pydevd: Improve package style.
>>
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>
>
> Also, thanks for refreshing/resubmitting the pydevd patch to upstream!

As a comment for my debugpy patch : we should probably care about that
too: https://github.com/microsoft/debugpy/issues/1585

Until this gets a proper answer, we should probably only update to
1.8.0, although I don't see why this should really diverge given the
commits.

I can't work on this today, but feel free to rebase the patch in 1.8.0
(should be easy, not much changes). Otherwise, I'll do it, but probably
not before next week.

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Wed, 22 May 2024 00:10:01 GMT) Full text and rfc822 format available.

Message #27 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 71037 <at> debbugs.gnu.org
Subject: Re: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Tue, 21 May 2024 20:07:52 -0400
Hi Nicolas,

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> On 2024-05-20 22:40, Maxim Cournoyer wrote:
>
>> Hello!
>>
>> Nicolas Graves <ngraves <at> ngraves.fr> writes:
>>
>>> Nicolas Graves (3):
>>>   gnu: python-pydevd: Move to pyproject-build-system.
>>>   gnu: python-pydevd: Update to 2.9.6.
>>>   gnu: python-pydevd: Improve package style.
>>>
>>
>> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>
>>
>> Also, thanks for refreshing/resubmitting the pydevd patch to upstream!
>
> As a comment for my debugpy patch : we should probably care about that
> too: https://github.com/microsoft/debugpy/issues/1585
>
> Until this gets a proper answer, we should probably only update to
> 1.8.0, although I don't see why this should really diverge given the
> commits.
>
> I can't work on this today, but feel free to rebase the patch in 1.8.0
> (should be easy, not much changes). Otherwise, I'll do it, but probably
> not before next week.

I'm not in a position to push on this right now, so I'll let you lead
the charge, even if that's in a week or two.  Thanks for doing so!

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Mon, 24 Jun 2024 03:14:01 GMT) Full text and rfc822 format available.

Message #30 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 71037 <at> debbugs.gnu.org
Subject: Re: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Sun, 23 Jun 2024 23:12:18 -0400
Hi Nicolas,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi Nicolas,
>
> Nicolas Graves <ngraves <at> ngraves.fr> writes:
>
>> On 2024-05-20 22:40, Maxim Cournoyer wrote:
>>
>>> Hello!
>>>
>>> Nicolas Graves <ngraves <at> ngraves.fr> writes:
>>>
>>>> Nicolas Graves (3):
>>>>   gnu: python-pydevd: Move to pyproject-build-system.
>>>>   gnu: python-pydevd: Update to 2.9.6.
>>>>   gnu: python-pydevd: Improve package style.
>>>>
>>>
>>> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>
>>>
>>> Also, thanks for refreshing/resubmitting the pydevd patch to upstream!
>>
>> As a comment for my debugpy patch : we should probably care about that
>> too: https://github.com/microsoft/debugpy/issues/1585
>>
>> Until this gets a proper answer, we should probably only update to
>> 1.8.0, although I don't see why this should really diverge given the
>> commits.
>>
>> I can't work on this today, but feel free to rebase the patch in 1.8.0
>> (should be easy, not much changes). Otherwise, I'll do it, but probably
>> not before next week.
>
> I'm not in a position to push on this right now, so I'll let you lead
> the charge, even if that's in a week or two.  Thanks for doing so!

Did you have a chance to work on this remaining detail?  It's a great
series!

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Mon, 24 Jun 2024 07:51:02 GMT) Full text and rfc822 format available.

Message #33 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 71037 <at> debbugs.gnu.org
Subject: Re: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Mon, 24 Jun 2024 09:50:26 +0200
On 2024-06-23 23:12, Maxim Cournoyer wrote:

> Did you have a chance to work on this remaining detail?  It's a great
> series!

I have rebased on 1.8.0 instead of 1.8.1 indeed. The issue now is that
it breaks ipykernel which needs an update and its update requires going
through python-team branch.

We should thus apply them (70995 and 71037) in python-team, which is
quite a mess to work with when you don't have commit access. I have some
time this week, maybe the right thing to do would be to apply for commit
access and rebase python-team myself.

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Mon, 24 Jun 2024 13:20:01 GMT) Full text and rfc822 format available.

Message #36 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 71037 <at> debbugs.gnu.org
Subject: Re: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Mon, 24 Jun 2024 09:18:43 -0400
Hi!

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> On 2024-06-23 23:12, Maxim Cournoyer wrote:
>
>> Did you have a chance to work on this remaining detail?  It's a great
>> series!
>
> I have rebased on 1.8.0 instead of 1.8.1 indeed. The issue now is that
> it breaks ipykernel which needs an update and its update requires going
> through python-team branch.
>
> We should thus apply them (70995 and 71037) in python-team, which is
> quite a mess to work with when you don't have commit access. I have some
> time this week, maybe the right thing to do would be to apply for commit
> access and rebase python-team myself.

That'd be worth it I think!  I encourage you to broadcast your intention
to guix-devel and ask/gather for 3 committers to vouch for you so that
we can make it a reality.

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Sat, 29 Jun 2024 07:01:01 GMT) Full text and rfc822 format available.

Message #39 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 71037 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Sat, 29 Jun 2024 02:00:12 -0500
> > time this week, maybe the right thing to do would be to apply for commit
> > access and rebase python-team myself.

Hi Nicolas,

I agree and I can vouch for you. Feel free to CC me if you need when
going through that process.

all the best,

jgart




Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Thu, 28 Nov 2024 22:22:02 GMT) Full text and rfc822 format available.

Message #42 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 71037 <at> debbugs.gnu.org
Subject: [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Thu, 28 Nov 2024 22:20:37 +0000
[Message part 1 (text/plain, inline)]
Hi Nicolas,

While reviewing a long list of your patches and applying them on
python-team I would say I can vouch for your as well ^.^

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#71037; Package guix-patches. (Wed, 18 Dec 2024 21:35:01 GMT) Full text and rfc822 format available.

Message #45 received at 71037 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 71037 <at> debbugs.gnu.org, "Nicolas Graves" <ngraves <at> ngraves.fr>
Subject: Re: [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Wed, 18 Dec 2024 21:34:34 +0000
Hi Nicolas,

Should this issue be closed as well? Looks like we have a newer version now in master.

all best,

jgart

PS

Are you still considering to apply for commit access? 

Guix wants you ;()
https://up.nixnet.services/7zlfj5wg.png




Reply sent to jgart <jgart <at> dismail.de>:
You have taken responsibility. (Wed, 15 Jan 2025 03:44:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Graves <ngraves <at> ngraves.fr>:
bug acknowledged by developer. (Wed, 15 Jan 2025 03:44:02 GMT) Full text and rfc822 format available.

Message #50 received at 71037-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 71037-done <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>, Nicolas Graves <ngraves <at> ngraves.fr>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Date: Tue, 14 Jan 2025 21:43:28 -0600
Closing this ticket as obsolete.

Feel free to open a new one for latest updates to python-pydevd and
related packages.
-- 
all the best,
jgart




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 12 Feb 2025 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 146 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.