GNU logs - #71085, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#71085: text-scale-adjust does not adjust margin width
Resent-From: Emre Yolcu <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 21 May 2024 00:04:02 +0000
Resent-Message-ID: <handler.71085.B.171624982916307 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71085 <at> debbugs.gnu.org
Feedback-ID: i1b09467c:Fastmail
From: Emre Yolcu <mail@HIDDEN>
Content-Type: text/plain;
	charset=us-ascii;
	delsp=yes;
	format=flowed
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Message-Id: <C7031EF2-EBCF-42B6-A79E-B1EA6B4F37FD@HIDDEN>
Date: Mon, 20 May 2024 18:50:28 -0400
Received-SPF: pass client-ip=103.168.172.157; envelope-from=mail@HIDDEN;
 helo=fhigh6-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Mailman-Approved-At: Mon, 20 May 2024 20:03:46 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

As of Emacs 29.3, changing the text size in a buffer using  
text-scale-adjust has no affect on margin width. Since the text displayed  
in the margins has the same height as the text in the buffer, this  
behavior causes the text in the margin to be clipped if we increase the  
text size too much by using text-scale-adjust. Here are the steps to  
confirm:

1. Launch with "emacs -Q".
2. Evaluate:

   (set-window-fringes nil 0)
   (set-window-margins nil 1)

3. Switch to a scratch buffer.
4. Place the cursor, which should be box-shaped by default, on the  
first-column of the buffer.
5. Increase the text size in the buffer by pressing C-x C-= several times.

   Expected behavior: Left margin has exactly the same width as that of the cursor.
   Current behavior: Left margin has width much smaller than that of the cursor.

It also seems to me that there is no way to work around this problem in  
the Elisp layer, because text-scale-mode works by remapping faces in a  
buffer-local manner; however,
- there is no face defined for the margins, and
- it seems that the pixel width of the margins is not determined in a  
buffer-local manner.

Given that {left,right}-margin-width are buffer-local variables, I would  
expect their pixel width to be determined in a buffer-local manner.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Emre Yolcu <mail@HIDDEN>
Subject: bug#71085: Acknowledgement (text-scale-adjust does not adjust
 margin width)
Message-ID: <handler.71085.B.171624982916307.ack <at> debbugs.gnu.org>
References: <C7031EF2-EBCF-42B6-A79E-B1EA6B4F37FD@HIDDEN>
X-Gnu-PR-Message: ack 71085
X-Gnu-PR-Package: emacs
Reply-To: 71085 <at> debbugs.gnu.org
Date: Tue, 21 May 2024 00:04:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 71085 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
71085: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71085
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#71085: text-scale-adjust does not adjust margin width
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 21 May 2024 11:39:02 +0000
Resent-Message-ID: <handler.71085.B71085.17162915197572 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Emre Yolcu <mail@HIDDEN>
Cc: 71085 <at> debbugs.gnu.org
Date: Tue, 21 May 2024 14:38:19 +0300
Message-Id: <86r0dv8kes.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <C7031EF2-EBCF-42B6-A79E-B1EA6B4F37FD@HIDDEN> (message
 from Emre Yolcu on Mon, 20 May 2024 18:50:28 -0400)
References: <C7031EF2-EBCF-42B6-A79E-B1EA6B4F37FD@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

tags 71085 notabug
thanks

> From: Emre Yolcu <mail@HIDDEN>
> Date: Mon, 20 May 2024 18:50:28 -0400
> 
> As of Emacs 29.3, changing the text size in a buffer using  
> text-scale-adjust has no affect on margin width. Since the text displayed  
> in the margins has the same height as the text in the buffer, this  
> behavior causes the text in the margin to be clipped if we increase the  
> text size too much by using text-scale-adjust. Here are the steps to  
> confirm:
> 
> 1. Launch with "emacs -Q".
> 2. Evaluate:
> 
>    (set-window-fringes nil 0)
>    (set-window-margins nil 1)
> 
> 3. Switch to a scratch buffer.
> 4. Place the cursor, which should be box-shaped by default, on the  
> first-column of the buffer.
> 5. Increase the text size in the buffer by pressing C-x C-= several times.
> 
>    Expected behavior: Left margin has exactly the same width as that of the cursor.
>    Current behavior: Left margin has width much smaller than that of the cursor.

I don't understand the expectations: the window and frame geometry are
not changed by text-scale-adjust, so why did you expect the window
margins to change?  The margins are part of the window geometry.

Since Emacs 29.1, we have global-text-scale-adjust-resizes-frames,
which, if non-nil, causes the frame to resize when you change the
text-size globally (e.g., with C-M-+ or C-M-mouse-wheel).  If you do
that, the window-margins resize as well, which in this case is indeed
expected (and works for me).

> It also seems to me that there is no way to work around this problem in  
> the Elisp layer, because text-scale-mode works by remapping faces in a  
> buffer-local manner; however,
> - there is no face defined for the margins, and
> - it seems that the pixel width of the margins is not determined in a  
> buffer-local manner.
> 
> Given that {left,right}-margin-width are buffer-local variables, I would  
> expect their pixel width to be determined in a buffer-local manner.

The above is inaccurate: the text shown in the margin can have its own
distinct face.  For example, try this in "emacs -Q":

  M-x font-lock-mode RET
  M-<
  M-: (set-window-margins nil 4 4) RET
  M-: (add-text-properties (point) (1+ (point)) (list 'display (list '(margin left-margin) (propertize "FOO" 'face 'warning)))) RET

You will see the string "FOO" displayed in the margin with a distinct
face.  You could define this face to have an absolute :height
attribute, in which case the text in the margin will not scale, and
thus will not be clipped when you use text-size-adjust.  So there _is_
in fact a way to work around, even if you don't want to use
global-text-scale-adjust-resizes-frames and the globalized
text-scaling.

I see no bug here.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 May 2024 11:38:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 21 07:38:40 2024
Received: from localhost ([127.0.0.1]:48696 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s9NpH-0001y5-Fr
	for submit <at> debbugs.gnu.org; Tue, 21 May 2024 07:38:39 -0400
Received: from eggs.gnu.org ([209.51.188.92]:54716)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>)
 id 1s9NpC-0001xu-Ce; Tue, 21 May 2024 07:38:37 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1s9Np1-000884-FD; Tue, 21 May 2024 07:38:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=e9MoNcgq9nydniRVv0+DQ7cTto266uBQAJjSV71ANaQ=; b=KLrvZ+PW5/0J
 cf96cuNFaIp78X4TzId/O2RfeEmAdpHZgCf6P9llHhKH762+V+Ne6o17iha6cu1S0gt/7OnvicmiA
 2XTp3UnHNfLVZ3NSGSSqMJ49iL2oW0f6kRgSmIjol3zsCkRVsep9qugdKGu59hgOU/nffqnlAlZtb
 ZnnRh2tPVbVPrSPcRyla8VDTiniaIKfx0Ch0nVUbQC7gxe6pVnmFzEPoT60y1FIuS9L8FrWDMY6r4
 eFPrIkyaOBl98GH3v4TALSz+w8yLxPbk5S1mYdWLOVEl8OJt/XjcWZ8hOgmM34lo2vLRue4dQTKny
 b/crQa9LVWgqPae8jPBQHw==;
Date: Tue, 21 May 2024 14:38:19 +0300
Message-Id: <86r0dv8kes.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Emre Yolcu <mail@HIDDEN>
In-Reply-To: <C7031EF2-EBCF-42B6-A79E-B1EA6B4F37FD@HIDDEN> (message
 from Emre Yolcu on Mon, 20 May 2024 18:50:28 -0400)
Subject: Re: bug#71085: text-scale-adjust does not adjust margin width
References: <C7031EF2-EBCF-42B6-A79E-B1EA6B4F37FD@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: 71085 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 71085 notabug
thanks

> From: Emre Yolcu <mail@HIDDEN>
> Date: Mon, 20 May 2024 18:50:28 -0400
> 
> As of Emacs 29.3, changing the text size in a buffer using  
> text-scale-adjust has no affect on margin width. Since the text displayed  
> in the margins has the same height as the text in the buffer, this  
> behavior causes the text in the margin to be clipped if we increase the  
> text size too much by using text-scale-adjust. Here are the steps to  
> confirm:
> 
> 1. Launch with "emacs -Q".
> 2. Evaluate:
> 
>    (set-window-fringes nil 0)
>    (set-window-margins nil 1)
> 
> 3. Switch to a scratch buffer.
> 4. Place the cursor, which should be box-shaped by default, on the  
> first-column of the buffer.
> 5. Increase the text size in the buffer by pressing C-x C-= several times.
> 
>    Expected behavior: Left margin has exactly the same width as that of the cursor.
>    Current behavior: Left margin has width much smaller than that of the cursor.

I don't understand the expectations: the window and frame geometry are
not changed by text-scale-adjust, so why did you expect the window
margins to change?  The margins are part of the window geometry.

Since Emacs 29.1, we have global-text-scale-adjust-resizes-frames,
which, if non-nil, causes the frame to resize when you change the
text-size globally (e.g., with C-M-+ or C-M-mouse-wheel).  If you do
that, the window-margins resize as well, which in this case is indeed
expected (and works for me).

> It also seems to me that there is no way to work around this problem in  
> the Elisp layer, because text-scale-mode works by remapping faces in a  
> buffer-local manner; however,
> - there is no face defined for the margins, and
> - it seems that the pixel width of the margins is not determined in a  
> buffer-local manner.
> 
> Given that {left,right}-margin-width are buffer-local variables, I would  
> expect their pixel width to be determined in a buffer-local manner.

The above is inaccurate: the text shown in the margin can have its own
distinct face.  For example, try this in "emacs -Q":

  M-x font-lock-mode RET
  M-<
  M-: (set-window-margins nil 4 4) RET
  M-: (add-text-properties (point) (1+ (point)) (list 'display (list '(margin left-margin) (propertize "FOO" 'face 'warning)))) RET

You will see the string "FOO" displayed in the margin with a distinct
face.  You could define this face to have an absolute :height
attribute, in which case the text in the margin will not scale, and
thus will not be clipped when you use text-size-adjust.  So there _is_
in fact a way to work around, even if you don't want to use
global-text-scale-adjust-resizes-frames and the globalized
text-scaling.

I see no bug here.

Last modified: Tue, 21 May 2024 11:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.