GNU bug report logs - #7118
24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: "Drew Adams" <drew.adams@HIDDEN>; dated Mon, 27 Sep 2010 18:46:03 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 7118 <at> debbugs.gnu.org:


Received: (at 7118) by debbugs.gnu.org; 2 Aug 2011 21:12:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 02 17:12:46 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QoMGc-0005A3-Jn
	for submit <at> debbugs.gnu.org; Tue, 02 Aug 2011 17:12:46 -0400
Received: from rcsinet15.oracle.com ([148.87.113.117])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1QoMGa-00059u-FD
	for 7118 <at> debbugs.gnu.org; Tue, 02 Aug 2011 17:12:44 -0400
Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237])
	by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id
	p72LCBop014408
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Tue, 2 Aug 2011 21:12:13 GMT
Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158])
	by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
	p72LCAEq003171
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 2 Aug 2011 21:12:11 GMT
Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62])
	by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id
	p72LC7r6006801; Tue, 2 Aug 2011 16:12:08 -0500
Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive
	Gateway v4.0) with ESMTP ; Tue, 02 Aug 2011 14:11:46 -0700
THREAD-INDEX: AcxEKM1CKuHtohEYSqWbL9GS8mDIywNL81iw
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6109
MIME-Version: 1.0
Message-ID: <5B1509F3414B4493B0CC29BAEED357E3@HIDDEN>
Date: Tue, 2 Aug 2011 14:11:46 -0700 (PDT)
From: Drew Adams <drew.adams@HIDDEN>
To: "'Stefan Monnier'" <monnier@HIDDEN>, "'Lars Magne Ingebrigtsen'"
	<larsi@HIDDEN>
Subject: RE: bug#7118: 24.0.50;dired-subdir-alist, dired-directory, etc.:
	necessarily buffer-local
References: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN><jwvsk0ux5ja.fsf-monnier+emacs@HIDDEN><m34o2p3pub.fsf@HIDDEN><CAAeL0SQtd7aLUR8e244L++piEbjZosB_F0Qoy4rWTNG9ie3-MA@HIDDEN><m3ipr4zzm8.fsf@HIDDEN>
	<jwvk4bhzlxe.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwvk4bhzlxe.fsf-monnier+emacs@HIDDEN>
X-Mailer: Microsoft Office Outlook 11
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Source-IP: acsinet21.oracle.com [141.146.126.237]
X-Auth-Type: Internal IP
X-CT-RefId: str=0001.0A090207.4E38682D.00EC:SCFMA922111,ss=1,re=-4.000,fgs=0
X-Spam-Score: -4.2 (----)
X-Debbugs-Envelope-To: 7118
Cc: 'Juanma Barranquero' <lekktu@HIDDEN>, 7118 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.2 (----)

Please don't forget this part of the bug report, which has been ignored so far:

> Still, we should mention in the doc string of
> `dired-subdir-alist' that the subdirs are subdirs of 
> `dired-directory'.





Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.
Severity set to 'wishlist' from 'minor' Request was from Lars Magne Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 7118 <at> debbugs.gnu.org:


Received: (at 7118) by debbugs.gnu.org; 17 Jul 2011 02:24:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 22:24:46 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QiH2D-0002i6-Cb
	for submit <at> debbugs.gnu.org; Sat, 16 Jul 2011 22:24:45 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.181]
	helo=ironport2-out.pppoe.ca)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <monnier@HIDDEN>) id 1QiH2B-0002ht-Bl
	for 7118 <at> debbugs.gnu.org; Sat, 16 Jul 2011 22:24:43 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av0EAJpHIk5MCqt8/2dsb2JhbABSp3V4iHzBEIY8BJ8nhDA
X-IronPort-AV: E=Sophos;i="4.67,215,1309752000"; d="scan'208";a="126229815"
Received: from 76-10-171-124.dsl.teksavvy.com (HELO ceviche.home)
	([76.10.171.124])
	by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA;
	16 Jul 2011 22:24:37 -0400
Received: by ceviche.home (Postfix, from userid 20848)
	id 96EBE660D5; Sat, 16 Jul 2011 22:24:37 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Lars Magne Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#7118: 24.0.50;
	dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Message-ID: <jwvk4bhzlxe.fsf-monnier+emacs@HIDDEN>
References: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
	<jwvsk0ux5ja.fsf-monnier+emacs@HIDDEN>
	<m34o2p3pub.fsf@HIDDEN>
	<CAAeL0SQtd7aLUR8e244L++piEbjZosB_F0Qoy4rWTNG9ie3-MA@HIDDEN>
	<m3ipr4zzm8.fsf@HIDDEN>
Date: Sat, 16 Jul 2011 22:24:37 -0400
In-Reply-To: <m3ipr4zzm8.fsf@HIDDEN> (Lars Magne Ingebrigtsen's
	message of "Thu, 14 Jul 2011 16:49:19 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.1 (--)
X-Debbugs-Envelope-To: 7118
Cc: Juanma Barranquero <lekktu@HIDDEN>, 7118 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.1 (--)

>> But IMHO, neither changing `revert-buffer-function' nor
>> `dired-subdir-alist' and `dired-directory' is really a bug fix.  Yes,
>> as they are now is error prone, but the uses in the sources are
>> already correct. That should be a wishlist item for 24.2.

Indeed.  Also always be extra careful that none of the `setq'
(resulting from removal of make-local-variable) can run before the
make-variable-buffer-local.  This is usually trivially the case, but
problems can appear if the setq is within an autoloaded expression or
when several files are involved.


        Stefan




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.

Message received at 7118 <at> debbugs.gnu.org:


Received: (at 7118) by debbugs.gnu.org; 14 Jul 2011 14:50:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 14 10:50:37 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QhNFM-0007sg-E6
	for submit <at> debbugs.gnu.org; Thu, 14 Jul 2011 10:50:37 -0400
Received: from hermes.netfonds.no ([80.91.224.195])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <larsi@HIDDEN>) id 1QhNFK-0007sR-R3
	for 7118 <at> debbugs.gnu.org; Thu, 14 Jul 2011 10:50:35 -0400
Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]
	helo=quimbies.gnus.org)
	by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.72) (envelope-from <larsi@HIDDEN>)
	id 1QhNF9-0008IZ-LX; Thu, 14 Jul 2011 16:50:23 +0200
From: Lars Magne Ingebrigtsen <larsi@HIDDEN>
To: Juanma Barranquero <lekktu@HIDDEN>
Subject: Re: bug#7118: 24.0.50;
	dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
In-Reply-To: <CAAeL0SQtd7aLUR8e244L++piEbjZosB_F0Qoy4rWTNG9ie3-MA@HIDDEN>
	(Juanma Barranquero's message of "Thu, 14 Jul 2011 16:45:28 +0200")
Date: Thu, 14 Jul 2011 16:49:19 +0200
Message-ID: <m3ipr4zzm8.fsf@HIDDEN>
References: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
	<jwvsk0ux5ja.fsf-monnier+emacs@HIDDEN>
	<m34o2p3pub.fsf@HIDDEN>
	<CAAeL0SQtd7aLUR8e244L++piEbjZosB_F0Qoy4rWTNG9ie3-MA@HIDDEN>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU4UokADkMACj4ACT0A
	CDwADD+C3i9YAAACfklEQVQ4jT1UgZXrIAwjf4KYKwNgYICj6QAHzgCQeP9Vvpy05V5zryjGsiTq
	CMvzWSv7yHmvm+xP1amOruUjURj4N3MvJehRPsDAI1IIPHPloT8fYBbGcyXOtf9OvPA5iutwzi0U
	qhZ8DfqpOOPqbPmeWqShLABsI/O174LkxoEOuYHVbc0tq50VH02L6gUQDX+C0QVQZg165g+Q6VHJ
	rQBKimHws7sRSDV1khrdam+psUfFUNKU/36EaVkxiYcIeooBQ2eOZ8eEbqwh1DpKBsCq3IUEn3X5
	xTFJuFgFChT9pEpc/YjWPWl+0wWtlmokDiVQliRiQDDBfU21xCwlermXMyUVr/EWEnNUZulb38AK
	Ug5KG8fAAPC35asCY5Thxdiufl18lt42A6YWno9N4uLcP/OSmB75psvDwyjT0Ax2Z0u9sUPniZiw
	AebBuqSbFRedxFzpttBMu4FkLnO/K257Ryllc0UHGDPfFr+BWtj8GGDM6/csRKbNijnCsNGc/5SQ
	nzVbfNRiFJcQ723Ym5qwM0FCAXBXLJiQQKo56EOzImXv7pfje29uMsYdSPq7w4JgZ0EAFUS1zPwF
	IKhIf7nZ6YfLlL8PQIXr0dTNF8aDikj1YoFDvWrAjTJSuFosRLeMYfIezpcBeGW2XnV1yC+ITGyN
	C3juUJShylRalnAMmgCIjleZrXAiZ+OHlkbYEGqywSeXdPUXV5FJyldKMDhDhdwwC8IavwDvz6fI
	BktxpRd0M7XcdUUlV6hg2sV/eHwBPebWdZrV8edbgf1wHKm2KwR/OAoGnQD0HjFdId9xyQRtrULH
	/dvA1mMHH7ECAOO6kOG5vaw5QXOYLvIfWvOxLtPqDYAAAAAASUVORK5CYII=
X-Now-Playing: Joni Mitchell's _Blue_: "All I Want"
X-Hashcash: 1:23:110714:7118 <at> debbugs.gnu.org::J59MU+XujbNk9RTw:000000000000000000000000000000000000000001NDp
X-Hashcash: 1:23:110714:monnier@HIDDEN::vltKiMB26zrdTvuV:0000000000000000000000000000000000000CMLr
X-Hashcash: 1:23:110714:lekktu@HIDDEN::o5nF8qzZks6R9lSR:1QTYx
MIME-Version: 1.0
Content-Type: text/plain
X-MailScanner-ID: 1QhNF9-0008IZ-LX
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@HIDDEN
MailScanner-NULL-Check: 1311259823.73447@yNhFXOwUauk0rnm9u/8clQ
X-Spam-Status: No
X-Spam-Score: -2.7 (--)
X-Debbugs-Envelope-To: 7118
Cc: 7118 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.7 (--)

Juanma Barranquero <lekktu@HIDDEN> writes:

> But IMHO, neither changing `revert-buffer-function' nor
> `dired-subdir-alist' and `dired-directory' is really a bug fix. Yes,
> as they are now is error prone, but the uses in the sources are
> already correct. That should be a wishlist item for 24.2.

Yeah, that's true.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.

Message received at 7118 <at> debbugs.gnu.org:


Received: (at 7118) by debbugs.gnu.org; 14 Jul 2011 14:46:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 14 10:46:16 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QhNBA-0007my-1X
	for submit <at> debbugs.gnu.org; Thu, 14 Jul 2011 10:46:16 -0400
Received: from mail-pv0-f172.google.com ([74.125.83.172])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lekktu@HIDDEN>) id 1QhNB8-0007ml-8I
	for 7118 <at> debbugs.gnu.org; Thu, 14 Jul 2011 10:46:14 -0400
Received: by pvh18 with SMTP id 18so315576pvh.3
	for <7118 <at> debbugs.gnu.org>; Thu, 14 Jul 2011 07:46:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=gmF+pS6lXWk1s0WtgqfDQx9ZOCRkmnzNUtwcYffYJ/8=;
	b=KeWRkOIviASpMqtEJpibkReC1o7I9vW3+UsX5Mp2JttqhpfD/FawbsRfLRTELs7f/2
	E56jAru5TmMBqHX6LOX/2CQDDcSvCmSLdPx310PrZp2eDc5MeHUqgiA2jde/N9+4jCz0
	lN82qZHZr0mTmLfsBwxD8Sxc9o8pMVXBhbvPs=
Received: by 10.142.120.1 with SMTP id s1mr1038354wfc.252.1310654768135; Thu,
	14 Jul 2011 07:46:08 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.144.4 with HTTP; Thu, 14 Jul 2011 07:45:28 -0700 (PDT)
In-Reply-To: <m34o2p3pub.fsf@HIDDEN>
References: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
	<jwvsk0ux5ja.fsf-monnier+emacs@HIDDEN>
	<m34o2p3pub.fsf@HIDDEN>
From: Juanma Barranquero <lekktu@HIDDEN>
Date: Thu, 14 Jul 2011 16:45:28 +0200
Message-ID: <CAAeL0SQtd7aLUR8e244L++piEbjZosB_F0Qoy4rWTNG9ie3-MA@HIDDEN>
Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.:
	necessarily buffer-local
To: Lars Magne Ingebrigtsen <larsi@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -3.4 (---)
X-Debbugs-Envelope-To: 7118
Cc: 7118 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.4 (---)

> What's the best way to make this change? =C2=A0Just say
>
> (make-variable-buffer-local 'var)
>
> after the `defvar', and then removing all the `make-local-variable'
> calls?

Yes.

BTW, it's a mystery to me why `revert-buffer-function' is not
automatically buffer-local, when every single package that sets it
does so locally; having a global non-nil revert-buffer-function does
not make any sense whatsoever.

But IMHO, neither changing `revert-buffer-function' nor
`dired-subdir-alist' and `dired-directory' is really a bug fix. Yes,
as they are now is error prone, but the uses in the sources are
already correct. That should be a wishlist item for 24.2.

=C2=A0 =C2=A0 Juanma




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.

Message received at 7118 <at> debbugs.gnu.org:


Received: (at 7118) by debbugs.gnu.org; 14 Jul 2011 14:32:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 14 10:32:18 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QhMxa-0006Wk-EU
	for submit <at> debbugs.gnu.org; Thu, 14 Jul 2011 10:32:18 -0400
Received: from hermes.netfonds.no ([80.91.224.195])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <larsi@HIDDEN>) id 1QhMxR-0006VK-9l
	for 7118 <at> debbugs.gnu.org; Thu, 14 Jul 2011 10:32:09 -0400
Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]
	helo=quimbies.gnus.org)
	by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.72) (envelope-from <larsi@HIDDEN>)
	id 1QhMx0-0007qv-1w; Thu, 14 Jul 2011 16:31:38 +0200
From: Lars Magne Ingebrigtsen <larsi@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#7118: 24.0.50;
	dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
In-Reply-To: <jwvsk0ux5ja.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
	of "Mon, 27 Sep 2010 23:05:00 +0200")
Date: Thu, 14 Jul 2011 16:21:32 +0200
Message-ID: <m34o2p3pub.fsf@HIDDEN>
References: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
	<jwvsk0ux5ja.fsf-monnier+emacs@HIDDEN>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
X-Now-Playing: Depeche Mode's _A Question of Lust_: "A Question of Lust"
X-Hashcash: 1:23:110714:drew.adams@HIDDEN::G6bEaQAMXnDcL/76:00000000000000000000000000000000000000006v7u
X-Hashcash: 1:23:110714:monnier@HIDDEN::NxF4ZievUWhsTBi2:0000000000000000000000000000000000000NOk1
X-Hashcash: 1:23:110714:7118 <at> debbugs.gnu.org::TUadkeUxlMjGyShv:00000000000000000000000000000000000000000y7iD
MIME-Version: 1.0
Content-Type: text/plain
X-MailScanner-ID: 1QhMx0-0007qv-1w
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@HIDDEN
MailScanner-NULL-Check: 1311258698.30495@EFsxmOP/aftr0fgi3+udiQ
X-Spam-Status: No
X-Spam-Score: -2.7 (--)
X-Debbugs-Envelope-To: 7118
Cc: 7118 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.7 (--)

Stefan Monnier <monnier@HIDDEN> writes:

>> We should use `make-variable-buffer-local' with vars such as
>> `dired-subdir-alist' and `dired-directory', instead of just calling
>> `make-local-variable'.
>
> Sounds OK.

What's the best way to make this change?  Just say

(make-variable-buffer-local 'var)

after the `defvar', and then removing all the `make-local-variable'
calls?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.

Message received at 7118 <at> debbugs.gnu.org:


Received: (at 7118) by debbugs.gnu.org; 27 Sep 2010 23:33:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 27 19:33:09 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1P0NC0-0002Yl-GV
	for submit <at> debbugs.gnu.org; Mon, 27 Sep 2010 19:33:08 -0400
Received: from mail-iw0-f172.google.com ([209.85.214.172])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lekktu@HIDDEN>) id 1P0NBy-0002YO-H3
	for 7118 <at> debbugs.gnu.org; Mon, 27 Sep 2010 19:33:07 -0400
Received: by iwn3 with SMTP id 3so5108098iwn.3
	for <7118 <at> debbugs.gnu.org>; Mon, 27 Sep 2010 16:35:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:mime-version:received:in-reply-to
	:references:from:date:message-id:subject:to:cc:content-type
	:content-transfer-encoding;
	bh=+PL+cdvs6tj8GV4uF/aa6uvoIyBGiKX1Z446hODR3tA=;
	b=ChsjwBVFtSrqpbAiREW7n7ObJ7blEGgXKoN6irNRFl1yL0KPLidnwWcAcmQ6T/hfnl
	wymij0PobdtpmmpNcSvFz98UvuQYrC2OBC1mA1Ptjx46uWAimRYvQOojsm+UUpbMruvP
	Rox0xaZaXeKAciE5RFpiwLf915AQwLkc4UgeA=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	b=qjyCHD78wHHPtnb3hCfMsLPwnaoCfqISgDdHqRXncnupT/pCTcFMew9pBoZBCie9W/
	LAC3MEskRyYz9qjVpI8/nG9Ok/0KdSBEt172U/DYfBDZsJJu9aT3oaWu2WJYD75itIYx
	FWXxi1RhMmUQYEw1KeTPtasvsfXDdtJLkT/mk=
Received: by 10.231.144.74 with SMTP id y10mr9874101ibu.65.1285630552271; Mon,
	27 Sep 2010 16:35:52 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.196.71 with HTTP; Mon, 27 Sep 2010 16:35:12 -0700 (PDT)
In-Reply-To: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
References: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
From: Juanma Barranquero <lekktu@HIDDEN>
Date: Tue, 28 Sep 2010 01:35:12 +0200
Message-ID: <AANLkTim=NwY82rFqO+X6QVMicUcoBJPkcxW8--=TWEic@HIDDEN>
Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.:
	necessarily buffer-local
To: Drew Adams <drew.adams@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.7 (--)
X-Debbugs-Envelope-To: 7118
Cc: 7118 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.7 (--)

On Mon, Sep 27, 2010 at 20:47, Drew Adams <drew.adams@HIDDEN> wrote:

> We should use `make-variable-buffer-local' with vars such as
> `dired-subdir-alist' and `dired-directory', instead of just calling
> `make-local-variable'. =C2=A0Why? =C2=A0Because these vars MUST be buffer=
 local,
> and we might as well make the code clearer by pointing that out. =C2=A0Th=
at
> is precisely the use case for `make-variable-buffer-local': a var that
> is necessarily buffer-local.

On the same vein, every single use of revert-buffer-function starts with

  (make-local-variable 'revert-buffer-function)
  (setq revert-buffer-function XXXXX)

or

  (set (make-local-variable 'revert-buffer-function) XXXXXX)

except the one in dired-x.el, which relies in dired-mode doing it
before. There have been at least three bugs in the past year caused by
revert-buffer-function not being automatically buffer-local.

=C2=A0 =C2=A0 Juanma




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.

Message received at 7118 <at> debbugs.gnu.org:


Received: (at 7118) by debbugs.gnu.org; 27 Sep 2010 21:02:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 27 17:02:12 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1P0Kpw-0001Ye-8Z
	for submit <at> debbugs.gnu.org; Mon, 27 Sep 2010 17:02:12 -0400
Received: from fencepost.gnu.org ([140.186.70.10])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <monnier@HIDDEN>) id 1P0Kpu-0001YZ-SX
	for 7118 <at> debbugs.gnu.org; Mon, 27 Sep 2010 17:02:11 -0400
Received: from dyn.83-228-217-009.dsl.vtx.ch ([83.228.217.9]:14253
	helo=fmsmemgm.homelinux.net)
	by fencepost.gnu.org with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <monnier@HIDDEN>)
	id 1P0Ksc-0005Wc-Uk; Mon, 27 Sep 2010 17:04:59 -0400
Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848)
	id EECA46611D; Mon, 27 Sep 2010 23:05:00 +0200 (CEST)
From: Stefan Monnier <monnier@HIDDEN>
To: "Drew Adams" <drew.adams@HIDDEN>
Subject: Re: bug#7118: 24.0.50;
	dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Message-ID: <jwvsk0ux5ja.fsf-monnier+emacs@HIDDEN>
References: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
Date: Mon, 27 Sep 2010 23:05:00 +0200
In-Reply-To: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN> (Drew Adams's
	message of "Mon, 27 Sep 2010 11:47:39 -0700")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: 7118
Cc: 7118 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.1 (-----)

> We should use `make-variable-buffer-local' with vars such as
> `dired-subdir-alist' and `dired-directory', instead of just calling
> `make-local-variable'.

Sounds OK.


        Stefan




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 Sep 2010 18:45:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 27 14:45:02 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1P0IhB-0000bn-NB
	for submit <at> debbugs.gnu.org; Mon, 27 Sep 2010 14:45:01 -0400
Received: from eggs.gnu.org ([140.186.70.92])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1P0Ih9-0000bX-Oc
	for submit <at> debbugs.gnu.org; Mon, 27 Sep 2010 14:45:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1P0Ijr-0007Eg-EQ
	for submit <at> debbugs.gnu.org; Mon, 27 Sep 2010 14:47:48 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
	T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([199.232.76.165]:50262)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1P0Ijr-0007Ec-8t
	for submit <at> debbugs.gnu.org; Mon, 27 Sep 2010 14:47:47 -0400
Received: from [140.186.70.92] (port=36887 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0Ijq-0004ai-2d
	for bug-gnu-emacs@HIDDEN; Mon, 27 Sep 2010 14:47:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1P0Ijo-0007Dx-PN
	for bug-gnu-emacs@HIDDEN; Mon, 27 Sep 2010 14:47:45 -0400
Received: from rcsinet10.oracle.com ([148.87.113.121]:33110)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1P0Ijo-0007Dj-Id
	for bug-gnu-emacs@HIDDEN; Mon, 27 Sep 2010 14:47:44 -0400
Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125])
	by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id
	o8RIlf8v030295
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <bug-gnu-emacs@HIDDEN>; Mon, 27 Sep 2010 18:47:43 GMT
Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155])
	by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id
	o8RIgrBb000794
	for <bug-gnu-emacs@HIDDEN>; Mon, 27 Sep 2010 18:47:41 GMT
Received: from abhmt004.oracle.com by acsmt354.oracle.com
	with ESMTP id 640730431285613258; Mon, 27 Sep 2010 11:47:38 -0700
Received: from dradamslap1 (/130.35.178.194)
	by default (Oracle Beehive Gateway v4.0)
	with ESMTP ; Mon, 27 Sep 2010 11:47:38 -0700
From: "Drew Adams" <drew.adams@HIDDEN>
To: <bug-gnu-emacs@HIDDEN>
Subject: 24.0.50;
	dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Date: Mon, 27 Sep 2010 11:47:39 -0700
Message-ID: <B53179EFF1B54D4EA98E63D1B3DD2602@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 11
Thread-Index: ActedHWdZ8VRbaNdT7yU3uwVdwQ6kg==
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Spam-Score: -6.3 (------)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.3 (------)

We should use `make-variable-buffer-local' with vars such as
`dired-subdir-alist' and `dired-directory', instead of just calling
`make-local-variable'.  Why?  Because these vars MUST be buffer local,
and we might as well make the code clearer by pointing that out.  That
is precisely the use case for `make-variable-buffer-local': a var that
is necessarily buffer-local.
 
Also, the doc strings are otherwise incomplete/vague: for
`dired-subdir-alist', for example, it speaks of "the buffer".  The var's
value is local to each particular Dired buffer, and this needs to be
made more clear.  If we use `make-variable-buffer-local' that will add
the necessary info to `C-h v' so that the doc strings begin to make
sense.  (Still, we should mention in the doc string of
`dired-subdir-alist' that the subdirs are subdirs of `dired-directory'.)
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-09-20 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
 





Acknowledgement sent to "Drew Adams" <drew.adams@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:
bug#7118; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.