GNU logs - #71193, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#71193: Shepherd fails to start a system when given an incorrect form to the start field of any service
Resent-From: "Picnoir" <picnoir@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 25 May 2024 07:37:01 +0000
Resent-Message-ID: <handler.71193.B.171662258825972 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71193 <at> debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
From: "Picnoir" <picnoir@HIDDEN>
Date: Sat, 25 May 2024 09:33:55 +0200
Message-ID: <87fru6uyzg.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2001:4b98:dc4:8::227;
 envelope-from=picnoir@HIDDEN; helo=relay7-d.mail.gandi.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

Hey Guix,

I'm facing a pretty annoying Shepherd 0.10.4 bug.

If a service start script gets provided an incorrect form, such as an
empty quoted list, Shepherd hangs during its early startup and bricks
the overall Guix system.

I think the following snippet is a good minimal reproducer for this. Add
this service to a guix system configuration:

--8<---------------cut here---------------start------------->8---
(simple-service
 'shepherd-bug-repro
 shepherd-root-service-type
 (list (shepherd-service
        (documentation "shepherd hang minimal repro")
        (provision '(shepherd-bug-repro))
        (requirement '())
        (start #~('())))))
u--8<---------------cut here---------------end--------------->8---

=E2=9A=A0 DO NOT BOOT ON A CRITICAL SYSTEM WITH THIS SERVICE, IT'LL BRICK I=
T =E2=9A=A0

You can create a VM for this system and start it. The VM hangs after the
log line "creating /etc/machine-id...", before any shepherd service gets
started.

You get the same behaviour if you end up booting by misfortune a "real"
system having this service.=20

Instead of having the whole system to freeze, I'd expect shepherd to
fail the particular service having an incorrect start form.

I'm not sure what's happening here. I did not manage to diagnose this furth=
er,
the shepherd does not seem to be super chatty at this stage of the boot.

Tested on Shepherd 0.10.4 with the Guix revision
c5e63e19ac672f9e63fc8ee98fa9a16f978ce19c.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Picnoir" <picnoir@HIDDEN>
Subject: bug#71193: Acknowledgement (Shepherd fails to start a system when
 given an incorrect form to the start field of any service)
Message-ID: <handler.71193.B.171662258825972.ack <at> debbugs.gnu.org>
References: <87fru6uyzg.fsf@HIDDEN>
X-Gnu-PR-Message: ack 71193
X-Gnu-PR-Package: guix
Reply-To: 71193 <at> debbugs.gnu.org
Date: Sat, 25 May 2024 07:37:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 71193 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
71193: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71193
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#71193: Shepherd fails to start a system when given an incorrect form to the start field of any service
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Wed, 26 Jun 2024 13:49:02 +0000
Resent-Message-ID: <handler.71193.B71193.17194096862996 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Picnoir" <picnoir@HIDDEN>
Cc: 71193 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <87fru6uyzg.fsf@HIDDEN> (picnoir@HIDDEN's
 message of "Sat, 25 May 2024 09:33:55 +0200")
References: <87fru6uyzg.fsf@HIDDEN>
Date: Wed, 26 Jun 2024 15:47:52 +0200
Message-ID: <87msn7byt3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Picnoir,

"Picnoir" <picnoir@HIDDEN> skribis:

> I think the following snippet is a good minimal reproducer for this. Add
> this service to a guix system configuration:
>
> --8<---------------cut here---------------start------------->8---
> (simple-service
>  'shepherd-bug-repro
>  shepherd-root-service-type
>  (list (shepherd-service
>         (documentation "shepherd hang minimal repro")
>         (provision '(shepherd-bug-repro))
>         (requirement '())
>         (start #~('())))))
> u--8<---------------cut here---------------end--------------->8---
>
> =E2=9A=A0 DO NOT BOOT ON A CRITICAL SYSTEM WITH THIS SERVICE, IT'LL BRICK=
 IT =E2=9A=A0
>
> You can create a VM for this system and start it. The VM hangs after the
> log line "creating /etc/machine-id...", before any shepherd service gets
> started.

[...]

> Tested on Shepherd 0.10.4 with the Guix revision
> c5e63e19ac672f9e63fc8ee98fa9a16f978ce19c.

This sounds very much like <https://issues.guix.gnu.org/71144>, which
was fixed in Guix commit cca25a67693bb68a1884a081b415a43fad1e8641,
shortly after the commit you mention.

I tested the reproducer you posted in a VM and it boots fine.  The
problem simply leads to an error message in /var/log/messages:

--8<---------------cut here---------------start------------->8---
Jun 26 15:43:09 localhost vmunix: [    3.574026] shepherd[1]: Exception cau=
ght while loading '/gnu/store/c44hd3gfksalrbsgc3a0ax4v9jmnkzb4-shepherd-she=
pherd-bug-repro.go': #<&compound-exception components: (#<&assertion-failur=
e> #<&origin origin: #f> #<&message message: "Wrong type to apply: ~S"> #<&i
Jun 26 15:43:09 localhost vmunix: [    3.574132] rritants irritants: (())> =
#<&exception-with-kind-and-args kind: wrong-type-arg args: (#f "Wrong type =
to apply: ~S" (()) (()))>)>
Jun 26 15:43:09 localhost vmunix: [    3.583838] shepherd[1]: starting serv=
ices...
Jun 26 15:43:09 localhost vmunix: [    3.585444] shepherd[1]: Configuration=
 successfully loaded from '/gnu/store/8cch4dv5ca1v0hsgyr6d8jay513x7d8g-shep=
herd.conf'.
--8<---------------cut here---------------end--------------->8---

=E2=80=A6 and of course the faulty service doesn=E2=80=99t show up at all i=
n =E2=80=98herd
status=E2=80=99.

Could you confirm it=E2=80=99s fine for you?

Thanks,
Ludo=E2=80=99.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 22 Jul 2024 07:21:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 22 03:21:38 2024
Received: from localhost ([127.0.0.1]:56751 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sVnMX-0000jB-U7
	for submit <at> debbugs.gnu.org; Mon, 22 Jul 2024 03:21:38 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:46036)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1sVnMV-0000iz-Uy
 for control <at> debbugs.gnu.org; Mon, 22 Jul 2024 03:21:36 -0400
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id A90C920D
 for <control <at> debbugs.gnu.org>; Mon, 22 Jul 2024 09:20:57 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id noRFiAtqwgQd for <control <at> debbugs.gnu.org>;
 Mon, 22 Jul 2024 09:20:57 +0200 (CEST)
Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 4587C1E3
 for <control <at> debbugs.gnu.org>; Mon, 22 Jul 2024 09:20:57 +0200 (CEST)
Date: Mon, 22 Jul 2024 09:20:55 +0200
Message-Id: <87o76pki3s.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #71193
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

close 71193 
quit

Last modified: Mon, 22 Jul 2024 07:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.