GNU bug report logs - #71228
[PATCH] gnu: guile-ncurses unicode fix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71228 in the body.
You can then email your comments to 71228 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: tmarjeski <at> gmail.com
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: guile-ncurses unicode fix
Date: Mon, 27 May 2024 18:34:47 +0300

[0001-gnu-guile-ncurses-fix-configure-flags-for-unicode-bu.patch (text/x-patch, inline)]

From 10c8622694ce0c6141b5a827e4ffddcd47f9d4b8 Mon Sep 17 00:00:00 2001
From: Trevor Arjeski <tmarjeski <at> gmail.com>
Date: Mon, 27 May 2024 18:22:33 +0300
Subject: [PATCH] gnu: guile-ncurses: fix configure-flags for unicode build

The flag "--with-ncursesw" doesn't seem to exist for guile-ncurses, and it
seemed to cause the build to not include unicode support. Building without it
produces the expected "with ncursesw" support.

This can be checked within the guile REPL using:
> ,use (ncurses curses)
> %wide-ncurses
> #t ; has unicode and wide char support
---
 gnu/packages/guile-xyz.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 44b4118e0a..8276380fc3 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2718,8 +2718,7 @@ (define-public guile-ncurses
                   (guix build utils))
        #:imported-modules ((guix build guile-build-system)
                            ,@%gnu-build-system-modules)
-       #:configure-flags (list "--with-ncursesw" ; Unicode support
-                               "--with-gnu-filesystem-hierarchy")
+       #:configure-flags (list "--with-gnu-filesystem-hierarchy")
        #:phases
        (modify-phases %standard-phases
          (add-before 'build 'fix-libguile-ncurses-file-name
-- 
2.45.1

Message #8 received at 71228 <at> debbugs.gnu.org (full text, mbox):

From: tmarjeski <at> gmail.com
To: 71228 <at> debbugs.gnu.org
Cc: zimon.toutoune <at> gmail.com, paren <at> disroot.org, ludo <at> gnu.org, me <at> tobias.gr,
 rekado <at> elephly.net, jgart <at> dismail.de, othacehe <at> gnu.org, guix <at> cbaines.net
Subject: [PATCH] gnu: guile-ncurses unicode fix
Date: Sun, 02 Jun 2024 11:18:55 +0300

Hi folks,
I recieved an email about someone else wanting this change and was
wondering if it could be looked at.

Thanks!

Message #13 received at 71228-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: tmarjeski <at> gmail.com
Cc: 71228-done <at> debbugs.gnu.org
Subject: Re: [bug#71228] [PATCH] gnu: guile-ncurses unicode fix
Date: Thu, 11 Jul 2024 12:43:35 +0200

Hi,

tmarjeski <at> gmail.com skribis:

>>From 10c8622694ce0c6141b5a827e4ffddcd47f9d4b8 Mon Sep 17 00:00:00 2001
> From: Trevor Arjeski <tmarjeski <at> gmail.com>
> Date: Mon, 27 May 2024 18:22:33 +0300
> Subject: [PATCH] gnu: guile-ncurses: fix configure-flags for unicode build
>
> The flag "--with-ncursesw" doesn't seem to exist for guile-ncurses, and it
> seemed to cause the build to not include unicode support. Building without it
> produces the expected "with ncursesw" support.
>
> This can be checked within the guile REPL using:
>> ,use (ncurses curses)
>> %wide-ncurses
>> #t ; has unicode and wide char support

I tweaked the commit log to match our conventions and finally applied
it, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.