GNU bug report logs - #71269
[PATCH 1/2] sdiff: Match execvp argument types

Previous Next

To reply to this bug, email your comments to 71269 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Khem Raj <raj.khem <at> gmail.com>
To: bug-diffutils <at> gnu.org
Cc: Khem Raj <raj.khem <at> gmail.com>
Subject: [PATCH 1/2] sdiff: Match execvp argument types
Date: Wed, 29 May 2024 21:55:24 -0700

Fixes build with GCC-14

../../diffutils-3.10/src/sdiff.c:579:28: error: passing argument 2 of '_execvp' from incompatible pointer type [-Wincompatible-pointer-types]
  579 |       execvp (diffargv[0], (char **) diffargv);
      |                            ^~~~~~~~~~~~~~~~~~
      |                            |
      |                            char **

* src/sdiff.c (main): execpv expects const pointer.

Upstream-Status: Submitted [https://lists.gnu.org/archive/html/diffutils-devel/2024-05/msg00000.html]
Signed-off-by: Khem Raj <raj.khem <at> gmail.com>
---
 src/sdiff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sdiff.c b/src/sdiff.c
index 0b638d4..a4642b1 100644
--- a/src/sdiff.c
+++ b/src/sdiff.c
@@ -576,7 +576,7 @@ main (int argc, char *argv[])
       diffarg (argv[optind]);
       diffarg (argv[optind + 1]);
       diffarg (0);
-      execvp (diffargv[0], (char **) diffargv);
+      execvp (diffargv[0], diffargv);
       perror_fatal (diffargv[0]);
     }
   else
-- 
2.45.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Khem Raj <raj.khem <at> gmail.com>
To: bug-diffutils <at> gnu.org
Cc: Khem Raj <raj.khem <at> gmail.com>
Subject: [PATCH 2/2] Define stricoll as _stricoll on mingw
Date: Wed, 29 May 2024 21:55:25 -0700

* src/system.h: Define stricoll as _stricoll on mingw.

Upstream-Status: Submitted [https://lists.gnu.org/archive/html/diffutils-devel/2024-05/msg00001.html]
Signed-off-by: Khem Raj <raj.khem <at> gmail.com>
---
 src/system.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/system.h b/src/system.h
index b37893f..4c7a318 100644
--- a/src/system.h
+++ b/src/system.h
@@ -63,6 +63,16 @@
 #include <inttypes.h>
 
 #include <string.h>
+/* stricoll is not provided by any headers on windows/mingw
+   only _stricoll is provided, the function is however aliased
+   to provide stricoll in runtime libraries, the configure check
+   to detect stricoll defines the prototype in generated test
+   itself and thus test passes, however compiling fails with
+   GCC-14 which enables implicit-function-declaration as error  */ 
+#if defined _WIN32 && ! defined __CYGWIN__
+#define stricoll _stricoll
+#endif
+
 #if ! HAVE_STRCASECOLL
 # if HAVE_STRICOLL || defined stricoll
 #  define strcasecoll(a, b) stricoll (a, b)
-- 
2.45.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.