Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 71284) by debbugs.gnu.org; 6 Jun 2024 06:24:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 06 02:24:22 2024 Received: from localhost ([127.0.0.1]:41720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF6Xu-00014R-IB for submit <at> debbugs.gnu.org; Thu, 06 Jun 2024 02:24:22 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:33915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sF6Xt-000147-Gi for 71284 <at> debbugs.gnu.org; Thu, 06 Jun 2024 02:24:21 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 44DE41C0004; Thu, 6 Jun 2024 06:23:59 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell In-Reply-To: <28afde26-8d83-8b5f-b617-a2797ea5e1fc@HIDDEN> (Jim Porter's message of "Wed, 5 Jun 2024 18:52:15 -0700") Organization: LINKOV.NET References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> <868qzq1n3r.fsf@HIDDEN> <e4149664-81c5-da5a-ecd6-3b07412f1665@HIDDEN> <86frtvrgtn.fsf@HIDDEN> <52b77c3b-f556-b436-c8c5-1f157681fa53@HIDDEN> <86o78i4j8u.fsf@HIDDEN> <28afde26-8d83-8b5f-b617-a2797ea5e1fc@HIDDEN> Date: Thu, 06 Jun 2024 09:19:52 +0300 Message-ID: <865xumpp87.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71284 Cc: 71284 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> The multi-line headers have such disadvantage that the outlines >> are not compact anymore. Also multi-line headers might have >> more technial issues with displaying an ellipsis at the end. > > Given that you mentioned a few other cases where multi-line headers might > be nice (assuming the number of lines is small), maybe it would make sense > to see what an implementation of that looks like. I'll see about writing > a patch for this. It would be nice to solve this long-standing problem. > (Another interesting thing I might try is to see if we could provide some > custom single-line abbreviation for multi-line headers. That would let us > have compact headers when they're collapsed, even if the "header" part is > really multiple lines when expanded.) Or maybe showing an outline should also show its pre-heading lines (maybe this would require adding e.g. outline-pre-header-regexp that matches the first line of such preface lines). This would be especially useful in cases when there are dozens of comment lines before the outline heading with the function name in programming language modes.
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.Received: (at 71284) by debbugs.gnu.org; 6 Jun 2024 01:59:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 05 21:59:51 2024 Received: from localhost ([127.0.0.1]:56440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF2Pu-00073Q-KB for submit <at> debbugs.gnu.org; Wed, 05 Jun 2024 21:59:51 -0400 Received: from mail-yw1-f176.google.com ([209.85.128.176]:51667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sF2Ps-000738-Bo for 71284 <at> debbugs.gnu.org; Wed, 05 Jun 2024 21:59:49 -0400 Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-627f3265898so4117297b3.3 for <71284 <at> debbugs.gnu.org>; Wed, 05 Jun 2024 18:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717639108; x=1718243908; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=djK4hG6LKK/oyHicD5sc+cfJ0JRgOTjFJtj9KHqBYRI=; b=iWOVAA6MEAZkanv2pXd3jJoiH7bc68yZhCfyFTL7oIL4mfk2vYHuApwTwt2WZh0U4k z5EBHRBMwSb8sqpjju51TITRp1vfORqeHpTwWMrtQAPJJaTA36cgTNNL14eJcrpZ/PHn M/8nL6bLUCGofMnIiaqciMNopEIVj05vuyMFudwCCFUCpLegR1yF1OE9/hRTARS3T2Wu 6AuvfyUHNseN/UJPdXjnzjwyqHpOryTHOFMMnv7LF5qtE9zfealHmfWJV8LcK7rXu91V exiEmAFKO6hKny9Gg137nuvzL6kD+8x8X13Mm9LsqkVyu7mboGTBM6hECQ+Z+QumWRpn p+4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717639108; x=1718243908; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=djK4hG6LKK/oyHicD5sc+cfJ0JRgOTjFJtj9KHqBYRI=; b=Xv//el2Kbd/DQ54zZgp4VZWNa+DMbmTa320njo3gdedSP/Fc4TdzeYjzhrmIapiqqf 0rPkmWu1AFHYCSxdauGrX7rzwrmvH4AeCTu6uA7H8pJQHIRkA5OTiPEFWRQQrRJQ77pz VguNkpgQ3QeYUV+ZNeoWKUDT9EVMcc1rdkOpQ+1aLSn870i2h2I6kZ2p3xcqvGhLL/4K fPhJKp7bDYhB/i90TpMpHQj5uPZXi2/IJ+2EIjr10431i4gsD4Vf5Ud+cW4lgubNFesq hkLJXFFJTb2D/0nMKeUB9iomD3h6at4vtEHTt8toXCBzfQRBR4RXpBOQQ7zcpUr16s8K AhSA== X-Gm-Message-State: AOJu0Yz1hS0xJXlvVqeXCnDf0/LHxVXEZkXPoX9LAzKduV6JpeeEvf3P kyVxsCkwPl1tTW6WA9wJM7B/sjWHRQ4gP93En/jfFieu2bb8imjMSKbWYQ== X-Google-Smtp-Source: AGHT+IFvswOcLQrwAzAoNV4ndW+qIWnWeTPCYaiqCjbJLZZSbXK0cSfbHBbrynWKV9STB2Qj4pGCPw== X-Received: by 2002:a17:902:ea06:b0:1f3:39f8:7e7f with SMTP id d9443c01a7336-1f6a59ffe74mr48379945ad.14.1717638736690; Wed, 05 Jun 2024 18:52:16 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f6bd7cd297sm2139005ad.165.2024.06.05.18.52.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 18:52:16 -0700 (PDT) Message-ID: <28afde26-8d83-8b5f-b617-a2797ea5e1fc@HIDDEN> Date: Wed, 5 Jun 2024 18:52:15 -0700 MIME-Version: 1.0 Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell Content-Language: en-US To: Juri Linkov <juri@HIDDEN> References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> <868qzq1n3r.fsf@HIDDEN> <e4149664-81c5-da5a-ecd6-3b07412f1665@HIDDEN> <86frtvrgtn.fsf@HIDDEN> <52b77c3b-f556-b436-c8c5-1f157681fa53@HIDDEN> <86o78i4j8u.fsf@HIDDEN> From: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <86o78i4j8u.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71284 Cc: 71284 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 6/2/2024 11:45 PM, Juri Linkov wrote: >> In any case, the more I think about this, the more my current patch seems >> like the wrong way to go about this. Even just describing the user-facing >> behavior in all scenarios is pretty complex, so I think it might be better >> to keep it simple and have a single outline level. >> >> That said, for the multi-line prompt case, I wonder if it would make sense >> for outline.el to support multi-line headers. If I could mark the entire >> prompt + command input as a "header", then collapsing it would look better: >> users would still see all of their input in the collapsed node. > > The multi-line headers have such disadvantage that the outlines > are not compact anymore. Also multi-line headers might have > more technial issues with displaying an ellipsis at the end. Given that you mentioned a few other cases where multi-line headers might be nice (assuming the number of lines is small), maybe it would make sense to see what an implementation of that looks like. I'll see about writing a patch for this. (Another interesting thing I might try is to see if we could provide some custom single-line abbreviation for multi-line headers. That would let us have compact headers when they're collapsed, even if the "header" part is really multiple lines when expanded.)
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.
Received: (at 71284) by debbugs.gnu.org; 3 Jun 2024 07:17:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 03:17:39 2024
Received: from localhost ([127.0.0.1]:53370 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sE1wo-00019c-LE
for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 03:17:39 -0400
Received: from mslow1.mail.gandi.net ([217.70.178.240]:38571)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1sE1wm-00019I-1U
for 71284 <at> debbugs.gnu.org; Mon, 03 Jun 2024 03:17:37 -0400
Received: from relay6-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::226])
by mslow1.mail.gandi.net (Postfix) with ESMTP id A5DFFC118D
for <71284 <at> debbugs.gnu.org>; Mon, 3 Jun 2024 06:53:23 +0000 (UTC)
Received: by mail.gandi.net (Postfix) with ESMTPSA id C4ED5C0003;
Mon, 3 Jun 2024 06:53:02 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Jim Porter <jporterbugs@HIDDEN>
Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode
to Eshell
In-Reply-To: <52b77c3b-f556-b436-c8c5-1f157681fa53@HIDDEN> (Jim Porter's
message of "Sun, 2 Jun 2024 21:34:14 -0700")
Organization: LINKOV.NET
References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN>
<868qzq1n3r.fsf@HIDDEN>
<e4149664-81c5-da5a-ecd6-3b07412f1665@HIDDEN>
<86frtvrgtn.fsf@HIDDEN>
<52b77c3b-f556-b436-c8c5-1f157681fa53@HIDDEN>
Date: Mon, 03 Jun 2024 09:45:37 +0300
Message-ID: <86o78i4j8u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 71284
Cc: 71284 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> In any case, the more I think about this, the more my current patch seems
> like the wrong way to go about this. Even just describing the user-facing
> behavior in all scenarios is pretty complex, so I think it might be better
> to keep it simple and have a single outline level.
>
> That said, for the multi-line prompt case, I wonder if it would make sense
> for outline.el to support multi-line headers. If I could mark the entire
> prompt + command input as a "header", then collapsing it would look better:
> users would still see all of their input in the collapsed node.
The multi-line headers have such disadvantage that the outlines
are not compact anymore. Also multi-line headers might have
more technial issues with displaying an ellipsis at the end.
> It would look something like so:
>
> v /home/user/dir
> $ cat some-file.txt
> output
> output
> output
>
> > /home/user/dir
> $ cat some-file.txt...
This is a known problem. Recently I had to add a special handling
in c-ts-mode--outline-predicate to put the outline heading on the
line with the function name instead of the first line with types:
static void
v bset_mode_name (struct buffer *b, Lisp_Object val)
{
b->mode_name_ = val;
}
static void
v bset_name (struct buffer *b, Lisp_Object val)
{
b->name_ = val;
}
In your case you could do something similar in eshell-outline-search
to put the outline heading on the meaningful line:
/home/user/dir
v $ cat some-file.txt
output
output
output
This is not ideal either since the first line belongs to the
previous outline. This is a known problem too. For example,
in etc/NEWS, the top +++ is not part of the outline, e.g.
+++
*** 'outline-minor-mode' is supported in tree-sitter major modes.
It can be used in all tree-sitter major modes that set either the
variable 'treesit-simple-imenu-settings' or 'treesit-outline-predicate'.
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.
Received: (at 71284) by debbugs.gnu.org; 3 Jun 2024 04:35:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 00:35:36 2024
Received: from localhost ([127.0.0.1]:41548 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sDzPz-0007al-Q1
for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 00:35:36 -0400
Received: from mail-pj1-f44.google.com ([209.85.216.44]:61688)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jporterbugs@HIDDEN>) id 1sDzPx-0007aO-Ek
for 71284 <at> debbugs.gnu.org; Mon, 03 Jun 2024 00:35:34 -0400
Received: by mail-pj1-f44.google.com with SMTP id
98e67ed59e1d1-2bfdae7997aso3081808a91.2
for <71284 <at> debbugs.gnu.org>; Sun, 02 Jun 2024 21:35:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1717389255; x=1717994055; darn=debbugs.gnu.org;
h=content-transfer-encoding:in-reply-to:from:references:cc:to
:content-language:subject:mime-version:date:message-id:from:to:cc
:subject:date:message-id:reply-to;
bh=5ZOSxeY8ucNvOrqA08ysgbsfc26S2FcH3wUrHRkrmS0=;
b=ZAxboKV05WdxlzZZmvYmKx2C9A6uo9AxPmfoqR+N1PTUnXFAuhTGKYNIXIPxJoJZwH
VcWqEoX378iIV/VT6FNU7qomHHZIcyyhsV8Hlf6WA3n6/wuapr6DdmyZFFXvJjq/Q+qE
1wHa6pgTv0T+cgIPwsgZFKwRD9Jc8E6OhVnBiKib7bW/SRcqpYrGdEu4Xjvf2ug4yx+8
GxvjmIHbzynZIlosUw8iMPSmfL8BAOfMRzXbUQsQMU2GeagM3ZNzgQ6xF3t2R1VygYfS
cu4TPCEtn953dvFRdJl+HnclP4zczrsarH2QbbFna2KHXJ1U0kALuQR8SHsLKXaSiO2Y
Sv5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1717389255; x=1717994055;
h=content-transfer-encoding:in-reply-to:from:references:cc:to
:content-language:subject:mime-version:date:message-id
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=5ZOSxeY8ucNvOrqA08ysgbsfc26S2FcH3wUrHRkrmS0=;
b=wk7IjMijbHAI7pC5lVt1RyT72p44VfJVsoEmlFUrKSYTK5i5W59ZpN1ESOCTVmwYku
fjRxWpiwzJrnEbKAdwz7++SUYURzOS+U0+H3fAFNhN4r331kHHeA/1gWJ4+APU5fT2mb
xodIWPQI6EzQ+9j1F9UrM5yl7zcQprZF+S9Njen6o73AU6qJBe2GjS6uOBc94UHhpZbn
aDix1YQ/BnUrV2zd+aseXZe1ny2YcRb2dBLhICYleNP624R4dkVFHZeRrTkvfIuiuVjU
/KRJExqo39SRKmqxpAs872dRmjVV5nUOdyuETPLkwUgIg9JDiE6/sCA84XI+iPZfoq51
bC9g==
X-Gm-Message-State: AOJu0YwqkhOkr/x8Q0KUqH8D7YI4ED8fnaLW0g6OZOAoIf/SieWKXp1Z
49B1MP7Q02EvcxsDIJEYedC+y1BlosTgOM/TDEXUE5R+R9l2E/vt
X-Google-Smtp-Source: AGHT+IH9rQVO5BX1/4DDN5LAoVCLIn0GKz7hSeBXAMyoyiwSTGXNoSzWIVLrSUWJJYLvaM58JDA7sw==
X-Received: by 2002:a17:90b:505:b0:2c1:e54a:19b9 with SMTP id
98e67ed59e1d1-2c1e54a1a65mr6445251a91.21.1717389254707;
Sun, 02 Jun 2024 21:34:14 -0700 (PDT)
Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com.
[23.240.98.37]) by smtp.googlemail.com with ESMTPSA id
98e67ed59e1d1-2c238690cbdsm918280a91.0.2024.06.02.21.34.14
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 02 Jun 2024 21:34:14 -0700 (PDT)
Message-ID: <52b77c3b-f556-b436-c8c5-1f157681fa53@HIDDEN>
Date: Sun, 2 Jun 2024 21:34:14 -0700
MIME-Version: 1.0
Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to
Eshell
Content-Language: en-US
To: Juri Linkov <juri@HIDDEN>
References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN>
<868qzq1n3r.fsf@HIDDEN>
<e4149664-81c5-da5a-ecd6-3b07412f1665@HIDDEN>
<86frtvrgtn.fsf@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <86frtvrgtn.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71284
Cc: 71284 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 6/1/2024 11:37 PM, Juri Linkov wrote:
> Sorry, I still don't understand why do you need two levels.
> Is it because in Eshell prompts are often multi-line?
I'm not sure if Eshell prompts are *often* multi-line, but personally I
use multi-line prompts everywhere I can. Maybe I'm just over-optimizing
for my own personal preferences here.
> IIUC, with two levels, the case when the output is empty has such problems
> that one line will contain two outline headers, that also means
> two conflicting margin arrows on the same line?
The way I implemented this, this problem wouldn't come up: if the output
is completely empty, there's no second-level node in the outline for
that command.
>> For prompts, this isn't as important, since a single-line prompt should
>> always have some visible text. For multi-line prompts, it would be possible
>> to treat the heading as the first non-empty line, but that would be
>> additional work on the Eshell side, and I think we'd still need the
>> outline.el changes to handle collapsing the command output. (Improving
>> heading-detection for multi-line prompts could always be done in a later
>> bug, too.)
>
> So the outline.el changes are required only to handle empty output lines?
> That essentially means adding support for two outline headers
> on the same line?
To be more precise, the outline.el changes would be required to handle
the case where a command's output *begins* with one or more newlines. So
the total output isn't empty, but the first *line* of it is.
In any case, the more I think about this, the more my current patch
seems like the wrong way to go about this. Even just describing the
user-facing behavior in all scenarios is pretty complex, so I think it
might be better to keep it simple and have a single outline level.
That said, for the multi-line prompt case, I wonder if it would make
sense for outline.el to support multi-line headers. If I could mark the
entire prompt + command input as a "header", then collapsing it would
look better: users would still see all of their input in the collapsed
node. It would look something like so:
v /home/user/dir
$ cat some-file.txt
output
output
output
> /home/user/dir
$ cat some-file.txt...
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.Received: (at 71284) by debbugs.gnu.org; 2 Jun 2024 06:51:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 02 02:51:18 2024 Received: from localhost ([127.0.0.1]:57715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDf3l-0007vi-TU for submit <at> debbugs.gnu.org; Sun, 02 Jun 2024 02:51:18 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sDf3j-0007vR-T0 for 71284 <at> debbugs.gnu.org; Sun, 02 Jun 2024 02:51:16 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id D5EFCE0002; Sun, 2 Jun 2024 06:50:36 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell In-Reply-To: <e4149664-81c5-da5a-ecd6-3b07412f1665@HIDDEN> (Jim Porter's message of "Fri, 31 May 2024 13:02:00 -0700") Organization: LINKOV.NET References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> <868qzq1n3r.fsf@HIDDEN> <e4149664-81c5-da5a-ecd6-3b07412f1665@HIDDEN> Date: Sun, 02 Jun 2024 09:37:08 +0300 Message-ID: <86frtvrgtn.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71284 Cc: 71284 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> This patch adds support for outline-minor-mode to Eshell. When enabled, >>> this will just add outline buttons to the prompt (as the top level), and >>> one to the start of the output (as level 2). > ... > The main case I'm trying to account for is collapsing the command > output. I think the most consistent way for Eshell is to make the "heading" > always be the first line of the output, even if that line is empty. That > way, the arrow button is always in the same spot (immediately after the > prompt/input), and if the output had many leading empty lines, you can > collapse all of them to save space (to be fair, this case probably isn't > super-common). Sorry, I still don't understand why do you need two levels. Is it because in Eshell prompts are often multi-line? IIUC, with two levels, the case when the output is empty has such problems that one line will contain two outline headers, that also means two conflicting margin arrows on the same line? > For prompts, this isn't as important, since a single-line prompt should > always have some visible text. For multi-line prompts, it would be possible > to treat the heading as the first non-empty line, but that would be > additional work on the Eshell side, and I think we'd still need the > outline.el changes to handle collapsing the command output. (Improving > heading-detection for multi-line prompts could always be done in a later > bug, too.) So the outline.el changes are required only to handle empty output lines? That essentially means adding support for two outline headers on the same line?
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.Received: (at 71284) by debbugs.gnu.org; 1 Jun 2024 06:00:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 01 02:00:34 2024 Received: from localhost ([127.0.0.1]:55670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDHn8-0000Gw-2Z for submit <at> debbugs.gnu.org; Sat, 01 Jun 2024 02:00:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sDHn3-0000Gg-Mr for 71284 <at> debbugs.gnu.org; Sat, 01 Jun 2024 02:00:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sDHkg-00061e-SP; Sat, 01 Jun 2024 01:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hj7+TuhuaS5WBoBmyPS3ZJYyv/3yhmu4tty5KYfcmFo=; b=FVUd5TkLb8sw JxU0evGysNJnnVHpKYKkrgbxkPaJpS7GTf6kv7F+7mnyssqaOUno147s36GEwMZ+7TlLaKWvhtks4 q5PdMVAS8fjqV1eCR0rQ1+uX7VDo80sZhx45M/k0gimC8eZcM7wwaGFgIcpEsqy6PDzoSUQIAgnbc SYADpcnUZBxhjErnLnYAFAltpCDn0pYlnGZnqzleyqjUt6/62xbwiVEq3msEIrcSjy4SaRysBojJT /LMrvhyb6OAEwZ6fKkzZAR+CxuppFYdMqMN6UsS8/DhEKWweRoavtB4RqjdcLGMbpVWoF92yXVcRE HmEI78dRy9R3bW2/8ZFQ5w==; Date: Sat, 01 Jun 2024 08:58:00 +0300 Message-Id: <867cf9p5lj.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <29dd5f9d-0467-1a80-438f-a516b20e34e1@HIDDEN> (message from Jim Porter on Fri, 31 May 2024 12:33:32 -0700) Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> <86y17qplcl.fsf@HIDDEN> <29dd5f9d-0467-1a80-438f-a516b20e34e1@HIDDEN> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71284 Cc: 71284 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Fri, 31 May 2024 12:33:32 -0700 > Cc: 71284 <at> debbugs.gnu.org, juri@HIDDEN > From: Jim Porter <jporterbugs@HIDDEN> > > On 5/30/2024 11:05 PM, Eli Zaretskii wrote: > > Seriously, though: since it is completely un-obvious what would > > outline-minor-mode mean for command-line-oriented modes like Eshell, > > both NEWS and the Eshell manual should say at least a couple of words > > about what that does. We cannot get away by just mentioning the > > support and keeping silent about the rest. > > Good point. I'd tried to write some more docs previously but was very > unsatisfied with my attempt. After sleeping on it, I've tried again (see > attached). > > I added a preliminary commit here to move some of the existing docs into > a new "Interaction" section, since I think the manual should really > split out the documentation of commands and their syntax from how to use > Eshell *interactively*. (I split this out since the diff is fairly > large, but the changes aren't all that exciting: it just moves things > from one spot to another, and adds some new index entries.) > > That provides a better spot to explain this new outline-minor-mode > support. I also filled in documentation for a few of the existing > navigation commands available in Eshell. Thanks, LGTM.
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.Received: (at 71284) by debbugs.gnu.org; 31 May 2024 20:03:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 16:03:56 2024 Received: from localhost ([127.0.0.1]:55401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sD8Tk-00081i-3D for submit <at> debbugs.gnu.org; Fri, 31 May 2024 16:03:56 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:52461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sD8Tf-00081D-1u for 71284 <at> debbugs.gnu.org; Fri, 31 May 2024 16:03:55 -0400 Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1f44b42e9a6so19407895ad.0 for <71284 <at> debbugs.gnu.org>; Fri, 31 May 2024 13:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717185754; x=1717790554; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=tS2WXvVbfROFv+96N0ZEuGLIjeN7TelzhyzUM5BI2Vo=; b=K6f5IN8BIE+1zsBbZHGQyAEKZ9qNiUrB0McSF+tJKltVG9GlK44ywHAi2DNWLwsv2C ep4mw5CahQ94jrn80lGpEsphUYOfMlefyAdBcyVs6LZIWCIH+wK70y4qfLXBWJTX1E+P iUCmDF233mlXm7amFop6X3n/LlKZZhaqMP3trCINcXdQ0OTjTT6tLSVuOyxWsDY6ygsY 8xbCzeT3fWgrNG4iaQ4lBmOB9b5/uW2e8fXXWSIPe0Ckd/VlVY6ypJRPZ1YqNXtCt/ft 0LGdxDJ9G5YfFK7ckmhJCNn7JCyjlgGZp2MW1r3qb6Q0AJkmtmbcLkm7h8SfvGgCI2vF mzwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717185754; x=1717790554; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tS2WXvVbfROFv+96N0ZEuGLIjeN7TelzhyzUM5BI2Vo=; b=YakZGaQ6/IeJ8wXEzBsZYlYvf3/Kwdg70OqVzKm+tX4ED+cPz+0RW83iFbzp9bRhIo fqM0ZLLOJDZ81+YRahJtGmWmkEa+NQm9NWBo55w1XE1gFxxa1mJdb6BRxmyb7tjH8jrv kxBvb1SYkoeqjvpEhBn5duTZ40xxxeBzrdOTFgWppXKVjqN3TR5UFYo90i/bVIG7cvXF HblP4mVN6MWfr1ceyv3NzfUNEtbPTfdxlhOzU+CXE3iTEthppvw7gpAisZ2QRhfGm2DH bi6stho2mQuEfIIxagE7T+cIND9mxu43bAfkEIe346G94Er4xxkFGt6mri45Wzf9vkYK 1kMA== X-Gm-Message-State: AOJu0Yxc4AKORs4tvCPmhE6yl+FaoinO8VdX1s+mBlwH3QXfe5AH7UXu bSA8Qxyjq+iIdXHzDtCmES3daZctdvFRvJZaqNId6eFRi7bVS5QDEhyXLg== X-Google-Smtp-Source: AGHT+IEORbkMYVWypgOFxvulbuZnTdT9+IcjS21bCWCDPCh4JCKnXcnkYa6HUR13Jowhq0jD2+W4og== X-Received: by 2002:a17:903:2c9:b0:1f4:5ad1:b65e with SMTP id d9443c01a7336-1f637029152mr37298805ad.34.1717185753704; Fri, 31 May 2024 13:02:33 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f63235aab4sm20419695ad.71.2024.05.31.13.02.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 May 2024 13:02:18 -0700 (PDT) Message-ID: <e4149664-81c5-da5a-ecd6-3b07412f1665@HIDDEN> Date: Fri, 31 May 2024 13:02:00 -0700 MIME-Version: 1.0 Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell Content-Language: en-US To: Juri Linkov <juri@HIDDEN> References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> <868qzq1n3r.fsf@HIDDEN> From: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <868qzq1n3r.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71284 Cc: 71284 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 5/30/2024 11:51 PM, Juri Linkov wrote: >> This patch adds support for outline-minor-mode to Eshell. When enabled, >> this will just add outline buttons to the prompt (as the top level), and >> one to the start of the output (as level 2). > > I'm not familiar with Eshell, so I tried in shell-mode to set > (setq-local outline-regexp "^.*\\$ ") and it works nicely > (for the real use it should be based on 'shell-prompt-pattern'). > > But I believe you had a good reason to prefer outline-search-function > and more changes in outline.el to support outlines in Eshell. Yeah, I've been trying to reduce Eshell's reliance on simple regexps like that to determine the structure of the content. Since Eshell runs entirely within Emacs, we have the knowledge to authoritatively determine what parts of the buffer are what (you can do this in Eshell by examining the 'field' property). Regexps always run a (small?) risk of false-positives, and would additionally require users to update the regexp when they update their prompt. >> The Eshell side is hopefully fairly straightforward, but the outline.el >> part probably warrants a close review. The changes in outline.el are all >> there to support outline headings that are just a newline and nothing >> else. This is important for both the output (you might call a command that >> prints a newline as the first character), and the prompt (the first >> character of your prompt could be a newline as a way of separating the >> prompt from the output just above it).[1] > > I don't understand why do you need an outline heading for the empty line. > Is it really useful for hide/show an empty line? The main case I'm trying to account for is collapsing the command output. I think the most consistent way for Eshell is to make the "heading" always be the first line of the output, even if that line is empty. That way, the arrow button is always in the same spot (immediately after the prompt/input), and if the output had many leading empty lines, you can collapse all of them to save space (to be fair, this case probably isn't super-common). For prompts, this isn't as important, since a single-line prompt should always have some visible text. For multi-line prompts, it would be possible to treat the heading as the first non-empty line, but that would be additional work on the Eshell side, and I think we'd still need the outline.el changes to handle collapsing the command output. (Improving heading-detection for multi-line prompts could always be done in a later bug, too.) >> I'm open to adding regression tests here since the logic is pretty subtle, >> but I didn't see any existing ones for outline.el and it's not immediately >> obvious the best way to test its behavior. Let me know if anyone has ideas >> though. > > Adding regression tests would be nice since the changes in outline.el > don't look trivial. I guess tests for outline.el should do two basic things: > call various outline commands (perhaps just outline-cycle and outline-cycle-buffer > should be sufficient) with various settings of outline variables, > then 'invisible-p' could check if outline visibility is satisfied. > Or we could prefer a lazy approach to install changes, then to add tests > only in case when a regression will be discovered later. Thanks for the ideas. I think it would be good to add some tests here, so if you agree with my reasoning for the outline.el changes, I'll start writing a few regression tests.
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.Received: (at 71284) by debbugs.gnu.org; 31 May 2024 19:34:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 15:34:56 2024 Received: from localhost ([127.0.0.1]:55378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sD81f-0006yI-6I for submit <at> debbugs.gnu.org; Fri, 31 May 2024 15:34:56 -0400 Received: from mail-pf1-f177.google.com ([209.85.210.177]:49291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sD81b-0006xx-Ha for 71284 <at> debbugs.gnu.org; Fri, 31 May 2024 15:34:53 -0400 Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-702342c60dfso1478832b3a.2 for <71284 <at> debbugs.gnu.org>; Fri, 31 May 2024 12:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717184014; x=1717788814; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=IILIaX4Nbfit6gNfeUg2hXDpfoZtfKSgQVFz/TUrcaY=; b=Z9jgVUGz6F1Wys7XlO4B4wpWiTI2s0oztkgEsc+WOM8Er8LqoAHqVS8/HjOuQYSsvh V0bc8Y0mW97b44NpRi1okmxgxjoW3o216MfN3kMGDky+rZstSeirBqz/SldLSzVM/0RI f4EbESr4SDedg0eEhGXBd2DHuBQkpo8kcV1f9rWay8m7uKXWWRL0Q6bipwOYmhPPfG2O VSuVSBiT4icJS+++u8JKHTfULNCeZZjER+HrlQcOm7AfiYfaszj/tEOuZlzDr4RaOsL4 6LhfhH0I3exiFf2eLqqYjPVDNFkRcM0qjGk/UWutK3o3w2sLZHbzNINMH6VgkgH9REQR UKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717184014; x=1717788814; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IILIaX4Nbfit6gNfeUg2hXDpfoZtfKSgQVFz/TUrcaY=; b=GgfmxEBrgZ0BIaMr3UY9JRoO6IEu/bRy6BzP3j+ypdC9t1ZLcUhDE5dqM9whH4giE2 HhBwlh28PlETTY//FhdM+5zUAlO2XLkTzvJ9X9fPz1sssFvB+1YmfA0qa50Y8wNPkOS6 XFjXtMLOOm3JZEPu6PIt5dSXbP4wVL87pb+cMBIGkmhXKbt/6+UbzNfifuhLw65ZuCeY 5N9NslPw254v1stVZura3Febexs4dPnTjaD1NWIQE0ijFkdBeQU6aajkWVWS6X/G0ikl Zmu6EYZh86/EZyFIhyKKZfRHPS90j2NF+EBc/NUFC+BGryuyopG5fOT/Wxm3Tt3UyQQV hUYg== X-Gm-Message-State: AOJu0YziQ7QP3sEcd/2mTGzLHUXawBkewShNIqB55sPtFdnLdpmxoO97 scOBizD2HwKSYQI3B0bTK6cjON6o2XZrRl12hm6Z/ICjCeaGxWYO X-Google-Smtp-Source: AGHT+IGV6GkCoVD/4Pi/ng1XAPD2ETuyJQYKDc/Op0F7tZjiuR0fV84avViqy8GC1KXaLQ/l7RGlGA== X-Received: by 2002:a05:6a20:324a:b0:1a7:a6f3:1827 with SMTP id adf61e73a8af0-1b26f245be2mr2789425637.46.1717184013966; Fri, 31 May 2024 12:33:33 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-6c353f0aef3sm1599419a12.10.2024.05.31.12.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 May 2024 12:33:33 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0noFHICmW7jLdB4d01YoUgEr" Message-ID: <29dd5f9d-0467-1a80-438f-a516b20e34e1@HIDDEN> Date: Fri, 31 May 2024 12:33:32 -0700 MIME-Version: 1.0 Subject: Re: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell Content-Language: en-US To: Eli Zaretskii <eliz@HIDDEN> References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> <86y17qplcl.fsf@HIDDEN> From: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <86y17qplcl.fsf@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71284 Cc: 71284 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------0noFHICmW7jLdB4d01YoUgEr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/30/2024 11:05 PM, Eli Zaretskii wrote: > Seriously, though: since it is completely un-obvious what would > outline-minor-mode mean for command-line-oriented modes like Eshell, > both NEWS and the Eshell manual should say at least a couple of words > about what that does. We cannot get away by just mentioning the > support and keeping silent about the rest. Good point. I'd tried to write some more docs previously but was very unsatisfied with my attempt. After sleeping on it, I've tried again (see attached). I added a preliminary commit here to move some of the existing docs into a new "Interaction" section, since I think the manual should really split out the documentation of commands and their syntax from how to use Eshell *interactively*. (I split this out since the diff is fairly large, but the changes aren't all that exciting: it just moves things from one spot to another, and adds some new index entries.) That provides a better spot to explain this new outline-minor-mode support. I also filled in documentation for a few of the existing navigation commands available in Eshell. --------------0noFHICmW7jLdB4d01YoUgEr Content-Type: text/plain; charset=UTF-8; name="0001-Add-an-Interaction-chapter-to-the-Eshell-manual.patch" Content-Disposition: attachment; filename*0="0001-Add-an-Interaction-chapter-to-the-Eshell-manual.patch" Content-Transfer-Encoding: base64 RnJvbSA4ODc0ZmQ4NGZjMzQwZWI5NjM1N2MzNmFhYzlkMDQzMzY2NDNkMDczIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMzEgTWF5IDIwMjQgMDk6MzY6MDMgLTA3MDAKU3ViamVjdDogW1BB VENIIDEvMl0gQWRkIGFuICJJbnRlcmFjdGlvbiIgY2hhcHRlciB0byB0aGUgRXNoZWxsIG1h bnVhbAoKKiBkb2MvbWlzYy9lc2hlbGwudGV4aSAoSW50ZXJhY3Rpb24pOiBOZXcgY2hhcHRl ci4KKENvbXBsZXRpb24sIEhpc3RvcnkpOiBNb3ZlIGludG8gIkludGVyYWN0aW9uIiBhbmQg YWRkIGtleSBpbmRleGluZy4KKEtleSByZWJpbmRpbmcpOiBBZGQga2V5IGluZGV4aW5nLgoo Q29tbWFuZCBJbmRleCk6IEFkZCB0aGlzIGluZGV4LgotLS0KIGRvYy9taXNjL2VzaGVsbC50 ZXhpIHwgMjA0ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCAxMTAgaW5zZXJ0aW9ucygrKSwgOTQgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvZG9jL21pc2MvZXNoZWxsLnRleGkgYi9kb2MvbWlzYy9lc2hlbGwudGV4 aQppbmRleCA4NzNkMTRhZmYzMi4uMjQwMGJhOTg4YjQgMTAwNjQ0Ci0tLSBhL2RvYy9taXNj L2VzaGVsbC50ZXhpCisrKyBiL2RvYy9taXNjL2VzaGVsbC50ZXhpCkBAIC03OSwxNSArNzks MTQgQEAgVG9wCiAqIENvbW1hbmRzOjoKICogRXhwYW5zaW9uOjoKICogSW5wdXQvT3V0cHV0 OjoKKyogSW50ZXJhY3Rpb246OgogKiBFeHRlbnNpb24gbW9kdWxlczo6CiAqIEJ1Z3MgYW5k IGlkZWFzOjogICAgICAgICAgICAgIEtub3duIHByb2JsZW1zLCBhbmQgZnV0dXJlIGlkZWFz LgogKiBHTlUgRnJlZSBEb2N1bWVudGF0aW9uIExpY2Vuc2U6OiBUaGUgbGljZW5zZSBmb3Ig dGhpcyBkb2N1bWVudGF0aW9uLgogKiBDb25jZXB0IEluZGV4OjoKICogRnVuY3Rpb24gYW5k IFZhcmlhYmxlIEluZGV4OjoKICogQ29tbWFuZCBJbmRleDo6Ci1AaWdub3JlCiAqIEtleSBJ bmRleDo6Ci1AZW5kIGlnbm9yZQogQGVuZCBtZW51CiAKIEBub2RlIEludHJvZHVjdGlvbgpA QCAtMjA4LDggKzIwNyw2IEBAIENvbW1hbmRzCiAqIFZhcmlhYmxlczo6CiAqIEFsaWFzZXM6 OgogKiBSZW1vdGUgQWNjZXNzOjoKLSogSGlzdG9yeTo6Ci0qIENvbXBsZXRpb246OgogKiBD b250cm9sIEZsb3c6OgogKiBTY3JpcHRzOjoKIEBlbmQgbWVudQpAQCAtMTU1Niw5MiArMTU1 Myw2IEBAIFJlbW90ZSBBY2Nlc3MKIHlvdSBjYW4gc2V0IHRoZSBvcHRpb24gQGNvZGV7ZXNo ZWxsLWV4cGxpY2l0LXJlbW90ZS1jb21tYW5kc30gdG8KIEBjb2Rle25pbH0uCiAKLUBub2Rl IEhpc3RvcnkKLUBzZWN0aW9uIEhpc3RvcnkKLUBjbWluZGV4IGhpc3RvcnkKLUB2aW5kZXgg ZXNoZWxsLWhpc3Rvcnktc2l6ZQotVGhlIEBzYW1we2hpc3Rvcnl9IGNvbW1hbmQgc2hvd3Mg YWxsIGNvbW1hbmRzIGtlcHQgaW4gdGhlIGhpc3RvcnkgcmluZwotYXMgbnVtYmVyZWQgbGlz dC4gIElmIHRoZSBoaXN0b3J5IHJpbmcgY29udGFpbnMKLUBjb2Rle2VzaGVsbC1oaXN0b3J5 LXNpemV9IGNvbW1hbmRzLCB0aG9zZSBudW1iZXJzIGNoYW5nZSBhZnRlciBldmVyeQotY29t bWFuZCBpbnZvY2F0aW9uLCB0aGVyZWZvcmUgdGhlIEBzYW1we2hpc3Rvcnl9IGNvbW1hbmQg c2hhbGwgYmUKLWFwcGxpZWQgYmVmb3JlIHVzaW5nIHRoZSBleHBhbnNpb24gbWVjaGFuaXNt IHdpdGggaGlzdG9yeSBudW1iZXJzLgotCi1UaGUgbi10aCBlbnRyeSBvZiB0aGUgaGlzdG9y eSByaW5nIGNhbiBiZSBhcHBsaWVkIHdpdGggdGhlIEBzYW1weyFufQotY29tbWFuZC4gIElm IEBjb2Rle259IGlzIG5lZ2F0aXZlLCB0aGUgZW50cnkgaXMgY291bnRlZCBmcm9tIHRoZSBl bmQKLW9mIHRoZSBoaXN0b3J5IHJpbmcuCi0KLUBjaW5kZXggZXZlbnQgZGVzaWduYXRvcnMK LUBmaW5kZXggZXNoZWxsLWV4cGFuZC1oaXN0b3J5LXJlZmVyZW5jZXMKLVdoZW4gaGlzdG9y eSBldmVudCBkZXNpZ25hdG9ycyBhcmUgZW5hYmxlZCAoYnkgYWRkaW5nCi1AY29kZXtlc2hl bGwtZXhwYW5kLWhpc3RvcnktcmVmZXJlbmNlc30gdG8KLUBjb2Rle2VzaGVsbC1leHBhbmQt aW5wdXQtZnVuY3Rpb25zfSksIEBzYW1weyFmb299IGV4cGFuZHMgdG8gdGhlIGxhc3QKLWNv bW1hbmQgYmVnaW5uaW5nIHdpdGggQGNvZGV7Zm9vfSwgYW5kIEBzYW1weyE/Zm9vfSB0byB0 aGUgbGFzdAotY29tbWFuZCBjb250YWluaW5nIEBjb2Rle2Zvb30uICBUaGUgbi10aCBhcmd1 bWVudCBvZiB0aGUgbGFzdCBjb21tYW5kCi1iZWdpbm5pbmcgd2l0aCBAY29kZXtmb299IGlz IGFjY2Vzc2libGUgYnkgQGNvZGV7IWZvbzpufS4KLQotQHZpbmRleCBlc2hlbGwtaGlzdG9y eS1maWxlLW5hbWUKLUB2aW5kZXggZXNoZWxsLWhpc3RvcnktYXBwZW5kCi1UaGUgaGlzdG9y eSBpcyBsb2FkZWQgdG8gdGhlIGhpc3RvcnkgcmluZyBmcm9tIHRoZSBmaWxlCi1AY29kZXtl c2hlbGwtaGlzdG9yeS1maWxlLW5hbWV9IGF0IHRoZSBzdGFydCBvZiBldmVyeSBzZXNzaW9u LCBhbmQKLXNhdmVkIHRvIHRoYXQgZmlsZSBhdCB0aGUgZW5kIG9mIGV2ZXJ5IHNlc3Npb24u ICBUaGUgZGVmYXVsdCBoaXN0b3J5Ci1zYXZpbmcgYmVoYXZpb3IgaXMgdG8gb3ZlcndyaXRl IHRoZSBoaXN0b3J5IGZpbGUgd2l0aCB0aGUgd2hvbGUKLWhpc3RvcnkgcmluZyBvZiB0aGUg c2Vzc2lvbi4gIElmIEBjb2Rle2VzaGVsbC1oaXN0b3J5LWFwcGVuZH0gaXMKLW5vbi1AY29k ZXtuaWx9LCB0aGUgaGlzdG9yeSB3aWxsIGluc3RlYWQgYmUgc2F2ZWQgYnkgYXBwZW5kaW5n IG5ldwotZW50cmllcyBmcm9tIHRoZSBzZXNzaW9uIHRvIHRoZSBoaXN0b3J5IGZpbGUsIHdo aWNoIGNvdWxkIHByZXZlbnQKLXBvdGVudGlhbCBoaXN0b3J5IGxvc3Mgd2l0aCBtdWx0aXBs ZSBFc2hlbGwgc2Vzc2lvbnMuICBVbmxpa2Ugb3RoZXIKLXNoZWxscywgc3VjaCBhcyBCYXNo LCBFc2hlbGwgY2Fubm90IGN1cnJlbnRseSBiZSBjb25maWd1cmVkIHRvIGNvbnRyb2wKLXRo ZSBzaXplIG9mIHRoZSBoaXN0b3J5IGZpbGUuICBJbiBwYXJ0aWN1bGFyLCB3aGVuCi1AY29k ZXtlc2hlbGwtaGlzdG9yeS1hcHBlbmR9IGlzIG5vbi1AY29kZXtuaWx9LCB0aGUgc2l6ZSBv ZiB0aGUgZmlsZQotd2lsbCBrZWVwIGluY3JlYXNpbmcsIGFuZCB0aGUgcmVjb21tZW5kZWQg d2F5IHRvIHRydW5jYXRlIHRoZSBmaWxlIGlzCi10byBydW4gdGhlIEBzYW1we2hpc3Rvcnkg LXd9IGNvbW1hbmQgaW4gYW4gRXNoZWxsIHNlc3Npb24uCi0KLVNpbmNlIHRoZSBkZWZhdWx0 IGJ1ZmZlciBuYXZpZ2F0aW9uIGFuZCBzZWFyY2hpbmcga2V5LWJpbmRpbmdzIGFyZQotc3Rp bGwgcHJlc2VudCBpbiB0aGUgRXNoZWxsIGJ1ZmZlciwgdGhlIGNvbW1hbmRzIGZvciBoaXN0 b3J5Ci1uYXZpZ2F0aW9uIGFuZCBzZWFyY2hpbmcgYXJlIGJvdW5kIHRvIGRpZmZlcmVudCBr ZXlzOgotCi1AdGFibGUgQGtiZAotQGl0ZW0gTS1yCi1AaXRlbXggTS1zCi1IaXN0b3J5IEkt c2VhcmNoLgotCi1AaXRlbSBNLXAKLUBpdGVteCBNLW4KLVByZXZpb3VzIGFuZCBuZXh0IGhp c3RvcnkgbGluZS4gIElmIHRoZXJlIGlzIGFueXRoaW5nIG9uIHRoZSBpbnB1dAotbGluZSB3 aGVuIHlvdSBydW4gdGhlc2UgY29tbWFuZHMsIHRoZXkgd2lsbCBpbnN0ZWFkIGp1bXAgdG8g dGhlCi1wcmV2aW91cyBvciBuZXh0IGxpbmUgdGhhdCBiZWdpbnMgd2l0aCB0aGF0IHN0cmlu Zy4KLUBlbmQgdGFibGUKLQotQG5vZGUgQ29tcGxldGlvbgotQHNlY3Rpb24gQ29tcGxldGlv bgotRXNoZWxsIHVzZXMgdGhlIHBjb21wbGV0ZSBwYWNrYWdlIGZvciBwcm9ncmFtbWFibGUg Y29tcGxldGlvbiwgc2ltaWxhcgotdG8gdGhhdCBvZiBvdGhlciBjb21tYW5kIHNoZWxscy4g IEFyZ3VtZW50IGNvbXBsZXRpb24gZGlmZmVycyBkZXBlbmRpbmcKLW9uIHRoZSBwcmVjZWRp bmcgY29tbWFuZDogZm9yIGV4YW1wbGUsIHBvc3NpYmxlIGNvbXBsZXRpb25zIGZvcgotQGNv bW1hbmR7cm1kaXJ9IGFyZSBvbmx5IGRpcmVjdG9yaWVzLCB3aGlsZSBAY29tbWFuZHtybX0g Y29tcGxldGlvbnMgY2FuCi1iZSBkaXJlY3RvcmllcyBAZW1waHthbmR9IGZpbGVzLiAgRXNo ZWxsIHByb3ZpZGVzIHByZWRlZmluZWQgY29tcGxldGlvbnMKLWZvciB0aGUgYnVpbHQtaW4g ZnVuY3Rpb25zIGFuZCBzb21lIGNvbW1vbiBleHRlcm5hbCBjb21tYW5kcywgYW5kIHlvdQot Y2FuIGRlZmluZSB5b3VyIG93biBmb3IgYW55IGNvbW1hbmQuCi0KLUVzaGVsbCBjb21wbGV0 aW9uIGFsc28gd29ya3MgZm9yIExpc3AgZm9ybXMgYW5kIGdsb2IgcGF0dGVybnMuIElmIHRo ZQotcG9pbnQgaXMgb24gYSBMaXNwIGZvcm0sIHRoZW4gQGtleXtUQUJ9IHdpbGwgYmVoYXZl IHNpbWlsYXJseSB0bwotY29tcGxldGlvbiBpbiBAY29kZXtlbGlzcC1tb2RlfSBhbmQgQGNv ZGV7bGlzcC1pbnRlcmFjdGlvbi1tb2RlfS4gIEZvcgotZ2xvYiBwYXR0ZXJucywgdGhlIHBh dHRlcm4gd2lsbCBiZSByZW1vdmVkIGZyb20gdGhlIGlucHV0IGxpbmUsIGFuZAotcmVwbGFj ZWQgYnkgdGhlIGNvbXBsZXRpb24uCi0KLUlmIHlvdSB3YW50IHRvIHNlZSB0aGUgZW50aXJl IGxpc3Qgb2YgcG9zc2libGUgY29tcGxldGlvbnMgKGUuZy4gd2hlbiBpdCdzCi1iZWxvdyB0 aGUgQGNvZGV7Y29tcGxldGlvbi1jeWNsZS10aHJlc2hvbGR9KSwgcHJlc3MgQGtiZHtNLT99 LgotCi1Ac3Vic2VjdGlvbiBwY29tcGxldGUKLVBjb21wbGV0ZSwgc2hvcnQgZm9yIHByb2dy YW1tYWJsZSBjb21wbGV0aW9uLCBpcyB0aGUgY29tcGxldGlvbgotbGlicmFyeSBvcmlnaW5h bGx5IHdyaXR0ZW4gZm9yIEVzaGVsbCwgYnV0IHVzYWJsZSBmb3IgY29tbWFuZAotY29tcGxl dGlvbkBmb290bm90ZXtDb21tYW5kIGNvbXBsZXRpb24sIGFzIG9wcG9zZWQgdG8gY29kZSBj b21wbGV0aW9uLAotd2hpY2ggaXMgYmV5b25kIHRoZSBzY29wZSBvZiBwY29tcGxldGUufSBp biBvdGhlciBtb2Rlcy4KLQotQ29tcGxldGlvbnMgYXJlIGRlZmluZWQgYXMgZnVuY3Rpb25z ICh3aXRoIEBjb2Rle2RlZnVufSkgbmFtZWQKLUBjb2Rle3Bjb21wbGV0ZS9DT01NQU5EfSwg d2hlcmUgQGNvZGV7Q09NTUFORH0gaXMgdGhlIG5hbWUgb2YgdGhlCi1jb21tYW5kIGZvciB3 aGljaCB0aGlzIGZ1bmN0aW9uIHByb3ZpZGVzIGNvbXBsZXRpb25zOyB5b3UgY2FuIGFsc28g bmFtZQotdGhlIGZ1bmN0aW9uIEBjb2Rle3Bjb21wbGV0ZS9NQUpPUi1NT0RFL0NPTU1BTkR9 IHRvIGRlZmluZSBjb21wbGV0aW9ucwotZm9yIGEgc3BlY2lmaWMgbWFqb3IgbW9kZS4KLQog QG5vZGUgQ29udHJvbCBGbG93CiBAc2VjdGlvbiBDb250cm9sIEZsb3cKIEJlY2F1c2UgRXNo ZWxsIGNvbW1hbmRzIGNhbiBub3QgKGVhc2lseSkgYmUgY29tYmluZWQgd2l0aCBMaXNwIGZv cm1zLApAQCAtMjQ4Niw2ICsyMzk3LDExMSBAQCBQaXBlbGluZXMKICBzaCAtYyAiZm9vIHwg YmF6IiA+IzxidWZmZXIgcXV1eD4KIEBlbmQgZXhhbXBsZQogCitAbm9kZSBJbnRlcmFjdGlv bgorQGNoYXB0ZXIgSW50ZXJhY3Rpb24KKworQXMgYW4gaW50ZXJhY3RpdmUgc2hlbGwsIEVz aGVsbCBjb250YWlucyBtYW55IGZlYXR1cmVzIGZvciBoZWxwaW5nIHRvCitpbnRlcmFjdCB3 aXRoIHlvdXIgY29tbWFuZCBlbnZpcm9ubWVudC4gIEluIGFkZGl0aW9uLCBzaW5jZSBFc2hl bGwgaXMgYQorcGFydCBvZiBFbWFjcywgYWxsIG9mIHRoZSB1c3VhbCBFbWFjcyBjb21tYW5k cyB3b3JrIHdpdGhpbiBFc2hlbGwgYXMKK3dlbGwuCisKK0BtZW51CisqIENvbXBsZXRpb246 OgorKiBIaXN0b3J5OjoKK0BlbmQgbWVudQorCitAbm9kZSBDb21wbGV0aW9uCitAc2VjdGlv biBDb21wbGV0aW9uCitFc2hlbGwgdXNlcyB0aGUgcGNvbXBsZXRlIHBhY2thZ2UgZm9yIHBy b2dyYW1tYWJsZSBjb21wbGV0aW9uLCBzaW1pbGFyCit0byB0aGF0IG9mIG90aGVyIGNvbW1h bmQgc2hlbGxzLiAgQXJndW1lbnQgY29tcGxldGlvbiBkaWZmZXJzIGRlcGVuZGluZworb24g dGhlIHByZWNlZGluZyBjb21tYW5kOiBmb3IgZXhhbXBsZSwgcG9zc2libGUgY29tcGxldGlv bnMgZm9yCitAY29tbWFuZHtybWRpcn0gYXJlIG9ubHkgZGlyZWN0b3JpZXMsIHdoaWxlIEBj b21tYW5ke3JtfSBjb21wbGV0aW9ucyBjYW4KK2JlIGRpcmVjdG9yaWVzIEBlbXBoe2FuZH0g ZmlsZXMuICBFc2hlbGwgcHJvdmlkZXMgcHJlZGVmaW5lZCBjb21wbGV0aW9ucworZm9yIHRo ZSBidWlsdC1pbiBmdW5jdGlvbnMgYW5kIHNvbWUgY29tbW9uIGV4dGVybmFsIGNvbW1hbmRz LCBhbmQgeW91CitjYW4gZGVmaW5lIHlvdXIgb3duIGZvciBhbnkgY29tbWFuZC4KKworQGtp bmRleCBUQUIKK0VzaGVsbCBjb21wbGV0aW9uIGFsc28gd29ya3MgZm9yIExpc3AgZm9ybXMg YW5kIGdsb2IgcGF0dGVybnMuIElmIHRoZQorcG9pbnQgaXMgb24gYSBMaXNwIGZvcm0sIHRo ZW4gQGtleXtUQUJ9IHdpbGwgYmVoYXZlIHNpbWlsYXJseSB0bworY29tcGxldGlvbiBpbiBA Y29kZXtlbGlzcC1tb2RlfSBhbmQgQGNvZGV7bGlzcC1pbnRlcmFjdGlvbi1tb2RlfS4gIEZv cgorZ2xvYiBwYXR0ZXJucywgdGhlIHBhdHRlcm4gd2lsbCBiZSByZW1vdmVkIGZyb20gdGhl IGlucHV0IGxpbmUsIGFuZAorcmVwbGFjZWQgYnkgdGhlIGNvbXBsZXRpb24uCisKK0BraW5k ZXggTS0/CitJZiB5b3Ugd2FudCB0byBzZWUgdGhlIGVudGlyZSBsaXN0IG9mIHBvc3NpYmxl IGNvbXBsZXRpb25zIChlLmcuIHdoZW4gaXQncworYmVsb3cgdGhlIEBjb2Rle2NvbXBsZXRp b24tY3ljbGUtdGhyZXNob2xkfSksIHByZXNzIEBrYmR7TS0/fS4KKworQHN1YnNlY3Rpb24g cGNvbXBsZXRlCitQY29tcGxldGUsIHNob3J0IGZvciBwcm9ncmFtbWFibGUgY29tcGxldGlv biwgaXMgdGhlIGNvbXBsZXRpb24KK2xpYnJhcnkgb3JpZ2luYWxseSB3cml0dGVuIGZvciBF c2hlbGwsIGJ1dCB1c2FibGUgZm9yIGNvbW1hbmQKK2NvbXBsZXRpb25AZm9vdG5vdGV7Q29t bWFuZCBjb21wbGV0aW9uLCBhcyBvcHBvc2VkIHRvIGNvZGUgY29tcGxldGlvbiwKK3doaWNo IGlzIGJleW9uZCB0aGUgc2NvcGUgb2YgcGNvbXBsZXRlLn0gaW4gb3RoZXIgbW9kZXMuCisK K0NvbXBsZXRpb25zIGFyZSBkZWZpbmVkIGFzIGZ1bmN0aW9ucyAod2l0aCBAY29kZXtkZWZ1 bn0pIG5hbWVkCitAY29kZXtwY29tcGxldGUvQ09NTUFORH0sIHdoZXJlIEBjb2Rle0NPTU1B TkR9IGlzIHRoZSBuYW1lIG9mIHRoZQorY29tbWFuZCBmb3Igd2hpY2ggdGhpcyBmdW5jdGlv biBwcm92aWRlcyBjb21wbGV0aW9uczsgeW91IGNhbiBhbHNvIG5hbWUKK3RoZSBmdW5jdGlv biBAY29kZXtwY29tcGxldGUvTUFKT1ItTU9ERS9DT01NQU5EfSB0byBkZWZpbmUgY29tcGxl dGlvbnMKK2ZvciBhIHNwZWNpZmljIG1ham9yIG1vZGUuCisKK0Bub2RlIEhpc3RvcnkKK0Bz ZWN0aW9uIEhpc3RvcnkKK0BjbWluZGV4IGhpc3RvcnkKK0B2aW5kZXggZXNoZWxsLWhpc3Rv cnktc2l6ZQorVGhlIEBzYW1we2hpc3Rvcnl9IGNvbW1hbmQgc2hvd3MgYWxsIGNvbW1hbmRz IGtlcHQgaW4gdGhlIGhpc3RvcnkgcmluZworYXMgbnVtYmVyZWQgbGlzdC4gIElmIHRoZSBo aXN0b3J5IHJpbmcgY29udGFpbnMKK0Bjb2Rle2VzaGVsbC1oaXN0b3J5LXNpemV9IGNvbW1h bmRzLCB0aG9zZSBudW1iZXJzIGNoYW5nZSBhZnRlciBldmVyeQorY29tbWFuZCBpbnZvY2F0 aW9uLCB0aGVyZWZvcmUgdGhlIEBzYW1we2hpc3Rvcnl9IGNvbW1hbmQgc2hhbGwgYmUKK2Fw cGxpZWQgYmVmb3JlIHVzaW5nIHRoZSBleHBhbnNpb24gbWVjaGFuaXNtIHdpdGggaGlzdG9y eSBudW1iZXJzLgorCitUaGUgbi10aCBlbnRyeSBvZiB0aGUgaGlzdG9yeSByaW5nIGNhbiBi ZSBhcHBsaWVkIHdpdGggdGhlIEBzYW1weyFufQorY29tbWFuZC4gIElmIEBjb2Rle259IGlz IG5lZ2F0aXZlLCB0aGUgZW50cnkgaXMgY291bnRlZCBmcm9tIHRoZSBlbmQKK29mIHRoZSBo aXN0b3J5IHJpbmcuCisKK0BjaW5kZXggZXZlbnQgZGVzaWduYXRvcnMKK0BmaW5kZXggZXNo ZWxsLWV4cGFuZC1oaXN0b3J5LXJlZmVyZW5jZXMKK1doZW4gaGlzdG9yeSBldmVudCBkZXNp Z25hdG9ycyBhcmUgZW5hYmxlZCAoYnkgYWRkaW5nCitAY29kZXtlc2hlbGwtZXhwYW5kLWhp c3RvcnktcmVmZXJlbmNlc30gdG8KK0Bjb2Rle2VzaGVsbC1leHBhbmQtaW5wdXQtZnVuY3Rp b25zfSksIEBzYW1weyFmb299IGV4cGFuZHMgdG8gdGhlIGxhc3QKK2NvbW1hbmQgYmVnaW5u aW5nIHdpdGggQGNvZGV7Zm9vfSwgYW5kIEBzYW1weyE/Zm9vfSB0byB0aGUgbGFzdAorY29t bWFuZCBjb250YWluaW5nIEBjb2Rle2Zvb30uICBUaGUgbi10aCBhcmd1bWVudCBvZiB0aGUg bGFzdCBjb21tYW5kCitiZWdpbm5pbmcgd2l0aCBAY29kZXtmb299IGlzIGFjY2Vzc2libGUg YnkgQGNvZGV7IWZvbzpufS4KKworQHZpbmRleCBlc2hlbGwtaGlzdG9yeS1maWxlLW5hbWUK K0B2aW5kZXggZXNoZWxsLWhpc3RvcnktYXBwZW5kCitUaGUgaGlzdG9yeSBpcyBsb2FkZWQg dG8gdGhlIGhpc3RvcnkgcmluZyBmcm9tIHRoZSBmaWxlCitAY29kZXtlc2hlbGwtaGlzdG9y eS1maWxlLW5hbWV9IGF0IHRoZSBzdGFydCBvZiBldmVyeSBzZXNzaW9uLCBhbmQKK3NhdmVk IHRvIHRoYXQgZmlsZSBhdCB0aGUgZW5kIG9mIGV2ZXJ5IHNlc3Npb24uICBUaGUgZGVmYXVs dCBoaXN0b3J5CitzYXZpbmcgYmVoYXZpb3IgaXMgdG8gb3ZlcndyaXRlIHRoZSBoaXN0b3J5 IGZpbGUgd2l0aCB0aGUgd2hvbGUKK2hpc3RvcnkgcmluZyBvZiB0aGUgc2Vzc2lvbi4gIElm IEBjb2Rle2VzaGVsbC1oaXN0b3J5LWFwcGVuZH0gaXMKK25vbi1AY29kZXtuaWx9LCB0aGUg aGlzdG9yeSB3aWxsIGluc3RlYWQgYmUgc2F2ZWQgYnkgYXBwZW5kaW5nIG5ldworZW50cmll cyBmcm9tIHRoZSBzZXNzaW9uIHRvIHRoZSBoaXN0b3J5IGZpbGUsIHdoaWNoIGNvdWxkIHBy ZXZlbnQKK3BvdGVudGlhbCBoaXN0b3J5IGxvc3Mgd2l0aCBtdWx0aXBsZSBFc2hlbGwgc2Vz c2lvbnMuICBVbmxpa2Ugb3RoZXIKK3NoZWxscywgc3VjaCBhcyBCYXNoLCBFc2hlbGwgY2Fu bm90IGN1cnJlbnRseSBiZSBjb25maWd1cmVkIHRvIGNvbnRyb2wKK3RoZSBzaXplIG9mIHRo ZSBoaXN0b3J5IGZpbGUuICBJbiBwYXJ0aWN1bGFyLCB3aGVuCitAY29kZXtlc2hlbGwtaGlz dG9yeS1hcHBlbmR9IGlzIG5vbi1AY29kZXtuaWx9LCB0aGUgc2l6ZSBvZiB0aGUgZmlsZQor d2lsbCBrZWVwIGluY3JlYXNpbmcsIGFuZCB0aGUgcmVjb21tZW5kZWQgd2F5IHRvIHRydW5j YXRlIHRoZSBmaWxlIGlzCit0byBydW4gdGhlIEBzYW1we2hpc3RvcnkgLXd9IGNvbW1hbmQg aW4gYW4gRXNoZWxsIHNlc3Npb24uCisKK1NpbmNlIHRoZSBkZWZhdWx0IGJ1ZmZlciBuYXZp Z2F0aW9uIGFuZCBzZWFyY2hpbmcga2V5LWJpbmRpbmdzIGFyZQorc3RpbGwgcHJlc2VudCBp biB0aGUgRXNoZWxsIGJ1ZmZlciwgdGhlIGNvbW1hbmRzIGZvciBoaXN0b3J5CituYXZpZ2F0 aW9uIGFuZCBzZWFyY2hpbmcgYXJlIGJvdW5kIHRvIGRpZmZlcmVudCBrZXlzOgorCitAdGFi bGUgQGtiZAorQGtpbmRleCBNLXIKK0BraW5kZXggTS1zCitAaXRlbSBNLXIKK0BpdGVteCBN LXMKK0hpc3RvcnkgSS1zZWFyY2guCisKK0BraW5kZXggTS1wCitAa2luZGV4IE0tbgorQGl0 ZW0gTS1wCitAaXRlbXggTS1uCitQcmV2aW91cyBhbmQgbmV4dCBoaXN0b3J5IGxpbmUuICBJ ZiB0aGVyZSBpcyBhbnl0aGluZyBvbiB0aGUgaW5wdXQKK2xpbmUgd2hlbiB5b3UgcnVuIHRo ZXNlIGNvbW1hbmRzLCB0aGV5IHdpbGwgaW5zdGVhZCBqdW1wIHRvIHRoZQorcHJldmlvdXMg b3IgbmV4dCBsaW5lIHRoYXQgYmVnaW5zIHdpdGggdGhhdCBzdHJpbmcuCitAZW5kIHRhYmxl CisKIEBub2RlIEV4dGVuc2lvbiBtb2R1bGVzCiBAY2hhcHRlciBFeHRlbnNpb24gbW9kdWxl cwogRXNoZWxsIHByb3ZpZGVzIGEgZmFjaWxpdHkgZm9yIGRlZmluaW5nIGV4dGVuc2lvbiBt b2R1bGVzIHNvIHRoYXQgdGhleQpAQCAtMjUyNCw2ICsyNTQwLDEwIEBAIEtleSByZWJpbmRp bmcKIGlucHV0IHRleHQuICBUbyBlbmFibGUgdGhpcyBtb2R1bGUsIGFkZCBAY29kZXtlc2hl bGwtcmViaW5kfSB0bwogQGNvZGV7ZXNoZWxsLW1vZHVsZXMtbGlzdH0uCiAKK0BraW5kZXgg Qy11CitAa2luZGV4IEMtdworQGtpbmRleCBDLXAKK0BraW5kZXggQy1uCiBGb3IgZXhhbXBs ZSwgaXQgYmluZHMgQGtiZHtDLXV9IHRvIGtpbGwgdGhlIGN1cnJlbnQgaW5wdXQgdGV4dCBh bmQKIEBrYmR7Qy13fSB0byBAY29kZXtiYWNrd2FyZC1raWxsLXdvcmR9LiAgSWYgdGhlIGhp c3RvcnkgbW9kdWxlIGlzCiBlbmFibGVkLCBpdCBhbHNvIGJpbmRzIEBrYmR7Qy1wfSBhbmQg QGtiZHtDLW59IHRvIG1vdmUgdGhyb3VnaCB0aGUKQEAgLTMxNzQsMTMgKzMxOTQsOSBAQCBD b21tYW5kIEluZGV4CiAKIEBwcmludGluZGV4IGNtCiAKLUBjIFRoZXJlIGFyZSBubyBAa2lu ZGV4IGVudHJpZXMgaW4gdGhpcyBtYW51YWw7IGF2b2lkIGdlbmVyYXRpbmcgYW4KLUBjIGVt cHR5IG1lbnUuCi1AaWdub3JlCiBAbm9kZSBLZXkgSW5kZXgKIEB1bm51bWJlcmVkIEtleSBJ bmRleAogCiBAcHJpbnRpbmRleCBreQotQGVuZCBpZ25vcmUKIAogQGJ5ZQotLSAKMi4yNS4x Cgo= --------------0noFHICmW7jLdB4d01YoUgEr Content-Type: text/plain; charset=UTF-8; name="0002-Add-support-for-outline-minor-mode-in-Eshell.patch" Content-Disposition: attachment; filename="0002-Add-support-for-outline-minor-mode-in-Eshell.patch" Content-Transfer-Encoding: base64 RnJvbSBjZjk3Zjk5MzE0YTc0YzliNDBjYjMxMjUyYjk3MGViODg3MDVlNGFjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMzAgTWF5IDIwMjQgMTQ6MzE6NTUgLTA3MDAKU3ViamVjdDogW1BB VENIIDIvMl0gQWRkIHN1cHBvcnQgZm9yIG91dGxpbmUtbWlub3ItbW9kZSBpbiBFc2hlbGwK CiogbGlzcC9vdXRsaW5lLmVsIChvdXRsaW5lLWJhY2stdG8taGVhZGluZyk6IFNraXAgcGFz dCBpbnZpc2libGUgdGV4dC4KKG91dGxpbmUtb24taGVhZGluZy1wKTogQ2hlY2sgZm9yIGlu dmlzaWJpbGl0eSBvZiB0aGUgY2hhcmFjdGVyICpiZWZvcmUqCnBvaW50OyB0aGF0IHdheSwg dGhpcyByZXR1cm5zIG5vbi1uaWwgaWYgYXQgdGhlIGVuZCB0aGUgZmlyc3QgbGluZSBvZiBh CmNvbGxhcHNlZCBzZWN0aW9uLgoob3V0bGluZS1mbGFnLXJlZ2lvbik6IFNldCB0aGUgb3V0 bGluZSBidXR0b24gYXMgbmVlZGVkLgoob3V0bGluZS1lbmQtb2Ytc3VidHJlZSk6IEFsbG93 IGZvciBzdG9wcGluZyBhdCBlbXB0eSBsaW5lcy4KCiogbGlzcC9lc2hlbGwvZW0tcHJvbXB0 LmVsIChlc2hlbGwtb3V0bGluZS1zZWFyY2gpCihlc2hlbGwtb3V0bGluZS1sZXZlbCk6IE5l dyBmdW5jdGlvbnMuLi4KKGVzaGVsbC1wcm9tcHQtaW5pdGlhbGl6ZSk6IC4uLiB1c2UgdGhl bS4KCiogZG9jL21pc2MvZXNoZWxsLnRleGkgKE5hdmlnYXRpb24pOiBOZXcgc2VjdGlvbi4K KEJ1Z3MgYW5kIGlkZWFzKTogUmVtb3ZlIGltcGxlbWVudGVkIGlkZWEuCgoqIGV0Yy9ORVdT OiBBbm5vdW5jZSB0aGlzIGNoYW5nZS4KLS0tCiBkb2MvbWlzYy9lc2hlbGwudGV4aSAgICAg fCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQogZXRjL05FV1MgICAgICAg ICAgICAgICAgIHwgIDYgKysrKysrCiBsaXNwL2VzaGVsbC9lbS1wcm9tcHQuZWwgfCA0NSAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCiBsaXNwL291dGxpbmUu ZWwgICAgICAgICAgfCAyOSArKysrKysrKysrKysrKysrKystLS0tLS0tLQogNCBmaWxlcyBj aGFuZ2VkLCAxMDAgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZG9jL21pc2MvZXNoZWxsLnRleGkgYi9kb2MvbWlzYy9lc2hlbGwudGV4aQppbmRleCAy NDAwYmE5ODhiNC4uZWMxY2M1YjIzOTQgMTAwNjQ0Ci0tLSBhL2RvYy9taXNjL2VzaGVsbC50 ZXhpCisrKyBiL2RvYy9taXNjL2VzaGVsbC50ZXhpCkBAIC0yNDA2LDEwICsyNDA2LDQwIEBA IEludGVyYWN0aW9uCiB3ZWxsLgogCiBAbWVudQorKiBOYXZpZ2F0aW9uOjoKICogQ29tcGxl dGlvbjo6CiAqIEhpc3Rvcnk6OgogQGVuZCBtZW51CiAKK0Bub2RlIE5hdmlnYXRpb24KK0Bz ZWN0aW9uIE5hdmlnYXRpb24KKworQHRhYmxlIEBrYmQKKworQGtpbmRleCBDLWMgQy1uCitA a2luZGV4IEMtYyBDLXAKK0BpdGVtIEMtYyBDLW4KK0BpdGVteCBDLWMgQy1wCitNb3ZlIHBv aW50IHRvIHRoZSBiZWdpbm5pbmcgb2YgdGhlIGlucHV0IGZvciB0aGUgbmV4dCBvciBwcmV2 aW91cworcHJvbXB0LiAgV2l0aCBhIHByZWZpeCBhcmd1bWVudCwgbW92ZSB0byB0aGUgbi10 aCBuZXh0IG9yIHByZXZpb3VzCitwcm9tcHQuCisKK0BraW5kZXggQy1jIEMtcgorQGtpbmRl eCBDLU0tbAorQGl0ZW0gQy1jIEMtcgorQGl0ZW14IEMtTS1sCitNb3ZlIHBvaW50IHRvIHRo ZSBzdGFydCBvZiB0aGUgcHJldmlvdXMgY29tbWFuZCdzIG91dHB1dCBhbmQgZGlzcGxheSBp dAorYXQgdGhlIHRvcCBvZiB0aGUgd2luZG93LiAgV2l0aCBhIHByZWZpeCBhcmd1bWVudCwg dGhpcyBhbHNvIG5hcnJvd3MgdGhlCityZWdpb24gdG8gdGhlIGxhc3QgY29tbWFuZCdzIG91 dHB1dC4KKworQGVuZCB0YWJsZQorCitFc2hlbGwgYWxzbyBzdXBwb3J0cyBPdXRsaW5lIG1p bm9yIG1vZGUgKEBweHJlZntPdXRsaW5lIE1pbm9yIE1vZGUsICwgLAorZW1hY3MsIFRoZSBF bWFjcyBFZGl0b3J9KS4gIEJ5IGVuYWJsaW5nIEBjb2Rle291dGxpbmUtbWlub3ItbW9kZX0s CitFc2hlbGwgd2lsbCBhbGxvdyBjb2xsYXBzaW5nIGNvbW1hbmRzIGFuZC9vciB0aGVpciBv dXRwdXQuICBFYWNoIGNvbW1hbmQKK2lzIGEgdG9wLWxldmVsIG91dGxpbmUgbm9kZSwgYW5k IHRoZSBvdXRwdXQgb2YgdGhlIGNvbW1hbmQgaXMgYQorc2Vjb25kLWxldmVsIG5vZGUgdW5k ZXIgdGhlIGNvbW1hbmQuCisKIEBub2RlIENvbXBsZXRpb24KIEBzZWN0aW9uIENvbXBsZXRp b24KIEVzaGVsbCB1c2VzIHRoZSBwY29tcGxldGUgcGFja2FnZSBmb3IgcHJvZ3JhbW1hYmxl IGNvbXBsZXRpb24sIHNpbWlsYXIKQEAgLTI5ODcsMTIgKzMwMTcsNiBAQCBCdWdzIGFuZCBp ZGVhcwogCiBAaXRlbSBTdXBwb3J0IHpzaCdzIGBgUGFyYW1ldGVyIEV4cGFuc2lvbicnIHN5 bnRheCwgaS5lLiwgQHNhbXB7JEB7QHZhcntuYW1lfTotQHZhcnt2YWx9QH19CiAKLUBpdGVt IENyZWF0ZSBhIG1vZGUgQGNvZGV7ZXNoZWxsLWJyb3dzZX0KLQotSXQgd291bGQgdHJlYXQg dGhlIEVzaGVsbCBidWZmZXIgYXMgYW4gb3V0bGluZS4gIENvbGxhcHNpbmcgdGhlIG91dGxp bmUKLWhpZGVzIGFsbCBvZiB0aGUgb3V0cHV0IHRleHQuICBDb2xsYXBzaW5nIGFnYWluIHdv dWxkIHNob3cgb25seSB0aGUKLWZpcnN0IGNvbW1hbmQgcnVuIGluIGVhY2ggZGlyZWN0b3J5 Ci0KIEBpdGVtIEFsbG93IG90aGVyIHJldmlzaW9ucyBvZiBhIGZpbGUgdG8gYmUgcmVmZXJl bmNlZCB1c2luZyBAc2FtcHtmaWxlQHtyZXZAfX0KIAogVGhpcyB3b3VsZCBiZSBleHBhbmRl ZCBieSBAY29kZXtlc2hlbGwtZXhwYW5kLWZpbGUtbmFtZX0gKHNlZSBhYm92ZSkuCmRpZmYg LS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDNjNjcyZmZlZDhmLi45YzEyOTc4 MTI4ZCAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTg3Nyw2ICs4 NzcsMTIgQEAgY2FuIG1ha2UgaXQgZXhlY3V0YWJsZSBsaWtlIG90aGVyIHNoZWxsIHNjcmlw dHM6CiAKICAgICAjIS91c3IvYmluL2VudiAtUyBlbWFjcyAtLWJhdGNoIC1mIGVzaGVsbC1i YXRjaC1maWxlCiAKKysrKworKioqIEVzaGVsbCBub3cgc3VwcG9ydHMgJ291dGxpbmUtbWlu b3ItbW9kZScuCitCeSBlbmFibGluZyAnb3V0bGluZS1taW5vci1tb2RlJywgRXNoZWxsIHdp bGwgYWxsb3cgY29sbGFwc2luZyBjb21tYW5kcworYW5kL29yIHRoZWlyIG91dHB1dC4gIEVh Y2ggY29tbWFuZCBpcyBhIHRvcC1sZXZlbCBvdXRsaW5lIG5vZGUsIGFuZCB0aGUKK291dHB1 dCBvZiB0aGUgY29tbWFuZCBpcyBhIHNlY29uZC1sZXZlbCBub2RlIHVuZGVyIHRoZSBjb21t YW5kLgorCiArKysKICoqKiBOZXcgYnVpbHRpbiBFc2hlbGwgY29tbWFuZCAnY29tcGlsZScu CiBUaGlzIGNvbW1hbmQgcnVucyBhbm90aGVyIGNvbW1hbmQsIHNlbmRpbmcgaXRzIG91dHB1 dCB0byBhIGNvbXBpbGF0aW9uCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lbS1wcm9tcHQu ZWwgYi9saXNwL2VzaGVsbC9lbS1wcm9tcHQuZWwKaW5kZXggYjY1NTZkMjk1NDQuLjJlNjM3 YWNjMDVmIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lbS1wcm9tcHQuZWwKKysrIGIvbGlz cC9lc2hlbGwvZW0tcHJvbXB0LmVsCkBAIC0xMDcsNiArMTA3LDQ1IEBAIGVzaGVsbC1wcm9t cHQtcmVwZWF0LW1hcAogCiA7OzsgRnVuY3Rpb25zOgogCisoZGVmdW4gZXNoZWxsLW91dGxp bmUtc2VhcmNoICgmb3B0aW9uYWwgYm91bmQgbW92ZSBiYWNrd2FyZCBsb29raW5nLWF0KQor ICAiU2VhcmNoIGZvciBvdXRsaW5lIGhlYWRpbmdzLiAgU2VlIGBvdXRsaW5lLXNlYXJjaC1m dW5jdGlvbicuIgorICAobGV0ICgodmFsdWUgJyhwcm9tcHQgY29tbWFuZC1vdXRwdXQpKSkK KyAgICAoaWYgbG9va2luZy1hdAorICAgICAgICAod2hlbiAoYW5kIChtZW1xIChnZXQtdGV4 dC1wcm9wZXJ0eSAocG9pbnQpICdmaWVsZCkgdmFsdWUpCisgICAgICAgICAgICAgICAgICAg KD0gKGZpZWxkLWJlZ2lubmluZyAocG9pbnQpKSAocG9pbnQpKSkKKyAgICAgICAgICAoc2V0 LW1hdGNoLWRhdGEgKGxpc3QgKHBvcy1ib2wpIChwb3MtZW9sKSkpCisgICAgICAgICAgdCkK KyAgICAgIDs7IEdvIHRvIHRoZSBlbmQgd2hlbiBpbiB0aGUgbWlkZGxlIG9mIGhlYWRpbmcu CisgICAgICAod2hlbiAoYW5kIChub3QgYmFja3dhcmQpCisgICAgICAgICAgICAgICAgICht ZW1xIChnZXQtdGV4dC1wcm9wZXJ0eSAocG9pbnQpICdmaWVsZCkgdmFsdWUpCisgICAgICAg ICAgICAgICAgICgvPSAocG9pbnQpIChmaWVsZC1iZWdpbm5pbmcgKHBvaW50KSkpKQorICAg ICAgICAoZ290by1jaGFyIChmaWVsZC1lbmQgKHBvaW50KSkpKQorICAgICAgOzsgU2VhcmNo IGZvciBvdXIgd2FudGVkIGZpZWxkcy4KKyAgICAgIChpZi1sZXQgKChwcm9wLW1hdGNoCisg ICAgICAgICAgICAgICAgKGZ1bmNhbGwgKGlmIGJhY2t3YXJkICMndGV4dC1wcm9wZXJ0eS1z ZWFyY2gtYmFja3dhcmQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICMndGV4dC1wcm9w ZXJ0eS1zZWFyY2gtZm9yd2FyZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAnZmllbGQg dmFsdWUgKGxhbWJkYSAobGlzdCBlbHQpIChtZW1xIGVsdCBsaXN0KSkpKQorICAgICAgICAg ICAgICAgOzsgYmVnIGFuZCBlbmQgc2hvdWxkIG9ubHkgaW5jbHVkZSB0aGUgZmlyc3QgbGlu ZSBvZiB0aGUgZmllbGQuCisgICAgICAgICAgICAgICAoYmVnIChwcm9wLW1hdGNoLWJlZ2lu bmluZyBwcm9wLW1hdGNoKSkKKyAgICAgICAgICAgICAgIChlbmQgKHNhdmUtZXhjdXJzaW9u IChnb3RvLWNoYXIgYmVnKSAocG9zLWVvbCkpKQorICAgICAgICAgICAgICAgKChvciAobnVs bCBib3VuZCkgKGlmIGJhY2t3YXJkICg+PSBiZWcgYm91bmQpICg8PSBlbmQgYm91bmQpKSkp CisgICAgICAgICAgICAgICAoKHNhdmUtZXhjdXJzaW9uCisgICAgICAgICAgICAgICAgICAo Z290by1jaGFyIGJlZykKKyAgICAgICAgICAgICAgICAgICg9IChmaWVsZC1iZWdpbm5pbmcg KHBvaW50KSAocG9zLWJvbCkpKSkpKQorICAgICAgICAgIChwcm9nbgorICAgICAgICAgICAg KGdvdG8tY2hhciAoaWYgYmFja3dhcmQgYmVnIGVuZCkpCisgICAgICAgICAgICAoc2V0LW1h dGNoLWRhdGEgKGxpc3QgYmVnIGVuZCkpCisgICAgICAgICAgICB0KQorICAgICAgICAod2hl biBtb3ZlIChnb3RvLWNoYXIgKG9yIGJvdW5kIChpZiBiYWNrd2FyZCAocG9pbnQtbWluKSAo cG9pbnQtbWF4KSkpKSkKKyAgICAgICAgbmlsKSkpKQorCisoZGVmdW4gZXNoZWxsLW91dGxp bmUtbGV2ZWwgKCkKKyAgIkdldCB0aGUgb3V0bGluZSBsZXZlbCBhdCBwb2ludC4iCisgIChw Y2FzZSAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnZmllbGQpCisgICAgKCdwcm9tcHQg MSkKKyAgICAoJ2NvbW1hbmQtb3V0cHV0IDIpCisgICAgKF8gKGVycm9yICJOb3QgYXQgYW4g b3V0bGluZSBoZWFkaW5nIikpKSkKKwogKGRlZmluZS1taW5vci1tb2RlIGVzaGVsbC1wcm9t cHQtbW9kZQogICAiTWlub3IgbW9kZSBmb3IgZXNoZWxsLXByb21wdCBtb2R1bGUuCiAKQEAg LTExNyw3ICsxNTYsMTEgQEAgZXNoZWxsLXByb21wdC1pbml0aWFsaXplCiAgICJJbml0aWFs aXplIHRoZSBwcm9tcHRpbmcgY29kZS4iCiAgICh1bmxlc3MgZXNoZWxsLW5vbi1pbnRlcmFj dGl2ZS1wCiAgICAgKGFkZC1ob29rICdlc2hlbGwtcG9zdC1jb21tYW5kLWhvb2sgJ2VzaGVs bC1lbWl0LXByb21wdCBuaWwgdCkKLSAgICAoZXNoZWxsLXByb21wdC1tb2RlKSkpCisgICAg KGVzaGVsbC1wcm9tcHQtbW9kZSkKKworICAgIChzZXRxLWxvY2FsIG91dGxpbmUtc2VhcmNo LWZ1bmN0aW9uICMnZXNoZWxsLW91dGxpbmUtc2VhcmNoCisgICAgICAgICAgICAgICAgb3V0 bGluZS1sZXZlbCAjJ2VzaGVsbC1vdXRsaW5lLWxldmVsCisgICAgICAgICAgICAgICAgb3V0 bGluZS1taW5vci1tb2RlLXVzZS1idXR0b25zICdpbi1tYXJnaW5zKSkpCiAKIChkZWZ1biBl c2hlbGwtZW1pdC1wcm9tcHQgKCkKICAgIkVtaXQgYSBwcm9tcHQgaWYgZXNoZWxsIGlzIGJl aW5nIHVzZWQgaW50ZXJhY3RpdmVseS4iCmRpZmYgLS1naXQgYS9saXNwL291dGxpbmUuZWwg Yi9saXNwL291dGxpbmUuZWwKaW5kZXggNDBhNzU3MDFjYmYuLmI3OTk4NDA5MmU5IDEwMDY0 NAotLS0gYS9saXNwL291dGxpbmUuZWwKKysrIGIvbGlzcC9vdXRsaW5lLmVsCkBAIC02ODcs NiArNjg3LDExIEBAIG91dGxpbmUtYmFjay10by1oZWFkaW5nCiAgICJNb3ZlIHRvIHByZXZp b3VzIGhlYWRpbmcgbGluZSwgb3IgYmVnIG9mIHRoaXMgbGluZSBpZiBpdCdzIGEgaGVhZGlu Zy4KIE9ubHkgdmlzaWJsZSBoZWFkaW5nIGxpbmVzIGFyZSBjb25zaWRlcmVkLCB1bmxlc3Mg SU5WSVNJQkxFLU9LIGlzIG5vbi1uaWwuIgogICAoZm9yd2FyZC1saW5lIDApCisgICh3aGVu IChhbmQgKG5vdCBpbnZpc2libGUtb2spCisgICAgICAgICAgICAgKD4gKHBvaW50KSAocG9p bnQtbWluKSkKKyAgICAgICAgICAgICAoZ2V0LWNoYXItcHJvcGVydHkgKDEtIChwb2ludCkp ICdpbnZpc2libGUpKQorICAgIDs7IFNraXAgYmFja3dhcmRzIHBhc3QgYW55IGludmlzaWJs ZSB0ZXh0LgorICAgIChnb3RvLWNoYXIgKHByZXZpb3VzLXNpbmdsZS1jaGFyLXByb3BlcnR5 LWNoYW5nZSAocG9pbnQpICdpbnZpc2libGUpKSkKICAgKG9yIChvdXRsaW5lLW9uLWhlYWRp bmctcCBpbnZpc2libGUtb2spCiAgICAgICAobGV0IChmb3VuZCkKIAkoc2F2ZS1leGN1cnNp b24KQEAgLTcwNiw3ICs3MTEsOSBAQCBvdXRsaW5lLW9uLWhlYWRpbmctcAogSWYgSU5WSVNJ QkxFLU9LIGlzIG5vbi1uaWwsIGFuIGludmlzaWJsZSBoZWFkaW5nIGxpbmUgaXMgb2sgdG9v LiIKICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgKGZvcndhcmQtbGluZSAwKQotICAgIChhbmQg KGJvbHApIChvciBpbnZpc2libGUtb2sgKG5vdCAob3V0bGluZS1pbnZpc2libGUtcCkpKQor ICAgIChhbmQgKGJvbHApIChvciBpbnZpc2libGUtb2sKKyAgICAgICAgICAgICAgICAgICAg KGJvYnApCisgICAgICAgICAgICAgICAgICAgIChub3QgKG91dGxpbmUtaW52aXNpYmxlLXAg KDEtIChwb2ludCkpKSkpCiAJIChpZiBvdXRsaW5lLXNlYXJjaC1mdW5jdGlvbgogICAgICAg ICAgICAgIChmdW5jYWxsIG91dGxpbmUtc2VhcmNoLWZ1bmN0aW9uIG5pbCBuaWwgbmlsIHQp CiAgICAgICAgICAgIChsb29raW5nLWF0IG91dGxpbmUtcmVnZXhwKSkpKSkKQEAgLTEwMDQs NiArMTAxMSwxMSBAQCBvdXRsaW5lLWZsYWctcmVnaW9uCiAgICAgKGxldCAoKG8gKG1ha2Ut b3ZlcmxheSBmcm9tIHRvIG5pbCAnZnJvbnQtYWR2YW5jZSkpKQogICAgICAgKG92ZXJsYXkt cHV0IG8gJ2V2YXBvcmF0ZSB0KQogICAgICAgKG92ZXJsYXktcHV0IG8gJ2ludmlzaWJsZSAn b3V0bGluZSkKKyAgICAgICh1bmxlc3MgKGVxIG91dGxpbmUtbWlub3ItbW9kZS11c2UtYnV0 dG9ucyAnaW5zZXJ0KQorICAgICAgICA7OyBTZXQgdXAgdGhlIGJ1dHRvbiBvbiB0aGlzIG92 ZXJsYXkgdG9vLiAgVGhpcyBlbnN1cmVzIHRoYXQgdGhlCisgICAgICAgIDs7IGJ1dHRvbiBp cyB2aXNpYmxlIGV2ZW4gaWYgdGhlIGZpcnN0IGxpbmUgb2YgdGhlIHJlZ2lvbiBpcworICAg ICAgICA7OyBlbXB0eS4KKyAgICAgICAgKG92ZXJsYXktcHV0IG8gJ2JlZm9yZS1zdHJpbmcg KG50aCAxIG91dGxpbmUtLWJ1dHRvbi1pY29ucykpKQogICAgICAgKG92ZXJsYXktcHV0IG8g J2lzZWFyY2gtb3Blbi1pbnZpc2libGUKIAkJICAgKG9yIG91dGxpbmUtaXNlYXJjaC1vcGVu LWludmlzaWJsZS1mdW5jdGlvbgogCQkgICAgICAgIydvdXRsaW5lLWlzZWFyY2gtb3Blbi1p bnZpc2libGUpKSkpCkBAIC0xMjY0LDE0ICsxMjc2LDEzIEBAIG91dGxpbmUtZW5kLW9mLXN1 YnRyZWUKIAkJKG9yIGZpcnN0ICg+IChmdW5jYWxsIG91dGxpbmUtbGV2ZWwpIGxldmVsKSkp CiAgICAgICAoc2V0cSBmaXJzdCBuaWwpCiAgICAgICAob3V0bGluZS1uZXh0LWhlYWRpbmcp KQotICAgIChpZiAoYW5kIChib2xwKSAobm90IChlb2xwKSkpCi0JOzsgV2Ugc3RvcHBlZCBh dCBhIG5vbmVtcHR5IGxpbmUgKHRoZSBuZXh0IGhlYWRpbmcpLgotCShwcm9nbgotCSAgOzsg R28gdG8gZW5kIG9mIGxpbmUgYmVmb3JlIGhlYWRpbmcKLQkgIChmb3J3YXJkLWNoYXIgLTEp Ci0gICAgICAgICAgKGlmIChhbmQgb3V0bGluZS1ibGFuay1saW5lIChib2xwKSkKLSAJICAg ICAgOzsgbGVhdmUgYmxhbmsgbGluZSBiZWZvcmUgaGVhZGluZwotIAkgICAgICAoZm9yd2Fy ZC1jaGFyIC0xKSkpKSkpCisgICAgKHdoZW4gKGJvbHApCisgICAgICA7OyBXZSBzdG9wcGVk IGF0IHRoZSBuZXh0IGhlYWRpbmcuICBHbyB0byBlbmQgb2YgbGluZSBiZWZvcmUKKyAgICAg IDs7IGhlYWRpbmcuCisgICAgICAoZm9yd2FyZC1jaGFyIC0xKQorICAgICAgKHdoZW4gKGFu ZCBvdXRsaW5lLWJsYW5rLWxpbmUgKGJvbHApKQorICAgICAgICA7OyBMZWF2ZSBibGFuayBs aW5lIGJlZm9yZSBoZWFkaW5nLgorICAgICAgICAoZm9yd2FyZC1jaGFyIC0xKSkpKSkKIAwK IChkZWZ1biBvdXRsaW5lLXNob3ctYnJhbmNoZXMgKCkKICAgIlNob3cgYWxsIHN1YmhlYWRp bmdzIG9mIHRoaXMgaGVhZGluZywgYnV0IG5vdCB0aGVpciBib2RpZXMuIgotLSAKMi4yNS4x Cgo= --------------0noFHICmW7jLdB4d01YoUgEr--
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.Received: (at 71284) by debbugs.gnu.org; 31 May 2024 07:08:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 03:08:38 2024 Received: from localhost ([127.0.0.1]:53053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sCwNS-0008Vl-3t for submit <at> debbugs.gnu.org; Fri, 31 May 2024 03:08:38 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:52649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sCwNM-0008VT-PJ for 71284 <at> debbugs.gnu.org; Fri, 31 May 2024 03:08:37 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id B0612FF806; Fri, 31 May 2024 07:08:14 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> Subject: Re: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell In-Reply-To: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> (Jim Porter's message of "Thu, 30 May 2024 22:18:44 -0700") Organization: LINKOV.NET References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> Date: Fri, 31 May 2024 09:51:28 +0300 Message-ID: <868qzq1n3r.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71284 Cc: 71284 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > This patch adds support for outline-minor-mode to Eshell. When enabled, > this will just add outline buttons to the prompt (as the top level), and > one to the start of the output (as level 2). I'm not familiar with Eshell, so I tried in shell-mode to set (setq-local outline-regexp "^.*\\$ ") and it works nicely (for the real use it should be based on 'shell-prompt-pattern'). But I believe you had a good reason to prefer outline-search-function and more changes in outline.el to support outlines in Eshell. > The Eshell side is hopefully fairly straightforward, but the outline.el > part probably warrants a close review. The changes in outline.el are all > there to support outline headings that are just a newline and nothing > else. This is important for both the output (you might call a command that > prints a newline as the first character), and the prompt (the first > character of your prompt could be a newline as a way of separating the > prompt from the output just above it).[1] I don't understand why do you need an outline heading for the empty line. Is it really useful for hide/show an empty line? > Mainly, the changes in outline.el are about checking to see if the > character *before* point is invisible (i.e. part of a collapsed node). This > way, if point is at the beginning of the output, and you collapse that > node, outline.el still considers you to be on a heading. (Without these > changes, cycling a node doesn't work correctly.) > > I'm open to adding regression tests here since the logic is pretty subtle, > but I didn't see any existing ones for outline.el and it's not immediately > obvious the best way to test its behavior. Let me know if anyone has ideas > though. Adding regression tests would be nice since the changes in outline.el don't look trivial. I guess tests for outline.el should do two basic things: call various outline commands (perhaps just outline-cycle and outline-cycle-buffer should be sufficient) with various settings of outline variables, then 'invisible-p' could check if outline visibility is satisfied. Or we could prefer a lazy approach to install changes, then to add tests only in case when a regression will be discovered later.
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.
Received: (at 71284) by debbugs.gnu.org; 31 May 2024 06:06:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 02:06:04 2024
Received: from localhost ([127.0.0.1]:52999 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sCvOt-0001NN-Mp
for submit <at> debbugs.gnu.org; Fri, 31 May 2024 02:06:03 -0400
Received: from eggs.gnu.org ([209.51.188.92]:41202)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1sCvOn-0001Mn-N6
for 71284 <at> debbugs.gnu.org; Fri, 31 May 2024 02:06:01 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1sCvOV-0005HG-2e; Fri, 31 May 2024 02:05:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=c6O7ur4bn9MJSHhJbI76SUs1xJ+n0pBUmsHHDfxT2S0=; b=DVc7m4R83zRx
9W4Cm7GjiQGA57rH1bkvc21sIq4rAKtV7LAa7ZyZyf7b8BEGJqzDk7Y506JQF6348+gdTzfQGkJ6c
W1gAW+Jl/0614hur5/MbEUHoW/E48DEV4zGdojGr68iA4b0fFOXA9N3z4HqFvkDSKNcOatD9tXFOZ
ShCai5Kt66J3I0KSAbhPbou5C0AAfyyGQ2Dj19oIIo4WzShjIU9akCwOe6P2Do1rS140LhMklGKge
U6yFrVs/VG+8/bWcbrmPySbA9FX0lc8aDRu8Mp2CkiXNUlbGRFlg2jEXk+r3upwllhmQIuld+C4+F
q96bN0MNZbJjEi2MaDTt6Q==;
Date: Fri, 31 May 2024 09:05:30 +0300
Message-Id: <86y17qplcl.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> (message from
Jim Porter on Thu, 30 May 2024 22:18:44 -0700)
Subject: Re: bug#71284: 30.0.50;
[PATCH] Add support for outline-minor-mode to Eshell
References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 71284
Cc: 71284 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: juri@HIDDEN
> Date: Thu, 30 May 2024 22:18:44 -0700
> From: Jim Porter <jporterbugs@HIDDEN>
>
> This patch adds support for outline-minor-mode to Eshell. When enabled,
> this will just add outline buttons to the prompt (as the top level), and
> one to the start of the output (as level 2).
Thanks.
> diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi
> index 873d14aff32..071a2e59191 100644
> --- a/doc/misc/eshell.texi
> +++ b/doc/misc/eshell.texi
> @@ -2967,12 +2967,6 @@ Bugs and ideas
>
> @item Support zsh's ``Parameter Expansion'' syntax, i.e., @samp{$@{@var{name}:-@var{val}@}}
>
> -@item Create a mode @code{eshell-browse}
> -
> -It would treat the Eshell buffer as an outline. Collapsing the outline
> -hides all of the output text. Collapsing again would show only the
> -first command run in each directory
> -
> @item Allow other revisions of a file to be referenced using @samp{file@{rev@}}
>
> This would be expanded by @code{eshell-expand-file-name} (see above).
> diff --git a/etc/NEWS b/etc/NEWS
> index 3c672ffed8f..b5d4c9cfe6e 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -877,6 +877,9 @@ can make it executable like other shell scripts:
>
> #!/usr/bin/env -S emacs --batch -f eshell-batch-file
>
> +---
> +*** Eshell now supports 'outline-minor-mode'.
This is what I call "anti-documentation": the text you removed, which
described a non-existing feature, told more about the feature than the
text you added after implementing it ;-)
Seriously, though: since it is completely un-obvious what would
outline-minor-mode mean for command-line-oriented modes like Eshell,
both NEWS and the Eshell manual should say at least a couple of words
about what that does. We cannot get away by just mentioning the
support and keeping silent about the rest.
bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 May 2024 05:21:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 01:21:22 2024 Received: from localhost ([127.0.0.1]:52961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sCuha-0005pv-Po for submit <at> debbugs.gnu.org; Fri, 31 May 2024 01:21:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:60522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sCuhU-0005pU-Nb for submit <at> debbugs.gnu.org; Fri, 31 May 2024 01:21:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jporterbugs@HIDDEN>) id 1sCufC-0004B3-6B for bug-gnu-emacs@HIDDEN; Fri, 31 May 2024 01:18:50 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <jporterbugs@HIDDEN>) id 1sCuf9-0004ch-Cp for bug-gnu-emacs@HIDDEN; Fri, 31 May 2024 01:18:49 -0400 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-6c3b5c5e32cso257173a12.1 for <bug-gnu-emacs@HIDDEN>; Thu, 30 May 2024 22:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717132726; x=1717737526; darn=gnu.org; h=subject:from:cc:to:content-language:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0r8Nqdjt0Md+NJA/cVVP12qCyL7R5E+whyTtbZv6ARQ=; b=h28JI7JGxcHzuXUpketGg3c0zLcuf7b24SPAL+39zOgYEU+xvTAfPbEdGXd3CJ3kSc dFRUsQcGwL0O6TkK3YnhiSV6Wb5vn5xzOs24mP6sK+mdLQ6tJbXT+GegTjhYE0pUOZ0Y JfBprrLc13QuTXX1JXql/M+rKvZvLkxGgBPP073bfGXYMolb9hsKUFsAo78tdM8D8Aix lEvkQXWA671hO0L+GQSSGJyV7YgJLS+/3YAx87QEzL+IaiO0Dl7YfqWkmU9WFsM4Ql+L miL8cCehM/h7J+GFYS4CNLno8qfMa24faq9ZUhZ339dPejPIhBhIRU76Edp01iQIK93J //yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717132726; x=1717737526; h=subject:from:cc:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0r8Nqdjt0Md+NJA/cVVP12qCyL7R5E+whyTtbZv6ARQ=; b=l2MOO5JIKETIGE9HTN4aS//z6TyEqAWzRkWg1+kq0KRIklU6xFOA9llAQJNzllFdbC d9D+Cwn3/FvoCVASBQyMpbfmMxq5FlZcVR29j8pPhkIV+o2Q/cWSN2UezLkNIQZpdM2v JfcqVkJ15iQhZ9rhHmrhqP8RQO19tD3WjepsGfF4bsnT0ptWPXCzqQCnjrlelE5j4VrZ z/aHe64zwWyM4ceUoLK10Gsc3djQqR3n8GO2rH//aW3JP8P5X9kZxoZEg32CHw48KpDC tYtP6G9ECi93gV5URQz6OucHjRS2TVFe/E+U951MUc55f2I1jITrtanDMzlx81E23XOg mlCQ== X-Gm-Message-State: AOJu0YzqAHjSW47SxirgoO7qqdMUxrkFzQITIAhn8kjk6L0YFq8EuhCj VSDDIzGfLt6cibUGDoqeCvB5V71HDnXMiftmTmGcy7aUVqa1/PcP8OR/ZQ== X-Google-Smtp-Source: AGHT+IFovhK6+lXqAiwkUu1hL2npIprxPoxDd31llIB5S7D8ePSMPVy8csYdjgtIJXvQPozydZUspA== X-Received: by 2002:a05:6a20:72a0:b0:1af:fff9:30dd with SMTP id adf61e73a8af0-1b26f188c59mr1236721637.35.1717132725341; Thu, 30 May 2024 22:18:45 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f63232ddddsm7209425ad.15.2024.05.30.22.18.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 22:18:44 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------G0odIboxDBBa1onWGXhV44nR" Message-ID: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@HIDDEN> Date: Thu, 30 May 2024 22:18:44 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@HIDDEN From: Jim Porter <jporterbugs@HIDDEN> Subject: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=jporterbugs@HIDDEN; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------G0odIboxDBBa1onWGXhV44nR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit This patch adds support for outline-minor-mode to Eshell. When enabled, this will just add outline buttons to the prompt (as the top level), and one to the start of the output (as level 2). The Eshell side is hopefully fairly straightforward, but the outline.el part probably warrants a close review. The changes in outline.el are all there to support outline headings that are just a newline and nothing else. This is important for both the output (you might call a command that prints a newline as the first character), and the prompt (the first character of your prompt could be a newline as a way of separating the prompt from the output just above it).[1] Mainly, the changes in outline.el are about checking to see if the character *before* point is invisible (i.e. part of a collapsed node). This way, if point is at the beginning of the output, and you collapse that node, outline.el still considers you to be on a heading. (Without these changes, cycling a node doesn't work correctly.) I'm open to adding regression tests here since the logic is pretty subtle, but I didn't see any existing ones for outline.el and it's not immediately obvious the best way to test its behavior. Let me know if anyone has ideas though. [1] In the prompt case, a different way to solve this would be to treat the start of the heading as the first non-empty line. That doesn't work for output though since *all* lines could be empty. --------------G0odIboxDBBa1onWGXhV44nR Content-Type: text/plain; charset=UTF-8; name="0001-Add-support-for-outline-minor-mode-in-Eshell.patch" Content-Disposition: attachment; filename="0001-Add-support-for-outline-minor-mode-in-Eshell.patch" Content-Transfer-Encoding: base64 RnJvbSBmMTBiODg3Zjk0NWQwNTdhNTBhMDZlZmNjZmM5ZDhjMWU2NzYyZjBlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMzAgTWF5IDIwMjQgMTQ6MzE6NTUgLTA3MDAKU3ViamVjdDogW1BB VENIXSBBZGQgc3VwcG9ydCBmb3Igb3V0bGluZS1taW5vci1tb2RlIGluIEVzaGVsbAoKKiBs aXNwL291dGxpbmUuZWwgKG91dGxpbmUtYmFjay10by1oZWFkaW5nKTogU2tpcCBwYXN0IGlu dmlzaWJsZSB0ZXh0Lgoob3V0bGluZS1vbi1oZWFkaW5nLXApOiBDaGVjayBmb3IgaW52aXNp YmlsaXR5IG9mIHRoZSBjaGFyYWN0ZXIgKmJlZm9yZSoKcG9pbnQ7IHRoYXQgd2F5LCB0aGlz IHJldHVybnMgbm9uLW5pbCBpZiBhdCB0aGUgZW5kIHRoZSBmaXJzdCBsaW5lIG9mIGEKY29s bGFwc2VkIHNlY3Rpb24uCihvdXRsaW5lLWZsYWctcmVnaW9uKTogU2V0IHRoZSBvdXRsaW5l IGJ1dHRvbiBhcyBuZWVkZWQuCihvdXRsaW5lLWVuZC1vZi1zdWJ0cmVlKTogQWxsb3cgZm9y IHN0b3BwaW5nIGF0IGVtcHR5IGxpbmVzLgoKKiBsaXNwL2VzaGVsbC9lbS1wcm9tcHQuZWwg KGVzaGVsbC1vdXRsaW5lLXNlYXJjaCkKKGVzaGVsbC1vdXRsaW5lLWxldmVsKTogTmV3IGZ1 bmN0aW9ucy4uLgooZXNoZWxsLXByb21wdC1pbml0aWFsaXplKTogLi4uIHVzZSB0aGVtLgoK KiBkb2MvbWlzYy9lc2hlbGwudGV4aSAoQnVncyBhbmQgaWRlYXMpOiBSZW1vdmUgaW1wbGVt ZW50ZWQgaWRlYS4KCiogZXRjL05FV1M6IEFubm91bmNlIHRoaXMgY2hhbmdlLgotLS0KIGRv Yy9taXNjL2VzaGVsbC50ZXhpICAgICB8ICA2IC0tLS0tLQogZXRjL05FV1MgICAgICAgICAg ICAgICAgIHwgIDMgKysrCiBsaXNwL2VzaGVsbC9lbS1wcm9tcHQuZWwgfCA0NSArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCiBsaXNwL291dGxpbmUuZWwgICAg ICAgICAgfCAyOSArKysrKysrKysrKysrKysrKystLS0tLS0tLQogNCBmaWxlcyBjaGFuZ2Vk LCA2NyBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mv bWlzYy9lc2hlbGwudGV4aSBiL2RvYy9taXNjL2VzaGVsbC50ZXhpCmluZGV4IDg3M2QxNGFm ZjMyLi4wNzFhMmU1OTE5MSAxMDA2NDQKLS0tIGEvZG9jL21pc2MvZXNoZWxsLnRleGkKKysr IGIvZG9jL21pc2MvZXNoZWxsLnRleGkKQEAgLTI5NjcsMTIgKzI5NjcsNiBAQCBCdWdzIGFu ZCBpZGVhcwogCiBAaXRlbSBTdXBwb3J0IHpzaCdzIGBgUGFyYW1ldGVyIEV4cGFuc2lvbicn IHN5bnRheCwgaS5lLiwgQHNhbXB7JEB7QHZhcntuYW1lfTotQHZhcnt2YWx9QH19CiAKLUBp dGVtIENyZWF0ZSBhIG1vZGUgQGNvZGV7ZXNoZWxsLWJyb3dzZX0KLQotSXQgd291bGQgdHJl YXQgdGhlIEVzaGVsbCBidWZmZXIgYXMgYW4gb3V0bGluZS4gIENvbGxhcHNpbmcgdGhlIG91 dGxpbmUKLWhpZGVzIGFsbCBvZiB0aGUgb3V0cHV0IHRleHQuICBDb2xsYXBzaW5nIGFnYWlu IHdvdWxkIHNob3cgb25seSB0aGUKLWZpcnN0IGNvbW1hbmQgcnVuIGluIGVhY2ggZGlyZWN0 b3J5Ci0KIEBpdGVtIEFsbG93IG90aGVyIHJldmlzaW9ucyBvZiBhIGZpbGUgdG8gYmUgcmVm ZXJlbmNlZCB1c2luZyBAc2FtcHtmaWxlQHtyZXZAfX0KIAogVGhpcyB3b3VsZCBiZSBleHBh bmRlZCBieSBAY29kZXtlc2hlbGwtZXhwYW5kLWZpbGUtbmFtZX0gKHNlZSBhYm92ZSkuCmRp ZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDNjNjcyZmZlZDhmLi5iNWQ0 YzljZmU2ZSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTg3Nyw2 ICs4NzcsOSBAQCBjYW4gbWFrZSBpdCBleGVjdXRhYmxlIGxpa2Ugb3RoZXIgc2hlbGwgc2Ny aXB0czoKIAogICAgICMhL3Vzci9iaW4vZW52IC1TIGVtYWNzIC0tYmF0Y2ggLWYgZXNoZWxs LWJhdGNoLWZpbGUKIAorLS0tCisqKiogRXNoZWxsIG5vdyBzdXBwb3J0cyAnb3V0bGluZS1t aW5vci1tb2RlJy4KKwogKysrCiAqKiogTmV3IGJ1aWx0aW4gRXNoZWxsIGNvbW1hbmQgJ2Nv bXBpbGUnLgogVGhpcyBjb21tYW5kIHJ1bnMgYW5vdGhlciBjb21tYW5kLCBzZW5kaW5nIGl0 cyBvdXRwdXQgdG8gYSBjb21waWxhdGlvbgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZW0t cHJvbXB0LmVsIGIvbGlzcC9lc2hlbGwvZW0tcHJvbXB0LmVsCmluZGV4IGI2NTU2ZDI5NTQ0 Li4yZTYzN2FjYzA1ZiAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZW0tcHJvbXB0LmVsCisr KyBiL2xpc3AvZXNoZWxsL2VtLXByb21wdC5lbApAQCAtMTA3LDYgKzEwNyw0NSBAQCBlc2hl bGwtcHJvbXB0LXJlcGVhdC1tYXAKIAogOzs7IEZ1bmN0aW9uczoKIAorKGRlZnVuIGVzaGVs bC1vdXRsaW5lLXNlYXJjaCAoJm9wdGlvbmFsIGJvdW5kIG1vdmUgYmFja3dhcmQgbG9va2lu Zy1hdCkKKyAgIlNlYXJjaCBmb3Igb3V0bGluZSBoZWFkaW5ncy4gIFNlZSBgb3V0bGluZS1z ZWFyY2gtZnVuY3Rpb24nLiIKKyAgKGxldCAoKHZhbHVlICcocHJvbXB0IGNvbW1hbmQtb3V0 cHV0KSkpCisgICAgKGlmIGxvb2tpbmctYXQKKyAgICAgICAgKHdoZW4gKGFuZCAobWVtcSAo Z2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnZmllbGQpIHZhbHVlKQorICAgICAgICAgICAg ICAgICAgICg9IChmaWVsZC1iZWdpbm5pbmcgKHBvaW50KSkgKHBvaW50KSkpCisgICAgICAg ICAgKHNldC1tYXRjaC1kYXRhIChsaXN0IChwb3MtYm9sKSAocG9zLWVvbCkpKQorICAgICAg ICAgIHQpCisgICAgICA7OyBHbyB0byB0aGUgZW5kIHdoZW4gaW4gdGhlIG1pZGRsZSBvZiBo ZWFkaW5nLgorICAgICAgKHdoZW4gKGFuZCAobm90IGJhY2t3YXJkKQorICAgICAgICAgICAg ICAgICAobWVtcSAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnZmllbGQpIHZhbHVlKQor ICAgICAgICAgICAgICAgICAoLz0gKHBvaW50KSAoZmllbGQtYmVnaW5uaW5nIChwb2ludCkp KSkKKyAgICAgICAgKGdvdG8tY2hhciAoZmllbGQtZW5kIChwb2ludCkpKSkKKyAgICAgIDs7 IFNlYXJjaCBmb3Igb3VyIHdhbnRlZCBmaWVsZHMuCisgICAgICAoaWYtbGV0ICgocHJvcC1t YXRjaAorICAgICAgICAgICAgICAgIChmdW5jYWxsIChpZiBiYWNrd2FyZCAjJ3RleHQtcHJv cGVydHktc2VhcmNoLWJhY2t3YXJkCisgICAgICAgICAgICAgICAgICAgICAgICAgICAjJ3Rl eHQtcHJvcGVydHktc2VhcmNoLWZvcndhcmQpCisgICAgICAgICAgICAgICAgICAgICAgICAg J2ZpZWxkIHZhbHVlIChsYW1iZGEgKGxpc3QgZWx0KSAobWVtcSBlbHQgbGlzdCkpKSkKKyAg ICAgICAgICAgICAgIDs7IGJlZyBhbmQgZW5kIHNob3VsZCBvbmx5IGluY2x1ZGUgdGhlIGZp cnN0IGxpbmUgb2YgdGhlIGZpZWxkLgorICAgICAgICAgICAgICAgKGJlZyAocHJvcC1tYXRj aC1iZWdpbm5pbmcgcHJvcC1tYXRjaCkpCisgICAgICAgICAgICAgICAoZW5kIChzYXZlLWV4 Y3Vyc2lvbiAoZ290by1jaGFyIGJlZykgKHBvcy1lb2wpKSkKKyAgICAgICAgICAgICAgICgo b3IgKG51bGwgYm91bmQpIChpZiBiYWNrd2FyZCAoPj0gYmVnIGJvdW5kKSAoPD0gZW5kIGJv dW5kKSkpKQorICAgICAgICAgICAgICAgKChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAgICAg ICAgICAgKGdvdG8tY2hhciBiZWcpCisgICAgICAgICAgICAgICAgICAoPSAoZmllbGQtYmVn aW5uaW5nIChwb2ludCkgKHBvcy1ib2wpKSkpKSkKKyAgICAgICAgICAocHJvZ24KKyAgICAg ICAgICAgIChnb3RvLWNoYXIgKGlmIGJhY2t3YXJkIGJlZyBlbmQpKQorICAgICAgICAgICAg KHNldC1tYXRjaC1kYXRhIChsaXN0IGJlZyBlbmQpKQorICAgICAgICAgICAgdCkKKyAgICAg ICAgKHdoZW4gbW92ZSAoZ290by1jaGFyIChvciBib3VuZCAoaWYgYmFja3dhcmQgKHBvaW50 LW1pbikgKHBvaW50LW1heCkpKSkpCisgICAgICAgIG5pbCkpKSkKKworKGRlZnVuIGVzaGVs bC1vdXRsaW5lLWxldmVsICgpCisgICJHZXQgdGhlIG91dGxpbmUgbGV2ZWwgYXQgcG9pbnQu IgorICAocGNhc2UgKGdldC10ZXh0LXByb3BlcnR5IChwb2ludCkgJ2ZpZWxkKQorICAgICgn cHJvbXB0IDEpCisgICAgKCdjb21tYW5kLW91dHB1dCAyKQorICAgIChfIChlcnJvciAiTm90 IGF0IGFuIG91dGxpbmUgaGVhZGluZyIpKSkpCisKIChkZWZpbmUtbWlub3ItbW9kZSBlc2hl bGwtcHJvbXB0LW1vZGUKICAgIk1pbm9yIG1vZGUgZm9yIGVzaGVsbC1wcm9tcHQgbW9kdWxl LgogCkBAIC0xMTcsNyArMTU2LDExIEBAIGVzaGVsbC1wcm9tcHQtaW5pdGlhbGl6ZQogICAi SW5pdGlhbGl6ZSB0aGUgcHJvbXB0aW5nIGNvZGUuIgogICAodW5sZXNzIGVzaGVsbC1ub24t aW50ZXJhY3RpdmUtcAogICAgIChhZGQtaG9vayAnZXNoZWxsLXBvc3QtY29tbWFuZC1ob29r ICdlc2hlbGwtZW1pdC1wcm9tcHQgbmlsIHQpCi0gICAgKGVzaGVsbC1wcm9tcHQtbW9kZSkp KQorICAgIChlc2hlbGwtcHJvbXB0LW1vZGUpCisKKyAgICAoc2V0cS1sb2NhbCBvdXRsaW5l LXNlYXJjaC1mdW5jdGlvbiAjJ2VzaGVsbC1vdXRsaW5lLXNlYXJjaAorICAgICAgICAgICAg ICAgIG91dGxpbmUtbGV2ZWwgIydlc2hlbGwtb3V0bGluZS1sZXZlbAorICAgICAgICAgICAg ICAgIG91dGxpbmUtbWlub3ItbW9kZS11c2UtYnV0dG9ucyAnaW4tbWFyZ2lucykpKQogCiAo ZGVmdW4gZXNoZWxsLWVtaXQtcHJvbXB0ICgpCiAgICJFbWl0IGEgcHJvbXB0IGlmIGVzaGVs bCBpcyBiZWluZyB1c2VkIGludGVyYWN0aXZlbHkuIgpkaWZmIC0tZ2l0IGEvbGlzcC9vdXRs aW5lLmVsIGIvbGlzcC9vdXRsaW5lLmVsCmluZGV4IDQwYTc1NzAxY2JmLi5iNzk5ODQwOTJl OSAxMDA2NDQKLS0tIGEvbGlzcC9vdXRsaW5lLmVsCisrKyBiL2xpc3Avb3V0bGluZS5lbApA QCAtNjg3LDYgKzY4NywxMSBAQCBvdXRsaW5lLWJhY2stdG8taGVhZGluZwogICAiTW92ZSB0 byBwcmV2aW91cyBoZWFkaW5nIGxpbmUsIG9yIGJlZyBvZiB0aGlzIGxpbmUgaWYgaXQncyBh IGhlYWRpbmcuCiBPbmx5IHZpc2libGUgaGVhZGluZyBsaW5lcyBhcmUgY29uc2lkZXJlZCwg dW5sZXNzIElOVklTSUJMRS1PSyBpcyBub24tbmlsLiIKICAgKGZvcndhcmQtbGluZSAwKQor ICAod2hlbiAoYW5kIChub3QgaW52aXNpYmxlLW9rKQorICAgICAgICAgICAgICg+IChwb2lu dCkgKHBvaW50LW1pbikpCisgICAgICAgICAgICAgKGdldC1jaGFyLXByb3BlcnR5ICgxLSAo cG9pbnQpKSAnaW52aXNpYmxlKSkKKyAgICA7OyBTa2lwIGJhY2t3YXJkcyBwYXN0IGFueSBp bnZpc2libGUgdGV4dC4KKyAgICAoZ290by1jaGFyIChwcmV2aW91cy1zaW5nbGUtY2hhci1w cm9wZXJ0eS1jaGFuZ2UgKHBvaW50KSAnaW52aXNpYmxlKSkpCiAgIChvciAob3V0bGluZS1v bi1oZWFkaW5nLXAgaW52aXNpYmxlLW9rKQogICAgICAgKGxldCAoZm91bmQpCiAJKHNhdmUt ZXhjdXJzaW9uCkBAIC03MDYsNyArNzExLDkgQEAgb3V0bGluZS1vbi1oZWFkaW5nLXAKIElm IElOVklTSUJMRS1PSyBpcyBub24tbmlsLCBhbiBpbnZpc2libGUgaGVhZGluZyBsaW5lIGlz IG9rIHRvby4iCiAgIChzYXZlLWV4Y3Vyc2lvbgogICAgIChmb3J3YXJkLWxpbmUgMCkKLSAg ICAoYW5kIChib2xwKSAob3IgaW52aXNpYmxlLW9rIChub3QgKG91dGxpbmUtaW52aXNpYmxl LXApKSkKKyAgICAoYW5kIChib2xwKSAob3IgaW52aXNpYmxlLW9rCisgICAgICAgICAgICAg ICAgICAgIChib2JwKQorICAgICAgICAgICAgICAgICAgICAobm90IChvdXRsaW5lLWludmlz aWJsZS1wICgxLSAocG9pbnQpKSkpKQogCSAoaWYgb3V0bGluZS1zZWFyY2gtZnVuY3Rpb24K ICAgICAgICAgICAgICAoZnVuY2FsbCBvdXRsaW5lLXNlYXJjaC1mdW5jdGlvbiBuaWwgbmls IG5pbCB0KQogICAgICAgICAgICAobG9va2luZy1hdCBvdXRsaW5lLXJlZ2V4cCkpKSkpCkBA IC0xMDA0LDYgKzEwMTEsMTEgQEAgb3V0bGluZS1mbGFnLXJlZ2lvbgogICAgIChsZXQgKChv IChtYWtlLW92ZXJsYXkgZnJvbSB0byBuaWwgJ2Zyb250LWFkdmFuY2UpKSkKICAgICAgIChv dmVybGF5LXB1dCBvICdldmFwb3JhdGUgdCkKICAgICAgIChvdmVybGF5LXB1dCBvICdpbnZp c2libGUgJ291dGxpbmUpCisgICAgICAodW5sZXNzIChlcSBvdXRsaW5lLW1pbm9yLW1vZGUt dXNlLWJ1dHRvbnMgJ2luc2VydCkKKyAgICAgICAgOzsgU2V0IHVwIHRoZSBidXR0b24gb24g dGhpcyBvdmVybGF5IHRvby4gIFRoaXMgZW5zdXJlcyB0aGF0IHRoZQorICAgICAgICA7OyBi dXR0b24gaXMgdmlzaWJsZSBldmVuIGlmIHRoZSBmaXJzdCBsaW5lIG9mIHRoZSByZWdpb24g aXMKKyAgICAgICAgOzsgZW1wdHkuCisgICAgICAgIChvdmVybGF5LXB1dCBvICdiZWZvcmUt c3RyaW5nIChudGggMSBvdXRsaW5lLS1idXR0b24taWNvbnMpKSkKICAgICAgIChvdmVybGF5 LXB1dCBvICdpc2VhcmNoLW9wZW4taW52aXNpYmxlCiAJCSAgIChvciBvdXRsaW5lLWlzZWFy Y2gtb3Blbi1pbnZpc2libGUtZnVuY3Rpb24KIAkJICAgICAgICMnb3V0bGluZS1pc2VhcmNo LW9wZW4taW52aXNpYmxlKSkpKQpAQCAtMTI2NCwxNCArMTI3NiwxMyBAQCBvdXRsaW5lLWVu ZC1vZi1zdWJ0cmVlCiAJCShvciBmaXJzdCAoPiAoZnVuY2FsbCBvdXRsaW5lLWxldmVsKSBs ZXZlbCkpKQogICAgICAgKHNldHEgZmlyc3QgbmlsKQogICAgICAgKG91dGxpbmUtbmV4dC1o ZWFkaW5nKSkKLSAgICAoaWYgKGFuZCAoYm9scCkgKG5vdCAoZW9scCkpKQotCTs7IFdlIHN0 b3BwZWQgYXQgYSBub25lbXB0eSBsaW5lICh0aGUgbmV4dCBoZWFkaW5nKS4KLQkocHJvZ24K LQkgIDs7IEdvIHRvIGVuZCBvZiBsaW5lIGJlZm9yZSBoZWFkaW5nCi0JICAoZm9yd2FyZC1j aGFyIC0xKQotICAgICAgICAgIChpZiAoYW5kIG91dGxpbmUtYmxhbmstbGluZSAoYm9scCkp Ci0gCSAgICAgIDs7IGxlYXZlIGJsYW5rIGxpbmUgYmVmb3JlIGhlYWRpbmcKLSAJICAgICAg KGZvcndhcmQtY2hhciAtMSkpKSkpKQorICAgICh3aGVuIChib2xwKQorICAgICAgOzsgV2Ug c3RvcHBlZCBhdCB0aGUgbmV4dCBoZWFkaW5nLiAgR28gdG8gZW5kIG9mIGxpbmUgYmVmb3Jl CisgICAgICA7OyBoZWFkaW5nLgorICAgICAgKGZvcndhcmQtY2hhciAtMSkKKyAgICAgICh3 aGVuIChhbmQgb3V0bGluZS1ibGFuay1saW5lIChib2xwKSkKKyAgICAgICAgOzsgTGVhdmUg YmxhbmsgbGluZSBiZWZvcmUgaGVhZGluZy4KKyAgICAgICAgKGZvcndhcmQtY2hhciAtMSkp KSkpCiAMCiAoZGVmdW4gb3V0bGluZS1zaG93LWJyYW5jaGVzICgpCiAgICJTaG93IGFsbCBz dWJoZWFkaW5ncyBvZiB0aGlzIGhlYWRpbmcsIGJ1dCBub3QgdGhlaXIgYm9kaWVzLiIKLS0g CjIuMjUuMQoK --------------G0odIboxDBBa1onWGXhV44nR--
Jim Porter <jporterbugs@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#71284; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.