Received: (at 71386) by debbugs.gnu.org; 20 Jun 2024 06:50:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 20 02:50:40 2024 Received: from localhost ([127.0.0.1]:45927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sKBd2-00045u-FG for submit <at> debbugs.gnu.org; Thu, 20 Jun 2024 02:50:40 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sKBd1-00045e-3V for 71386 <at> debbugs.gnu.org; Thu, 20 Jun 2024 02:50:39 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 19BC320005; Thu, 20 Jun 2024 06:50:06 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <427a9100-dc84-42e6-bd07-44103e3475cd@HIDDEN> (martin rudalics's message of "Wed, 19 Jun 2024 11:37:52 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> <m24j9rr1q5.fsf@HIDDEN> <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> <m2zfrjpkpx.fsf@HIDDEN> <c9fcaadd-e936-40e1-b10c-d2d2d25e0509@HIDDEN> <m25xu6oywi.fsf@HIDDEN> <86h6dp1mcg.fsf@HIDDEN> <427a9100-dc84-42e6-bd07-44103e3475cd@HIDDEN> Date: Thu, 20 Jun 2024 09:48:10 +0300 Message-ID: <864j9o155d.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> I don't know why Martin wants to avoid closing the tabs in window.el >> when tabs have the same status as frames, and frames are deleted >> in window.el. > > I don't want to avoid closing tabs in window.el. But please make sure > that the mechanism works for any window on any frame. Whatever we > choose, 'window-deletable-p' and 'window--delete' have to work for an > arbitrary live window. So the obstacle is that tab-bar-close-tab closes tabs only on the selected frame? I don't know, this never was a problem.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 19 Jun 2024 09:38:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 19 05:38:07 2024 Received: from localhost ([127.0.0.1]:38316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJrlW-0007FH-Ow for submit <at> debbugs.gnu.org; Wed, 19 Jun 2024 05:38:06 -0400 Received: from mout.gmx.net ([212.227.17.20]:60301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sJrlT-0007Ea-In for 71386 <at> debbugs.gnu.org; Wed, 19 Jun 2024 05:38:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718789873; x=1719394673; i=rudalics@HIDDEN; bh=+kBviaogNu7vyDsdSw+8UP2rj7qj6Mm+vQGSjzXgCfM=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=NP+kSulNI2exAo1SDFKlg7RaatQVwFTLOCJmrbV4PnWMDwyirSj7ZtdZTPIldVMG YI6VyrXrQuud8IISBuAHCIpCHkZBymZvFZ321tKC57j9u4t4Ibcrw3Va3SPMV93s2 K9IEnHTEpYzDpjJSLE9WXMp6JQhf013+XIOKEbii5ILg5x/I2J8wNfWesnW94Ul+7 MFzbDuf9jnr7CSvIPLbrGoPEha0mB2202xmlOZFbSY+PhCBCqQjcQL/A5gKMcGtP7 6LMLwWiAxHUTAvkqa/Dnr+3ILmQrXflAf60O205JLGPwUADfyY2DBJ7CCATOOIw3S CAA5KYp7Xzh3ObdCGw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.224]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCbEp-1sAkwU2Kah-0089OC; Wed, 19 Jun 2024 11:37:53 +0200 Message-ID: <427a9100-dc84-42e6-bd07-44103e3475cd@HIDDEN> Date: Wed, 19 Jun 2024 11:37:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> <m24j9rr1q5.fsf@HIDDEN> <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> <m2zfrjpkpx.fsf@HIDDEN> <c9fcaadd-e936-40e1-b10c-d2d2d25e0509@HIDDEN> <m25xu6oywi.fsf@HIDDEN> <86h6dp1mcg.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86h6dp1mcg.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:nZkrGgSRJgWC+N4b7oOScbNUNQ7vsaQFMCJG7/UfEJP4/lCc+G5 1MpI85P7BwbeYNnTtu5hMMzJLKvccr89YwVyhK+W61TfOsVviSY3JrRYCqE4oxdDa7B13Zv efvevZxWPz4y2C8s+D6Sl7D5eVQe2vgR+en9vLY2hwDmUc8bSMtfKom7QLmVrKg0slkmYV+ mpdUFAVjsO4Z0pMQdQ2CA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:EN5mwqQ0a1A=;6hrUqrm7JlCOhklRp7tVeUC5Taj XTH8DTXELzNaWlL5ep4n2CvtQYZ6Uj49Mi7dTRuqpM0ow26rwvWcFVC1pWsimdQejhyLDw5VM TgEbod8zffGELN6PaqL8d8eSb3KT6B9VH2uJ2bi20Qx6DBMiwQCynPWP2qSsLs7iXj2xflcSb Ds+f9PKhOxb/KyyM3xGhou0rCiCNlw6TKH/VWkKXZY9xZt7BXjcrwK6/L+1Dm0Su9cUGWabc9 8Q/cxiLM+ZE/2MjPyya/trZMQnRmpFB3yrNcsq8kR0bgAA3uvRTrjwwO58I0otrWN7oOuFUnz xn5aCvr9xdoCTTMo9daSTjEouXwpZRYYpfqfZY5WpfAB4ObCExbYUzOqMMuLfku51Kbmaosky ZJbIW5JdwWw8VpC7eWFBDDhKJj6qrCCIBR0fRugyYpPrSuihhaXDvhoMCWcOdJqoaNHZLjyE5 RpE5V+uFxjixH204DTGPmuOdxvRsrpvjFZ80mwBIuoqFhPuArEDpleMeWyFWUheMxMLWscd4y vPeLWODgp5B5mFf1Q2c8ec2UNUFtyBnyNo4kLRrsQoun64vK3BQGNdM2KbBDQWENsVaFDmUlC DAGMk/rVyNMgTCVF4LlSFflzbbB+1p0QX8ZmdKBcvAZxYrnrPaLG3KRPT3KHk9/DYCfOnpLF9 VpE/yupR7OQOrEGTlf1Q75Gypzi/Hd9HUgIIEoL4W8wJFhKGK7FMledwsmxxIZ02AahzQ8btz YH0dLWa210L+akL6ZaJJ8s6Ikwhuj64EchNx7G7hdsZgXgh1BM+OyPTJc/9mcdKOCoA8CFyIb abdks7wvHrmWPWf5G26/GnorMFDfU1LVO+ZqLmdcDcYtM= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I don't know why Martin wants to avoid closing the tabs in window.el > when tabs have the same status as frames, and frames are deleted > in window.el. I don't want to avoid closing tabs in window.el. But please make sure that the mechanism works for any window on any frame. Whatever we choose, 'window-deletable-p' and 'window--delete' have to work f [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.224 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I don't know why Martin wants to avoid closing the tabs in window.el > when tabs have the same status as frames, and frames are deleted > in window.el. I don't want to avoid closing tabs in window.el. But please make sure that the mechanism works for any window on any frame. Whatever we choose, 'window-deletable-p' and 'window--delete' have to work f [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.224 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > I don't know why Martin wants to avoid closing the tabs in window.el > when tabs have the same status as frames, and frames are deleted > in window.el. I don't want to avoid closing tabs in window.el. But please make sure that the mechanism works for any window on any frame. Whatever we choose, 'window-deletable-p' and 'window--delete' have to work for an arbitrary live window. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 19 Jun 2024 06:25:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 19 02:25:56 2024 Received: from localhost ([127.0.0.1]:34501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJolY-0001KI-LP for submit <at> debbugs.gnu.org; Wed, 19 Jun 2024 02:25:56 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:60049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sJolW-0001K3-6x for 71386 <at> debbugs.gnu.org; Wed, 19 Jun 2024 02:25:54 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 01EE51C0005; Wed, 19 Jun 2024 06:25:22 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Al Haji-Ali <abdo.haji.ali@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <m25xu6oywi.fsf@HIDDEN> (Al Haji-Ali's message of "Tue, 18 Jun 2024 20:04:45 +0100") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> <m24j9rr1q5.fsf@HIDDEN> <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> <m2zfrjpkpx.fsf@HIDDEN> <c9fcaadd-e936-40e1-b10c-d2d2d25e0509@HIDDEN> <m25xu6oywi.fsf@HIDDEN> Date: Wed, 19 Jun 2024 09:24:31 +0300 Message-ID: <86h6dp1mcg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: martin rudalics <rudalics@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> We've been discussing changes to 'switch-to-prev-buffer' in Bug#69993 >> but ended up in disagreement on what to do. Juri then implemented a >> purely tab-bar based method. For my Emacs I use an option that allows >> it to switch to buffers that have been already displayed at least once >> only and am quite happy with it (I've never managed to derive a suitable >> regexp for all buffers I never want to switch to). > > I'll check Bug#69993 and try to figure out how to close the tab when > it has a single dedicated window from `switch-to-prev-buffer`, Unfortunately, there is nothing to figure out from Bug#69993, because it was about tab-line, not tab-bar. > or maybe Juri has some ideas? I don't know why Martin wants to avoid closing the tabs in window.el when tabs have the same status as frames, and frames are deleted in window.el.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 18 Jun 2024 19:07:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 18 15:07:36 2024 Received: from localhost ([127.0.0.1]:48875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJeB5-0002Pt-Mu for submit <at> debbugs.gnu.org; Tue, 18 Jun 2024 15:07:35 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:52487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sJeB3-0002Pa-NH for 71386 <at> debbugs.gnu.org; Tue, 18 Jun 2024 15:07:34 -0400 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4230366ad7bso52756555e9.1 for <71386 <at> debbugs.gnu.org>; Tue, 18 Jun 2024 12:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718737585; x=1719342385; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=92i5ueeWV1DxtSn/aL00+0PPzTCPJEHQjWZ45MtumOg=; b=JfSRyACv/CxKx94rb0JfKUnWgduJrpqRYxFpXsspKCINLZn3O6VfPnrUDX3LkdS30+ qna3XrtLrf35zAuSlTly3kTmrLT3jvhxgd+T8H0n9WRkpPrjMqFwpwtXd2jTvACzDXek uE/2kgwrjolit4IEgZT1DMT8GVPiGmP62c3foUrfXsxvHpkNU4o9esP42ZKOAdaPfssO 5hOqutvzDrqMfxvAS/fLrun1Y7ytiyu4iszCKTtVQCCeR35UaIPDrFvUZzL65RtRyunl MGgT8cXc0eywrxc+Hudd/82E0HNx99IqtFZNzjH0N2Bua+Ptedsuood9fVGCUizSpxPm 1UDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718737585; x=1719342385; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=92i5ueeWV1DxtSn/aL00+0PPzTCPJEHQjWZ45MtumOg=; b=IyduPL3MrTdaSYM5szDl3CeoCeCUc8CcJEroZ5rxfIw6b1/mkJjP4dJ5Mso/WI/8Xt vJtDGu4RXUyjrHFPnJVyJ1ws+m930nq9D124w20V5ysRhgfHaZsPbbBy45jK7CxPDAEv mcGtweOcWgnNnOSMTGXq2tkonfZ0GIIccJhgQlibjHOndwYAnhdjLZiVEu/4Q8hSnHjo yLq0CaU4EBpmUy6JMgUZvsoOwi6FkSs/Mau1YB32gpEIcxBOuM/vTWSIKRbIvw+KGgOV 9yaFQxcVz1S62AAsZLvaVtsguWdSu/g0fo63R4ssp3IPmojn+dBWtMBLgfEUPyFDN5Iw GzQA== X-Forwarded-Encrypted: i=1; AJvYcCX6g2vrip7QPPljwrrmnpbRZzknbklufygKk7qFbe11J15ae6j5RULzLx9KoEkHgJdShJDtkZIrLBCb6wY33rOUCy1fzvY= X-Gm-Message-State: AOJu0YzZLpdcuQu3nfX1AmRDbvgfn/OTodteSAsYIChmM04NQMCp1o5m gW/7BCZ65/HG2KdjdObSbmj5GbN5Wz77qFzyr8GST/Rdwr1gS3GoOHwsNw== X-Google-Smtp-Source: AGHT+IHnnHIJc/Y/BDzmcwsBLZ5ayMOuyzSZk4/KEEcnR897vYG3c/iYo+LNgl9tc6sVpPXK5OAbcw== X-Received: by 2002:adf:e84e:0:b0:361:78c8:2eb6 with SMTP id ffacd0b85a97d-363175b904emr404337f8f.25.1718737584607; Tue, 18 Jun 2024 12:06:24 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422870e986asm239050695e9.27.2024.06.18.12.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 12:06:24 -0700 (PDT) From: Al Haji-Ali <abdo.haji.ali@HIDDEN> To: martin rudalics <rudalics@HIDDEN>, Juri Linkov <juri@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <c9fcaadd-e936-40e1-b10c-d2d2d25e0509@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> <m24j9rr1q5.fsf@HIDDEN> <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> <m2zfrjpkpx.fsf@HIDDEN> <c9fcaadd-e936-40e1-b10c-d2d2d25e0509@HIDDEN> Date: Tue, 18 Jun 2024 20:04:45 +0100 Message-ID: <m25xu6oywi.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 18/06/2024, martin rudalics wrote: > We've been discussing changes to 'switch-to-prev-buffer' in Bug#69993 > but ended up in disagreement on what to do. Juri then implemented a > purely tab-bar based method. For my Emacs I use an option that allows > it to switch to buffers that have been already displayed at least once > only and am quite happy with it (I've never managed to derive a suitable > regexp for all buffers I never want to switch to). I see. The change you suggested is definitely needed in any case and would address the main issue in this bug report (frame being deleted and losing tab configuration). I would just suggest that `window-deletable-functions` be renamed to `window-deletable-predicates` or `window-deletable-p-functions` (as Juri suggested in his very first patch) to emphasize that these should be side-effect-free predicates. I guess the code that Juri originally suggested for tab-bar can also be used with `window-deletable-functions`. ,---- | (defun tab-bar-window-delete-frame-p (window kill) | "Prevent deletion of WINDOW and its frame when it contains tabs. | Used in `'window-deletable-functions'." | (and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1))) | | (add-hook 'window-deletable-functions #'tab-bar-window-delete-frame-p) `---- I'll check Bug#69993 and try to figure out how to close the tab when it has a single dedicated window from `switch-to-prev-buffer`, or maybe Juri has some ideas? -- Al
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 18 Jun 2024 09:52:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 18 05:52:39 2024 Received: from localhost ([127.0.0.1]:41916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJVW3-0003Bs-A0 for submit <at> debbugs.gnu.org; Tue, 18 Jun 2024 05:52:39 -0400 Received: from mout.gmx.net ([212.227.17.20]:40221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sJVW0-0003Bb-OX for 71386 <at> debbugs.gnu.org; Tue, 18 Jun 2024 05:52:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718704344; x=1719309144; i=rudalics@HIDDEN; bh=O56NKoG6qzbJu4AAYeOOFix0nb/NTeSWq9Z+T9SrQF0=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=sXszDA4EkVjrkwkLpKn3/9AD+Re+BR5ebB9buSV4/rekk5cAsHIqudSLhpPDjveB kvhYZB8HLrwEUy6Z4+j69paap/dSXdheNJ7Z9Uoo3PoZvEP3GU4+ertuotJcvfhdv RIKG1DZmkcMq9warQo9U7pkgZaQYPPjA8Ax33ME3yw0B5KPty2cPhFnVt+7a9ryuM qryQR/N6H9sguBWhjOQDqPDy7ermGEO1gAudXMnsIcF8IHwQp6db4jIeZmxpTq3rF oBq+LUqIWOZxOc1WmBc965tZU3n6oeAvzDMAQyPk3sFyldodW2iKOmX9RpBSFIV5J aHo5koDtcY+miGXVaA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([213.142.96.227]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1HZi-1sMFbG2hlC-000Ssj; Tue, 18 Jun 2024 11:52:24 +0200 Message-ID: <c9fcaadd-e936-40e1-b10c-d2d2d25e0509@HIDDEN> Date: Tue, 18 Jun 2024 11:52:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Al Haji-Ali <abdo.haji.ali@HIDDEN>, Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> <m24j9rr1q5.fsf@HIDDEN> <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> <m2zfrjpkpx.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <m2zfrjpkpx.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:qYwbYgh0Z/G3/asaZDM/3e3GR807I1QkGgWAhn4xpzDMRtxpe5C cvdWYGC5QwcT70TjTm4yEB86f2ulgF9mrxCI8Z+KqVFKnXhoRiX+/BeA9bmdIzLKikfdRyq IXBJWQraCaqDaoPMEsk4ng7OK3GMsjXYWPQkumSMX2/6dUrroE9zbAeDixL/Z55ylgbuOCg mBu8nasX7Ta8WOJHQ7MCg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:C02AbDH5d4Y=;IJ5jaEh+ww1vKPp8VaPLw27kGtf rLIBlFJ+c5CadczACojLENAdTtvYBuNK97GyqiM24Z/ZNggxjLwW47re9dIk51JnY5nerT+FK LXNWjqTQvC+w9o+A9Pt3/paiD+a1qdhEIOZ/Yl7sO4LABdeAw8kLq7XpshZq7mgsnEwxMe2PG PfxHNDlfOr5LBQUPTzCNhjIEtepQxQ8gd1T3GNSZetF99QFie4aNXeup6XufHvVul2nF2sFty VoZv25B4zqXMrCvImE/AkAzl3k0PxWRXx8zu8P91jOUWDLbkhsrDp7lzogMIWOZOzL8PNzCsD WR3I+0NKlatv2WjirljtbeLTQgDO10IoC0nNaBSLsLN0EX8GUVvoO//3M4YEUMU6U2WcdQy7A kn/i8y6auSxbTEMt0ArEVNQUgmhK/OzAlIA47+Ce4acZPexFEsVJ7haVgI+IZmxEbAnybdCYQ ozUodACvr+ASiQZeTaAdSte/cTIehYKpiXFXFdeb3H5MwzuYtw+zBSoSTbSK6GwQ6EoKV+e6x Zus1KpW8b7Bp6PYv+YlaKnBAOAmJt8ZDNcDuiCdrIlrz1Pi2Pf3Npe8GxWqy+QjxCTuDQ4y85 I+b+sU/eHxuFbkK+pdOKMsuU/JEJKB135K2twrt1GCud6NKROM/+MQj6DiQolN2aAp2GIWH5V q1/YZLBMJr0cu48TLELdSKpN2zXSbEteK/RmxjDJpmiATRoZegqbUE5QJWZE0tf7MbcZrYyL+ vMaFMmbAMOveRv5LCCOLTJGUe/D0bYKUnw+vOrqj8e0tor8uRScNizCTksSJePUdrJZ4MHAL+ 0H90V4KmjioOpK+AvZgSoG4p8lgFuZ7tzjkF24n/MNRBk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > However, `switch-to-prev-buffer` does not seem to allow hooks to > modify its behaviour (by the tab-bar code or otherwise), except to > skip buffers. Are we open to adding such hooks as well? We've been discussing changes to 'switch-to-prev-buffer' in Bug#69993 but ended up in disagreement on what to do. Juri then implemented a purely tab-bar based method. For my Emacs I use an option that allows it to switch to buffers that have been already displayed at least once only and am quite happy with it (I've never managed to derive a suitable regexp for all buffers I never want to switch to). But I do not think that we need a hook for 'switch-to-prev-buffer'. A user may call it at any moment and the tab bar code must already know how to deal with it via something like 'window-state-change-functions' (and on a non-selected frame as well). martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 17 Jun 2024 17:03:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 17 13:03:46 2024 Received: from localhost ([127.0.0.1]:35269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJFli-000659-A8 for submit <at> debbugs.gnu.org; Mon, 17 Jun 2024 13:03:46 -0400 Received: from mail-lf1-f53.google.com ([209.85.167.53]:49202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sJFlg-00064h-Jd for 71386 <at> debbugs.gnu.org; Mon, 17 Jun 2024 13:03:45 -0400 Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52cc10b5978so688371e87.2 for <71386 <at> debbugs.gnu.org>; Mon, 17 Jun 2024 10:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718643756; x=1719248556; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=UiimQTuOGgiORmUwXlnQuO/lYE4OFbo1fVQnUHQHcgw=; b=YcSKg+e0D7frikTm4bB0yvkjeZqDt4dwmZXPYLHM/R6/ogrMaDzpZZ54IE4kmlQo0Z e12emrrWC//XgHf0CN+7MdoDYZltpOBWN1Wtn21YEMy95WTSZ6EcpeVNLBn/Zv0JAcfx K+ZGtk4Psa2a2ut+izLjbtPou1F4Tmoe2TyMDomcx9hLEXzd38NEQkUie/iUFaLCSi+R AxF0Gb+6AXwzYyJ2Hm8bhG8BbI2NgdByHtKPqY6rDNVimMCTeXuL25iAKlhmdqEkdBqZ W2HXwFfzeviQx91OPP2YpXq+AALMWFGMsbQkx7681ErbRJ+Jen69YSdWP0MTUAbqet+O 3zqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718643756; x=1719248556; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UiimQTuOGgiORmUwXlnQuO/lYE4OFbo1fVQnUHQHcgw=; b=sB6PHoht3/D+65TLNyzpd+TnsXi8nqY2QL/ZA9zHCUe26l9cWuvMHg9NNj623gmnSz sVWjY8grHzn0KzKX2GdhXZTBlNZCyBiV8oXNmNYBxTUiIAOZIqFsupfQ5t+6RJKEw0Uo pgrx8HEbDQ6OTP+7GvUq8wcou2QJ+kZ+p3JRqV1hhX2WFRo45Rra9V3i2NpCeX1OuFNX vP6jy2PBIMKbzSW3+l/wPD0+kNDeqyohxhQSSSu5lZtaiGWGEQ+lWPKhwxpIwQBM0ZtR MNkoomklPsURI+KpDRpmUuLq3H8euDU9ASUqvnrSCumHJQmS3UE9bwDGUGkxvU+aqO2X sA7A== X-Forwarded-Encrypted: i=1; AJvYcCUIh+Td+JS5L2fGDK36aAn6nBXCXvuEXixWvircglNYNsdgh6p7jgpltwdUF9x5wuvyVDossaFLOQVbt4M3yXJLDcJY6W0= X-Gm-Message-State: AOJu0Yyu8wxwVKvhd76ilvlN+y+SHZqmvdU8ZEQRwAg9wXuQOh9D4kZi hu3FMhaIjeqny6K7H8LK8TC7M+o3ykwIx+WpteFDDMavP74LqA2J X-Google-Smtp-Source: AGHT+IG00OBKNZDKMYKIHloLYCUMSQi3dc+9Lqvd76D09UJPotxTv5/Ik2TEzUzExz525og+6iJD7g== X-Received: by 2002:a05:6512:743:b0:52c:859f:9f77 with SMTP id 2adb3069b0e04-52ca6e65821mr6962828e87.19.1718643755943; Mon, 17 Jun 2024 10:02:35 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-423072c21dbsm122077415e9.4.2024.06.17.10.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 10:02:35 -0700 (PDT) From: Al Haji-Ali <abdo.haji.ali@HIDDEN> To: martin rudalics <rudalics@HIDDEN>, Juri Linkov <juri@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> <m24j9rr1q5.fsf@HIDDEN> <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> Date: Mon, 17 Jun 2024 18:01:14 +0100 Message-ID: <m2zfrjpkpx.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 17/06/2024, martin rudalics wrote: > > The patch I proposed will simply cause another buffer to be shown in > that window. How this affects the tab bar code is beyond the limits of > 'quit-restore-window' and colleagues. I suppose the tab bar code should > do whatever it does when 'switch-to-prev-buffer' gets called. Ah, this could work and I can see it being more foolproof than modifying `window--delete`. However, `switch-to-prev-buffer` does not seem to allow hooks to modify its behaviour (by the tab-bar code or otherwise), except to skip buffers. Are we open to adding such hooks as well? -- Al
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 17 Jun 2024 16:47:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 17 12:47:25 2024 Received: from localhost ([127.0.0.1]:35241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJFVt-0002ql-4C for submit <at> debbugs.gnu.org; Mon, 17 Jun 2024 12:47:25 -0400 Received: from mout.gmx.net ([212.227.17.20]:58129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sJFVp-0002qX-QZ for 71386 <at> debbugs.gnu.org; Mon, 17 Jun 2024 12:47:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718642832; x=1719247632; i=rudalics@HIDDEN; bh=UhsuXz2ZOEEwlN1pOS2uMKRaSSaS8bM5gLnX6ZJUmAY=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ONtvbrEecYfp9SNA1baViZNOlMDWZqtjf6opjemMkczV5kfVwZnxFKjb7LERUmq+ TmbC8SRH8cy44HsxRIeUY6S3gLzrS3BzdULBN/vFBHKIqnwuCdF5MVKYbnZOGMwRT H2SlO4Vj65vwTIpYBobxcoJZHdximiO6RXNDZ7+J9pSVlN24Yk8MqyKDx1S2WQTsS 5wIVanigekrHU9giR6eDIVlmvSKQbkrqW9731sSmHeZCvW70ECNAP9Z3uIB6O2+7p V0KIBfP5CAbITNwz/Yx+GfhUyi72cKXzaSMMJWaLGVvFpA/suNN0jEP2ThZ5eRui/ qfGaTs20cFJpjgZoYA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.42]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MN5if-1s2xiH19fx-00Liq8; Mon, 17 Jun 2024 18:47:12 +0200 Message-ID: <d95a1014-9d29-4bd4-be36-ef44ea3bc4a8@HIDDEN> Date: Mon, 17 Jun 2024 18:47:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Al Haji-Ali <abdo.haji.ali@HIDDEN>, Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> <m24j9rr1q5.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <m24j9rr1q5.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:uf6QTbpnCxtxdIuWS9rleEDOB6QtIGItKcAKN/8X0JRks3/dqpc M7GjTtZiiIHmYoAQ5ac3KJ7o99SxZ8ro4GGKmqZwscH2saclLBovxTCoUp3R0Aj6Vt3SIek /uIUxInz/9vxgLFcFSMDduk6vd+Ufuze1o3MF3Rug5DJz2D41NzU+MxdRzw6vvm5mdNfDB4 qeXvBH9ZE6hg4/uQTqxjQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9x0gm6x+pX0=;gq5oatUEwC8To7nHUUMLjVL7z3N RckguzCY2SO1SxpiEhWRbnE+V0n4/sBGJaL623UfeUrziFXRjqESmyEGLCyAQibJHjXIe3KT8 AabCw37QEoLnIDAIOZgBpZmuQmv7Cew4kfYV9ClArx8/3WkHBvCw46A6/ts5V5nvxDiXnEL2q 32YHHo1/EwCASmaC47SqfnauBtcLtzPopamBppu4r0ALSZZDWHX2LjkIv/ZGEOVlwKfgDzhyb m3/HyA0fD2VDV9peN4b9O1vI6qDBZY2Kl593FGUSeeFyCCJJ9aP1VmDz7sIH96xTeL/4UY0ej Vrfc+DAmwwZ0M12BrU9ZVtLvUQRG42d+A0FBtJpFYEmaMGBmkzLvMuryTMt/yatk6NH3GfSO2 EbwqyxMYExa35mqusrAG4egUxyN/Jm4ZibGBqxIGHqKqJwkN3FH9iPykG2fFIAtvxCf5rwUC/ o8BLXh/WwcT6g1OvkkOryJwxuOOh5tzV7PkpRQVxDc7UqY9zzxYIXnrFktEZ7oHkJwnvukuaq qeJiT6QjvjQWpdcwZAEPAnZyW7/j1AYjSscaMy4wxbdV0pGPqyejiUNHZbfhAEHGeb3AI0SbW nBNuiD4U/c3yccpM9d7LUh2Y0FifOykSk56+fwRN9yp2ZYTCU5prAVyO2/BxO86GbWKe09wzO rEsC6kJK6rAT2uq++MnG8EuJJEaUEcGlb8kZzljLKvTITbVY2pzO4MCXoJrVv1X4PagFgmxb9 CWSH0xkCykN93qdmHv0R5GTmISaykzWalDf49YS8QyjkVUXeGtYzXUEK0etv3uWuq7RWnczHf c6nD9Vo6O7ayohBkcZgZQ1To6Q5VlpRCf9d8Zi5npNjcg= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > It would be great if the fix is done entirely in `window-deletable-p`, > but is the idea functions in `window-deletable-functions` could have > side-effects even though they are called from a predi [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.42 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > It would be great if the fix is done entirely in `window-deletable-p`, > but is the idea functions in `window-deletable-functions` could have > side-effects even though they are called from a predi [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.42 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > It would be great if the fix is done entirely in `window-deletable-p`, > but is the idea functions in `window-deletable-functions` could have > side-effects even though they are called from a predicate? No. We could emphasize that in the doc-string. The idea is that such a function can have 'window-deletable-p' return nil instead of 'frame' or t. WOW all functions on 'window-deletable-functions' have to agree that 'window-deletable-p' may return any non-nil value it initially proposes. > For tabs, I believe an ideal fix would close the tab in lieu of > deleting the frame when the buffer of a dedicated window is killed > (similar to what Juri does in per patches). The patch I proposed will simply cause another buffer to be shown in that window. How this affects the tab bar code is beyond the limits of 'quit-restore-window' and colleagues. I suppose the tab bar code should do whatever it does when 'switch-to-prev-buffer' gets called. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 17 Jun 2024 16:10:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 17 12:10:12 2024 Received: from localhost ([127.0.0.1]:35191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJEvs-0001sn-Jl for submit <at> debbugs.gnu.org; Mon, 17 Jun 2024 12:10:12 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:43147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sJEvq-0001sa-Ic for 71386 <at> debbugs.gnu.org; Mon, 17 Jun 2024 12:10:11 -0400 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-35f2c9e23d3so3694793f8f.0 for <71386 <at> debbugs.gnu.org>; Mon, 17 Jun 2024 09:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718640542; x=1719245342; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=L1zWDFQEX9PfNy3EPowh+QmoZr1p0+hGxbJLCDT3CbA=; b=cNs/jM6qvcKf4l1+beXdFj5bBT9PA9Pusa67BYRytzqPn4daxgM4xU37fIiD55KthC Y68FqD310U9lGsEIA3z4ugeqEKGOBj3go2Z0VrH+vYdnJtG01pliyrvZ+MF/0eWCpzwk 5k1E6VKm2pgJdEND1+i22CW+urgeXVF3kJlSiJ3uGDA2xGuDUmnmKrd2l/C3CcAZcQ2W zAhnyiIgJvVQnpS6cNCRQdhLpJ9zYYT//41X6QKzn/oiB0mjU2N9yBWSH1FkIIWftmdi 3QTiRDcYDFQsOwqJVKGhyByYAhzdg0EvoYUqQp7LIDogQjSNnL533KMOsiKaIyEJBkO6 +Eeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718640542; x=1719245342; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L1zWDFQEX9PfNy3EPowh+QmoZr1p0+hGxbJLCDT3CbA=; b=pU/3P6pWhWh74o5MTpNL0NfxNTsOv2R+VCru93RVIal8hdUu/Q83DFkFR/UxCz6WED jeuLHIfGhUxooWVvy92enrthtd1eD6ddK8QsIHUmFRuFy1rt+p7ZygXZccKNsNe9YPRt U0BFZhPpGsHx8fLQ5qYySfyMhBF7xNLqjS+qXrxRy/TuNKR5e1DqpdsYCICl5O1sQCSd 1KhckQuSFNSv3pXgJTWYMtTho+5HozlBTuM5s6pMRSGE+78O/2nuM+VCfhxxjN8W+UA9 hU9BuJw5qegWyCGLWbJUbInFk6HUldx2Vontt148xYJBFar8UNGlM79hxFiqslENunuf xbJQ== X-Forwarded-Encrypted: i=1; AJvYcCXmnpzSpjCt8boIlRjheyVTxCmCvADOYAjddMKbtxiIqcEOfuYVKGpHx2FWKJcEhjruMvsBY5UJYUTXGMrDzfmd8jKC6iw= X-Gm-Message-State: AOJu0Yx/+zvWFEAssnwgNiK7xpkxOqu20pS956/UKFh6S5A9FCfzfOqF njWVXnCn+qWYkAFyOQYvkF7f2as7Nh2rB6qEEQj+1Q0nqV+aPj7H X-Google-Smtp-Source: AGHT+IG2NV0KrYrhLWbcgCxns/3j/DP/2+MQWdTNU/NmFom3Swg7FN6NzCfJKa84TFu5Ohsp22nP7A== X-Received: by 2002:a5d:6ac2:0:b0:360:9333:c69 with SMTP id ffacd0b85a97d-3609eaa9059mr74510f8f.33.1718640542350; Mon, 17 Jun 2024 09:09:02 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750acd7csm12189655f8f.52.2024.06.17.09.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 09:09:01 -0700 (PDT) From: Al Haji-Ali <abdo.haji.ali@HIDDEN> To: martin rudalics <rudalics@HIDDEN>, Juri Linkov <juri@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> Date: Mon, 17 Jun 2024 17:08:34 +0100 Message-ID: <m24j9rr1q5.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 17/06/2024, martin rudalics wrote: > This means that we should do the entire fix within 'window-deletable-p', > right? That's not an internal function, so we can, in all conscience, > supply an abnormal hook as in the roughly tested patch attached. It would be great if the fix is done entirely in `window-deletable-p`, but is the idea functions in `window-deletable-functions` could have side-effects even though they are called from a predicate? For tabs, I believe an ideal fix would close the tab in lieu of deleting the frame when the buffer of a dedicated window is killed (similar to what Juri does in per patches). -- Al
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 17 Jun 2024 14:47:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 17 10:47:51 2024 Received: from localhost ([127.0.0.1]:34964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJDeB-00087W-5m for submit <at> debbugs.gnu.org; Mon, 17 Jun 2024 10:47:51 -0400 Received: from mout.gmx.net ([212.227.17.20]:41297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sJDe9-00087G-1P for 71386 <at> debbugs.gnu.org; Mon, 17 Jun 2024 10:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718635660; x=1719240460; i=rudalics@HIDDEN; bh=QMd8zafktqRYhZKHjTER12eAEn3gKuX67YgG+GcGlk8=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=NLkkAc8BDj8OjYbRsSbE5+M2vhJFtZl+0ucaFqzRBo/khPLldB5KUb1pTvc4tE/Y t7NomSvCGBEcdSAXnmbRG21yfvuCr3wQRXRM8v6RbLuFpqvE7q+/erDuLtdXJwIKp 9nZxRTx3J9lgcwbCWFGr4uMmS8mL2o4GI3GZpbs8CcYeaMsJsyDBTMl+e67npiWyD ydwN5p1bPBJEwj8xWGZyOSvioIUPK0rqw5FuBuyznbo8+QnROQu8JHOW85hWRyh0w hJdYBriAMLAJo0UOr8PON3Uoru4hskk2guSbaXupHz6RLC11k5gULmWMDbxVVNeFI izW8DOwzXWIsCw8bsg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.42]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiTt-1rwLk90y21-00SGv5; Mon, 17 Jun 2024 16:47:40 +0200 Message-ID: <dbafc5da-dc0a-4fbe-a902-01cf60310f00@HIDDEN> Date: Mon, 17 Jun 2024 16:47:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <86a5jksv4k.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86a5jksv4k.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Rwj803zp55wJLqxpkWK+0SGNlPtqpq5xKBiLAHdjDpYuFjQ0hQf tgZCvdIotvCFpzcDEjuq4oHRfMmfpk4LGFgqGgJR4mVxAZuiq4rDlzvgSzPmektGKmbX0PT PeMaLosgPUOf/xfItt5QFGOJf7pvApRFhuD89RyGi689u0xnL4O4occE2G3YTmA43KhC9qv n3HkAYvQkNZBU6QhQfo6Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:MxZjSBj/Ta8=;U0FYTViMS6H0Fp7O5A20P0nbrnD ljmFIcaIa9dorD+ZIvlN+mqRb/NbsUgbgvyFmZzcy3QksCaoJLbMwIXy3iY4Ffw0FQa2nZfot h2PGMFHPcJ7+Z2GszsAn5TIHd0sFcjx2ZLNCcDNAPhHp8GtTQ5AlqtUjQwxFK0q3NxOXxFDQz fMwOy8ox+lBU91zcD6sQrgMF8sl3NAFFUH3FiHBjzf8Hh0/ce2XbRNfsYa63pzDoRjzlV8xkL I5W3p+pp/OtNn6XVMnrQfxeccabrH8NdjEkO9vCqLrO6I8S9n8zJU28h8HN/QqtpkGWzaGizv JaWEjBO82d09Qhh7bL8nQOV1zsORC0x5oLS74+jNkRRf45p3z747W8vfOdttX13HkXpgisQvm iIJzNuLHlC4GXpk8a+7aOOXb98FrOzwDlmb2eI3IIhi6cI3LV2C+TWvN1fSOUlhxRqow049H2 zWKXWHUbHzbOZr7VAqjOjIdJDIxIuCJ0wuuaLk77ytMRJaCV3DsVUeNLitCddkRSLNxKEZ61j kypIqrDzqEKUUpVCb5u1X04okes0w5O60TJCPD6TQkAZkil+AtzcIjd6vMbRlcpQ+hKBOUdU+ fjNEWwOlgPfFCzG+LprbT/VKBoEit8Piu+UCnmF0U2yXJAK6Shl+xDg+c/jCjaaVy0mbiEzAe TE6QJRHbf022ggOyXisrFQYuZQ4hDKPbhNseHV1mP4gubKSLWVukcVanJiidJ8KaGZY1DID1L Wy/gZPd6iNwqbzIXaJ0s6HKTVIrots37RLmCY4PBS9u3l0oGamWMuLqEOuXK8RCw+dDC6+hC+ oIhNR82A241SUjKTtfYOKGtcZUGzj0InQFmHdIUaQnXL8= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > This patch just copies the logic of frame handling to tab handling. > There is no customization for frame handling, There is: 'auto-hide-function'. > so there is > no customization for tab handling. Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.42 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > This patch just copies the logic of frame handling to tab handling. > There is no customization for frame handling, There is: 'auto-hide-function'. > so there is > no customization for tab handling. Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.42 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > This patch just copies the logic of frame handling to tab handling. > There is no customization for frame handling, There is: 'auto-hide-function'. > so there is > no customization for tab handling. But we want to customize the new behavior whether to retain a frame because it has outstanding tabs or not. > In window-deletable-p there is hard-coded 'frame-root-window-p' > that checks if the frame has only 1 window. So the patch > does the same by checking if there is only 1 tab on the frame. > > Also in window--delete the call of 'tab-bar-close-tab' > corresponds to the call 'delete-frame'. And if a user wants to auto-hide the frame? martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 17 Jun 2024 14:47:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 17 10:47:25 2024 Received: from localhost ([127.0.0.1]:34960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJDdk-00086o-MW for submit <at> debbugs.gnu.org; Mon, 17 Jun 2024 10:47:25 -0400 Received: from mout.gmx.net ([212.227.17.20]:34327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sJDdg-00086U-NY for 71386 <at> debbugs.gnu.org; Mon, 17 Jun 2024 10:47:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718635631; x=1719240431; i=rudalics@HIDDEN; bh=sEWsOmCfQPuFa8BLn6F7WIWuJDLnfnaT/ZV7KMm9Mpg=; h=X-UI-Sender-Class:Content-Type:Message-ID:Date:MIME-Version: Subject:To:Cc:References:From:In-Reply-To:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ZgkdNEuLBzggFHnDM8e3Um1keiZrmdD73CmlpSxr5VYujJfDgVCuV3t9Gw7LJCQG sReAJaBqN2xgDNhb44TZrGnjUY408gDVnLE38C0zXecJFw9jtLDs22os2fmtDeAyO 2Y4xV3h+SClWxH4TYyKWhV9ADh1MMSh/uyPCZzyabbL2xLwcnIvCIJhqsK2+hQC9F 9zyOktNpVazGz6AuYKkB78gXW8aVuCb2QHzxMis9osphwQFq5TYuu6ECZkmcE7tTI DYcisXZ8/Y12mfbnHorJe7GhOOcPsJCgFV345+9JcboqmL3TtEka+Oz0nbosMO36d CmT3Fj5gU7+8hX5UsA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.42]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQMuX-1rxRd806wj-00UkrK; Mon, 17 Jun 2024 16:47:11 +0200 Content-Type: multipart/mixed; boundary="------------0zQl5pzA8P2OcERiXsfniyJ3" Message-ID: <87b7ee75-7c63-42ac-8551-c0d20a46ea43@HIDDEN> Date: Mon, 17 Jun 2024 16:47:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Al Haji-Ali <abdo.haji.ali@HIDDEN>, Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <m2frtdrwj1.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <m2frtdrwj1.fsf@HIDDEN> X-Provags-ID: V03:K1:iLeTvu495NgQJvOCuiiGgIq45GiVM5Pez+GLzkmmWWJngC7Kj+w Am6JBBTfkMBum8VQjEh4MD+55lgAc0V3rLbz6Di1z8ZcTh47r6mh09W51Wm1KlBr0dl0WqZ jS2ErOxXyVmk5DI8SGXMmM98GG+4aFz9CP2y0ABN1U1UUrmyL/ar4b/O9ftnN+sNfldK5zh gnzqJqK9SAApQARp+yJYA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:AH6EXGb1YwY=;rLBW52VG+iMqBFR41biGO0BQo56 iN94/EE3GxiZCGmBmDO+4dD7WkM4IHGi9lTpQnU51mk7RFBPTW6mjjcXSeqHcWqjZ0jL0NHRy 6MOSBMWj7RN10FPQFgJuvp74rpwqHrYhUpnZxb+KxwFtAfH+ml1qhrJU7nFChbptN8X5cQabV l2C+8dqYYpUqZed2qqnNmd4jSrEIks3CdAF9Ino0SlwdKfGraERD3Ll0n2Bo+7O2Jooa0y+6m MgX2MXut26trvF10YZPc+GkCygReyEOYDw0JPPxGTebRUUbhe6JBWVKiVsHDqwtYkxRzirxWn n1LfuuEkBBIeA7Q/I0SffSGa44AEa5JcxTnoPNikFoAsmk1rQUi1WaOvHiJYNs16vpcSM3cz+ dDgCzCw3imYPSzvoBw4jCUABMoauNoy3WN99yTaSoqi3PD+ZcfbvXTrLCAkMPGas6hZ9ZwDPs IUfEbuuO+apd1VckgZW9yG4ufdEgmlKIEAXNrfmCqpd6pG66WYYEoXEf0Xt/nIjsPc0v7Fhri qzk3m2TOfN7Bq8BuBAOpw+utle9uvWITOrr57QrSS2FBmT7V9QoMNAo+kEJ9RcuLHZuJiV+ex NyvzfhL+uGg7W+Y3WBMGBIQOJC9saBz9RH/+UHeG1GvlskOhoMi2J2kBq3LUuRSGi40envbW5 0XaoaqvAeArBTF2ruToz0QD0HKRyCGqdTqF8rgpLyfgagrty/UxpDEgeBAsVXsWNe3cDSm16W T4R6InNIqf2HXL6GWeX2M6xSMIMy9XuvbYzt2toK8GWrZ+KfU7LTkoMgabfUnn6Rdkzlq2kSH esFWRl48vzMOq1HlPmm4LZK6KVYS/89r3uNtQxvB8n6gM= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Also if the proposed change to `window-deletable-p` is adopted, then a > grep on `window-deletable-p` also reveals that, for consistency, > `delete-windows-on` and even `calendar-exit` in `calendar [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.42 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Also if the proposed change to `window-deletable-p` is adopted, then a > grep on `window-deletable-p` also reveals that, for consistency, > `delete-windows-on` and even `calendar-exit` in `calendar [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.42 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager This is a multi-part message in MIME format. --------------0zQl5pzA8P2OcERiXsfniyJ3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > Also if the proposed change to `window-deletable-p` is adopted, then a > grep on `window-deletable-p` also reveals that, for consistency, > `delete-windows-on` and even `calendar-exit` in `calendar.el` should > be modified similarly to `window--delete`. This means that we should do the entire fix within 'window-deletable-p', right? That's not an internal function, so we can, in all conscience, supply an abnormal hook as in the roughly tested patch attached. martin --------------0zQl5pzA8P2OcERiXsfniyJ3 Content-Type: text/x-patch; charset=UTF-8; name="window-deletable-functions.diff" Content-Disposition: attachment; filename="window-deletable-functions.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avd2luZG93LmVsIGIvbGlzcC93aW5kb3cuZWwKaW5kZXggNjA0 Yjk4Njg5MjEuLjA0ZTM4ZmFhMDc0IDEwMDY0NAotLS0gYS9saXNwL3dpbmRvdy5lbAorKysg Yi9saXNwL3dpbmRvdy5lbApAQCAtNDEwNCw2ICs0MTA0LDI3IEBAIG9uZS13aW5kb3ctcAog CShuZXh0LXdpbmRvdyBiYXNlLXdpbmRvdyAoaWYgbm9taW5pICdhcmcpIGFsbC1mcmFtZXMp KSkpCiAMCiA7OzsgRGVsZXRpbmcgd2luZG93cy4KKyhkZWZjdXN0b20gd2luZG93LWRlbGV0 YWJsZS1mdW5jdGlvbnMgbmlsCisgICAiQWJub3JtYWwgaG9vayB0byBkZWNpZGUgd2hldGhl ciBhIHdpbmRvdyBtYXkgYmUgc2FmZWx5IGRlbGV0ZWQuCitUaGUgdmFsdWUgc2hvdWxkIGJl IGEgbGlzdCBvZiBmdW5jdGlvbnMgdGhhdCB0YWtlIHR3byBhcmd1bWVudHMuICBUaGUKK2Zp cnN0IGFyZ3VtZW50IGlzIHRoZSB3aW5kb3cgYWJvdXQgdG8gYmUgZGVsZXRlZC4gIFRoZSBz ZWNvbmQgYXJndW1lbnQKK2lmIG5vbi1uaWwsIG1lYW5zIHRoYXQgdGhlIHdpbmRvdyBpcyB0 aGUgb25seSB3aW5kb3cgb24gaXRzIGZyYW1lIGFuZAorc2hvdWxkIGJlIGRlbGV0ZWQgdG9n ZXRoZXIgd2l0aCBpdHMgZnJhbWUuICBUaGUgd2luZG93J3MgYnVmZmVyIGlzCitjdXJyZW50 IHdoZW4gcnVubmluZyB0aGlzIGhvb2suCisKK0lmIGFueSBvZiB0aGVzZSBmdW5jdGlvbnMg cmV0dXJucyBuaWwsIHRoZSB3aW5kb3cgd2lsbCBub3QgYmUgZGVsZXRlZAorYW5kIGFub3Ro ZXIgYnVmZmVyIHdpbGwgYmUgc2hvd24gaW4gaXQuICBUaGlzIGhvb2sgaXMgcnVuIGJ5Citg d2luZG93LWRlbGV0YWJsZS1wJyB3aGljaCwgaW4gaXMgdHVybiwgaXMgY2FsbGVkIGJ5IGBk ZWxldGUtd2luZG93cy1vbicKK2FuZCBgcXVpdC1yZXN0b3JlLXdpbmRvdycuICBJdCBpcyBu ZWl0aGVyIHJ1biBieSBgZGVsZXRlLXdpbmRvdycgbm9yCitgZGVsZXRlLWZyYW1lJy4KKwor VGhlIHB1cnBvc2Ugb2YgdGhpcyBob29rIGlzIHRvIGdpdmUgaXRzIGNsaWVudHMgYSBjaGFu Y2UgdG8gc2F2ZSBhCit3aW5kb3cgb3IgaXRzIGZyYW1lIGZyb20gZGVsZXRpb24gYmVjYXVz ZSB0aGV5IG1pZ2h0IHN0aWxsIHdhbnQgdG8gdXNlCit0aGF0IHdpbmRvdyBvciBmcmFtZSBm b3IgdGhlaXIgb3duIHB1cnBvc2VzLiIKKyAgOnR5cGUgJ2hvb2sKKyAgOnZlcnNpb24gIjMw LjEiCisgIDpncm91cCAnd2luZG93cykKKwogKGRlZnVuIHdpbmRvdy1kZWxldGFibGUtcCAo Jm9wdGlvbmFsIHdpbmRvdykKICAgIlJldHVybiB0IGlmIFdJTkRPVyBjYW4gYmUgc2FmZWx5 IGRlbGV0ZWQgZnJvbSBpdHMgZnJhbWUuCiBXSU5ET1cgbXVzdCBiZSBhIHZhbGlkIHdpbmRv dyBhbmQgZGVmYXVsdHMgdG8gdGhlIHNlbGVjdGVkIG9uZS4KQEAgLTQxMzcsMTQgKzQxNTgs MjAgQEAgd2luZG93LWRlbGV0YWJsZS1wCiAJCSAgICAoYW5kIG1pbmlidWYgKGVxIGZyYW1l ICh3aW5kb3ctZnJhbWUgbWluaWJ1ZikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgKG5v dCAoZXEgKGRlZmF1bHQtdG9wbGV2ZWwtdmFsdWUKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICdtaW5pYnVmZmVyLWZvbGxvd3Mtc2VsZWN0ZWQtZnJhbWUpCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdCkpKSkpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdCkpKSkKKwkJICAobm90ICh3aXRoLWN1cnJlbnQtYnVmZmVy ICh3aW5kb3ctYnVmZmVyIHdpbmRvdykKKwkJCSAocnVuLWhvb2std2l0aC1hcmdzLXVudGls LWZhaWx1cmUKKwkJCSAgJ3dpbmRvdy1kZWxldGFibGUtZnVuY3Rpb25zIHdpbmRvdyB0KSkp KQogCSdmcmFtZSkpCiAgICAgICgod2luZG93LW1pbmlidWZmZXItcCB3aW5kb3cpCiAgICAg ICA7OyBJZiBXSU5ET1cgaXMgdGhlIG1pbmlidWZmZXIgd2luZG93IG9mIGEgbm9uLW1pbmli dWZmZXItb25seQogICAgICAgOzsgZnJhbWUsIGl0IGNhbm5vdCBiZSBkZWxldGVkIHNlcGFy YXRlbHkuCiAgICAgICBuaWwpCi0gICAgICgob3IgaWdub3JlLXdpbmRvdy1wYXJhbWV0ZXJz Ci0JICAobm90IChlcSB3aW5kb3cgKHdpbmRvdy1tYWluLXdpbmRvdyBmcmFtZSkpKSkKKyAg ICAgKChhbmQgKG9yIGlnbm9yZS13aW5kb3ctcGFyYW1ldGVycworCSAgICAgICAobm90IChl cSB3aW5kb3cgKHdpbmRvdy1tYWluLXdpbmRvdyBmcmFtZSkpKSkKKwkgICAod2l0aC1jdXJy ZW50LWJ1ZmZlciAod2luZG93LWJ1ZmZlciB3aW5kb3cpCisJICAgICAocnVuLWhvb2std2l0 aC1hcmdzLXVudGlsLWZhaWx1cmUKKwkgICAgICAnd2luZG93LWRlbGV0YWJsZS1mdW5jdGlv bnMgd2luZG93IG5pbCkpKQogICAgICAgOzsgT3RoZXJ3aXNlLCBXSU5ET1cgY2FuIGJlIGRl bGV0ZWQgdW5sZXNzIGl0IGlzIHRoZSBtYWluIHdpbmRvdwogICAgICAgOzsgb2YgaXRzIGZy YW1lLgogICAgICAgdCkpKSkK --------------0zQl5pzA8P2OcERiXsfniyJ3--
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 17 Jun 2024 06:17:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 17 02:17:51 2024 Received: from localhost ([127.0.0.1]:59317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sJ5gc-0007fs-KC for submit <at> debbugs.gnu.org; Mon, 17 Jun 2024 02:17:50 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:57321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sJ5gb-0007fT-1R for 71386 <at> debbugs.gnu.org; Mon, 17 Jun 2024 02:17:49 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5F31BE0007; Mon, 17 Jun 2024 06:17:37 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <86a5jksv4k.fsf@HIDDEN> (Juri Linkov's message of "Sun, 16 Jun 2024 19:45:55 +0300") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> <86a5jksv4k.fsf@HIDDEN> Date: Mon, 17 Jun 2024 09:16:44 +0300 Message-ID: <861q4w14c3.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> + ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) >> + 'tab) >> >> How would users get back the old behavior? By customizing >> 'tab-bar-close-last-tab-choice', 'tab-bar-tab-prevent-close-functions'? > > This patch just copies the logic of frame handling to tab handling. > There is no customization for frame handling, so there is > no customization for tab handling. > > In window-deletable-p there is hard-coded 'frame-root-window-p' > that checks if the frame has only 1 window. So the patch > does the same by checking if there is only 1 tab on the frame. > > Also in window--delete the call of 'tab-bar-close-tab' > corresponds to the call 'delete-frame'. Please see a more correct patch: diff --git a/lisp/window.el b/lisp/window.el index cf5c07395ab..588014b8f77 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4138,7 +4138,9 @@ window-deletable-p (not (eq (default-toplevel-value 'minibuffer-follows-selected-frame) t))))) - 'frame)) + (if (and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) + 'tab + 'frame))) ((window-minibuffer-p window) ;; If WINDOW is the minibuffer window of a non-minibuffer-only ;; frame, it cannot be deleted separately. @@ -4979,6 +4981,9 @@ window--delete (unless (and dedicated-only (not (window-dedicated-p window))) (let ((deletable (window-deletable-p window))) (cond + ((eq deletable 'tab) + (tab-bar-close-tab) + 'tab) ((eq deletable 'frame) (let ((frame (window-frame window))) (cond
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 16 Jun 2024 16:53:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 16 12:53:47 2024 Received: from localhost ([127.0.0.1]:43615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sIt8U-0002T3-PH for submit <at> debbugs.gnu.org; Sun, 16 Jun 2024 12:53:47 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sIt8S-0002Sf-W6 for 71386 <at> debbugs.gnu.org; Sun, 16 Jun 2024 12:53:45 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6A8F440003; Sun, 16 Jun 2024 16:53:34 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> (martin rudalics's message of "Sun, 16 Jun 2024 09:52:26 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> Date: Sun, 16 Jun 2024 19:45:55 +0300 Message-ID: <86a5jksv4k.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > + ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) > + 'tab) > > How would users get back the old behavior? By customizing > 'tab-bar-close-last-tab-choice', 'tab-bar-tab-prevent-close-functions'? This patch just copies the logic of frame handling to tab handling. There is no customization for frame handling, so there is no customization for tab handling. In window-deletable-p there is hard-coded 'frame-root-window-p' that checks if the frame has only 1 window. So the patch does the same by checking if there is only 1 tab on the frame. Also in window--delete the call of 'tab-bar-close-tab' corresponds to the call 'delete-frame'.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 16 Jun 2024 10:52:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 16 06:52:13 2024 Received: from localhost ([127.0.0.1]:45926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sInUa-0005Js-Kl for submit <at> debbugs.gnu.org; Sun, 16 Jun 2024 06:52:13 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:57819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sInUY-0005JV-UR for 71386 <at> debbugs.gnu.org; Sun, 16 Jun 2024 06:52:11 -0400 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-35dc9cef36dso3241673f8f.3 for <71386 <at> debbugs.gnu.org>; Sun, 16 Jun 2024 03:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718535064; x=1719139864; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=RAXAG/5vLd9YwUf7Y80TMRKtX0nbwclKw5ohxgB/0T4=; b=MAcYluCHbZ7eXcHj/EIqTSbidSgE8FLwMHPsbsOvjQZbOclTe89Qcwc+T9wMpxQDm5 79Fevhl8PsVXIeJVlUwhCkRG1Gk/andTVmpWjRwHLBxic8HWODYHf+L8UZpuUglvol0U BRmZTXRnsmKMo4YiP3h71SxrEzyA7nChGrrqGs2HXiBKA7JFq5KeQv4+aD+S/8zeBNhM l0Edqf2gsIlwrXkUr7eFYYlRKuu4htidyZoBkJr8IeY/zkLW1Us+0EsPx7Ph4uUhiXjO ftZtGFTfvWvhOiqn6+SskAl4OWw9j0iZ4bFTDoSpnVgKuTBQrs/wq84ib7MkXpLvnmY5 23bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718535064; x=1719139864; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RAXAG/5vLd9YwUf7Y80TMRKtX0nbwclKw5ohxgB/0T4=; b=qzzXBaYPp5wN5b6TcumAtvmxU0Pd1ltbxK41c11ITM0ZOShmVczYHGoigseZoWYHKi xtgWHnxX8EF5my1FlXj7ib/rNUeCJ19amhGRq5RLPYy2Fxgn8Ru0d4qbzK2cg14IBSWg liOBkem6Tx7ZBcmrS3oLh5dqPir3/TJ67R6dSN3dvwjnMMQftXMAUr4dHdrE1Df1EYEp gpZweEyZS8xjDImiMFZwYBpdf8mzrRGKB4Gkg2waPhMqzEm0hCu8cPbMpygH+eypCqzi eKqCFlwUm1H9FO6+5Y0osRRR3Pe3oLh+SClQ1TkJqzFt2qimlz8GwTLdqMxHKCsYWAva qACQ== X-Forwarded-Encrypted: i=1; AJvYcCXvBC+N7W+bZfnu8Wc3f/HGJo7jfAkEb8iodJtthiEqC4qINn8urCoLGb5Yc6nwkL1qPHKSMIglg/dZeHQ2S8DD4ngN9OI= X-Gm-Message-State: AOJu0YxcNGibFP48J/ATl7ZuXcNBDYuy2+kqx3LPWmrP2blR1y2weIPa jjUPXXcH8ooVxIQSrtgU2mRUml1z8tqqijuppM6GJad/oCEJMLsY X-Google-Smtp-Source: AGHT+IGg87WZaQWCRlRWSMT5eS/rDBS4j2rRXA75cSkM2hl+uEIU9lwBKWziOU57QhYg6m3sHdoMlQ== X-Received: by 2002:a05:6000:249:b0:35f:20eb:4831 with SMTP id ffacd0b85a97d-3607a75c664mr4384301f8f.38.1718535063447; Sun, 16 Jun 2024 03:51:03 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3607509c883sm9280788f8f.29.2024.06.16.03.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jun 2024 03:51:02 -0700 (PDT) From: Al Haji-Ali <abdo.haji.ali@HIDDEN> To: martin rudalics <rudalics@HIDDEN>, Juri Linkov <juri@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> Date: Sun, 16 Jun 2024 11:50:58 +0100 Message-ID: <m2frtdrwj1.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 15/06/2024, martin rudalics wrote: > I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p' > as mentioned earlier) for two reasons. > This is probably the right approach to minimize unattended consequences and it would definitely address the issue (which is, to reiterate, is that fundamentally, tabs behave like windows in many situations, but not when deleting buffers with dedicated windows -- having two windows prevents deleting a frame, but not having two tabs). I imagine Juri wanted to avoid having tab-specific code in `window.el` with the previous patch, hence the more generic hooks. The current patch of Juri should probably be protected with `featurep` or `fboundp` for tab-specific symbols. Also if the proposed change to `window-deletable-p` is adopted, then a grep on `window-deletable-p` also reveals that, for consistency, `delete-windows-on` and even `calendar-exit` in `calendar.el` should be modified similarly to `window--delete`. Best regards, -- Al
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 16 Jun 2024 08:10:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 16 04:10:21 2024 Received: from localhost ([127.0.0.1]:35526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sIkxw-0006mr-JM for submit <at> debbugs.gnu.org; Sun, 16 Jun 2024 04:10:21 -0400 Received: from mout.gmx.net ([212.227.15.18]:57833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sIkgl-0005yE-J6 for 71386 <at> debbugs.gnu.org; Sun, 16 Jun 2024 03:52:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718524347; x=1719129147; i=rudalics@HIDDEN; bh=5jJq9AIqbqervT1xEK4Vaex4a7/z1hW8SfjB62GhUJQ=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=cMZNpRg1JSGZ5qpZ7VdP2MaJ5NNrOWLEEMGk8y7XNpg2/FSYhVIQ6F4RmujEmIyZ tXe3T7mWMYMHsFRXiG2TQNglGXUFVLHAPiihL1UjGzrfqB6C3dWvfPxQjHQ+VQwT0 CJri1qKQ4qdUjl26xOCvwom4aiVfzenGShDNiM7nM8sW8hlVK/OeflX7Jh8Di53Ir 47QOYjeeVfR6umWLnIbiqgxUFtDtA3cERsk4tVsT5+kcXrd74YHDjvtFwtNNMbsBb F3i1Qfr8rtKLFymRP2mDOP8HBspxfX9SYfP9TsM0vroCKRcSo7GvZoFNWfgCxQpwT HcKcITi2n4OykB+ulg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([213.142.97.154]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2V0H-1sNwG42C7T-00wnFj; Sun, 16 Jun 2024 09:52:27 +0200 Message-ID: <eae268e4-16c4-4170-aede-5bd53a00d0e3@HIDDEN> Date: Sun, 16 Jun 2024 09:52:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> <86frtdtlns.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86frtdtlns.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:NyHR27kGLx71N6V44CLvjMVnr9dTg3z5Qpg0kovhPEjdunLdrea feAlYOx4Jj2Bs8C+mk5LfP1c13kwyzuitzPPxLBjHt+MhpG0+EpqzTl6XXzsBZacAJmZwso DM1v2VtkhYNO/QujCPbseZMHkZaD2zYEf6kR8wO3OLmaJF5sFPLnC6MskhkelQ9pcB624hz 3cIuSTqkUSOrvLjbaF5Jg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:jhFq7nhIi6c=;nXUMF02GGOcRpos5sxhhtZjpE8/ nGPAtJ7kDpjngdgkVVdJeb26iOPNakfqN+uWu1TgZseMcMhLG5jQzwwm61UlfMxwWf+ZziS34 HgH9H3e0saeQfv3bIZiMpmz5krRkyH+78SqyKyokm/VxE5RdVoifGct/e6AB17iAbMI57uq5k ZjXaK24vshKjkoieYbSO+MqXZMZPXAk8QkfaMo31w/bb0ktDeN8ZY1DPvFMmPJd6i9HeUT8UQ WPktLSaRJQuA6o8dshsmOnDxm0DyAmfADA3hmoo7OUl0/gCCbdp/3crui7f3broKaqOeKLRCR YtJUqOBBxFHrSUHsAThQJuc3hfuJj8XuFYR4CdkkeRZcbO1gFK6+wZC5xB5TUp8DEX1CS1k4P Swz/M/VVG0NQrA0SM0mby6sBv8/tMhWIj43YNrUnvZbte/SB1uOoeOkRN3XbPXvHswH/NaZca dhz4E5sScnWksUtsPx2cMqCBWPfAqIq8ohUuOEC+QecsuQWuNTVFrZS5Iwp7JJzoOrEy5YN7B pGMg26WnRt3LKks0rfH9DFtXcg/DFO4Z/Spt7ODAbIImWl532gs/GETsdP0OGa3fSPpNEHwFB TYHZi2SucgS/PgvACvCpRe8Kr6M08uMw3lh/IGuAIh1ShgS5T5h37TFH1Fqi9cR6XkTRzCmdS 58FWcSWWXG3ppr/DLfleZ0JbRIo3ZqAyAlEECOq0UILQdJ2rcTXN8c6IrW7OixV/YmDT0866H YUXM7lzoYoet2qUmGrbAU2sEnpPA7cusI05ULxL42/fLW9prk9m0F+GF9iKNXhMzXuSedwh+P uYqoE7XVU0azdb5HMIHyytx7hET6OF7woY8KQLseOb6Ao= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: + ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) + 'tab) How would users get back the old behavior? By customizing 'tab-bar-close-last-tab-choice', 'tab-bar-tab-prevent-close-functions'? Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [213.142.97.154 listed in zen.spamhaus.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: + ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) + 'tab) How would users get back the old behavior? By customizing 'tab-bar-close-last-tab-choice', 'tab-bar-tab-prevent-close-functions'? Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [213.142.97.154 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager + ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) + 'tab) How would users get back the old behavior? By customizing 'tab-bar-close-last-tab-choice', 'tab-bar-tab-prevent-close-functions'? martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 16 Jun 2024 07:04:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 16 03:04:51 2024 Received: from localhost ([127.0.0.1]:59445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sIjwZ-0003n8-0J for submit <at> debbugs.gnu.org; Sun, 16 Jun 2024 03:04:51 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:35275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sIjwX-0003mm-1n for 71386 <at> debbugs.gnu.org; Sun, 16 Jun 2024 03:04:49 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id CABE340002; Sun, 16 Jun 2024 07:04:20 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> (martin rudalics's message of "Sat, 15 Jun 2024 10:42:05 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> Date: Sun, 16 Jun 2024 09:58:10 +0300 Message-ID: <86frtdtlns.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > +(defvar window-delete-frame-functions nil > + "A list of functions to handle the frame deletion. > > I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p' > as mentioned earlier) for two reasons. > > The first reason is that 'window--delete' is an internal function of > window.el. I wouldn't want an internal function run a hook "of its own" > because that's difficult to explain to users. OTOH I suppose that a > function like 'tab-bar-save-frame-p' should be callable from any other > function too, as soon as the need arises. > > The second reason is that I wouldn't want "anyone" to inhibit frame > deletion. Such a facility could have consequences I cannot fathom at > the moment. Would we want 'delete-frame' to obey it too and possibly > spare the frame? Ok, here is the right patch: diff --git a/lisp/window.el b/lisp/window.el index b7bd59bc813..872110a8321 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4120,6 +4120,8 @@ window-deletable-p (let ((frame (window-frame window))) (cond + ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)) + 'tab) ((frame-root-window-p window) ;; WINDOW's frame can be deleted only if there are other frames ;; on the same terminal, and it does not contain the active @@ -4979,6 +4981,9 @@ window--delete (unless (and dedicated-only (not (window-dedicated-p window))) (let ((deletable (window-deletable-p window))) (cond + ((eq deletable 'tab) + (tab-bar-close-tab) + 'tab) ((eq deletable 'frame) (let ((frame (window-frame window))) (cond
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 15 Jun 2024 08:42:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 15 04:42:16 2024 Received: from localhost ([127.0.0.1]:54701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sIOzH-0005Iw-TE for submit <at> debbugs.gnu.org; Sat, 15 Jun 2024 04:42:16 -0400 Received: from mout.gmx.net ([212.227.17.20]:47539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sIOzF-0005IT-Vk for 71386 <at> debbugs.gnu.org; Sat, 15 Jun 2024 04:42:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718440926; x=1719045726; i=rudalics@HIDDEN; bh=d3hP/J70rHVA2Wk3P9Vrgeo2UUr2AjLrHtYyieG7sHk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=UosBEbLgwCMq5frmh+mwd8INWBzUEJhhJ6JXNEDdiiRpm+9OrG8u5ITKhCCbHmMg Swp56OYpUbs7ig++4ODZaUnIXDj5+kw2fuH0kCzTe7KVMd9MT0IVbyl9nuwBOck6v VPM2YRhtpN1stL5Darq/wedvA7YYxm5OJS9wa2Jb6ZENuysS0ax/BDKjObWaCaJ0l YLikHWZUluwvBUGwhIcn6LXdlgIYX0hUdykmcRQZU2G631QXW8QI+EYgEgvVychg+ H+yGs9MSErOm6SHzIA4khpnSwC+rYBcnytHVwDggLBpjbR6tU49gcyjv+wzXvlvA7 9bJUhEtWLmFIT4encg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.155]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MkYbu-1sgEU42HMc-00ddle; Sat, 15 Jun 2024 10:42:06 +0200 Message-ID: <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@HIDDEN> Date: Sat, 15 Jun 2024 10:42:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> <8634pfe735.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <8634pfe735.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:I4Brdv1J+y4TbAbZz2QL9IYNRN28SFMJp/MOxFCsm01lLRXXs4A ACvOe3FcrBNqCztxaW4UqTPlmNoBau8E3y0aN1jsljTwYuJ7Na/ny4c94Ynujx9DtIZ9TQ4 mhrBXC/dwPfbImS5usRhUD2QXOhoZi5fVJgXlq6BFUuuIRU8lOGD3N8Gb6L1UFcqSXRdbMk KGid07DXSBfHUrLu8a6/w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:PlqkJroizbE=;ffQPEMDLwEcGvxrzJRN45qgTSf7 IGFeQgfgyayDnV+cXpEGNrX22k1+NfChV87YPNa1y4fPr6Nak2cD7b0cYFTYaw9k2TkSnX4Au cTkahqGJiaJq8KerZ+iL0F7ZwiXszjIqxL/6kvrfj1Gk6zrEr5WWre9vvnCue1n9m0F2uHwjq KZykt8gj1l37OCW0a4NUXyW9ACTRRUwn/d5EEBCqx0nfogLNozhgKBfKjU+E1QZJvxFzUf18F rhuYAeAN9k/sf3TfwQtd32If5x7OL6QOYE92HP9LAx9u0pXUDBgEczuZKH6Z5IwP6ls/9w8kb Up32yTTBWtr8YVDdVUdHdn566cyW80/HX3giScVVHD4Gd7g5UHd+9v0uNO1XU970E4yBXYQFF J+b5KipIskPLLXp/3eIwR4LBUgFmxd/+TPAVp90a9mra82A9vLoqWMPzx3KFU5gqnpOrOvk6Q o5sEwNfLMhre/0A2IggO4AcxH+MxQGtuGEwkFmFADUUejAq/5gn1WNoIqyvAmdBjsl7YMAXvj neJiGsZHlphyN1JofoLQkOfbKFjb2VmjvJJ1qv4yTCcEbs5Boe3p96FglmhjXTylb2/8x7hKG Pd/LmYjRbwpOS4k19FsqjPIbZC3TqDVaCTzcRbYCq7fppN5KSp7kPGS9scw5vUiGEB3VsI9Zy 6YJ4as+OhNy+RqyEl+cvWjvRmfYNoMmMm58BALXAbhTAlzb82xON8/rXR94PuLoQcZygt9heu rbn4NpgFxDA48uPi1nuS1SPH4YP86yd2ACoK1NGGcVy9+ZkrbpnBwr9qOJ382Qrjgol6KlAKS fOkWCrmJzrnwE+Et5nD3526y3aj990KgUEiVvDhtzZubo= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: +(defvar window-delete-frame-functions nil + "A list of functions to handle the frame deletion. I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p' as mentioned earlier) for two reasons. Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.155 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: +(defvar window-delete-frame-functions nil + "A list of functions to handle the frame deletion. I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p' as mentioned earlier) for two reasons. Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.155 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager +(defvar window-delete-frame-functions nil + "A list of functions to handle the frame deletion. I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p' as mentioned earlier) for two reasons. The first reason is that 'window--delete' is an internal function of window.el. I wouldn't want an internal function run a hook "of its own" because that's difficult to explain to users. OTOH I suppose that a function like 'tab-bar-save-frame-p' should be callable from any other function too, as soon as the need arises. The second reason is that I wouldn't want "anyone" to inhibit frame deletion. Such a facility could have consequences I cannot fathom at the moment. Would we want 'delete-frame' to obey it too and possibly spare the frame? Let's see what Haji-Ali thinks. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 14 Jun 2024 18:04:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 14 14:04:54 2024 Received: from localhost ([127.0.0.1]:40893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sIBIE-0004cg-0i for submit <at> debbugs.gnu.org; Fri, 14 Jun 2024 14:04:54 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sIBI6-0004c5-Ce for 71386 <at> debbugs.gnu.org; Fri, 14 Jun 2024 14:04:49 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 18CE4E0003; Fri, 14 Jun 2024 18:04:18 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> (martin rudalics's message of "Thu, 13 Jun 2024 10:21:43 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> Date: Fri, 14 Jun 2024 20:46:06 +0300 Message-ID: <8634pfe735.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >>> But KILL means to delete the frame and the tab-bar code wants to prevent >>> that. Or what am I missing? >> >> For frames KILL defines whether to delete or iconify the frame. >> There is no such thing as to "iconify" the tab. > > Don't you want to distinguish 'kill' non-nil where the frame should get > deleted from 'kill' nil where nothing is done? In the latter case the > window cannot even be deleted because when the return value of > 'window-deletable-p' equals 'frame' this implies that WINDOW is the root > window of its frame. This is the best that I can do, you can improve it if you want: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=window-delete-frame-functions.patch diff --git a/lisp/window.el b/lisp/window.el index 604b9868921..155b0b55482 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4948,6 +4968,13 @@ frame-auto-hide-function :group 'frames :version "26.1") +(defvar window-delete-frame-functions nil + "A list of functions to handle the frame deletion. +Each of functions is called with two arguments: FRAME and KILL where +KILL means the buffer shown in window will be killed. When one of functions +returns a non-nil value then `window--delete' will not delete the frame. +The function can also perform own action instead of deleting the frame.") + (defun window--delete (&optional window dedicated-only kill) "Delete WINDOW if possible. WINDOW must be a live window and defaults to the selected one. @@ -4962,6 +4989,10 @@ window--delete ((eq deletable 'frame) (let ((frame (window-frame window))) (cond + ((run-hook-with-args-until-success + 'window-delete-frame-functions + frame kill) + nil) (kill (delete-frame frame)) ((functionp (frame-parameter frame 'auto-hide-function)) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 6ab6324540e..2f7578b842b 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -2659,6 +2659,17 @@ tab-switcher-mouse-select (goto-char (posn-point (event-end event))) (tab-switcher-select)) + +(defun tab-bar-window-delete-frame (frame _kill) + "Handle frame deletion in `tab-bar-mode'. +When there are more than one tab on the selected frame, then close +the current tab. In this case return t to not delete the frame +in `window--delete'." + (and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1) + (progn (tab-bar-close-tab) t))) + +(add-hook 'window-delete-frame-functions #'tab-bar-window-delete-frame) + (defun tab-bar--reusable-frames (all-frames) (cond --=-=-=--
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 14 Jun 2024 06:16:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 14 02:16:53 2024 Received: from localhost ([127.0.0.1]:39604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sI0F3-00086p-6T for submit <at> debbugs.gnu.org; Fri, 14 Jun 2024 02:16:53 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:52521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sI0F0-00086a-F5 for 71386 <at> debbugs.gnu.org; Fri, 14 Jun 2024 02:16:52 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 347DD1BF204; Fri, 14 Jun 2024 06:16:22 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> (martin rudalics's message of "Thu, 13 Jun 2024 10:21:43 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> Date: Fri, 14 Jun 2024 09:13:16 +0300 Message-ID: <86a5jof3uv.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> But KILL means to delete the frame and the tab-bar code wants to prevent >>> that. Or what am I missing? >> >> For frames KILL defines whether to delete or iconify the frame. >> There is no such thing as to "iconify" the tab. > > Don't you want to distinguish 'kill' non-nil where the frame should get > deleted from 'kill' nil where nothing is done? In the latter case the > window cannot even be deleted because when the return value of > 'window-deletable-p' equals 'frame' this implies that WINDOW is the root > window of its frame. I still don't understand how frame deletion should be handled for tabs for this bug report and for bug#59862. Probably need to study more.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 13 Jun 2024 08:21:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 13 04:21:54 2024 Received: from localhost ([127.0.0.1]:33741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sHfiT-0006Nl-Le for submit <at> debbugs.gnu.org; Thu, 13 Jun 2024 04:21:53 -0400 Received: from mout.gmx.net ([212.227.17.22]:34357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sHfiR-0006NM-DJ for 71386 <at> debbugs.gnu.org; Thu, 13 Jun 2024 04:21:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718266905; x=1718871705; i=rudalics@HIDDEN; bh=Qb6Rv+D17oCdXfxn9aNK5U59UQoa2C1FvbW+Ak666Kg=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=XY70qmFwVc3qQ/bY9fEHKCTnRlbT14F6EdHgwAmWwYovaOQZOd//rMwgrwyRM/UP /xuP6xYM1sVSVX/RomsZalfPqIJ0xHvKRhpXWJyGZnt/OhuChDcZ6ajCtDD2ZgETZ Kh2LAamy+uojhjIsvyLwu3O5vbmCCYfjCy87NpdXzlC4NMfI8OC08fT8NyEuRmk5C WKP1hC5w/gpq0u+I06LsTF93iwCYsNXtS7cgh/6VnvosmRIhdk0rGc6AfgpIeOXsu jmo6qJTC3BKrhqXfukhuajLDDRxlMSyiCPmuq63eywWiBQC/MeG24nt0XSLDRNkbQ V4BSMoceG4s0squK5w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.56]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MNt0C-1s2LmT00YS-00SHje; Thu, 13 Jun 2024 10:21:45 +0200 Message-ID: <db60970d-f5c8-4ad7-b7d1-e39c61a81580@HIDDEN> Date: Thu, 13 Jun 2024 10:21:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> <86r0d1iaxc.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86r0d1iaxc.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:QvLNVoku7l3G3U27Bt252whY/abDs/DCh9toBaSWbKXG6vL+MXI CH2XNArc64uegUogO5W5pQpQ/yG8irz6gDjA3w69sPVgH0KgLzQ6m+dkGRcVGw6FmR+vwbR h4ly8lf6OVEI3Co9X3lDkgKYJOVppRsHXzSYiaqFUZwSUqK4MggHaVXGGn2hmw4FgQRIFei Fx/tQhz3G854BVo6sTPJg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qsqv1Q6sT78=;PSLdtIGIqFiT0HWyN9eie68Nq25 l1Dcf2CT4V25M4fP1d8t1r62pYtMCPu4LO7KMhniejl9wwfzEqyoFzT08tqeZWhbXJC/HMA/e H4Wyq6uCq+BmFNGYQoNyTiHMHAAuPYcj34f+n9GXUoKOATLSVKIFfCQknJe/VFGjo/UjGTBkj X/Iqetv95sUY9J3jwiycOx6JoS1NwoCKwB1tgjG75VYH65ZUtpp84NB7f2CHRrE953NHaTDvR T8Z8OdXhchPLpi2aT4IoqmozZ1p2xrH83gCCXPFQdJpKnOaNSN9I8COQxNBnqNs8JiIQkyKQR HVI2o7AFQcCa+wp4P8exU+GgqC8uoSVArHjmw2oDwuiEZRtb4DWL0vOeYDWb1VdON9eTDJL2K XqmUHvuq0dIbCZ/SGEIT5MJhKEqeS8uhdfNfAF1USqNylzs+VAPnfq1Tkb6zv4Q36js3LVlIa qaAo13N1GMiYHQq9fmHxr83D1wGoQXS2cR4Ax+idTzYfvgQBKu5B6E2tlLqBLIO5XyKC6oZUM 4h1Wr0yNPfsGteSYGmGvaYL17y4afqT0sn+ng0KsmdDUvYy5eH4ql7hcHW54CIpLLwgR7d9XZ JmjRJrJW3tGL+jexm3UunV2dud8tGT66cl6Nt9ffC70QOfZzSsWIusrw52fiNmSJQhAugFlkV HFf7J1O+or93AZ+Dd5uR34KhHdknFOaVyBG4AyqSaLUwgMiQop4CbdCnkFWhbFBV4gw0eZRIB M8jykDIjZskGsj72uabPUt8V1mx/y2D8I0u+QWvH8Cfrsvf0JcmDXXKG/u9EobQW9RCVQfHi5 2AGIoZ/PwBA1/7fP1fw0OmzBlNPegBFSaeUHkKO+vct34= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> But KILL means to delete the frame and the tab-bar code wants to prevent >> that. Or what am I missing? > > For frames KILL defines whether to delete or iconify the frame. > There is no such thing as to "iconify" the tab. Don't you want to distinguish 'kill' non-nil where the frame should get deleted from 'kill' nil where nothing is done? In the latter case the window cannot even be deleted because when the return value of 'window-deletable-p' equals 'frame' this implies that WINDOW is the root window of its frame. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 13 Jun 2024 07:13:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 13 03:13:46 2024 Received: from localhost ([127.0.0.1]:57877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sHeeY-0003X7-7G for submit <at> debbugs.gnu.org; Thu, 13 Jun 2024 03:13:46 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sHeeT-0003WI-4c for 71386 <at> debbugs.gnu.org; Thu, 13 Jun 2024 03:13:41 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0358540007; Thu, 13 Jun 2024 07:13:13 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Al Haji-Ali <abdo.haji.ali@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <m234pjqwdd.fsf@HIDDEN> (Al Haji-Ali's message of "Tue, 11 Jun 2024 17:26:06 +0100") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <m234pjqwdd.fsf@HIDDEN> Date: Thu, 13 Jun 2024 09:50:23 +0300 Message-ID: <86zfrpib04.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: martin rudalics <rudalics@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> So it makes no sense to send the value of the KILL arg to tab-bar code? >> Because there is nothing to decide based on its value? > > Perhaps, for consistency, the argument should be send in case > `window-delete-frame-functions` is used for other reasons by the > user. Also, perhaps the tab should not be closed if `kill` is nil (similar > to how the frame is not killed if `kill` is nil) and another buffer should > be shown. If I read `window--delete` code correctly, the frame goes away in any case: (kill (delete-frame frame)) ((functionp frame-auto-hide-function) (funcall frame-auto-hide-function frame)) If `kill` is nil, the frame gets hidden: the default value of `frame-auto-hide-function` is `iconify-frame` that is like closing the tab too.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 13 Jun 2024 07:13:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 13 03:13:27 2024 Received: from localhost ([127.0.0.1]:57849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sHeeF-0003Vq-I4 for submit <at> debbugs.gnu.org; Thu, 13 Jun 2024 03:13:27 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:40371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sHeeE-0003VV-BI for 71386 <at> debbugs.gnu.org; Thu, 13 Jun 2024 03:13:26 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id A9BEAE0006; Thu, 13 Jun 2024 07:13:17 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> (martin rudalics's message of "Wed, 12 Jun 2024 10:57:47 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> Date: Thu, 13 Jun 2024 09:53:03 +0300 Message-ID: <86r0d1iaxc.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> So it makes no sense to send the value of the KILL arg to tab-bar code? >> Because there is nothing to decide based on its value? > > But KILL means to delete the frame and the tab-bar code wants to prevent > that. Or what am I missing? For frames KILL defines whether to delete or iconify the frame. There is no such thing as to "iconify" the tab.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 12 Jun 2024 08:57:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 12 04:57:55 2024 Received: from localhost ([127.0.0.1]:37525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sHJnn-0006Pp-2p for submit <at> debbugs.gnu.org; Wed, 12 Jun 2024 04:57:55 -0400 Received: from mout.gmx.net ([212.227.17.21]:46719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sHJnl-0006Pb-TW for 71386 <at> debbugs.gnu.org; Wed, 12 Jun 2024 04:57:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718182668; x=1718787468; i=rudalics@HIDDEN; bh=6Pohvv7DyTM+UpEqMPvnMRENn2TNOaLgLQSPPGoiqAM=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=QMP56M4txRKUZtGkoSQ7rEk/FhYcvkEw2J5XsB/qxN7XWKrWp7iYULWto2RAA6D6 O/a2vMX+6RuAExz5DAofpA6clTrmT5CXExtISdEuyzvQ3737vlS4W4V4jfvrj1GaK XW/gih9zKyj2hGNGOjm1Cyoy0nwP8NuQMtrNZEvkQj5oUi9nmqUF0sNPWz5my1Zgb V2dNEU6rrf8A9A789VElDLqKSodBQduqKyaJbEfvq0Ehhqvl3LhKaXEFIE4P/Gszk EfwvSn03+MHfBUctwNfbywzTsz9HS57woVsLliPrqhruYW0kNNVzoBLNg8h7vz8T6 9pMJNIcK/fqOf7xleQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([46.125.249.118]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mo6ux-1skJlv0pvX-00mP0n; Wed, 12 Jun 2024 10:57:48 +0200 Message-ID: <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@HIDDEN> Date: Wed, 12 Jun 2024 10:57:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86frtkeyzo.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:f+kxt2emDxkkXmdGuKDhzDpnK0UQq4RGIpztic2ZaxMQ1bpAwbQ KenMSxfpF1NCLYPMfNQSEGYm9KoCv5qkahk4JlP1Ct9EAhps8UyW+7QNR+SniQyM4FYMiqE F7WArW3S8ln5B/AVGDNcivDxAyV0l5vxWBRLOV4uNqpvu5Oyle3p65aalVYCdoPajfJSoir hvP1HMlDVIqIU+t1n0JHA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rLL2soZG4k8=;zTkTQ47VWPqXopKG6X/O2Jtrr4p rzXtudBLwRzMlA7AHeL5DVGWqtLjx98E+iQp/MDdR8GutPFiUkmRBI8LKYrtCI01fkMSrRz5P rGLGJsoYaW2yWx/xvXjPg3zzetg13U+LzXdiMnZBCRZ8GEIjUgVMF5ushHHToIK3Df8jQhKbW h3KS+8J3MDGEIXa8tRkra3MM2mf2/2JPCS5kN0/qFi3jr1bLvWRDubX1z0pB1r8CZyHV2sEoi 7QA/qdLwAb16jqU6RwhGh+8SyUfIHMqTukyrS+NcM/pl4A+o++sY7G3lXtoCDtlh61okNM0cG lqYJBTmzMhqda2J8C0l/A34FvEVZv++jahvBn8WBloGG0z+tNph1OnOHzwq2IeRKEHFREfuUH 2pk1Qha93NaSdipTtJDk4GLDPvUFDsmIuuabmNBHdCihE2sHGDkDZDbWaw9ZfolYBkfrZXqBA Dvvjkb5Wz7boEpPnWB3St+jwUxGff4skeSkR1u38+EQ2Ubvdb6iwUdjUJEV5bmVhWfLd6E32C bT8R9EsCMclJHhQ1dpkyIiAnOCqTRmfxsDBHVjte9xY9sq+EgxkrHNv2HbVZuMwIj12Qipuve ZENf+eg/tJsS8NsDE5+9FGvW6mTfMz0YCxhVwoH9BbsbmqixkiyKIVBBBLUpAhtdBJTtOT2hq QViwl/wnsAbXsJM4z4r183jOwzYvQnUNs79uLVatwofug2wl2mQMSuyLTwBd6xZ4id0mXbIoR nLxDDi3xqULsbssA/3ZR5slIKGQVbPPlESFgKAhO1MOY2NxYsQumz37A8yx8lU/GnvBVZOa3o LUecgepYP1j4BULdle95HUSLKeJnAI955jEdyXniBna9g= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > So it makes no sense to send the value of the KILL arg to tab-bar code? > Because there is nothing to decide based on its value? But KILL means to delete the frame and the tab-bar code wants to prevent that. Or what am I missing? martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 11 Jun 2024 16:27:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 11 12:27:44 2024 Received: from localhost ([127.0.0.1]:36038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sH4LY-0001qL-Aa for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 12:27:44 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:47341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sH4LV-0001q1-Um for 71386 <at> debbugs.gnu.org; Tue, 11 Jun 2024 12:27:42 -0400 Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52961b77655so6415793e87.2 for <71386 <at> debbugs.gnu.org>; Tue, 11 Jun 2024 09:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718123197; x=1718727997; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uySUrB9O/xl/+gsFtwOntcfS0/xzNCTYBo7cGGRbPFM=; b=PckrAMujnJhj4b2XlQt7dExK3pwufsffYU4Blyy/eoOfglwhbW6W5x7XSwLMAdjAs7 HLOLqimmMunn+VRSRDi1+4ERagau9FV/S6bVs7emqBM0cJk2q9Msl9FvvqUrkFU3scCW IuM7fSPS5FYemvD3m6KOnvwZzvNnx5TtKGtxz4d+9k9rmhn3up95xrQR9bVardC0SJW3 z0XuMjzrvv0V6cKAP1awrt1/rC6H6gXayLGkcSL1ymZJQGfm9npkrsPcD6Tnr6umuOis sKokPP6Ey+quKTL+vb1U4NxV3Pr2a/4bctr8hWQGQ4WU2oQC0P0oPJsMvKKpCtyN8+Z/ eMMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718123197; x=1718727997; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uySUrB9O/xl/+gsFtwOntcfS0/xzNCTYBo7cGGRbPFM=; b=aSmoOwqZOYoyUZQi9hqmDVrgz3tqqk+4QgVDFkSiE3xhB/KiwAMEamKw9piQ2Mfl5S 57//zTD4T1HMN6XPOO/00yiTr6oSuEByNDopWNQ4EeXR9SMl3M5iAM6W4k/XwFRAjOfF IFeO1jgb8S16fqj7n8n+d0wm4SsmSN/Dn82fa2i5AJk2kSImuFNeu3a10Hoaftks8c2D mzptD9zPoyp8Eg3gsq8ZalI46IZhwbXT7BDyAZj2kr/NNsiOkTjzTW+29tbYoT7i7BJI 5J/qpSz8EeUEGjgz7bhWQ5AmF5n4oxdWCrHD+lCie2/uOBAynC3AJJlcbjKDlnGH+HLl MGGw== X-Forwarded-Encrypted: i=1; AJvYcCUKfvqTBYSrU93gmZ04LUprzXoDYDwGt08zTN9twC3C6jxRLNto7vrUPwohcj4yHA6gZOtjv8X+S48hODqij59ViRU8WYA= X-Gm-Message-State: AOJu0YwTChAqHnh8hU7kySiKcn7z3qsL8RMQaEqj/Y11qp3nb/ctYDo+ pLUfj4LrMgxZi7O5c0rcpcFMmdB7wyegIeS4IGL+DmBD4IuAUx0w X-Google-Smtp-Source: AGHT+IF8ljdvgrsP0A18sTFBT/LZKYisKY64S0DdAPtOGPGgdKoOjjl4FbwMo8JrN+pg5SaHfG3iyw== X-Received: by 2002:a05:6512:3189:b0:52c:8a37:6d00 with SMTP id 2adb3069b0e04-52c8a376e4fmr4603713e87.8.1718123197035; Tue, 11 Jun 2024 09:26:37 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c19e567sm184606335e9.1.2024.06.11.09.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 09:26:36 -0700 (PDT) From: Al Haji-Ali <abdo.haji.ali@HIDDEN> To: Juri Linkov <juri@HIDDEN>, martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <86frtkeyzo.fsf@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> <86frtkeyzo.fsf@HIDDEN> Date: Tue, 11 Jun 2024 17:26:06 +0100 Message-ID: <m234pjqwdd.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 11/06/2024, Juri Linkov wrote: > So it makes no sense to send the value of the KILL arg to tab-bar code? > Because there is nothing to decide based on its value? Perhaps, for consistency, the argument should be send in case `window-delete-frame-functions` is used for other reasons by the user. Also, perhaps the tab should not be closed if `kill` is nil (similar to how the frame is not killed if `kill` is nil) and another buffer should be shown. -- Al
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 11 Jun 2024 15:54:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 11 11:54:47 2024 Received: from localhost ([127.0.0.1]:35840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sH3pe-0000mn-P6 for submit <at> debbugs.gnu.org; Tue, 11 Jun 2024 11:54:47 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:49713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sH3pd-0000mg-EH for 71386 <at> debbugs.gnu.org; Tue, 11 Jun 2024 11:54:45 -0400 Received: from relay1-d.mail.gandi.net (unknown [217.70.183.193]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 1C68DC4E1B for <71386 <at> debbugs.gnu.org>; Tue, 11 Jun 2024 07:11:52 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id AD43A240005; Tue, 11 Jun 2024 07:11:45 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> (martin rudalics's message of "Mon, 10 Jun 2024 10:00:28 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> Date: Tue, 11 Jun 2024 09:58:19 +0300 Message-ID: <86frtkeyzo.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> But I don't understand the logic of using the KILL argument >> in 'window--delete': >> >> (kill >> (delete-frame frame)) >> >> Maybe Martin could explain. > > KILL non-nil here comes from the prefix argument of 'quit-window' which, > if provided, 'quit-window' passes as 'kill' via BURY-OR-KILL to > 'quit-restore-window' which then passes t via the KILL argument to > 'window--delete'. 'window--delete' itself does not deal with buffers, > it handles windows only. > > 'quit-restore-window' calls 'kill-buffer' later when BURY-OR-KILL equals > 'kill'. At that time, the window should already have been taken care of > - either by deletion or by showing another buffer. The return value of > 'window--delete' is used to make the last conjuncts in the first 'cond' > of 'quit-restore-window' succeed or fail (in the latter case the next > clause will be probed). > > The idea of deleting the frame comes from the fact that a killed buffer > cannot be re-shown in that frame's sole window. 'quit-restore-window' > calls 'window--delete' in this case iff that window has no previous > other buffer to show instead, so deleting the window (and possibly its > frame) is the obvious choice rather than showing some unrelated buffer > in it. So it makes no sense to send the value of the KILL arg to tab-bar code? Because there is nothing to decide based on its value?
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 10 Jun 2024 08:25:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 10 04:25:08 2024 Received: from localhost ([127.0.0.1]:44702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sGaKx-00037J-Iv for submit <at> debbugs.gnu.org; Mon, 10 Jun 2024 04:25:08 -0400 Received: from mout.gmx.net ([212.227.15.19]:52569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sGaKv-00036U-14 for 71386 <at> debbugs.gnu.org; Mon, 10 Jun 2024 04:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1718007882; x=1718612682; i=rudalics@HIDDEN; bh=h0HtFdWRHKFhmb08VWB8ovAA3twtf17qfoGIW5fwGr4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=SVpf6zjrN+FCfrPuYqZKO/Bpe29BYzJ7YFY5mmHtgW8gmrZ1/OpoBWAjzcosSJwp mo2zXOeuqShxrOFvk1QIdg3jP0k580EOhPEFXFShxuEB81sy6q5ecZS+bgbU3gf9y dZXEn5JsIJNYm9zMt5jHMMhRjsT8KaYTKZmGl5lyA/Dp1TP1zk6/FeYsUX8LWrz+x rZGvZOFCz5AEC2UqlNZ5Uhqgx7dT6K7pBm7/VyxxjH+EpCZA9JYkbwB4X2caDGSHP mKyMXyhK3L20QuImNKsZCockdbWCDhuPAcJpOxi34YxdNCAsIdfwa67a2vObEl9zJ DZDbJWJIPNqHWB2kVw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.60]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N95iH-1sSHmJ2Y6B-014Jh9; Mon, 10 Jun 2024 10:00:32 +0200 Message-ID: <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@HIDDEN> Date: Mon, 10 Jun 2024 10:00:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> <86o78ac6ny.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86o78ac6ny.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:2XvnHYnQfWDnsxRLytD2msc33jcCC49D+adDc/uO1L/8h2lOvWH kMH2/ffiRqvzTPVkfu/30HS+3XsxQo0mi8VBKio4ULtFiKrmVwPBsUq4dXETNNPYHrtrOsm l1RpW3uhqYBlYFcz8hwj0WSGsuua587mOEQQOj7Q5Or1kL1tZXXBxOa/1QWmoLQ6UVl9pCz wBb3oL9Y3t1gIoMPlsCuA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xkNCInNn64w=;GzisrPMBkNE3WAAAyNeP/XsYQYt 7J0FHGL1p0Lpdz1U2yZ5ohBHlL3Jtudl8kSIxOzLpT8MzWLm0EyxLBe9KqeiXixa7ghSqgfln M4QxQFjfscDwE7nC7Ev136R68K0tiWUgaOYQEiKqmDc0fcCtvzdiWV/By9cSZyr+HARSNMI51 s4YsbqO2eKY5Ozv/yrz6q+EuHgaUI2L51HxwaBuPS2zH1UzQLrVVNkhHB4F6XWz2sVCOp+9tG le+LxUzqpQ4r91gTrsT+zZkNQMPZtfp2YR0kHPaJxKcQ+cYDHn6/91WdnY9IWVquXCbPvg8Tf rD/pY4XJTAEj/rknKn/lHciEN5PgnOyvzws+MJ7M4RNFYOUQblb6qOvkthHZPBnvu+yuiL0aw OJKW8kq22T6Ri4pUBYVUfq0KQPYci2oF2Ye5rmVjDEX/GwU/A4udXcfBP3HRe4euP62lKUvu7 8OPchhjnU81i4tahV55TLu2qxb6qPa7Agv9mXMUe3khfVTzr1zeb7WJR+ax4CVQb239tG0aiy 6x9rLbs6ftZ5ttt4O7fkiLISLTUoGNHDU1K6p6bOgU0SFlnHV/kOcuTay9QC7h7R+l8lZpK0z /fQeOIGjQ6+DnWadEhVeu2TbyVsvKq1fxHlHLjyI1DWVsFLT5LS31hiHes9tNT0Ffyn6RDncY hkuGiFeFsfNwl5Zg9cms0Dm9VjdWWi2vjYZFGCKGMpfuD0e0oiQEj9MmBJuMeh/AFWAwDPJUD cbwSghsYCr2zj4fmCLRFGHf7f8uIWEN2DxZ47fScyz249Q8M2hdv3Re0iBJ4XyBm7ydxV5ire 8vGBPEsap/SJgETOd4mTQv4hy961LZaQs6/R7xqgZpn8Q= X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> So KILL is a boolean, and if it's non-nil, it means the buffer will be >> killed? If so, will the buffer be killed even if the function returns >> non-nil? > > I don't know, I just copied the text [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.60 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.19 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 71386 Cc: abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> So KILL is a boolean, and if it's non-nil, it means the buffer will be >> killed? If so, will the buffer be killed even if the function returns >> non-nil? > > I don't know, I just copied the text [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.60 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.19 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager >> So KILL is a boolean, and if it's non-nil, it means the buffer will be >> killed? If so, will the buffer be killed even if the function returns >> non-nil? > > I don't know, I just copied the text from the doc string of 'window--delete'. > But I don't understand the logic of using the KILL argument > in 'window--delete': > > (kill > (delete-frame frame)) > > Maybe Martin could explain. KILL non-nil here comes from the prefix argument of 'quit-window' which, if provided, 'quit-window' passes as 'kill' via BURY-OR-KILL to 'quit-restore-window' which then passes t via the KILL argument to 'window--delete'. 'window--delete' itself does not deal with buffers, it handles windows only. 'quit-restore-window' calls 'kill-buffer' later when BURY-OR-KILL equals 'kill'. At that time, the window should already have been taken care of - either by deletion or by showing another buffer. The return value of 'window--delete' is used to make the last conjuncts in the first 'cond' of 'quit-restore-window' succeed or fail (in the latter case the next clause will be probed). The idea of deleting the frame comes from the fact that a killed buffer cannot be re-shown in that frame's sole window. 'quit-restore-window' calls 'window--delete' in this case iff that window has no previous other buffer to show instead, so deleting the window (and possibly its frame) is the obvious choice rather than showing some unrelated buffer in it. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 9 Jun 2024 18:40:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 09 14:40:27 2024 Received: from localhost ([127.0.0.1]:54168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sGNSr-0000Fw-Nl for submit <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:40:27 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:42321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sGNIn-0008Cw-5f for 71386 <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:30:01 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8334A20002; Sun, 9 Jun 2024 18:29:17 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <86ikyi9e2l.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 09 Jun 2024 21:16:34 +0300") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> <86ikyi9e2l.fsf@HIDDEN> Date: Sun, 09 Jun 2024 21:28:17 +0300 Message-ID: <86o78ac6ny.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> I tried to improve these doc strings: > > Thanks, they are more clear now. But one point still needs > clarification, IMO: > >> +(defvar window-delete-frame-functions nil >> + "A list of functions to handle the frame deletion. >> +Each of functions is called with two arguments: FRAME and KILL where >> +KILL means the buffer shown in window will be killed. When one of functions > > So KILL is a boolean, and if it's non-nil, it means the buffer will be > killed? If so, will the buffer be killed even if the function returns > non-nil? I don't know, I just copied the text from the doc string of 'window--delete'. But I don't understand the logic of using the KILL argument in 'window--delete': (kill (delete-frame frame)) Maybe Martin could explain.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 9 Jun 2024 18:40:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 09 14:40:24 2024 Received: from localhost ([127.0.0.1]:54160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sGNSo-0000FJ-OS for submit <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:40:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sGNHk-0008A3-Ca for 71386 <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:28:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sGN5q-0006RD-Dx; Sun, 09 Jun 2024 14:16:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dqtwR/+M8SXApgMidazdw480SHPS98BKcgKF7z92khM=; b=GED+zN0O2SGl DcMX1EJTrq/lI5GhzPbUvpBak6CbYDem7k1cAcCpJSKAhMnwOMo8ibUW5QJsUCcxIEhF0wRCPJ/1g 66KCiSAZrFaOJAifKKKs+b1x1te4965Q0aV2xxjVa/fVx+pLCh9HloiSFm5MIAoXULIQ+eUSfOkZD vx5NrP6/SBHT9aybKAzasWsEXmmjfCfICO0H5Ad3bv5b0+QPdy4yKHS16EQiBF5PL+JyR1LTZuhlT RQ62rj/5pdgGoGPGQ3XbH2p0u4JiPW5QQ2cJosy0BQMZh40ugqcRWMaZCA6Ig1MW6pVMQl1N6zuj4 QUt/W7eki1O/DvOmOtBYYA==; Date: Sun, 09 Jun 2024 21:16:34 +0300 Message-Id: <86ikyi9e2l.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <86zfruc7qh.fsf@HIDDEN> (message from Juri Linkov on Sun, 09 Jun 2024 20:58:10 +0300) Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> <86zfruc7qh.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Cc: abdo.haji.ali@HIDDEN, rudalics@HIDDEN, 71386 <at> debbugs.gnu.org > Date: Sun, 09 Jun 2024 20:58:10 +0300 > > >> +(defun tab-bar-window-delete-frame (frame _kill) > >> + "Whether FRAME should be deleted when other tabs are available for that frame. > >> +Instead of deleting the frame, close the current tab. > > > > The first and the second sentences contradict each other. The first > > implies that this is a predicate which returns a boolean, whereas the > > second says that it closes the tab and negtlets to say anything about > > the return value. > > > >> +(defvar window-delete-frame-functions nil > >> + "Don't delete frame when one of functions returns t. > >> +Each of functions is called with two arguments: FRAME and KILL. > >> +The function can perform an action instead of deleting the frame.") > > > > This doc string should at least explain what is the KILL argument and > > its meaning. > > I tried to improve these doc strings: Thanks, they are more clear now. But one point still needs clarification, IMO: > +(defvar window-delete-frame-functions nil > + "A list of functions to handle the frame deletion. > +Each of functions is called with two arguments: FRAME and KILL where > +KILL means the buffer shown in window will be killed. When one of functions So KILL is a boolean, and if it's non-nil, it means the buffer will be killed? If so, will the buffer be killed even if the function returns non-nil?
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 9 Jun 2024 18:25:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 09 14:25:27 2024 Received: from localhost ([127.0.0.1]:53372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sGNEN-0007y8-2G for submit <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:25:27 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:60899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sGMxt-0004Pw-9m for 71386 <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:08:25 -0400 Received: from relay2-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::222]) by mslow1.mail.gandi.net (Postfix) with ESMTP id B8A96C5A31 for <71386 <at> debbugs.gnu.org>; Sun, 9 Jun 2024 17:00:53 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 216C240005; Sun, 9 Jun 2024 17:00:31 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Al Haji-Ali <abdo.haji.ali@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <m27cf0h9sy.fsf@HIDDEN> (Al Haji-Ali's message of "Fri, 07 Jun 2024 19:44:45 +0100") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> Date: Sun, 09 Jun 2024 19:59:29 +0300 Message-ID: <868qzehxie.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > If I may interject a bit, I think it would be better if the tab is > closed (i.e., tab-bar-close-tab is called) and another tab is > displayed when the dedicated buffer is killed if its the only one in > a window. Thanks, good suggestion. > For example, I changed `window--delete` on my machine to > have this > > (if (and tab-bar-mode > (> (length (tab-bar-tabs)) 1)) > (tab-bar-close-tab) > (delete-frame frame)) > > In your patch, `tab-bar-window-delete-frame-p` doesn't do that, nor > should it as it is a predicate. Maybe > `window-delete-frame-predicate-functions` should be renamed to > `window-delete-frame-actions` or something and `tab-bar-close-tab` > should be called in `tab-bar-window-delete-frame-p` (removing `-p` > probably) -- in fact, the `delete-frame` code itself could be added as > such an action, if we are not averse to changes to the interface. It should be sufficient to rename it to just 'window-delete-frame-functions'. Then it's not a predicate, and also follows the naming convention of hooks having the '-functions' suffix. > Also, just FYI, your patch doesn't allow the branches with > `auto-hide-function` and `frame-auto-hide-function` to be called when > `kill` is nil. I don't know the side-effects of not calling these > functions in such cases, but might be worth checking. Probably the frame should not be hidden after closing the tab, so these branches should not be handled. Ok, here is the patch that supports your initial case: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=tab-bar-window-delete-frame.patch diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 6ab6324540e..485ea1d5dd0 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -2659,6 +2659,16 @@ tab-switcher-mouse-select (goto-char (posn-point (event-end event))) (tab-switcher-select)) + +(defun tab-bar-window-delete-frame (frame _kill) + "Whether FRAME should be deleted when other tabs are available for that frame. +Instead of deleting the frame, close the current tab. +Used via `window-delete-frame-predicate-functions' by `window--delete'." + (and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1) + (progn (tab-bar-close-tab) t))) + +(add-hook 'window-delete-frame-functions #'tab-bar-window-delete-frame) + (defun tab-bar--reusable-frames (all-frames) (cond diff --git a/lisp/window.el b/lisp/window.el index 2208346ec8c..b1e877b82a8 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4968,6 +4968,11 @@ frame-auto-hide-function :group 'frames :version "26.1") +(defvar window-delete-frame-functions nil + "Don't delete frame when one of functions returns t. +Each of functions is called with two arguments: FRAME and KILL. +The function can perform an action instead of deleting the frame.") + (defun window--delete (&optional window dedicated-only kill) "Delete WINDOW if possible. WINDOW must be a live window and defaults to the selected one. @@ -4982,6 +4987,10 @@ window--delete ((eq deletable 'frame) (let ((frame (window-frame window))) (cond + ((run-hook-with-args-until-success + 'window-delete-frame-functions + frame kill) + nil) (kill (delete-frame frame)) ((functionp (frame-parameter frame 'auto-hide-function)) --=-=-=--
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 9 Jun 2024 18:25:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 09 14:25:27 2024 Received: from localhost ([127.0.0.1]:53367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sGNEL-0007xz-K8 for submit <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:25:27 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:39959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sGMx0-0004N7-Un for 71386 <at> debbugs.gnu.org; Sun, 09 Jun 2024 14:07:32 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id DD2AA1BF207; Sun, 9 Jun 2024 18:07:06 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <86msnu9fhg.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 09 Jun 2024 20:46:03 +0300") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> <86msnu9fhg.fsf@HIDDEN> Date: Sun, 09 Jun 2024 20:58:10 +0300 Message-ID: <86zfruc7qh.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> +(defun tab-bar-window-delete-frame (frame _kill) >> + "Whether FRAME should be deleted when other tabs are available for that frame. >> +Instead of deleting the frame, close the current tab. > > The first and the second sentences contradict each other. The first > implies that this is a predicate which returns a boolean, whereas the > second says that it closes the tab and negtlets to say anything about > the return value. > >> +(defvar window-delete-frame-functions nil >> + "Don't delete frame when one of functions returns t. >> +Each of functions is called with two arguments: FRAME and KILL. >> +The function can perform an action instead of deleting the frame.") > > This doc string should at least explain what is the KILL argument and > its meaning. I tried to improve these doc strings: diff --git a/lisp/window.el b/lisp/window.el index 2208346ec8c..e97557b5bb2 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4968,6 +4968,13 @@ frame-auto-hide-function :group 'frames :version "26.1") +(defvar window-delete-frame-functions nil + "A list of functions to handle the frame deletion. +Each of functions is called with two arguments: FRAME and KILL where +KILL means the buffer shown in window will be killed. When one of functions +returns a non-nil value then `window--delete' will not delete the frame. +The function can also perform own action instead of deleting the frame.") + (defun window--delete (&optional window dedicated-only kill) "Delete WINDOW if possible. WINDOW must be a live window and defaults to the selected one. @@ -4982,6 +4989,10 @@ window--delete ((eq deletable 'frame) (let ((frame (window-frame window))) (cond + ((run-hook-with-args-until-success + 'window-delete-frame-functions + frame kill) + nil) (kill (delete-frame frame)) ((functionp (frame-parameter frame 'auto-hide-function)) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 6ab6324540e..2f7578b842b 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -2659,6 +2659,17 @@ tab-switcher-mouse-select (goto-char (posn-point (event-end event))) (tab-switcher-select)) + +(defun tab-bar-window-delete-frame (frame _kill) + "Handle frame deletion in `tab-bar-mode'. +When there are more than one tab on the selected frame, then close +the current tab. In this case return t to not delete the frame +in `window--delete'." + (and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1) + (progn (tab-bar-close-tab) t))) + +(add-hook 'window-delete-frame-functions #'tab-bar-window-delete-frame) + (defun tab-bar--reusable-frames (all-frames) (cond
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 9 Jun 2024 17:55:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 09 13:55:25 2024 Received: from localhost ([127.0.0.1]:51947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sGMlI-0003pI-Ne for submit <at> debbugs.gnu.org; Sun, 09 Jun 2024 13:55:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sGMch-0003QU-7w for 71386 <at> debbugs.gnu.org; Sun, 09 Jun 2024 13:46:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sGMcK-0001EN-82; Sun, 09 Jun 2024 13:46:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VYSEzFTGIDxELuwSOocoZCMgmw28z/1i+ON58x6V8v0=; b=Fmd4J83VPjF/ IMaEe3wcX+9CjUl6pY89LUrN3vFo++RWVAY30mynDWKVrXHXDDiwxYnHPhrx8ocrriYLvVLttXt25 gmUi8zv3nlONf38gp8bjoIeipZ/ZCjggdv+ZD8Mrbw3u0d0HH/Lj0CKq3xFJ4UUw9IhqpBsZXNBf5 nKgm7GO5qQ7zQzK3q4IEsl9sBUTAJYfGvFhQigXXT2W//Gy+oe8rIB4xbSzRIlflE6nQD6WjWjagg TvO3dqWv+4VIgV3pCwvZ3zYtBaSZt9mFkZqcEZlIoFSwDMykWtOWzypHyxrNev7TkjuZVAr87AQnw IxVxc2uSjbL9E5ihN+hvyg==; Date: Sun, 09 Jun 2024 20:46:03 +0300 Message-Id: <86msnu9fhg.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <868qzehxie.fsf@HIDDEN> (message from Juri Linkov on Sun, 09 Jun 2024 19:59:29 +0300) Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> <m27cf0h9sy.fsf@HIDDEN> <868qzehxie.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, rudalics@HIDDEN, 71386 <at> debbugs.gnu.org > Date: Sun, 09 Jun 2024 19:59:29 +0300 > > +(defun tab-bar-window-delete-frame (frame _kill) > + "Whether FRAME should be deleted when other tabs are available for that frame. > +Instead of deleting the frame, close the current tab. The first and the second sentences contradict each other. The first implies that this is a predicate which returns a boolean, whereas the second says that it closes the tab and negtlets to say anything about the return value. > +(defvar window-delete-frame-functions nil > + "Don't delete frame when one of functions returns t. > +Each of functions is called with two arguments: FRAME and KILL. > +The function can perform an action instead of deleting the frame.") This doc string should at least explain what is the KILL argument and its meaning.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 20:05:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 07 16:05:08 2024 Received: from localhost ([127.0.0.1]:57737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFfpj-0002gj-Ss for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 16:05:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sFfph-0002fo-6K for 71386 <at> debbugs.gnu.org; Fri, 07 Jun 2024 16:05:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sFfbT-0008QG-7S; Fri, 07 Jun 2024 15:50:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wSFtj/pODX4neyrY7k5epM6CuKlz1GHRoA8Mh9edVtU=; b=LaLNrsdrfHLv xDumobAXDrwwVYFQPCxDtKmNCh9I9eIN/BPhgIAoSG9tGuCAR0/at/XwLduVGc5Y4jxwXzJwA5/iL mWtzYsevZDk7LqLiZ75ZE/XDqASaUAdItna+yPkjiR1BJbAx0qGkeU5WoJLqIMdHJjXibC/TNVyCp dIS++r8M15bRYrDIqxy8WU5QTY9EX00GjhzM6G9m2YWIw+MoBeb3bGA5pVxgLKOD614YiF9Tu1ixW NleOZL2Swpojezy09dYISrGst73YmffJGOXrD8B7ykcER6ifldM1FJKc2fxUUKDwYgOKxQkllspFU rkc4jFIbxTfGrmTVsS6XWQ==; Date: Fri, 07 Jun 2024 22:50:20 +0300 Message-Id: <86v82kedmr.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <86y17gmxdg.fsf@HIDDEN> (message from Juri Linkov on Fri, 07 Jun 2024 21:16:43 +0300) Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org > Date: Fri, 07 Jun 2024 21:16:43 +0300 > > >> Ok, here is a better patch: > > > > Thanks, but I think this should be controlled by a user option, since > > it's quite a drastic change in behavior. > > I'm against adding useless options to tab-bar.el It is not useless IMO. > since users can easily remove hook with 1 liner: > > (remove-hook 'window-delete-frame-predicate-functions 'tab-bar-window-delete-frame-p) If we document this in NEWS, it could be good enough.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 18:55:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 07 14:55:39 2024 Received: from localhost ([127.0.0.1]:52041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFekV-0007je-9Y for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 14:55:39 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:46431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sFekT-0007jH-Gs for 71386 <at> debbugs.gnu.org; Fri, 07 Jun 2024 14:55:38 -0400 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4216724ced1so10518365e9.1 for <71386 <at> debbugs.gnu.org>; Fri, 07 Jun 2024 11:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717786456; x=1718391256; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=R320gO8Zjg4tljSyOnJDKcc9DCf2UBHXaYyQIJFXBsM=; b=VPD9Ix0a3FN2RVt25W2UoiDPU1OqB2krv89noKPMogrl+F3tfDOIqhOoQgbwH3Xy6f IedJcYvvgc116N9D4aKPlmzmYgYp9l3uCAy4ZDn6nhTOtGQnmyT5iaXqW8TvPNC21PW3 plI3ki7P30Rl23MnmXijORJqTfug3c0lAn96hC60DBsXX8oHrvfhM+/UVNsY6NHnE28K yB9L3C04fOMvZ7E/xnOug1VnhRG9Qu8SVLuusTNQne3A/EqfldM/vFXM+gJsDx0GJKJU PCsrVrBDbql06pY7PmzWcoOE3ilfJ2Lp/CQXtLbhT7LhJA6QmRiWPtUoWb8ztv3DjU/E h6yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717786456; x=1718391256; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R320gO8Zjg4tljSyOnJDKcc9DCf2UBHXaYyQIJFXBsM=; b=sCytv1QZ7zjCdEcjezS+wa3yZL53BDrJrF1ER/uXQfjLz56LkM9Yx1czP7epP0ZVOx O/FMAYJ/Smqabp5/r5qzNGhyYtKM7Y+CaSFYFl/hMwnr/dGvZUaj8r3szuL+TPRfL/Zc GKfPcSEkwKNaTvzufr8qOXf5H/PxjVF9fzaLqUoZSb0BLqxG6807t1WLueutjrku4L/s 2mN6nTLIP7dcTP9X3/f5LtPuSEJWGTJmA1+x+dszCrb3ChggW68Kess2yGgdRxmazHTU QLa9Ab4aCb+XQdP3RBI1Bnea0lu5WfJriegLKZ8x5hu8pI3Jwf4zSEKyaeVegUhwVJ1r /7Tw== X-Forwarded-Encrypted: i=1; AJvYcCWlCQW2Dm0jUyveC3jPFsg3id2H6K/PADw9q3WTyM1eFpGeH9Yoo+VU6SX8hxFf3+qfeZLCBBxquOV1ur1TYbL4ztD8w38= X-Gm-Message-State: AOJu0YwYLVSdfrCXH994Qvb2IPhwnSyiLkbjoEePaI3NG5PaYS6iBEe7 /AMQnoQFJ5kikVbqKyHNl5joUJWiL0+birHJyLQVY/Mhib7LFKD0tjKlPQ== X-Google-Smtp-Source: AGHT+IFe/oFJzSxIs40eqNnU9CE9hDlcpSWFO2Ov2XhYnesTzX+nKr0lgSSGViwo+k+Y7lAmdJkZCg== X-Received: by 2002:a05:600c:a382:b0:417:fbc2:caf8 with SMTP id 5b1f17b1804b1-42164a03077mr28549445e9.23.1717785895542; Fri, 07 Jun 2024 11:44:55 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c2c7dafsm60966225e9.35.2024.06.07.11.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 11:44:54 -0700 (PDT) From: Al Haji-Ali <abdo.haji.ali@HIDDEN> To: Juri Linkov <juri@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <86y17gmxdg.fsf@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> <86y17gmxdg.fsf@HIDDEN> Date: Fri, 07 Jun 2024 19:44:45 +0100 Message-ID: <m27cf0h9sy.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 07/06/2024, Juri Linkov wrote: > Ok, here is a better patch: Hello Juri, If I may interject a bit, I think it would be better if the tab is closed (i.e., tab-bar-close-tab is called) and another tab is displayed when the dedicated buffer is killed if its the only one in a window. For example, I changed `window--delete` on my machine to have this (if (and tab-bar-mode (> (length (tab-bar-tabs)) 1)) (tab-bar-close-tab) (delete-frame frame)) In your patch, `tab-bar-window-delete-frame-p` doesn't do that, nor should it as it is a predicate. Maybe `window-delete-frame-predicate-functions` should be renamed to `window-delete-frame-actions` or something and `tab-bar-close-tab` should be called in `tab-bar-window-delete-frame-p` (removing `-p` probably) -- in fact, the `delete-frame` code itself could be added as such an action, if we are not averse to changes to the interface. Also, just FYI, your patch doesn't allow the branches with `auto-hide-function` and `frame-auto-hide-function` to be called when `kill` is nil. I don't know the side-effects of not calling these functions in such cases, but might be worth checking. -- Al
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 18:18:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 07 14:18:54 2024 Received: from localhost ([127.0.0.1]:49067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFeAv-0005xU-UX for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 14:18:54 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sFeAt-0005x6-Ly for 71386 <at> debbugs.gnu.org; Fri, 07 Jun 2024 14:18:52 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 04ED8C0003; Fri, 7 Jun 2024 18:18:08 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <86y17gej2x.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 07 Jun 2024 20:52:38 +0300") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> <86y17gej2x.fsf@HIDDEN> Date: Fri, 07 Jun 2024 21:16:43 +0300 Message-ID: <86y17gmxdg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> Ok, here is a better patch: > > Thanks, but I think this should be controlled by a user option, since > it's quite a drastic change in behavior. I'm against adding useless options to tab-bar.el since users can easily remove hook with 1 liner: (remove-hook 'window-delete-frame-predicate-functions 'tab-bar-window-delete-frame-p)
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 18:12:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 07 14:12:36 2024 Received: from localhost ([127.0.0.1]:48468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFe4q-0005d2-5W for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 14:12:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sFe4n-0005ca-GZ for 71386 <at> debbugs.gnu.org; Fri, 07 Jun 2024 14:12:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sFdlb-00046M-M4; Fri, 07 Jun 2024 13:52:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V8xR7R37h0y+nsMNHteCphPLbCin14kJUzKL3e+mk5k=; b=baFvtQ2L4HUA lu64lw2I9/xavAAhVN6hyE60ib9hNUfsXSgkxzVJXh9fWnkZp5qByfmlwYcX1BNlLP+YO1PBzxtgK 0EWS/rg4CLvt6djAeqetW4VAlYNL8BkqyKDOrFwkgtfSmjk2typcaABDJO8JX1DRb0cJd3zyw5rk8 adw7FfHRcS4KXAhW6lx3Y5JRCmUxDdldFv7/qt3tNxbDCwRg4vsA7/dr/n60bKRq3L9vbatHq3/NN RRZ76Ru+htACrTYkWbsAAS3OSJAsEnfOv0ypW71eHs31B7AEuUG8cK81RMsMc+Pixo0nWDPS8vs2N 1dSp+vsqF2i4kKScIT8XQw==; Date: Fri, 07 Jun 2024 20:52:38 +0300 Message-Id: <86y17gej2x.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <86msnw4qm4.fsf@HIDDEN> (message from Juri Linkov on Fri, 07 Jun 2024 20:20:03 +0300) Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> <86msnw4qm4.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN>, > 71386 <at> debbugs.gnu.org > Date: Fri, 07 Jun 2024 20:20:03 +0300 > > > Provide an option, say 'tab-bar-save-frame', that allows users to > > customize whether a frame should be deleted when "other tabs are > > available for that frame". And provide a function, say > > 'tab-bar-save-frame-p', 'window--delete' could call thusly > > Ok, here is a better patch: Thanks, but I think this should be controlled by a user option, since it's quite a drastic change in behavior.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 17:22:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 07 13:22:39 2024 Received: from localhost ([127.0.0.1]:44676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFdIV-0003HR-AB for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 13:22:39 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:47443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sFdIT-0003H6-Md for 71386 <at> debbugs.gnu.org; Fri, 07 Jun 2024 13:22:38 -0400 Received: from relay5-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::225]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 802BBC6C10 for <71386 <at> debbugs.gnu.org>; Fri, 7 Jun 2024 17:21:48 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 338A01C0003; Fri, 7 Jun 2024 17:21:26 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> (martin rudalics's message of "Fri, 7 Jun 2024 10:23:52 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> Date: Fri, 07 Jun 2024 20:20:03 +0300 Message-ID: <86msnw4qm4.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> Sorry, I don't understand what I should do in tab-bar-mode >> for quit-restore-window. I expected that changes should be >> in window.el. > > Provide an option, say 'tab-bar-save-frame', that allows users to > customize whether a frame should be deleted when "other tabs are > available for that frame". And provide a function, say > 'tab-bar-save-frame-p', 'window--delete' could call thusly Ok, here is a better patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=window-delete-frame-predicate-functions.patch diff --git a/lisp/window.el b/lisp/window.el index 2208346ec8c..abc9f1b4011 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4968,6 +4968,10 @@ frame-auto-hide-function :group 'frames :version "26.1") +(defvar window-delete-frame-predicate-functions nil + "Don't delete frame when one of functions returns t. +Called with two arguments: FRAME and KILL.") + (defun window--delete (&optional window dedicated-only kill) "Delete WINDOW if possible. WINDOW must be a live window and defaults to the selected one. @@ -4982,6 +4986,10 @@ window--delete ((eq deletable 'frame) (let ((frame (window-frame window))) (cond + ((run-hook-with-args-until-success + 'window-delete-frame-predicate-functions + frame kill) + nil) (kill (delete-frame frame)) ((functionp (frame-parameter frame 'auto-hide-function)) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index dac57ce2070..25bfefbc205 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -2631,6 +2631,14 @@ tab-switcher-mouse-select (goto-char (posn-point (event-end event))) (tab-switcher-select)) + +(defun tab-bar-window-delete-frame-p (frame _kill) + "Whether FRAME should be deleted when other tabs are available for that frame. +Used via `window-delete-frame-predicate-functions' by `window--delete'." + (and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1))) + +(add-hook 'window-delete-frame-predicate-functions #'tab-bar-window-delete-frame-p) + (defun tab-bar--reusable-frames (all-frames) (cond --=-=-=--
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 08:25:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 07 04:25:25 2024 Received: from localhost ([127.0.0.1]:34717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFUua-00063a-KJ for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 04:25:24 -0400 Received: from mout.gmx.net ([212.227.15.18]:38437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sFUtU-0005zl-HX for 71386 <at> debbugs.gnu.org; Fri, 07 Jun 2024 04:24:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1717748634; x=1718353434; i=rudalics@HIDDEN; bh=VvOVNb67Y6zYhXrUsdwR/l6D1z2aTJJOpcPavNKgzx4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=IZqnBJ8T9EU6cL537l8nL51FAw3g0QOMPExmtrYWmOh/ZSI7lZ/p//+XXPXdj20D XyQZj5/zUbRV6PO3bJJJAs7/1+sR244cJDZwz3P8eM0jN3ub6PlQ+sv+heUQ/8HdY tH3kYSmX+99mjWZtYV9l84uODa43lhoJb+48rBRAfW9zyDfhWnpZUKbq9y9Dg9+5o fe33P/uneo9paInYbSZcDfWdOIxeaEqKqP8F1egEY1eNpWbCo16k0tIoRLYhC6DLK 1IhQpZ86I+QSimML5mymp9gBm6NmcqwVRfYzzZYa4fpzKL27ky6bPuNYgztVBZiDQ P6KRNtZScj1T1z9Nxg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([213.142.97.105]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N95iH-1sTMqb2Ytj-014Jds; Fri, 07 Jun 2024 10:23:54 +0200 Message-ID: <8561a63a-66d3-44cd-872f-73d26af7edbe@HIDDEN> Date: Fri, 7 Jun 2024 10:23:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> <86zfrx8ec0.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86zfrx8ec0.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:nxhTjspmSbfTRsbK7+apmip+gl0PVYVd3YPYSgw8UF4I4R9KlaY tUAOqNyy9tf66IEzxq5tF+jQnqZNsa7/Oj7ru83EF4czT4ujeGpAmQCt6rOzAdAGXrwgYe1 ql6+Bou5ytfjS88HFkfzzFWPshQOURvxVhIhN8fwvA8SBW+1Frl8bJ0lHKFnK6rjEaV1Ek0 YWJIezEy9QH39TR/f7Z4w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:VcEX1o5slUc=;aztULhX/GVi4CYo/R64opIDtv4U 3pgePWJIQTMlhk59vGu3tvQ9HsMMnlZDlj94GxEODpdzJMItVgusBY98NpDPvzyFifreNLq9P p0vd2m75p8Olxf/MEn+BwaNLmg9fcCUwE0ECPnPg5xH5B5Mlaz8DbKYry+Qv8BRlK9Gir6PsV 9rdeW/kFyjR6XG+1fjgGDkEjv9sZaSKGP070YPOY6JlRUTGrbWokNiulxnPONrDkBGcFNahrG mSge+ReqmnZx/6Fx4wT+nzx6uxWsSuqWLSqigyvlb66GjQGBu1cfVjwnjZ31aq6BHRn8ftA80 5hjmYIl2yKIV+9t/LscjU5U738IGj4ARHVu7KDPgLNu24DOv682ycELCv0Kl+O7cUGkvHHVW/ ssdq0O8DghvuG8KNXECmBCAXMbmImBroWHNNTB7KrfnIxrGl5eK/cb+vWMNW6eKbqZlvWB1u1 uk/LaaH+lLqkir7GHX3BVlMuP/v8hcnP/Bb3La8XYB/F3tClcMNs/q3m48OCakNt0rDsn8ury vCxDQ6o7Uu7ufXAZPKrNZeG+SfCXsrGwzdP1rSOTe+jYU89H58Amnf+n+a2h38qrepQFuvu3r xLVCe0JYPsd0JxKi1UoKQA9TyWIxW1ahqU1FRanTF4Yreo4qBlEUBfy3EFJA5SlreISCdh/rK beBYn1k2Rohw6GRpnrdL60f1wM79FIlwhOQUR8FjcYnWib1Hal3ePnbYmSljfIhusbeFZhALs SpcoGW2M5i/2p/OyOnotJ4JWIGvS1Skk3SF7NmWW9zEiVpbxIXhvhpqvtMW+qd2DZVrVdw+LE nj4dnUiN2/mNxgGUAJ8CDWz0YYId3rS7I4wkCb3q7t1O8= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > Sorry, I don't understand what I should do in tab-bar-mode > for quit-restore-window. I expected that changes should be > in window.el. Provide an option, say 'tab-bar-save-frame', that allows users to customize whether a frame should be deleted when "other tabs are available for that frame". And provide a function, say 'tab-bar-save-frame-p', 'window--delete' could call thusly (let ((deletable (window-deletable-p window))) (cond ((eq deletable 'frame) (let ((frame (window-frame window))) (cond ((and (fboundp 'tab-bar-save-frame-p) (tab-bar-save-frame-p frame kill)) nil) (kill (delete-frame frame)) thus avoiding to kill the frame when that function returns non-nil. 'tab-bar-save-frame-p' itself would be free to do with the frame whatever it wants according to the value of 'tab-bar-save-frame'. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 06:55:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 07 02:55:22 2024 Received: from localhost ([127.0.0.1]:55827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFTVR-0001Sn-MK for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 02:55:22 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:47043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sFTIe-0000nW-L2 for 71386 <at> debbugs.gnu.org; Fri, 07 Jun 2024 02:42:09 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7186AFF80C; Fri, 7 Jun 2024 06:41:26 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: martin rudalics <rudalics@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> (martin rudalics's message of "Thu, 6 Jun 2024 11:19:59 +0200") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> Date: Fri, 07 Jun 2024 09:39:20 +0300 Message-ID: <86zfrx8ec0.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Eli Zaretskii <eliz@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> If I open a frame with multiple tabs, and one of the tabs has a >>> dedicated window, then kill the buffer with the dedicated window, the >>> frame is deleted along with its tabs. >>> >>> I understand that this is the documented behaviour, however my >>> expectation is that the tab should be deleted but the frame should >>> stay when other tabs are available, similar to how the frame is not >>> deleted if other windows are visible. >> >> I'm not sure I agree with you. Tabs are just saved frame >> configurations, they are not real windows. If we make this behavior >> dependent on tab-bar-mode, we basically introduce an incompatible >> behavior change in this particular case, which people and Lisp >> programs out there might not expect or like. > > The current behavior of 'replace-buffer-in-windows' has been taken over > from 'quit-window' which Richard initially designed as > > ;; Get rid of the frame, if it has just one dedicated window > ;; and other visible frames exist. > > It is not carved in stone but if we want to change it for the tabs case > we should leave it in place. So I think that Juri should provide a tabs > option that has 'quit-restore-window' (which 'replace-buffer-in-windows' > should call) spare the frame in that case. Which buffer to show in that > window instead (especially if it never showed another buffer in its > whole life) is another question. Sorry, I don't understand what I should do in tab-bar-mode for quit-restore-window. I expected that changes should be in window.el.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 6 Jun 2024 10:10:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 06 06:10:52 2024 Received: from localhost ([127.0.0.1]:52454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sFA55-0001ln-Sc for submit <at> debbugs.gnu.org; Thu, 06 Jun 2024 06:10:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sFA54-0001la-7C for 71386 <at> debbugs.gnu.org; Thu, 06 Jun 2024 06:10:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sFA4f-0005S7-D8; Thu, 06 Jun 2024 06:10:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5ns4WGmZeW2fyXXAPFgtfab7uxFXhHqTSqbc5iuS5RI=; b=oVTUJVW5bYkz SW+k40Zqf6kL1uthi1uDSLonC8KunZgcwOYnsqLkN/4obFgQn2i/werSC2yDaPwRmK+efGjjZ8l9C I5u3RHd4tyJX4A1pha1EdhuM+iQ1rhVC+/koZe7RteQa6SX23ZqsC8unglC0B/XOxer8+VktSpMbr VtfqTtZGyZtRYImAvmV4x+RFdC2KhFpnOje3J9WmdzedOBbK9mY/h7g4VYyYlsXf9mlOfZO9h09/P o+3JilRJx4FSoDeVzP9wnQMsndEJoV0OQ7HENA2/DaZ54Aszi6kBXBCveobmq47a4mj0DLJyuLHVn vMjQaWIkiqx1kOdNnVJ9aQ==; Date: Thu, 06 Jun 2024 13:10:14 +0300 Message-Id: <8634pqidq1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <86plsuppl1.fsf@HIDDEN> (message from Juri Linkov on Thu, 06 Jun 2024 09:12:10 +0300) Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <86plsuppl1.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71386 Cc: rudalics@HIDDEN, abdo.haji.ali@HIDDEN, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Cc: Al Haji-Ali <abdo.haji.ali@HIDDEN>, martin rudalics > <rudalics@HIDDEN>, 71386 <at> debbugs.gnu.org > Date: Thu, 06 Jun 2024 09:12:10 +0300 > > >> If I open a frame with multiple tabs, and one of the tabs has > >> a dedicated window, then kill the buffer with the dedicated window, > >> the frame is deleted along with its tabs. > >> > >> I understand that this is the documented behaviour, however my > >> expectation is that the tab should be deleted but the frame should > >> stay when other tabs are available, similar to how the frame is not > >> deleted if other windows are visible. > > > > I'm not sure I agree with you. Tabs are just saved frame > > configurations, they are not real windows. If we make this behavior > > dependent on tab-bar-mode, we basically introduce an incompatible > > behavior change in this particular case, which people and Lisp > > programs out there might not expect or like. > > > > I'm adding Juri and Martin to this discussion. > > I don't understand the logic of window--delete. But maybe > window-deletable-p should also check for existing tabs in tab-bar-mode > and return 'tab' instead of 'frame'. Then window--delete > could close the tab instead of deleting the frame. Sure, technically it should not be hard to make this change. I just am not sure we should. Martin, WDYT?
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 6 Jun 2024 09:20:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 06 05:20:36 2024 Received: from localhost ([127.0.0.1]:52343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF9IS-0000Qm-Jt for submit <at> debbugs.gnu.org; Thu, 06 Jun 2024 05:20:36 -0400 Received: from mout.gmx.net ([212.227.15.19]:50025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sF9IR-0000Qa-4y for 71386 <at> debbugs.gnu.org; Thu, 06 Jun 2024 05:20:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1717665614; x=1718270414; i=rudalics@HIDDEN; bh=+094daeID3uAmayPFg7KHLfmKHJLSmfyKat6GLxlOYQ=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=R/4eV8r6laj4bJaFtfqsEj7Sso1LEaKKs/MblernBkZfPU2ALR+vgpxbHLxTUo3w bI7ZG+sBM7+mSlzB5Md7kjf4lQC2U+TLyhD4p8ydQVWJcsC5lf/uKRpexdMZanpP+ j/GDhXezRh+ZPh57D35PcHEeNBaSuvmWd7WRRSZSbIgb5zimwQjK8IMXj4kDKErEV QHqr2FubV1sfOx0seTeu1QSNrW46vKmGCznZQ+6ryWETGhuRqYPTwZTXAI3XeEKj5 x4yflAf9i9HRwwtJxRc1v3nc6V5Nnlkrsm03iPsj0hEfroKDseoquv0Dr25FYgNvo XJa/bJg6JD9Kg/jLPw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.83]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N49lD-1sNhtf0KAb-011Zy2; Thu, 06 Jun 2024 11:20:14 +0200 Message-ID: <7d1c9de4-bbdd-4bd2-bd1e-60ef91d8b8c1@HIDDEN> Date: Thu, 6 Jun 2024 11:20:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Juri Linkov <juri@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> <86plsuppl1.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86plsuppl1.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:joLInnHm93fG2ZBT6HwwBjJoN4M+B8Np3eY2VZ9miUJSGiN+wdL nk1Z3JkIppQEWq9HkJ5R5+kOpsv50olCyHfSjAn2eyJ25hDeqqzX1sGoGu6CUKLqJern0Jy fITmLYkR+rNCtum8k9OGuIYmA0m31LBsRMLAAe8IsRGm8W0lQUpPVsrk8Pf6ERP1pWNGa5y 2AcXYDQ7HTVQlp9vP9/zg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tGCR4BkvRUs=;WQNp+1MMwwIyNQhWt74gAviObEe oPRo2EBSLP8AHwKVSCYcOxU7MBzk0hx1EIt0cLWkJ8gfbcVG/w/Wk1wekbkM50801fVhUS44q m0acHYmQK076XbMrw9hhKj7btsw3WgkdgrEVApmIbj/0GIWl7XR9HQCGIR2GoGMcJTB7vrgey eVWw5BjsM8gOAHj8rJ4XYDvNlIbTxMT4UXI3ZlGDw1+pyWs+9k+CloLXcC1v9lO2nryXqn7b9 yu5lXipUkzyYN/I6Nn2EFvk6dQjjXU4AG1KRR5c1INak3oJotYHmCxUlVE6BGotIkXWiIs3pq 6xHnMHUA7m51wF7/3tfN9PuPaJ4AyCsj75r8V+jt2DngZlJ5Nb/77tgaO+w0jklvgZMkuUZaQ u7BdXdVxnRWwYP4Q8WQiKtWCqIFfekbpgGLWW29u7gtefzDATUEjtdKTP0HfU4aUCN7jXDK5I rf8v4nXgNNGshfzjCot4CyOFMBtktkSCkITj9EItJNSW2LfjcRsQ604iD6GBPUqjzsLQR+bRl CyHJkjLyXYIJBd0VRjJD49vUrrO0dg7S1Bpl+DoZW2KSIuPXa5fDFJhblxr6rgOrIxDJUV9AZ +eaMywetvHKz5+RuIOlu9J6BszfkEpc4cYdzcB8xPSFWqxjdadRzkhk/bnNDqQrvFl105K8Ki qFM8HGAVwfH36/Dl4ld6ZBEtJ1RXfY6GrA5UMQ739LHa5MogqyXbUfAxHTvCxnqN++wzh1Jvh gMKWSotvjuvyHsR+z7XxBQvOuYOYdxrYdLkgdXSfc+WYxQF+5IuPlhsirGyD2voblDfCo2EZw iepxgCQG8O1XmFkivvmHweZlyjZTJ6YGpDZN3KtgkrTG0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: Al Haji-Ali <abdo.haji.ali@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > I don't understand the logic of window--delete. It mainly tries to deal with the auto hide mechanism. Other then that it looks pretty innocuous to me. > But maybe > window-deletable-p should also check for existing tabs in tab-bar-mode > and return 'tab' instead of 'frame'. Then window--delete > could close the tab instead of deleting the frame. Governed by an option in the tabs code, I would say. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 6 Jun 2024 09:20:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 06 05:20:23 2024 Received: from localhost ([127.0.0.1]:52340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF9IF-0000QK-8c for submit <at> debbugs.gnu.org; Thu, 06 Jun 2024 05:20:23 -0400 Received: from mout.gmx.net ([212.227.15.15]:44593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1sF9ID-0000Q6-Kv for 71386 <at> debbugs.gnu.org; Thu, 06 Jun 2024 05:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1717665600; x=1718270400; i=rudalics@HIDDEN; bh=Qxo9zjF+NymQJMU8HklyUiKNfZLxnBwogPDYETiXdng=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=rXoxfB4e4iZcmeO7Lbyol6sH4RbTDs64o6E0WiYJkarfzublTf/OX5TKBi9HfmGn AzLmYSr6s/EvKUUW8QrOv+akRTKKFhABNkHQHgVV5erw6NdlSQaAQsT/ITkeCydg6 /mqrdebYxcBfEW9049avHo9+MxwcjjGO12S03z0u9o1raNNkFkowoC3Cy2QfAGl29 5A8sqp4rW5tDn2Re7OMGZ0u0SMfEFZ9DipRIwITGYiEQSQOwACrK5+1bAFLJT6Jbp cKHDTZjpQVsijCm/s3Jxc6gSP91e+uLf4OaKKVPfKwCwX2c2ricCtJzWolfuWNyTA 4LQCIrLIQLlfMKLNsA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.83]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MC34h-1s9KH71COr-00C5VX; Thu, 06 Jun 2024 11:20:00 +0200 Message-ID: <7269c7c4-86a1-44bf-8d5d-378c3584027a@HIDDEN> Date: Thu, 6 Jun 2024 11:19:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs To: Eli Zaretskii <eliz@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN>, Juri Linkov <juri@HIDDEN> References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <86ikymipzx.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:q3gESVkSxSbm8NEGcqCFkcLaom48+MGVRbLiEy4hKWCWMiSBacU hIKboOcfVqhgVQ4ZQC382msm/vKC1QUQXygAlBHPFJnTAXtB7AvLJHcQPDCKf0pRh5QzFHF ZM9YBcudrMtPTmy56MfcYYsqwOBKhQdNrQaVjvIgixpTgnAP0wv2v4MnkWw6WzmnHnVv52C 7/WfY6RKXdMAw3czb5/VQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:LkpJACSyBVo=;AwiVbs4MYC8Yg5tjgZDBQqCnOZQ CBRknvlZY7bHfcF3JqL92ieXUDk8YUr8mfFEEIEI33+lHkzZ/+AlY5YXvoHIblGMcs7tIETm2 HywtnmhaacMHSkzoxonHA6AV1a8Ng4Dl9sR57cqv12jiZSrHTaUx9qr7ncAdn18FZnb8qr7Cw 9ZKh4WXh9qcYteNYHKsQBaDqLRFTQzhgf5gvls6IsNsNt+XLV4b8ZE3vHm7MvcQ1G2Q9lsBop xEQXb+zV1+sGzIi+iY12AVTmkucH1X7dWAxYY9kj2LMtGR31ayIXL+D+2M2ZXQqkYDO2o86Pz hOeyvvJvOpnct/wrY0kVZMD3VWagmziM6WCVIEb8nljvGGrHgjpbz+GBWyHMqnT9IhR1h7Hpz Nd8rPr5jTali67td6USw26C1w7FciFdl3U3AlHiqXqcUum9jpG6vF/nl2dQoOaHXsrDiGj+Bc /Dw8v/kUmFdfS/ROebYnX+CjtRgZ3fgjeVdYltgb7Fs/+MHqOFJ7XCaA/4k1Ea+p1LfxHIDKc S3i568CHuWAX8jvAfkpkCa/sQLMl1TJTObP7nLuMJSZ+t5s5KdeJE5zQ2Xm61wM9jaB24XYxy tlGRCLmwHrQ9HtLfYfDVMNfonxEITELkU1bHO7O63HyCdQ2YwCTZpYeX2WKCwL/B9KuKX/ilU 3ntKCHz44kvIAugJWHXuwZk8WC0T8DGay0+eiehqOweWRcwacYzCXRvtJ2eLmWu0jtVTsgFMO SEc78BSUV8v/WOWpnjMJSJnwUK4qTbsUlXLe/fDb9lccd76Xx4xeT56hG7wt/98P0XMEWZvJC MnXVoOkk+yw+RFppyN350ZwHdmeRAaFSUqfW14034znF4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> If I open a frame with multiple tabs, and one of the tabs has a >> dedicated window, then kill the buffer with the dedicated window, the >> frame is deleted along with its tabs. >> >> I understand that this is the documented behaviour, however my >> expectation is that the tab should be deleted but the frame should >> stay when other tabs are available, similar to how the frame is not >> deleted if other windows are visible. > > I'm not sure I agree with you. Tabs are just saved frame > configurations, they are not real windows. If we make this behavior > dependent on tab-bar-mode, we basically introduce an incompatible > behavior change in this particular case, which people and Lisp > programs out there might not expect or like. The current behavior of 'replace-buffer-in-windows' has been taken over from 'quit-window' which Richard initially designed as ;; Get rid of the frame, if it has just one dedicated window ;; and other visible frames exist. It is not carved in stone but if we want to change it for the tabs case we should leave it in place. So I think that Juri should provide a tabs option that has 'quit-restore-window' (which 'replace-buffer-in-windows' should call) spare the frame in that case. Which buffer to show in that window instead (especially if it never showed another buffer in its whole life) is another question. martin
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 6 Jun 2024 06:24:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 06 02:24:40 2024 Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF6YC-00015N-L1 for submit <at> debbugs.gnu.org; Thu, 06 Jun 2024 02:24:40 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sF6YA-000157-QQ for 71386 <at> debbugs.gnu.org; Thu, 06 Jun 2024 02:24:39 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id A592C60002; Thu, 6 Jun 2024 06:23:57 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs In-Reply-To: <86ikymipzx.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 06 Jun 2024 08:45:06 +0300") Organization: LINKOV.NET References: <m2frtrhs4j.fsf@HIDDEN> <86ikymipzx.fsf@HIDDEN> Date: Thu, 06 Jun 2024 09:12:10 +0300 Message-ID: <86plsuppl1.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71386 Cc: martin rudalics <rudalics@HIDDEN>, Al Haji-Ali <abdo.haji.ali@HIDDEN>, 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> If I open a frame with multiple tabs, and one of the tabs has >> a dedicated window, then kill the buffer with the dedicated window, >> the frame is deleted along with its tabs. >> >> I understand that this is the documented behaviour, however my >> expectation is that the tab should be deleted but the frame should >> stay when other tabs are available, similar to how the frame is not >> deleted if other windows are visible. > > I'm not sure I agree with you. Tabs are just saved frame > configurations, they are not real windows. If we make this behavior > dependent on tab-bar-mode, we basically introduce an incompatible > behavior change in this particular case, which people and Lisp > programs out there might not expect or like. > > I'm adding Juri and Martin to this discussion. I don't understand the logic of window--delete. But maybe window-deletable-p should also check for existing tabs in tab-bar-mode and return 'tab' instead of 'frame'. Then window--delete could close the tab instead of deleting the frame.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at 71386) by debbugs.gnu.org; 6 Jun 2024 06:02:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 06 02:02:58 2024 Received: from localhost ([127.0.0.1]:40577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF6DB-00009P-Mw for submit <at> debbugs.gnu.org; Thu, 06 Jun 2024 02:02:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sF6D7-00008r-RN for 71386 <at> debbugs.gnu.org; Thu, 06 Jun 2024 02:02:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sF5vy-00025A-18; Thu, 06 Jun 2024 01:45:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=73z2TLx+Qy1OJuS7f5DKJA3M+JviVVmWHxCOi0m4N+A=; b=d2X8VnZCpc+s 25Sv6nZ+S+Oci+nNRx/bImPzgNC7AGZzBNG2WSYNI80DoogcQFV0iqFS8FYnoC+84ekoEQdyFstdA phntBtMMvXZZcuxkeouSed90NtI5Nbe4/xylzGW/fUsTFBVKryEl/HsyLq2gDriQZsYGuBaA18tDx Fy8yEI1Nr/tCpdycpqNN506KCpF+5nHyb0SlMAYsjC7rsOeAuMFexYaWnmmtasS/sADp1gkvHqHGu PzTtLhErwj2JrbKtT2IR4O7D4W5rgjCFeyP6YyUD7oMfT5FEDuJYPNoFOWQhxwcoejvxR4otRpYyH VAtqD72VVi4fAloI09sUnQ==; Date: Thu, 06 Jun 2024 08:45:06 +0300 Message-Id: <86ikymipzx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Al Haji-Ali <abdo.haji.ali@HIDDEN>, Juri Linkov <juri@HIDDEN>, martin rudalics <rudalics@HIDDEN> In-Reply-To: <m2frtrhs4j.fsf@HIDDEN> (message from Al Haji-Ali on Thu, 06 Jun 2024 00:44:28 +0100) Subject: Re: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs References: <m2frtrhs4j.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71386 Cc: 71386 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Al Haji-Ali <abdo.haji.ali@HIDDEN> > Date: Thu, 06 Jun 2024 00:44:28 +0100 > > > If I open a frame with multiple tabs, and one of the tabs has a dedicated window, then kill the buffer with the dedicated window, the frame is deleted along with its tabs. > > I understand that this is the documented behaviour, however my expectation is that the tab should be deleted but the frame should stay when other tabs are available, similar to how the frame is not deleted if other windows are visible. I'm not sure I agree with you. Tabs are just saved frame configurations, they are not real windows. If we make this behavior dependent on tab-bar-mode, we basically introduce an incompatible behavior change in this particular case, which people and Lisp programs out there might not expect or like. I'm adding Juri and Martin to this discussion. > The following code illustrates the issue: > > ,---- > | (with-selected-frame (make-frame) > | (tab-bar-mode) > | (switch-to-buffer (generate-new-buffer "test")) > | (tab-bar-new-tab) > | (switch-to-buffer (generate-new-buffer "test2")) > | (set-window-dedicated-p (selected-window) t) > | ;;(kill-buffer) ;; Kill buffer manually to see the issue > | ) > `---- > > I am unable to test this on Emacs 30, but I checked the source code and `window--delete` in `window.el`, which is the function that I think should be changed, seems to do the same as in Emacs 29.1. Emacs 30 behaves the same in this regard.
bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 6 Jun 2024 00:10:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 05 20:10:21 2024 Received: from localhost ([127.0.0.1]:49530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF0ht-0001wg-4B for submit <at> debbugs.gnu.org; Wed, 05 Jun 2024 20:10:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:58024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sF0Ma-0000zh-US for submit <at> debbugs.gnu.org; Wed, 05 Jun 2024 19:48:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sF0MM-0003XW-D9 for bug-gnu-emacs@HIDDEN; Wed, 05 Jun 2024 19:48:02 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <abdo.haji.ali@HIDDEN>) id 1sF0MK-00081c-Uo for bug-gnu-emacs@HIDDEN; Wed, 05 Jun 2024 19:48:02 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4210aa00c94so4310775e9.1 for <bug-gnu-emacs@HIDDEN>; Wed, 05 Jun 2024 16:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717631279; x=1718236079; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=x3Od+kHQiYw10KJUCEWfl19VRFpwdq31FvZ+w9rMBwk=; b=UgZcV+4+3dLMgPjoSj/Y+Xv3ilfC2FneLUE947mnGQ7SVQgByEhJhcm3iLgeuwCTiR vfwCFbkfauNYw2z4zCM+NomHh+LDCnr/3PGjN7PM5w03H1YPBs+VKioO0iqRbyRmE9L9 AsWQpRVeIXWN1RPoUsasZi8ksCqDUAcL0+Ons+AmUvoxQ44IC8Hj9jqi3JqJvdDLaTvw xviGQJUdHl6CUoV0LxSL/lP3YhCzWJJHijAvvTxEq2yDexUhCU8U/pQwixNikYujgnUS mH79kB8NP8RW9zz+0/y7u/Yu1vaY2d8yaGObDWKz6CggLb0ghc1BAtRSVNuaXWfSO8Y0 DTXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717631279; x=1718236079; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=x3Od+kHQiYw10KJUCEWfl19VRFpwdq31FvZ+w9rMBwk=; b=hBfSChgRpXlQSL0lpo2tnVgVHGiDQmYnZyurlriBFev2OdAl4BI8Deg3iYPkJh8d/I UoDa9IqlMilYxv/YPiKb+ENYBkNcHpHEMaCYkGCSSDICGDjmsbfQb/lGjcVh1U/af3Bg K9JhMRP2+QtWksv+djhAfDQBUE7OV2MtzkFIbebhcpdtgbw1oV/EUZ7Uue1+0/vjfEVx 0v3986Pw01qvZJkS6/DogeUNsrNwEtjaqQvd7WulSNOevVVL8JSYfY2XGBVTQam6jyu2 pmlItOPBX6ER7Z7Bb8uZgomxNvQnAXG1A7z/RCMcuwkpHsvq7EGcZkz9Aw3STqhC9fYf nutQ== X-Gm-Message-State: AOJu0YzvkqA/QbddzddEs1QvHJEe5stBbQm6gGVFzM2j040tfbCNf5Xc KVdb+y1Hu7VL5IsnHhfwgEOkMjwQxVldOuOT19GGmEUbhJGBpj0l8Mi7cw== X-Google-Smtp-Source: AGHT+IEPZBuKNU1xrSjK9yVdIw6j3QtCYitqYpnx/KjWPq6rXszr3B03IowdD5G0/uTcollRdnn2mw== X-Received: by 2002:a05:600c:3108:b0:421:2cb3:160 with SMTP id 5b1f17b1804b1-421562df35amr31929455e9.8.1717631278587; Wed, 05 Jun 2024 16:47:58 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158102ab8sm37741965e9.18.2024.06.05.16.47.57 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 16:47:57 -0700 (PDT) From: Al Haji-Ali <abdo.haji.ali@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Thu, 06 Jun 2024 00:44:28 +0100 Message-ID: <m2frtrhs4j.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=abdo.haji.ali@HIDDEN; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) If I open a frame with multiple tabs, and one of the tabs has a dedicated window, then kill the buffer with the dedicated window, the frame is deleted along with its tabs. I understand that this is the documented behaviour, however my expectation is that the tab should be deleted but the frame should stay when other tabs are available, similar to how the frame is not deleted if other windows are visible. The following code illustrates the issue: ,---- | (with-selected-frame (make-frame) | (tab-bar-mode) | (switch-to-buffer (generate-new-buffer "test")) | (tab-bar-new-tab) | (switch-to-buffer (generate-new-buffer "test2")) | (set-window-dedicated-p (selected-window) t) | ;;(kill-buffer) ;; Kill buffer manually to see the issue | ) `---- I am unable to test this on Emacs 30, but I checked the source code and `window--delete` in `window.el`, which is the function that I think should be changed, seems to do the same as in Emacs 29.1. -- Al
Al Haji-Ali <abdo.haji.ali@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#71386
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.