GNU logs - #71419, boring messages

Message sent to monnier@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#71419: 30.0.50; Completion does not always highlight the "common part" corresponding to suffix
Resent-From: Dmitry Gutov <dmitry@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: monnier@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 07 Jun 2024 22:38:01 +0000
Resent-Message-ID: <handler.71419.B.171779982827736 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71419 <at> debbugs.gnu.org
Cc: monnier@HIDDEN
Feedback-ID: i0e71465a:Fastmail
Message-ID: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
Date: Sat, 8 Jun 2024 01:36:42 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=103.168.172.153; envelope-from=dmitry@HIDDEN;
 helo=fhigh2-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

X-Debbugs-Cc: monnier@HIDDEN

For example:

1. Type

   (fo|-function

where | denotes the position of point.

2. C-M-i

You get 5 completions (the exact number is not important), where "fo" is
highlighted in all of them, but "function is not.

3. Move point to after "-" (meaning, just one character forward), press
C-M-i again (twice).

Completion expands the text to "(fo-|-function" (the addition might be
unimportant) and "function" is highlighted with the face
`completions-common-part' now, in all completions.

This seems inconsistent.

Also, highlighting is information. If it was more uniform, we could use
it to e.g. address the FIXME in completion-all-completions. Though
that's up for discussion, given that highlighting is inherently less
reliable than other methods we use. But it would be a non-breaking
change, OT2H.

WDYT?

In GNU Emacs 30.0.50 (build 28, x86_64-pc-linux-gnu, X toolkit, cairo
  version 1.18.0, Xaw scroll bars) of 2024-06-07 built on potemkin
Repository revision: b571c6571c8bc4c34569650104aee273c19cbfd4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12302000
System Description: Ubuntu 23.10

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: bug#71419: Acknowledgement (30.0.50; Completion does not always
 highlight the "common part" corresponding to suffix)
Message-ID: <handler.71419.B.171779982827736.ack <at> debbugs.gnu.org>
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
X-Gnu-PR-Message: ack 71419
X-Gnu-PR-Package: emacs
Reply-To: 71419 <at> debbugs.gnu.org
Date: Fri, 07 Jun 2024 22:38:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  monnier@HIDDEN
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 71419 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
71419: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71419
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#71419: 30.0.50; Completion does not always highlight the "common part" corresponding to suffix
Resent-From: Dmitry Gutov <dmitry@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 07 Jun 2024 22:49:03 +0000
Resent-Message-ID: <handler.71419.B71419.17178004947961 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71419 <at> debbugs.gnu.org
Cc: monnier@HIDDEN
Feedback-ID: i0e71465a:Fastmail
Message-ID: <213784df-1ec8-428d-843f-5a1165490bbb@HIDDEN>
Date: Sat, 8 Jun 2024 01:47:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Dmitry Gutov <dmitry@HIDDEN>
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
Content-Language: en-US
In-Reply-To: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 08/06/2024 01:36, Dmitry Gutov wrote:
> If it was more uniform, we could use
> it to e.g. address the FIXME in completion-all-completions.

To address bug#70968, among other things.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#71419: 30.0.50; Completion does not always highlight the "common part" corresponding to suffix
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 09 Jun 2024 13:54:02 +0000
Resent-Message-ID: <handler.71419.B71419.171794120722750 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Dmitry Gutov <dmitry@HIDDEN>
Cc: 71419 <at> debbugs.gnu.org
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN> (Dmitry Gutov's
 message of "Sat, 8 Jun 2024 01:36:42 +0300")
Message-ID: <jwved96rzzh.fsf-monnier+emacs@HIDDEN>
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
Date: Sun, 09 Jun 2024 09:52:56 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> For example:
>
> 1. Type (fo|-function
> 2. C-M-i
>
> You get 5 completions (the exact number is not important), where "fo" is
> highlighted in all of them, but "function is not.

Looks like a bug in the `basic` completion style: it filters things that
match the glob pattern `fo*-function` yet it only highlights the prefix.

> Also, highlighting is information. If it was more uniform, we could use
> it to e.g. address the FIXME in completion-all-completions.

I don't think it could be trusted to always provide the needed data (and
even if it does, it would be sufficiently clunky to use that I'm not
sure we'd want to rely on it).


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#71419: 30.0.50; Completion does not always highlight the "common part" corresponding to suffix
Resent-From: Dmitry Gutov <dmitry@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 09 Jun 2024 20:47:02 +0000
Resent-Message-ID: <handler.71419.B71419.1717966000852 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71419
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 71419 <at> debbugs.gnu.org
Received: via spool by 71419-submit <at> debbugs.gnu.org id=B71419.1717966000852
          (code B ref 71419); Sun, 09 Jun 2024 20:47:02 +0000
Received: (at 71419) by debbugs.gnu.org; 9 Jun 2024 20:46:40 +0000
Received: from localhost ([127.0.0.1]:59602 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sGPR1-0000Dg-Ib
	for submit <at> debbugs.gnu.org; Sun, 09 Jun 2024 16:46:39 -0400
Received: from wfout4-smtp.messagingengine.com ([64.147.123.147]:41631)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1sGPQy-0000DD-D7
 for 71419 <at> debbugs.gnu.org; Sun, 09 Jun 2024 16:46:37 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailfout.west.internal (Postfix) with ESMTP id 837001C00086;
 Sun,  9 Jun 2024 16:39:00 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Sun, 09 Jun 2024 16:39:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm3; t=1717965540;
 x=1718051940; bh=Z8s4RXWWELCiGWqZioPKnoYBoI9Wt+2aG+UFp8++Mz0=; b=
 Frr/HStWuojbT2kJQ8gqbQ/WwMVj/Ef2vUHD4m7arHN2rT9D5VJUl0Gu1VDF+uXd
 Isk7o643+FyfQL4sfpDI8OZmoc8F4UEpESUvM4c3NLeqHZulWq8ALu4om10j+sD0
 6sVOj4f8qG/Pg5VfQ8lg4QXdjGz/BEQU04ewLBhiqzpXKiAnfEDMyy9CuEZrXWlU
 GZbUgWImphFkUBd/h3LBbSIJ521H09p+UTryLL9+J9t8usFoSTYRZUGSnrYPuH+L
 X9ts59b2vgf4HlECQAO7g0/L+Vc934Q8sMeIvNgpNY990a6S6HABh9PkAPU++KUE
 N3VUBpa1sJcUhzKPnQXHHA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717965540; x=
 1718051940; bh=Z8s4RXWWELCiGWqZioPKnoYBoI9Wt+2aG+UFp8++Mz0=; b=W
 4MuvDnBTKkv4owSWpfR++b4rT2MM6V1Y6wIoC/uPGtrNerW/6Hjh8EWbYSRE1EgQ
 17RT2Y+WOuIJaIk7WvCAcZAOOgBj/46TJHOff+IzZQ/lYY3B+hbY8BLqQNO6+IQP
 39A6TKbW9JPDOKLFnsnoZdi44qEMK8N+Kn1k31yyzPcndJZ/RQkVOgAvbAs8mXSD
 5UMbVRUn4yHJkvZeBBZ45Ywh5ZEv32Rxqf1E/5MLrTqVlExg1nXNWIy+EOF6zxgb
 98ozZhokm51hV4pC4OBHDF0jMgIUfvwdUN/KOSF5NPdvLNQygRKr02cR3ZWu6094
 oufJQzd1//bja9sOOzwnQ==
X-ME-Sender: <xms:4xJmZj85Q1fJqmh--R_c77BZ_3-1tvQ7byAjTE0l1cAaOODyGjJABw>
 <xme:4xJmZvsVGD1lDh69vsYqSn9A_BvXEW1CmvBvNn5UM4wKZKSpI3Lhh7es653GgMdRD
 53u23A7WgH_uemoL04>
X-ME-Received: <xmr:4xJmZhA2xYs76xQkoKZzxN0HsPS0CnuHaSVn5MTw7EF3xm_aMbxbYxVrZ9ojtycFNsvF>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtjedgudehtdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm
 ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg
 htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg
 udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 gumhhithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:4xJmZvfQLa0EL_rw_2FMjVOgjQJgsPpEeeWHPjA8eWzgyjgnHqAD9A>
 <xmx:4xJmZoOnN_h_qLKp6u2ejCLbMCL2v_V4oTFuw3gf3Nbsk7iBArsdQA>
 <xmx:4xJmZhmh3DdMwwhwbfpS6sIsvJotwKGwhcAY3OxBOGmsI1hWGOaNcA>
 <xmx:4xJmZiufVqWqilOYeDoqw223oS-E-PlMpDmQIvwaAQEIfxv4T7J0IQ>
 <xmx:5BJmZhYC8d_hQL42nwH6MAVx-CsC1AZ2LIij-iTLITWMF2usRUXgBV6D>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 9 Jun 2024 16:38:59 -0400 (EDT)
Message-ID: <1dc364dc-1a16-4de4-9372-767906494610@HIDDEN>
Date: Sun, 9 Jun 2024 23:38:57 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
 <jwved96rzzh.fsf-monnier+emacs@HIDDEN>
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <jwved96rzzh.fsf-monnier+emacs@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 09/06/2024 16:52, Stefan Monnier wrote:
>> For example:
>>
>> 1. Type (fo|-function
>> 2. C-M-i
>>
>> You get 5 completions (the exact number is not important), where "fo" is
>> highlighted in all of them, but "function is not.
> 
> Looks like a bug in the `basic` completion style: it filters things that
> match the glob pattern `fo*-function` yet it only highlights the prefix.

Yes, thanks. Looks like this one-liner fixes it:

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index f62cb2566b2..144cda8cfdc 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -3816,7 +3816,7 @@ completion-basic-all-completions
                              'point
                              (substring afterpoint 0 (cdr bounds)))))
           (all (completion-pcm--all-completions prefix pattern table 
pred)))
-    (completion-hilit-commonality all point (car bounds))))
+    (completion-pcm--hilit-commonality pattern all)))

  ;;; Partial-completion-mode style completion.



>> Also, highlighting is information. If it was more uniform, we could use
>> it to e.g. address the FIXME in completion-all-completions.
> 
> I don't think it could be trusted to always provide the needed data (and
> even if it does, it would be sufficiently clunky to use that I'm not
> sure we'd want to rely on it).

You're probably right.

But it would have been nice to be able to use it in the "progressive 
improvement" kind of fashion: when the suffix and the other parts are 
highlighted correctly, we do the right thing; if the style missed the 
suffix highlighting, we do the other thing - and put the responsibility 
on the third party.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#71419: 30.0.50; Completion does not always highlight the "common part" corresponding to suffix
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 09 Jun 2024 21:08:01 +0000
Resent-Message-ID: <handler.71419.B71419.171796722815757 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71419
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Dmitry Gutov <dmitry@HIDDEN>
Cc: 71419 <at> debbugs.gnu.org
Received: via spool by 71419-submit <at> debbugs.gnu.org id=B71419.171796722815757
          (code B ref 71419); Sun, 09 Jun 2024 21:08:01 +0000
Received: (at 71419) by debbugs.gnu.org; 9 Jun 2024 21:07:08 +0000
Received: from localhost ([127.0.0.1]:60817 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sGPkp-000461-O9
	for submit <at> debbugs.gnu.org; Sun, 09 Jun 2024 17:07:08 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3930)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1sGPko-00045R-8f
 for 71419 <at> debbugs.gnu.org; Sun, 09 Jun 2024 17:07:06 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4DF1880882;
 Sun,  9 Jun 2024 17:06:44 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1717967203;
 bh=SriyvqmSDip4X4tOR/AkhHiCjWi+t8ldlMd5NPJPOdE=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=ZAYtlx66Y2znA9TUJsGJiHn1E+aXuX58cBG00SXiNhcAugR0ANccckca5nZWd3Ud2
 ncxUJydCeUldAPF+MfKVjbXZP8L0ovmpUoOs2CNY9xPSgNsLRBx5Hojoj1z7GrlUK6
 540FhpKOZfTtCwLY+mqwTE3ktntKkVxVwWlse3xADk4MKcSY/uWf962q+TErfRwhNO
 UdB7tUVkR3a+MMDJ/sBndxYDTWCVPeKssT0kHRurwAB23MPZ7Ln8OCN5p7tkcIDsgL
 9y5jWZ2ykYRrQlwCgWoXlKZAZrRJk0Z0GK4w2RDARxgJppfaJVdli49aXanqa0msIU
 kurjIvoY5EC1w==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4465980240;
 Sun,  9 Jun 2024 17:06:43 -0400 (EDT)
Received: from pastel (unknown [24.140.236.196])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1901E1203BC;
 Sun,  9 Jun 2024 17:06:43 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <1dc364dc-1a16-4de4-9372-767906494610@HIDDEN> (Dmitry Gutov's
 message of "Sun, 9 Jun 2024 23:38:57 +0300")
Message-ID: <jwvy17drfnf.fsf-monnier+emacs@HIDDEN>
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
 <jwved96rzzh.fsf-monnier+emacs@HIDDEN>
 <1dc364dc-1a16-4de4-9372-767906494610@HIDDEN>
Date: Sun, 09 Jun 2024 17:06:42 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.144 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index f62cb2566b2..144cda8cfdc 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -3816,7 +3816,7 @@ completion-basic-all-completions
>                              'point
>                              (substring afterpoint 0 (cdr bounds)))))
>           (all (completion-pcm--all-completions prefix pattern table pred=
)))
> -    (completion-hilit-commonality all point (car bounds))))
> +    (completion-pcm--hilit-commonality pattern all)))
>
>  ;;; Partial-completion-mode style completion.

Thanks for tracking it down.  It matches my expectation.

> But it would have been nice to be able to use it in the "progressive
>  improvement" kind of fashion: when the suffix and the other parts are
>  highlighted correctly, we do the right thing; if the style missed the
>  suffix highlighting, we do the other thing - and put the responsibility =
on
> the third party.

=F0=9F=99=82


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#71419: 30.0.50; Completion does not always highlight the "common part" corresponding to suffix
Resent-From: Dmitry Gutov <dmitry@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 12 Jun 2024 23:58:02 +0000
Resent-Message-ID: <handler.71419.B71419.17182366755930 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71419
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 71419 <at> debbugs.gnu.org
Received: via spool by 71419-submit <at> debbugs.gnu.org id=B71419.17182366755930
          (code B ref 71419); Wed, 12 Jun 2024 23:58:02 +0000
Received: (at 71419) by debbugs.gnu.org; 12 Jun 2024 23:57:55 +0000
Received: from localhost ([127.0.0.1]:60316 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sHXqk-0001XY-Iv
	for submit <at> debbugs.gnu.org; Wed, 12 Jun 2024 19:57:54 -0400
Received: from fout6-smtp.messagingengine.com ([103.168.172.149]:57725)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1sHXqh-0001XE-Nu
 for 71419 <at> debbugs.gnu.org; Wed, 12 Jun 2024 19:57:52 -0400
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
 by mailfout.nyi.internal (Postfix) with ESMTP id 3DB67138014F;
 Wed, 12 Jun 2024 19:57:47 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute6.internal (MEProxy); Wed, 12 Jun 2024 19:57:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-type:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:subject
 :subject:to:to; s=fm3; t=1718236667; x=1718323067; bh=j4biu7YSLx
 pOqq2PYhBjroceHfjBtZXKzxw2aPk6qwA=; b=fkhaPSgNWoHHL8fYYxCrji0F8T
 pNWnuj2FGcnW4DgbWuSjPa31ITprPkV4UsfJAQ/vnmmAVVYG7A3t4oeGuU5O3WWy
 eUCeO3A0qyj337d0l8iDWo0EkOCBN76uuQx/j+oZQNGjMjFzy3axXhYTJ4z80OA0
 iELbiTzb2sykoColhhAmXzRQ+ek6TUuVZVDtRTN2Hr5tKfulIWXVZhOiTWtUZXLJ
 2ZYhSiyuGpL4RpIjOAkw7H+XY/lVstd4dR+SD1+mN3DdLG5oRLKJPebk+xAGBOYG
 uw1B+pY3mAWUs1hmbEeIcIMbOTsBFU4XqJd4iCs/L6/8We8C+QR41X7yPAzQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:content-type:date:date
 :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:subject:subject:to
 :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1718236667; x=1718323067; bh=j4biu7YSLxpOqq2PYhBjroceHfjB
 tZXKzxw2aPk6qwA=; b=e9QWPfI1kL/3FrbBhheeOMdweQjcHyMh2GrmSU04HjT6
 RPqIDvVdIbMUIGWEu32y6er0jBdL1lH/M+ODN9OIMB2L09KvwaUwPIuYGdpbpBAR
 oEQx4TixiLSbF0f1ipxsHcIboaleyyVxttxBp/sSNDRB/fTTSQErJHHcB0Gbpjdo
 RwsU46ddEPHxTot0fKMS5onVkiocmxL6H3DzKcpTINK5dCZXSe1bbnGcYDaSGiyi
 S0uHtjhTL8N70P19lrOq1DbmFJocohoUYzMdrew4KSk7ZffOSGRFZCvx1mmuiCGC
 fWfWTPpKYCqO7icImZEJlKpJOWlAdrZbBfVuVsO8cg==
X-ME-Sender: <xms:-jVqZhQfjq0pLTYB5uNaKRQX53QYLs0Js-YNJaXgwxwPnFQ5gXcaFg>
 <xme:-jVqZqxP1dsJc8D4C69VRP_wY68OGUf9ZAw8-h8tFJt6ULTKCIw9unL72Rj8iPceQ
 DmgDDC6lnKe31gXhr4>
X-ME-Received: <xmr:-jVqZm3MV9HAEYIEeX0kqoKNcXiWC3hVTxxHePlZDiZmVpibUL1o7AYlhj1E_MS5p2DP>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeduiedgtdejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertddvjeenucfhrhhomhepffhmihht
 rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth
 gvrhhnpeehleefudekudduveekieelgfeiffdvkefhkeeljeeujeegueekveffkeejjeev
 heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh
 hithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:-jVqZpBka0Ps_cmusE_EEvNtrBTxSRNz403jB10OIAxQEImIXMMFQg>
 <xmx:-jVqZqj1FgKwsHe30os3TdVP5Ptoe6eWkDZTbEE0vLLIZkMZGloq3Q>
 <xmx:-jVqZtokQiyi2xVfTZjyeqcPuG2Mrc6IzeZnOEintuM62Wki1iN5XA>
 <xmx:-jVqZlge27yem2mwqoZ9L0cK-V4GQguX73D1dMj_8JKI0hjmsDtLDg>
 <xmx:-zVqZtsPnB2fsxgWOrM3eLCfpw-LZ8el2TW0Nfi-YqXkil0bRyn0z8eX>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 12 Jun 2024 19:57:46 -0400 (EDT)
Content-Type: multipart/mixed; boundary="------------LEGlwJ5I30yCb0AQRQRsEqAn"
Message-ID: <8446cd2d-7f27-4742-8193-3d83e7ef5f21@HIDDEN>
Date: Thu, 13 Jun 2024 02:57:43 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
 <jwved96rzzh.fsf-monnier+emacs@HIDDEN>
 <1dc364dc-1a16-4de4-9372-767906494610@HIDDEN>
 <jwvy17drfnf.fsf-monnier+emacs@HIDDEN>
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <jwvy17drfnf.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

This is a multi-part message in MIME format.
--------------LEGlwJ5I30yCb0AQRQRsEqAn
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/06/2024 00:06, Stefan Monnier wrote:
>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
>> index f62cb2566b2..144cda8cfdc 100644
>> --- a/lisp/minibuffer.el
>> +++ b/lisp/minibuffer.el
>> @@ -3816,7 +3816,7 @@ completion-basic-all-completions
>>                               'point
>>                               (substring afterpoint 0 (cdr bounds)))))
>>            (all (completion-pcm--all-completions prefix pattern table pred)))
>> -    (completion-hilit-commonality all point (car bounds))))
>> +    (completion-pcm--hilit-commonality pattern all)))
>>
>>   ;;; Partial-completion-mode style completion.
> 
> Thanks for tracking it down.  It matches my expectation.

Thanks, now fixed on master.

>> But it would have been nice to be able to use it in the "progressive
>>   improvement" kind of fashion: when the suffix and the other parts are
>>   highlighted correctly, we do the right thing; if the style missed the
>>   suffix highlighting, we do the other thing - and put the responsibility on
>> the third party.
> 
> 🙂

It could work like in the attached. I agree that it's somewhat brittle, 
though.

If you're not in favor of installing this patch, what would be your 
preferred strategy for fixing bug#70968? We could try resurrecting the 
relevant part of Daniel's patch for completion-all-completions, but it 
means a fair amount of breakage. Or another dynamic variable similar to 
completion-lazy-hilit-fn...

FWIW my interest here is how to better implement the same step in 
company-mode, but the default UI is a good common ground.
--------------LEGlwJ5I30yCb0AQRQRsEqAn
Content-Type: text/x-patch; charset=UTF-8;
 name="completions--count-common-spans.diff"
Content-Disposition: attachment;
 filename="completions--count-common-spans.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2xpc3AvbWluaWJ1ZmZlci5lbCBiL2xpc3AvbWluaWJ1ZmZlci5lbApp
bmRleCAxNDRjZGE4Y2ZkYy4uZDg5NTIwOTQxOTYgMTAwNjQ0Ci0tLSBhL2xpc3AvbWluaWJ1
ZmZlci5lbAorKysgYi9saXNwL21pbmlidWZmZXIuZWwKQEAgLTI1NTEsNiArMjU1MSwyNSBA
QCBjb21wbGV0aW9ucy0tYWZ0ZXItY2hhbmdlCiAgICAgICAod2l0aC1zZWxlY3RlZC13aW5k
b3cgd2luZG93CiAgICAgICAgIChjb21wbGV0aW9ucy0tZGVzZWxlY3QpKSkpKQogCisoZGVm
dW4gY29tcGxldGlvbnMtLWNvdW50LWNvbW1vbi1zcGFucyAoc3RyKQorICAobGV0ICgocG9z
IDApCisgICAgICAgIHByZXYtcG9zCisgICAgICAgIHZhbHVlCisgICAgICAgIChzdW0gMCkp
CisgICAgKHdoaWxlIHBvcworICAgICAgKHdoZW4gcHJldi1wb3MKKyAgICAgICAgKGNsLWlu
Y2Ygc3VtICgtIHBvcyBwcmV2LXBvcykpKQorICAgICAgKGlmIChhbmQgKHNldHEgdmFsdWUg
KGdldC10ZXh0LXByb3BlcnR5IHBvcyAnZmFjZSBzdHIpKQorICAgICAgICAgICAgICAgKGlm
IChsaXN0cCB2YWx1ZSkKKyAgICAgICAgICAgICAgICAgICAobWVtcSAnY29tcGxldGlvbnMt
Y29tbW9uLXBhcnQgdmFsdWUpCisgICAgICAgICAgICAgICAgIChlcSAnY29tcGxldGlvbnMt
Y29tbW9uLXBhcnQgdmFsdWUpKSkKKyAgICAgICAgICAoc2V0cSBwcmV2LXBvcyBwb3MpCisg
ICAgICAgIChzZXRxIHByZXYtcG9zIG5pbCkpCisgICAgICAoc2V0cSBwb3MgKG5leHQtc2lu
Z2xlLXByb3BlcnR5LWNoYW5nZSBwb3MgJ2ZhY2Ugc3RyKSkKKyAgICAgICh3aGVuIChhbmQg
KG5vdCBwb3MpIHByZXYtcG9zKQorICAgICAgICAoY2wtaW5jZiBzdW0gKC0gKGxlbmd0aCBz
dHIpIHByZXYtcG9zKSkpKQorICAgIHN1bSkpCisKIChkZWZ1biBtaW5pYnVmZmVyLWNvbXBs
ZXRpb24taGVscCAoJm9wdGlvbmFsIHN0YXJ0IGVuZCkKICAgIkRpc3BsYXkgYSBsaXN0IG9m
IHBvc3NpYmxlIGNvbXBsZXRpb25zIG9mIHRoZSBjdXJyZW50IG1pbmlidWZmZXIgY29udGVu
dHMuIgogICAoaW50ZXJhY3RpdmUpCkBAIC0yNzA2LDYgKzI3MjUsMTAgQEAgbWluaWJ1ZmZl
ci1jb21wbGV0aW9uLWhlbHAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7
IGJ1dCB0aGF0IGNsYXNoZWQgd2l0aCBhbm90aGVyIGV4aXN0aW5nIG1hcmtlci4KICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjbC1kZWNmIChudGggMSBiYXNlLXBvc2l0
aW9uKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKC0gZW5k
IHN0YXJ0IChsZW5ndGggY2hvaWNlKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICA7OyBDb21wbGV0aW9uIHN0eWxlIHRoYXQgZG9lc24ndCBtYXRjaCBzdWZmaXguCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodW5sZXNzICg+IChjb21wbGV0aW9u
cy0tY291bnQtY29tbW9uLXNwYW5zIGNob2ljZSkKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgKC0gKHBvaW50KSBzdGFydCkpCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGVuZCAocG9pbnQpKSkKICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIDs7IEZJWE1FOiBVc2UgYG1kJyB0byBkbyBxdW90aW5n
JnRlcm1pbmF0b3IgaGVyZS4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChj
b21wbGV0aW9uLS1yZXBsYWNlIHN0YXJ0IChtaW4gZW5kIChwb2ludC1tYXgpKSBjaG9pY2Up
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGV0KiAoKG1pbmlidWZmZXIt
Y29tcGxldGlvbi10YWJsZSBjdGFibGUpCg==

--------------LEGlwJ5I30yCb0AQRQRsEqAn--

Message sent:

MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: bug#71419: closed (30.0.50; Completion does not always highlight
 the "common part" corresponding to suffix)
CC: tracker <at> debbugs.gnu.org
Message-ID: <handler.71419.D71419.17407947718115.ackdone <at> debbugs.gnu.org>
References: <CADwFkmmGmQnDntrjo95eaeEZSDuFL0gT_o3jGdM4aA5VmSLUrg@HIDDEN>
 <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
X-Gnu-PR-Message: closed 71419
X-Gnu-PR-Package: emacs
Date: Sat, 01 Mar 2025 02:07:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1740794822-8388-0"

This is a multi-part message in MIME format...

------------=_1740794822-8388-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8

Your message dated Fri, 28 Feb 2025 18:06:01 -0800
with message-id <CADwFkmmGmQnDntrjo95eaeEZSDuFL0gT_o3jGdM4aA5VmSLUrg@HIDDEN=
mail.com>
and subject line Re: bug#71419: 30.0.50; Completion does not always highlig=
ht the "common part" corresponding to suffix
has caused the debbugs.gnu.org bug report #71419,
regarding 30.0.50; Completion does not always highlight the "common part" c=
orresponding to suffix
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@HIDDEN)


--=20
71419: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71419
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

------------=_1740794822-8388-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by debbugs.gnu.org; 7 Jun 2024 22:37:08 +0000
Received: from localhost ([127.0.0.1]:40874 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sFiCq-0007DG-28
	for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 18:37:08 -0400
Received: from lists.gnu.org ([209.51.188.17]:58440)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1sFiCm-0007D1-KI
 for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 18:37:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1sFiCW-0006Mi-QW
 for bug-gnu-emacs@HIDDEN; Fri, 07 Jun 2024 18:36:48 -0400
Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1sFiCU-0001W8-My
 for bug-gnu-emacs@HIDDEN; Fri, 07 Jun 2024 18:36:48 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailfhigh.nyi.internal (Postfix) with ESMTP id DD98D11400DB
 for <bug-gnu-emacs@HIDDEN>; Fri,  7 Jun 2024 18:36:45 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Fri, 07 Jun 2024 18:36:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :content-transfer-encoding:content-type:content-type:date:date
 :from:from:in-reply-to:message-id:mime-version:reply-to:subject
 :subject:to:to; s=fm3; t=1717799805; x=1717886205; bh=y4db/hDRYD
 ndpfqpBJd9pD5SvGjopMP4Jbwfiy/PJAc=; b=RaecTwobu6/iZn3VhBBoqF/ht2
 BDVZLsNV2/MTMhRSmHLLPyQylA52aePTNTv2ktOVeqUFVRhsrYCnZSVMCANX7v1D
 xL+AIuf4lFpx4wJ9+chJl27Gdn8vtNeTUmUT+s5GtHz/5sexgIPWP6h8n/U0Mg8h
 7LtoxDlOZC0PE7ZftEAIbYcwY5HK9W+2x507XHXcEIZzEr3dFUt4NQVGS73g5yrS
 4qHLikewWynzVrxQuO4t/jrUzKppIIL5gSNZzuY8lK8ZUfv8QGDDJLj9+0idOdce
 aGTyb2Vy9RPw7eD5aQTgZo8MzrmVRQFDTVOoxWKCYRI0Dpg+Ld9/UJHlLBfQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:message-id:mime-version:reply-to:subject:subject:to
 :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1717799805; x=1717886205; bh=y4db/hDRYDndpfqpBJd9pD5SvGjo
 pMP4Jbwfiy/PJAc=; b=Mg4Vqw1A/NIOAbhsCZxmYvfc0sQwYp512wt36D4k5Cep
 sOQE4ZzsyytHmxw5Wr6UxexdBgGwkJe/RMsXF34BNOL4Ahwu65137lyAHncKXMHl
 Xo88C/XKVZz6KTSIg5Xeielr0x4FXd4m767bkTPpswzF7QK6J+I8QNcOdjc9OoFb
 I703a5gyrWsl/Sq++JmKEIsz0Eq46PxkaMKj1BnzkKRlU1pRYe/I+LUYFiXHTR/e
 lE3BosddJiNivl2qoS/yZC6MsqUuRASi0PBq5hCgZCiYd6xm+5lZRSyznRQCCGfR
 DEu0EFa7mHxnrcI+PAKiDrc/RWEu1BkvfKD0TW0Q/A==
X-ME-Sender: <xms:fYtjZnGwWnqWSkEFMhwIukcQNooYwx-o3Ejgxr8gl7F3FR2mnAxrMQ>
 <xme:fYtjZkXCRIH9-W9SH3LXhaV_kuwHp3aayeblv7vXPkU-WqE0grZcpMWDWYfhQjAQ3
 ctOICXwgDg-_zdjLe0>
X-ME-Received: <xmr:fYtjZpINzbVI263ncKvROu9KZymnn6cZNfftiDjUdVxYsnC-Zg38NXkL5kivfvYHZe44>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtvddgudduucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfvuffhtgfgsehtjeertd
 dtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthho
 vhdruggvvheqnecuggftrfgrthhtvghrnhephfetveeuhfdvudeuhfevhfeukeeiteekle
 evtefhgedvfeefgedtffeifeethfejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
 rghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:fYtjZlFf-wVMth0Ur7bLdA6uBXVduVtj6MYrLj4hNgn4zyPICPP31g>
 <xmx:fYtjZtUfmrzo5SkgqDrCTdOwx8XoW1t4bugO6ihlhcqvUJ0NhYFNuA>
 <xmx:fYtjZgOIe1VzlviUKfSfD72wGnpT_sIIwTS0jVgZuKAIAChbdnk6QQ>
 <xmx:fYtjZs0sLdHcAj4ypk25opxo0YVuYSg6wzTiyfy1ynQq6_UaGDI--A>
 <xmx:fYtjZsejphaBSxnERHKx7VUe-8P4AGTlzfmDRVJFYeg_3UhUOmGCaqAh>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <bug-gnu-emacs@HIDDEN>; Fri, 7 Jun 2024 18:36:45 -0400 (EDT)
Message-ID: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
Date: Sat, 8 Jun 2024 01:36:42 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; Completion does not always highlight the "common part"
 corresponding to suffix
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=103.168.172.153; envelope-from=dmitry@HIDDEN;
 helo=fhigh2-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

X-Debbugs-Cc: monnier@HIDDEN

For example:

1. Type

   (fo|-function

where | denotes the position of point.

2. C-M-i

You get 5 completions (the exact number is not important), where "fo" is
highlighted in all of them, but "function is not.

3. Move point to after "-" (meaning, just one character forward), press
C-M-i again (twice).

Completion expands the text to "(fo-|-function" (the addition might be
unimportant) and "function" is highlighted with the face
`completions-common-part' now, in all completions.

This seems inconsistent.

Also, highlighting is information. If it was more uniform, we could use
it to e.g. address the FIXME in completion-all-completions. Though
that's up for discussion, given that highlighting is inherently less
reliable than other methods we use. But it would be a non-breaking
change, OT2H.

WDYT?

In GNU Emacs 30.0.50 (build 28, x86_64-pc-linux-gnu, X toolkit, cairo
  version 1.18.0, Xaw scroll bars) of 2024-06-07 built on potemkin
Repository revision: b571c6571c8bc4c34569650104aee273c19cbfd4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12302000
System Description: Ubuntu 23.10



------------=_1740794822-8388-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 71419-done) by debbugs.gnu.org; 1 Mar 2025 02:06:11 +0000
Received: from localhost ([127.0.0.1]:55929 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toCEz-00026d-V6
	for submit <at> debbugs.gnu.org; Fri, 28 Feb 2025 21:06:10 -0500
Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:48495)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1toCEy-00025U-2V
 for 71419-done <at> debbugs.gnu.org; Fri, 28 Feb 2025 21:06:08 -0500
Received: by mail-ed1-x52f.google.com with SMTP id
 4fb4d7f45d1cf-5e4c0c12bccso4846617a12.1
 for <71419-done <at> debbugs.gnu.org>; Fri, 28 Feb 2025 18:06:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740794762; x=1741399562; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=OBHuBDQlu3AwZw7mIFyq+6SWXUWaAVxoGJRAPUccHEc=;
 b=LzSnAcy4TQZroj3dB8JtmGVZa8SOY05l2d3X3BD4ItAr75AJmxeuyG2mHcSlQa3qT1
 9Hqz8At40jEj6jsE0FJBbMFtrLV1x53rFRTfOX/gFU6nnWUF0JWOHFFXMwAbB/aE1fG4
 8FppXJU/+Zfhu20kqfpFyXjVMB42ovLEQ/OkNJZASN7zb1wah1UAlzwo3zWg8c/74TMP
 sVuLVzdtPbRHROqMXYyLZ7pdaY3fXeJ8YcvuU8JqP4gn8f5FQ/kopI7IEAqH7Uy9UgSd
 cWEJxQapCzB6hOiCkkul0irG/odIPEMzXbOoUz/lyuGVIaXGkyovcaR8E3bnzmm6UGEH
 T7qA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740794762; x=1741399562;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=OBHuBDQlu3AwZw7mIFyq+6SWXUWaAVxoGJRAPUccHEc=;
 b=oZVRa3RikFShHTnjLpYx2SnIZG4qsfYIYfUPv81KLsAv/r765jeMoYG+GuZMDHSt4F
 pcGPes5qkjloJs179WkOU1Vmh0LEdDZz1bdXFM76tQGb5CN4enhHmQmC3Toe/FTW3JRl
 n8rpwV/PzNmHHzwlBPimihZiZC4rMl/LqPvk/Cn1zIC0W/zzjsssCGqsL3auo8iC/Tg9
 MAn00y2GWup5wP3newTayNTOsj3WEiCiz2wiC21wFnSQxmZqLONf0jnxrHR3MSRFS6LK
 u2xuadOmptdn8w4NAxlK0ht5kkJ6+BVBu7k0SEb4d8emxrrRC3stEhVSrPS5lHh7w4xe
 pNIQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCV/bgYLYwTG06vMMf8bXq54++KqDzyIk229cyy8reuU1Flo0FI6fZW6QEKwHNqnwDISl/jTdTOc1utF <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0Yz6IWsGoFKgs48Sggdabvee/E/U2XxBc/xM80XZsVMx0Pyta89z
 funou3UePaX3Cr2vW6GQwDEq7TrZ263YJs6OdQI3On4+ZK+UbuJJ6/RKHHHxclAAI1wSHTaV7rH
 9opqRImQaEO6LlUA56B133gih+BM=
X-Gm-Gg: ASbGncs8tfFV71MpsSP5thfQePkOQK6+jytZG7MQbApFP7idKjZ4dVEbq4kGZusqDoU
 bzVbXRUHPIY3Zu6cq445okYWO/ltuTuAmxkEXDJnu15PIq3Lf8G1qF7uuw7HbxcgKLLWjvnn11N
 1Bcs2atD41L2AnVyK5jgE2sbMpKM0=
X-Google-Smtp-Source: AGHT+IE1stz5fOtkAMykebKK8UJAbfOP4zWuUbG+nF2raGvDTbk+WKp/DufvKOmR5JzVDI7ASOsv+6VShvoqfNCTqdo=
X-Received: by 2002:a05:6402:27c7:b0:5e4:cd12:59f3 with SMTP id
 4fb4d7f45d1cf-5e4d6b858cdmr4379736a12.31.1740794761726; Fri, 28 Feb 2025
 18:06:01 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Fri, 28 Feb 2025 18:06:01 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <8446cd2d-7f27-4742-8193-3d83e7ef5f21@HIDDEN>
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
 <jwved96rzzh.fsf-monnier+emacs@HIDDEN>
 <1dc364dc-1a16-4de4-9372-767906494610@HIDDEN>
 <jwvy17drfnf.fsf-monnier+emacs@HIDDEN>
 <8446cd2d-7f27-4742-8193-3d83e7ef5f21@HIDDEN>
MIME-Version: 1.0
Date: Fri, 28 Feb 2025 18:06:01 -0800
X-Gm-Features: AQ5f1JojeSoOK4Rtzu8nGDU_y0pZjRbFn4DsrPUrLwO3wrlyO_iPVNXIZ6Ta-gc
Message-ID: <CADwFkmmGmQnDntrjo95eaeEZSDuFL0gT_o3jGdM4aA5VmSLUrg@HIDDEN>
Subject: Re: bug#71419: 30.0.50; Completion does not always highlight the
 "common part" corresponding to suffix
To: Dmitry Gutov <dmitry@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 71419-done
Cc: Stefan Monnier <monnier@HIDDEN>, 71419-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Dmitry Gutov <dmitry@HIDDEN> writes:

> On 10/06/2024 00:06, Stefan Monnier wrote:
>>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
>>> index f62cb2566b2..144cda8cfdc 100644
>>> --- a/lisp/minibuffer.el
>>> +++ b/lisp/minibuffer.el
>>> @@ -3816,7 +3816,7 @@ completion-basic-all-completions
>>>                               'point
>>>                               (substring afterpoint 0 (cdr bounds)))))
>>>            (all (completion-pcm--all-completions prefix pattern table p=
red)))
>>> -    (completion-hilit-commonality all point (car bounds))))
>>> +    (completion-pcm--hilit-commonality pattern all)))
>>>
>>>   ;;; Partial-completion-mode style completion.
>> Thanks for tracking it down.  It matches my expectation.
>
> Thanks, now fixed on master.

I'm therefore closing this bug report.

>
>>> But it would have been nice to be able to use it in the "progressive
>>>   improvement" kind of fashion: when the suffix and the other parts are
>>>   highlighted correctly, we do the right thing; if the style missed the
>>>   suffix highlighting, we do the other thing - and put the responsibili=
ty on
>>> the third party.
>> =F0=9F=99=82
>
> It could work like in the attached. I agree that it's somewhat brittle, t=
hough.
>
> If you're not in favor of installing this patch, what would be your prefe=
rred
> strategy for fixing bug#70968? We could try resurrecting the relevant par=
t of
> Daniel's patch for completion-all-completions, but it means a fair amount=
 of
> breakage. Or another dynamic variable similar to completion-lazy-hilit-fn=
...
>
> FWIW my interest here is how to better implement the same step in company=
-mode,
> but the default UI is a good common ground.


------------=_1740794822-8388-0--

Message sent:

MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: bug#71419: closed (Re: bug#71419: 30.0.50; Completion does not
 always highlight the "common part" corresponding to suffix)
Message-ID: <handler.71419.D71419.17407947718115.notifdone <at> debbugs.gnu.org>
References: <CADwFkmmGmQnDntrjo95eaeEZSDuFL0gT_o3jGdM4aA5VmSLUrg@HIDDEN>
 <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
X-Gnu-PR-Message: they-closed 71419
X-Gnu-PR-Package: emacs
Reply-To: 71419 <at> debbugs.gnu.org
Date: Sat, 01 Mar 2025 02:07:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1740794822-8388-1"

This is a multi-part message in MIME format...

------------=_1740794822-8388-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Your bug report

#71419: 30.0.50; Completion does not always highlight the "common part" cor=
responding to suffix

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 71419 <at> debbugs.gnu.org.

--=20
71419: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71419
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

------------=_1740794822-8388-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 71419-done) by debbugs.gnu.org; 1 Mar 2025 02:06:11 +0000
Received: from localhost ([127.0.0.1]:55929 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toCEz-00026d-V6
	for submit <at> debbugs.gnu.org; Fri, 28 Feb 2025 21:06:10 -0500
Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:48495)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1toCEy-00025U-2V
 for 71419-done <at> debbugs.gnu.org; Fri, 28 Feb 2025 21:06:08 -0500
Received: by mail-ed1-x52f.google.com with SMTP id
 4fb4d7f45d1cf-5e4c0c12bccso4846617a12.1
 for <71419-done <at> debbugs.gnu.org>; Fri, 28 Feb 2025 18:06:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740794762; x=1741399562; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=OBHuBDQlu3AwZw7mIFyq+6SWXUWaAVxoGJRAPUccHEc=;
 b=LzSnAcy4TQZroj3dB8JtmGVZa8SOY05l2d3X3BD4ItAr75AJmxeuyG2mHcSlQa3qT1
 9Hqz8At40jEj6jsE0FJBbMFtrLV1x53rFRTfOX/gFU6nnWUF0JWOHFFXMwAbB/aE1fG4
 8FppXJU/+Zfhu20kqfpFyXjVMB42ovLEQ/OkNJZASN7zb1wah1UAlzwo3zWg8c/74TMP
 sVuLVzdtPbRHROqMXYyLZ7pdaY3fXeJ8YcvuU8JqP4gn8f5FQ/kopI7IEAqH7Uy9UgSd
 cWEJxQapCzB6hOiCkkul0irG/odIPEMzXbOoUz/lyuGVIaXGkyovcaR8E3bnzmm6UGEH
 T7qA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740794762; x=1741399562;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=OBHuBDQlu3AwZw7mIFyq+6SWXUWaAVxoGJRAPUccHEc=;
 b=oZVRa3RikFShHTnjLpYx2SnIZG4qsfYIYfUPv81KLsAv/r765jeMoYG+GuZMDHSt4F
 pcGPes5qkjloJs179WkOU1Vmh0LEdDZz1bdXFM76tQGb5CN4enhHmQmC3Toe/FTW3JRl
 n8rpwV/PzNmHHzwlBPimihZiZC4rMl/LqPvk/Cn1zIC0W/zzjsssCGqsL3auo8iC/Tg9
 MAn00y2GWup5wP3newTayNTOsj3WEiCiz2wiC21wFnSQxmZqLONf0jnxrHR3MSRFS6LK
 u2xuadOmptdn8w4NAxlK0ht5kkJ6+BVBu7k0SEb4d8emxrrRC3stEhVSrPS5lHh7w4xe
 pNIQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCV/bgYLYwTG06vMMf8bXq54++KqDzyIk229cyy8reuU1Flo0FI6fZW6QEKwHNqnwDISl/jTdTOc1utF <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0Yz6IWsGoFKgs48Sggdabvee/E/U2XxBc/xM80XZsVMx0Pyta89z
 funou3UePaX3Cr2vW6GQwDEq7TrZ263YJs6OdQI3On4+ZK+UbuJJ6/RKHHHxclAAI1wSHTaV7rH
 9opqRImQaEO6LlUA56B133gih+BM=
X-Gm-Gg: ASbGncs8tfFV71MpsSP5thfQePkOQK6+jytZG7MQbApFP7idKjZ4dVEbq4kGZusqDoU
 bzVbXRUHPIY3Zu6cq445okYWO/ltuTuAmxkEXDJnu15PIq3Lf8G1qF7uuw7HbxcgKLLWjvnn11N
 1Bcs2atD41L2AnVyK5jgE2sbMpKM0=
X-Google-Smtp-Source: AGHT+IE1stz5fOtkAMykebKK8UJAbfOP4zWuUbG+nF2raGvDTbk+WKp/DufvKOmR5JzVDI7ASOsv+6VShvoqfNCTqdo=
X-Received: by 2002:a05:6402:27c7:b0:5e4:cd12:59f3 with SMTP id
 4fb4d7f45d1cf-5e4d6b858cdmr4379736a12.31.1740794761726; Fri, 28 Feb 2025
 18:06:01 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Fri, 28 Feb 2025 18:06:01 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <8446cd2d-7f27-4742-8193-3d83e7ef5f21@HIDDEN>
References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
 <jwved96rzzh.fsf-monnier+emacs@HIDDEN>
 <1dc364dc-1a16-4de4-9372-767906494610@HIDDEN>
 <jwvy17drfnf.fsf-monnier+emacs@HIDDEN>
 <8446cd2d-7f27-4742-8193-3d83e7ef5f21@HIDDEN>
MIME-Version: 1.0
Date: Fri, 28 Feb 2025 18:06:01 -0800
X-Gm-Features: AQ5f1JojeSoOK4Rtzu8nGDU_y0pZjRbFn4DsrPUrLwO3wrlyO_iPVNXIZ6Ta-gc
Message-ID: <CADwFkmmGmQnDntrjo95eaeEZSDuFL0gT_o3jGdM4aA5VmSLUrg@HIDDEN>
Subject: Re: bug#71419: 30.0.50; Completion does not always highlight the
 "common part" corresponding to suffix
To: Dmitry Gutov <dmitry@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 71419-done
Cc: Stefan Monnier <monnier@HIDDEN>, 71419-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Dmitry Gutov <dmitry@HIDDEN> writes:

> On 10/06/2024 00:06, Stefan Monnier wrote:
>>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
>>> index f62cb2566b2..144cda8cfdc 100644
>>> --- a/lisp/minibuffer.el
>>> +++ b/lisp/minibuffer.el
>>> @@ -3816,7 +3816,7 @@ completion-basic-all-completions
>>>                               'point
>>>                               (substring afterpoint 0 (cdr bounds)))))
>>>            (all (completion-pcm--all-completions prefix pattern table p=
red)))
>>> -    (completion-hilit-commonality all point (car bounds))))
>>> +    (completion-pcm--hilit-commonality pattern all)))
>>>
>>>   ;;; Partial-completion-mode style completion.
>> Thanks for tracking it down.  It matches my expectation.
>
> Thanks, now fixed on master.

I'm therefore closing this bug report.

>
>>> But it would have been nice to be able to use it in the "progressive
>>>   improvement" kind of fashion: when the suffix and the other parts are
>>>   highlighted correctly, we do the right thing; if the style missed the
>>>   suffix highlighting, we do the other thing - and put the responsibili=
ty on
>>> the third party.
>> =F0=9F=99=82
>
> It could work like in the attached. I agree that it's somewhat brittle, t=
hough.
>
> If you're not in favor of installing this patch, what would be your prefe=
rred
> strategy for fixing bug#70968? We could try resurrecting the relevant par=
t of
> Daniel's patch for completion-all-completions, but it means a fair amount=
 of
> breakage. Or another dynamic variable similar to completion-lazy-hilit-fn=
...
>
> FWIW my interest here is how to better implement the same step in company=
-mode,
> but the default UI is a good common ground.


------------=_1740794822-8388-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by debbugs.gnu.org; 7 Jun 2024 22:37:08 +0000
Received: from localhost ([127.0.0.1]:40874 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sFiCq-0007DG-28
	for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 18:37:08 -0400
Received: from lists.gnu.org ([209.51.188.17]:58440)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1sFiCm-0007D1-KI
 for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 18:37:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1sFiCW-0006Mi-QW
 for bug-gnu-emacs@HIDDEN; Fri, 07 Jun 2024 18:36:48 -0400
Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1sFiCU-0001W8-My
 for bug-gnu-emacs@HIDDEN; Fri, 07 Jun 2024 18:36:48 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailfhigh.nyi.internal (Postfix) with ESMTP id DD98D11400DB
 for <bug-gnu-emacs@HIDDEN>; Fri,  7 Jun 2024 18:36:45 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Fri, 07 Jun 2024 18:36:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :content-transfer-encoding:content-type:content-type:date:date
 :from:from:in-reply-to:message-id:mime-version:reply-to:subject
 :subject:to:to; s=fm3; t=1717799805; x=1717886205; bh=y4db/hDRYD
 ndpfqpBJd9pD5SvGjopMP4Jbwfiy/PJAc=; b=RaecTwobu6/iZn3VhBBoqF/ht2
 BDVZLsNV2/MTMhRSmHLLPyQylA52aePTNTv2ktOVeqUFVRhsrYCnZSVMCANX7v1D
 xL+AIuf4lFpx4wJ9+chJl27Gdn8vtNeTUmUT+s5GtHz/5sexgIPWP6h8n/U0Mg8h
 7LtoxDlOZC0PE7ZftEAIbYcwY5HK9W+2x507XHXcEIZzEr3dFUt4NQVGS73g5yrS
 4qHLikewWynzVrxQuO4t/jrUzKppIIL5gSNZzuY8lK8ZUfv8QGDDJLj9+0idOdce
 aGTyb2Vy9RPw7eD5aQTgZo8MzrmVRQFDTVOoxWKCYRI0Dpg+Ld9/UJHlLBfQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:message-id:mime-version:reply-to:subject:subject:to
 :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1717799805; x=1717886205; bh=y4db/hDRYDndpfqpBJd9pD5SvGjo
 pMP4Jbwfiy/PJAc=; b=Mg4Vqw1A/NIOAbhsCZxmYvfc0sQwYp512wt36D4k5Cep
 sOQE4ZzsyytHmxw5Wr6UxexdBgGwkJe/RMsXF34BNOL4Ahwu65137lyAHncKXMHl
 Xo88C/XKVZz6KTSIg5Xeielr0x4FXd4m767bkTPpswzF7QK6J+I8QNcOdjc9OoFb
 I703a5gyrWsl/Sq++JmKEIsz0Eq46PxkaMKj1BnzkKRlU1pRYe/I+LUYFiXHTR/e
 lE3BosddJiNivl2qoS/yZC6MsqUuRASi0PBq5hCgZCiYd6xm+5lZRSyznRQCCGfR
 DEu0EFa7mHxnrcI+PAKiDrc/RWEu1BkvfKD0TW0Q/A==
X-ME-Sender: <xms:fYtjZnGwWnqWSkEFMhwIukcQNooYwx-o3Ejgxr8gl7F3FR2mnAxrMQ>
 <xme:fYtjZkXCRIH9-W9SH3LXhaV_kuwHp3aayeblv7vXPkU-WqE0grZcpMWDWYfhQjAQ3
 ctOICXwgDg-_zdjLe0>
X-ME-Received: <xmr:fYtjZpINzbVI263ncKvROu9KZymnn6cZNfftiDjUdVxYsnC-Zg38NXkL5kivfvYHZe44>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtvddgudduucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfvuffhtgfgsehtjeertd
 dtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthho
 vhdruggvvheqnecuggftrfgrthhtvghrnhephfetveeuhfdvudeuhfevhfeukeeiteekle
 evtefhgedvfeefgedtffeifeethfejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
 rghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:fYtjZlFf-wVMth0Ur7bLdA6uBXVduVtj6MYrLj4hNgn4zyPICPP31g>
 <xmx:fYtjZtUfmrzo5SkgqDrCTdOwx8XoW1t4bugO6ihlhcqvUJ0NhYFNuA>
 <xmx:fYtjZgOIe1VzlviUKfSfD72wGnpT_sIIwTS0jVgZuKAIAChbdnk6QQ>
 <xmx:fYtjZs0sLdHcAj4ypk25opxo0YVuYSg6wzTiyfy1ynQq6_UaGDI--A>
 <xmx:fYtjZsejphaBSxnERHKx7VUe-8P4AGTlzfmDRVJFYeg_3UhUOmGCaqAh>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <bug-gnu-emacs@HIDDEN>; Fri, 7 Jun 2024 18:36:45 -0400 (EDT)
Message-ID: <96abea7d-3e18-4a81-8b6c-79dd0b496420@HIDDEN>
Date: Sat, 8 Jun 2024 01:36:42 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; Completion does not always highlight the "common part"
 corresponding to suffix
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=103.168.172.153; envelope-from=dmitry@HIDDEN;
 helo=fhigh2-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

X-Debbugs-Cc: monnier@HIDDEN

For example:

1. Type

   (fo|-function

where | denotes the position of point.

2. C-M-i

You get 5 completions (the exact number is not important), where "fo" is
highlighted in all of them, but "function is not.

3. Move point to after "-" (meaning, just one character forward), press
C-M-i again (twice).

Completion expands the text to "(fo-|-function" (the addition might be
unimportant) and "function" is highlighted with the face
`completions-common-part' now, in all completions.

This seems inconsistent.

Also, highlighting is information. If it was more uniform, we could use
it to e.g. address the FIXME in completion-all-completions. Though
that's up for discussion, given that highlighting is inherently less
reliable than other methods we use. But it would be a non-breaking
change, OT2H.

WDYT?

In GNU Emacs 30.0.50 (build 28, x86_64-pc-linux-gnu, X toolkit, cairo
  version 1.18.0, Xaw scroll bars) of 2024-06-07 built on potemkin
Repository revision: b571c6571c8bc4c34569650104aee273c19cbfd4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12302000
System Description: Ubuntu 23.10



------------=_1740794822-8388-1--

Last modified: Sat, 1 Mar 2025 02:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.