GNU bug report logs - #71489
Two libtool issues

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71489 in the body.
You can then email your comments to 71489 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Sergey Poznyakoff" <gray <at> gnu.org.ua>
To: <bug-libtool <at> gnu.org>
Subject: Two libtool issues
Date: Tue, 11 Jun 2024 13:20:15 +0200

Hello,

Some time ago I discovered two libool issues related to the library
preference, which caused lots of problems in GNU mailutils.  The issues
are described in detail in the following article:

  https://gray.gnu.org.ua/public/ltbug

(Sorry if it is too long: I tried to provide as much detail as possible,
along with examples and proposed patches).  
  
I reported that to the bug-libtool list on 2019-12-14. Back then I got a
reply which seemed to stem from misreading rather than from an attempt to
understand the problem. So I ended up distributing a patched ltmain.sh
with GNU mailutils.

Is there any chance these issues can be addressed in libtool?

Regards,
Sergey

Message #8 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: Sergey Poznyakoff <gray <at> gnu.org.ua>, 71489 <at> debbugs.gnu.org
Subject: Re: bug#71489: Two libtool issues
Date: Fri, 9 Aug 2024 20:23:36 +0300

[Message part 1 (text/plain, inline)]

Hi Sergey,

On 11/06/2024 14:20, Sergey Poznyakoff wrote:
> Hello,
> 
> Some time ago I discovered two libool issues related to the library
> preference, which caused lots of problems in GNU mailutils.  The issues
> are described in detail in the following article:
> 
>    https://gray.gnu.org.ua/public/ltbug
> 
> (Sorry if it is too long: I tried to provide as much detail as possible,
> along with examples and proposed patches).
>    
> I reported that to the bug-libtool list on 2019-12-14. Back then I got a
> reply which seemed to stem from misreading rather than from an attempt to
> understand the problem. So I ended up distributing a patched ltmain.sh
> with GNU mailutils.
> 
> Is there any chance these issues can be addressed in libtool?

Thank you for your bug report and all of the detail that you provided. I
have replicated your errors and created a test file based off of your
testcases. It has been applied to libtool's development branch [1]. If
you would verify the patch and test file are applied properly for this
issue, I will close the bug.

Also, thank you for reporting these issues again. I am sorry it was not
looked into sooner.

[1] 
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=998a3347622014a0ecb58bdf57388b3f545e5934

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #11 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: Sam James <sam <at> gentoo.org>
To: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
Cc: Sergey Poznyakoff <gray <at> gnu.org.ua>, 71489 <at> debbugs.gnu.org
Subject: Re: bug#71489: Two libtool issues
Date: Fri, 09 Aug 2024 18:41:41 +0100

Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com> writes:

> Hi Sergey,
>
> On 11/06/2024 14:20, Sergey Poznyakoff wrote:
>> Hello,
>> Some time ago I discovered two libool issues related to the library
>> preference, which caused lots of problems in GNU mailutils.  The issues
>> are described in detail in the following article:
>>    https://gray.gnu.org.ua/public/ltbug
>> (Sorry if it is too long: I tried to provide as much detail as
>> possible,
>> along with examples and proposed patches).
>>    I reported that to the bug-libtool list on 2019-12-14. Back then
>> I got a
>> reply which seemed to stem from misreading rather than from an attempt to
>> understand the problem. So I ended up distributing a patched ltmain.sh
>> with GNU mailutils.
>> Is there any chance these issues can be addressed in libtool?
>
> Thank you for your bug report and all of the detail that you provided. I
> have replicated your errors and created a test file based off of your
> testcases. It has been applied to libtool's development branch [1]. If
> you would verify the patch and test file are applied properly for this
> issue, I will close the bug.

The writeup is genuinely excellent - still digesting it.

It looks to me like
https://gray.gnu.org.ua/public/ltbug/0001-ltmain.in-append-rpath-option-arguments-to-finalize_.patch
did get applied but merged into one patch so the commit message from the
1st one got lost. Not sure if that's worth changing.

>
> Also, thank you for reporting these issues again. I am sorry it was not
> looked into sooner.
>
> [1]
> https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=998a3347622014a0ecb58bdf57388b3f545e5934

Message #14 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: Sam James <sam <at> gentoo.org>
Cc: Sergey Poznyakoff <gray <at> gnu.org.ua>, 71489 <at> debbugs.gnu.org
Subject: Re: bug#71489: Two libtool issues
Date: Fri, 9 Aug 2024 20:51:48 +0300

[Message part 1 (text/plain, inline)]

Hi Sam,

On 09/08/2024 20:41, Sam James wrote:
> Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com> writes:
> 
>> Hi Sergey,
>>
>> On 11/06/2024 14:20, Sergey Poznyakoff wrote:
>>> Hello,
>>> Some time ago I discovered two libool issues related to the library
>>> preference, which caused lots of problems in GNU mailutils.  The issues
>>> are described in detail in the following article:
>>>     https://gray.gnu.org.ua/public/ltbug
>>> (Sorry if it is too long: I tried to provide as much detail as
>>> possible,
>>> along with examples and proposed patches).
>>>     I reported that to the bug-libtool list on 2019-12-14. Back then
>>> I got a
>>> reply which seemed to stem from misreading rather than from an attempt to
>>> understand the problem. So I ended up distributing a patched ltmain.sh
>>> with GNU mailutils.
>>> Is there any chance these issues can be addressed in libtool?
>>
>> Thank you for your bug report and all of the detail that you provided. I
>> have replicated your errors and created a test file based off of your
>> testcases. It has been applied to libtool's development branch [1]. If
>> you would verify the patch and test file are applied properly for this
>> issue, I will close the bug.
> 
> The writeup is genuinely excellent - still digesting it.
> 
> It looks to me like
> https://gray.gnu.org.ua/public/ltbug/0001-ltmain.in-append-rpath-option-arguments-to-finalize_.patch
> did get applied but merged into one patch so the commit message from the
> 1st one got lost. Not sure if that's worth changing.

I applied the cumulative patch that was provided, since the issues were
related. I am not opposed to reverting the commit and message that I
applied to separate each change though.

>> Also, thank you for reporting these issues again. I am sorry it was not
>> looked into sooner.
>>
>> [1]
>> https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=998a3347622014a0ecb58bdf57388b3f545e5934

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #17 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: Sam James <sam <at> gentoo.org>
To: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
Cc: Sergey Poznyakoff <gray <at> gnu.org.ua>, 71489 <at> debbugs.gnu.org
Subject: Re: bug#71489: Two libtool issues
Date: Mon, 12 Aug 2024 16:13:39 +0100

Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com> writes:

> Hi Sam,

Hi Ileana,
>
> On 09/08/2024 20:41, Sam James wrote:
>> Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com> writes:
>> 
>>> Hi Sergey,
>>>
>>> On 11/06/2024 14:20, Sergey Poznyakoff wrote:
>>>> Hello,
>>>> Some time ago I discovered two libool issues related to the library
>>>> preference, which caused lots of problems in GNU mailutils.  The issues
>>>> are described in detail in the following article:
>>>>     https://gray.gnu.org.ua/public/ltbug
>>>> (Sorry if it is too long: I tried to provide as much detail as
>>>> possible,
>>>> along with examples and proposed patches).
>>>>     I reported that to the bug-libtool list on 2019-12-14. Back then
>>>> I got a
>>>> reply which seemed to stem from misreading rather than from an attempt to
>>>> understand the problem. So I ended up distributing a patched ltmain.sh
>>>> with GNU mailutils.
>>>> Is there any chance these issues can be addressed in libtool?
>>>
>>> Thank you for your bug report and all of the detail that you provided. I
>>> have replicated your errors and created a test file based off of your
>>> testcases. It has been applied to libtool's development branch [1]. If
>>> you would verify the patch and test file are applied properly for this
>>> issue, I will close the bug.
>> The writeup is genuinely excellent - still digesting it.
>> It looks to me like
>> https://gray.gnu.org.ua/public/ltbug/0001-ltmain.in-append-rpath-option-arguments-to-finalize_.patch
>> did get applied but merged into one patch so the commit message from the
>> 1st one got lost. Not sure if that's worth changing.
>
> I applied the cumulative patch that was provided, since the issues were
> related. I am not opposed to reverting the commit and message that I
> applied to separate each change though.
>

Yeah, no problem -- completely fine with me as-is, I just wanted to
check it was intentional. Thanks again both to you but also Sergey for
the wonderful investigation. I'm pretty sure this is the cause of some
issues we've had downstream for years but never got to the bottom of.

>>> Also, thank you for reporting these issues again. I am sorry it was not
>>> looked into sooner.
>>>
>>> [1]
>>> https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=998a3347622014a0ecb58bdf57388b3f545e5934

thanks,
sam

Message #22 received at 71489-done <at> debbugs.gnu.org (full text, mbox):

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: 71489-done <at> debbugs.gnu.org
Cc: Sergey Poznyakoff <gray <at> gnu.org.ua>, Sam James <sam <at> gentoo.org>
Subject: Re: bug#71489: Two libtool issues
Date: Tue, 27 Aug 2024 18:48:03 +0300

[Message part 1 (text/plain, inline)]

I have not seen any issues with the new testcase for testing the two
libtool issues or the changes made to fix these issues. I have merged
the changes into master:
 
https://git.savannah.gnu.org/cgit/libtool.git/commit/?id=0e1b33332429cd578367bd0ad420c065d5caf0ac

For now, I am going to close this bug. Thank you again, Sergey, for
fixing and documenting these issues!

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #25 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: Sam James <sam <at> gentoo.org>
To: 71489 <at> debbugs.gnu.org
Cc: ileanadumitrescu95 <at> gmail.com, gray <at> gnu.org.ua
Subject: Re: bug#71489: Two libtool issues
Date: Tue, 27 Aug 2024 20:22:05 +0100

Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com> writes:

> I have not seen any issues with the new testcase for testing the two
> libtool issues or the changes made to fix these issues. I have merged
> the changes into master:
>  https://git.savannah.gnu.org/cgit/libtool.git/commit/?id=0e1b33332429cd578367bd0ad420c065d5caf0ac
>
> For now, I am going to close this bug. Thank you again, Sergey, for
> fixing and documenting these issues!

Ileana, would you be willing to consider a new dev release for testing
for this? While I hope it's a safe change, I think there's some benefit
to be had from distros testing it out with mass-rebuilds.

Message #28 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: Sam James <sam <at> gentoo.org>, 71489 <at> debbugs.gnu.org
Cc: gray <at> gnu.org.ua
Subject: Re: bug#71489: Two libtool issues
Date: Wed, 28 Aug 2024 17:30:57 +0300

[Message part 1 (text/plain, inline)]

On 27/08/2024 22:22, Sam James wrote:
> Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com> writes:
> 
>> I have not seen any issues with the new testcase for testing the two
>> libtool issues or the changes made to fix these issues. I have merged
>> the changes into master:
>>   https://git.savannah.gnu.org/cgit/libtool.git/commit/?id=0e1b33332429cd578367bd0ad420c065d5caf0ac
>>
>> For now, I am going to close this bug. Thank you again, Sergey, for
>> fixing and documenting these issues!
> 
> Ileana, would you be willing to consider a new dev release for testing
> for this? While I hope it's a safe change, I think there's some benefit
> to be had from distros testing it out with mass-rebuilds.

I could upload another beta release in a day or two to allow for some
additional testing before the stable release. I would like to release
the stable in the next couple of weeks though, if there are not any
major issues.

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #31 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: "Sergey Poznyakoff" <gray <at> gnu.org.ua>
To: "Ileana Dumitrescu" <ileanadumitrescu95 <at> gmail.com>
Cc: 71489 <at> debbugs.gnu.org
Subject: Re: bug#71489: Two libtool issues
Date: Wed, 28 Aug 2024 16:38:09 +0200

Hi Ileana,

My apologies for not being able to reply earlier!

Thanks a lot for taking care of this.  It works like a charm.

Best regards,
Sergey

Message #34 received at 71489 <at> debbugs.gnu.org (full text, mbox):

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: Sergey Poznyakoff <gray <at> gnu.org.ua>
Cc: 71489 <at> debbugs.gnu.org
Subject: Re: bug#71489: Two libtool issues
Date: Wed, 28 Aug 2024 18:55:17 +0300

[Message part 1 (text/plain, inline)]

Hi Sergey,

On 28/08/2024 17:38, Sergey Poznyakoff wrote:
> Hi Ileana,
> 
> My apologies for not being able to reply earlier!
> 
> Thanks a lot for taking care of this.  It works like a charm.

It took several years for this to even be addressed, so no apology
is needed! I am happy to see it is fixed :)

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.