GNU bug report logs - #71675
[PATCH] missing declaration for image_cache_refcount

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71675 in the body.
You can then email your comments to 71675 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pankaj Jangid <pankaj <at> codeisgreat.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] missing declaration for image_cache_refcount
Date: Thu, 20 Jun 2024 19:17:18 +0700

[Message part 1 (text/plain, inline)]

Tags: patch

Build was failing on macos. Perhaps this declaration was accidently
deleted in a previous commit.



In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.5.0, NS
 appkit-2487.60 Version 14.5 (Build 23F79)) of 2024-06-20 built on
 Pankajs-MacBook-Pro.local
Repository revision: 41cbfead7e2bce2f563e37a9a737a00a7b86e7f1
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2487
System Description:  macOS 14.5

[0001-missing-declaration-for-image_cache_refcount.patch (text/patch, attachment)]

Message #10 received at 71675-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Pankaj Jangid <pankaj <at> codeisgreat.org>
Cc: 71675-done <at> debbugs.gnu.org
Subject: Re: bug#71675: [PATCH] missing declaration for image_cache_refcount
Date: Thu, 20 Jun 2024 22:16:12 +0800

Pankaj Jangid <pankaj <at> codeisgreat.org> writes:

> Tags: patch
>
> Build was failing on macos. Perhaps this declaration was accidently
> deleted in a previous commit.

No, it was rendered redundant by the deletion of some hideous code,
but the NS port was not properly adjusted for the same, which was
corrected some 30 minutes ago.  Closing, thanks.

Message #13 received at 71675 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Pankaj Jangid <pankaj <at> codeisgreat.org>
Cc: 71675 <at> debbugs.gnu.org
Subject: Re: bug#71675: [PATCH] missing declaration for image_cache_refcount
Date: Thu, 20 Jun 2024 10:22:05 -0400

Pankaj Jangid <pankaj <at> codeisgreat.org> writes:

> Tags: patch
>
> Build was failing on macos. Perhaps this declaration was accidently
> deleted in a previous commit.
>
>
>
> In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.5.0, NS
>  appkit-2487.60 Version 14.5 (Build 23F79)) of 2024-06-20 built on
>  Pankajs-MacBook-Pro.local
> Repository revision: 41cbfead7e2bce2f563e37a9a737a00a7b86e7f1
> Repository branch: master
> Windowing system distributor 'Apple', version 10.3.2487
> System Description:  macOS 14.5
>
>>From f823075ef4b05fa701c570885416fc7d1f628520 Mon Sep 17 00:00:00 2001
> From: Pankaj Jangid <pankaj <at> codeisgreat.org>
> Date: Thu, 20 Jun 2024 19:12:29 +0700
> Subject: [PATCH] missing declaration for image_cache_refcount
>
> 	* (src/nsfns.m): perhaps this was accidently deleted in a
> 	previous commit
> ---
>  src/nsfns.m | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi Pankaj,

I suspect 199fcbe2d30ff021491b345decf22024913ca40f has already fixed
this, could you confirm?

Thanks

  Andrea

Message #16 received at 71675 <at> debbugs.gnu.org (full text, mbox):

From: Pankaj Jangid <pankaj <at> codeisgreat.org>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: 71675 <at> debbugs.gnu.org
Subject: Re: bug#71675: [PATCH] missing declaration for image_cache_refcount
Date: Tue, 16 Jul 2024 08:43:29 +0530

Andrea Corallo <acorallo <at> gnu.org> writes:

> I suspect 199fcbe2d30ff021491b345decf22024913ca40f has already fixed
> this, could you confirm?

Yes. This was fixed. Sorry for the delayed reply.

Message #19 received at 71675-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Pankaj Jangid <pankaj <at> codeisgreat.org>, Andrea Corallo <acorallo <at> gnu.org>
Cc: 71675-done <at> debbugs.gnu.org
Subject: Re: bug#71675: [PATCH] missing declaration for image_cache_refcount
Date: Fri, 19 Jul 2024 16:27:59 -0700

Pankaj Jangid <pankaj <at> codeisgreat.org> writes:

> Andrea Corallo <acorallo <at> gnu.org> writes:
>
>> I suspect 199fcbe2d30ff021491b345decf22024913ca40f has already fixed
>> this, could you confirm?
>
> Yes. This was fixed. Sorry for the delayed reply.

I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.