GNU bug report logs - #71695
guix-install.sh REQUIRE check for SYSV_INIT_REQUIRE

Previous Next

Package: guix;

Reported by: Nyi Nyi Zaw <nyinyizaw.nav <at> gmail.com>

Date: Fri, 21 Jun 2024 16:20:01 UTC

Severity: normal

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

To reply to this bug, email your comments to 71695 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#71695; Package guix. (Fri, 21 Jun 2024 16:20:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nyi Nyi Zaw <nyinyizaw.nav <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Fri, 21 Jun 2024 16:20:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nyi Nyi Zaw <nyinyizaw.nav <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: guix-install.sh REQUIRE check for SYSV_INIT_REQUIRE
Date: Fri, 21 Jun 2024 16:45:42 +0630
[Message part 1 (text/plain, inline)]
Cause>>

>
>   MX linux 23.3(Debian 12.5 “bookworm” base) return sysv-init as 
> lowercase with dash
>   which cause install script fails with sysv-init_REQUIRE[@]: invalid 
> variable name
>

ERROR>>

> https://www.gnu.org/software/guix/
> This script installs GNU Guix on your system
> To uninstall, pass in the '--uninstall' parameter.
> Press return to continue...
> [1718953785.295]: Starting installation (Fri Jun 21 01:39:45 PM +0630 
> 2024)
> [1718953785.306]: [ INFO ] init system is: sysv-init
> ./guix-install.sh: line 164: sysv-init_REQUIRE[@]: invalid variable name

Fix Patch >> Convert sysv-init to SYSV_INIT_REQUIRE to match with 
variable name

>   --- guix-install.sh     2024-06-21 15:22:03.000000000 +0630
>   +++ guix-install-patched.sh     2024-06-21 16:09:17.454668652 +0630
>   @@ -157,7 +157,9 @@
>
>   add_init_sys_require()
>   { # Add the elements of FOO_INIT_SYS to REQUIRE
>       -    local init_require="${INIT_SYS}_REQUIRE[@]"
>       + # Convert INIT_SYS return string to uppercase and replace dash 
> with underscore
>       +    local init_require="${INIT_SYS^^}_REQUIRE[@]"
>       + init_require="${init_require//-/_}"
> if[[ !-z "$init_require"]]; then
> # Have to add piecemeal because ${!foo[@]} performs direct array key
> # expansion, not indirect plain array expansion.


[Message part 2 (text/html, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#71695; Package guix. (Sat, 22 Jun 2024 13:13:02 GMT) Full text and rfc822 format available.

Message #8 received at 71695 <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: Nyi Nyi Zaw <nyinyizaw.nav <at> gmail.com>
Cc: 71695 <at> debbugs.gnu.org
Subject: Re: bug#71695: guix-install.sh REQUIRE check for SYSV_INIT_REQUIRE
Date: Sat, 22 Jun 2024 09:12:17 -0400
The fix looks good to me. I don't have commit access so you may want to
send it off to guix-patches so it's not lost.
(info "(guix) Submitting Patches")

If you can, please submit in plaintext. The formatting here looks odd. :)

-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.




Information forwarded to bug-guix <at> gnu.org:
bug#71695; Package guix. (Tue, 25 Feb 2025 19:44:03 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Diana Belle <garbados <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: bug#71695: guix-install.sh REQUIRE check for SYSV_INIT_REQUIRE
Date: Tue, 25 Feb 2025 08:58:49 -0800
[Message part 1 (text/plain, inline)]
Hi!

"ieure" on IRC #guix suggested I email this list to inquire about whether
this bugfix was ever merged:
https://lists.gnu.org/archive/html/bug-guix/2024-06/msg00145.html

Currently the Guix installer is broken on WSL2 systems as a result of this
bug. Applying the patch fixes it.

- Diana
[Message part 2 (text/html, inline)]

Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Fri, 28 Feb 2025 13:23:03 GMT) Full text and rfc822 format available.

Notification sent to Nyi Nyi Zaw <nyinyizaw.nav <at> gmail.com>:
bug acknowledged by developer. (Fri, 28 Feb 2025 13:23:03 GMT) Full text and rfc822 format available.

Message #16 received at 71695-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Diana Belle <garbados <at> gmail.com>
Cc: 71695-done <at> debbugs.gnu.org, Nyi Nyi Zaw <nyinyizaw.nav <at> gmail.com>
Subject: Re: bug#71695: guix-install.sh REQUIRE check for SYSV_INIT_REQUIRE
Date: Fri, 28 Feb 2025 22:21:38 +0900
Hi,

Diana Belle <garbados <at> gmail.com> writes:

> Hi!
>
> "ieure" on IRC #guix suggested I email this list to inquire about whether
> this bugfix was ever merged:
> https://lists.gnu.org/archive/html/bug-guix/2024-06/msg00145.html
>
> Currently the Guix installer is broken on WSL2 systems as a result of this
> bug. Applying the patch fixes it.

The above patch hadn't been merged; I've manually applied it now, in
commit 99bf56fd50, already pushed.

Let me know if something is still not working.

-- 
Thanks,
Maxim




This bug report was last modified 13 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.