Received: (at 71697) by debbugs.gnu.org; 18 Jul 2024 09:19:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 18 05:19:54 2024 Received: from localhost ([127.0.0.1]:36909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sUNIo-00075U-0u for submit <at> debbugs.gnu.org; Thu, 18 Jul 2024 05:19:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1sUNIm-00075F-7j for 71697 <at> debbugs.gnu.org; Thu, 18 Jul 2024 05:19:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1sUNIb-00084T-8o; Thu, 18 Jul 2024 05:19:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=7P8uD0M+xG4eX7i4sJBvMfnaQjuQFC3Nj+GHqGw8xyo=; b=DGZYWlNs7F+p/6ByhmZz uFALmGi2hWiLQOWzE4puREV2Sm7v5nOGhlndUk9tSt1Pp4qC9Ja4QNms+ozd8YJBfSArsAoDNBmTW 8hxZOnL5Q9jYfvT6s5nUmQq8QkJujaZxPND2UNplW//VMZVTCY2s3sX4X4APrvUsHHgOVFktUBDQi mylp7IxUNDwsRnTeCPLfrsg3GBubwDRTFuiq3155eKNNhsgp2WEiwWB3Ha80Hl3v4TlzzsZQzb1h7 7ySXoz/TCEXelg3dAeNoS71BmP/vhECHOKw2SjbKnAcS/mTcsixh2QUsRJp8YoqTzGSEc++oEhCHR Ag5D1pkM+EmQSQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Simon Tournier <zimon.toutoune@HIDDEN> Subject: Re: [bug#71697] [PATCH v4 1/2] scripts: lint: Add 'dry-run' option. In-Reply-To: <9971c126670cd0f49a647d538aaf206d5b963322.1720804839.git.zimon.toutoune@HIDDEN> (Simon Tournier's message of "Fri, 12 Jul 2024 19:22:12 +0200") References: <8cb162bcde91d3b39453de576caadb9a6f8f8733.1718990517.git.zimon.toutoune@HIDDEN> <9971c126670cd0f49a647d538aaf206d5b963322.1720804839.git.zimon.toutoune@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Primidi 1 Thermidor an 232 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour de =?utf-8?Q?l'=C3=89pautre?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 18 Jul 2024 11:19:38 +0200 Message-ID: <87zfqfvyz9.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71697 Cc: Josselin Poiret <dev@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, 71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>, Matthew Trzcinski <matt@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, Simon Tournier <zimon.toutoune@HIDDEN> skribis: > + (fold-packages (lambda (p r) > + (show-package-checkers p checkers) > + (when (not (assoc-ref opts 'dry-run?)) > + (run-checkers p checkers > + #:store store))) '())) I=E2=80=99d call =E2=80=98show-package-checkers=E2=80=99 only for dry runs = (like it would print =E2=80=9Cthe following checkers would run: =E2=80=A6=E2=80=9D). That said,= I find =E2=80=98--dry-run=E2=80=99 in this case not so useful because it would just print the same thing on and on for each and every package. Also, s/when not/unless/. Ludo=E2=80=99.
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 12 Jul 2024 17:23:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 12 13:23:43 2024
Received: from localhost ([127.0.0.1]:54722 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sSJzi-0007Y1-Uo
for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:43 -0400
Received: from mail-wm1-f42.google.com ([209.85.128.42]:39254)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sSJzf-0007XP-J3
for 71697 <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:40 -0400
Received: by mail-wm1-f42.google.com with SMTP id
5b1f17b1804b1-4266eae16b0so1341705e9.1
for <71697 <at> debbugs.gnu.org>; Fri, 12 Jul 2024 10:23:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1720804953; x=1721409753; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=6G8Gl3xDVEpIo8ssRUtaMYUszS5c2rsynyihTLXuuSk=;
b=hOsP3oYEPH9WyIUY2zl9uH8p5RQyHUqeOlQtksamQqXVBG+OE20PNNlRET/Mb0qoBs
AYD6DKtpK6xFwOGxvu7BMzFf5R7uQXRe/I93lJVazN7wuhMsHpma5fXcFIhzW7wNKX3F
LTQooJyqd3JuM+mQKqcl1fsZKriJtLN47xeL76GJbf8/HvW5Z9ytglrzpZBGsyGf7TUF
kHth383KJikXLlES81tx1hQkPxt28tfjSfPDur5CXKRC9tWDbbsMMp/beoBfr8qpEx4M
DTRSz1p5yU3QtIenbLKT5hHzF/kIJaj4r34Qev3Mm27xGrJl94oXhwFzEco7L/4FOS1Y
Ot3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720804953; x=1721409753;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=6G8Gl3xDVEpIo8ssRUtaMYUszS5c2rsynyihTLXuuSk=;
b=kuAazQTVVb/G4MotSMxVotrZ6oiJ4edGR3pMzJeeXHv8UXVfQNKeFCwaUPjJHi+Z1W
0zZtyg1cHH3X1pkOAUkhh8rYADUA+DbL049rRW5ionBXUj1h1LIMaBR6NY5krbdnEK8a
+OkMs0TF5tEvOjzFq8uSXfAlPY8TQknjFttYodATQOfD1IpIjVjFSlfRje9I4ZhwiMOE
myz5xUQVBlLUtSQ6CdejM4Mv7pwNjPES5L0+0LbCHXy9miibUwtPKpNXg07PDvUF/hYq
ooDOtmKz9rwwjfqLq4kTVPkL6VqUnq8yQjEd+c+WNIBl3dXtloGMctsJKMWKkXtI0Fw+
5kkg==
X-Forwarded-Encrypted: i=1;
AJvYcCU3v7RMV26r4XZVmXQ197rsgaAOjyKON76VnDnBpmxNk64kloujhqEhkLMsyAru2FNV4PN6CIzcvxPvAGW2j0VxKckPc68=
X-Gm-Message-State: AOJu0Yw4UmXSHwfNaju0jcw1Fe03yHzRwcax4uL4ufUrrrQwc/tD9YRO
gIgI/hpC59YuLdlM1cDrZOT/vT1V2jVyEESWUwLlRfvJUrUXuUTR
X-Google-Smtp-Source: AGHT+IG+RC8N2o7p6VZikU/FXs1eJkt7Cnxq/TvwJ6uqMAhRtl1aw80kjuq/Z37X+Wrzgxfslm04GA==
X-Received: by 2002:a05:600c:5125:b0:427:9f6c:e4bd with SMTP id
5b1f17b1804b1-427a1c61036mr8012685e9.6.1720804953525;
Fri, 12 Jul 2024 10:22:33 -0700 (PDT)
Received: from lili (roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr.
[194.254.61.41]) by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-4279f2c1640sm29354145e9.43.2024.07.12.10.22.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 12 Jul 2024 10:22:33 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Greg Hogan
<code@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <87h6dfbj1w.fsf@HIDDEN>
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
Date: Fri, 12 Jul 2024 19:20:08 +0200
Message-ID: <87o772eddj.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi, On Wed, 26 Jun 2024 at 15:28, Maxim Cournoyer wrote: >>
Could we not instead create a GUIX_LINT_OPTIONS,
similar to >> GUIX_BUILD_OPTIONS?
Then anyone wishing to universally exclude certain >> checkers (or disable
network checks) on their own system wou [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.128.42 listed in list.dnswl.org]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.128.42 listed in wl.mailspike.net]
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi, On Wed, 26 Jun 2024 at 15:28, Maxim Cournoyer wrote: >>
Could we not instead create a GUIX_LINT_OPTIONS, similar to >> GUIX_BUILD_OPTIONS?
Then anyone wishing to universally exclude certain >> checkers (or disable
network checks) on their own system wou [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.128.42 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.128.42 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi,
On Wed, 26 Jun 2024 at 15:28, Maxim Cournoyer <maxim.cournoyer@HIDDEN> w=
rote:
>> Could we not instead create a GUIX_LINT_OPTIONS, similar to
>> GUIX_BUILD_OPTIONS? Then anyone wishing to universally exclude certain
>> checkers (or disable network checks) on their own system would be free
>> to do so.
>
> That would be a good option to have too, on top of the other one.
Well, I am not convinced it would be helpful. Because if you have:
GUIX_LINT_EXCLUDE=3Darchival,home-page guix lint -L . foobar
is as complicated as:
guix lint -L . -x archival,home-page foobar
And if ones does:
export GUIX_LINT_EXCLUDE=3Darchival
then the checker =E2=80=99archival=E2=80=99 would be always excluded, i.e.,=
for the
third-party custom packages =E2=80=93 that=E2=80=99s what the aim :-) =E2=
=80=93 but also when
the person would contribute to Guix proper =E2=80=93 and that=E2=80=99s aga=
inst our
quality assurance, IMHO.
Somehow, from my point of view, the idea of the patch set is only to
provide a complementary mechanism of =E2=80=9C--exclude=E2=80=9D. Consider=
that I am
packaging something for Guix proper and I am bored by some checker
because it takes time, or because the warning annoys me or because it
sends again and again the exact same request to SWH or because whatever
other reasons, then I can just temporarily turn off that checker when
developing and looping over =E2=80=9Cguix lint=E2=80=9D, either via --exclu=
de or either
via the package property. Once the package is ready, I submit it with
all checkers turned on.
Obviously, a third-party channel could use this mechanism to turn off
the checkers. It=E2=80=99s up to them. :-)
Well, maybe the wording of the manual could be tweaked if it does not
capture this idea.
Cheers,
simon
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 12 Jul 2024 17:23:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 12 13:23:42 2024
Received: from localhost ([127.0.0.1]:54720 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sSJzi-0007Xv-HO
for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:42 -0400
Received: from mail-lf1-f44.google.com ([209.85.167.44]:41413)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sSJze-0007X9-2r
for 71697 <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:38 -0400
Received: by mail-lf1-f44.google.com with SMTP id
2adb3069b0e04-52e9ebb9cbaso328840e87.1
for <71697 <at> debbugs.gnu.org>; Fri, 12 Jul 2024 10:23:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1720804952; x=1721409752; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=zDO0hTECZg0vNXfbIJwW9S4W1jDPEOi0MYGFTPnXNLk=;
b=Is/Cu8XJbbX3q/uvlhfsuk4t4pQCAuyIkPoo9/v3BmqPgg82wc3BXlLJ+oGHQJ+53l
aje/ksl6+dQQIesz7ekVAE8yV7kad6gRErPChXhTq7iEJi6nmBY6m4Vp8mjtNAvnpb1b
3DuLEmFs5Me9y8PqG4BQP2r3TaXGkmmSCn3p9uBsf8pzC7diBd9uanEs53R+81dYApdA
jKhFSXMGdkhk0OzMaERGiLrIjSKjZ5NY4ndzytlXzMTdQtrHJNyxfKbBXG+WRrJdVxJB
IHnZsorVz9aa0pSlsQdDb7W0tgjMgqQpjRxF3gByVD+YTzJWsrtrzjZcxbhZIlGubYaK
dOVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720804952; x=1721409752;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=zDO0hTECZg0vNXfbIJwW9S4W1jDPEOi0MYGFTPnXNLk=;
b=wuE2m05wW4pgUjTymrKhSRLGGD99SJFkz2RheDWJoZ2TFjvYT0g6TfI/0wUXjDUOea
fIodEe3MbcMql3N4/EAjM3LNGn+naKYkRkCVp22P8Fa17MXsCeZHrhm64w60k/zIbHHD
yAjONT9DKqblLoYwq1bQ9xYvI+4N2UQDoG75vAG+A9lTFjJDklrz2WAvG2by0PoNcxhl
dWXt+bjBSA5ZEnViTF4KyGbo9td04uPAZQlTFNC6LczdeqW+rhcyBX0iarEeyF83NXsL
Ho8tAsWYgMDEpUAyAY7M7EczuREkCizzuci6e7RnKuppBNE5WojN9KSythk1WEEbYO27
qb9w==
X-Forwarded-Encrypted: i=1;
AJvYcCXRPgm8teZJcU3GP5HpBSiI0QIny7eeUL6RUUxR86+f4DRGeXL4vzFoS9/FXME2q3nroaC1mkYsHCP4OHdLjIzCAGb1xBE=
X-Gm-Message-State: AOJu0YxSMZelkszv66Z0BPbUv2vMMysPoOF3t37vg6/yC8u9bF3j7fJg
Yfzvxn5rEk++DmhSEvK+lrUP8pLN8w1LAqB0s5Rd2rovc3bc+WAG
X-Google-Smtp-Source: AGHT+IHYVCUpouZNRVAx71qymEKnObenlSZGUBxahsXWFdMXJDBhvJYchYfMDKYB9fzj0KZ5b+I/Lg==
X-Received: by 2002:a05:6512:3a83:b0:52c:a7b6:bb11 with SMTP id
2adb3069b0e04-52eb99906f7mr7945738e87.1.1720804950690;
Fri, 12 Jul 2024 10:22:30 -0700 (PDT)
Received: from lili (roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr.
[194.254.61.41]) by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-367cde8902csm10703760f8f.51.2024.07.12.10.22.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 12 Jul 2024 10:22:30 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Greg Hogan <code@HIDDEN>, Maxim Cournoyer
<maxim.cournoyer@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
<CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
Date: Fri, 12 Jul 2024 16:16:48 +0200
Message-ID: <87seweelv3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 4.1 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Greg, On Thu, 27 Jun 2024 at 12:38, Greg Hogan wrote: >
If this is the best use case for a spurious feature request then I > find
this a dangerous addition to the project.
Content analysis details: (4.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.167.44 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.167.44 listed in list.dnswl.org]
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 3.1 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Greg, On Thu, 27 Jun 2024 at 12:38, Greg Hogan wrote: >
If this is the best use case for a spurious feature request then I > find
this a dangerous addition to the project.
Content analysis details: (3.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.167.44 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.167.44 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Greg,
On Thu, 27 Jun 2024 at 12:38, Greg Hogan <code@HIDDEN> wrote:
> If this is the best use case for a spurious feature request then I
> find this a dangerous addition to the project.
Sorry, I do not see the danger. What I see is the same policy for the
project =E2=80=93 nothing is changed =E2=80=93 and the patch set provides a=
n helper for
third-party channels outside the project.
When developing or maintaining a third-party channel outside the
project, one might systematically run:
guix lint -L . -x refresh,github-urls foobar
because of some reasons of =E2=80=99foobar=E2=80=99. I do not see where it=
is dangerous
to also have the alternative to configure this exclusion at the package
level definition.
> Those denigrading and
> demanding that Guix pressure partner projects to restrict the use of
> free software are unlikely to be content adding these flags to their
> private packages as may exist.
About pressure, I will not rehash here what had been said at length
elsewhere. :-) Let me clarify about =E2=80=9Crestrict=E2=80=9D.
For sure, I agree that by definition of free software, one cannot
restrict its usage. The key point here seems between a right and an
obligation. One has the right to modify and/or share but no obligation;
it=E2=80=99s still free software. :-)
Therefore, if one uses Guix to develop packages, it=E2=80=99s up to them to
decide how they want to share their developments on free software.
However, we have the right to use these developments how we want =E2=80=93
limited by what the license allows.
All in all, I do not see the danger. :-)
Cheers,
simon
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 12 Jul 2024 17:23:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 12 13:23:38 2024
Received: from localhost ([127.0.0.1]:54716 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sSJze-0007XX-2d
for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:38 -0400
Received: from mail-wm1-f51.google.com ([209.85.128.51]:37941)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sSJzb-0007Wt-26
for 71697 <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:35 -0400
Received: by mail-wm1-f51.google.com with SMTP id
5b1f17b1804b1-426719e2efeso2911765e9.0
for <71697 <at> debbugs.gnu.org>; Fri, 12 Jul 2024 10:23:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1720804949; x=1721409749; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=/1vjyhJiZXjVYXD2kT5xwXTCFIiyXxGXc2+xyYKGizQ=;
b=iGZIiIXZJRXej3oRFHmzqw0bAbcNdl/S8dWZCtmNhCar7tJ0+M0nfeYmfaAni19VxV
1JGZK/Ka85ILfkXxm8JleqCLZeIEgOC9QP5+6uoe8xLU9j6QZtyOzDFtMIFR4kwuuM5G
cYZWJqw4r36l7iQYf/JUE5jkpITv4SI3Eby3MvOTZrQ+CoYIItdR3oXf7HosVawH4lLJ
+jiN8wsVDhsaraYKlKPrKwiNlGCIljNQNJhfmz/vSA63VRuxdD1XI50zb7rm+nVKEONQ
jNbAj1IGFPfooUbUV0dPIiQwJIH9TeGzAPj+5oC6wxp9Wr03ZVvqjGYKiH7Y1uiCchm/
qAaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720804949; x=1721409749;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=/1vjyhJiZXjVYXD2kT5xwXTCFIiyXxGXc2+xyYKGizQ=;
b=lVVSFd+fw5uHvWBH33jbIDMIYI5ZiFMrEk/NO4GH5QMUjY5xcpioZ0y9vrA2hjnWck
IlQy9C1iDN3cF56JnWs6lotgXCgTaA6V4QCZBlJf3N8TgWP/b8tFYlMVicwM6myNf586
u6DxWcE/XJh9a7AOm9lgncCSkNh9w7lA5EyReMW7XOTPWAkkT7iNVPZcyFfQ94G6vRWV
3hid0i+AsYpiRnFchIB4NDLdfpNNMnpHeBCPTUyFWPPf3t2kLEq9lQlOtB26ugEXSFaj
80A9siEgNrxkjRz5gUKg7FZwTOk+Xk/4O1DuLyQCivnttUsrPYh63w2IOQMGdJs4DrpP
7E5g==
X-Forwarded-Encrypted: i=1;
AJvYcCUbluRV6tDAXAYhapIR53cJz2PuDRUrgTfvAynPzxBPTHmPNcQwHktmF7NJdZcJRLVHdD+hGpi6ezRsNawgFHWUXCECnzM=
X-Gm-Message-State: AOJu0YwHwsXgfVJ9Io2CVJezjgDpRg+2Cj+H7zBY8pu5wcVrv1hCHQo+
y2la7jrmBonWcGTvwa9PDkdQ5jwAopnQMQxIpv1JT5A56rwglxxZ
X-Google-Smtp-Source: AGHT+IH4cpWWfEeOqH42gJuZMkf37EVsdsO0j7yljJwFAsMB9qjIWttSQqD5achGg7dMfJ4jS80/7Q==
X-Received: by 2002:a05:600c:1d1a:b0:426:6fc0:5910 with SMTP id
5b1f17b1804b1-42798312823mr36534395e9.1.1720804948850;
Fri, 12 Jul 2024 10:22:28 -0700 (PDT)
Received: from lili (roam-nat-fw-prg-194-254-61-42.net.univ-paris-diderot.fr.
[194.254.61.42]) by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-367cdfab753sm10607421f8f.107.2024.07.12.10.22.27
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 12 Jul 2024 10:22:28 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Dale Mellor <guix-devel-0brg6a@HIDDEN>, Maxim Cournoyer
<maxim.cournoyer@HIDDEN>, Greg Hogan <code@HIDDEN>,
71697 <at> debbugs.gnu.org
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <b681ec139e90c3ea30a82ae0a463618b775b52dd.camel@HIDDEN>
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
<CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
<87zfr48ms8.fsf@HIDDEN>
<b681ec139e90c3ea30a82ae0a463618b775b52dd.camel@HIDDEN>
Date: Fri, 12 Jul 2024 15:36:03 +0200
Message-ID: <875xtag2bg.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 4.1 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Dale, On Sun, 30 Jun 2024 at 15:48, Dale Mellor wrote:
> Original, original poster here (I'm feeling pretty awkward right now TBH,
like > a bad shit-stirrer). The point is that I use GUIX to support my own,
private > projects. It is nothing to do with lic [...]
Content analysis details: (4.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.128.51 listed in list.dnswl.org]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.128.51 listed in wl.mailspike.net]
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
Christopher Baines <guix@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 3.1 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Dale, On Sun, 30 Jun 2024 at 15:48, Dale Mellor wrote:
> Original, original poster here (I'm feeling pretty awkward right now TBH,
like > a bad shit-stirrer). The point is that I use GUIX to support my own,
private > projects. It is nothing to do with lic [...]
Content analysis details: (3.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.128.51 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.128.51 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Dale,
On Sun, 30 Jun 2024 at 15:48, Dale Mellor <guix-devel-0brg6a@HIDDEN> wrot=
e:
> Original, original poster here (I'm feeling pretty awkward right now TB=
H, like
> a bad shit-stirrer). The point is that I use GUIX to support my own, pri=
vate
> projects. It is nothing to do with licensing, I'm the only one who has e=
ver
> seen the code. In this context it is unacceptable that GUIX should give =
it away
> to anyone.
Well, from my understanding, the general case for packages included in
Guix proper is to run all checkers.
Then, my willing with this patch submission is to address side projects,
as you are pointing. The first answer is: it=E2=80=99s not a problem becau=
se
=E2=80=9Cguix lint=E2=80=9D offers the option =E2=80=9C--exclude=E2=80=9D. =
However, as you mentioned,
it=E2=80=99s easy to forget and=E2=80=A6 bang. Hence, the patch set as mit=
igation for
public side projects using Guix:
+ Have a --dry-run option
+ Exclude lint checkers at the package definition level
+ Still have the option --exclude option
I think, having these 3 features addresses the case of public side
projects.
Cheers,
simon
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 12 Jul 2024 17:23:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 12 13:23:34 2024
Received: from localhost ([127.0.0.1]:54713 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sSJzZ-0007XC-IL
for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:33 -0400
Received: from mail-wr1-f43.google.com ([209.85.221.43]:39954)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sSJzW-0007Wk-Oz
for 71697 <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:32 -0400
Received: by mail-wr1-f43.google.com with SMTP id
ffacd0b85a97d-3678ff89323so135917f8f.0
for <71697 <at> debbugs.gnu.org>; Fri, 12 Jul 2024 10:23:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1720804943; x=1721409743; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=2gv+7f0rQwUo/1QWLs1vGfa+kqapI6Hu14gCpNPYs6s=;
b=H02KXOJaWH52CxLZH0UTSvvmU8jCMS9pRnd2ck+ffnt6SuXrcz3plpVIWPbLm4qtUy
75uzJI4qCTNsHaMxFWJJVG/BWx5N2TmB64EQldcTmbYMMvJq8Q2yWQhPxMVXf+gZkyIH
DQMApDrsSNlVDo5Y9MSiXA/AnWb3lOUebxJu5tIitliS4v/YvJ3zl3pI3TrV4KiB32H3
mYT5z8aqk81Sf0LrypdWkhm0J7pOGfpXiYPlMGRpZhvV90Ucg3UHtX87XlTDQk8Kf5yn
N64ScYN5ek42NULhmLGX1lha62HNrIX2i5Z73IAT5OcRO+ACa2nqGVs9t+S8aCQky0fQ
yQIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720804943; x=1721409743;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=2gv+7f0rQwUo/1QWLs1vGfa+kqapI6Hu14gCpNPYs6s=;
b=VqCDcpJH8QmRj7pepvdEcT6neQZ4TDdf0IyWiYLCxGkSoGTpBrvbQx+9xeeVhEhYBe
V97cOzlgbLlPZvf1GN21oTfBKCEjpxtY1Cj/idE7Lvn7f7uaPi10Oa52imTbBhm1QGZg
wh93Eniyhm4JMJq6c2K2qa2IlH/v5caRnQgSXP7XJU3dr8r8Ju/zsJXf7a+pA0uNtYM+
Yb4/l6hfdqQF04hDgeKw6YS0AxkqsQZt4cmMZzJGr9qpfhuYLwHRFp7RcP8tzL6TZCvI
9IG4f2KoFlhwz88qCbPakqvZQSefDrj7/iNuth2k1Ipc3PqEhLqX/J/XLEz6lkzO/c7W
+8aQ==
X-Gm-Message-State: AOJu0YxrhJZT6O+kqFwkCyF8xTqRlAgokxffUWPOZ2OSw55gN+vApMUN
lYOkqDjibPX8QfN8s0wLLRV5f1oSOdJGP9ePcWA9JOj58xvLKIlQl53YEA==
X-Google-Smtp-Source: AGHT+IFsraEqibalargG9swaBvnlS0smSvRgD+zY2uFHs3+rtaCaYDP+k3hTb841YE7PeXathxW0Mw==
X-Received: by 2002:a05:600c:4450:b0:426:6358:7c5d with SMTP id
5b1f17b1804b1-4279835bcc7mr35780805e9.4.1720804943361;
Fri, 12 Jul 2024 10:22:23 -0700 (PDT)
Received: from lili.univ-paris-diderot.fr
(roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr. [194.254.61.41])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-4279f288c3fsm28943435e9.29.2024.07.12.10.22.22
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 12 Jul 2024 10:22:23 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: 71697 <at> debbugs.gnu.org
Subject: [PATCH v4 2/2] scripts: lint: Honor package property to exclude
checkers.
Date: Fri, 12 Jul 2024 19:22:13 +0200
Message-ID: <30bba4961b5652378ecdb89e3f44bb136ee77dc8.1720804839.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <9971c126670cd0f49a647d538aaf206d5b963322.1720804839.git.zimon.toutoune@HIDDEN>
References: <9971c126670cd0f49a647d538aaf206d5b963322.1720804839.git.zimon.toutoune@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71697
Cc: Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* guix/scripts/lint.scm (exclude-package-checkers): New procedure, remove the
checker if the package is marked.
(run-checkers, guix-lint): Use it.
* doc/guix.texi: Document 'lint-excluded-checkers' package property.
Change-Id: Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
---
doc/guix.texi | 16 +++++++++++++++-
guix/scripts/lint.scm | 17 ++++++++++++++---
2 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 6043962038..0558532077 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -71,7 +71,7 @@
Copyright @copyright{} 2019 Alex Griffin@*
Copyright @copyright{} 2019, 2020, 2021, 2022 Guillaume Le Vaillant@*
Copyright @copyright{} 2020 Liliana Marie Prikler@*
-Copyright @copyright{} 2019, 2020, 2021, 2022, 2023 Simon Tournier@*
+Copyright @copyright{} 2019, 2020, 2021, 2022, 2023, 2024 Simon Tournier@*
Copyright @copyright{} 2020 Wiktor Żelazny@*
Copyright @copyright{} 2020 Damien Cassou@*
Copyright @copyright{} 2020 Jakub Kądziołka@*
@@ -15448,6 +15448,20 @@ Invoking guix lint
to the new style.
@end table
+When developing a package, sometimes it is not desired to run the same
+checker each time @command{guix lint} is invoked---e.g., because the
+checker takes time or to avoid to send again and again the same request
+for archiving. Instead of excluding the checker at the command-line via
+the option @code{--exclude}, the package might be marked to skip the
+checker by honoring the property in package definition, e.g.,
+
+@lisp
+(package
+ (name "python-scikit-learn")
+ ;; @dots{}
+ (properties '((lint-excluded-checkers . (archival home-page)))))
+@end lisp
+
The general syntax is:
@example
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index 1b13d6e17f..ca1864b459 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -9,7 +9,7 @@
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@HIDDEN>
;;; Copyright © 2017, 2018 Efraim Flashner <efraim@HIDDEN>
;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@HIDDEN>
-;;; Copyright © 2019, 2020 Simon Tournier <zimon.toutoune@HIDDEN>
+;;; Copyright © 2019, 2020, 2024 Simon Tournier <zimon.toutoune@HIDDEN>
;;; Copyright © 2020 Brice Waegeneire <brice@HIDDEN>
;;;
;;; This file is part of GNU Guix.
@@ -59,6 +59,15 @@ (define (emit-warnings warnings)
name version message))))
warnings))
+(define (exclude-package-checkers package checkers)
+ "Filter the CHECKERS list using PACKAGE properties field."
+ (let* ((properties (package-properties package))
+ (excluded-checkers (or (assq-ref properties 'lint-excluded-checkers)
+ '())))
+ (remove (lambda (checker)
+ (member (lint-checker-name checker) excluded-checkers))
+ checkers)))
+
(define* (run-checkers package checkers #:key store)
"Run the given CHECKERS on PACKAGE."
(let ((tty? (isatty? (current-error-port))))
@@ -72,7 +81,8 @@ (define* (run-checkers package checkers #:key store)
(if (lint-checker-requires-store? checker)
((lint-checker-check checker) package #:store store)
((lint-checker-check checker) package))))
- checkers)
+ (exclude-package-checkers
+ package checkers))
(when tty?
(format (current-error-port) "\x1b[K")
(force-output (current-error-port)))))
@@ -228,7 +238,8 @@ (define-command (guix-lint . args)
(package-name package)
(package-version package)
(sort (map (compose symbol->string lint-checker-name)
- checkers)
+ (exclude-package-checkers
+ package checkers))
string<?)))
(call-maybe-with-store
--
2.41.0
guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 12 Jul 2024 17:23:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 12 13:23:33 2024
Received: from localhost ([127.0.0.1]:54711 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sSJzZ-0007XA-5A
for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:33 -0400
Received: from mail-lf1-f41.google.com ([209.85.167.41]:41193)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sSJzW-0007Wi-Qp
for 71697 <at> debbugs.gnu.org; Fri, 12 Jul 2024 13:23:32 -0400
Received: by mail-lf1-f41.google.com with SMTP id
2adb3069b0e04-52e98c72d2bso304875e87.0
for <71697 <at> debbugs.gnu.org>; Fri, 12 Jul 2024 10:23:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1720804943; x=1721409743; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=IRKpmqdKI7616wEYEI3Qxp7EpVoHvOeBOzJN1w6MK6Q=;
b=dUHmeBbtKt5INp1DS5meXIINQKH+lG10uUDM0vRKkyMNhHI6uPT61ESr/KUaMNoDdP
c1Qnf7ipKSCzjWc0Pyn7CgVgflDzmQOJuskdN+rEpPvh+eNp9oFvHQYkI+eooub7F+lF
1U8fEEWvfv1/jOlAJBLz4NLXrudWDPSzvSwUQTwhi+gUYlVKT1MWzKWqdCwzZAX+kMRx
ANwKTtCEDYLTbbaFQaov9vZttMxWXsKLnuQ0kUsI5ICguEuuAPXNDk7WYNH6JsjTKSs/
B2MiRVTjFgzwRABT0wNONLytQcLADtOhNyNFnel//mle36nUJGaKfnB5nkMtlClS/qxC
rR7A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720804943; x=1721409743;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=IRKpmqdKI7616wEYEI3Qxp7EpVoHvOeBOzJN1w6MK6Q=;
b=SubduXv2fPd9o50jksA9143GQvjaUVqY3mLDG0IoJFYQrVUu9fHhnIvobx+33GsgHa
inaWLplRFEyqbnKLNbHcUK3u7ZmNHea1F6bZ2M5/YqcQBbojZgfi0dJKCnNp9ypQWv6G
bTA9E772WsujTofmaMyID7jqDVJPk6Q1cIBk6zJXZSOs43R1eqgs+4RahX7UTsN4Vixx
y6yE+KJi4Xu7y41Or3vsBztoAB2fFH8xd+JPA0HCl4W0q2b+g3DLj5NJRRrvrJdXDBjw
2HjxlVRp1eRJD5qerHD7JUvWhs30/NwJVOVAst3V7YETq16yexuZ6UQq7nGUHq9KsYFt
12QQ==
X-Gm-Message-State: AOJu0YxGrgjbgt1s8hGy8wxiJnCh7OFClcLM8Ju53zMcOREyd+Lc9Pxe
Rprz1rCrwwiOOn5b/98QKE2zgWyfQVgdr5JdkAZaFC51Cdad8MZEP6hXfw==
X-Google-Smtp-Source: AGHT+IFeTejb0yxhLnJcRvHepqFFSh79ArS+nu1kSfyfCoG/JiYjaTMxP4MjKPRlGN54jVxKcogJQQ==
X-Received: by 2002:a05:6512:1597:b0:52e:be49:9d35 with SMTP id
2adb3069b0e04-52ebe499f1fmr5549603e87.4.1720804942479;
Fri, 12 Jul 2024 10:22:22 -0700 (PDT)
Received: from lili.univ-paris-diderot.fr
(roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr. [194.254.61.41])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-4279f288c3fsm28943435e9.29.2024.07.12.10.22.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 12 Jul 2024 10:22:21 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: 71697 <at> debbugs.gnu.org
Subject: [PATCH v4 1/2] scripts: lint: Add 'dry-run' option.
Date: Fri, 12 Jul 2024 19:22:12 +0200
Message-ID: <9971c126670cd0f49a647d538aaf206d5b963322.1720804839.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71697
Cc: Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* guix/scripts/lint.scm (guix-lint)[show-package-checkers]: New procedure.
(show-help, %options): Add 'dry-run' option.
* doc/guix.texi: Document it.
Change-Id: I8c96e376d52c0961ccf2ab39f1fc856c762b089d
---
doc/guix.texi | 3 +++
guix/scripts/lint.scm | 26 ++++++++++++++++++++++----
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 5b77c84b4a..6043962038 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -15463,6 +15463,9 @@ Invoking guix lint
List and describe all the available checkers that will be run on packages
and exit.
+@item --dry-run
+Do not run the checkers.
+
@item --checkers
@itemx -c
Only enable the checkers specified in a comma-separated list using the
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index ee3de51fb1..1b13d6e17f 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -100,6 +100,8 @@ (define (show-help)
(display (G_ "Usage: guix lint [OPTION]... [PACKAGE]...
Run a set of checkers on the specified package; if none is specified,
run the checkers on all packages.\n"))
+ (display (G_ "
+ --dry-run do not run checkers "))
(display (G_ "
-c, --checkers=CHECKER1,CHECKER2...
only run the specified checkers"))
@@ -154,6 +156,9 @@ (define %options
(option '(#\n "no-network") #f #f
(lambda (opt name arg result)
(alist-cons 'no-network? #t result)))
+ (option '("dry-run") #f #f
+ (lambda (opt name arg result)
+ (alist-cons 'dry-run? #t result)))
(find (lambda (option)
(member "load-path" (option-names option)))
%standard-build-options)
@@ -218,14 +223,27 @@ (define-command (guix-lint . args)
(proc store))
(proc #f)))
+ (define (show-package-checkers package checkers)
+ (format (current-error-port) "~a@~a checked by~{ ~a~}.~%"
+ (package-name package)
+ (package-version package)
+ (sort (map (compose symbol->string lint-checker-name)
+ checkers)
+ string<?)))
+
(call-maybe-with-store
(lambda (store)
(cond
((null? args)
- (fold-packages (lambda (p r) (run-checkers p checkers
- #:store store)) '()))
+ (fold-packages (lambda (p r)
+ (show-package-checkers p checkers)
+ (when (not (assoc-ref opts 'dry-run?))
+ (run-checkers p checkers
+ #:store store))) '()))
(else
(for-each (lambda (package)
- (run-checkers package checkers
- #:store store))
+ (show-package-checkers package checkers)
+ (when (not (assoc-ref opts 'dry-run?))
+ (run-checkers package checkers
+ #:store store)))
args)))))))))
base-commit: 2d6a3799fcda5c017f653c6e96b91964b07a7ee0
--
2.41.0
guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.Received: (at 71697) by debbugs.gnu.org; 5 Jul 2024 07:41:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 05 03:41:10 2024 Received: from localhost ([127.0.0.1]:43492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sPdZ8-0000VW-28 for submit <at> debbugs.gnu.org; Fri, 05 Jul 2024 03:41:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1sPdZ6-0000VJ-9p for 71697 <at> debbugs.gnu.org; Fri, 05 Jul 2024 03:41:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1sPdYw-0006a2-Dt; Fri, 05 Jul 2024 03:40:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=cWA14whghmXEFsIUzExPPJprepBij6fE9D2dpDznjaA=; b=oR1aymEAKOVh/jZh+fgq 8Yg+lGohS6BRRT8z00sAan4Gy74t/Rg0BP1+a7J6209sFdJ8F6MFpSbUGbgyjqIUO2p9o+4zvEnZ8 ZdTgjhBp2Hk3wnU3pn4OUUqs7tHH2xpUJwGchvLLNdLghy9btmmdXGe3kDhMphnRBupQ72YU2nnp+ n+Kfl2rrhELOFbnwLFqlcSveqagvNBXZn2cmikjDxefX0KMLXqK+Gt0Eu+NR86IhXMifQkwrxVX+V Lk0GYjskRoasiKxf0ctFLUj7F7c33ogTYN8Og6ORLvVQH+6mDPLepWg67NRNn35WEncsNVRhuOoj3 2MXEt+1TlGGaWA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Greg Hogan <code@HIDDEN> Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers. In-Reply-To: <CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN> (Greg Hogan's message of "Thu, 27 Jun 2024 12:38:26 -0400") References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN> <ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN> <871q4ldpgv.fsf@HIDDEN> <CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN> <87h6dfbj1w.fsf@HIDDEN> <CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 18 Messidor an 232 de la =?utf-8?Q?R=C3=A9vol?= =?utf-8?Q?ution=2C?= jour de la Gesse X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 05 Jul 2024 09:40:55 +0200 Message-ID: <8734oo70c8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71697 Cc: Josselin Poiret <dev@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, 71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>, Matthew Trzcinski <matt@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) Greg Hogan <code@HIDDEN> skribis: > On Wed, Jun 26, 2024 at 3:28=E2=80=AFPM Maxim Cournoyer > <maxim.cournoyer@HIDDEN> wrote: >> >> I don't think these exclusions should be committed in general to the >> repo, except when we have for example the author of some software >> explicitly requesting that SWH archival be disabled for it in Guix. > > Author requests are as problematic to a free software distribution as > the earlier demands to modify historical data are to reproducibility. +1 I think this would be a slippery slope. Free software is meant to be freely redistributable, unconditionally. Ludo=E2=80=99.
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 2 Jul 2024 01:40:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 01 21:40:35 2024
Received: from localhost ([127.0.0.1]:35245 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sOSVX-00077P-1g
for submit <at> debbugs.gnu.org; Mon, 01 Jul 2024 21:40:35 -0400
Received: from mail-qv1-f49.google.com ([209.85.219.49]:55720)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1sOSVU-00077C-MT
for 71697 <at> debbugs.gnu.org; Mon, 01 Jul 2024 21:40:33 -0400
Received: by mail-qv1-f49.google.com with SMTP id
6a1803df08f44-6b5031d696dso19322446d6.3
for <71697 <at> debbugs.gnu.org>; Mon, 01 Jul 2024 18:40:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719884366; x=1720489166; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=x8GYceIRPNZfqb1rbtBIVLR42EWPi61TaljIGDPP2qs=;
b=E6CXR345fzYMqIKE2VeqvKekKYPbDP2gyfxvQ16fxLvP0bALh88bzjvTgnzESABRCp
TvKjlutNK4io2sl/7DK25dlSzZEITlTOLrV5rksVyHGkwpkVNshc0RfeZT+FAtZGZmNa
f6ST/q2HEeZJ6fWP8ZEo/eoO6VXv8c9oD9PRllZ8e5w1cZ2QKkWti5ADkx8HuLLNDPO2
orYMHD+ykBzuF8qra1+Z7av1IUmDQH1stM2gRRDlt+02u91P1AwYhOZMbcThy5wRPgcu
8g9T8ey0ZYtkNfr8Lg639UMpyKXLDKo5vRgpTmKgvv0AEe53MdUCxPdvYCuMiQd9/QEF
yS1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719884366; x=1720489166;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=x8GYceIRPNZfqb1rbtBIVLR42EWPi61TaljIGDPP2qs=;
b=uvG6N4Sh7MKnpAe4Z+jy7GTWnXm3K7+au6hjHBUnpveehx/UePZnR6EjKEurc9YyuE
8vWJ7vTcUsf/Qru+vUIyDpyFj1X9N/eq3EhlNII7ZPYgAtXjmtWlmmTl8jgu/MoCCima
pkLUc8Fl//5gc7nOr1djDvgkh5pPu/ooPSnkVuY8gGzD6CxvZtgZqwJ11gHn+YGMyW4c
9ZTJ1msab0aRUToB6iK4p0aDlnetPIZEvZQzxf2vfddWLBPxjC4fFLjxsR2wTONSufu1
0dEUApWjQ3I4lxQLaIvrUBkb6ZV091JlAY9Wmei4Liyo+pL00/k685IEE2yNW4i+6XCr
2z1Q==
X-Gm-Message-State: AOJu0YzewRTpZFP8eMNWr4CC0Q0TsdtDIlDJpYvdJITAemVSuIu3oeDS
RImu51Pz/OSSzZ4eV6rHgWYXxF3dfSN2cFtkTRUW3JzRnYMswSiD
X-Google-Smtp-Source: AGHT+IGRhW2gSjC8CegQoalRVSQu7x+lxltmrReC3dYxKfpaJfCxHC8Fdg4cto/l/ugY5yWBJgouiw==
X-Received: by 2002:ad4:5c6b:0:b0:6b5:a81b:b974 with SMTP id
6a1803df08f44-6b5b704f9c0mr90894986d6.7.1719884366061;
Mon, 01 Jul 2024 18:39:26 -0700 (PDT)
Received: from hurd (dsl-159-108.b2b2c.ca. [66.158.159.108])
by smtp.gmail.com with ESMTPSA id
6a1803df08f44-6b59e5f2726sm38683436d6.85.2024.07.01.18.39.24
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 01 Jul 2024 18:39:25 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Dale Mellor <guix-devel-0brg6a@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <72a5f3c9d0523b29ed99afd5a551b411f4c0e7f5.camel@HIDDEN> (Dale
Mellor's message of "Tue, 02 Jul 2024 00:23:00 +0100")
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
<CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
<87zfr48ms8.fsf@HIDDEN>
<b681ec139e90c3ea30a82ae0a463618b775b52dd.camel@HIDDEN>
<87cynw7sgl.fsf@HIDDEN>
<72a5f3c9d0523b29ed99afd5a551b411f4c0e7f5.camel@HIDDEN>
Date: Mon, 01 Jul 2024 21:39:23 -0400
Message-ID: <878qyk7et0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Dale, Dale Mellor writes: > On Mon, 2024-07-01 at 16:44
-0400, Maxim Cournoyer wrote: >> >> OK. From my understanding, the code is
not transferred; only an archival >> request to the project URL is submitted
to SHW, and its up [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.219.49 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.49 listed in wl.mailspike.net]
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Greg Hogan <code@HIDDEN>,
Ricardo Wurmus <rekado@HIDDEN>, 71697 <at> debbugs.gnu.org,
Christopher Baines <guix@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Dale, Dale Mellor writes: > On Mon, 2024-07-01 at 16:44
-0400, Maxim Cournoyer wrote: >> >> OK. From my understanding, the code is
not transferred; only an archival >> request to the project URL is submitted
to SHW, and its up [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.219.49 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.49 listed in wl.mailspike.net]
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Dale,
Dale Mellor <guix-devel-0brg6a@HIDDEN> writes:
> On Mon, 2024-07-01 at 16:44 -0400, Maxim Cournoyer wrote:
>>=20
>> OK. From my understanding, the code is not transferred; only an archival
>> request to the project URL is submitted to SHW, and its up to SHW to
>> attempt to retrieve it (which would fail if the URL is private/protected
>> by some means).
>>=20
>> Perhaps we could have a dummy 'private' or 'non-free' license added to
>> (guix licenses), that the 'check-archival' procedure would check to skip
>> the archival request?=C2=A0 This would need to be documented (mentioning=
it's
>> not for use for packages carried in the Guix collection, but for end
>> users working on a software not meant to be distributed).
>>=20
>
> You have now brought the discussion full circle; you can pick it up at
> https://lists.gnu.org/archive/html/guix-devel/2024-06/msg00225.html.
Thanks, sorry for missing it. I like the replies from Ricardo there.
--=20
Cheers,
Maxim
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 1 Jul 2024 20:45:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 01 16:45:36 2024
Received: from localhost ([127.0.0.1]:34806 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sONu4-0002I3-Ex
for submit <at> debbugs.gnu.org; Mon, 01 Jul 2024 16:45:36 -0400
Received: from mail-qv1-f41.google.com ([209.85.219.41]:46342)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1sONu3-0002Hk-0D
for 71697 <at> debbugs.gnu.org; Mon, 01 Jul 2024 16:45:35 -0400
Received: by mail-qv1-f41.google.com with SMTP id
6a1803df08f44-6b54683f65fso17874776d6.1
for <71697 <at> debbugs.gnu.org>; Mon, 01 Jul 2024 13:45:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719866668; x=1720471468; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=EtkR94oeKvxKcXXx4XQD9hWLjAEZ7o/FSM45sB9gQwc=;
b=maFA94YORa7bQW6sTNDPHYTeCLE5e53wnB+EvYlm5RQL9lnYJODE3IX74uXIwcYNry
PiQRzvO+kjCXr2jWPdUmskqTF0y6yYb6E3du6aphd3e1BaT+77iXva2dm0fRMnbB+p1v
bEsQoFb2d5MkSndIjPVyHxQJkL5NCY2a7Qw2ibQkilb6OJL/oz2jCg998Th1qC+fXVNS
EIUOQmgzjaPmzpO5fS1muOlTXJCCYIWtH6+38kmZSl/81iHMl72Gk9JRzfRAG3SM3QOM
jr9lhQ/k0vjy+5eX2o7k6y6Oyvy8phf8ujbFkM/yDwreZi57L3G0656knk4aWC1nkcJb
pCPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719866668; x=1720471468;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=EtkR94oeKvxKcXXx4XQD9hWLjAEZ7o/FSM45sB9gQwc=;
b=eoG6waJJ0pdoA+QL9otCSX6G5hWjNOxztSwgYDqURWuyKt2GYNRzuiQlaBSb18W36x
eoiW71eUaX98um/KfZWRU1ptG/Dy7uZZJ56htWGX8s2Q/7sEuMQHm8Ip0heXtnJSdqwN
KjsK516eh08c0BwWd6GVBOh6MlQaKmes+55K8B2h6RbrQYymq9Tb+/S1cMkyXG/m9tO5
HsF8ECchKpugpImsUEBXd36Yel5fhN8dQbunSCRROMJXc56OxgzwgzEIxOkYHZFIB0JE
F0v8/0SeMR018To/9QOeloS23+c0OmyFTtdXBp00dTr4OJNORUREoxObtOqmfVAsT5qZ
WkmA==
X-Forwarded-Encrypted: i=1;
AJvYcCV30LYIiYz8BGsQgAbWup3H9m5Bm7zvle28OAwQsdkXZv2kMbtTlg1VKBPDWuEwVJESqBHyW/0m4Cj/ToabkRaq2E8BCoU=
X-Gm-Message-State: AOJu0YxKtYnXlO48DNE+KoYRg9RkOjHpetxH2RIBDs6fkcHcaJsPlumq
EBDUD1DpjvBCXVfg37RDamLKrpzEmVMiMQTm4HUO/gPzflwzh8G2
X-Google-Smtp-Source: AGHT+IGrVWqGZqCvSqluqhkyPoRK5YfNLBpj4dZgr8NqfpU/yiIl8C9d4nh+QDS1ut1m866tcq7keg==
X-Received: by 2002:a05:6214:dc1:b0:6b0:7eaf:febb with SMTP id
6a1803df08f44-6b5b713f773mr99968236d6.31.1719866668552;
Mon, 01 Jul 2024 13:44:28 -0700 (PDT)
Received: from hurd (dsl-159-108.b2b2c.ca. [66.158.159.108])
by smtp.gmail.com with ESMTPSA id
6a1803df08f44-6b5bcf1acc0sm19564086d6.44.2024.07.01.13.44.27
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 01 Jul 2024 13:44:28 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Dale Mellor <guix-devel-0brg6a@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <b681ec139e90c3ea30a82ae0a463618b775b52dd.camel@HIDDEN> (Dale
Mellor's message of "Sun, 30 Jun 2024 15:48:15 +0100")
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
<CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
<87zfr48ms8.fsf@HIDDEN>
<b681ec139e90c3ea30a82ae0a463618b775b52dd.camel@HIDDEN>
Date: Mon, 01 Jul 2024 16:44:26 -0400
Message-ID: <87cynw7sgl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Dale, Dale Mellor writes: > On Fri, 2024-06-28 at 23:12
-0400, Maxim Cournoyer wrote: >> >> While I dislike the attitude/approach
used, I think the essence of the >> complaint was that Guix, via SHW, was
somehow facilitating t [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.219.41 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.41 listed in wl.mailspike.net]
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Greg Hogan <code@HIDDEN>,
Ricardo Wurmus <rekado@HIDDEN>, 71697 <at> debbugs.gnu.org,
Christopher Baines <guix@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Dale, Dale Mellor writes: > On Fri, 2024-06-28 at 23:12
-0400, Maxim Cournoyer wrote: >> >> While I dislike the attitude/approach
used, I think the essence of the >> complaint was that Guix, via SHW, was
somehow facilitating t [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.219.41 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.41 listed in wl.mailspike.net]
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Dale,
Dale Mellor <guix-devel-0brg6a@HIDDEN> writes:
> On Fri, 2024-06-28 at 23:12 -0400, Maxim Cournoyer wrote:
>>=20
>> While I dislike the attitude/approach used, I think the essence of the
>> complaint was that Guix, via SHW, was somehow facilitating the
>> scavenging of free software sources to train large language models
>> (LLM), with the opinion that these models do not respect the licenses of
>> the sources ingested for their produced output (the work is considered
>> new work, not a derived work, or perhaps it's still legally a gray area,
>> I don't know).=C2=A0 In this perspective, the original poster was seekin=
g to
>> have the free software more protected against what they see as a loop
>> hole in the LLM business, as explained above.
>
> Original, original poster here (I'm feeling pretty awkward right now TB=
H, like
> a bad shit-stirrer). The point is that I use GUIX to support my own, pri=
vate
> projects. It is nothing to do with licensing, I'm the only one who has e=
ver
> seen the code. In this context it is unacceptable that GUIX should give =
it away
> to anyone.
OK. From my understanding, the code is not transferred; only an archival
request to the project URL is submitted to SHW, and its up to SHW to
attempt to retrieve it (which would fail if the URL is private/protected
by some means).
Perhaps we could have a dummy 'private' or 'non-free' license added to
(guix licenses), that the 'check-archival' procedure would check to skip
the archival request? This would need to be documented (mentioning it's
not for use for packages carried in the Guix collection, but for end
users working on a software not meant to be distributed).
--=20
Thanks,
Maxim
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 30 Jun 2024 14:48:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 30 10:48:27 2024
Received: from localhost ([127.0.0.1]:58661 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sNvqt-0006Ne-9s
for submit <at> debbugs.gnu.org; Sun, 30 Jun 2024 10:48:27 -0400
Received: from [195.15.247.228] (port=37203 helo=rdmp.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <guix-devel-0brg6a@HIDDEN>) id 1sNvqs-0006NP-2T
for 71697 <at> debbugs.gnu.org; Sun, 30 Jun 2024 10:48:26 -0400
Received: from [127.0.0.1] (helo=[IPv6:::1])
by rdmp.org with esmtp (Exim 4.96.1)
(envelope-from <guix-devel-0brg6a@HIDDEN>) id 1sNvqi-0007MV-18;
Sun, 30 Jun 2024 14:48:16 +0000
Message-ID: <b681ec139e90c3ea30a82ae0a463618b775b52dd.camel@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
From: Dale Mellor <guix-devel-0brg6a@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Greg Hogan
<code@HIDDEN>, 71697 <at> debbugs.gnu.org
Date: Sun, 30 Jun 2024 15:48:15 +0100
In-Reply-To: <87zfr48ms8.fsf@HIDDEN>
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
<CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
<87zfr48ms8.fsf@HIDDEN>
Organization: DM Bespoke Computer Solutions Ltd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4
MIME-Version: 1.0
X-Spam-Score: 4.3 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Fri, 2024-06-28 at 23:12 -0400, Maxim Cournoyer wrote:
> > While I dislike the attitude/approach used, I think the essence of the
> complaint was that Guix, via SHW, was somehow facilitating the > [...]
Content analysis details: (4.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
Christopher Baines <guix@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 3.3 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Fri, 2024-06-28 at 23:12 -0400, Maxim Cournoyer wrote:
> > While I dislike the attitude/approach used, I think the essence of the
> complaint was that Guix, via SHW, was somehow facilitating the > [...]
Content analysis details: (3.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
On Fri, 2024-06-28 at 23:12 -0400, Maxim Cournoyer wrote:
>=20
> While I dislike the attitude/approach used, I think the essence of the
> complaint was that Guix, via SHW, was somehow facilitating the
> scavenging of free software sources to train large language models
> (LLM), with the opinion that these models do not respect the licenses of
> the sources ingested for their produced output (the work is considered
> new work, not a derived work, or perhaps it's still legally a gray area,
> I don't know).=C2=A0 In this perspective, the original poster was seeking=
to
> have the free software more protected against what they see as a loop
> hole in the LLM business, as explained above.
Original, original poster here (I'm feeling pretty awkward right now TBH,=
like
a bad shit-stirrer). The point is that I use GUIX to support my own, priva=
te
projects. It is nothing to do with licensing, I'm the only one who has eve=
r
seen the code. In this context it is unacceptable that GUIX should give it=
away
to anyone.
Dale
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 29 Jun 2024 03:13:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 28 23:13:49 2024
Received: from localhost ([127.0.0.1]:36550 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sNOX7-0007ti-BB
for submit <at> debbugs.gnu.org; Fri, 28 Jun 2024 23:13:49 -0400
Received: from mail-qv1-f47.google.com ([209.85.219.47]:46448)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1sNOX5-0007tQ-4N
for 71697 <at> debbugs.gnu.org; Fri, 28 Jun 2024 23:13:48 -0400
Received: by mail-qv1-f47.google.com with SMTP id
6a1803df08f44-6b54683f65fso6054046d6.1
for <71697 <at> debbugs.gnu.org>; Fri, 28 Jun 2024 20:13:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719630762; x=1720235562; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=J/WcdEaIoSiFg4lh+YRprK/KZIyn7iOKspw9xdybac4=;
b=O1NZ+KnY1y8rQCGJ1GwNVCxzIFLvWvHUo1dzNP2/Kh6Bi0M8Ni6e+7t7C31wcDwzUR
BT9jxrnOcQYY3FF7Aa6xPX02qcj4mB/jHTaC4B+CH43eDF7TGXiJ/QuCT0o4bCzIOfaC
P+vhsTM/JpnxT+gLZNAK7ynjC4RTRRMMFt2Qi+2dLGxRCmyomHb4k79yJIS0OE8+q2pa
MK+VekJL5686dhymp6Z13tud2QQ2IKnryo39wWbrzrp4cF+UCaedA4DazZkWr19EJQ/B
FxWCDlH8l/JwkZLJDLv0YGncd7fN+uCsd/WMC5I/Ue/GsdNYgWfohlRnX2hPMXf8wl73
bKDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719630762; x=1720235562;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=J/WcdEaIoSiFg4lh+YRprK/KZIyn7iOKspw9xdybac4=;
b=YXtYqKUwLvECh5uSo184qugjNeWDBRPgom9BkIDxwiV9eDNuvHPtjYwt6w0mWKZH19
wSoG/8Ck8zy+6r4baZpmSkXYdBpgNSEI4hA88VsOCh7tZx8PfFjoPnyyNwMYy09yytD6
6MYQEgx08umVyqQhR2o6fx6AelsqRzGKPUQtgST+BupKkE5478jzAWHuYPv3Xaw9Ln8P
FBAxr2C57fXDqCfY43SCedGzxM3i9/mbr1OqTQFgDYRA9aZ1/wsYFJTOZP5QfaENs/Z+
VWJ+5joob0DtSQaC2Mw7i+Fna69lxpaQZ+OBuHzbGoj4oh9VOa9vSxbldvN64PJoah3o
GPCQ==
X-Forwarded-Encrypted: i=1;
AJvYcCXVAhkxdQw0t9A7ofuiU7zdR0sY6kT/atpTxUW1/zRmoWTdEitZzZuweJg8sl0HHATZAhXe3vUZLCOB48z/lSFTP0B7Pjw=
X-Gm-Message-State: AOJu0YwDL4ZQJneTJNhVAOZXMpviURES8I8QI9hTbT8iL9+hOdBRUioA
KWXo+1SSVVA4nCqj0dEmggenjZw7FCF0U8YeDAm+pUN7Py4Hcjve
X-Google-Smtp-Source: AGHT+IHXCnkpeJOKEXBWdicBqWXZIm7wwAiH3/t+u6BQfPUwfFjfayXVbUhlpwtbRJ/3P6LMh9h3Xw==
X-Received: by 2002:a05:6214:5014:b0:6b5:4335:3af0 with SMTP id
6a1803df08f44-6b5b71ee79amr927806d6.62.1719630761972;
Fri, 28 Jun 2024 20:12:41 -0700 (PDT)
Received: from hurd ([204.48.95.10]) by smtp.gmail.com with ESMTPSA id
6a1803df08f44-6b59e5f39c1sm13208446d6.97.2024.06.28.20.12.40
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 28 Jun 2024 20:12:41 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Greg Hogan <code@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
(Greg Hogan's message of "Thu, 27 Jun 2024 12:38:26 -0400")
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
<CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
Date: Fri, 28 Jun 2024 23:12:39 -0400
Message-ID: <87zfr48ms8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Greg, Greg Hogan writes: > On Wed, Jun 26, 2024 at 3:28 PM
Maxim Cournoyer > wrote: >> >> I don't think these exclusions should be committed
in general to the >> repo, except when we have for example the author of
some so [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.47 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.219.47 listed in list.dnswl.org]
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Greg, Greg Hogan writes: > On Wed, Jun 26, 2024 at 3:28 PM
Maxim Cournoyer > wrote: >> >> I don't think these exclusions should be committed
in general to the >> repo, except when we have for example the author of
some so [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.47 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.219.47 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Greg,
Greg Hogan <code@HIDDEN> writes:
> On Wed, Jun 26, 2024 at 3:28=E2=80=AFPM Maxim Cournoyer
> <maxim.cournoyer@HIDDEN> wrote:
>>
>> I don't think these exclusions should be committed in general to the
>> repo, except when we have for example the author of some software
>> explicitly requesting that SWH archival be disabled for it in Guix.
>
> Author requests are as problematic to a free software distribution as
> the earlier demands to modify historical data are to reproducibility.
>
> How do we authenticate authorship? Is it a single author, all authors,
> majority of authorship? How would the latter be measured and valued?
> Are author requests transitive? In which direction? Do the requests
> propagate to dependent packages, or must a request include author
> approval from all project dependencies? How do we handle cases where
> copyright has not been noted as carefully as in Guix? Must the request
> be made specifically to the Guix project? How do we monitor projects
> for new authors or changes to requests?
>
> We have a system for honoring author requests that resolves every
> single one of these issues: software licenses. And this is not some
> new issue, developers have been debating commercial use ("Micro$oft")
> of their work for decades, yet here we are writing free software and
> building a free Gnu/OS.
You raise good questions, for which I do not have immediate answers.
> These requests to turn free software non-free are simply the tip of
> the iceberg. We have always considered the artist (author) to be
> separate from the art (licensed software). Now we get (from the
> initiator of these demands) that "Not every political opinion should
> be respected." which is a clear contradiction of the Guix Code of
> Conduct's "Being respectful of differing opinions, viewpoints, and
> experiences". Which individuals or demographic subgroups will be next
> claimed problematic and need to have their contributions excluded?
>
>> It may also be useful e.g. for some project that really don't have a
>> home page, to avoid a spurious lint warning in this case.
>
> If this is the best use case for a spurious feature request then I
> find this a dangerous addition to the project. Those denigrading and
> demanding that Guix pressure partner projects to restrict the use of
> free software are unlikely to be content adding these flags to their
> private packages as may exist.
While I dislike the attitude/approach used, I think the essence of the
complaint was that Guix, via SHW, was somehow facilitating the
scavenging of free software sources to train large language models
(LLM), with the opinion that these models do not respect the licenses of
the sources ingested for their produced output (the work is considered
new work, not a derived work, or perhaps it's still legally a gray area,
I don't know). In this perspective, the original poster was seeking to
have the free software more protected against what they see as a loop
hole in the LLM business, as explained above.
That's an interesting legal and moral challenge/problem, but I don't
think GNU Guix is the right venue to debate it; especially not in the
way it's been attempted here.
--=20
Thanks,
Maxim
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 27 Jun 2024 16:39:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 27 12:39:48 2024
Received: from localhost ([127.0.0.1]:43263 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sMsA0-0003jv-FV
for submit <at> debbugs.gnu.org; Thu, 27 Jun 2024 12:39:48 -0400
Received: from mail-oa1-f53.google.com ([209.85.160.53]:59810)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <code@HIDDEN>) id 1sMs9z-0003ji-6q
for 71697 <at> debbugs.gnu.org; Thu, 27 Jun 2024 12:39:47 -0400
Received: by mail-oa1-f53.google.com with SMTP id
586e51a60fabf-25cc31f3716so3605786fac.3
for <71697 <at> debbugs.gnu.org>; Thu, 27 Jun 2024 09:39:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1719506318; x=1720111118;
darn=debbugs.gnu.org;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=v17d70bKw09ImaL37VIzGQUmCetR1x2DuREofsWa65M=;
b=Ud3CMN1hqd00oki5kK7iC+K2u65mPZ6XpSLUxEyfJjXnE+xWLE0Z/y/ARJSR5ZRfZ0
gdz/DIlc1nKqK9EyykmkByIZLeRC+XFEGsNN+N/Yyj2/HI+Wd4UiRdnW9l69aUVBSune
Gl5crObfrLn2pD2akFP2jsz2ZUXw6Ye7bwdegUChWVfR7yttfztCxSNPfcPraGdlXD8o
sgfGRNUAS7NW95LCRJ99qq8wNrPc3G0gjOVUhSEjBPE0+ZUKUFpGD+mhRFyL4uqK+zrK
0LtLM9OFZUCe85aWW3ZtlMyemDkt1rX7Pvrc/pQ92WuS6RAiv4nelJ8RMN1c3DWIy8kD
bm7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719506318; x=1720111118;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=v17d70bKw09ImaL37VIzGQUmCetR1x2DuREofsWa65M=;
b=EExSU/IM0gqscS2DcZ3+AmpjDFkp6kBcX6Qri+iEQDmWjZzPVxFzCvaK8mFGxf3O6s
+D+2dNWW9dbEqWWWtm2djAlYJ+M86B60hQLdMNrQuykgJxe5jagutFDEjPUgD59feXUw
1/Z/qXGsO7nxJmcgD9ECxY8RmBxIpdq5LAEGMzX3TKf6s382bbq7C2VgPBTauYRN/Fyz
G7kxn6VOa+c8IY4ln+18QIE/ojg5m6JP6KgT6ksswI5cRpYB+zddOXwL4pl50HI6YZS/
JLbR6FQVrUYyNGe04j8xNc3ipQfbS78SXH8wZR9Gn6Ihm1X6uSIMqlcHl5BB4N44gXK5
WD+g==
X-Forwarded-Encrypted: i=1;
AJvYcCXNTCO6HWCpzIzb6EtJgnMyoKPLGuwde//kh9Gr2Hvq0IAuDISenAnu/ODVjssIdWmY6GMFHes8kgBkx8Qs/TD4Zt8mr8s=
X-Gm-Message-State: AOJu0Yw/1T6vTTjq5MkIKxvYERrpD3wkJ1btm1/JLqjntCTGYbfaM5qZ
7dejt/56aulU5wunxnxNKAHuajzCDpRmEB8zlsqsNF51ISjpFLJG+QX6+cPD819yyfhyfBLLh9f
pNaZ08Fu/zbhGagoIuC+kn6q5Tl0GwOz3y2a5AA==
X-Google-Smtp-Source: AGHT+IGQNYRetYL7ixs9jCOgzWMEMYmRjNhJTDmu6BPdW6vxRH9ydrgHIM27+lLdRNmJ12dXzoxa0ZdRzOfOHA6lCYk=
X-Received: by 2002:a05:6870:e242:b0:254:ab8e:471b with SMTP id
586e51a60fabf-25d06ebefc1mr11526732fac.50.1719506318263; Thu, 27 Jun 2024
09:38:38 -0700 (PDT)
MIME-Version: 1.0
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
<87h6dfbj1w.fsf@HIDDEN>
In-Reply-To: <87h6dfbj1w.fsf@HIDDEN>
From: Greg Hogan <code@HIDDEN>
Date: Thu, 27 Jun 2024 12:38:26 -0400
Message-ID: <CA+3U0ZntOt+-gKcJ7Q_EJszY7TAgpcF6q+O_8uZAAO+3dHEuog@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property
to exclude checkers.
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Wed, Jun 26, 2024 at 3:28 PM Maxim Cournoyer <maxim.cournoyer@HIDDEN>
wrote: > > I don't think these exclusions should be committed in general
to the > repo, except when we have for example th [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 SPF_NONE SPF: sender does not publish an SPF Record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.160.53 listed in list.dnswl.org]
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.160.53 listed in wl.mailspike.net]
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
=?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Wed, Jun 26, 2024 at 3:28 PM Maxim Cournoyer <maxim.cournoyer@HIDDEN>
wrote: > > I don't think these exclusions should be committed in general
to the > repo, except when we have for example th [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.160.53 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.160.53 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 SPF_NONE SPF: sender does not publish an SPF Record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
On Wed, Jun 26, 2024 at 3:28=E2=80=AFPM Maxim Cournoyer
<maxim.cournoyer@HIDDEN> wrote:
>
> I don't think these exclusions should be committed in general to the
> repo, except when we have for example the author of some software
> explicitly requesting that SWH archival be disabled for it in Guix.
Author requests are as problematic to a free software distribution as
the earlier demands to modify historical data are to reproducibility.
How do we authenticate authorship? Is it a single author, all authors,
majority of authorship? How would the latter be measured and valued?
Are author requests transitive? In which direction? Do the requests
propagate to dependent packages, or must a request include author
approval from all project dependencies? How do we handle cases where
copyright has not been noted as carefully as in Guix? Must the request
be made specifically to the Guix project? How do we monitor projects
for new authors or changes to requests?
We have a system for honoring author requests that resolves every
single one of these issues: software licenses. And this is not some
new issue, developers have been debating commercial use ("Micro$oft")
of their work for decades, yet here we are writing free software and
building a free Gnu/OS.
These requests to turn free software non-free are simply the tip of
the iceberg. We have always considered the artist (author) to be
separate from the art (licensed software). Now we get (from the
initiator of these demands) that "Not every political opinion should
be respected." which is a clear contradiction of the Guix Code of
Conduct's "Being respectful of differing opinions, viewpoints, and
experiences". Which individuals or demographic subgroups will be next
claimed problematic and need to have their contributions excluded?
> It may also be useful e.g. for some project that really don't have a
> home page, to avoid a spurious lint warning in this case.
If this is the best use case for a spurious feature request then I
find this a dangerous addition to the project. Those denigrading and
demanding that Guix pressure partner projects to restrict the use of
free software are unlikely to be content adding these flags to their
private packages as may exist.
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 26 Jun 2024 19:29:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 26 15:29:23 2024
Received: from localhost ([127.0.0.1]:40369 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sMYKY-0007Gp-VC
for submit <at> debbugs.gnu.org; Wed, 26 Jun 2024 15:29:23 -0400
Received: from mail-qk1-f171.google.com ([209.85.222.171]:50281)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1sMYKX-0007Gc-9T
for 71697 <at> debbugs.gnu.org; Wed, 26 Jun 2024 15:29:21 -0400
Received: by mail-qk1-f171.google.com with SMTP id
af79cd13be357-79c072af217so189839685a.0
for <71697 <at> debbugs.gnu.org>; Wed, 26 Jun 2024 12:29:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719430093; x=1720034893; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=1ilDd8ltMPdXWrkPXIHq/4gVtMKVeMEjrD0CXAJZ7/o=;
b=fxHTKSX6ovYaoFzeTIfkAgvGgmLKx2IgmmBguOWsKGOKnVGub7E/cphQB0WHQ2bduQ
q3VLKMkwKqzg/jOtpzF+b7zib8mws20eWoROm+r0mpjwphbbiycpAWELAo9VfywbIMkT
VVVmWDIHRkwQiYa3URcf8tRVXJRZlf2ECh7rvCRzUycDAJLwd+2IOV9CF/rhoaDTTskI
Z+fij3uvwBKekTe4R+kq1sMa8GJ0kZUX44veO+os3SNy78EAevmT4ST29LCuszDQ1PqO
H7wYVJiqPu/FOIbV9vGcZ7vIEK3kr2+QT14PgjITONLyUCs7r+otKvToRFJ4bP1Nqob0
hRtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719430093; x=1720034893;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=1ilDd8ltMPdXWrkPXIHq/4gVtMKVeMEjrD0CXAJZ7/o=;
b=xVClY2+c6bypS8yrV0DKCcWj/51GXyuzzLJtj11vi1P8kNNS/uNkWme5r2wNoRjyBp
pJiJvFQelDRK4r1eDNaBHTds6CWmBkho/OAI8gnwWjeEAJAnqcnMvCf6ktJQSClnpGXA
s/Bds0pRXW3Eepn4tC0LJlbujYiM0zHE5BOcbA3C9j1SqeDRLg8GSvtZ+8twrBSAdivm
Bz9daKcP2rcdixcbRFIEzniT29OSUk8KhocGXzPfNqhH8iKRYJ1ycFiC+QRQW+4K2QUp
fNPB82NA1PwZfFd8Gikmf/jRZ0EZ7z62ZOCbPMn2x5hyGaxffhiY49OVwl0RAmpRuust
hGVA==
X-Forwarded-Encrypted: i=1;
AJvYcCUg/StBz7d8quj6zoYWudKo7ZeLjigxPMoKlVkvBXJOmEZ+0plBxbxq7rd80MvLxYiO6zusZdbZdyRtQDAvg8sgGlsSjDQ=
X-Gm-Message-State: AOJu0YwL7dG4dN0esmMdt9KxZq/mmdlvC3ndS6DuNEF+BfvjOnTrdqEx
f6eeC47nHEbnNBrK5qciA4MStehrpLiiiszUwe6vrKUx9jnNVAX5
X-Google-Smtp-Source: AGHT+IGlhfsakzn3MdE9T5MAvoEar23K4jf7bK1bzQqwEAO8CpGGVszvsTfD5J/TmeR0pNJnvpDGDA==
X-Received: by 2002:a05:620a:4416:b0:795:54d4:df7e with SMTP id
af79cd13be357-79be6ed69cemr1364021885a.20.1719430093179;
Wed, 26 Jun 2024 12:28:13 -0700 (PDT)
Received: from hurd ([204.48.95.10]) by smtp.gmail.com with ESMTPSA id
af79cd13be357-79bce8b0f3esm526802285a.29.2024.06.26.12.28.11
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 26 Jun 2024 12:28:12 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Greg Hogan <code@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
(Greg Hogan's message of "Tue, 25 Jun 2024 13:14:18 -0400")
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
<CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
Date: Wed, 26 Jun 2024 15:28:11 -0400
Message-ID: <87h6dfbj1w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Greg, Greg Hogan writes: > On Tue, Jun 25, 2024 at 11:15 AM
Ludovic Courtès wrote: >> >> Hi, >> >> Simon Tournier skribis: >> >> > +@lisp
>> > +(package >> > + (name "python-scikit-learn") >> > + ;; @dots{} >> >
+ (pro [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.222.171 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.222.171 listed in list.dnswl.org]
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Greg, Greg Hogan writes: > On Tue, Jun 25, 2024 at 11:15 AM
Ludovic Courtès wrote: >> >> Hi, >> >> Simon Tournier skribis: >> >> > +@lisp
>> > +(package >> > + (name "python-scikit-learn") >> > + ;; @dots{} >> >
+ (pro [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.222.171 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.222.171 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Greg,
Greg Hogan <code@HIDDEN> writes:
> On Tue, Jun 25, 2024 at 11:15=E2=80=AFAM Ludovic Court=C3=A8s <ludo@HIDDEN=
rg> wrote:
>>
>> Hi,
>>
>> Simon Tournier <zimon.toutoune@HIDDEN> skribis:
>>
>> > +@lisp
>> > +(package
>> > + (name "python-scikit-learn")
>> > + ;; @dots{}
>> > + (properties '((lint-exclude-archival? . #t)
>> > + (lint-exclude-home-page? . #t))))
>>
>> To complement Maxim=E2=80=99s review, how about:
>>
>> (properties '((lint-excluded-checkers . (archival home-page))))
>>
>> ?
>>
>> Apart from that, the idea sounds reasonable to me.
>>
>> Thanks,
>> Ludo=E2=80=99.
>
> Could we not instead create a GUIX_LINT_OPTIONS, similar to
> GUIX_BUILD_OPTIONS? Then anyone wishing to universally exclude certain
> checkers (or disable network checks) on their own system would be free
> to do so.
That would be a good option to have too, on top of the other one.
> I find the current implementation confusing since I don't believe the
> project would accept a new or modified package missing the home page
> or with archiving disabled. Stated another way, to which Guix packages
> are we adding lint exclusions?
I don't think these exclusions should be committed in general to the
repo, except when we have for example the author of some software
explicitly requesting that SWH archival be disabled for it in Guix.
It may also be useful e.g. for some project that really don't have a
home page, to avoid a spurious lint warning in this case.
--=20
Thanks,
Maxim
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.Received: (at 71697) by debbugs.gnu.org; 26 Jun 2024 08:24:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 26 04:24:55 2024 Received: from localhost ([127.0.0.1]:38311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sMNxW-00069v-V2 for submit <at> debbugs.gnu.org; Wed, 26 Jun 2024 04:24:55 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rekado@HIDDEN>) id 1sMNxS-00069i-Ae for 71697 <at> debbugs.gnu.org; Wed, 26 Jun 2024 04:24:53 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1719390285; cv=none; d=zohomail.com; s=zohoarc; b=HDprkHLRJj2p+2XJITMrQQ/VRjUdQ0iYx1ksNMHmr4mtaIUwRqbAncVvVKHtQYzTmjD0x/bOygKlP7q0o6VV7N5PwK/DOaUmh4TS/97wQOYiJwHYTEX9FLUv9pqU3t3STw072/iiOHl8Z7i0S/sjyswJFOE/9aWuBvNww6vvggw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719390285; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=pE7tvO8mDKvIrx4cvqrET+dURQ+AvA5SVs4NKZ4bXDE=; b=N/7eZYnECUqgL1c0xUqi9kRbe8JhqPW0Wug6DXNJk1HGxrc8AzAK3SDfsYdR1DJcX+ady1ocQnPshKD7FAASjbjESbGVnjNEbjUtaqYecQDlx0jGm9KVsf0efTFd6Nw3bb/utyq2t0sC+WLVEsYPD75Ga5zN+5HA7ZDF3T7Nugo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@HIDDEN; dmarc=pass header.from=<rekado@HIDDEN> DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1719390285; s=zoho; d=elephly.net; i=rekado@HIDDEN; h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=pE7tvO8mDKvIrx4cvqrET+dURQ+AvA5SVs4NKZ4bXDE=; b=KQBcAjvRFdWDJdS8OvBY+kur6YqpwQ/SoEz+D2nSw7K96ZoqncRM2a3VG6hktF/A 9hHv9iOWkHXxzGGnpkBG8kjODH4YbGJpjfq3W24iad5u/hpee7MKGG9UvMQvZeDfj2Z 9o/GfIUKeJmZj2NgoZ7N1uesIafjBCak9lWOUfHk= Received: by mx.zohomail.com with SMTPS id 1719390284402286.95407594957044; Wed, 26 Jun 2024 01:24:44 -0700 (PDT) From: Ricardo Wurmus <rekado@HIDDEN> To: Greg Hogan <code@HIDDEN> Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers. In-Reply-To: <CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN> (Greg Hogan's message of "Tue, 25 Jun 2024 13:14:18 -0400") References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN> <ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN> <871q4ldpgv.fsf@HIDDEN> <CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN> Date: Wed, 26 Jun 2024 10:24:41 +0200 Message-ID: <87a5j8xgae.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71697 Cc: 71697 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Greg Hogan <code@HIDDEN> writes: > I find the current implementation confusing since I don't believe the > project would accept a new or modified package missing the home page > or with archiving disabled. Stated another way, to which Guix packages > are we adding lint exclusions? To packages in your own channel. -- Ricardo
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 25 Jun 2024 17:15:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 25 13:15:57 2024
Received: from localhost ([127.0.0.1]:37631 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sM9lq-0001Ov-QT
for submit <at> debbugs.gnu.org; Tue, 25 Jun 2024 13:15:57 -0400
Received: from mail-ot1-f45.google.com ([209.85.210.45]:49316)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <code@HIDDEN>) id 1sM9lh-0001OR-Aq
for 71697 <at> debbugs.gnu.org; Tue, 25 Jun 2024 13:15:52 -0400
Received: by mail-ot1-f45.google.com with SMTP id
46e09a7af769-6f97a4c4588so3334099a34.2
for <71697 <at> debbugs.gnu.org>; Tue, 25 Jun 2024 10:15:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1719335670; x=1719940470;
darn=debbugs.gnu.org;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=qV2PU+zW+401Ia9BfAuQ4XhYxaWYs4WyBkXc31Gwvow=;
b=CMGKEG6H2jqsVTcwGYiTNOqdC39veS+pOahfhTR9ITf8IDgv/Di9w2luGt/WcOvahi
Iq89abvMM146Zar9MUhr7AOxeufwo37mNQLdWNxUyY6himwZSvY2Cb4bMRbfPY1Wz8Hj
tHK1nHZoCMHQtcaVCb68fiAnC3GM0sG/IsQSYnOCh6jLhT7Gf0RNtFAzp3jCpUBmCaKI
lVSR7UroSh6e2CWqqlYVZ60K6znK5y5EIGem5qI24bHpDsJ+vcwmcOlQtfwDzmVsX+/G
axAFdGSWMrCUFKvDbgBwGP5VbDZtdHbQNUMRoUbnu6enaswFlz1lPkjAZggs1BEvzm3c
OcFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719335671; x=1719940471;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=qV2PU+zW+401Ia9BfAuQ4XhYxaWYs4WyBkXc31Gwvow=;
b=m5afoljvRU4AOOgrySye32EyjgCiKH5yBIj3KCCZcnpgY2t0bECs5Zrpn15bGacSsS
z6Lr+OH4HsQKznzz41m6KbSag/0YX488rHZdIBIVVQX8V5rljLnX6+RFhuJSUI5K8lBW
UXiCLkumj/hn3tJNTnkL2GuOITWfrz6V8FqIqGnOUF2G9sA82gP9iGFdPj8ZRBhXQdIx
BTRtUWNzvzAC7MB0dZ/jPGigyyBoud/bFudXdmjSf95PW5+tPZYbWk4ccstQmEBgZoZ8
PVRsd0zuMbNLE6qBCMRHiHIH7xcQVyObWQwmA9eqwGBieK9AxYW5MFKwJbH932npC1D8
pUxQ==
X-Forwarded-Encrypted: i=1;
AJvYcCWXwwQMoM7nwD5lxOifZZrSw07AsxziwHlQlDSUFR1z0fi+JTC5U2xGUnTjcL50k+WOwrMSJzPJ5K1p3D1HSVgbh+9Znu0=
X-Gm-Message-State: AOJu0Yx0sMD8H8Tw6zpaeeUyi8Mr9cKRnit5k81IjHcwH/05584q/6y7
sBixPrcDRDTMqGK4ESj96z6A8LA4QgA6hQV0Xd3f/yU2JHZgw1T5/8ff9epry8e3pDzMsTbmOaD
MtIjDgA9zIL1ergUGEfaIAgrVKuntZNWx/znFTg==
X-Google-Smtp-Source: AGHT+IGnL8LjZrLwp0lhyUuAN0mymq0hLI/99wfwLpmNZ7GqLK25mxzypAHFAXOBMZ2SjxTJNaEGWUbje6vzH5tP0Hk=
X-Received: by 2002:a05:6830:18ee:b0:6f9:916e:517f with SMTP id
46e09a7af769-700afa09a0amr9683570a34.28.1719335670609; Tue, 25 Jun 2024
10:14:30 -0700 (PDT)
MIME-Version: 1.0
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
<871q4ldpgv.fsf@HIDDEN>
In-Reply-To: <871q4ldpgv.fsf@HIDDEN>
From: Greg Hogan <code@HIDDEN>
Date: Tue, 25 Jun 2024 13:14:18 -0400
Message-ID: <CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property
to exclude checkers.
To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Tue, Jun 25, 2024 at 11:15 AM Ludovic Courtès <ludo@HIDDEN>
wrote: > > Hi, > > Simon Tournier <zimon.toutoune@HIDDEN> skribis: > >
> +@lisp > > +(package > > + (name "python-scikit-learn") > [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 SPF_NONE SPF: sender does not publish an SPF Record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.210.45 listed in wl.mailspike.net]
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Tue, Jun 25, 2024 at 11:15 AM Ludovic Courtès <ludo@HIDDEN>
wrote: > > Hi, > > Simon Tournier <zimon.toutoune@HIDDEN> skribis: > >
> +@lisp > > +(package > > + (name "python-scikit-learn") > [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.210.45 listed in wl.mailspike.net]
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 SPF_NONE SPF: sender does not publish an SPF Record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.210.45 listed in list.dnswl.org]
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
On Tue, Jun 25, 2024 at 11:15=E2=80=AFAM Ludovic Court=C3=A8s <ludo@HIDDEN=
> wrote:
>
> Hi,
>
> Simon Tournier <zimon.toutoune@HIDDEN> skribis:
>
> > +@lisp
> > +(package
> > + (name "python-scikit-learn")
> > + ;; @dots{}
> > + (properties '((lint-exclude-archival? . #t)
> > + (lint-exclude-home-page? . #t))))
>
> To complement Maxim=E2=80=99s review, how about:
>
> (properties '((lint-excluded-checkers . (archival home-page))))
>
> ?
>
> Apart from that, the idea sounds reasonable to me.
>
> Thanks,
> Ludo=E2=80=99.
Could we not instead create a GUIX_LINT_OPTIONS, similar to
GUIX_BUILD_OPTIONS? Then anyone wishing to universally exclude certain
checkers (or disable network checks) on their own system would be free
to do so.
I find the current implementation confusing since I don't believe the
project would accept a new or modified package missing the home page
or with archiving disabled. Stated another way, to which Guix packages
are we adding lint exclusions?
Greg
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 25 Jun 2024 15:14:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 25 11:14:44 2024
Received: from localhost ([127.0.0.1]:37559 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sM7sa-0006x2-B5
for submit <at> debbugs.gnu.org; Tue, 25 Jun 2024 11:14:44 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40006)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1sM7sV-0006wl-L4
for 71697 <at> debbugs.gnu.org; Tue, 25 Jun 2024 11:14:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1sM7sJ-0007yj-UX; Tue, 25 Jun 2024 11:14:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
From; bh=JST2Tch4Z0TZMd5GdQEElQEioZ40af1PXgmZJZFejf4=; b=N1sYxTN03p23SAzWkMH6
4JKdkZ0VoYWloMwQEsmF0DRIYTRjxoPjOq/fdOBPlKWnaE6XsPhUE/Ctl2rnYQsxbOlw1skIhf3sp
wgN1iXAwJVlxPVYm5dEkQLNt5TJUjFhXTPrBh62ytg3/Cbpu0IREYC3cZrRKuGXXcTe3iQk7B0gbR
9189trf9MeMHXB3hOkpnvUHutK5WXFHBo/ZNV4Z66NIN+KghDJb88HKqj5DcTSbthg8BMpRr8RBHW
+AKf+ExcvoWGJPV5lMa1FWSc7WKf6SVt7BrKHnyfpi+LwoI6oIUapCG9/H0gJx1UTW7JcRVbBsJZN
3FJIbU56KNjJ3w==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
(Simon Tournier's message of "Sat, 22 Jun 2024 17:27:08 +0200")
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Octidi 8 Messidor an 232 de la =?utf-8?Q?R=C3=A9volu?=
=?utf-8?Q?tion=2C?= jour de =?utf-8?Q?l'=C3=89chalotte?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Tue, 25 Jun 2024 17:14:24 +0200
Message-ID: <871q4ldpgv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Mathieu Othacehe <othacehe@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Simon Tournier <zimon.toutoune@HIDDEN> skribis:
> +@lisp
> +(package
> + (name "python-scikit-learn")
> + ;; @dots{}
> + (properties '((lint-exclude-archival? . #t)
> + (lint-exclude-home-page? . #t))))
To complement Maxim=E2=80=99s review, how about:
(properties '((lint-excluded-checkers . (archival home-page))))
?
Apart from that, the idea sounds reasonable to me.
Thanks,
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 24 Jun 2024 08:22:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 24 04:22:24 2024
Received: from localhost ([127.0.0.1]:45897 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sLexz-0003Uf-QD
for submit <at> debbugs.gnu.org; Mon, 24 Jun 2024 04:22:24 -0400
Received: from mail.webarch.email ([81.95.52.48]:35304)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <email@HIDDEN>) id 1sLexx-0003UU-F4
for 71697 <at> debbugs.gnu.org; Mon, 24 Jun 2024 04:22:22 -0400
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)
with ESMTPSA id AB9D71A83240; Mon, 24 Jun 2024 09:21:58 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msavoritias.me;
s=20210930; t=1719217337;
h=from:subject:date:message-id:to:cc:mime-version:content-type:
content-transfer-encoding:in-reply-to:references;
bh=owkRwxTP1twuBifQVRDQSSrovkgEm7lA3TMM7b+PpZA=;
b=Bgn1Rj4RvNvHdJgrj62+6EUGzuZWxV14Z8cueXw7LwgBwXgwpz6RYZ28T8ELo8lELJI+Bf
T6rbudxVWUjRD8pz+0SGgULs+eGGiNxWzZMUicfwwa3Vr0nmm69PzuAknAuAc0AfLhmtS/
EQyqTPk+2x7gnSUop5jr+5c8ErX+BcwsJ4sIGegodlRlHWaEuNMJAdFF7es2S9Megtmewf
Dys2k7C3r8/EEaIopfnR3I/0OC4pvGSIy5jOCLSZXkKLF25abIPD6AumYVgywl8uVabv6m
CuEPxWZcIjnzxjQsYTZkCfWRyuNbM99nj33PzdwXFwnxHGLydm7qGC2/CdV+Rw==
Date: Mon, 24 Jun 2024 11:21:51 +0300
From: MSavoritias <email@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: [bug#71697] [PATCH v2] guix: scripts: lint: Honor package
property to exclude chercker.
Message-ID: <20240624112151.706cac24@HIDDEN>
In-Reply-To: <878qyxugsn.fsf@HIDDEN>
References: <8cb162bcde91d3b39453de576caadb9a6f8f8733.1718990517.git.zimon.toutoune@HIDDEN>
<4e0382d4b36b12d59774d23e0e9177889e2398f2.1718994792.git.zimon.toutoune@HIDDEN>
<20240622172919.2709d7c3@HIDDEN> <878qyxugsn.fsf@HIDDEN>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.41; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Last-TLS-Session-Version: TLSv1.3
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Sat,
22 Jun 2024 17:40:40 +0200 Simon Tournier <zimon.toutoune@HIDDEN>
wrote: > Hi, > > On Sat, 22 Jun 2024 at 17:29,
MSavoritias <email@HIDDEN>
wrote: > > > Because as it currently stands this patch doesn't account for:
> > - people who dont have channels but run guix [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
MSavoritias <email@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Sat, 22 Jun 2024 17:40:40 +0200 Simon Tournier <zimon.toutoune@HIDDEN>
wrote: > Hi, > > On Sat, 22 Jun 2024 at 17:29, MSavoritias <email@HIDDEN>
wrote: > > > Because as it currently stands this patch doesn't account for:
> > - people who dont have channels but run guix [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
On Sat, 22 Jun 2024 17:40:40 +0200
Simon Tournier <zimon.toutoune@HIDDEN> wrote:
> Hi,
>=20
> On Sat, 22 Jun 2024 at 17:29, MSavoritias <email@HIDDEN> wrote:
>=20
> > Because as it currently stands this patch doesn't account for:
> > - people who dont have channels but run guix lint =20
>=20
> You misread: there is no channel involved.
>=20
> Considering this patch, if an user does not want to run *any* checker
> for whatever reason, then this user has at hand two means:
>=20
> + guix lint --exclude
> + rely on the =E2=80=99properties=E2=80=99 field directly in package def=
inition
>=20
>=20
> > - people who may not read the manual and have their code sent to SWH ev=
en tho they didnt intent it =20
>=20
> Considering this patch, all the checkers for each package are clearly
> displayed.
>=20
> And this patch adds also the option =E2=80=99--dry-run=E2=80=99. Therefo=
re, if one does
> not want to read the manual, that=E2=80=99s a good mitigation.
>=20
> Cheers,
> simon
Ah okay. That sounds like a good first step then.
MSavoritias
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.Received: (at 71697) by debbugs.gnu.org; 23 Jun 2024 23:55:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 23 19:55:27 2024 Received: from localhost ([127.0.0.1]:57291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sLX3P-0001cV-CY for submit <at> debbugs.gnu.org; Sun, 23 Jun 2024 19:55:27 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:54713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1sLX3N-0001cC-Fg for 71697 <at> debbugs.gnu.org; Sun, 23 Jun 2024 19:55:25 -0400 Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3d229baccc4so1985505b6e.1 for <71697 <at> debbugs.gnu.org>; Sun, 23 Jun 2024 16:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719186859; x=1719791659; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=enaHUDBRjHlmY1MU6chkSnuE19P6aMs7z9nc4D+cvFU=; b=TWhX8QNB5wIbq+u3ploQWXg9kYexBSpO4QRx1xncda7wAxf3NX5c0GOIB/T0AsPZbE bTJPHkqEBKktBYGCbu2Sfp8PfmGUzUTMxRX3EhEsBPdHFyWoEBuV8uwqoIxJUCMuroAD MG3K0t7C3e/ikDWymieO30TJaom+g05yGqXSNdupo1XmbHVN13CuO1J/rIsTvFpUKCda GWsSb1ZqhBpzOBNo8ELGUnEbk56RZIi1onGdxwXM/umZRugXbmWfaiVyD3zaySbTeIpx 5DEYtWXs5AnnyWgwibeuRtSwC0AI2btlC2tJhsgD7h8A/D3mX9xLHK6ac54XnFcWmae2 TfmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719186859; x=1719791659; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=enaHUDBRjHlmY1MU6chkSnuE19P6aMs7z9nc4D+cvFU=; b=rc9EjaJBJ7iX6V5jCR2CmvT4MfASevwaz6RxTrdrSHjxW8C1Cb4o6orO9UoEjxZ0LD MPecT3hESHJO+nrOA64DMgk5mQCMNiGh7Py+MagXSzv87t9dqCiaavllHp2jVzA5Ol6a lHZhOLBCdg57gspk9hdKv2x60XoesE9Bkgu07ceHf7J2ZG6rIRsh9vy+7olecuTk0QcA 6T+b08haiCxHGyKYude3VCKYgh8sNL2NNDixWH9o2+vedFCoByTIGWUCFmdqku5poNaa KXGPnk6ewbJnXSOkvY4Od2KaClortXzBNd4GJ7Zh1YX7RL08FLqjMyIMjwhL/nDbfugD XB1w== X-Gm-Message-State: AOJu0YxhlJCq/J8r38L8gu/Y9QIAUIZH7peaxlKRNvJ8FYXs7uyQIkWD taClwEezzVvthfgm6yyiEf3nr3OtiTt4y7apr7e1580iwCnMFvvTDpA4gMCU X-Google-Smtp-Source: AGHT+IEoBWwB6lFkHKdQhytrb5/PrI9kuAIDoVNChdApJ/GIjXM2GdH5hKA169L5r29UzM1UwqPbJg== X-Received: by 2002:a05:6808:210a:b0:3d2:1790:612e with SMTP id 5614622812f47-3d54594d988mr3469826b6e.5.1719186858852; Sun, 23 Jun 2024 16:54:18 -0700 (PDT) Received: from hurd (dsl-205-233-124-241.b2b2c.ca. [205.233.124.241]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-444c2c3c334sm36080801cf.60.2024.06.23.16.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 16:54:18 -0700 (PDT) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Simon Tournier <zimon.toutoune@HIDDEN> Subject: Re: [bug#71697] [PATCH v3 1/2] scripts: lint: Add 'dry-run' option. In-Reply-To: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN> (Simon Tournier's message of "Sat, 22 Jun 2024 17:27:07 +0200") References: <8cb162bcde91d3b39453de576caadb9a6f8f8733.1718990517.git.zimon.toutoune@HIDDEN> <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN> Date: Sun, 23 Jun 2024 19:54:16 -0400 Message-ID: <877cefb4gn.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71697 Cc: Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, 71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>, Matthew Trzcinski <matt@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, Simon Tournier <zimon.toutoune@HIDDEN> writes: > * guix/scripts/lint.scm (show-help, %options): Add 'dry-run' option. > (guix-lint): Use it. > * doc/guix.texi: Document it. > > Change-Id: I8c96e376d52c0961ccf2ab39f1fc856c762b089d > --- > doc/guix.texi | 3 +++ > guix/scripts/lint.scm | 16 ++++++++++++---- > 2 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 769ca1399f..037b1a2f24 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -15459,6 +15459,9 @@ Invoking guix lint > List and describe all the available checkers that will be run on packages > and exit. > > +@item --dry-run > +Do not run the checkers. Does it print which checkers would run? Otherwise I don't see the usefulness. -- Thanks, Maxim
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 23 Jun 2024 23:52:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 23 19:52:45 2024
Received: from localhost ([127.0.0.1]:57220 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sLX0m-0001XH-Kb
for submit <at> debbugs.gnu.org; Sun, 23 Jun 2024 19:52:45 -0400
Received: from mail-ot1-f41.google.com ([209.85.210.41]:44181)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1sLX0k-0001X0-Be
for 71697 <at> debbugs.gnu.org; Sun, 23 Jun 2024 19:52:43 -0400
Received: by mail-ot1-f41.google.com with SMTP id
46e09a7af769-6f9a4f9923aso2172756a34.0
for <71697 <at> debbugs.gnu.org>; Sun, 23 Jun 2024 16:52:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719186696; x=1719791496; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=JW9UIF6XKk/xhKo3HJme4+lReq5a+ff/nGdCRvQWiHk=;
b=ctSaylqARNqaM5x3nJC9M8/09IQW+LObsouYIcPWnu8IyRT+sQ+Z8AvsgPFeIsC8W7
Rx53VriWnV0ZNK3+lL2Es+Zed5vnsvDGD03d5LtREgJpAsPntj8t31JiniSPtaADa87a
ITiQ5j0mjKL5htTEwFh7s85yQwmFmtivf6KzPFt1SeMJLOc9a9iNVNlPI3hA/928MY7y
A7dcNGi71iYD8HExfHW6xT5Xn36STgV1NrYwjpPFBOwethihIA2LN6n4sW9im1ftsStK
jsqftS1SUeXcP82EOHyjSCpCI/Pps2QQP1wxkeQIFVuXeSZWYTZl8cBq/EQjVvut2FxB
7MHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719186696; x=1719791496;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=JW9UIF6XKk/xhKo3HJme4+lReq5a+ff/nGdCRvQWiHk=;
b=SFbj9ILVFPqwoVML1WzDQYnkpH+MUMQKOijdGhiZBeOiXOktba6qmlB1QWB339WGCP
MQy/tYHVz0E6t2uUCzFS3ybs4B4hpLJqi5jnYAj9GPr2BUniEWBeT9EBr1XnuQGV+/Zi
dbg7ohAS5h1IdiuT2K4b5wWd2RP6GCDCsHpYpSizdLHoBXp4TW2EdxIzbF7vOkrdwgXZ
ImRoPcLVpCs1JZWPryiqLWV9F+ZT/0yVdUfu9UhjFL1c/G01mRsj3Gb5KOc/+OiZZFFy
o2xNSHIazHAcGyOYEt0Gfg4J8WGjXaDI8wn62TjuRsTPsAEaRdDvdPAB90uwxn2j9KpY
Ju7A==
X-Gm-Message-State: AOJu0YxP+l6Tw3svWRl0vNWHpHhFHA/UsJ6SIq9xOnetmbJRiYXQ7/wF
6cr5YtAN0XgbU9RF0UqGVi8/Hw/yheQJgmnxTb4GsTCpfQ+wq7aA
X-Google-Smtp-Source: AGHT+IHVUPVIGDi5atuOtLUOTjIU5VJ7T9rgGY93dIokweasFWLiDPuOwogevCkMSl42+EnvHV/Wuw==
X-Received: by 2002:a9d:7387:0:b0:6fa:128a:5582 with SMTP id
46e09a7af769-700ac4be336mr4331407a34.13.1719186695849;
Sun, 23 Jun 2024 16:51:35 -0700 (PDT)
Received: from hurd (dsl-205-233-124-241.b2b2c.ca. [205.233.124.241])
by smtp.gmail.com with ESMTPSA id
d75a77b69052e-444c2ba6b39sm35948311cf.55.2024.06.23.16.51.34
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 23 Jun 2024 16:51:34 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package
property to exclude checkers.
In-Reply-To: <ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
(Simon Tournier's message of "Sat, 22 Jun 2024 17:27:08 +0200")
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
<ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
Date: Sun, 23 Jun 2024 19:51:33 -0400
Message-ID: <87bk3rb4l6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Simon,
Simon Tournier <zimon.toutoune@HIDDEN> writes:
> * guix/scripts/lint.scm (exclude-package-checkers): New procedure, filter=
the
> checker if the package is marked.
> (guix-lint)[show-package-checkers]: New procedure.
> * doc/guix.texi: Document it.
>
> Change-Id: Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
> ---
> doc/guix.texi | 17 ++++++++++++++++-
> guix/scripts/lint.scm | 26 +++++++++++++++++++++++++-
> 2 files changed, 41 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 037b1a2f24..1baf3fafe6 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -71,7 +71,7 @@
> Copyright @copyright{} 2019 Alex Griffin@*
> Copyright @copyright{} 2019, 2020, 2021, 2022 Guillaume Le Vaillant@*
> Copyright @copyright{} 2020 Liliana Marie Prikler@*
> -Copyright @copyright{} 2019, 2020, 2021, 2022, 2023 Simon Tournier@*
> +Copyright @copyright{} 2019, 2020, 2021, 2022, 2023, 2024 Simon Tournier=
@*
> Copyright @copyright{} 2020 Wiktor =C5=BBelazny@*
> Copyright @copyright{} 2020 Damien Cassou@*
> Copyright @copyright{} 2020 Jakub K=C4=85dzio=C5=82ka@*
> @@ -15444,6 +15444,21 @@ Invoking guix lint
> to the new style.
> @end table
>
> +Sometimes it is not desired to run the same checker each time
> +@command{guix lint} is invoked---e.g., because the checker takes time or
> +to avoid to send again and again the same request for archiving.
The rationale sounds odd in the context of creating Guix packages for
Guix -- I wouldn't want someone to start adding random lint exclusions
to package properties because some check "takes time". I think it'd be
better to give as an example which problem the mechanism was created
for, which is, to opt out of the Software Heritage archival requests.
From there the text could mention that the mechanism is general can be
used to disable other lint checks as well, such as the home page check.
> +Instead of excluding the checker at the command-line via the option
> +@code{--exclude}, the package might be marked to skip the checker by
> +honoring the property in package definition, e.g.,
> +
> +@lisp
> +(package
> + (name "python-scikit-learn")
> + ;; @dots{}
> + (properties '((lint-exclude-archival? . #t)
> + (lint-exclude-home-page? . #t))))
> +@end lisp
> +
> The general syntax is:
>
> @example
> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
> index b98266c831..7aed467eae 100644
> --- a/guix/scripts/lint.scm
> +++ b/guix/scripts/lint.scm
> @@ -9,7 +9,7 @@
> ;;; Copyright =C2=A9 2017 Tobias Geerinckx-Rice <me@HIDDEN>
> ;;; Copyright =C2=A9 2017, 2018 Efraim Flashner <efraim@HIDDEN>
> ;;; Copyright =C2=A9 2018, 2019 Arun Isaac <arunisaac@HIDDEN>
> -;;; Copyright =C2=A9 2019, 2020 Simon Tournier <zimon.toutoune@HIDDEN>
> +;;; Copyright =C2=A9 2019, 2020, 2024 Simon Tournier <zimon.toutoune@gma=
il.com>
> ;;; Copyright =C2=A9 2020 Brice Waegeneire <brice@HIDDEN>
> ;;;
> ;;; This file is part of GNU Guix.
> @@ -39,6 +39,7 @@ (define-module (guix scripts lint)
> #:use-module (ice-9 format)
> #:use-module (srfi srfi-1)
> #:use-module (srfi srfi-37)
> + #:use-module (srfi srfi-26)
> #:export (guix-lint
> run-checkers))
>
> @@ -59,6 +60,18 @@ (define (emit-warnings warnings)
> name version message))))
> warnings))
>
> +(define (exclude-package-checkers package checkers)
> + "Filter the CHECKERS list using PACKAGE properties field."
> + (let ((properties (package-properties package)))
> + (filter (lambda (checker)
> + (not (assq-ref properties
> + ((compose string->symbol
> + (cut string-append "lint-exclude-=
" <> "?")
> + symbol->string
> + lint-checker-name)
> + checker))))
> + checkers)))
Instead of using filter + a negated test, I'd use 'remove' (from SRFI
1).
> (define* (run-checkers package checkers #:key store)
> "Run the given CHECKERS on PACKAGE."
> (let ((tty? (isatty? (current-error-port))))
> @@ -223,16 +236,27 @@ (define-command (guix-lint . args)
> (proc store))
> (proc #f)))
>
> + (define (show-package-checkers package checkers)
> + (format (current-error-port) "~a@~a checked by~{ ~a~}.~%"
> + (package-name package)
> + (package-version package)
> + (sort (map (compose symbol->string lint-checker-name)
> + (exclude-package-checkers
> + package checkers))
> + string<?)))
> +
> (call-maybe-with-store
> (lambda (store)
> (cond
> ((null? args)
> (fold-packages (lambda (p r)
> + (show-package-checkers p checkers)
> (when (not (assoc-ref opts 'dry-run?))
> (run-checkers p checkers
> #:store store))) '()))
> (else
> (for-each (lambda (package)
> + (show-package-checkers package checkers)
> (when (not (assoc-ref opts 'dry-run?))
> (run-checkers package checkers
> #:store store)))
I haven't tried it, but this looks reasonable to me.
--=20
Thanks,
Maxim
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 22 Jun 2024 16:23:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 22 12:23:48 2024
Received: from localhost ([127.0.0.1]:51546 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sL3Wm-0003EH-BV
for submit <at> debbugs.gnu.org; Sat, 22 Jun 2024 12:23:48 -0400
Received: from mail-lf1-f41.google.com ([209.85.167.41]:40359)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sL3Wh-0003Di-CR
for 71697 <at> debbugs.gnu.org; Sat, 22 Jun 2024 12:23:43 -0400
Received: by mail-lf1-f41.google.com with SMTP id
2adb3069b0e04-52ca9e52d5dso415367e87.1
for <71697 <at> debbugs.gnu.org>; Sat, 22 Jun 2024 09:23:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719073358; x=1719678158; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=JimjZUgcy5JIqiIdRsKvpNGLH2YzIMiDs7nx2Ke6X4o=;
b=TZueEI57QBL21UdaKHj7RoS/4kggS+yxkzNsWDvM9MVWokSjniUSJyqfqq/qPQZ63p
INCtyDroWyYamy7fcGCzgFZXzB1RBBCB98pgTBbZjGUDnxC+nG5t66/Vo48ZbgMUx7nn
MnhZU4n9HD6lMX2uSU0PVL74OLl7RSa6OQP13/Uq3r62zRVnuw0IAgT4/KtP4YzRVKCC
4g/SPHgukq/DyLxwkleZVqAqnrqfIYEPsggk+4+dMyqJ2PINnwBkOVV6leeYMvANoG/N
y19Hckr+1wpPNg+v/99OtMy8nN5q/GZFIUK2a0d6O4RG+2y2JUbVaNa1e3X0YrKtaral
ezbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719073358; x=1719678158;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=JimjZUgcy5JIqiIdRsKvpNGLH2YzIMiDs7nx2Ke6X4o=;
b=AZIFqigNTU1cUN7nRWusUtAsvzFQvoJDlLTmRusoyONQ8RqjdCoxKbeWcmOX4h/pKS
QyD250h3+AJfV0MJOyubZUSbwn4a/FZpSwjKPvAwPc0WCy5RuFy2sY+OhT6KQ2ZsJlWr
+ttVDk8e233fvyFZXsZvB7N9csg1U3cYCiUXqhLM/6/AfFw9iRE9PIn88fmWYnS24yH4
DaZo1mAUBAQE79Ief0cylYfuwnX5lyBszlU7dEMZPdw4+o+5VrwAtHoUc+wpUljf0D0Z
aPNaHp1gCObYRxMoQm2T44r0UUmwOYrxU9yxYl+yqQXEDsxtC0zBdTW7+5IYxUCZ8am2
e2vQ==
X-Forwarded-Encrypted: i=1;
AJvYcCV1jdGmY6ws/EPnvaIKJbJl8criFPwoMokHUVGOzZEE8yaqp6AgUCf4BGFdsSJKHqDEw7guIKnUP3NsXYqzDZDcYCtra3g=
X-Gm-Message-State: AOJu0YxPJRJpNI6Ff5WGf+f0pd1+U2s0ATkKJzhSNVWCWE91p4k9lV1M
ZapYI2+WwM7uA/wBHZFLFphw2EGKfOHgHD7Z+G2BBOQGiz8wPzPT
X-Google-Smtp-Source: AGHT+IHaNMWYFuq8b4EK9MMgHOz76SVdZrBLrFWs0R1Y9FCAOg0y02D5y9zLD5ORXXqTWK4hLGjjSQ==
X-Received: by 2002:a2e:780b:0:b0:2ec:4a95:5f05 with SMTP id
38308e7fff4ca-2ec561c0b33mr8529211fa.3.1719073357277;
Sat, 22 Jun 2024 09:22:37 -0700 (PDT)
Received: from lili ([2a01:e0a:59b:9120:cf36:ad5d:499d:a92])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-4247d208b6bsm111204145e9.32.2024.06.22.09.22.36
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 22 Jun 2024 09:22:36 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: MSavoritias <email@HIDDEN>
Subject: Re: [bug#71697] [PATCH v2] guix: scripts: lint: Honor package
property to exclude chercker.
In-Reply-To: <20240622172919.2709d7c3@HIDDEN> (MSavoritias's message of
"Sat, 22 Jun 2024 17:29:19 +0300")
References: <8cb162bcde91d3b39453de576caadb9a6f8f8733.1718990517.git.zimon.toutoune@HIDDEN>
<4e0382d4b36b12d59774d23e0e9177889e2398f2.1718994792.git.zimon.toutoune@HIDDEN>
<20240622172919.2709d7c3@HIDDEN>
Date: Sat, 22 Jun 2024 17:40:40 +0200
Message-ID: <878qyxugsn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi, On Sat, 22 Jun 2024 at 17:29,
MSavoritias wrote: > Because
as it currently stands this patch doesn't account for: > - people who dont
have channels but run guix lint
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.167.41 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.167.41 listed in wl.mailspike.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi, On Sat, 22 Jun 2024 at 17:29, MSavoritias wrote: > Because
as it currently stands this patch doesn't account for: > - people who dont
have channels but run guix lint
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.167.41 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.167.41 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (zimon.toutoune[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi,
On Sat, 22 Jun 2024 at 17:29, MSavoritias <email@HIDDEN> wrote:
> Because as it currently stands this patch doesn't account for:
> - people who dont have channels but run guix lint
You misread: there is no channel involved.
Considering this patch, if an user does not want to run *any* checker
for whatever reason, then this user has at hand two means:
+ guix lint --exclude
+ rely on the =E2=80=99properties=E2=80=99 field directly in package defin=
ition
> - people who may not read the manual and have their code sent to SWH even=
tho they didnt intent it
Considering this patch, all the checkers for each package are clearly
displayed.
And this patch adds also the option =E2=80=99--dry-run=E2=80=99. Therefore=
, if one does
not want to read the manual, that=E2=80=99s a good mitigation.
Cheers,
simon
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 22 Jun 2024 15:28:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 22 11:28:25 2024
Received: from localhost ([127.0.0.1]:49750 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sL2fB-0000vI-4A
for submit <at> debbugs.gnu.org; Sat, 22 Jun 2024 11:28:25 -0400
Received: from mail-wr1-f43.google.com ([209.85.221.43]:38284)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sL2f7-0000uc-OU
for 71697 <at> debbugs.gnu.org; Sat, 22 Jun 2024 11:28:23 -0400
Received: by mail-wr1-f43.google.com with SMTP id
ffacd0b85a97d-3649cecd396so153925f8f.1
for <71697 <at> debbugs.gnu.org>; Sat, 22 Jun 2024 08:28:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719070036; x=1719674836; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=Kvz11Z4sZHbCY8w1bcwDr2hW9iJnZL6tuy0troxNjaU=;
b=l21vliT2ozzkSKND3ljwQUWa5KAqC2ITbCHruLc5Vdi8nyFo38+P7HZARVcJ+EScZ9
YbkbF9v3n0cSKARkyFWRzspp1NUnSa7tujhuQ3S+GQFsv57hxGMF2z14Xji+GrnZ7li6
61DHVmD7Nx8w2RaNVDRBDUEmZJzMwrEyZXxmjo4zRfCwPmz8Wy8YiegPojca54ucRJRi
hLfcqchX7J2oYcQJVyw/n+8GCFABUVb0Vt9viVEKT+/E1o0JD8JD9s88xtiWhd0SbRsD
oKdwaEOnWpZwoDySBJ9AnT+rotSOQIatziN2K56T/6jRRbH+c9e0F51FvdU1c1f3gGXI
6igw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719070036; x=1719674836;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Kvz11Z4sZHbCY8w1bcwDr2hW9iJnZL6tuy0troxNjaU=;
b=s/6KSJJNLDLC+HaD/roZQyvMy6xd7shzme35DELcetpOygYocFI9nY2CLalSJA9pi8
I1x9RVyNEcU92tBpzi0LOvGelBzqNWAJh7UwrjjaN60Y1zmtqmpQ+9bhXZn1LgxHXj6O
C2VmxQbvacUs78LtDhDN+wGGrbb7hDbgUh5ruzH0opwgrDehX3rsBIxN1f+vQpzQkHlg
SgkZHgZUroDDB15gNt/o9fjk+yALv7Movv2tsxSEIAFIFH6Ha31vX3WJnv3UNmXT7yym
SbdJVokirwYEBtx1289Z6PxamZRpA+FpV4+l1QsywZ5exVHDYp2fyxMmT+FtDzVtHTtc
JiAg==
X-Gm-Message-State: AOJu0YwfAFneTgCAmft3UckZsUyRZh0NDobUxPGFHfXGIUSvObCBJQ26
W7A16mcc+xSXoDA3uBJDGuBP7EL2mBCm8xQ+v65SPOR7u0n7Ole8xyYJLQ==
X-Google-Smtp-Source: AGHT+IEwxDFKrkVUx93W2sATEzOWeTpEJJvHKMdeDee3x0A7FulLMIuHP/GliXGsSBak7j9UjFcs+A==
X-Received: by 2002:a5d:5f8c:0:b0:360:8419:7a3c with SMTP id
ffacd0b85a97d-366dfa2d8b3mr1389437f8f.4.1719070035942;
Sat, 22 Jun 2024 08:27:15 -0700 (PDT)
Received: from lili.. ([2a01:e0a:59b:9120:cf36:ad5d:499d:a92])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-366383f6dc7sm4763294f8f.14.2024.06.22.08.27.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 22 Jun 2024 08:27:15 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: 71697 <at> debbugs.gnu.org
Subject: [PATCH v3 2/2] scripts: lint: Honor package property to exclude
checkers.
Date: Sat, 22 Jun 2024 17:27:08 +0200
Message-ID: <ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 71697
Cc: Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* guix/scripts/lint.scm (exclude-package-checkers): New procedure, filter the
checker if the package is marked.
(guix-lint)[show-package-checkers]: New procedure.
* doc/guix.texi: Document it.
Change-Id: Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
---
doc/guix.texi | 17 ++++++++++++++++-
guix/scripts/lint.scm | 26 +++++++++++++++++++++++++-
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 037b1a2f24..1baf3fafe6 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -71,7 +71,7 @@
Copyright @copyright{} 2019 Alex Griffin@*
Copyright @copyright{} 2019, 2020, 2021, 2022 Guillaume Le Vaillant@*
Copyright @copyright{} 2020 Liliana Marie Prikler@*
-Copyright @copyright{} 2019, 2020, 2021, 2022, 2023 Simon Tournier@*
+Copyright @copyright{} 2019, 2020, 2021, 2022, 2023, 2024 Simon Tournier@*
Copyright @copyright{} 2020 Wiktor Żelazny@*
Copyright @copyright{} 2020 Damien Cassou@*
Copyright @copyright{} 2020 Jakub Kądziołka@*
@@ -15444,6 +15444,21 @@ Invoking guix lint
to the new style.
@end table
+Sometimes it is not desired to run the same checker each time
+@command{guix lint} is invoked---e.g., because the checker takes time or
+to avoid to send again and again the same request for archiving.
+Instead of excluding the checker at the command-line via the option
+@code{--exclude}, the package might be marked to skip the checker by
+honoring the property in package definition, e.g.,
+
+@lisp
+(package
+ (name "python-scikit-learn")
+ ;; @dots{}
+ (properties '((lint-exclude-archival? . #t)
+ (lint-exclude-home-page? . #t))))
+@end lisp
+
The general syntax is:
@example
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index b98266c831..7aed467eae 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -9,7 +9,7 @@
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@HIDDEN>
;;; Copyright © 2017, 2018 Efraim Flashner <efraim@HIDDEN>
;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@HIDDEN>
-;;; Copyright © 2019, 2020 Simon Tournier <zimon.toutoune@HIDDEN>
+;;; Copyright © 2019, 2020, 2024 Simon Tournier <zimon.toutoune@HIDDEN>
;;; Copyright © 2020 Brice Waegeneire <brice@HIDDEN>
;;;
;;; This file is part of GNU Guix.
@@ -39,6 +39,7 @@ (define-module (guix scripts lint)
#:use-module (ice-9 format)
#:use-module (srfi srfi-1)
#:use-module (srfi srfi-37)
+ #:use-module (srfi srfi-26)
#:export (guix-lint
run-checkers))
@@ -59,6 +60,18 @@ (define (emit-warnings warnings)
name version message))))
warnings))
+(define (exclude-package-checkers package checkers)
+ "Filter the CHECKERS list using PACKAGE properties field."
+ (let ((properties (package-properties package)))
+ (filter (lambda (checker)
+ (not (assq-ref properties
+ ((compose string->symbol
+ (cut string-append "lint-exclude-" <> "?")
+ symbol->string
+ lint-checker-name)
+ checker))))
+ checkers)))
+
(define* (run-checkers package checkers #:key store)
"Run the given CHECKERS on PACKAGE."
(let ((tty? (isatty? (current-error-port))))
@@ -223,16 +236,27 @@ (define-command (guix-lint . args)
(proc store))
(proc #f)))
+ (define (show-package-checkers package checkers)
+ (format (current-error-port) "~a@~a checked by~{ ~a~}.~%"
+ (package-name package)
+ (package-version package)
+ (sort (map (compose symbol->string lint-checker-name)
+ (exclude-package-checkers
+ package checkers))
+ string<?)))
+
(call-maybe-with-store
(lambda (store)
(cond
((null? args)
(fold-packages (lambda (p r)
+ (show-package-checkers p checkers)
(when (not (assoc-ref opts 'dry-run?))
(run-checkers p checkers
#:store store))) '()))
(else
(for-each (lambda (package)
+ (show-package-checkers package checkers)
(when (not (assoc-ref opts 'dry-run?))
(run-checkers package checkers
#:store store)))
--
2.41.0
guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 22 Jun 2024 15:28:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 22 11:28:21 2024
Received: from localhost ([127.0.0.1]:49743 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sL2f6-0000ut-Ms
for submit <at> debbugs.gnu.org; Sat, 22 Jun 2024 11:28:21 -0400
Received: from mail-wm1-f50.google.com ([209.85.128.50]:39218)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sL2f5-0000uW-1f
for 71697 <at> debbugs.gnu.org; Sat, 22 Jun 2024 11:28:19 -0400
Received: by mail-wm1-f50.google.com with SMTP id
5b1f17b1804b1-42181803bf2so4437935e9.1
for <71697 <at> debbugs.gnu.org>; Sat, 22 Jun 2024 08:28:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719070033; x=1719674833; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=iTeAICyrNsT46JmUSzzy/T6nLJzSjmnRRhRRrPI9P+s=;
b=BDCUbEucdUYeN1/ZkizA3JP0J63XFooiksXGjd37FxCZlEsL39JqdKk0CrHVvTqtpe
cxteRHaaKBHJy7jvuPO2cc72da6UEM6jlqsOWia3nItf+y2IrJDl8SeUTOaCwfiR6epz
b0SGVjTC8UIrQBXi9fzUrLkWhF2DgyDBE07f0ltjGWKAzbE0QLvZtpJkjz+Tony4heSa
jBEitKcaYD+jqyE8VqE/MT2MtCFlveHkB/9pKlGCP/OHtp428Ujn/9tzT7M6l5tfhECe
1ev6J6tuTcz18J9YUvmoUqBsJ2q5MzCHorcI1tJiX90sCPCgVrUbzXMUJiHz97uSGgkX
LEJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719070033; x=1719674833;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=iTeAICyrNsT46JmUSzzy/T6nLJzSjmnRRhRRrPI9P+s=;
b=dhPItfyVgeUHZ2nq2/Rb8ASfEmJeJbF8/9XjCJa7DrsUwr3LAvhYIQNF0pyO7ozphy
KN4K5vylSPaQl+r3nSmVvz/O1V1184DyIbGtRJDqAfxUfCeEWcMiLFBxIMq2Itb07X3r
xHIlFVLsvHxZYTM+F9oaYXTG6z6114OTzqd/20uexw6qUZnCk21Yz1vK88kTCjmILbI0
FBPLSOPmHRX1Al0Ewhc3KPIYRjn6tZEoAdJW/n3xvyNUIgICZCTmxu4NxdqAJXHnxCVU
dqLmGnJM8rsqN8wNB5M1Cs+adEklpT9XoL32MoMzjRkWc47CXmlm1IE6lHuGfGzYmqxi
J4NA==
X-Gm-Message-State: AOJu0YzH1Tz0mgPqKuhrHcNzqiiwij/JifQ4/0dkKel8znq6XJxZQl67
bi0SORUPVSe8olMUlePPRnnVs4ZPilc5i6aE0oYQ4+is68IEl6w4F9oX4Q==
X-Google-Smtp-Source: AGHT+IGzItJaN+OqeWcvkDiwGWXHLlZunV7eYia2T6qrlDN+/j4IYRfvZIIxkUsF4NGZZuHtkfDJ+Q==
X-Received: by 2002:a05:6000:18ae:b0:35f:2929:846e with SMTP id
ffacd0b85a97d-366e2a0a8eemr1015226f8f.1.1719070033018;
Sat, 22 Jun 2024 08:27:13 -0700 (PDT)
Received: from lili.. ([2a01:e0a:59b:9120:cf36:ad5d:499d:a92])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-366383f6dc7sm4763294f8f.14.2024.06.22.08.27.11
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 22 Jun 2024 08:27:12 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: 71697 <at> debbugs.gnu.org
Subject: [PATCH v3 1/2] scripts: lint: Add 'dry-run' option.
Date: Sat, 22 Jun 2024 17:27:07 +0200
Message-ID: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 71697
Cc: Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* guix/scripts/lint.scm (show-help, %options): Add 'dry-run' option.
(guix-lint): Use it.
* doc/guix.texi: Document it.
Change-Id: I8c96e376d52c0961ccf2ab39f1fc856c762b089d
---
doc/guix.texi | 3 +++
guix/scripts/lint.scm | 16 ++++++++++++----
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 769ca1399f..037b1a2f24 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -15459,6 +15459,9 @@ Invoking guix lint
List and describe all the available checkers that will be run on packages
and exit.
+@item --dry-run
+Do not run the checkers.
+
@item --checkers
@itemx -c
Only enable the checkers specified in a comma-separated list using the
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index ee3de51fb1..b98266c831 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -100,6 +100,8 @@ (define (show-help)
(display (G_ "Usage: guix lint [OPTION]... [PACKAGE]...
Run a set of checkers on the specified package; if none is specified,
run the checkers on all packages.\n"))
+ (display (G_ "
+ --dry-run do not run checkers "))
(display (G_ "
-c, --checkers=CHECKER1,CHECKER2...
only run the specified checkers"))
@@ -154,6 +156,9 @@ (define %options
(option '(#\n "no-network") #f #f
(lambda (opt name arg result)
(alist-cons 'no-network? #t result)))
+ (option '("dry-run") #f #f
+ (lambda (opt name arg result)
+ (alist-cons 'dry-run? #t result)))
(find (lambda (option)
(member "load-path" (option-names option)))
%standard-build-options)
@@ -222,10 +227,13 @@ (define-command (guix-lint . args)
(lambda (store)
(cond
((null? args)
- (fold-packages (lambda (p r) (run-checkers p checkers
- #:store store)) '()))
+ (fold-packages (lambda (p r)
+ (when (not (assoc-ref opts 'dry-run?))
+ (run-checkers p checkers
+ #:store store))) '()))
(else
(for-each (lambda (package)
- (run-checkers package checkers
- #:store store))
+ (when (not (assoc-ref opts 'dry-run?))
+ (run-checkers package checkers
+ #:store store)))
args)))))))))
base-commit: bc8a41f4a8d9f1f0525d7bc97c67ed3c8aea3111
--
2.41.0
guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 22 Jun 2024 14:29:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 22 10:29:51 2024
Received: from localhost ([127.0.0.1]:48014 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sL1kU-0007PF-FS
for submit <at> debbugs.gnu.org; Sat, 22 Jun 2024 10:29:51 -0400
Received: from mail.webarch.email ([81.95.52.48]:36152)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <email@HIDDEN>) id 1sL1kR-0007P6-IU
for 71697 <at> debbugs.gnu.org; Sat, 22 Jun 2024 10:29:48 -0400
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)
with ESMTPSA id A30421A88747; Sat, 22 Jun 2024 15:29:21 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msavoritias.me;
s=20210930; t=1719066584;
h=from:subject:date:message-id:to:cc:mime-version:content-type:
content-transfer-encoding:in-reply-to:references;
bh=MseUyAQZAVV5AqF0Jp6PUi1b+X03cMu8tCJoeHR14Qk=;
b=QMWgDc5jQ41Ca3+MzMJQetjMKeOyLJqHqPm5Ivbf2XYxPcq0s6TlFo5+v1QI7Zia014nrS
yrBQ9brx0nuDBAVlPZYJ79TI2E3E0lChuj3G9SotlZfzgSOU7S5isFgpDGPRUullCFD//w
l9qV8C7i72d9oeQPNjTVOpwbTFnW1kf3lfd9l0yKm/AVmvlCiA++v9tiU/ao/p3+R5Do+D
d932MhEaNLTiws1JK4Eb5a908JMf6ZEQYVqFkB8WxCGrSv0lsA048U16qTwtxh6gE5Bo34
JwVI3/eRqTTOkcL4I+NI/W4mACmNHuLEc0ZBadhDWLOQyhliuWdpi+uGaIZ+sg==
Date: Sat, 22 Jun 2024 17:29:19 +0300
From: MSavoritias <email@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: [bug#71697] [PATCH v2] guix: scripts: lint: Honor package
property to exclude chercker.
Message-ID: <20240622172919.2709d7c3@HIDDEN>
In-Reply-To: <4e0382d4b36b12d59774d23e0e9177889e2398f2.1718994792.git.zimon.toutoune@HIDDEN>
References: <8cb162bcde91d3b39453de576caadb9a6f8f8733.1718990517.git.zimon.toutoune@HIDDEN>
<4e0382d4b36b12d59774d23e0e9177889e2398f2.1718994792.git.zimon.toutoune@HIDDEN>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.41; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Last-TLS-Session-Version: TLSv1.3
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Fri,
21 Jun 2024 20:33:28 +0200 Simon Tournier <zimon.toutoune@HIDDEN>
wrote: > * guix/scripts/lint.scm (run-checkers): Skip the checker if the
package is > marked. > * doc/guix.texi: Document it. > > Change-Id:
Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
> --- > doc/guix.texi | [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 71697
Cc: Josselin Poiret <dev@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Mathieu Othacehe <othacehe@HIDDEN>,
Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@HIDDEN>,
Tobias Geerinckx-Rice <me@HIDDEN>,
Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
71697 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>,
Matthew Trzcinski <matt@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Fri, 21 Jun 2024 20:33:28 +0200 Simon Tournier <zimon.toutoune@HIDDEN>
wrote: > * guix/scripts/lint.scm (run-checkers): Skip the checker if the
package is > marked. > * doc/guix.texi: Document it. > > Change-Id: Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
> --- > doc/guix.texi | [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
On Fri, 21 Jun 2024 20:33:28 +0200
Simon Tournier <zimon.toutoune@HIDDEN> wrote:
> * guix/scripts/lint.scm (run-checkers): Skip the checker if the package is
> marked.
> * doc/guix.texi: Document it.
>=20
> Change-Id: Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
> ---
> doc/guix.texi | 17 ++++++++++++++++-
> guix/scripts/lint.scm | 17 +++++++++++++++--
> 2 files changed, 31 insertions(+), 3 deletions(-)
>=20
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 769ca1399f..46a4079c4b 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -71,7 +71,7 @@
> Copyright @copyright{} 2019 Alex Griffin@*
> Copyright @copyright{} 2019, 2020, 2021, 2022 Guillaume Le Vaillant@*
> Copyright @copyright{} 2020 Liliana Marie Prikler@*
> -Copyright @copyright{} 2019, 2020, 2021, 2022, 2023 Simon Tournier@*
> +Copyright @copyright{} 2019, 2020, 2021, 2022, 2023, 2024 Simon Tournier=
@*
> Copyright @copyright{} 2020 Wiktor =C5=BBelazny@*
> Copyright @copyright{} 2020 Damien Cassou@*
> Copyright @copyright{} 2020 Jakub K=C4=85dzio=C5=82ka@*
> @@ -15444,6 +15444,21 @@ Invoking guix lint
> to the new style.
> @end table
> =20
> +Sometimes it is not desired to run the same checker each time
> +@command{guix lint} is invoked---e.g., because the checker takes time or
> +to avoid to send again and again the same request for archiving.
> +Instead of excluding the checker at the command-line via the option
> +@code{--exclude}, the package might be marked to skip the checker by
> +honoring the property in package definition, e.g.,
> +
> +@lisp
> +(package
> + (name "python-scikit-learn")
> + ;; @dots{}
> + (properties '((no-archival . #t)
> + (no-name . #t))))
> +@end lisp
> +
> The general syntax is:
> =20
> @example
> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
> index ee3de51fb1..d8bac277a0 100644
> --- a/guix/scripts/lint.scm
> +++ b/guix/scripts/lint.scm
> @@ -9,7 +9,7 @@
> ;;; Copyright =C2=A9 2017 Tobias Geerinckx-Rice <me@HIDDEN>
> ;;; Copyright =C2=A9 2017, 2018 Efraim Flashner <efraim@HIDDEN>
> ;;; Copyright =C2=A9 2018, 2019 Arun Isaac <arunisaac@HIDDEN>
> -;;; Copyright =C2=A9 2019, 2020 Simon Tournier <zimon.toutoune@HIDDEN>
> +;;; Copyright =C2=A9 2019, 2020, 2024 Simon Tournier <zimon.toutoune@gma=
il.com>
> ;;; Copyright =C2=A9 2020 Brice Waegeneire <brice@HIDDEN>
> ;;;
> ;;; This file is part of GNU Guix.
> @@ -39,6 +39,7 @@ (define-module (guix scripts lint)
> #:use-module (ice-9 format)
> #:use-module (srfi srfi-1)
> #:use-module (srfi srfi-37)
> + #:use-module (srfi srfi-26)
> #:export (guix-lint
> run-checkers))
> =20
> @@ -61,6 +62,18 @@ (define (emit-warnings warnings)
> =20
> (define* (run-checkers package checkers #:key store)
> "Run the given CHECKERS on PACKAGE."
> + (define (checkers* checkers)
> + (let ((properties (package-properties package)))
> + (filter (lambda (checker)
> + (any (lambda (p)
> + (eq? p ((compose string->symbol
> + (cut string-append "no-" <>)
> + symbol->string
> + lint-checker-name)
> + checker)))
> + properties))
> + checkers)))
> +
> (let ((tty? (isatty? (current-error-port))))
> (for-each (lambda (checker)
> (when tty?
> @@ -72,7 +85,7 @@ (define* (run-checkers package checkers #:key store)
> (if (lint-checker-requires-store? checker)
> ((lint-checker-check checker) package #:store store)
> ((lint-checker-check checker) package))))
> - checkers)
> + (checkers* checkers))
> (when tty?
> (format (current-error-port) "\x1b[K")
> (force-output (current-error-port)))))
>=20
> base-commit: bc8a41f4a8d9f1f0525d7bc97c67ed3c8aea3111
Why not make this opt-in instead and have it `enable-archiving`?
Because as it currently stands this patch doesn't account for:
- people who dont have channels but run guix lint
- people who may not read the manual and have their code sent to SWH even t=
ho they didnt intent it
Guix should strive to do what it is explicitly asked. nothing more. which i=
s lint in this case, not archiving.
MSavoritias
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 21 Jun 2024 21:10:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 21 17:10:37 2024
Received: from localhost ([127.0.0.1]:43924 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sKlWm-0005Wq-Nn
for submit <at> debbugs.gnu.org; Fri, 21 Jun 2024 17:10:36 -0400
Received: from mail-wm1-f66.google.com ([209.85.128.66]:58791)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1sKlWl-0005Wd-A1
for 71697 <at> debbugs.gnu.org; Fri, 21 Jun 2024 17:10:36 -0400
Received: by mail-wm1-f66.google.com with SMTP id
5b1f17b1804b1-4218180a122so18210095e9.1
for <71697 <at> debbugs.gnu.org>; Fri, 21 Jun 2024 14:10:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719004170; x=1719608970; darn=debbugs.gnu.org;
h=mime-version:user-agent:content-transfer-encoding:references
:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date
:message-id:reply-to;
bh=dUpxqztAnx74zegX4/3n3rMffQpDimCQutZhTY3jhtM=;
b=i+UknWeG95Sr3pQgLFjwCtym4Rr5llnVu4r+OyNzsuYU9OB5Sde57YtAXyaMydAEu3
Rhm0LnJS19Yl3OYdb67hUVjXhoxZpMq9/wdIrcDy2hPh55MuES7ewbe3VQS/SEksPo6A
8xbzce0qwZFKt0likdivVicwEcGV47TAz6rpYWmJTXXexBErRD5Cx8U8ehPL12h7wHX7
Zc8/7kBxB2nZ8txWeyWRuRGfLA44986cKVawiXO/uwWwvOm0+1fpPsS/BD2Mwc6e9A9K
Jc/tZ8gveUzMjNKGvV4uaTH668RBtmPtiBl2LcVRSwg5ckAHMUHHImG8+heuVR2NFF0a
VfEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719004170; x=1719608970;
h=mime-version:user-agent:content-transfer-encoding:references
:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=dUpxqztAnx74zegX4/3n3rMffQpDimCQutZhTY3jhtM=;
b=b6ugzUAPr7iTv71BYCjsJ+fWDB4ZkcTdk9Hd6WzI+ePem4REcwlfxRDwLp8/Hwj5io
JI+mA+LgBbmSEMmTA+rYFp3Pdxb1wpNWNBAvepUG9oewuT4OFSTjF1VgOF9goliWx4/R
mmX7kqLVs0I7gzj4aGFO+iJFoeNUHVK/tBJYQpKgPxxEROZOleWaJJKRiIfeQBceGlfS
+CxUSeNAdfwD8l0Api7+rWwNW/6OoBQRnAwtjoRbVV9Y9OSeEMHe8dwWP56X0BHouA5m
cTheBH8X0GNCuO9HUC/LXrqRTtgraR1eeNaaEWU8/L9DMOVFfyyQO32Qcadx7hnM7NcW
a4aw==
X-Forwarded-Encrypted: i=1;
AJvYcCWmoYVQ3435FehGo1CH2pFQ/CeqBZgsuENzaUAZYANPwn6ynyEQx1NgXsNL3AQYiyFw0D7l9yFDKXzxUhbnnSlj+KZGTGw=
X-Gm-Message-State: AOJu0Yy0V3wSzFZd7s9CGNBBrSSby51+FrBel9MIHHrYpHRypQkQyXTC
Spb1t0D1Dxuvfgr6bySllAUvOEJzMMBOtfbCd9UFjwx5nA4uQVxK+HhhD9yE
X-Google-Smtp-Source: AGHT+IHlrFzxng74HdXXvixzcKb10EyAjFEvEsR7FBjeM2xroQjGaPTeGmxdprtb0kDzQuqXBwBq0w==
X-Received: by 2002:a05:600c:1c81:b0:421:7c20:a263 with SMTP id
5b1f17b1804b1-42475177b66mr78329975e9.11.1719004169861;
Fri, 21 Jun 2024 14:09:29 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-4247d0b6355sm78591465e9.2.2024.06.21.14.09.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 21 Jun 2024 14:09:29 -0700 (PDT)
Message-ID: <41ee38ce437ae9b444cfda72f51f31b2c62516d6.camel@HIDDEN>
Subject: Re: [PATCH v2] guix: scripts: lint: Honor package property to
exclude chercker.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>, 71697 <at> debbugs.gnu.org
Date: Fri, 21 Jun 2024 23:09:27 +0200
In-Reply-To: <4e0382d4b36b12d59774d23e0e9177889e2398f2.1718994792.git.zimon.toutoune@HIDDEN>
References: <4e0382d4b36b12d59774d23e0e9177889e2398f2.1718994792.git.zimon.toutoune@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4
MIME-Version: 1.0
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 71697
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am Freitag, dem 21.06.2024 um 20:33 +0200 schrieb Simon Tournier:
> +Sometimes it is not desired to run the same checker each time
> +@command{guix lint} is invoked---e.g., because the checker takes
> time or
> +to avoid to send again and again the same request for archiving.
> +Instead of excluding the checker at the command-line via the option
> +@code{--exclude}, the package might be marked to skip the checker by
> +honoring the property in package definition, e.g.,
> +
> +@lisp
> +(package
> +=C2=A0 (name "python-scikit-learn")
> +=C2=A0 ;; @dots{}
> +=C2=A0 (properties '((no-archival . #t)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 (no-name . #t))))
> +@end lisp
> +
Maybe we should future-proof this by calling them "lint-exclude-CHECK".
While a generic "no-CHECK" sounds great, at least no-name might confuse
first readers :)
Cheers
guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at 71697) by debbugs.gnu.org; 21 Jun 2024 18:34:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 21 14:34:47 2024
Received: from localhost ([127.0.0.1]:43468 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sKj5z-00049L-8q
for submit <at> debbugs.gnu.org; Fri, 21 Jun 2024 14:34:47 -0400
Received: from mail-lf1-f48.google.com ([209.85.167.48]:40827)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sKj5v-000492-SV
for 71697 <at> debbugs.gnu.org; Fri, 21 Jun 2024 14:34:45 -0400
Received: by mail-lf1-f48.google.com with SMTP id
2adb3069b0e04-52bc0236f04so343682e87.3
for <71697 <at> debbugs.gnu.org>; Fri, 21 Jun 2024 11:34:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1718994818; x=1719599618; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=HVAO5DtNU0JFGh3skv5JK9JIYs/VAz9vYSg5oGKnJtg=;
b=bBOygU3KMNXLIjVLfQZMXJ9zRIKKgUkR0WGm9id4AsG2IJeqFEi+gA7TrLZU39/zjQ
63nMlGuInyUrwC9M0/KPqQhsCtxIe/uXmrM1RNmII4omq7BS3UBgL1FPpcroyrWLvrDF
bQ4rCRgrWjaLNuDbHP+ob5v4k4rscdu9imIZgXzhVUyD8Yry7yZLC2lyZt0KaJL1IrqE
lIOqmqfvysc310W60Ml6gJ/z6mJOimy3bSaMj6FjkMnHJ4FNUC/UegWybwzbq4l2BAkn
9Cgnj/MX1EqlLwsbLvTUrsVIddT+ERmTghnwm9YY5KiRjeC0Lt+gqANoMxA1jM5KaMAh
unAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1718994818; x=1719599618;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=HVAO5DtNU0JFGh3skv5JK9JIYs/VAz9vYSg5oGKnJtg=;
b=qCtFjYtI8yZz7Q8kWd506kBHBK0tgJZ384Ya8ZipMHLtYsGkK4f0Kn+XIh0CKR/lV2
1AOzmxbMTk1lHboxU1R5OqPQrX4JxScMMISDp/7kVNept4QZGrmUxV89dj+5ZCMkGkIB
H5mo3iqR92aEhWiP7jv34ECZvex69XT70yfC5SVYlB3xruSQwAGmeAfruVePl3OomvnR
/5VuvuAuMLFdkzGa+Td6u8XeUypzBpw+RXoQCwYgpdVfJluqVN1258KstiVW0w8rP6Au
JUkG268WdlZzW1mu9BEVwhATxQkEKfN3UP84POm6wsHD7VcPUQjcEDP9qcjQ7ewHxcTS
3v5A==
X-Gm-Message-State: AOJu0YzzwMhGgMX4zB68+pUXeOoUm1LrqLeLvMO6b9SoAsf2fOkhxdel
LEV38Ih9NnNn0Sr6tsTPuVLCVJu+AEqpiBZongv9hqPoMeedVNDsTfevNw==
X-Google-Smtp-Source: AGHT+IEwcBCCTgHhGkiaKmsaoguo+m4QPOd0wXPQMjH1kT/bcDRNfiPfKJffAHDYV9Wv0g6pDsRAuw==
X-Received: by 2002:a05:6512:b22:b0:52c:cd07:37b6 with SMTP id
2adb3069b0e04-52ccd0738b3mr5501947e87.1.1718994817573;
Fri, 21 Jun 2024 11:33:37 -0700 (PDT)
Received: from lili.. ([89.207.175.12]) by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-366d5cbd5bbsm1625604f8f.97.2024.06.21.11.33.35
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 21 Jun 2024 11:33:36 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: 71697 <at> debbugs.gnu.org
Subject: [PATCH v2] guix: scripts: lint: Honor package property to exclude
chercker.
Date: Fri, 21 Jun 2024 20:33:28 +0200
Message-ID: <4e0382d4b36b12d59774d23e0e9177889e2398f2.1718994792.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 71697
Cc: Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* guix/scripts/lint.scm (run-checkers): Skip the checker if the package is
marked.
* doc/guix.texi: Document it.
Change-Id: Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
---
doc/guix.texi | 17 ++++++++++++++++-
guix/scripts/lint.scm | 17 +++++++++++++++--
2 files changed, 31 insertions(+), 3 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 769ca1399f..46a4079c4b 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -71,7 +71,7 @@
Copyright @copyright{} 2019 Alex Griffin@*
Copyright @copyright{} 2019, 2020, 2021, 2022 Guillaume Le Vaillant@*
Copyright @copyright{} 2020 Liliana Marie Prikler@*
-Copyright @copyright{} 2019, 2020, 2021, 2022, 2023 Simon Tournier@*
+Copyright @copyright{} 2019, 2020, 2021, 2022, 2023, 2024 Simon Tournier@*
Copyright @copyright{} 2020 Wiktor Żelazny@*
Copyright @copyright{} 2020 Damien Cassou@*
Copyright @copyright{} 2020 Jakub Kądziołka@*
@@ -15444,6 +15444,21 @@ Invoking guix lint
to the new style.
@end table
+Sometimes it is not desired to run the same checker each time
+@command{guix lint} is invoked---e.g., because the checker takes time or
+to avoid to send again and again the same request for archiving.
+Instead of excluding the checker at the command-line via the option
+@code{--exclude}, the package might be marked to skip the checker by
+honoring the property in package definition, e.g.,
+
+@lisp
+(package
+ (name "python-scikit-learn")
+ ;; @dots{}
+ (properties '((no-archival . #t)
+ (no-name . #t))))
+@end lisp
+
The general syntax is:
@example
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index ee3de51fb1..d8bac277a0 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -9,7 +9,7 @@
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@HIDDEN>
;;; Copyright © 2017, 2018 Efraim Flashner <efraim@HIDDEN>
;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@HIDDEN>
-;;; Copyright © 2019, 2020 Simon Tournier <zimon.toutoune@HIDDEN>
+;;; Copyright © 2019, 2020, 2024 Simon Tournier <zimon.toutoune@HIDDEN>
;;; Copyright © 2020 Brice Waegeneire <brice@HIDDEN>
;;;
;;; This file is part of GNU Guix.
@@ -39,6 +39,7 @@ (define-module (guix scripts lint)
#:use-module (ice-9 format)
#:use-module (srfi srfi-1)
#:use-module (srfi srfi-37)
+ #:use-module (srfi srfi-26)
#:export (guix-lint
run-checkers))
@@ -61,6 +62,18 @@ (define (emit-warnings warnings)
(define* (run-checkers package checkers #:key store)
"Run the given CHECKERS on PACKAGE."
+ (define (checkers* checkers)
+ (let ((properties (package-properties package)))
+ (filter (lambda (checker)
+ (any (lambda (p)
+ (eq? p ((compose string->symbol
+ (cut string-append "no-" <>)
+ symbol->string
+ lint-checker-name)
+ checker)))
+ properties))
+ checkers)))
+
(let ((tty? (isatty? (current-error-port))))
(for-each (lambda (checker)
(when tty?
@@ -72,7 +85,7 @@ (define* (run-checkers package checkers #:key store)
(if (lint-checker-requires-store? checker)
((lint-checker-check checker) package #:store store)
((lint-checker-check checker) package))))
- checkers)
+ (checkers* checkers))
(when tty?
(format (current-error-port) "\x1b[K")
(force-output (current-error-port)))))
base-commit: bc8a41f4a8d9f1f0525d7bc97c67ed3c8aea3111
--
2.41.0
guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 21 Jun 2024 18:12:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 21 14:12:54 2024
Received: from localhost ([127.0.0.1]:43245 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sKikn-0003Kn-Fg
for submit <at> debbugs.gnu.org; Fri, 21 Jun 2024 14:12:54 -0400
Received: from lists.gnu.org ([209.51.188.17]:57290)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1sKikl-0003KE-9d
for submit <at> debbugs.gnu.org; Fri, 21 Jun 2024 14:12:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1sKhyE-0002B8-GM
for guix-patches@HIDDEN; Fri, 21 Jun 2024 13:22:42 -0400
Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1sKhyC-0006F1-8u
for guix-patches@HIDDEN; Fri, 21 Jun 2024 13:22:42 -0400
Received: by mail-wm1-x32e.google.com with SMTP id
5b1f17b1804b1-42181803bf2so3320715e9.1
for <guix-patches@HIDDEN>; Fri, 21 Jun 2024 10:22:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1718990557; x=1719595357; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=g/j/h95CqXP1iqbwYTBHZcJUqHM4KZmz2U0trIZfz1E=;
b=Y/ruKoFxCyeSFMIlaAkL5mF5SjXiEo0kEfeV65mPfeylIZNx3WkqngIpqp84Wj7Eit
jBIXA+wqPmV1GNF5HCQE1piHnvkwMyNGacBOUBFCBsltkYtD1FThF2vp4bI2CwxsV2p/
IuvlTohrHZMlce2nCyjYEbhBsscxNxH1jtGukDTcngLWQglMKklqzhwJbdJzw8nuHYg6
A1XQLiu1ufpmTUIYz7F6Ii9evL9cG1M/dvkB2rnRed0bak1E4iOJFxk3vNm1rFXIzf2X
LTZLEtKoXxbktCo3AsbdhRcVMaAs+iQUNxI2MH3gk9DkEKNWL2epkqRvQutrAGLnZzhv
TQUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1718990557; x=1719595357;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=g/j/h95CqXP1iqbwYTBHZcJUqHM4KZmz2U0trIZfz1E=;
b=c1eejR3ey16dfW4B8gu7EyzGzbuUcrtMqugNOyynyi6huZX6zQEfgPqwK+KL2oOTzg
SVwqt+sdCSab5vgqW1vSkmjO/lkM6GuHpzzAlzLvmaDnwXLZszeUOXgkIkLEo6ej2fJl
HRdRAFvR7R69rjwL9vzH4340KyyiSLzohcVQsxLZU6UAE17bnMbqduQHY3MV2kH/3VK1
mJyqAEZQHxd3Wv3dplOf8ycZdFGrKIWjldFmBLWmgpeEPnJynZ68f8SSpsMXg7o2hobI
oK95rMZIErT2J+EaPOj+BEmiOhgWb/hheljepL41m1LnjHSZgXV6W6hg4T1y2iiWUiga
D3gg==
X-Gm-Message-State: AOJu0Yy3TkMKXiT4/4+h1IcMo74H8AWMcTOZPbJUgTqw/XDwoZevXeZ4
S+A3rZYeb+tUor/pcUWcUej++S9QEUfevvaZupzXS08JiMDmyop47QnrxQ==
X-Google-Smtp-Source: AGHT+IGG37+NEWWVsARNnfRmZOy/y7qdUWlvl32yclS9FwRJR7VObW7V8+09GyWS6sI3QilyLIpo0A==
X-Received: by 2002:a5d:5847:0:b0:362:3358:48cf with SMTP id
ffacd0b85a97d-363171e2873mr6955747f8f.2.1718990556515;
Fri, 21 Jun 2024 10:22:36 -0700 (PDT)
Received: from lili.. ([89.207.175.12]) by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-4247d21225fsm72658335e9.42.2024.06.21.10.22.34
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 21 Jun 2024 10:22:36 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] guix: lint: Honor 'no-archival?' package property.
Date: Fri, 21 Jun 2024 19:22:24 +0200
Message-ID: <8cb162bcde91d3b39453de576caadb9a6f8f8733.1718990517.git.zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::32e;
envelope-from=zimon.toutoune@HIDDEN; helo=mail-wm1-x32e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
* guix/lint.scm (check-archival): Skip the checker if the package is marked.
* doc/guix.texi: Document it.
Change-Id: I2e21b60ee4f02255f298740a2e9ebb1717e490ff
---
doc/guix.texi | 15 ++++-
guix/lint.scm | 154 ++++++++++++++++++++++++++------------------------
2 files changed, 93 insertions(+), 76 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 769ca1399f..5c1cb89686 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -71,7 +71,7 @@
Copyright @copyright{} 2019 Alex Griffin@*
Copyright @copyright{} 2019, 2020, 2021, 2022 Guillaume Le Vaillant@*
Copyright @copyright{} 2020 Liliana Marie Prikler@*
-Copyright @copyright{} 2019, 2020, 2021, 2022, 2023 Simon Tournier@*
+Copyright @copyright{} 2019, 2020, 2021, 2022, 2023, 2024 Simon Tournier@*
Copyright @copyright{} 2020 Wiktor Żelazny@*
Copyright @copyright{} 2020 Damien Cassou@*
Copyright @copyright{} 2020 Jakub Kądziołka@*
@@ -15380,6 +15380,19 @@ Invoking guix lint
prints a message and the @code{archival} checker stops doing anything until
that limit has been reset.
+Sometimes it is not desired to send a request for archiving each time
+@command{guix lint} is run. The package might be marked to skip the
+@code{archival} checker by honoring the @code{no-archival?} property in
+package definition:
+
+@lisp
+(define-public python-scikit-learn
+ (package
+ (name "python-scikit-learn")
+ ;; @dots{}
+ (properties '((no-archival? . #t)))))
+@end lisp
+
@item cve
@cindex security vulnerabilities
@cindex CVE, Common Vulnerabilities and Exposures
diff --git a/guix/lint.scm b/guix/lint.scm
index 68d532968d..4c33ec6598 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1717,84 +1717,88 @@ (define (check-archival package)
(lookup-directory-by-nar-hash (content-hash-value hash)
(content-hash-algorithm hash)))
- (parameterize ((%allow-request? skip-when-limit-reached))
- (catch #t
- (lambda ()
- (match (package-source package)
- (#f ;no source
- '())
- ((and (? origin? origin)
- (= origin-uri (? git-reference? reference)))
- (define url
- (git-reference-url reference))
- (define commit
- (git-reference-commit reference))
- (define hash
- (origin-hash origin))
-
- (match (or (lookup-by-nar-hash hash)
- (if (commit-id? commit)
- (or (lookup-revision commit)
- (lookup-origin-revision url commit))
- (lookup-origin-revision url commit)))
- ((or (? string?) (? revision?))
- '())
- (#f
- ;; Revision is missing from the archive, attempt to save it.
- (save-package-source package))))
- ((? origin? origin)
- (if (and=> (origin-hash origin) ;XXX: for ungoogled-chromium
- content-hash-value) ;& icecat
- (let ((hash (origin-hash origin)))
- (match (or (lookup-by-nar-hash hash)
- (lookup-content (content-hash-value hash)
- (symbol->string
- (content-hash-algorithm hash))))
- (#f
- ;; If ORIGIN is a version-control checkout, save it now.
- ;; If not, check whether HASH is in the Disarchive
- ;; database ("Save Code Now" does not accept tarballs).
- (if (vcs-origin origin)
- (save-package-source package)
- (match (lookup-disarchive-spec hash)
- (#f
- (list (make-warning package
- (G_ "source not archived on Software \
+ (if (not (assq 'no-archival? (package-properties package)))
+ (parameterize ((%allow-request? skip-when-limit-reached))
+ (catch #t
+ (lambda ()
+ (match (package-source package)
+ (#f ;no source
+ '())
+ ((and (? origin? origin)
+ (= origin-uri (? git-reference? reference)))
+ (define url
+ (git-reference-url reference))
+ (define commit
+ (git-reference-commit reference))
+ (define hash
+ (origin-hash origin))
+
+ (match (or (lookup-by-nar-hash hash)
+ (if (commit-id? commit)
+ (or (lookup-revision commit)
+ (lookup-origin-revision url commit))
+ (lookup-origin-revision url commit)))
+ ((or (? string?) (? revision?))
+ '())
+ (#f
+ ;; Revision is missing from the archive, attempt to save it.
+ (save-package-source package))))
+ ((? origin? origin)
+ (if (and=> (origin-hash origin) ;XXX: for ungoogled-chromium
+ content-hash-value) ;& icecat
+ (let ((hash (origin-hash origin)))
+ (match (or (lookup-by-nar-hash hash)
+ (lookup-content (content-hash-value hash)
+ (symbol->string
+ (content-hash-algorithm hash))))
+ (#f
+ ;; If ORIGIN is a version-control checkout, save it now.
+ ;; If not, check whether HASH is in the Disarchive
+ ;; database ("Save Code Now" does not accept tarballs).
+ (if (vcs-origin origin)
+ (save-package-source package)
+ (match (lookup-disarchive-spec hash)
+ (#f
+ (list (make-warning package
+ (G_ "source not archived on Software \
Heritage and missing from the Disarchive database")
- #:field 'source)))
- (directory-ids
- (match (find (lambda (id)
- (not (lookup-directory id)))
- directory-ids)
- (#f '())
- (id
- (list (make-warning package
- (G_ "\
+ #:field 'source)))
+ (directory-ids
+ (match (find (lambda (id)
+ (not (lookup-directory id)))
+ directory-ids)
+ (#f '())
+ (id
+ (list (make-warning package
+ (G_ "\
Disarchive entry refers to non-existent SWH directory '~a'")
- (list id)
- #:field 'source))))))))
- ((? content?)
- '())
- ((? string? swhid)
- '())))
- '()))
- ((? local-file?)
- '())
- (_
- (list (make-warning package
- (G_ "\
+ (list id)
+ #:field 'source))))))))
+ ((? content?)
+ '())
+ ((? string? swhid)
+ '())))
+ '()))
+ ((? local-file?)
+ '())
+ (_
+ (list (make-warning package
+ (G_ "\
source is not an origin, it cannot be archived")
- #:field 'source)))))
- (match-lambda*
- (('swh-error url method response)
- (swh-response->warning package url method response))
- ((key . args)
- (if (eq? key skip-key)
- '()
- (with-networking-fail-safe
- (G_ "while connecting to Software Heritage")
- '()
- (apply throw key args))))))))
+ #:field 'source)))))
+ (match-lambda*
+ (('swh-error url method response)
+ (swh-response->warning package url method response))
+ ((key . args)
+ (if (eq? key skip-key)
+ '()
+ (with-networking-fail-safe
+ (G_ "while connecting to Software Heritage")
+ '()
+ (apply throw key args)))))))
+ (list
+ (make-warning package
+ (G_ "skip archiving as marked by package")))))
(define (check-haskell-stackage package)
"Check whether PACKAGE is a Haskell package ahead of the current
base-commit: bc8a41f4a8d9f1f0525d7bc97c67ed3c8aea3111
--
2.41.0
Simon Tournier <zimon.toutoune@HIDDEN>:guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN.
Full text available.guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#71697; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.