GNU bug report logs - #71721
[PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71721 in the body.
You can then email your comments to 71721 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'
Date: Sat, 22 Jun 2024 10:23:56 -0500

[Message part 1 (text/plain, inline)]

Tags: patch

This adds entries to map mpc.el’s tool-bar icons to GTK stock
icons.

[0001-Add-icons-used-by-mpc.el-to-x-gtk-stock-map.patch (text/patch, attachment)]

Message #8 received at 71721 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: john muhl <jm <at> pub.pink>
Cc: 71721 <at> debbugs.gnu.org
Subject: Re: bug#71721: [PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'
Date: Mon, 24 Jun 2024 09:52:40 +0800

john muhl <jm <at> pub.pink> writes:

> Tags: patch
>
> This adds entries to map mpc.el’s tool-bar icons to GTK stock
> icons.

Would KDE users please confirm that no outsized icons are introduced by
this patch on that desktop environment?

Message #13 received at 71721 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: john muhl <jm <at> pub.pink>, 71721 <at> debbugs.gnu.org
Subject: Re: bug#71721: [PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'
Date: Tue, 11 Feb 2025 11:34:55 -0800

Po Lu <luangruo <at> yahoo.com> writes:

> john muhl <jm <at> pub.pink> writes:
>
>> Tags: patch
>>
>> This adds entries to map mpc.el’s tool-bar icons to GTK stock
>> icons.
>
> Would KDE users please confirm that no outsized icons are introduced by
> this patch on that desktop environment?

Do we know anyone who runs KDE that we could ask specifically?

I don't have access to KDE right now, myself.  Otherwise, it should be
easy enough to test.

Message #16 received at 71721 <at> debbugs.gnu.org (full text, mbox):

From: jm <at> pub.pink
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Po Lu <luangruo <at> yahoo.com>, 71721 <at> debbugs.gnu.org
Subject: Re: bug#71721: [PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'
Date: Tue, 11 Feb 2025 13:37:15 -0600

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Po Lu <luangruo <at> yahoo.com> writes:
>
>> john muhl <jm <at> pub.pink> writes:
>>
>>> Tags: patch
>>>
>>> This adds entries to map mpc.el’s tool-bar icons to GTK stock
>>> icons.
>>
>> Would KDE users please confirm that no outsized icons are introduced by
>> this patch on that desktop environment?
>
> Do we know anyone who runs KDE that we could ask specifically?
>
> I don't have access to KDE right now, myself.  Otherwise, it should be
> easy enough to test.

I tested it in a VM with KDE and didn’t see any problem but guess
I forgot to report back and can’t find the screenshots anymore.

Message #19 received at 71721 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: jm <at> pub.pink
Cc: Po Lu <luangruo <at> yahoo.com>, 71721 <at> debbugs.gnu.org
Subject: Re: bug#71721: [PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'
Date: Tue, 11 Feb 2025 12:03:10 -0800

jm <at> pub.pink writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Po Lu <luangruo <at> yahoo.com> writes:
>>
>>> john muhl <jm <at> pub.pink> writes:
>>>
>>>> Tags: patch
>>>>
>>>> This adds entries to map mpc.el’s tool-bar icons to GTK stock
>>>> icons.
>>>
>>> Would KDE users please confirm that no outsized icons are introduced by
>>> this patch on that desktop environment?
>>
>> Do we know anyone who runs KDE that we could ask specifically?
>>
>> I don't have access to KDE right now, myself.  Otherwise, it should be
>> easy enough to test.
>
> I tested it in a VM with KDE and didn’t see any problem but guess
> I forgot to report back and can’t find the screenshots anymore.

So can we install this now?  Po Lu?

Message #22 received at 71721 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: jm <at> pub.pink, 71721 <at> debbugs.gnu.org
Subject: Re: bug#71721: [PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'
Date: Wed, 12 Feb 2025 09:24:40 +0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> So can we install this now?  Po Lu?

By all means.

Message #27 received at 71721-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 71721-done <at> debbugs.gnu.org, jm <at> pub.pink
Subject: Re: bug#71721: [PATCH] Add icons used by 'mpc.el' to 'x-gtk-stock-map'
Date: Tue, 11 Feb 2025 18:37:34 -0800

Version: 31.1

Po Lu <luangruo <at> yahoo.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> So can we install this now?  Po Lu?
>
> By all means.

Thanks, installed on master as commit ddb1dfa3f2d.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.