GNU bug report logs - #71736
Small cleanup patches for lua-ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71736 in the body.
You can then email your comments to 71736 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: Small cleanup patches for lua-ts-mode
Date: Sun, 23 Jun 2024 09:41:06 -0500

Tags: patch

Following up with a few trivial cleanups in lua-ts-mode.

Message #8 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 71736 <at> debbugs.gnu.org
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Sun, 23 Jun 2024 09:58:59 -0500

[Message part 1 (text/plain, inline)]

john muhl <jm <at> pub.pink> writes:

[0001-Add-eglot-ensure-option-to-lua-ts-mode-hook.patch (text/x-patch, attachment)]

[0002-Use-keymap-set-in-lua-ts-mode-bug-71736.patch (text/x-patch, attachment)]

[0003-lua-ts-mode.el-Reword-doc.-bug-71736.patch (text/x-patch, attachment)]

[0004-Remove-useless-require-of-rx-in-lua-ts-mode.patch (text/x-patch, attachment)]

[Message part 6 (text/plain, inline)]

> Tags: patch
>
> Following up with a few trivial cleanups in lua-ts-mode.

Message #11 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: john muhl <jm <at> pub.pink>, 71736 <at> debbugs.gnu.org
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Sun, 23 Jun 2024 08:51:08 -0700

john muhl <jm <at> pub.pink> writes:

> From abecae7d631f4b313fe8510f47e480f1a82bb4ad Mon Sep 17 00:00:00 2001
> From: john muhl <jm <at> pub.pink>
> Date: Thu, 13 Jun 2024 15:19:04 -0500
> Subject: [PATCH 4/4] ; Remove useless require of 'rx' in 'lua-ts-mode'
>
> * lisp/progmodes/lua-ts-mode.el: No need to require 'rx' since it
> is preloaded.  (bug#71736)

I don't think "rx" is preloaded.  In emacs -Q, (featurep 'rx) is nil.

Message #14 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 71736 <at> debbugs.gnu.org
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Sun, 23 Jun 2024 11:12:21 -0500

Stefan Kangas <stefankangas <at> gmail.com> writes:

> john muhl <jm <at> pub.pink> writes:
>
>> From abecae7d631f4b313fe8510f47e480f1a82bb4ad Mon Sep 17 00:00:00 2001
>> From: john muhl <jm <at> pub.pink>
>> Date: Thu, 13 Jun 2024 15:19:04 -0500
>> Subject: [PATCH 4/4] ; Remove useless require of 'rx' in 'lua-ts-mode'
>>
>> * lisp/progmodes/lua-ts-mode.el: No need to require 'rx' since it
>> is preloaded.  (bug#71736)
>
> I don't think "rx" is preloaded.  In emacs -Q, (featurep 'rx) is nil.

I guess I got confused. I tried:

  $ src/emacs -Q -batch -eval '(message "%s" (rx bos "heyo" eos))'
  \`heyo\`

which led me to think it didn’t need to be required. Feel free to
discard.

Message #17 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: stefankangas <at> gmail.com, 71736 <at> debbugs.gnu.org
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Thu, 27 Jun 2024 12:02:06 +0300

> Cc: 71736 <at> debbugs.gnu.org
> From: john muhl <jm <at> pub.pink>
> Date: Sun, 23 Jun 2024 11:12:21 -0500
> 
> Stefan Kangas <stefankangas <at> gmail.com> writes:
> 
> > john muhl <jm <at> pub.pink> writes:
> >
> >> From abecae7d631f4b313fe8510f47e480f1a82bb4ad Mon Sep 17 00:00:00 2001
> >> From: john muhl <jm <at> pub.pink>
> >> Date: Thu, 13 Jun 2024 15:19:04 -0500
> >> Subject: [PATCH 4/4] ; Remove useless require of 'rx' in 'lua-ts-mode'
> >>
> >> * lisp/progmodes/lua-ts-mode.el: No need to require 'rx' since it
> >> is preloaded.  (bug#71736)
> >
> > I don't think "rx" is preloaded.  In emacs -Q, (featurep 'rx) is nil.
> 
> I guess I got confused. I tried:
> 
>   $ src/emacs -Q -batch -eval '(message "%s" (rx bos "heyo" eos))'
>   \`heyo\`
> 
> which led me to think it didn’t need to be required. Feel free to
> discard.

Discard all of the patches or just that 4/4 part?

Message #20 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, john muhl <jm <at> pub.pink>
Cc: 71736 <at> debbugs.gnu.org
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Thu, 27 Jun 2024 16:05:03 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> Discard all of the patches or just that 4/4 part?

I think just the 4/4 part, indeed, so I've installed patches 1 and 3 on
emacs-30.

I think patch 2 should go to master, but it doesn't apply cleanly.
John, could you please rebase it and resend?

Message #23 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 71736 <at> debbugs.gnu.org
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Fri, 28 Jun 2024 11:24:41 -0500

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> Discard all of the patches or just that 4/4 part?
>
> I think just the 4/4 part, indeed, so I've installed patches 1 and 3 on
> emacs-30.

Yep. I meant just the one part but of course you can always
discard whatever you like :)

> I think patch 2 should go to master, but it doesn't apply cleanly.
> John, could you please rebase it and resend?

Oops, I see now it included a bit of unrelated local changes.

Here’s another try. I rebased it and checked that it applies to
emacs-30 and master. Out of curiousity, what makes it unfit for
the emacs-30 branch?

[0001-Use-keymap-set-in-lua-ts-mode-bug-71736.patch (text/x-patch, attachment)]

Message #28 received at 71736-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 71736-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Fri, 28 Jun 2024 12:56:09 -0700

Version: 30.1

john muhl <jm <at> pub.pink> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> I think patch 2 should go to master, but it doesn't apply cleanly.
>> John, could you please rebase it and resend?
>
> Oops, I see now it included a bit of unrelated local changes.
>
> Here’s another try. I rebased it and checked that it applies to
> emacs-30 and master.

Thanks!

> Out of curiousity, what makes it unfit for the emacs-30 branch?

We prefer not to put code cleanups on the release branch.

So I've now pushed it to `master`, and I'm closing this bug report.

BTW, is there any reason not to use `defvar-keymap' in lua-ts-mode.el?
Does it need to be compatible with Emacs 28?

Message #31 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 71736 <at> debbugs.gnu.org
Cc: stefankangas <at> gmail.com
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Fri, 28 Jun 2024 17:16:36 -0500

Stefan Kangas <stefankangas <at> gmail.com> writes:

> BTW, is there any reason not to use `defvar-keymap' in
> lua-ts-mode.el?

Probably I did not remember (or know) it was available. I’ll
change it.

> Does it need to be compatible with Emacs 28?

Let’s hope not.

Message #34 received at 71736 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: john muhl <jm <at> pub.pink>, 71736 <at> debbugs.gnu.org
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Fri, 28 Jun 2024 19:59:30 -0700

john muhl <jm <at> pub.pink> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> BTW, is there any reason not to use `defvar-keymap' in
>> lua-ts-mode.el?
>
> Probably I did not remember (or know) it was available. I’ll
> change it.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.