X-Loop: help-debbugs@HIDDEN Subject: bug#71760: 31.0.50; Filling jsdoc text doesn't work in js-ts-mode Resent-From: Damien Cassou <damien@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 24 Jun 2024 20:24:02 +0000 Resent-Message-ID: <handler.71760.B.171926060019169 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 71760 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71760 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.171926060019169 (code B ref -1); Mon, 24 Jun 2024 20:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jun 2024 20:23:20 +0000 Received: from localhost ([127.0.0.1]:35696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sLqDg-0004z7-7E for submit <at> debbugs.gnu.org; Mon, 24 Jun 2024 16:23:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:47110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <damien@HIDDEN>) id 1sLqDf-0004yz-2D for submit <at> debbugs.gnu.org; Mon, 24 Jun 2024 16:23:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <damien@HIDDEN>) id 1sLqDd-000672-Fn for bug-gnu-emacs@HIDDEN; Mon, 24 Jun 2024 16:23:17 -0400 Received: from mail.reprendre.net ([193.23.30.35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <damien@HIDDEN>) id 1sLqDb-0004N3-7K for bug-gnu-emacs@HIDDEN; Mon, 24 Jun 2024 16:23:17 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C2222C911B for <bug-gnu-emacs@HIDDEN>; Mon, 24 Jun 2024 22:23:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=dkim; t=1719260592; h=from:subject:date:message-id:to:mime-version:content-type; bh=IHWCgx655vhd+UPvLeeqrIx870+D+oRT+rOW8fenkQ0=; b=TiLLbyg8nMfYMSTIWalfuSN6CKYZkIkZbR9Vqdik/p2CQnbaXVeM14wbKJi5Gz2xQ9y8p9 DIxSJ8EDycuxlwOcmTo2MNHoADF/7xFdX0NdwTUHoyO4dOu7FyNE0Er5Vm1aMyyfuU0xdW tMFnAgX47mqJw7ubSw/n1ehwi9Um3wjfDIUswdlgoyJqCq9mZKrMlSLt2MtRrvQYJ9zuw4 Fd6XB6LFopU0ox+p+nH6wS0Up1dkJgHlWCT27pqD7rxKlnX6+RnaojzZBY3095mu+ow6tx z/7wgU5rZheCpkOSWPIHFGOQtvWAxw7w1UTiTzRyIZNx31QGNoowUe90qf/3SA== From: Damien Cassou <damien@HIDDEN> Date: Mon, 24 Jun 2024 22:23:06 +0200 Message-ID: <871q4mxf85.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Last-TLS-Session-Version: TLSv1.3 Received-SPF: pass client-ip=193.23.30.35; envelope-from=damien@HIDDEN; helo=mail.reprendre.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hi, in a commit recently merged in master (0edacf2aa7e53), js-ts-mode has been improved to use the jsdoc treesitter grammar on documentation. Font lock works great but M-q doesn't fill long lines. To reproduce, make sure your Emacs contains the above-mentioned commit and make sure you have the jsdoc treesitter grammar available. Then, save the attached JavaScript file to your disk and execute: $ emacs -Q --eval "(progn (find-file \"/home/cassou/tmp/test.js\") (js-ts-mode))" Move point to the middle of line 2 (or line 4) and press M-q. Expected: The paragraph is filled. Actual: Nothing changes. I tried changing the value of `c-ts-common--comment-regexp' to include "description" (as this is what the jsdoc parser uses for text) but the result is worse. I also tried reusing `js-fill-paragraph' but that fails as well. I would be happy to implement something and send a patch but I have no idea were to start. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/javascript Content-Disposition: attachment; filename=test.js /** * Test. rat art srs tr tr st rst artsar t arstienartsioenaroti eanrtsoi aerntso iaerst * * @param {string} bla - Some documentation of this parameter. ar tar star tsa rst arstar st arst art rs */ function f(bla) { } --=-=-=--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Damien Cassou <damien@HIDDEN> Subject: bug#71760: Acknowledgement (31.0.50; Filling jsdoc text doesn't work in js-ts-mode) Message-ID: <handler.71760.B.171926060019169.ack <at> debbugs.gnu.org> References: <871q4mxf85.fsf@HIDDEN> X-Gnu-PR-Message: ack 71760 X-Gnu-PR-Package: emacs Reply-To: 71760 <at> debbugs.gnu.org Date: Mon, 24 Jun 2024 20:24:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 71760 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 71760: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71760 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 25 Jun 2024 13:05:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 25 09:05:20 2024 Received: from localhost ([127.0.0.1]:36465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sM5rM-0000Ew-6l for submit <at> debbugs.gnu.org; Tue, 25 Jun 2024 09:05:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sM5rG-0000EQ-LG; Tue, 25 Jun 2024 09:05:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sM5r9-0006fb-J5; Tue, 25 Jun 2024 09:05:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dNuhdnKi6H/ZvkHt1bCjwH8SKO+7mOhyfqRu184YtH8=; b=cHyZCaL6R0h2 rNhM7vilOptZ+hguIjof1Jv34j3fD5HyepgMViJeFm7mkV0gF90T6UwTmdPGMzmQk2i0yGNmEaYzA hxSlaBIsEPUmUrHPCCno3YUKB2otxU3R6/403zGsHIF32khxmP5GYn9kbPe7wMicIjQb0tvKKIgsk JhsYLvO3fYhY5ThjUJIzU/msKz97HYaoyvoOD4CUwqn2kn/Um0NyWvuIlOrPKZ4JQUg6kk4zrYJza iqFIzRv0KZESDLsxXRgcSzAQMBb+Tfc1i0TPfjVY2k5O0AbvmP+ARx3R4FcJc+3qsCgFOwnDJlync FVeAbKK+ahfc1uoqcsM/tQ==; Date: Tue, 25 Jun 2024 16:05:04 +0300 Message-Id: <86r0cl9nr3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Damien Cassou <cassou@HIDDEN> In-Reply-To: <875xtyxhr7.fsf@HIDDEN> (message from Damien Cassou on Mon, 24 Jun 2024 21:28:28 +0200) Subject: Re: bug#71768: 31.0.50; Filling jsdoc text doesn't work in js-ts-mode References: <875xtyxhr7.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 71768 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) merge 71768 71760 thanks > From: Damien Cassou <cassou@HIDDEN> > Date: Mon, 24 Jun 2024 21:28:28 +0200 > > Hi, > > in a commit recently merged in master (0edacf2aa7e53), js-ts-mode has > been improved to use the jsdoc treesitter grammar on documentation. Font > lock works great but M-q doesn't fill long lines. > > To reproduce, make sure your Emacs contains the above-mentioned commit > and make sure you have the jsdoc treesitter grammar available. Then, > save the attached JavaScript file to your disk and execute: > > $ emacs -Q --eval "(progn (find-file \"/home/cassou/tmp/test.js\") (js-ts-mode))" > > Move point to the middle of line 2 (or line 4) and press M-q. > > Expected: The paragraph is filled. > > Actual: Nothing changes. > > I tried changing the value of `c-ts-common--comment-regexp' to include > "description" (as this is what the jsdoc parser uses for text) but the > result is worse. I also tried reusing `js-fill-paragraph' but that fails > as well. > > I would be happy to implement something and send a patch but I have no > idea were to start. This is an exact duplicate of bug#71760 which you submitted an hour later, from a different email address. I'm merging them.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.