GNU bug report logs - #71768
31.0.50; Filling jsdoc text doesn't work in js-ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71768 in the body.
You can then email your comments to 71768 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <cassou <at> luz5.mail-host-address-is-not-set>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Filling jsdoc text doesn't work in js-ts-mode
Date: Mon, 24 Jun 2024 21:28:28 +0200

[Message part 1 (text/plain, inline)]

Hi,

in a commit recently merged in master (0edacf2aa7e53), js-ts-mode has
been improved to use the jsdoc treesitter grammar on documentation. Font
lock works great but M-q doesn't fill long lines.

To reproduce, make sure your Emacs contains the above-mentioned commit
and make sure you have the jsdoc treesitter grammar available. Then,
save the attached JavaScript file to your disk and execute:

$ emacs -Q --eval "(progn (find-file \"/home/cassou/tmp/test.js\") (js-ts-mode))"

Move point to the middle of line 2 (or line 4) and press M-q.

Expected: The paragraph is filled.

Actual: Nothing changes.

I tried changing the value of `c-ts-common--comment-regexp' to include
"description" (as this is what the jsdoc parser uses for text) but the
result is worse. I also tried reusing `js-fill-paragraph' but that fails
as well.

I would be happy to implement something and send a patch but I have no
idea were to start.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[test.js (text/javascript, attachment)]

Message #8 received at 71768 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <cassou <at> luz5.mail-host-address-is-not-set>
Cc: 71768 <at> debbugs.gnu.org
Subject: Re: bug#71768: 31.0.50; Filling jsdoc text doesn't work in js-ts-mode
Date: Tue, 25 Jun 2024 16:05:04 +0300

merge 71768 71760
thanks

> From: Damien Cassou <cassou <at> luz5.mail-host-address-is-not-set>
> Date: Mon, 24 Jun 2024 21:28:28 +0200
> 
> Hi,
> 
> in a commit recently merged in master (0edacf2aa7e53), js-ts-mode has
> been improved to use the jsdoc treesitter grammar on documentation. Font
> lock works great but M-q doesn't fill long lines.
> 
> To reproduce, make sure your Emacs contains the above-mentioned commit
> and make sure you have the jsdoc treesitter grammar available. Then,
> save the attached JavaScript file to your disk and execute:
> 
> $ emacs -Q --eval "(progn (find-file \"/home/cassou/tmp/test.js\") (js-ts-mode))"
> 
> Move point to the middle of line 2 (or line 4) and press M-q.
> 
> Expected: The paragraph is filled.
> 
> Actual: Nothing changes.
> 
> I tried changing the value of `c-ts-common--comment-regexp' to include
> "description" (as this is what the jsdoc parser uses for text) but the
> result is worse. I also tried reusing `js-fill-paragraph' but that fails
> as well.
> 
> I would be happy to implement something and send a patch but I have no
> idea were to start.

This is an exact duplicate of bug#71760 which you submitted an hour
later, from a different email address.  I'm merging them.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.