Eli Zaretskii <eliz@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 71768) by debbugs.gnu.org; 25 Jun 2024 13:05:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 25 09:05:17 2024 Received: from localhost ([127.0.0.1]:36463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sM5rI-0000Ei-Rm for submit <at> debbugs.gnu.org; Tue, 25 Jun 2024 09:05:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sM5rG-0000EQ-LG; Tue, 25 Jun 2024 09:05:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sM5r9-0006fb-J5; Tue, 25 Jun 2024 09:05:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dNuhdnKi6H/ZvkHt1bCjwH8SKO+7mOhyfqRu184YtH8=; b=cHyZCaL6R0h2 rNhM7vilOptZ+hguIjof1Jv34j3fD5HyepgMViJeFm7mkV0gF90T6UwTmdPGMzmQk2i0yGNmEaYzA hxSlaBIsEPUmUrHPCCno3YUKB2otxU3R6/403zGsHIF32khxmP5GYn9kbPe7wMicIjQb0tvKKIgsk JhsYLvO3fYhY5ThjUJIzU/msKz97HYaoyvoOD4CUwqn2kn/Um0NyWvuIlOrPKZ4JQUg6kk4zrYJza iqFIzRv0KZESDLsxXRgcSzAQMBb+Tfc1i0TPfjVY2k5O0AbvmP+ARx3R4FcJc+3qsCgFOwnDJlync FVeAbKK+ahfc1uoqcsM/tQ==; Date: Tue, 25 Jun 2024 16:05:04 +0300 Message-Id: <86r0cl9nr3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Damien Cassou <cassou@HIDDEN> In-Reply-To: <875xtyxhr7.fsf@HIDDEN> (message from Damien Cassou on Mon, 24 Jun 2024 21:28:28 +0200) Subject: Re: bug#71768: 31.0.50; Filling jsdoc text doesn't work in js-ts-mode References: <875xtyxhr7.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71768 Cc: 71768 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) merge 71768 71760 thanks > From: Damien Cassou <cassou@HIDDEN> > Date: Mon, 24 Jun 2024 21:28:28 +0200 > > Hi, > > in a commit recently merged in master (0edacf2aa7e53), js-ts-mode has > been improved to use the jsdoc treesitter grammar on documentation. Font > lock works great but M-q doesn't fill long lines. > > To reproduce, make sure your Emacs contains the above-mentioned commit > and make sure you have the jsdoc treesitter grammar available. Then, > save the attached JavaScript file to your disk and execute: > > $ emacs -Q --eval "(progn (find-file \"/home/cassou/tmp/test.js\") (js-ts-mode))" > > Move point to the middle of line 2 (or line 4) and press M-q. > > Expected: The paragraph is filled. > > Actual: Nothing changes. > > I tried changing the value of `c-ts-common--comment-regexp' to include > "description" (as this is what the jsdoc parser uses for text) but the > result is worse. I also tried reusing `js-fill-paragraph' but that fails > as well. > > I would be happy to implement something and send a patch but I have no > idea were to start. This is an exact duplicate of bug#71760 which you submitted an hour later, from a different email address. I'm merging them.
bug-gnu-emacs@HIDDEN:bug#71768; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 25 Jun 2024 05:58:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 25 01:58:21 2024
Received: from localhost ([127.0.0.1]:36128 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sLzC8-00068U-FZ
for submit <at> debbugs.gnu.org; Tue, 25 Jun 2024 01:58:21 -0400
Received: from lists.gnu.org ([209.51.188.17]:43278)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <damien@HIDDEN>) id 1sLpMo-0003NG-Qv
for submit <at> debbugs.gnu.org; Mon, 24 Jun 2024 15:28:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <damien@HIDDEN>) id 1sLpMm-0003dT-Ui
for bug-gnu-emacs@HIDDEN; Mon, 24 Jun 2024 15:28:41 -0400
Received: from mail.reprendre.net ([2001:910:1410:501::1])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <damien@HIDDEN>) id 1sLpMk-0003Tv-OL
for bug-gnu-emacs@HIDDEN; Mon, 24 Jun 2024 15:28:40 -0400
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)
with ESMTPSA id CE6C92C9048
for <bug-gnu-emacs@HIDDEN>; Mon, 24 Jun 2024 21:28:29 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=dkim;
t=1719257310; h=from:subject:date:message-id:to:mime-version:content-type;
bh=IHWCgx655vhd+UPvLeeqrIx870+D+oRT+rOW8fenkQ0=;
b=F4Ho5L3IXBDG9HdY5CoQv+ywuwnjsCni0eFP4w0xJwzIuW7kSXOu+1/Ky65okwRALojbz0
iItRGZK0yo5NpUzYfAsfV8I009BbGxhrThgKEHpDRisCDz10NLq9xOTrdLjRqxDThXQLrY
dk/nit3rnn/IkGRRzJYsK3KOL9eRKH1QcaslRXd7Kwcv9lIDJG707dxQYp1Zn49fiOyl78
sE0Tci4RD1JqcgmP4wKAXnungfISejTIxZeKfRJL3X3C98PYEcey+zLyzmS3VUsQWDKp8z
bHrzInTFfxiav2g3tgegmdTOnpck5DjZTpcYdoM14AczpufZgMXsQYkK1vUCtg==
From: Damien Cassou <cassou@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; Filling jsdoc text doesn't work in js-ts-mode
X-Debbugs-Cc:
Date: Mon, 24 Jun 2024 21:28:28 +0200
Message-ID: <875xtyxhr7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Last-TLS-Session-Version: TLSv1.3
Received-SPF: pass client-ip=2001:910:1410:501::1;
envelope-from=damien@HIDDEN; helo=mail.reprendre.net
X-Spam_score_int: -8
X-Spam_score: -0.9
X-Spam_bar: /
X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_NXDOMAIN=0.9,
DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Tue, 25 Jun 2024 01:58:19 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
--=-=-=
Content-Type: text/plain
Hi,
in a commit recently merged in master (0edacf2aa7e53), js-ts-mode has
been improved to use the jsdoc treesitter grammar on documentation. Font
lock works great but M-q doesn't fill long lines.
To reproduce, make sure your Emacs contains the above-mentioned commit
and make sure you have the jsdoc treesitter grammar available. Then,
save the attached JavaScript file to your disk and execute:
$ emacs -Q --eval "(progn (find-file \"/home/cassou/tmp/test.js\") (js-ts-mode))"
Move point to the middle of line 2 (or line 4) and press M-q.
Expected: The paragraph is filled.
Actual: Nothing changes.
I tried changing the value of `c-ts-common--comment-regexp' to include
"description" (as this is what the jsdoc parser uses for text) but the
result is worse. I also tried reusing `js-fill-paragraph' but that fails
as well.
I would be happy to implement something and send a patch but I have no
idea were to start.
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
--=-=-=
Content-Type: text/javascript
Content-Disposition: attachment; filename=test.js
/**
* Test. rat art srs tr tr st rst artsar t arstienartsioenaroti eanrtsoi aerntso iaerst
*
* @param {string} bla - Some documentation of this parameter. ar tar star tsa rst arstar st arst art rs
*/
function f(bla) {
}
--=-=-=--
Damien Cassou <cassou@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#71768; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.