GNU bug report logs - #71771
31.0.50; [PATCH] php-ts-mode: jsdoc support in javascript

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71771 in the body.
You can then email your comments to 71771 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [PATCH] php-ts-mode: jsdoc support in javascript
Date: Tue, 25 Jun 2024 11:52:20 +0200

[Message part 1 (text/plain, inline)]

Hi, 
this patch add support for embedding jsdoc into inline javascript element.

Thanks

Vincenzo

p.s. Damien's patch broke php-ts-mode if jsdoc parser is not installed.

[0001-Add-jsdoc-support-to-php-ts-mode-in-script-element.patch (text/x-patch, attachment)]

Message #8 received at 71771 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 71771 <at> debbugs.gnu.org
Subject: Re: bug#71771: 31.0.50;
 [PATCH] php-ts-mode: jsdoc support in javascript
Date: Thu, 27 Jun 2024 12:45:54 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Date: Tue, 25 Jun 2024 11:52:20 +0200
> 
> this patch add support for embedding jsdoc into inline javascript element.

Thanks, but is this for the master branch or for the emacs-30 release
branch?  Where was php-ts-mode broken?

Message #11 received at 71771 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71771 <at> debbugs.gnu.org
Subject: Re: bug#71771: 31.0.50;
 [PATCH] php-ts-mode: jsdoc support in javascript
Date: Thu, 27 Jun 2024 12:29:40 +0200

In data giovedì 27 giugno 2024 11:45:54 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Date: Tue, 25 Jun 2024 11:52:20 +0200
> > 
> > this patch add support for embedding jsdoc into inline javascript element.
> 
> Thanks, but is this for the master branch or for the emacs-30 release
> branch?  Where was php-ts-mode broken?
Hi Eli, 
this is for the master branch.
jsdoc is not available in emacs-30. 
Thanks.
V.

Message #14 received at 71771 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71771 <at> debbugs.gnu.org
Subject: Re: bug#71771: 31.0.50;
 [PATCH] php-ts-mode: jsdoc support in javascript
Date: Thu, 27 Jun 2024 21:44:59 +0200

[Message part 1 (text/plain, inline)]

In data giovedì 27 giugno 2024 12:29:40 CEST, Vincenzo Pupillo ha scritto:
> In data giovedì 27 giugno 2024 11:45:54 CEST, Eli Zaretskii ha scritto:
> > > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > > Date: Tue, 25 Jun 2024 11:52:20 +0200
> > > 
> > > this patch add support for embedding jsdoc into inline javascript
> > > element.
> > 
> > Thanks, but is this for the master branch or for the emacs-30 release
> > branch?  Where was php-ts-mode broken?
> 
> Hi Eli,
> this is for the master branch.
> jsdoc is not available in emacs-30.
> Thanks.
> V.
php-ts-mode was broken because the js--treesit-font-lock-settings variable now 
contains rules for jsdoc, a parser that php-ts-mode did not use.
I fixed the patch because, as I wrote for bug 71776, the jsdoc parser is 
local, just like the phpdoc parser.
 The screenshot I attach is the result of this patch and the two from bug 
71776.

Thanks.
Vincenzo

[0001-Add-jsdoc-support-to-php-ts-mode-in-script-element.patch (text/x-patch, attachment)]

[php_with_jsdoc_20240627_152341.png (image/png, attachment)]

Message #17 received at 71771 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 71771 <at> debbugs.gnu.org
Subject: Re: bug#71771: 31.0.50; [PATCH] php-ts-mode: jsdoc support in
 javascript
Date: Fri, 28 Jun 2024 03:52:41 +0300

On 27/06/2024 13:29, Vincenzo Pupillo wrote:
> this is for the master branch.
> jsdoc is not available in emacs-30.

To be clear, js-ts-mode's jsdoc integration is in emacs-30.

Message #20 received at 71771 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 71771 <at> debbugs.gnu.org
Subject: Re: bug#71771: 31.0.50;
 [PATCH] php-ts-mode: jsdoc support in javascript
Date: Fri, 28 Jun 2024 10:00:30 +0200

In data venerdì 28 giugno 2024 02:52:41 CEST, Dmitry Gutov ha scritto:
> On 27/06/2024 13:29, Vincenzo Pupillo wrote:
> > this is for the master branch.
> > jsdoc is not available in emacs-30.
> 
> To be clear, js-ts-mode's jsdoc integration is in emacs-30.
> 
Whoops, I missed it.
This patch also works with emacs-30.

Thanks.
Vincenzo

Message #25 received at 71771-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: dmitry <at> gutov.dev, 71771-done <at> debbugs.gnu.org
Subject: Re: bug#71771: 31.0.50;
 [PATCH] php-ts-mode: jsdoc support in javascript
Date: Sat, 29 Jun 2024 15:09:24 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: 71771 <at> debbugs.gnu.org
> Date: Fri, 28 Jun 2024 10:00:30 +0200
> 
> In data venerdì 28 giugno 2024 02:52:41 CEST, Dmitry Gutov ha scritto:
> > On 27/06/2024 13:29, Vincenzo Pupillo wrote:
> > > this is for the master branch.
> > > jsdoc is not available in emacs-30.
> > 
> > To be clear, js-ts-mode's jsdoc integration is in emacs-30.
> > 
> Whoops, I missed it.
> This patch also works with emacs-30.

Thanks, installed on emacs-30, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.