GNU bug report logs - #71793
[PATCH] ui: Write down the unwritten rule.

Previous Next

To reply to this bug, email your comments to 71793 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] ui: Write down the unwritten rule.
Date: Thu, 27 Jun 2024 13:44:10 +0200

Quote from Ludovic:

> [..] there’s the unwritten rule that non-UI modules should not load (guix
> ui) [..]

This commit turns it into a written rule.

* guix/ui.scm: Document the import policy.

Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
---
 guix/ui.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/ui.scm b/guix/ui.scm
index d82fa533cc..d24886d156 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -35,6 +35,10 @@
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
+;;; !!!!
+;;; !!!! This module shall not be imported from non-UI modules.
+;;; !!!!
+
 (define-module (guix ui)
   #:use-module (guix i18n)
   #:use-module (guix colors)
-- 
2.45.1

Message #8 received at 71793 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 71793 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: Re: [PATCH] ui: Write down the unwritten rule.
Date: Sat, 29 Jun 2024 01:47:52 -0500

> Quote from Ludovic:
> 

Hi Tomas,

Can you link me to the places where you are quoting that from? Thanks!

all best,

jgart

Message #11 received at 71793 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: jgart <jgart <at> dismail.de>
Cc: 71793 <at> debbugs.gnu.org
Subject: Re: [PATCH] ui: Write down the unwritten rule.
Date: Sat, 29 Jun 2024 20:43:35 +0200

[Message part 1 (text/plain, inline)]

On 2024-06-29 01:47:52 -0500, jgart wrote:
>
> > Quote from Ludovic:
> >
>
> Hi Tomas,
>
> Can you link me to the places where you are quoting that from? Thanks!

Yes sure, it was given as a reason to not merge patch #2 in 70839:
  https://issues.guix.gnu.org/70839#4-lineno17

It is always possible I just misunderstood.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 71793-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, 71793-done <at> debbugs.gnu.org,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#71793] [PATCH] ui: Write down the unwritten rule.
Date: Wed, 04 Sep 2024 15:56:12 +0200

Hi,

Tomas Volf <~@wolfsden.cz> skribis:

> Quote from Ludovic:
>
>> [..] there’s the unwritten rule that non-UI modules should not load (guix
>> ui) [..]
>
> This commit turns it into a written rule.
>
> * guix/ui.scm: Document the import policy.
>
> Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2

I committed a variant of this patch, thanks.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.