GNU bug report logs -
#71793
[PATCH] ui: Write down the unwritten rule.
Previous Next
Reported by: Tomas Volf <~@wolfsden.cz>
Date: Thu, 27 Jun 2024 11:45:01 UTC
Severity: normal
Tags: patch
Done: Ludovic Courtès <ludo <at> gnu.org>
To reply to this bug, email your comments to 71793 AT debbugs.gnu.org.
There is no need to reopen the bug first.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix <at> cbaines.net, dev <at> jpoiret.xyz, ludo <at> gnu.org, othacehe <at> gnu.org, zimon.toutoune <at> gmail.com, me <at> tobias.gr, guix-patches <at> gnu.org
:
bug#71793
; Package
guix-patches
.
(Thu, 27 Jun 2024 11:45:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Tomas Volf <~@wolfsden.cz>
:
New bug report received and forwarded. Copy sent to
guix <at> cbaines.net, dev <at> jpoiret.xyz, ludo <at> gnu.org, othacehe <at> gnu.org, zimon.toutoune <at> gmail.com, me <at> tobias.gr, guix-patches <at> gnu.org
.
(Thu, 27 Jun 2024 11:45:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Quote from Ludovic:
> [..] there’s the unwritten rule that non-UI modules should not load (guix
> ui) [..]
This commit turns it into a written rule.
* guix/ui.scm: Document the import policy.
Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
---
guix/ui.scm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/guix/ui.scm b/guix/ui.scm
index d82fa533cc..d24886d156 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -35,6 +35,10 @@
;;; You should have received a copy of the GNU General Public License
;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+;;; !!!!
+;;; !!!! This module shall not be imported from non-UI modules.
+;;; !!!!
+
(define-module (guix ui)
#:use-module (guix i18n)
#:use-module (guix colors)
--
2.45.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#71793
; Package
guix-patches
.
(Sat, 29 Jun 2024 06:49:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 71793 <at> debbugs.gnu.org (full text, mbox):
> Quote from Ludovic:
>
Hi Tomas,
Can you link me to the places where you are quoting that from? Thanks!
all best,
jgart
Information forwarded
to
guix-patches <at> gnu.org
:
bug#71793
; Package
guix-patches
.
(Sat, 29 Jun 2024 21:10:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 71793 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 2024-06-29 01:47:52 -0500, jgart wrote:
>
> > Quote from Ludovic:
> >
>
> Hi Tomas,
>
> Can you link me to the places where you are quoting that from? Thanks!
Yes sure, it was given as a reason to not merge patch #2 in 70839:
https://issues.guix.gnu.org/70839#4-lineno17
It is always possible I just misunderstood.
Have a nice day,
Tomas Volf
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Ludovic Courtès <ludo <at> gnu.org>
:
You have taken responsibility.
(Wed, 04 Sep 2024 13:58:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Tomas Volf <~@wolfsden.cz>
:
bug acknowledged by developer.
(Wed, 04 Sep 2024 13:58:02 GMT)
Full text and
rfc822 format available.
Message #16 received at 71793-done <at> debbugs.gnu.org (full text, mbox):
Hi,
Tomas Volf <~@wolfsden.cz> skribis:
> Quote from Ludovic:
>
>> [..] there’s the unwritten rule that non-UI modules should not load (guix
>> ui) [..]
>
> This commit turns it into a written rule.
>
> * guix/ui.scm: Document the import policy.
>
> Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
I committed a variant of this patch, thanks.
Ludo’.
This bug report was last modified 3 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.