GNU bug report logs - #71796
[PATCH] Do not depend on tmpnam in posix.test.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 27 Jun 2024 13:44:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 27 09:44:12 2024
Received: from localhost ([127.0.0.1]:41315 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sMpQ4-0001X7-FV
	for submit <at> debbugs.gnu.org; Thu, 27 Jun 2024 09:44:12 -0400
Received: from lists.gnu.org ([209.51.188.17]:33718)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <~@wolfsden.cz>) id 1sMpQ2-0001Wz-Er
 for submit <at> debbugs.gnu.org; Thu, 27 Jun 2024 09:44:10 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sMpPz-0004bx-81
 for bug-guile@HIDDEN; Thu, 27 Jun 2024 09:44:07 -0400
Received: from wolfsden.cz ([37.205.8.62])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sMpPw-0007sH-UJ
 for bug-guile@HIDDEN; Thu, 27 Jun 2024 09:44:06 -0400
Received: by wolfsden.cz (Postfix, from userid 104)
 id 8ECB12A8732; Thu, 27 Jun 2024 13:44:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1719495841; bh=xiIzO1bMtvZnR6hCg8nJFgf3VS4wt7ZXD1lNBJm7l6o=;
 h=From:To:Cc:Subject:Date;
 b=QMZS1PuJOLVv5b0kpa6VTWJ8may9jsh1VbxywgL1bg88YTTA3VquGMj2PVbrsP5wb
 IFdC1KlaOxLAXHPUIHm3PbrBm1dPxhJhNqJ/dzHOc0bt7r7iMErDjPeLxRzjddXgK2
 XK/AqSkS4Ly8y440fjPnLx4aCk0+J/hzy0DBC1bVW3A39WpPshXZEOyZEz8hrFWfl8
 7/9NaBvkSnNqPESRSAo/xgbpPK4bltvUoq8H3PKNgF0iCuOyECGQGkNw94V1/0X0hY
 o+NISbqw9CCFLLk0rhIY62tQ5jcFnOwY9FzYYEoYsM8K2JY3kXHxQfmRUohbHO1gpx
 UfZ7lzeatAPwBNauLrppliffKhXfhUmFW4473XnbtRE+IV6LT/7OqgFlbuQZkXvWxe
 AOgZxdVOvb1AvewHvtAnxuZYMguYvvyEqH1qWHMnLtfivz/lhvYaDAlJYLBgAN9aPG
 GGbvW7VsG0OMsIBWxCAnBhBTDFzPCDUOhT9H8Vkm+thXdQ0nZEmV4UUsbkbkip2UXy
 b4NJZ9ehDZ1Dn9dicRCRTR8jA+u1HwAfpVhnGrBjdwt5hVMnzY1u8CzXqJLizFl+lI
 K0QjioT5KuIF/9zXyVL8Yn14kB1AnxQCy54qounIRxLC+IDUUX7BR3I6ut3+zGCsf3
 dvn088ZDHCRNdY9XmmJK0/gA=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
 autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
 by wolfsden.cz (Postfix) with ESMTPSA id 264542A8428;
 Thu, 27 Jun 2024 13:44:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1719495841; bh=xiIzO1bMtvZnR6hCg8nJFgf3VS4wt7ZXD1lNBJm7l6o=;
 h=From:To:Cc:Subject:Date;
 b=QMZS1PuJOLVv5b0kpa6VTWJ8may9jsh1VbxywgL1bg88YTTA3VquGMj2PVbrsP5wb
 IFdC1KlaOxLAXHPUIHm3PbrBm1dPxhJhNqJ/dzHOc0bt7r7iMErDjPeLxRzjddXgK2
 XK/AqSkS4Ly8y440fjPnLx4aCk0+J/hzy0DBC1bVW3A39WpPshXZEOyZEz8hrFWfl8
 7/9NaBvkSnNqPESRSAo/xgbpPK4bltvUoq8H3PKNgF0iCuOyECGQGkNw94V1/0X0hY
 o+NISbqw9CCFLLk0rhIY62tQ5jcFnOwY9FzYYEoYsM8K2JY3kXHxQfmRUohbHO1gpx
 UfZ7lzeatAPwBNauLrppliffKhXfhUmFW4473XnbtRE+IV6LT/7OqgFlbuQZkXvWxe
 AOgZxdVOvb1AvewHvtAnxuZYMguYvvyEqH1qWHMnLtfivz/lhvYaDAlJYLBgAN9aPG
 GGbvW7VsG0OMsIBWxCAnBhBTDFzPCDUOhT9H8Vkm+thXdQ0nZEmV4UUsbkbkip2UXy
 b4NJZ9ehDZ1Dn9dicRCRTR8jA+u1HwAfpVhnGrBjdwt5hVMnzY1u8CzXqJLizFl+lI
 K0QjioT5KuIF/9zXyVL8Yn14kB1AnxQCy54qounIRxLC+IDUUX7BR3I6ut3+zGCsf3
 dvn088ZDHCRNdY9XmmJK0/gA=
From: Tomas Volf <~@wolfsden.cz>
To: bug-guile@HIDDEN
Subject: [PATCH] Do not depend on tmpnam in posix.test.
Date: Thu, 27 Jun 2024 15:43:35 +0200
Message-ID: <20240627134335.26287-1-~@wolfsden.cz>
X-Mailer: git-send-email 2.45.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
 helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Tomas Volf <~@wolfsden.cz>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

`tmpnam' is a deprecated procedure that can be excluded during a
configure (`--disable-tmpnam').  There currently was a single test
relying on it, and therefore failing is such configuration.  This commit
switches to mkstemp instead.

* test-suite/tests/posix.test ("system*"): Use mkstemp instead of
tmpnam.
---
 test-suite/tests/posix.test | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/test-suite/tests/posix.test b/test-suite/tests/posix.test
index 18dad8902..0d75eb145 100644
--- a/test-suite/tests/posix.test
+++ b/test-suite/tests/posix.test
@@ -362,7 +362,8 @@
 
   (pass-if-equal "https://bugs.gnu.org/52835"
       "bong\n"
-    (let ((file (tmpnam)))
+    (let* ((port (mkstemp "T-XXXXXX"))
+           (file (port-filename port)))
       ;; Redirect stdout and stderr to FILE.
       (define status
         (call-with-output-file file
@@ -373,8 +374,9 @@
                   (lambda ()
                     (system* "sh" "-c" "echo bong >&2"))))))))
 
+      (delete-file file)
       (and (zero? (status:exit-val status))
-           (call-with-input-file file get-string-all))))
+           (get-string-all port))))
 
   (pass-if-equal "https://bugs.gnu.org/63024"
       0
-- 
2.45.1