GNU bug report logs - #71824
[PATCH] import: go: Fix indentation in help message.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71824 in the body.
You can then email your comments to 71824 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: guix-patches <at> gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: [PATCH] import: go: Fix indentation in help message.
Date: Fri, 28 Jun 2024 12:14:50 -0400

* guix/scripts/import/go.scm (show-help) <recursive>: Indent second line.

Change-Id: Iad096231e26ed4e0e1c584f92e43f2695a2d8682
---
 guix/scripts/import/go.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/scripts/import/go.scm b/guix/scripts/import/go.scm
index f1970d3543..b90c6ac72f 100644
--- a/guix/scripts/import/go.scm
+++ b/guix/scripts/import/go.scm
@@ -51,7 +51,7 @@ (define (show-help)
   -h, --help             display this help and exit"))
   (display (G_ "
   -r, --recursive        generate package expressions for all Go modules
-that are not yet in Guix"))
+                         that are not yet in Guix"))
   (display (G_ "
   -p, --goproxy=GOPROXY  specify which goproxy server to use"))
   (display (G_ "

base-commit: 78b881722f08325c76096557313a0faee847c66f
-- 
2.45.1

Message #8 received at 71824 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 71824 <at> debbugs.gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: Re: [PATCH] import: go: Fix indentation in help message.
Date: Fri, 28 Jun 2024 20:08:17 -0500

I'll let someone else comment on this since I'm not sure what our policy
is on indentation at the moment.

all best,

jgart

Message #11 received at 71824 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 71824 <at> debbugs.gnu.org
Subject: [PATCH] import: go: Fix indentation in help message.
Date: Mon, 01 Jul 2024 21:53:30 +0100

[Message part 1 (text/plain, inline)]

Hi,

The change looks reasonable while comparing other importer' help:

--8<---------------cut here---------------start------------->8---
(guix/linux-gnu)[sharlatan <at> guxtil ~/code/guix]$: guix import cran --help
Usage: guix import cran PACKAGE-NAME
Import and convert the CRAN package for PACKAGE-NAME.

  -a, --archive=ARCHIVE  specify the archive repository
  -h, --help             display this help and exit
  -r, --recursive        import packages recursively
  -s, --style=STYLE      choose output style, either specification or variable
  -p, --license-prefix=PREFIX
                         add custom prefix to licenses
  -V, --version          display version information and exit

Report bugs to: bug-guix <at> gnu.org.
GNU Guix home page: <https://guix.gnu.org>
General help using Guix and GNU software: <https://guix.gnu.org/en/help/>
(guix/linux-gnu)[sharlatan <at> guxtil ~/code/guix]$: guix import pypi --help
Usage: guix import pypi PACKAGE-NAME
Import and convert the PyPI package for PACKAGE-NAME.

  -h, --help             display this help and exit
  -r, --recursive        import packages recursively
  -V, --version          display version information and exit

Report bugs to: bug-guix <at> gnu.org.
GNU Guix home page: <https://guix.gnu.org>
General help using Guix and GNU software: <https://guix.gnu.org/en/help/>
(guix/linux-gnu)[sharlatan <at> guxtil ~/code/guix]$: guix import go --help
Usage: guix import go PACKAGE-PATH[@VERSION]
Import and convert the Go module for PACKAGE-PATH.  Optionally, a version
can be specified after the arobas (@) character.

  -h, --help             display this help and exit
  -r, --recursive        generate package expressions for all Go modules
that are not yet in Guix
  -p, --goproxy=GOPROXY  specify which goproxy server to use
  --pin-versions         use the exact versions of a module's dependencies

Report bugs to: bug-guix <at> gnu.org.
GNU Guix home page: <https://guix.gnu.org>
--8<---------------cut here---------------end--------------->8---

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 71824 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 71824 <at> debbugs.gnu.org
Subject: [PATCH] import: go: Fix indentation in help message.
Date: Mon, 01 Jul 2024 21:55:37 +0100

[Message part 1 (text/plain, inline)]

And after applying patch locally:

--8<---------------cut here---------------start------------->8---
> ./pre-inst-env guix import go --help
Usage: guix import go PACKAGE-PATH[@VERSION]
Import and convert the Go module for PACKAGE-PATH.  Optionally, a version
can be specified after the arobas (@) character.

  -h, --help             display this help and exit
  -r, --recursive        generate package expressions for all Go modules
                         that are not yet in Guix
  -p, --goproxy=GOPROXY  specify which goproxy server to use
  --pin-versions         use the exact versions of a module's dependencies

Report bugs to: bug-guix <at> gnu.org.
GNU Guix home page: <https://www.gnu.org/software/guix/>
General help using Guix and GNU software: <https://guix.gnu.org/en/help/>
--8<---------------cut here---------------end--------------->8---

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 71824-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 71824-done <at> debbugs.gnu.org
Subject: [PATCH] import: go: Fix indentation in help message.
Date: Mon, 01 Jul 2024 21:59:55 +0100

[Message part 1 (text/plain, inline)]

Pushed as 69089674bb9fb2cc7b3285b73fb7dda7d99a2550 to master.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.