GNU bug report logs - #71870
Some broken Go packages (including Podman)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71870 in the body.
You can then email your comments to 71870 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nils Landt <nils <at> landt.email>
To: "bug-guix <at> gnu.org" <bug-guix <at> gnu.org>
Subject: Some broken Go packages (including Podman)
Date: Mon, 1 Jul 2024 09:35:08 +0200 (CEST)

[Message part 1 (text/plain, inline)]

Building the new Podman package fails because building a depdency (gvisor-tap-vsock) fails:
 
The following derivation will be built:
/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv
building /gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv...
WARNING: (guile-user): imported module (guix build utils) overrides core binding `delete'
Backtrace:
16 (primitive-load "/gnu/store/2a9k7v2qhydivh63xv921gr6kp9?")
In ice-9/eval.scm:
214:21 15 (_ #f)
217:50 14 (lp (#<procedure 7ffff77ff680 at ice-9/eval.scm:282:?> ?))
217:50 13 (lp (#<procedure 7ffff77ff660 at ice-9/eval.scm:282:?> ?))
217:50 12 (lp (#<procedure 7ffff77ff640 at ice-9/eval.scm:282:?> ?))
217:50 11 (lp (#<procedure 7ffff77ff620 at ice-9/eval.scm:282:?> ?))
217:50 10 (lp (#<procedure 7ffff77ff5c0 at ice-9/eval.scm:649:?> ?))
217:50 9 (lp (#<procedure 7ffff77ff580 at ice-9/eval.scm:282:?> ?))
217:50 8 (lp (#<procedure 7ffff77ff520 at ice-9/eval.scm:649:?> ?))
217:50 7 (lp (#<procedure 7ffff77ff500 at ice-9/eval.scm:282:?> ?))
217:50 6 (lp (#<procedure 7ffff77ff4c0 at ice-9/eval.scm:282:?> ?))
217:50 5 (lp (#<procedure 7ffff77ff4a0 at ice-9/eval.scm:282:?> ?))
217:33 4 (lp (#<procedure 7ffff77ff0a0 at ice-9/eval.scm:649:?> ?))
293:34 3 (_ #(#(#(#(#(#<directory (guile-user) 7f?> ?) ?) ?) ?) ?))
173:55 2 (_ #(#(#(#(#(#<directory (guile-user) 7f?> ?) ?) ?) ?) ?))
223:20 1 (proc #(#(#(#(#(#<directory (guile-user)?> ?) ?) ?) ?) ?))
In unknown file:
0 (%resolve-variable (5 (guix build go-build-system) . #) #)
ERROR: In procedure %resolve-variable:
In procedure module-lookup: Unbound variable: remove-go-references
builder for `/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv' failed with exit code 1
build of /gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv failed
View build log at '/var/log/guix/drvs/4l/zcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv.gz'.
guix build: error: build of `/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv' failed
error: Recipe `guix` failed on line 13 with exit code 1
 
It looks to me like 0df957eecc536e1d0a5722b47dda1563439bbe04 removed remove-go-references, but it is still used by podman, gvisor-tap-vsock, and buildah.
 
--
Nils Landt

[Message part 2 (text/html, inline)]

Message #8 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 71870 <at> debbugs.gnu.org
Cc: Nils Landt <nils <at> landt.email>
Subject: Re: Some broken Go packages (including Podman)
Date: Mon, 01 Jul 2024 09:35:32 -0500

> Building the new Podman package fails because building a depdency
> (gvisor-tap-vsock) fails:

Hi Nils,

Would you be interested in sending patches to fix these failures?
-- 
all the best,
jgart

Message #11 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: Nils Landt <nils <at> landt.email>
To: jgart <jgart <at> dismail.de>, 71870 <at> debbugs.gnu.org
Subject: Re: Some broken Go packages (including Podman)
Date: Mon, 1 Jul 2024 16:43:54 +0200 (CEST)

> jgart <jgart <at> dismail.de> hat am 01.07.2024 16:35 CEST geschrieben:
> 
>  
> > Building the new Podman package fails because building a depdency
> > (gvisor-tap-vsock) fails:
> 
> Hi Nils,
> 
> Would you be interested in sending patches to fix these failures?

No, the patch submission process is too annoying for me.

Message #14 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Nils Landt" <nils <at> landt.email>, 71870 <at> debbugs.gnu.org
Subject: Re: Some broken Go packages (including Podman)
Date: Mon, 01 Jul 2024 17:04:08 +0000

> No, the patch submission process is too annoying for me.
>

Hi Nils,

Sorry to hear that. I can relate to that as I've also been annoyed by aspects of the process.

Can you share some of the pain points that you've experienced with the patch submission process?

This will help us potentially address that and open discussion around it.

How do you think that the patch submission process can be improved?

I'm going to give a talk in August at the Guix London meetup on patch review, the mumi CLI tool, and my current personal workflow.

TBA,

jgart

Message #17 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: Nils Landt <nils <at> landt.email>
To: jgart <jgart <at> dismail.de>, 71870 <at> debbugs.gnu.org
Subject: Re: Some broken Go packages (including Podman)
Date: Tue, 2 Jul 2024 08:20:42 +0200 (CEST)

> jgart <jgart <at> dismail.de> hat am 01.07.2024 19:04 CEST geschrieben:
> 
>  
> > No, the patch submission process is too annoying for me.
> >
> 
> Hi Nils,
> 
> Sorry to hear that. I can relate to that as I've also been annoyed by aspects of the process.
> 
> Can you share some of the pain points that you've experienced with the patch submission process?
> 
> This will help us potentially address that and open discussion around it.
>
> How do you think that the patch submission process can be improved?
 
Nothing that hasn't been talked about for years, really.

- Patch submission workflow without email
- Code review tool with threaded at-code conversations
- Code formatter that I can make work for vim (i.e. guix style for non-packages)
- Useful commit messages instead of GNU ChangeLog

My previous attempt at contribution (https://issues.guix.gnu.org/66557) was quite unpleasant.
I don't know how to phrase my critique of the reviewers in a constructive manner, given that I respect we're all human beings volunteering time for this hobby.
 
> I'm going to give a talk in August at the Guix London meetup on patch review, the mumi CLI tool, and my current personal workflow.

I will be watching the recording, but I don't see how it would address my wishlist :)

Message #20 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: woshilapin <woshilapin <at> tuziwo.info>
To: "71870 <at> debbugs.gnu.org" <71870 <at> debbugs.gnu.org>
Cc: "nils <at> landt.email" <nils <at> landt.email>,
 "jgart <at> dismail.de" <jgart <at> dismail.de>
Subject: Re: Some broken Go packages (including Podman)
Date: Tue, 02 Jul 2024 10:03:00 +0000

Hi Nils, hi jgart,

> Building the new Podman package fails because building a depdency
> (gvisor-tap-vsock) fails:
> <...>
> It looks to me like 0df957eecc536e1d0a5722b47dda1563439bbe04 removed
> remove-go-references, but it is still used by podman,
> gvisor-tap-vsock, and buildah.

You might be interested in this other issue that links to some
interesting content related to the removal of `remove-go-references`,
especially the following comment.

https://issues.guix.gnu.org/71852#1

Sincerely,
--
Jean SIMARD aka woshilapin

Message #23 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "woshilapin" <woshilapin <at> tuziwo.info>, 71870 <at> debbugs.gnu.org
Cc: nils <at> landt.email
Subject: Re: Some broken Go packages (including Podman)
Date: Tue, 02 Jul 2024 15:16:03 +0000

Thanks for the link. I'll take a look

all best,

jgart

Message #26 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus Diaz <jean <at> foundation.xyz>
To: 71870 <at> debbugs.gnu.org
Cc: woshilapin <at> tuziwo.info, nils <at> landt.email, jgart <at> dismail.de
Subject: Re: Some broken Go packages (including Podman)
Date: Wed, 3 Jul 2024 16:40:04 +0000

Hello,

I've sent a few patches in <https://issues.guix.gnu.org/71923> to fix
the build of these
packages and also updates podman to latest version.

Cheers,

Message #29 received at 71870 <at> debbugs.gnu.org (full text, mbox):

From: Nils Landt <nils <at> landt.email>
To: Jean-Pierre De Jesus Diaz <jean <at> foundation.xyz>, 71870 <at> debbugs.gnu.org
Subject: Re: Some broken Go packages (including Podman)
Date: Thu, 4 Jul 2024 08:51:31 +0200 (CEST)

> Jean-Pierre De Jesus Diaz <jean <at> foundation.xyz> hat am 03.07.2024 18:40 CEST geschrieben:
> 
>  
> Hello,
> 
> I've sent a few patches in <https://issues.guix.gnu.org/71923> to fix
> the build of these
> packages and also updates podman to latest version.
> 
> Cheers,

Thank you very much Jean-Pierre.

Message #34 received at 71870-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 71870-done <at> debbugs.gnu.org
Subject: Some broken Go packages (including Podman)
Date: Fri, 12 Jul 2024 16:34:56 +0100

[Message part 1 (text/plain, inline)]

Hi,

Closing as resovled in other mentioned issues.

Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.