GNU bug report logs - #71877
Three spaces for error messages instead of one

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71877 in the body.
You can then email your comments to 71877 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: bug-gnulib <at> gnu.org
Cc: bug-libtool <at> gnu.org
Subject: Three spaces for error messages instead of one
Date: Mon, 1 Jul 2024 18:39:04 +0300

[Message part 1 (text/plain, inline)]

Hi,

It was reported [1] that error messages from a libtool invocation have
additional spaces after the package name before the error message. After
looking into this, it seems that gnulib-modules/bootstrap is the cause.

Here is an example:
libtool:   error: only absolute run-paths are allowed

Here is the relevant code in bootstrap:
```
# func_error ARG...
# -----------------
# Echo program name prefixed message to standard error.
func_error ()
{
    $debug_cmd

    $require_term_colors

    func_echo_infix_1 "  $tc_standout${tc_red}error$tc_reset" "$*" >&2
}


# func_fatal_error ARG...
# -----------------------
# Echo program name prefixed message to standard error, and exit.
func_fatal_error ()
{
    $debug_cmd

    func_error "$*"
    exit $EXIT_FAILURE
}
```

Is there a reason for the extra spacing, or could this be changed?

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71595

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>, bug-gnulib <at> gnu.org
Cc: bug-libtool <at> gnu.org
Subject: Re: Three spaces for error messages instead of one
Date: Mon, 01 Jul 2024 19:10:53 +0200

Hi Ileana,

> Here is the relevant code in bootstrap:
> ```
> # func_error ARG...
> # -----------------
> # Echo program name prefixed message to standard error.
> func_error ()
> {
>      $debug_cmd
> 
>      $require_term_colors
> 
>      func_echo_infix_1 "  $tc_standout${tc_red}error$tc_reset" "$*" >&2
> }

This code doesn't exist in gnulib's 'bootstrap'.

Note that there are several variants/forks of 'bootstrap':
  - The one created by Paul Eggert and maintained in gnulib.
  - The one by Gary Vaughan https://github.com/gvvaughan/bootstrap
  - A fork of that, by Gary Vaughan, Pavel Raiskup, Reuben Thomas
    https://github.com/gnulib-modules/bootstrap
    This is the one used by GNU libtool and GNU m4.

libtool's ltmain.sh includes this function. ltmain.sh is generated
from ltmain.in, funclib.sh, and options-parser; the latter two come
from https://github.com/gnulib-modules/bootstrap .

Bruno

Message #13 received at 71877-done <at> debbugs.gnu.org (full text, mbox):

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: Bruno Haible <bruno <at> clisp.org>, bug-gnulib <at> gnu.org
Cc: 71877-done <at> debbugs.gnu.org
Subject: Re: bug#71877: Three spaces for error messages instead of one
Date: Mon, 1 Jul 2024 20:44:09 +0300

[Message part 1 (text/plain, inline)]

Hi Bruno,

On 01/07/2024 20:10, Bruno Haible wrote:
> Hi Ileana,
> 
>> Here is the relevant code in bootstrap:
>> ```
>> # func_error ARG...
>> # -----------------
>> # Echo program name prefixed message to standard error.
>> func_error ()
>> {
>>       $debug_cmd
>>
>>       $require_term_colors
>>
>>       func_echo_infix_1 "  $tc_standout${tc_red}error$tc_reset" "$*" >&2
>> }
> 
> This code doesn't exist in gnulib's 'bootstrap'.
> 
> Note that there are several variants/forks of 'bootstrap':
>    - The one created by Paul Eggert and maintained in gnulib.
>    - The one by Gary Vaughan https://github.com/gvvaughan/bootstrap
>    - A fork of that, by Gary Vaughan, Pavel Raiskup, Reuben Thomas
>      https://github.com/gnulib-modules/bootstrap
>      This is the one used by GNU libtool and GNU m4.
> 
> libtool's ltmain.sh includes this function. ltmain.sh is generated
> from ltmain.in, funclib.sh, and options-parser; the latter two come
> from https://github.com/gnulib-modules/bootstrap .
> 
> Bruno
> 

I am following Karl's advice to contact gnulib regarding this. Thank you
for the explanation. I know the bootstrap used by libtool is maintained
on Github. I referenced gnulib-modules/bootstrap [1] in the bug report,
but I should have added in the link for clarity.

I also assumed gnulib would be the correct place to contact for
understanding some design decisions with bootstrap, since it is under
the 'gnulib-modules' namespace. It seems this is wrong though. I will
close this here for now and ask about this issue on Github.

[1] https://github.com/gnulib-modules/bootstrap

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.