GNU bug report logs - #71882
[PATCH] gnu: librewolf: Fix building on aarch64-linux.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71882 in the body.
You can then email your comments to 71882 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: guix-patches <at> gnu.org
Cc: Remco van 't Veer <remco <at> remworks.net>
Subject: [PATCH] gnu: librewolf: Fix building on aarch64-linux.
Date: Mon,  1 Jul 2024 21:53:22 +0200

* gnu/packages/librewolf.scm (librewolf)[arguments]: On non-x86-linux systems the "--disable-eme" switch is not available because EME is not available.

Change-Id: I0f397570249b1bc6a0182d2744a8d3c459c1bafa
---
 gnu/packages/librewolf.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm
index c84bcaf3ce..892f12565d 100644
--- a/gnu/packages/librewolf.scm
+++ b/gnu/packages/librewolf.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2022 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2023 Tomas Volf <wolf <at> wolfsden.cz>
 ;;; Copyright © 2023 Ian Eure <ian <at> retrospec.tv>
+;;; Copyright © 2024 Remco van 't Veer <remco <at> remworks.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -261,7 +262,10 @@ (define-public librewolf
                               "--disable-crashreporter"
                               "--allow-addon-sideload"
                               "--with-unsigned-addon-scopes=app,system"
-                              "--disable-eme"
+
+                              ;; switch only available on x86 and EME not
+                              ;; supported on other targets
+                              ,@(if #$(target-x86?) '("--disable-eme") '())
 
                               ;; Build details
                               "--disable-debug"

base-commit: ba6460900f052759fe82e4ceb606d25e19f02884
-- 
2.45.1

Message #10 received at 71882-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 71882-done <at> debbugs.gnu.org, 71832 <at> debbugs.gnu.org
Subject: Closing one bug
Date: Mon, 8 Jul 2024 10:55:33 +0200

Hello,

I have pushed the patch of #71882 to fix the build on non-x86 architectures.
I could still build on x86_64, but could still not build on aarch64; but
the latter failure is probably due to a lack of memory (the configure phase
passes now, but the build fails later on with a SIGKILL).

As this means that the librewolf update of #71832 needs to be rebased,
I am cc-ing this bug.

Andreas

Message #13 received at 71882 <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: 71882 <at> debbugs.gnu.org
Cc: Andreas Enge <andreas <at> enge.fr>
Subject: Re: bug#71882: closed (Closing one bug)
Date: Mon, 08 Jul 2024 12:16:30 +0200

Hi Andreas,

Thanks for committing this.

2024/07/08, GNU bug Tracking System:

> I have pushed the patch of #71882 to fix the build on non-x86 architectures.
> I could still build on x86_64, but could still not build on aarch64; but
> the latter failure is probably due to a lack of memory (the configure phase
> passes now, but the build fails later on with a SIGKILL).

I tried to build it on the only ARM machine I have but indeed 8Gb of RAM
is not enough and this build dies with a OOM kill.  So I used a 22Gb x86
machine and qemu with offload build to get a working binary for my ARM
machine.  Happily browsing the internet with librwolf on my mnt reform
now.

Remco

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.