GNU bug report logs - #71886
Diffoscope test suite fails with openssh 9.8p1

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71886 in the body.
You can then email your comments to 71886 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: bug-guix <at> gnu.org
Subject: Diffoscope test suite fails with openssh 9.8p1
Date: Mon, 01 Jul 2024 17:50:20 -0400

Hi all,

With Guix 6522f93ed098fa13f51f6d017035607e26237d31 diffoscope's test
suite fails. I'm reporting this here in case we want to try to implement
some kind of workaround in the meantime.

Diffoscope does not seem to have an upstream issue opened yet. I tried
reporting it but was blocked by the classic "yet another gitlab account
that needs manual approval" problem. It's possible this problem is
unique to Guix though.

I tried upgrading Guix's Diffoscope to 271 and encountered the same
issue.

--8<---------------cut here---------------start------------->8---
=================================== FAILURES ===================================
__________________________________ test_diff ___________________________________

differences = []

    @skip_unless_tool_is_at_least("ssh-keygen", openssh_version, "6.9")
    def test_diff(differences):
        expected_diff = get_data("openssh_pub_key_expected_diff")
>       assert differences[0].unified_diff == expected_diff
E       IndexError: list index out of range

tests/comparators/test_openssh_pub_key.py:60: IndexError
__________________________ test_compare_non_existing ___________________________

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fffefd20190>
opensshpubkey1 = <<class 'abc.PublicKeyFile'> /tmp/guix-build-diffoscope-271.drv-0/source/tests/data/test_openssh_pub_key1.pub>

    @skip_unless_tools_exist("ssh-keygen")
    def test_compare_non_existing(monkeypatch, opensshpubkey1):
        monkeypatch.setattr(Config(), "new_file", True)
        difference = opensshpubkey1.compare(
            MissingFile("/nonexisting", opensshpubkey1)
        )
        assert difference.source2 == "/nonexisting"
>       assert len(difference.details) > 0
E       assert 0 > 0
E        +  where 0 = len([])
E        +    where [] = <Difference /tmp/guix-build-diffoscope-271.drv-0/source/tests/data/test_openssh_pub_key1.pub -- /nonexisting []>.details

tests/comparators/test_openssh_pub_key.py:70: AssertionError
--8<---------------cut here---------------end--------------->8---


-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.

Message #8 received at 71886 <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: 71886 <at> debbugs.gnu.org
Subject: Re: bug#71886: Diffoscope test suite fails with openssh 9.8p1
Date: Wed, 03 Jul 2024 18:31:09 -0400

Issue reported upstream at
https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/382.
Fixed in 0743d63f85f298131e78045ec6d73acdc50b97eb (confirmed) which will
likely be part of a 272 release.

-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.

Message #11 received at 71886 <at> debbugs.gnu.org (full text, mbox):

From: Kaelyn <kaelyn.alexi <at> protonmail.com>
To: "71886 <at> debbugs.gnu.org" <71886 <at> debbugs.gnu.org>
Subject: bug#71886: Diffoscope test suite fails with openssh 9.8p1
Date: Fri, 05 Jul 2024 00:06:05 +0000

Hi Richard,

I've encountered the diffoscope failure as well, and looked at their  repo to see how new version 271 was and what activity has happened since. It looks like they may have already fixed the test failures, pending a new release: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/0743d63f85f298131e78045ec6d73acdc50b97eb

Cheers,
Kaelyn

Message #14 received at 71886 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> reproducible-builds.org>
To: 71886 <at> debbugs.gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>,
 Kaelyn <kaelyn.alexi <at> protonmail.com>
Subject: Re: bug#71886: Diffoscope test suite fails with openssh 9.8p1
Date: Fri, 05 Jul 2024 12:13:36 -0700

[Message part 1 (text/plain, inline)]

On 2024-07-05, Kaelyn wrote:
> I've encountered the diffoscope failure as well, and looked at their
> repo to see how new version 271 was and what activity has happened
> since. It looks like they may have already fixed the test failures,
> pending a new release:
> https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/0743d63f85f298131e78045ec6d73acdc50b97eb

And 272 is tagged with hopefully minor other changes ... working on a
patch now!

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 71886-done <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> reproducible-builds.org>
To: 71886-done <at> debbugs.gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>,
 Kaelyn <kaelyn.alexi <at> protonmail.com>
Subject: Re: bug#71886: Diffoscope test suite fails with openssh 9.8p1
Date: Fri, 05 Jul 2024 12:28:53 -0700

[Message part 1 (text/plain, inline)]

On 2024-07-05, Vagrant Cascadian wrote:
> On 2024-07-05, Kaelyn wrote:
>> I've encountered the diffoscope failure as well, and looked at their
>> repo to see how new version 271 was and what activity has happened
>> since. It looks like they may have already fixed the test failures,
>> pending a new release:
>> https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/0743d63f85f298131e78045ec6d73acdc50b97eb
>
> And 272 is tagged with hopefully minor other changes ... working on a
> patch now!

Pushed as e725e47a695c82305fa65e63e54477c6a210f53d.

The upstream changes were very minor, essentially only fixing this one
issue triggering build failure and a few debian-specific changes, so
hopefully it was ok to just go ahead and push it.

Thanks for reporting the issue and pointing out the fix was in progress!

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.