GNU bug report logs - #71888
[PATCH] nnfeed: (Mostly) fix group descriptions

Previous Next

To reply to this bug, email your comments to 71888 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Semyonov <daniel <at> dsemy.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Tue, 02 Jul 2024 02:43:29 +0300

[Message part 1 (text/plain, inline)]

Tags: patch

Hi,

I realized a few days ago I barely tested group descriptions in nnatom
(and by extension nnfeed), and turns out they were in fact broken.
Attached is a patch which should fix them.

Also, while working on this patch I found out the Gnus backend interface
docs are slightly misleading on this subject - Gnus reads a group
description per line inserted in the " *nntpd*" buffer, with each line
containing a group's name followed by its description.
Contrary to the docs, the separator between the name and its associated
description is either a space or a tab (the docs only mention a tab).
This is why this is "mostly" fixed, as groups with a space in their name
will incorrectly include any part of the name after the first space in
the description.

I don't currently have time to go over all other backends to see if
changing this to reflect the docs will break anything, so I just added a
comment about it.

Daniel



In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-06-12 built on coldharbour
Repository revision: 3905db6e3aa947b847c072259ad6d08c8a15e10e
Repository branch: master
System Description: Void Linux

Configured using:
 'configure -C --prefix=/opt/Emacs --without-x --with-pgtk
 --with-small-ja-dic --with-native-compilation 'CFLAGS=-march=native
 -O2''

[0001-nnfeed-Mostly-fix-group-descriptions.patch (text/patch, attachment)]

Message #8 received at 71888 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: 71888 <at> debbugs.gnu.org
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Tue, 02 Jul 2024 15:11:14 +0300

> Date: Tue, 02 Jul 2024 02:43:29 +0300
> From:  Daniel Semyonov via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> I realized a few days ago I barely tested group descriptions in nnatom
> (and by extension nnfeed), and turns out they were in fact broken.
> Attached is a patch which should fix them.

Thanks, but please tell whether this is for the emacs-30 release
branch or for master.  IOW, does the problem exist on emacs-30 or only
on master?

Message #11 received at 71888 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Semyonov <daniel <at> dsemy.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71888 <at> debbugs.gnu.org
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Wed, 03 Jul 2024 00:01:57 +0300

>>>>> Eli Zaretskii writes:

    >> Date: Tue, 02 Jul 2024 02:43:29 +0300
    >> From:  Daniel Semyonov via "Bug reports for GNU Emacs,
    >> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
    >> 
    >> I realized a few days ago I barely tested group descriptions in nnatom
    >> (and by extension nnfeed), and turns out they were in fact broken.
    >> Attached is a patch which should fix them.

    > Thanks, but please tell whether this is for the emacs-30 release
    > branch or for master.  IOW, does the problem exist on emacs-30 or only
    > on master?

Sorry, this problem exists on both emacs-30 and on master (it was
unfortunately broken since nnfeed and nnatom were added to Emacs last
year).

I'm currently going over nnfeed and nnatom when I have free time to
hopefully find any issues I missed before Emacs 30 is released (as it
will be the first stable release to include them).

Message #14 received at 71888 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: 71888 <at> debbugs.gnu.org
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Sat, 06 Jul 2024 13:12:08 +0300

> From: Daniel Semyonov <daniel <at> dsemy.com>
> Cc: 71888 <at> debbugs.gnu.org
> Date: Wed, 03 Jul 2024 00:01:57 +0300
> 
> >>>>> Eli Zaretskii writes:
> 
>     >> Date: Tue, 02 Jul 2024 02:43:29 +0300
>     >> From:  Daniel Semyonov via "Bug reports for GNU Emacs,
>     >> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>     >> 
>     >> I realized a few days ago I barely tested group descriptions in nnatom
>     >> (and by extension nnfeed), and turns out they were in fact broken.
>     >> Attached is a patch which should fix them.
> 
>     > Thanks, but please tell whether this is for the emacs-30 release
>     > branch or for master.  IOW, does the problem exist on emacs-30 or only
>     > on master?
> 
> Sorry, this problem exists on both emacs-30 and on master (it was
> unfortunately broken since nnfeed and nnatom were added to Emacs last
> year).

Thanks, so I've now installed the patch on the emacs-30 release
branch.

> I'm currently going over nnfeed and nnatom when I have free time to
> hopefully find any issues I missed before Emacs 30 is released (as it
> will be the first stable release to include them).

So I'm not yet closing this bug, given that you say there's more to be
done here.

Thanks.

Message #17 received at 71888 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71888 <at> debbugs.gnu.org, Daniel Semyonov <daniel <at> dsemy.com>
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Sun, 29 Sep 2024 18:44:53 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Daniel Semyonov <daniel <at> dsemy.com>
>> Cc: 71888 <at> debbugs.gnu.org
>> Date: Wed, 03 Jul 2024 00:01:57 +0300
>>
>> I'm currently going over nnfeed and nnatom when I have free time to
>> hopefully find any issues I missed before Emacs 30 is released (as it
>> will be the first stable release to include them).
>
> So I'm not yet closing this bug, given that you say there's more to be
> done here.

Any news here?  Thanks.

Message #20 received at 71888 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Semyonov <daniel <at> dsemy.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 71888 <at> debbugs.gnu.org
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Mon, 14 Oct 2024 23:49:41 +0300

>>>>> Stefan Kangas writes:

    > Eli Zaretskii <eliz <at> gnu.org> writes:
    >>> From: Daniel Semyonov <daniel <at> dsemy.com>
    >>> Cc: 71888 <at> debbugs.gnu.org
    >>> Date: Wed, 03 Jul 2024 00:01:57 +0300
    >>> 
    >>> I'm currently going over nnfeed and nnatom when I have free time to
    >>> hopefully find any issues I missed before Emacs 30 is released (as it
    >>> will be the first stable release to include them).
    >> 
    >> So I'm not yet closing this bug, given that you say there's more to be
    >> done here.

    > Any news here?  Thanks.

Sorry but no, I really hoped I would have more time to spend on this but
life has been getting in the way lately unfortunately. (Also, sorry for
taking this long to respond)

I don't think there are many issues remaining in the code FWIW, as I've
been using it for years at this point so hopefully I already found and
fixed most of them; I was mostly worried about parts of Gnus I don't use
frequently interacting with my code in weird ways (and I have had time
to test some of these parts at least, and they seem to work as
expected).

Message #23 received at 71888 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 71888 <at> debbugs.gnu.org
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Mon, 14 Oct 2024 14:51:06 -0700

Daniel Semyonov <daniel <at> dsemy.com> writes:

> Sorry but no, I really hoped I would have more time to spend on this but
> life has been getting in the way lately unfortunately. (Also, sorry for
> taking this long to respond)

Thanks, and no worries.  We're all volunteers here.

> I don't think there are many issues remaining in the code FWIW, as I've
> been using it for years at this point so hopefully I already found and
> fixed most of them; I was mostly worried about parts of Gnus I don't use
> frequently interacting with my code in weird ways (and I have had time
> to test some of these parts at least, and they seem to work as
> expected).

Should we perhaps close this bug, then?  You could always open a new one
if any new issues should arise.

Message #28 received at 71888-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 71888-done <at> debbugs.gnu.org
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Sat, 2 Nov 2024 23:10:44 -0700

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Daniel Semyonov <daniel <at> dsemy.com> writes:
>
>> Sorry but no, I really hoped I would have more time to spend on this but
>> life has been getting in the way lately unfortunately. (Also, sorry for
>> taking this long to respond)
>
> Thanks, and no worries.  We're all volunteers here.
>
>> I don't think there are many issues remaining in the code FWIW, as I've
>> been using it for years at this point so hopefully I already found and
>> fixed most of them; I was mostly worried about parts of Gnus I don't use
>> frequently interacting with my code in weird ways (and I have had time
>> to test some of these parts at least, and they seem to work as
>> expected).
>
> Should we perhaps close this bug, then?  You could always open a new one
> if any new issues should arise.

That was 2 weeks ago, so I'm closing this bug report now.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.