GNU bug report logs -
#71898
[PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.
Previous Next
Reported by: Igor Goryachev <igor <at> goryachev.org>
Date: Tue, 2 Jul 2024 08:58:01 UTC
Severity: normal
Tags: patch
Done: Andrew Tropin <andrew <at> trop.in>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71898 in the body.
You can then email your comments to 71898 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#71898
; Package
guix-patches
.
(Tue, 02 Jul 2024 08:58:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Igor Goryachev <igor <at> goryachev.org>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 02 Jul 2024 08:58:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
---
gnu/packages/erlang.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index dd07c1a617..58aac2bead 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -792,6 +792,11 @@ (define-public erlang-lfe
#:phases
#~(modify-phases %standard-phases
(delete 'configure)
+ (add-after 'unpack 'make-deterministic
+ (lambda _
+ (substitute* "src/lfe_env.erl"
+ (("maps:fold\\(F, A, D\\)")
+ "lists:sort(maps:fold(F, A, D))"))))
;; The following is inspired by rebar-build-system.scm
(add-before 'check 'erlang-depends
(lambda* (#:key inputs #:allow-other-keys)
base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7
--
2.45.2
Information forwarded
to
guix-patches <at> gnu.org
:
bug#71898
; Package
guix-patches
.
(Tue, 02 Jul 2024 11:03:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 2024-07-02 11:57, Igor Goryachev wrote:
> * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
>
> Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
> ---
> gnu/packages/erlang.scm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index dd07c1a617..58aac2bead 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -792,6 +792,11 @@ (define-public erlang-lfe
> #:phases
> #~(modify-phases %standard-phases
> (delete 'configure)
> + (add-after 'unpack 'make-deterministic
> + (lambda _
> + (substitute* "src/lfe_env.erl"
> + (("maps:fold\\(F, A, D\\)")
> + "lists:sort(maps:fold(F, A, D))"))))
It would be useful to add some explanation in the comment and probably a
link to upstream PR/thread.
> ;; The following is inspired by rebar-build-system.scm
> (add-before 'check 'erlang-depends
> (lambda* (#:key inputs #:allow-other-keys)
>
> base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7
--
Best regards,
Andrew Tropin
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Andrew Tropin <andrew <at> trop.in>
:
You have taken responsibility.
(Sun, 07 Jul 2024 07:53:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Igor Goryachev <igor <at> goryachev.org>
:
bug acknowledged by developer.
(Sun, 07 Jul 2024 07:53:02 GMT)
Full text and
rfc822 format available.
Message #13 received at 71898-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 2024-07-02 11:57, Igor Goryachev via Guix-patches via wrote:
> * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
>
> Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
> ---
> gnu/packages/erlang.scm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index dd07c1a617..58aac2bead 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -792,6 +792,11 @@ (define-public erlang-lfe
> #:phases
> #~(modify-phases %standard-phases
> (delete 'configure)
> + (add-after 'unpack 'make-deterministic
> + (lambda _
> + (substitute* "src/lfe_env.erl"
> + (("maps:fold\\(F, A, D\\)")
> + "lists:sort(maps:fold(F, A, D))"))))
> ;; The following is inspired by rebar-build-system.scm
> (add-before 'check 'erlang-depends
> (lambda* (#:key inputs #:allow-other-keys)
>
> base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7
Superseded by 71899.
--
Best regards,
Andrew Tropin
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#71898
; Package
guix-patches
.
(Sun, 07 Jul 2024 07:55:01 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sun, 04 Aug 2024 11:24:18 GMT)
Full text and
rfc822 format available.
This bug report was last modified 34 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.