GNU bug report logs - #71946
30.0.50; [PATCH] Fix bibtex validation for non-file buffers

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Liu Hui <liuhui1610@HIDDEN>; Keywords: patch; Done: Eli Zaretskii <eliz@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 71946-done <at> debbugs.gnu.org:


Received: (at 71946-done) by debbugs.gnu.org; 20 Jul 2024 09:49:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 20 05:49:28 2024
Received: from localhost ([127.0.0.1]:51770 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sV6iW-0008CW-6U
	for submit <at> debbugs.gnu.org; Sat, 20 Jul 2024 05:49:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40688)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sV6iU-0008CJ-Mf
 for 71946-done <at> debbugs.gnu.org; Sat, 20 Jul 2024 05:49:26 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sV6iO-0002oC-UD; Sat, 20 Jul 2024 05:49:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=G76VXS3K+q09+rPdeKv7hFRfEhN8x0+iEvo6zlv/At4=; b=cmFVrdw7nVFs
 0tQ3Q8611DYNCBBHj+fCAq46nob6jB+bVb4xFcKnRFmjpJz5FvdIUW/PQVuqLbCn0kjTzSJM2m/tc
 WfUQ9pXREudPG+DHvJr92rNDEsTu60ySghjpQFc32MgvPoI02wEYKOqxGLDz1EEVPfu9EIcVgs7lQ
 CFM5n3V0+RMXY2CmxlxuBeQ0pflUDbrzyjyZm6ZKLxg+3op4DB1r3LYjYo/nF91ILFkd+xWLc7322
 //9lgIJjdyBfZMe0diHd1VH/i7DKSojnNXFVJQnbJffb0Eh8Od2jfxHGuErwrrw31Yz4e6adgxLDK
 +vHAFfp3B0+e1J0pu9nvjA==;
Date: Sat, 20 Jul 2024 12:49:17 +0300
Message-Id: <861q3oe6le.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>
In-Reply-To: <CAOQTW-MHvt0jDbsPaFkOoBkgnFGzusXBcnYvu--ViToAgYLGiQ@HIDDEN>
 (message from Liu Hui on Fri, 5 Jul 2024 18:00:00 +0800)
Subject: Re: bug#71946: 30.0.50;
 [PATCH] Fix bibtex validation for non-file buffers
References: <CAOQTW-MHvt0jDbsPaFkOoBkgnFGzusXBcnYvu--ViToAgYLGiQ@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 71946-done
Cc: 71946-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Fri, 5 Jul 2024 18:00:00 +0800
> 
> I find that bibtex-validate has a minor issue for non-file buffers
> with syntax errors:
> 
> 1. emacs -Q
> 2. create an empty buffer containing the following text:
> 
> @article{1,
>   title = {Title},
>   author = {authors},
>   year = {2019}
> 
> 3. M-x bibtex-mode, then M-x bibtex-validate
>    => Wrong type argument: stringp, nil
> 
> This patch fixes the problem. Thanks.

Thanks, installed on the emacs-30 branch and closing the bug.
Notification sent to Liu Hui <liuhui1610@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Eli Zaretskii <eliz@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 71946 <at> debbugs.gnu.org:


Received: (at 71946) by debbugs.gnu.org; 13 Jul 2024 10:26:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 13 06:26:42 2024
Received: from localhost ([127.0.0.1]:55169 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sSZxi-0001jQ-5v
	for submit <at> debbugs.gnu.org; Sat, 13 Jul 2024 06:26:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37068)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sSZxc-0001j7-Hn
 for 71946 <at> debbugs.gnu.org; Sat, 13 Jul 2024 06:26:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sSZxW-0001gc-Fp; Sat, 13 Jul 2024 06:26:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=fX3kvQ7Hso1RFyFq3w3fXIHZNpgVTRqbYF5Ze8YspUQ=; b=OOfSAKxtRoon
 ixYzGsuVSgL+PzQUKU1MQa9FEC75eeKm8d6QLg6rXQaqtFTRKyIegapjmA1/i9EMhHSJfx06UtEkp
 lIfdUm56wsqBOJT8cMGeoL9r3HRnDEdP/Yd/6afS1rAznvtAQtDRRdtUavMJ6KGVn2rMbz19zQfmX
 PmoU1OsITXJmyCJOXZwPHi7HsuCT4bpyCxMVV0RGyAaXX3rTaD7iWZuIP5/XDVg3GiqF9ns3nBy47
 +4/xy/3HTGx9ev6dcb7qhdYPC2VD6dgDVlMQ0wMuVHWSWQ67oxPfTF8ZA91q0j47VOSTFeclKT2Vy
 QxEwPNhLLkib9aEOGriSWg==;
Date: Sat, 13 Jul 2024 13:26:28 +0300
Message-Id: <86r0bxk2p7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>, Roland Winkler <winkler@HIDDEN>
In-Reply-To: <CAOQTW-MHvt0jDbsPaFkOoBkgnFGzusXBcnYvu--ViToAgYLGiQ@HIDDEN>
 (message from Liu Hui on Fri, 5 Jul 2024 18:00:00 +0800)
Subject: Re: bug#71946: 30.0.50;
 [PATCH] Fix bibtex validation for non-file buffers
References: <CAOQTW-MHvt0jDbsPaFkOoBkgnFGzusXBcnYvu--ViToAgYLGiQ@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 71946
Cc: 71946 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Fri, 5 Jul 2024 18:00:00 +0800
> 
> I find that bibtex-validate has a minor issue for non-file buffers
> with syntax errors:
> 
> 1. emacs -Q
> 2. create an empty buffer containing the following text:
> 
> @article{1,
>   title = {Title},
>   author = {authors},
>   year = {2019}
> 
> 3. M-x bibtex-mode, then M-x bibtex-validate
>    => Wrong type argument: stringp, nil
> 
> This patch fixes the problem. Thanks.
> 
> From b90a6838fa75e9023bcb61b6f545a5a7916e3b3c Mon Sep 17 00:00:00 2001
> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Fri, 5 Jul 2024 17:50:08 +0800
> Subject: [PATCH] Fix bibtex validation for non-file buffers
> 
> * lisp/textmodes/bibtex.el (bibtex-validate): Use buffer name when
> errors are found in non-file buffers.
> ---
>  lisp/textmodes/bibtex.el | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
> index a6da34d6a41..1473fc2bd6b 100644
> --- a/lisp/textmodes/bibtex.el
> +++ b/lisp/textmodes/bibtex.el
> @@ -4638,13 +4638,16 @@ bibtex-validate
>              (bibtex-progress-message 'done)))))
>  
>      (if error-list
> -        (let ((file (file-name-nondirectory (buffer-file-name)))
> -              (dir default-directory)
> -              (err-buf "*BibTeX validation errors*"))
> +        (let* ((file-p (buffer-file-name))
> +               (file (if file-p (file-name-nondirectory file-p) (buffer-name)))
> +               (dir default-directory)
> +               (err-buf "*BibTeX validation errors*"))
>            (setq error-list (sort error-list #'car-less-than-car))
>            (with-current-buffer (get-buffer-create err-buf)
>              (setq default-directory dir)
>              (unless (eq major-mode 'compilation-mode) (compilation-mode))
> +            (setq-local compilation-parse-errors-filename-function
> +                        (if file-p #'identity #'get-buffer))
>              (let ((inhibit-read-only t))
>                (delete-region (point-min) (point-max))
>                (insert (substitute-command-keys
> -- 
> 2.25.1

Thanks.

Roland, is this patch okay with you, and if so, is it safe enough to
be installed on the emacs-30 release branch?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#71946; Package emacs. Full text available.

Message received at 71946 <at> debbugs.gnu.org:


Received: (at 71946) by debbugs.gnu.org; 6 Jul 2024 22:39:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 06 18:39:15 2024
Received: from localhost ([127.0.0.1]:46939 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sQE3m-0006mN-QD
	for submit <at> debbugs.gnu.org; Sat, 06 Jul 2024 18:39:15 -0400
Received: from out-186.mta1.migadu.com ([95.215.58.186]:58989)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jb@HIDDEN>) id 1sQE3k-0006m9-Sf
 for 71946 <at> debbugs.gnu.org; Sat, 06 Jul 2024 18:39:13 -0400
X-Envelope-To: 71946 <at> debbugs.gnu.org
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net;
 s=key1; t=1720305510;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=kcJoPWTY/mZva4fzgo2P/6dPj3pQ5EoLOB7WV2LsU40=;
 b=KXUytzdx3jUqIgUPuKDRhaYm7ByJ86arVsKJB7ciFLZZhA1FNEtZuef4Cxq+mzMCwP6HJF
 GI1FGph7oSZ0fz9aMHIKV3WrQzlp5Zp4QdtUZWMEUZLehlsAm6bgfC3969++bkacyE7KCJ
 riRyXmO9C2hd2BLl6hMlnVSWWFjUAzJWbXCQ98r7/IrRjdFfOhpdfIpkITfoZ8CdCjDs61
 wNvRCDzCiw+Q2AF2yqr66n1vp1S/c7GSnX8QJiijH0kcfT4EV8A9pEvQsmeKC1UwsvlATi
 bHJrjXqmgxHiUjXzC39LK9SoQ3Hk0wYE57c6Dqw0sogsD4v8M54IpN749JabFw==
X-Envelope-To: liuhui1610@HIDDEN
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Jeremy Bryant <jb@HIDDEN>
To: Liu Hui <liuhui1610@HIDDEN>
Subject: Re: bug#71946: 30.0.50; [PATCH] Fix bibtex validation for non-file
 buffers
In-Reply-To: <CAOQTW-MHvt0jDbsPaFkOoBkgnFGzusXBcnYvu--ViToAgYLGiQ@HIDDEN>
 (Liu Hui's message of "Fri, 5 Jul 2024 18:00:00 +0800")
References: <CAOQTW-MHvt0jDbsPaFkOoBkgnFGzusXBcnYvu--ViToAgYLGiQ@HIDDEN>
Date: Sat, 06 Jul 2024 23:38:28 +0100
Message-ID: <87sewmp2mz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 71946
Cc: 71946 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Liu Hui <liuhui1610@HIDDEN> writes:

> Hi,
>
> I find that bibtex-validate has a minor issue for non-file buffers
> with syntax errors:
>
> 1. emacs -Q
> 2. create an empty buffer containing the following text:
>
> @article{1,
>   title = {Title},
>   author = {authors},
>   year = {2019}
>
> 3. M-x bibtex-mode, then M-x bibtex-validate
>    => Wrong type argument: stringp, nil

I have tested this recipe and reproduced this bug

>
> This patch fixes the problem. Thanks.

I have no comments on this patch yet.

>
> [2. text/x-patch; 0001-Fix-bibtex-validation-for-non-file-buffers.patch]...
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#71946; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 5 Jul 2024 10:00:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 05 06:00:35 2024
Received: from localhost ([127.0.0.1]:43620 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sPfk3-00076D-AM
	for submit <at> debbugs.gnu.org; Fri, 05 Jul 2024 06:00:35 -0400
Received: from lists.gnu.org ([209.51.188.17]:56210)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liuhui1610@HIDDEN>) id 1sPfk0-000765-RD
 for submit <at> debbugs.gnu.org; Fri, 05 Jul 2024 06:00:33 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <liuhui1610@HIDDEN>)
 id 1sPfjx-00086G-Ey
 for bug-gnu-emacs@HIDDEN; Fri, 05 Jul 2024 06:00:29 -0400
Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <liuhui1610@HIDDEN>)
 id 1sPfjv-0002NL-Ta
 for bug-gnu-emacs@HIDDEN; Fri, 05 Jul 2024 06:00:29 -0400
Received: by mail-vs1-xe34.google.com with SMTP id
 ada2fe7eead31-48fe5a03889so515265137.1
 for <bug-gnu-emacs@HIDDEN>; Fri, 05 Jul 2024 03:00:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1720173626; x=1720778426; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=CxjGGWNUNGLuUrWgt3S5nQob7c5a87tBmJK1I6uv3JQ=;
 b=YtdvN5W/Xyzg+yZl6QT+RSzdiQ5E9TfyiHtNO6OZLh5OTWBq2k2B8VHqEbo0cCd1m7
 AtIXCHmcNGG5B+Gudhk8qEQI0kA+pqfER1+rpbM+DBDO6eILTR6HA5OgSxfJzEyPcsTQ
 fYItMieC3lmCIpd3AIbcQjZOTLgHxuhRC6UYLkep3+/LMFomW0/Ld8RvkqLWeVcdKm1I
 b9/mx4KjxEmcNpKg5H/1HAj2Wn0EBjmLLMmwaTG3yglarumzorYRyHXouIaOtiu9Pf2n
 Ms+DQff+hBUFnKiIVH1Y8uFDshiPJSb1uOFo2Hj1Oj3PA2l0eI9vf5iaFCZuyWEOjaiU
 c26w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1720173626; x=1720778426;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=CxjGGWNUNGLuUrWgt3S5nQob7c5a87tBmJK1I6uv3JQ=;
 b=DjYLjJKP0RH4jDRm9ir8Rf2CtiNYV9C18OwlheRW+wFaCJNmnIA7Pw7nhI1y3PoI1R
 PRPEUWzZcwmdOkX837JpSRYLKRCiL5p0J5KkDCFvlNKj/EEnfKgvt104Y4pSlFTl9osW
 cR7abQ9CHjxAgK7BJY1hQPYRfRQ6zfNFEqMIng8bT0X7BC8dB2nEhuUZJ5eB6xcwAAHf
 od1IkcqFMEU+n3NvE5AGXS00uz3DcJm1aHOyCVMNRSr9wgXWX032vOfAN7K56zPta0Pv
 bhkKYU0I1iAYakab7QARcSJQ0w6zCLE35Osjh5KArGGcXGnOrt8nFUeyFU1DgWGZK2Wm
 N4tQ==
X-Gm-Message-State: AOJu0YxnBWctAF6vUHfsKSbL77553qqmfXyKKM0I4O0NUzX481+gU8fP
 6BOGSHQKsSx/prPSjZ8v8QJaJT8T/H/Yp2VohLHc+zH+B0/2DplkvvnmZPl67ilVgF52v/VinaG
 oWuIGbgB2NJxz97KFJ8tEg4QQd5elsodNsjE=
X-Google-Smtp-Source: AGHT+IG+m8HcEsMHotDxlHP1nrNruWUwRzHbVtqZ/ZT1TH5n7LbscJSnKIEbPqPoXfVctqHJMu1tTWYuVAPUgcgJtjE=
X-Received: by 2002:a67:e419:0:b0:48f:9324:db08 with SMTP id
 ada2fe7eead31-48fee66c28cmr3838187137.4.1720173625944; Fri, 05 Jul 2024
 03:00:25 -0700 (PDT)
MIME-Version: 1.0
From: Liu Hui <liuhui1610@HIDDEN>
Date: Fri, 5 Jul 2024 18:00:00 +0800
Message-ID: <CAOQTW-MHvt0jDbsPaFkOoBkgnFGzusXBcnYvu--ViToAgYLGiQ@HIDDEN>
Subject: 30.0.50; [PATCH] Fix bibtex validation for non-file buffers
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="000000000000ee969e061c7d216f"
Received-SPF: pass client-ip=2607:f8b0:4864:20::e34;
 envelope-from=liuhui1610@HIDDEN; helo=mail-vs1-xe34.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

--000000000000ee969e061c7d216f
Content-Type: text/plain; charset="UTF-8"

Hi,

I find that bibtex-validate has a minor issue for non-file buffers
with syntax errors:

1. emacs -Q
2. create an empty buffer containing the following text:

@article{1,
  title = {Title},
  author = {authors},
  year = {2019}

3. M-x bibtex-mode, then M-x bibtex-validate
   => Wrong type argument: stringp, nil

This patch fixes the problem. Thanks.

--000000000000ee969e061c7d216f
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Fix-bibtex-validation-for-non-file-buffers.patch"
Content-Disposition: attachment; 
	filename="0001-Fix-bibtex-validation-for-non-file-buffers.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_ly8bvmvp0>
X-Attachment-Id: f_ly8bvmvp0

RnJvbSBiOTBhNjgzOGZhNzVlOTAyM2JjYjYxYjZmNTQ1YTVhNzkxNmUzYjNjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog
RnJpLCA1IEp1bCAyMDI0IDE3OjUwOjA4ICswODAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGJpYnRl
eCB2YWxpZGF0aW9uIGZvciBub24tZmlsZSBidWZmZXJzCgoqIGxpc3AvdGV4dG1vZGVzL2JpYnRl
eC5lbCAoYmlidGV4LXZhbGlkYXRlKTogVXNlIGJ1ZmZlciBuYW1lIHdoZW4KZXJyb3JzIGFyZSBm
b3VuZCBpbiBub24tZmlsZSBidWZmZXJzLgotLS0KIGxpc3AvdGV4dG1vZGVzL2JpYnRleC5lbCB8
IDkgKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u
cygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL2JpYnRleC5lbCBiL2xpc3AvdGV4dG1v
ZGVzL2JpYnRleC5lbAppbmRleCBhNmRhMzRkNmE0MS4uMTQ3M2ZjMmJkNmIgMTAwNjQ0Ci0tLSBh
L2xpc3AvdGV4dG1vZGVzL2JpYnRleC5lbAorKysgYi9saXNwL3RleHRtb2Rlcy9iaWJ0ZXguZWwK
QEAgLTQ2MzgsMTMgKzQ2MzgsMTYgQEAgYmlidGV4LXZhbGlkYXRlCiAgICAgICAgICAgICAoYmli
dGV4LXByb2dyZXNzLW1lc3NhZ2UgJ2RvbmUpKSkpKQogCiAgICAgKGlmIGVycm9yLWxpc3QKLSAg
ICAgICAgKGxldCAoKGZpbGUgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgKGJ1ZmZlci1maWxlLW5h
bWUpKSkKLSAgICAgICAgICAgICAgKGRpciBkZWZhdWx0LWRpcmVjdG9yeSkKLSAgICAgICAgICAg
ICAgKGVyci1idWYgIipCaWJUZVggdmFsaWRhdGlvbiBlcnJvcnMqIikpCisgICAgICAgIChsZXQq
ICgoZmlsZS1wIChidWZmZXItZmlsZS1uYW1lKSkKKyAgICAgICAgICAgICAgIChmaWxlIChpZiBm
aWxlLXAgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgZmlsZS1wKSAoYnVmZmVyLW5hbWUpKSkKKyAg
ICAgICAgICAgICAgIChkaXIgZGVmYXVsdC1kaXJlY3RvcnkpCisgICAgICAgICAgICAgICAoZXJy
LWJ1ZiAiKkJpYlRlWCB2YWxpZGF0aW9uIGVycm9ycyoiKSkKICAgICAgICAgICAoc2V0cSBlcnJv
ci1saXN0IChzb3J0IGVycm9yLWxpc3QgIydjYXItbGVzcy10aGFuLWNhcikpCiAgICAgICAgICAg
KHdpdGgtY3VycmVudC1idWZmZXIgKGdldC1idWZmZXItY3JlYXRlIGVyci1idWYpCiAgICAgICAg
ICAgICAoc2V0cSBkZWZhdWx0LWRpcmVjdG9yeSBkaXIpCiAgICAgICAgICAgICAodW5sZXNzIChl
cSBtYWpvci1tb2RlICdjb21waWxhdGlvbi1tb2RlKSAoY29tcGlsYXRpb24tbW9kZSkpCisgICAg
ICAgICAgICAoc2V0cS1sb2NhbCBjb21waWxhdGlvbi1wYXJzZS1lcnJvcnMtZmlsZW5hbWUtZnVu
Y3Rpb24KKyAgICAgICAgICAgICAgICAgICAgICAgIChpZiBmaWxlLXAgIydpZGVudGl0eSAjJ2dl
dC1idWZmZXIpKQogICAgICAgICAgICAgKGxldCAoKGluaGliaXQtcmVhZC1vbmx5IHQpKQogICAg
ICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkKICAgICAg
ICAgICAgICAgKGluc2VydCAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMKLS0gCjIuMjUuMQoK
--000000000000ee969e061c7d216f--
Acknowledgement sent to Liu Hui <liuhui1610@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#71946; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 20 Jul 2024 10:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.