GNU bug report logs - #71949
[PATCH] services: web: Pass run-directory to nginx's actions.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71949 in the body.
You can then email your comments to 71949 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] services: web: Pass run-directory to nginx's actions.
Date: Fri,  5 Jul 2024 17:01:20 +0200

Reloading nginx lead to (harmless, yet annoying) alert being logged:

    nginx: [alert] could not open error log file: open() "/gnu/store/9l2lznlqpjcm79znq1xas378maqgysc8-nginx-1.27.0/logs/error.log" failed (2: No such file or directory)

Since there already is prepared runtime directory for nginx, all that was
missing was to also pass it to the reload and reopen invocations.

* gnu/services/web.scm (nginx-shepherd-service)[reload, reopen]: Pass -p flag
with run-directory as value.

Change-Id: Id5c558d65def8c1fe5cf581a4a370508ac05e550
---
 gnu/services/web.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index c10bd4cdff..b73cd30fe7 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -858,11 +858,11 @@ (define (nginx-shepherd-service config)
 the same configuration file.  It is useful for situations where the same nginx
 configuration file can point to different things after a reload, such as
 renewed TLS certificates, or @code{include}d files.")
-                 (procedure (nginx-action "-s" "reload")))
+                 (procedure (nginx-action "-p" run-directory "-s" "reload")))
                (shepherd-action
                 (name 'reopen)
                 (documentation "Re-open log files.")
-                (procedure (nginx-action "-s" "reopen"))))))))))
+                (procedure (nginx-action "-p" run-directory "-s" "reopen"))))))))))
 
 (define nginx-service-type
   (service-type (name 'nginx)
-- 
2.45.1

Message #10 received at 71949-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 71949-done <at> debbugs.gnu.org
Subject: Re: [bug#71949] [PATCH] services: web: Pass run-directory to
 nginx's actions.
Date: Wed, 10 Jul 2024 16:05:19 +0200

Tomas Volf <~@wolfsden.cz> skribis:

> Reloading nginx lead to (harmless, yet annoying) alert being logged:
>
>     nginx: [alert] could not open error log file: open() "/gnu/store/9l2lznlqpjcm79znq1xas378maqgysc8-nginx-1.27.0/logs/error.log" failed (2: No such file or directory)
>
> Since there already is prepared runtime directory for nginx, all that was
> missing was to also pass it to the reload and reopen invocations.
>
> * gnu/services/web.scm (nginx-shepherd-service)[reload, reopen]: Pass -p flag
> with run-directory as value.
>
> Change-Id: Id5c558d65def8c1fe5cf581a4a370508ac05e550

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.