GNU bug report logs - #71952
documentation inaccuracy?

Previous Next

To reply to this bug, email your comments to 71952 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: chris <chris <at> bumblehead.com>
To: bug-guix <at> gnu.org
Cc: chris <at> bumblehead.com
Subject: documentation inaccuracy?
Date: Fri, 5 Jul 2024 11:22:13 -0700

This section of the documentation seems innacurate,

https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-home.html#index-home-generations

> When specifying a negative value such as -1, you must precede it with -- to prevent it from being parsed as an option. For example:
>
> guix home switch-generation -- -1

Running the same command here gives the following result

> $ guix home switch-generation -- -1
>
> guix home: error: -1: extraneous command

Instead, `guix home roll-back` and `guix home switch-generation +1` can be used.

Message #8 received at 71952 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 71952 <at> debbugs.gnu.org
Cc: chris <chris <at> bumblehead.com>, Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: Re: documentation inaccuracy?
Date: Sat, 06 Jul 2024 08:33:47 -0500

hi chris,

would you like to send a patch fixing this?

hi simon,

wdyt?
-- 
all the best,
jgart

Message #11 received at 71952 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: chris <chris <at> bumblehead.com>, 71952 <at> debbugs.gnu.org
Cc: chris <at> bumblehead.com, jgart <jgart <at> dismail.de>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: bug#71952: documentation inaccuracy?
Date: Tue, 09 Jul 2024 19:08:24 +0200

[Message part 1 (text/plain, inline)]

Hi,

>> $ guix home switch-generation -- -1
>> guix home: error: -1: extraneous command

Indeed, the command-line parser seems incorrect and inconsistent with
the documentation.

The culprit seems the procedure ’parse-args’ from ’guix-home’ command
inside the module (guix scripts home).

Hum, I guess something as the attached patch should fix the issue.

[p.patch (text/x-diff, inline)]

diff --git a/guix/scripts/home.scm b/guix/scripts/home.scm
index b4c82d275f..5c39e83983 100644
--- a/guix/scripts/home.scm
+++ b/guix/scripts/home.scm
@@ -682,6 +682,8 @@ (define-command (guix-home . args)
       (match rest
         (() opts)
         (("--") opts)
+        (("--" n)
+         (alist-cons 'argument n opts))
         (("--" command ...)
          (match (assoc-ref opts 'action)
            ('container

[Message part 3 (text/plain, inline)]

WDYT?

Cheers,
simon

Message #14 received at 71952 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Simon Tournier" <zimon.toutoune <at> gmail.com>, "chris"
 <chris <at> bumblehead.com>, 71952 <at> debbugs.gnu.org
Cc: chris <at> bumblehead.com, Andrew Tropin <andrew <at> trop.in>
Subject: Re: bug#71952: documentation inaccuracy?
Date: Tue, 09 Jul 2024 18:58:26 +0000

LGTM, Andrew WDYT?

--
jgart

Message #17 received at 71952 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: jgart <jgart <at> dismail.de>, Simon Tournier <zimon.toutoune <at> gmail.com>,
 chris <chris <at> bumblehead.com>, 71952 <at> debbugs.gnu.org
Cc: chris <at> bumblehead.com
Subject: Re: bug#71952: documentation inaccuracy?
Date: Wed, 31 Jul 2024 17:43:42 +0400

[Message part 1 (text/plain, inline)]

> LGTM, Andrew WDYT?

Didn't try the patch, but overall idea seems right.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.