GNU bug report logs - #71953
[PATCH 0/3] gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71953 in the body.
You can then email your comments to 71953 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 0/3] gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.
Date: Fri,  5 Jul 2024 21:26:55 +0300

Unbundle "go-github-com-ipfs-go-ipld-cbor" from Kubo (IPFS.)

Artyom V. Poptsov (3):
  gnu: Add go-github-com-whyrusleeping-cbor-gen.
  gnu: Add go-github-com-ipfs-go-ipld-cbor.
  gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.

 gnu/packages/ipfs.scm | 63 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 62 insertions(+), 1 deletion(-)


base-commit: 922e943059050f05532ac8274e55e25ebe711cf5
-- 
2.45.2

Message #8 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 71953 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 1/3] gnu: Add go-github-com-whyrusleeping-cbor-gen.
Date: Fri,  5 Jul 2024 21:28:20 +0300

* gnu/packages/ipfs.scm (go-github-com-whyrusleeping-cbor-gen): New variable.

Change-Id: I7fc01ba570492a145bcea00f08e0ccb7cc0479af
---
 gnu/packages/ipfs.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm
index d75a99c4e1..373e73f4d2 100644
--- a/gnu/packages/ipfs.scm
+++ b/gnu/packages/ipfs.scm
@@ -449,6 +449,36 @@ (define-public go-github-com-ipfs-go-log
       #:go go-1.21
       #:import-path "github.com/ipfs/go-log"))))
 
+(define-public go-github-com-whyrusleeping-cbor-gen
+  (package
+    (name "go-github-com-whyrusleeping-cbor-gen")
+    (version "v0.0.0-20230818171029-f91ae536ca25")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/whyrusleeping/cbor-gen")
+             (commit (go-version->git-ref version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "08by7pqh4fcwf2va01iif75yqkfssi6d48334404mmv9jmhzim60"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:import-path "github.com/whyrusleeping/cbor-gen"))
+    (propagated-inputs
+     (list go-github-com-ipfs-go-cid
+           go-github-com-google-go-cmp-cmp
+           go-golang-org-x-xerrors))
+    (home-page "https://github.com/whyrusleeping/cbor-gen")
+    (synopsis "Codegen for cbor codecs on your types")
+    ;; There is not much information provided by the project, see
+    ;; <https://github.com/whyrusleeping/go-sysinfo/issues>.
+    (description
+     "Some basic utilities to generate fast path @url{https://cbor.io/, CBOR} codecs
+for your types.")
+    (license license:expat)))
+
 (define-public gx
   (package
     (name "gx")
-- 
2.45.2

Message #11 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 71953 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 2/3] gnu: Add go-github-com-ipfs-go-ipld-cbor.
Date: Fri,  5 Jul 2024 21:28:21 +0300

* gnu/packages/ipfs.scm (go-github-com-ipfs-go-ipld-cbor): New variable.

Change-Id: I1a85366eb558fe3043fe39d8aabd4bf14f98a32a
---
 gnu/packages/ipfs.scm | 40 +++++++++++++++++++++++++++++++++++-----
 1 file changed, 35 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm
index 373e73f4d2..3c137818ae 100644
--- a/gnu/packages/ipfs.scm
+++ b/gnu/packages/ipfs.scm
@@ -270,6 +270,38 @@ (define-public go-github-com-ipfs-go-ipfs-util
      "Common utilities used by @code{go-ipfs} and other related Go packages.")
     (license license:expat)))
 
+(define-public go-github-com-ipfs-go-ipld-cbor
+  (package
+    (name "go-github-com-ipfs-go-ipld-cbor")
+    (version "0.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ipfs/go-ipld-cbor")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0yxk4sbf1fk9aaizzpz3h30049wqvaz0s3jnbdd5akhj7wg89h21"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:go go-1.21
+      #:import-path "github.com/ipfs/go-ipld-cbor"))
+    (propagated-inputs
+     (list go-github-com-ipfs-go-block-format
+           go-github-com-ipfs-go-cid
+           go-github-com-ipfs-go-ipfs-util
+           go-github-com-ipfs-go-ipld-format
+           go-github-com-multiformats-go-multihash
+           go-github-com-polydawn-refmt
+           go-github-com-whyrusleeping-cbor-gen))
+    (home-page "https://github.com/ipfs/go-ipld-cbor")
+    (synopsis "A cbor implementation of the @code{go-ipld-format}")
+    (description
+     "An implementation of a @url{https://cbor.io/, CBOR} encoded merkledag object.")
+    (license license:expat)))
+
 (define-public go-github-com-ipfs-go-ipld-format
   (package
     (name "go-github-com-ipfs-go-ipld-format")
@@ -471,12 +503,10 @@ (define-public go-github-com-whyrusleeping-cbor-gen
            go-github-com-google-go-cmp-cmp
            go-golang-org-x-xerrors))
     (home-page "https://github.com/whyrusleeping/cbor-gen")
-    (synopsis "Codegen for cbor codecs on your types")
-    ;; There is not much information provided by the project, see
-    ;; <https://github.com/whyrusleeping/go-sysinfo/issues>.
+    (synopsis "Codegen for CBOR codecs on the specified types")
     (description
-     "Some basic utilities to generate fast path @url{https://cbor.io/, CBOR} codecs
-for your types.")
+     "Basic utilities to generate fast path @url{https://cbor.io/, CBOR} codecs for
+types.")
     (license license:expat)))
 
 (define-public gx
-- 
2.45.2

Message #14 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 71953 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 3/3] gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.
Date: Fri,  5 Jul 2024 21:28:22 +0300

* gnu/packages/ipfs.scm (kubo): Unbundle go-github-com-ipfs-go-ipld-cbor.
[inputs]: Add go-github-com-ipfs-go-ipld-cbor.

Change-Id: I8edd09e134dee725f1ecaf8f4296c74c4cc5f37c
---
 gnu/packages/ipfs.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm
index 3c137818ae..6a6bd81caf 100644
--- a/gnu/packages/ipfs.scm
+++ b/gnu/packages/ipfs.scm
@@ -669,6 +669,7 @@ (define-public kubo
                              "vendor/github.com/ipfs/go-detect-race"
                              "vendor/github.com/ipfs/go-ipfs-delay"
                              "vendor/github.com/ipfs/go-ipfs-util"
+                             "vendor/github.com/ipfs/go-ipld-cbor"
                              "vendor/github.com/ipfs/go-ipld-format"
                              "vendor/github.com/ipfs/go-log"
                              "vendor/github.com/ipld/go-ipld-prime"
@@ -754,7 +755,7 @@ (define-public kubo
                   ;;go-github-com-ipfs-go-ds-measure
                   ;;go-github-com-ipfs-go-fs-lock
                   ;;go-github-com-ipfs-go-ipfs-cmds
-                  ;;go-github-com-ipfs-go-ipld-cbor
+                  go-github-com-ipfs-go-ipld-cbor
                   go-github-com-ipfs-go-ipld-format
                   ;;go-github-com-ipfs-go-ipld-git
                   ;;go-github-com-ipfs-go-ipld-legacy
-- 
2.45.2

Message #17 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 71953 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 0/3] gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.
Date: Sat, 6 Jul 2024 18:14:06 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patches.

May you check [PATCH 2/3] gnu: Add go-github-com-ipfs-go-ipld-cbor, not to
include other modifications please?

--
Oleg

[Message part 2 (text/html, inline)]

Message #20 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 71953 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH v2 2/3] gnu: Add go-github-com-ipfs-go-ipld-cbor.
Date: Sun,  7 Jul 2024 10:13:03 +0300

* gnu/packages/ipfs.scm (go-github-com-ipfs-go-ipld-cbor): New variable.

Change-Id: I1a85366eb558fe3043fe39d8aabd4bf14f98a32a
---
 gnu/packages/ipfs.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm
index f5ccd6cb8f..3c137818ae 100644
--- a/gnu/packages/ipfs.scm
+++ b/gnu/packages/ipfs.scm
@@ -270,6 +270,38 @@ (define-public go-github-com-ipfs-go-ipfs-util
      "Common utilities used by @code{go-ipfs} and other related Go packages.")
     (license license:expat)))
 
+(define-public go-github-com-ipfs-go-ipld-cbor
+  (package
+    (name "go-github-com-ipfs-go-ipld-cbor")
+    (version "0.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ipfs/go-ipld-cbor")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0yxk4sbf1fk9aaizzpz3h30049wqvaz0s3jnbdd5akhj7wg89h21"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:go go-1.21
+      #:import-path "github.com/ipfs/go-ipld-cbor"))
+    (propagated-inputs
+     (list go-github-com-ipfs-go-block-format
+           go-github-com-ipfs-go-cid
+           go-github-com-ipfs-go-ipfs-util
+           go-github-com-ipfs-go-ipld-format
+           go-github-com-multiformats-go-multihash
+           go-github-com-polydawn-refmt
+           go-github-com-whyrusleeping-cbor-gen))
+    (home-page "https://github.com/ipfs/go-ipld-cbor")
+    (synopsis "A cbor implementation of the @code{go-ipld-format}")
+    (description
+     "An implementation of a @url{https://cbor.io/, CBOR} encoded merkledag object.")
+    (license license:expat)))
+
 (define-public go-github-com-ipfs-go-ipld-format
   (package
     (name "go-github-com-ipfs-go-ipld-format")
-- 
2.45.2

Message #23 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 71953 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH v2 1/3] gnu: Add go-github-com-whyrusleeping-cbor-gen.
Date: Sun,  7 Jul 2024 10:13:02 +0300

* gnu/packages/ipfs.scm (go-github-com-whyrusleeping-cbor-gen): New variable.

Change-Id: I7fc01ba570492a145bcea00f08e0ccb7cc0479af
---
 gnu/packages/ipfs.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm
index d75a99c4e1..f5ccd6cb8f 100644
--- a/gnu/packages/ipfs.scm
+++ b/gnu/packages/ipfs.scm
@@ -449,6 +449,34 @@ (define-public go-github-com-ipfs-go-log
       #:go go-1.21
       #:import-path "github.com/ipfs/go-log"))))
 
+(define-public go-github-com-whyrusleeping-cbor-gen
+  (package
+    (name "go-github-com-whyrusleeping-cbor-gen")
+    (version "v0.0.0-20230818171029-f91ae536ca25")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/whyrusleeping/cbor-gen")
+             (commit (go-version->git-ref version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "08by7pqh4fcwf2va01iif75yqkfssi6d48334404mmv9jmhzim60"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:import-path "github.com/whyrusleeping/cbor-gen"))
+    (propagated-inputs
+     (list go-github-com-ipfs-go-cid
+           go-github-com-google-go-cmp-cmp
+           go-golang-org-x-xerrors))
+    (home-page "https://github.com/whyrusleeping/cbor-gen")
+    (synopsis "Codegen for CBOR codecs on the specified types")
+    (description
+     "Basic utilities to generate fast path @url{https://cbor.io/, CBOR} codecs for
+types.")
+    (license license:expat)))
+
 (define-public gx
   (package
     (name "gx")
-- 
2.45.2

Message #26 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 71953 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH v2 3/3] gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.
Date: Sun,  7 Jul 2024 10:13:04 +0300

* gnu/packages/ipfs.scm (kubo): Unbundle go-github-com-ipfs-go-ipld-cbor.
[inputs]: Add go-github-com-ipfs-go-ipld-cbor.

Change-Id: I8edd09e134dee725f1ecaf8f4296c74c4cc5f37c
---
 gnu/packages/ipfs.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm
index 3c137818ae..6a6bd81caf 100644
--- a/gnu/packages/ipfs.scm
+++ b/gnu/packages/ipfs.scm
@@ -669,6 +669,7 @@ (define-public kubo
                              "vendor/github.com/ipfs/go-detect-race"
                              "vendor/github.com/ipfs/go-ipfs-delay"
                              "vendor/github.com/ipfs/go-ipfs-util"
+                             "vendor/github.com/ipfs/go-ipld-cbor"
                              "vendor/github.com/ipfs/go-ipld-format"
                              "vendor/github.com/ipfs/go-log"
                              "vendor/github.com/ipld/go-ipld-prime"
@@ -754,7 +755,7 @@ (define-public kubo
                   ;;go-github-com-ipfs-go-ds-measure
                   ;;go-github-com-ipfs-go-fs-lock
                   ;;go-github-com-ipfs-go-ipfs-cmds
-                  ;;go-github-com-ipfs-go-ipld-cbor
+                  go-github-com-ipfs-go-ipld-cbor
                   go-github-com-ipfs-go-ipld-format
                   ;;go-github-com-ipfs-go-ipld-git
                   ;;go-github-com-ipfs-go-ipld-legacy
-- 
2.45.2

Message #29 received at 71953 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 71953 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/3] gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.
Date: Sun, 07 Jul 2024 10:22:44 +0300

[Message part 1 (text/plain, inline)]

Hello Oleg!

Thanks for the patch review.  Please find patchset v2 in the issue.

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 71953-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 71953-done <at> debbugs.gnu.org
Subject: [PATCH 0/3] gnu: kubo: Unbundle go-github-com-ipfs-go-ipld-cbor.
Date: Sun, 07 Jul 2024 16:11:57 +0100

[Message part 1 (text/plain, inline)]

Hi,

Pushed as c6fae8a300..ff1bb647b5 to master. 

I've unbundled some more packages which were quite simple are combing as
dependencies for others.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.