GNU bug report logs - #71958
[PATCH] Improve `tab-line-tabs-fixed-window-buffers` sorting performance

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71958 in the body.
You can then email your comments to 71958 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Improve `tab-line-tabs-fixed-window-buffers` sorting
 performance
Date: Fri, 5 Jul 2024 19:11:54 +0800

[Message part 1 (text/plain, inline)]

[0001-Improve-tab-line-tabs-fixed-window-buffers-sorting-p.patch (text/x-patch, attachment)]

Message #8 received at 71958 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eval Exec <execvy <at> gmail.com>
Cc: 71958 <at> debbugs.gnu.org
Subject: Re: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers`
 sorting performance
Date: Sat, 06 Jul 2024 09:23:36 +0300

> From: Eval Exec <execvy <at> gmail.com>
> Date: Fri, 5 Jul 2024 19:11:54 +0800

Thanks.  I'll leave it to Juri to review the code and comment, but
just minor nits on your commit log message:

> * lsp/tab-line.el (tab-line-tabs-fixed-window-buffers): Enhanced
> `tab-line-tabs-fixed-window-buffers` performance by optimizing buffer
> sorting mechanism. Replaced inefficient `seq-position` calls with a hash
> table to cache buffer positions, significantly improving speed when
> handling large buffer lists.

Our style is to say "Enhance" and "Replace", not "Enhanced" and
"Replaced".  Also, we use the US English convention of leaving two
spaces between sentences.  Finally, please quote symbols 'like this',
not `like this`.

In addition, I'd encourage you to start your legal paperwork of
assigning the copyright to the FSF at this time, so we could accept
your contributions without any restrictions.  If you are willing to
start the paperwork now, I will send you the form to fill and the
instructions to go with it.

Message #13 received at 71958 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71958 <at> debbugs.gnu.org, Eval Exec <execvy <at> gmail.com>
Subject: Re: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers`
 sorting performance
Date: Sun, 07 Jul 2024 19:51:10 +0300

>> From: Eval Exec <execvy <at> gmail.com>
>> Date: Fri, 5 Jul 2024 19:11:54 +0800
>
> I'll leave it to Juri to review the code and comment, but
> just minor nits on your commit log message:

I confirm this is the right fix.
Thanks to Eval Exec.

> In addition, I'd encourage you to start your legal paperwork of
> assigning the copyright to the FSF at this time, so we could accept
> your contributions without any restrictions.  If you are willing to
> start the paperwork now, I will send you the form to fill and the
> instructions to go with it.

Do I understand correctly that this patch could be installed now
with Copyright-paperwork-exempt?

Message #16 received at 71958 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 71958 <at> debbugs.gnu.org, execvy <at> gmail.com
Subject: Re: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers`
 sorting performance
Date: Sun, 07 Jul 2024 20:33:53 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: Eval Exec <execvy <at> gmail.com>,  71958 <at> debbugs.gnu.org
> Date: Sun, 07 Jul 2024 19:51:10 +0300
> 
> >> From: Eval Exec <execvy <at> gmail.com>
> >> Date: Fri, 5 Jul 2024 19:11:54 +0800
> >
> > I'll leave it to Juri to review the code and comment, but
> > just minor nits on your commit log message:
> 
> I confirm this is the right fix.
> Thanks to Eval Exec.
> 
> > In addition, I'd encourage you to start your legal paperwork of
> > assigning the copyright to the FSF at this time, so we could accept
> > your contributions without any restrictions.  If you are willing to
> > start the paperwork now, I will send you the form to fill and the
> > instructions to go with it.
> 
> Do I understand correctly that this patch could be installed now
> with Copyright-paperwork-exempt?

Yes.  Please also mention the bug number in the log message when you
commit.

Thanks.

Message #19 received at 71958 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71958 <at> debbugs.gnu.org, execvy <at> gmail.com
Subject: Re: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers`
 sorting performance
Date: Sun, 07 Jul 2024 21:24:40 +0300

close 71958 30.0.60
thanks

>> > I'll leave it to Juri to review the code and comment, but
>> > just minor nits on your commit log message:
>> 
>> I confirm this is the right fix.
>> Thanks to Eval Exec.
>> 
>> > In addition, I'd encourage you to start your legal paperwork of
>> > assigning the copyright to the FSF at this time, so we could accept
>> > your contributions without any restrictions.  If you are willing to
>> > start the paperwork now, I will send you the form to fill and the
>> > instructions to go with it.
>> 
>> Do I understand correctly that this patch could be installed now
>> with Copyright-paperwork-exempt?
>
> Yes.  Please also mention the bug number in the log message when you
> commit.

Ok, so now done.

Message #24 received at 71958 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71958 <at> debbugs.gnu.org, execvy <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers`
 sorting performance
Date: Mon, 08 Jul 2024 22:46:42 -0400

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

How are you feeling these days?
-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Message #27 received at 71958 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71958 <at> debbugs.gnu.org, execvy <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers`
 sorting performance
Date: Fri, 12 Jul 2024 22:21:42 -0400

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

I meant to send "How are you feeling these days?" as a reply to a
different message.  Sorry for the confusion.

Alas, I can't find the message it was meant as a reply to.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.