GNU bug report logs - #71961
[PATCH] Improve tab-line-tabs-fixed-window-buffers performance

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71961 in the body.
You can then email your comments to 71961 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eval Exec <execvy <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Improve tab-line-tabs-fixed-window-buffers performance
Date: Fri, 5 Jul 2024 22:50:40 +0800

[Message part 1 (text/plain, inline)]

Hello,
After noticing severe lag when `buffer-list` exceeds 1000 buffers,
particularly
with `tab-line-switch-to-prev-tab` and `tab-line-switch-to-next-tab`,
a profiler
revealed that the sorting operation in
`tab-line-tabs-fixed-window-buffers` heavily
relies on the `seq-position` function. This reliance significantly
impacts performance.
To address this, I have proposed a patch to optimize the buffer
sorting mechanism within
`tab-line-tabs-fixed-window-buffers`. The solution involves replacing
the inefficient
`seq-position` calls with a hash table to cache buffer positions,
which markedly
enhances performance when handling large buffer lists.

This is my first attempt at hacking Emacs. Do you have any suggestions
on this idea?

Thank you

[0001-Improve-tab-line-tabs-fixed-window-buffers-performan.patch (text/x-patch, attachment)]

Message #12 received at 71961 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Bryant <jb <at> jeremybryant.net>
To: Eval Exec <execvy <at> gmail.com>
Cc: 71961 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#71961: [PATCH] Improve tab-line-tabs-fixed-window-buffers
 performance
Date: Sun, 07 Jul 2024 21:32:10 +0100

Eval Exec <execvy <at> gmail.com> writes:

> Hello,
> After noticing severe lag when `buffer-list` exceeds 1000 buffers,

1000?

> particularly
> with `tab-line-switch-to-prev-tab` and `tab-line-switch-to-next-tab`,
> a profiler
> revealed that the sorting operation in
> `tab-line-tabs-fixed-window-buffers` heavily
> relies on the `seq-position` function. This reliance significantly
> impacts performance.
> To address this, I have proposed a patch to optimize the buffer
> sorting mechanism within
> `tab-line-tabs-fixed-window-buffers`. The solution involves replacing
> the inefficient
> `seq-position` calls with a hash table to cache buffer positions,
> which markedly
> enhances performance when handling large buffer lists.
>
> This is my first attempt at hacking Emacs. Do you have any suggestions
> on this idea?

Adding Juri to this bug report

>
> Thank you
>
> [2. text/x-patch; 0001-Improve-tab-line-tabs-fixed-window-buffers-performan.patch]...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.