Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 71988) by debbugs.gnu.org; 1 Mar 2025 01:44:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 28 20:44:03 2025 Received: from localhost ([127.0.0.1]:55625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1toBtb-0002Es-4Y for submit <at> debbugs.gnu.org; Fri, 28 Feb 2025 20:44:03 -0500 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:56418) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1toBtY-0002E0-6O for 71988 <at> debbugs.gnu.org; Fri, 28 Feb 2025 20:44:00 -0500 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e4d50ed90aso2418905a12.0 for <71988 <at> debbugs.gnu.org>; Fri, 28 Feb 2025 17:44:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740793434; x=1741398234; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=H+omMgLFIsMqI8n7GPetFlERsjSVREVVVxfWTkQMW5U=; b=U9+o8pej2/GEyX3fUzzkzmCwqohDmftOp6ef0xSC1lT3fg+gqoQv7vQ07ueNK1zCFh TdsHNPfXegh4o9XEuIlMGfngQgYaNPrUD8c4j+w/AgWwcweUU4RqrinE8na94kPoRZaP vRSng7eTI97WaDhweLMOZVx5w7GLG+looJRh2pdYEgKt+8Zi8LeLGt4aWb5TYf8jscoi RrwjtCK3jPeaP2VVBX2e/emyeRkul8Amx8Ww4RyGsShQiRwzEZ0b1GT1873plOleJtgH rq7Y/W3gh+JxNHhYVdTe2/qGKMkTQCi0Q4GiDqp6kiMybT2yjHTPBGIRJfX5Hhf1E7fx pVUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740793434; x=1741398234; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H+omMgLFIsMqI8n7GPetFlERsjSVREVVVxfWTkQMW5U=; b=iyuoiXzHUqDKENm7X9YwxwIHb/+QA8pSCrlWwFg3hCqRLLhU92rCMpQvCcxUb0Hmfa Uhzj1gmr9h0bGBozZXkcvMfQW/qxlmJmuHtC2Uq3oSwnYkQzDIfS75TeImGU0vo2wKu5 8+FJL6bIpeusWQOJblUZLfZXkfRvQii+tJSCiEYq6phNZmpdgQC20qcc1Y8xKwKXbcLO jxhP3SpZdYa9WoMVDd21xyW3mG5u+bbqJSifX9HBNWDDmZ1UknPnC4sWh0l+8GnsoGcT laBcgZes1uKLDWhkrxz1UQxXIgHpjxc6k6K5Ntj97+6Sunj3NViWRYvTTxoLYJ6Xlot8 oSig== X-Gm-Message-State: AOJu0YxtYTKN7cv2YwHdW+AAbQnfH0iDasmm+bpbqoQANKjCR6lCgxHh uPxAULDlm58vApenacDH6GRd723zCEZWi47vTVKuBnfiQ644pY0KLnrv2i3JxZV7Z4hMJYSwfgq iSo+GEiK5cNIOlYRekYh1uQSCkCbhEA5h X-Gm-Gg: ASbGncvcf7AneU2YmF9wnG3iwFE1jqdNYirwb+LBylG+vWOhq3PeP2pEPuO3zKyFPn+ S2Khu+wkFTvklyrcSKzodBD4nQx51rw20n2+UEwy7pLqO/6y196o/KQZY5b1D0+THIbrLVHUzIf RyTOo/B1GO52qvvPpDZHQa1MqzbFc= X-Google-Smtp-Source: AGHT+IHyE3Ylhnvz9ld4d6Vqsibagn+y3Ej2hjbo6elD2laY5p9uWMAYebMlhH92hdQYBZxkeiQwQe2i+h8anE+n5p4= X-Received: by 2002:a05:6402:234e:b0:5dc:c9ce:b029 with SMTP id 4fb4d7f45d1cf-5e4d6acd607mr5553366a12.5.1740793433804; Fri, 28 Feb 2025 17:43:53 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Feb 2025 17:43:53 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <6c0eElmIpNe7IlK05in9_OGFsEl8V5pIXzstK4dtIKMEFmTRcuODoRybzXGb3M7O7GjZsN2onbJRq4robe_Nd8ivV_NlY8vzYV5SZnMjTIM=@protonmail.com> References: <cVt0dZOYriBO6Tpo1lJSHrnbA6ttTZvZIClty3TCFUNMfHf66UhbHi7A329CLnWz5ueIn3ypvcKDLsBynBK8wzd41YA29AKEPDgokIrVsqs=@protonmail.com> <6c0eElmIpNe7IlK05in9_OGFsEl8V5pIXzstK4dtIKMEFmTRcuODoRybzXGb3M7O7GjZsN2onbJRq4robe_Nd8ivV_NlY8vzYV5SZnMjTIM=@protonmail.com> MIME-Version: 1.0 Date: Fri, 28 Feb 2025 17:43:53 -0800 X-Gm-Features: AQ5f1JqxLJD0JJ6_3sST5qXPysCWrX_7SVhK-necDwFo_6fdGjm1a13BQu2Vq8k Message-ID: <CADwFkm=_EO1_5W757c-x+98QAb=oaV43pmxZVinA6oNqk6-=fQ@HIDDEN> Subject: Re: bug#71988: 31.0.50; ert-test-run-tests-batch-expensive runs out of memory if previous tests failed To: Pip Cet <pipcet@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71988 Cc: 71988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) tags 71988 + patch thanks Pip Cet <pipcet@HIDDEN> writes: > On Monday, July 8th, 2024 at 04:49, Pip Cet <pipcet@HIDDEN> wrote: >> This bug report is mostly to get a bug number to put in the patch :-). > > Which I'm now attaching. Sorry about that. Makes sense to me. How about installing it? > > Pip > > From 8f7e9b50f0edd33f601fab0842c5b4a7e4398490 Mon Sep 17 00:00:00 2001 > From: Pip Cet <pipcet@HIDDEN> > Date: Mon, 8 Jul 2024 19:50:16 +0000 > Subject: [PATCH] (Bug#71988) Avoid excessively large backtraces in ert-tests > > * test/lisp/emacs-lisp/ert-tests.el (ert-test-run-tests-batch-expensive): > Temporarily make `cl-print-object' not print out vectors while running > the test. > --- > test/lisp/emacs-lisp/ert-tests.el | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el > index 1aff73d66f6..4237d354f38 100644 > --- a/test/lisp/emacs-lisp/ert-tests.el > +++ b/test/lisp/emacs-lisp/ert-tests.el > @@ -594,9 +594,13 @@ ert-test-run-tests-batch-expensive > :body (lambda () (should (equal complex-list 1)))))) > (let ((ert-debug-on-error nil) > messages) > - (cl-letf* (((symbol-function 'message) > + (cl-letf* (((symbol-function 'cl-print-object) (symbol-function 'cl-print-object)) > + ((symbol-function 'message) > (lambda (format-string &rest args) > (push (apply #'format format-string args) messages)))) > + ;; don't print the ert--stats-tests vector, which would run out of > + ;; memory if previous tests have failed. > + (cl-defmethod cl-print-object ((object vector) stream)) > (save-window-excursion > (let ((case-fold-search nil) > (ert-batch-backtrace-right-margin nil) > @@ -611,7 +615,9 @@ ert-test-run-tests-batch-expensive > do > (unless found-frame > (setq found-frame (cl-search frame msg :test 'equal)))) > - (should found-frame))))) > + (should found-frame)))) > + ;; ensure our temporary binding was undone. > + (should (equal (cl-prin1-to-string [a]) "[a]"))) > > (ert-deftest ert-test-special-operator-p () > (should (ert--special-operator-p 'if))
bug-gnu-emacs@HIDDEN:bug#71988; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 8 Jul 2024 19:54:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 08 15:54:54 2024 Received: from localhost ([127.0.0.1]:51588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sQuRp-0000nT-Jx for submit <at> debbugs.gnu.org; Mon, 08 Jul 2024 15:54:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:41808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1sQuRn-0000nL-Me for submit <at> debbugs.gnu.org; Mon, 08 Jul 2024 15:54:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1sQuRi-00048m-Cm for bug-gnu-emacs@HIDDEN; Mon, 08 Jul 2024 15:54:46 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1sQuRS-0000Y8-Fm for bug-gnu-emacs@HIDDEN; Mon, 08 Jul 2024 15:54:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720468467; x=1720727667; bh=vUDxpgPz7ygSFOpAhmXFBM5HjRp0ITTSEo2WH5YHYoE=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=aNAOKK81dZ0eiM7ca+x18c+HVXJmFam4501od7/c3Yz8cZqLWRhO8NiSaNEuaeSPC iLqDJ1BegMcHMd5AwPy7lq17wSyL707xukkpsRVqC3+bv7L62vrPFZR0JL91A8JTu5 XR/0PrBXmhj59APQ80Hmjegv0yIh9a+rMeKuhBEw1r2t0X0aeIYBXcZjJfwBBRcBvY KdpVBrB/hGkm/X3/YHXYRKI8ADnjkX2FgGZTdDTWDCnWZw9rnGLIdQW2H1be5s61GB x4hCDoEjjQkdIv6Ig3zlFYxFaSF0NPD+dY8jeyOJoncWSoMNYrAXyRbaAlggc/0G7O QnPjFI1CGSTVg== Date: Mon, 08 Jul 2024 19:54:25 +0000 To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: 31.0.50; ert-test-run-tests-batch-expensive runs out of memory if previous tests failed Message-ID: <6c0eElmIpNe7IlK05in9_OGFsEl8V5pIXzstK4dtIKMEFmTRcuODoRybzXGb3M7O7GjZsN2onbJRq4robe_Nd8ivV_NlY8vzYV5SZnMjTIM=@protonmail.com> In-Reply-To: <cVt0dZOYriBO6Tpo1lJSHrnbA6ttTZvZIClty3TCFUNMfHf66UhbHi7A329CLnWz5ueIn3ypvcKDLsBynBK8wzd41YA29AKEPDgokIrVsqs=@protonmail.com> References: <cVt0dZOYriBO6Tpo1lJSHrnbA6ttTZvZIClty3TCFUNMfHf66UhbHi7A329CLnWz5ueIn3ypvcKDLsBynBK8wzd41YA29AKEPDgokIrVsqs=@protonmail.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 66c6fb40af9fc10369a55b8589d8294e8b31387b MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_NcyyhaPT7SGCYk8Naz6CgWVtJ2UttvoNMnrg" Received-SPF: pass client-ip=185.70.40.134; envelope-from=pipcet@HIDDEN; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_NcyyhaPT7SGCYk8Naz6CgWVtJ2UttvoNMnrg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Monday, July 8th, 2024 at 04:49, Pip Cet <pipcet@HIDDEN> wrote: > This bug report is mostly to get a bug number to put in the patch :-). Which I'm now attaching. Sorry about that. Pip --b1_NcyyhaPT7SGCYk8Naz6CgWVtJ2UttvoNMnrg Content-Type: text/x-patch; name=0001-Bug-71988-Avoid-excessively-large-backtraces-in-ert-.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Bug-71988-Avoid-excessively-large-backtraces-in-ert-.patch RnJvbSA4ZjdlOWI1MGYwZWRkMzNmNjAxZmFiMDg0MmM1YjRhN2U0Mzk4NDkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAcHJvdG9ubWFpbC5jb20+CkRhdGU6 IE1vbiwgOCBKdWwgMjAyNCAxOTo1MDoxNiArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIChCdWcjNzE5 ODgpIEF2b2lkIGV4Y2Vzc2l2ZWx5IGxhcmdlIGJhY2t0cmFjZXMgaW4gZXJ0LXRlc3RzCgoqIHRl c3QvbGlzcC9lbWFjcy1saXNwL2VydC10ZXN0cy5lbCAoZXJ0LXRlc3QtcnVuLXRlc3RzLWJhdGNo LWV4cGVuc2l2ZSk6ClRlbXBvcmFyaWx5IG1ha2UgYGNsLXByaW50LW9iamVjdCcgbm90IHByaW50 IG91dCB2ZWN0b3JzIHdoaWxlIHJ1bm5pbmcKdGhlIHRlc3QuCi0tLQogdGVzdC9saXNwL2VtYWNz LWxpc3AvZXJ0LXRlc3RzLmVsIHwgMTAgKysrKysrKystLQogMSBmaWxlIGNoYW5nZWQsIDggaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3Mt bGlzcC9lcnQtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9lcnQtdGVzdHMuZWwKaW5k ZXggMWFmZjczZDY2ZjYuLjQyMzdkMzU0ZjM4IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3Mt bGlzcC9lcnQtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvZXJ0LXRlc3RzLmVs CkBAIC01OTQsOSArNTk0LDEzIEBAIGVydC10ZXN0LXJ1bi10ZXN0cy1iYXRjaC1leHBlbnNpdmUK IAkJCSA6Ym9keSAobGFtYmRhICgpIChzaG91bGQgKGVxdWFsIGNvbXBsZXgtbGlzdCAxKSkpKSkp CiAgICAgKGxldCAoKGVydC1kZWJ1Zy1vbi1lcnJvciBuaWwpCiAgICAgICAgICAgbWVzc2FnZXMp Ci0gICAgICAoY2wtbGV0ZiogKCgoc3ltYm9sLWZ1bmN0aW9uICdtZXNzYWdlKQorICAgICAgKGNs LWxldGYqICgoKHN5bWJvbC1mdW5jdGlvbiAnY2wtcHJpbnQtb2JqZWN0KSAoc3ltYm9sLWZ1bmN0 aW9uICdjbC1wcmludC1vYmplY3QpKQorICAgICAgICAgICAgICAgICAoKHN5bWJvbC1mdW5jdGlv biAnbWVzc2FnZSkKICAgICAgICAgICAgICAgICAgIChsYW1iZGEgKGZvcm1hdC1zdHJpbmcgJnJl c3QgYXJncykKICAgICAgICAgICAgICAgICAgICAgKHB1c2ggKGFwcGx5ICMnZm9ybWF0IGZvcm1h dC1zdHJpbmcgYXJncykgbWVzc2FnZXMpKSkpCisgICAgICAgIDs7IGRvbid0IHByaW50IHRoZSBl cnQtLXN0YXRzLXRlc3RzIHZlY3Rvciwgd2hpY2ggd291bGQgcnVuIG91dCBvZgorICAgICAgICA7 OyBtZW1vcnkgaWYgcHJldmlvdXMgdGVzdHMgaGF2ZSBmYWlsZWQuCisgICAgICAgIChjbC1kZWZt ZXRob2QgY2wtcHJpbnQtb2JqZWN0ICgob2JqZWN0IHZlY3Rvcikgc3RyZWFtKSkKICAgICAgICAg KHNhdmUtd2luZG93LWV4Y3Vyc2lvbgogICAgICAgICAgIChsZXQgKChjYXNlLWZvbGQtc2VhcmNo IG5pbCkKICAgICAgICAgICAgICAgICAoZXJ0LWJhdGNoLWJhY2t0cmFjZS1yaWdodC1tYXJnaW4g bmlsKQpAQCAtNjExLDcgKzYxNSw5IEBAIGVydC10ZXN0LXJ1bi10ZXN0cy1iYXRjaC1leHBlbnNp dmUKIAkJIGRvCiAJCSAodW5sZXNzIGZvdW5kLWZyYW1lCiAJCSAgIChzZXRxIGZvdW5kLWZyYW1l IChjbC1zZWFyY2ggZnJhbWUgbXNnIDp0ZXN0ICdlcXVhbCkpKSkKLSAgICAgICAgKHNob3VsZCBm b3VuZC1mcmFtZSkpKSkpCisgICAgICAgIChzaG91bGQgZm91bmQtZnJhbWUpKSkpCisgIDs7IGVu c3VyZSBvdXIgdGVtcG9yYXJ5IGJpbmRpbmcgd2FzIHVuZG9uZS4KKyAgKHNob3VsZCAoZXF1YWwg KGNsLXByaW4xLXRvLXN0cmluZyBbYV0pICJbYV0iKSkpCiAKIChlcnQtZGVmdGVzdCBlcnQtdGVz dC1zcGVjaWFsLW9wZXJhdG9yLXAgKCkKICAgKHNob3VsZCAoZXJ0LS1zcGVjaWFsLW9wZXJhdG9y LXAgJ2lmKSkKLS0gCjIuNDUuMgoK --b1_NcyyhaPT7SGCYk8Naz6CgWVtJ2UttvoNMnrg--
bug-gnu-emacs@HIDDEN:bug#71988; Package emacs.
Full text available.Received: (at 71988) by debbugs.gnu.org; 8 Jul 2024 11:17:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 08 07:17:48 2024 Received: from localhost ([127.0.0.1]:49819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sQmNQ-00061F-1g for submit <at> debbugs.gnu.org; Mon, 08 Jul 2024 07:17:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sQmNN-000612-68 for 71988 <at> debbugs.gnu.org; Mon, 08 Jul 2024 07:17:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sQmNB-0003Va-6n; Mon, 08 Jul 2024 07:17:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OyZZ8Tq2qaEmXD69ZoOuaBUQjsdtIm7XW0jz5cU4uA8=; b=Jwcc171u8K6/ 11k4UJu5Dgq2A69IQaglC0ruF1zNprITfehSOz2s+r7JiFNmGaxW3IBXTgTU0dcW1JgZQACJCH7cx gNHMVuLdpfz9dSHvAvKDiRsDMfYzWSpvCYIN2mD04P9kmrw714joqhCn92uWKAoH7OGEsuG6dDV3n C7x91Py7irRt4fGDT3uXoDpQ8k8x3yNiuGFTHOIbdLODD+n6gysN/I6EncdruM50tN2p2Dw7LBf7X S0tv8eviYNTJgf4vKs0haaUO19i1UlELgRKPZQcQ+Qga5cy22D+C2KDoczjoQbjU8krYafZeZ28qm XK1UsVGKBgm8/Sds602HLw==; Date: Mon, 08 Jul 2024 14:17:26 +0300 Message-Id: <868qyc16bd.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN>, Stefan Monnier <monnier@HIDDEN> In-Reply-To: <cVt0dZOYriBO6Tpo1lJSHrnbA6ttTZvZIClty3TCFUNMfHf66UhbHi7A329CLnWz5ueIn3ypvcKDLsBynBK8wzd41YA29AKEPDgokIrVsqs=@protonmail.com> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#71988: 31.0.50; ert-test-run-tests-batch-expensive runs out of memory if previous tests failed References: <cVt0dZOYriBO6Tpo1lJSHrnbA6ttTZvZIClty3TCFUNMfHf66UhbHi7A329CLnWz5ueIn3ypvcKDLsBynBK8wzd41YA29AKEPDgokIrVsqs=@protonmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71988 Cc: 71988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Mon, 08 Jul 2024 04:49:54 +0000 > From: Pip Cet via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > This bug report is mostly to get a bug number to put in the patch :-). > > The test `ert-test-run-tests-batch-expensive' overrides print settings > and prints a full backtrace to a temporary buffer repeatedly. If a > previous test, such as `ert-test-run-tests-batch', failed, this > eventually runs out of memory even on a 64 GB system. > > For example, one can add "(should nil)" to ert-test-run-tests-batch and > run: > > $ make -C test lisp/emacs-lisp/ert-tests > > The problem is the ert--stats structure's tests vector is being printed, > which recursively prints all previous tests' data. > > A possible fix is to temporarily override cl-print-object for either > vectors or the ert--stats object to print nothing. > > Unfortunately, we don't appear to have an official mechanism for > temporarily calling cl-defmethod, such as a generalized variable one can > cl-letf to. The patch does that by running cl-defmethod inside a > (cl-letf* (((symbol-function 'cl-print-object) (symbol-function > 'cl-print-object))) ...) form. As future changes to cl-generic might > break that, an additional test is added to make sure our binding is > undone and die loudly if it hasn't been. > > This also speeds up the test significantly and it might be possible to > remove the :unstable tag. > > > diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el > index 1aff73d66f6..2f8e7382bea 100644 > --- a/test/lisp/emacs-lisp/ert-tests.el > +++ b/test/lisp/emacs-lisp/ert-tests.el > @@ -583,6 +583,7 @@ ert-test-run-tests-batch > (setq found-long (string-match long-text msg))) > (unless found-complex > (setq found-complex (string-match complex-text msg)))) > + (should nil) > (should found-long) > (should found-complex))))) Stefan, any comments or suggestions?
bug-gnu-emacs@HIDDEN:bug#71988; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 8 Jul 2024 04:50:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 08 00:50:15 2024 Received: from localhost ([127.0.0.1]:49432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sQgKN-0001Ix-5t for submit <at> debbugs.gnu.org; Mon, 08 Jul 2024 00:50:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:47826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1sQgKI-0001Ig-61 for submit <at> debbugs.gnu.org; Mon, 08 Jul 2024 00:50:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1sQgKD-0007UR-4b for bug-gnu-emacs@HIDDEN; Mon, 08 Jul 2024 00:50:05 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1sQgKB-0005Hr-12 for bug-gnu-emacs@HIDDEN; Mon, 08 Jul 2024 00:50:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720414199; x=1720673399; bh=bYP0Bqf2rYXqh5HDI9cy2Z0QynYzxXXyaov2PNNKZoc=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=IQEFFwfac7AGfB5KBP5Sm2JTMEA4kT9/P1KbmkZwPDmx422wg4Iyh1RYZe04YO0Uf TeakBuzIHBaS7GedYGmANfn2FyYexkYWBIpADfrJ48ARyWIInBz4eULxD2VsvvMqht iia7sT13JjVB1oj85jKvYzcWP0qiqb1KESxzcJQw/cWxvHnmp8VinbH2bHzpscZaxB N+Rf55T2V76UCYQdHkZTGdE6S+v2x6CjMfqf7/euxPDjhxudv7HovUUocNS2+YGeHp 8eOUtMH2Ptcs7+wSP2+hd93Cs4lp71ffBHDGryiWyGd9Qm01Dye/+ceVeLotPJzTWz ntPNiCI/XT1qA== Date: Mon, 08 Jul 2024 04:49:54 +0000 To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: 31.0.50; ert-test-run-tests-batch-expensive runs out of memory if previous tests failed Message-ID: <cVt0dZOYriBO6Tpo1lJSHrnbA6ttTZvZIClty3TCFUNMfHf66UhbHi7A329CLnWz5ueIn3ypvcKDLsBynBK8wzd41YA29AKEPDgokIrVsqs=@protonmail.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: c3bc2e178bc72cc98d90675c2902e047b333df0e MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_zSKYbvc3qGge9nyFVYnxffM8Cg6iz8q7xeMH5pse4w" Received-SPF: pass client-ip=185.70.40.134; envelope-from=pipcet@HIDDEN; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_zSKYbvc3qGge9nyFVYnxffM8Cg6iz8q7xeMH5pse4w Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable This bug report is mostly to get a bug number to put in the patch :-). The test `ert-test-run-tests-batch-expensive' overrides print settings and prints a full backtrace to a temporary buffer repeatedly. If a previous test, such as `ert-test-run-tests-batch', failed, this eventually runs out of memory even on a 64 GB system. For example, one can add "(should nil)" to ert-test-run-tests-batch and run: $ make -C test lisp/emacs-lisp/ert-tests The problem is the ert--stats structure's tests vector is being printed, which recursively prints all previous tests' data. A possible fix is to temporarily override cl-print-object for either vectors or the ert--stats object to print nothing. Unfortunately, we don't appear to have an official mechanism for temporarily calling cl-defmethod, such as a generalized variable one can cl-letf to. The patch does that by running cl-defmethod inside a (cl-letf* (((symbol-function 'cl-print-object) (symbol-function 'cl-print-object))) ...) form. As future changes to cl-generic might break that, an additional test is added to make sure our binding is undone and die loudly if it hasn't been. This also speeds up the test significantly and it might be possible to remove the :unstable tag. --b1_zSKYbvc3qGge9nyFVYnxffM8Cg6iz8q7xeMH5pse4w Content-Type: text/x-patch; name=0001-ert-tests-reproducer.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-ert-tests-reproducer.patch ZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2VydC10ZXN0cy5lbCBiL3Rlc3QvbGlz cC9lbWFjcy1saXNwL2VydC10ZXN0cy5lbAppbmRleCAxYWZmNzNkNjZmNi4uMmY4ZTczODJiZWEg MTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2VydC10ZXN0cy5lbAorKysgYi90ZXN0 L2xpc3AvZW1hY3MtbGlzcC9lcnQtdGVzdHMuZWwKQEAgLTU4Myw2ICs1ODMsNyBAQCBlcnQtdGVz dC1ydW4tdGVzdHMtYmF0Y2gKIAkJICAgKHNldHEgZm91bmQtbG9uZyAoc3RyaW5nLW1hdGNoIGxv bmctdGV4dCBtc2cpKSkKIAkJICh1bmxlc3MgZm91bmQtY29tcGxleAogCQkgICAoc2V0cSBmb3Vu ZC1jb21wbGV4IChzdHJpbmctbWF0Y2ggY29tcGxleC10ZXh0IG1zZykpKSkKKyAgICAgICAgKHNo b3VsZCBuaWwpCiAJKHNob3VsZCBmb3VuZC1sb25nKQogCShzaG91bGQgZm91bmQtY29tcGxleCkp KSkpCiAK --b1_zSKYbvc3qGge9nyFVYnxffM8Cg6iz8q7xeMH5pse4w Content-Type: text/x-patch; name=0001-ert-tests.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-ert-tests.patch ZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2VydC10ZXN0cy5lbCBiL3Rlc3QvbGlz cC9lbWFjcy1saXNwL2VydC10ZXN0cy5lbAppbmRleCAxYWZmNzNkNjZmNi4uNGNiNTIzZDJmZjEg MTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2VydC10ZXN0cy5lbAorKysgYi90ZXN0 L2xpc3AvZW1hY3MtbGlzcC9lcnQtdGVzdHMuZWwKQEAgLTU2OSw3ICs1NjksNyBAQCBlcnQtdGVz dC1ydW4tdGVzdHMtYmF0Y2gKICAgICAgICAgKHNhdmUtd2luZG93LWV4Y3Vyc2lvbgogICAgICAg ICAgIChsZXQgKChjYXNlLWZvbGQtc2VhcmNoIG5pbCkKICAgICAgICAgICAgICAgICAoZXJ0LWJh dGNoLWJhY2t0cmFjZS1yaWdodC1tYXJnaW4gbmlsKQotCQkoZXJ0LWJhdGNoLXByaW50LWxldmVs IDEwKQorCQkoZXJ0LWJhdGNoLXByaW50LWxldmVsIDEpCiAJCShlcnQtYmF0Y2gtcHJpbnQtbGVu Z3RoIDExKSkKICAgICAgICAgICAgIChlcnQtcnVuLXRlc3RzLWJhdGNoCiAgICAgICAgICAgICAg YChtZW1iZXIgLGZhaWxpbmctdGVzdC0xICxmYWlsaW5nLXRlc3QtMikpKSkpCg== --b1_zSKYbvc3qGge9nyFVYnxffM8Cg6iz8q7xeMH5pse4w--
Pip Cet <pipcet@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#71988; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.