GNU bug report logs - #71990
[PATCH] gnu: Add emacs-empv.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71990 in the body.
You can then email your comments to 71990 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: guix-patches <at> gnu.org
Cc: Thanos Apollo <public <at> thanosapollo.org>
Subject: [PATCH] gnu: Add emacs-empv.
Date: Mon,  8 Jul 2024 09:27:57 +0300

* gnu/packages/emacs-xyz.scm (emacs-empv): New variable.

Change-Id: Ibfb0fca623a536e8db27b15b87e76ef9d7d5a742
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c82e264930..0bb115ee42 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3730,6 +3730,34 @@ (define-public emacs-emprise
 Selectrum.")
     (license license:gpl3+)))
 
+(define-public emacs-empv
+  (let ((commit "631299ae2a918b4af17ae94eddcde4c9451235bb"))
+    (package
+      (name "emacs-empv")
+      (version "v4.2.0")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/isamert/empv.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0njqzri2qvpsdbkrkr1lidg2zc2742nzapwgdjaf5ms3rl8kc898"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       (list emacs-compat
+	     emacs-s))
+      (home-page "https://github.com/isamert/empv.el")
+      (synopsis "An Emacs media player, media library manager, radio player, YouTube frontend ")
+      (description
+       "An Emacs media player, based on mpv.  More precisely this package
+provides somewhat comprehensive interface to mpv with bunch of
+convenient functionality like an embedded radio manager, YouTube
+interface, local music/video library manager etc.")
+      (license license:gpl3+))))
+
 (define-public emacs-marginalia-emprise
   (package
     (name "emacs-marginalia-emprise")

base-commit: 5217ea6d45bef053844d8360a06252b9436783b3
-- 
2.45.2

Message #8 received at 71990 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Thanos Apollo <public <at> thanosapollo.org>
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 71990 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#71990] [PATCH] gnu: Add emacs-empv.
Date: Mon, 08 Jul 2024 10:02:05 +0200

Hello,

Thanos Apollo <public <at> thanosapollo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-empv): New variable.

Thank you. Some comments follow.

> +(define-public emacs-empv
> +  (let ((commit "631299ae2a918b4af17ae94eddcde4c9451235bb"))
> +    (package
> +      (name "emacs-empv")
> +      (version "v4.2.0")

Upstream version is confusing. The main file says its 4.3.0, but last
tag, created one day before bumping to 4.3.0, mentions 4.2.0-RC1.

Moreover, commit 631299... does not match a version bump. So, you should
also bind `revision' to, e.g., "0". and use `git-file-name'.

Eventually, you need to remove the "v" from the version string. It
belongs to the tag, not the version.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/isamert/empv.el")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0njqzri2qvpsdbkrkr1lidg2zc2742nzapwgdjaf5ms3rl8kc898"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +       (list emacs-compat
> +	     emacs-s))

You can write propagated inputs on a single line.

  (propagated-inputs (list emacs-compat emacs-s))

> +      (home-page "https://github.com/isamert/empv.el")
> +      (synopsis "An Emacs media player, media library manager, radio player, YouTube frontend ")

Please remove the article "An" and the trailing white space.

> +      (description
> +       "An Emacs media player, based on mpv.  More precisely this package
> +provides somewhat comprehensive interface to mpv with bunch of
> +convenient functionality like an embedded radio manager, YouTube
> +interface, local music/video library manager etc.")
> +      (license license:gpl3+))))

Description should consist of complete sentences. I suggest something
like:

  "This package is an Emacs player, based on MPV.  More precisely, it
  [...], local music and video library manager, etc."

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 71990 <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: 71990 <at> debbugs.gnu.org
Cc: Thanos Apollo <public <at> thanosapollo.org>
Subject: [PATCH 1/2] gnu: Add emacs-empv.
Date: Mon,  8 Jul 2024 19:41:53 +0300

* gnu/packages/emacs-xyz.scm (emacs-empv): New variable.

Change-Id: Ibfb0fca623a536e8db27b15b87e76ef9d7d5a742
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d5257f16a9..97d13e4635 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3730,6 +3730,34 @@ (define-public emacs-emprise
 Selectrum.")
     (license license:gpl3+)))
 
+(define-public emacs-empv
+  (let ((commit "631299ae2a918b4af17ae94eddcde4c9451235bb")
+        (revision "0"))
+    (package
+      (name "emacs-empv")
+      (version (git-version "4.3.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/isamert/empv.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0njqzri2qvpsdbkrkr1lidg2zc2742nzapwgdjaf5ms3rl8kc898"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       (list emacs-compat emacs-s))
+      (home-page "https://github.com/isamert/empv.el")
+      (synopsis "Emacs media player, media library manager, radio player, YouTube frontend")
+      (description
+       "Emacs multimedia player based on MPV.  This package offers a
+comprehensive interface to mpv, including convenient features such as an
+embedded radio manager, YouTube integration, and a local music/video library
+manager.")
+      (license license:gpl3+))))
+
 (define-public emacs-marginalia-emprise
   (package
     (name "emacs-marginalia-emprise")

base-commit: 13f0f52314244f08eb9fdd626d907c0c3976e06a
-- 
2.45.2

Message #16 received at 71990-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Thanos Apollo <public <at> thanosapollo.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 71990-done <at> debbugs.gnu.org
Subject: Re: [bug#71990] [PATCH 1/2] gnu: Add emacs-empv.
Date: Tue, 09 Jul 2024 10:07:59 +0200

Hello,

Thanos Apollo <public <at> thanosapollo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-empv): New variable.

I bumped it to the (very recent) latest upstream commit and applied your
patch. Thank you!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.