GNU bug report logs - #71991
[PATCH 2/2] gnu: emacs-yeetube: Update to 2.1.7

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71991 in the body.
You can then email your comments to 71991 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: guix-patches <at> gnu.org
Cc: Thanos Apollo <public <at> thanosapollo.org>
Subject: [PATCH 2/2] gnu: emacs-yeetube: Update to 2.1.7
Date: Mon,  8 Jul 2024 10:17:35 +0300

* gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.7.

Change-Id: Ib5de9ca8d155740da2a5f7ecdba9b349e366def3
---
 gnu/packages/emacs-xyz.scm | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0bb115ee42..e9e7f06603 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -29238,10 +29238,10 @@ (define-public emacs-ytel-show
       (license license:gpl3+))))
 
 (define-public emacs-yeetube
-  (let ((commit "c9721a295f4fd30a44e94b3424151fa8a14d22ae")) ;version bump
+  (let ((commit "5c0a3efd2fb5cc25a6a90741ad198e31fdb15640"))
     (package
       (name "emacs-yeetube")
-      (version "2.1.6")
+      (version "2.1.7")
       (source
        (origin
          (method git-fetch)
@@ -29250,7 +29250,7 @@ (define-public emacs-yeetube
                (commit commit)))
          (sha256
           (base32
-           "0lrcs0n30h800sm6py4av44a3fcfgasmj223mnl76q34syyrgz6k"))
+           "0a3pm8cz6yl5s2xnbnjvdwm8mf5hyman419xl4fyyfgwy6vrxp70"))
          (file-name (git-file-name name version))))
       (build-system emacs-build-system)
       (arguments
@@ -29272,13 +29272,10 @@ (define-public emacs-yeetube
       (inputs (list mpv torsocks yt-dlp))
       (propagated-inputs (list emacs-compat))
       (home-page "https://thanosapollo.org/projects/yeetube/")
-      (synopsis "Youtube and Invidious front-end for Emacs")
+      (synopsis "Youtube front-end for Emacs")
       (description
-       "This package offers an Emacs interface that allows you to search YouTube
-or an Invidious instance for a specific query.  The search results are shown
-as links in an Org mode buffer.  The videos can be opened to a user-defined
-video player (by default @command{mpv}) or downloaded using @command{yt-dlp}.
-This package also includes a @code{yt-dlp} front-end.")
+       "This package provides the ability to scrape YouTube, with the results
+displayed in a tabulated list.")
       (license license:gpl3+))))
 
 (define-public emacs-org-web-tools
-- 
2.45.2

Message #8 received at 71991 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Thanos Apollo <public <at> thanosapollo.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 71991 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#71991] [PATCH 2/2] gnu: emacs-yeetube: Update to 2.1.7
Date: Mon, 08 Jul 2024 10:05:46 +0200

Hello,

Thanos Apollo <public <at> thanosapollo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.7.

Thank you. Some comments follow.

>  (define-public emacs-yeetube
> -  (let ((commit "c9721a295f4fd30a44e94b3424151fa8a14d22ae")) ;version bump
> +  (let ((commit "5c0a3efd2fb5cc25a6a90741ad198e31fdb15640"))

Why did you remove the comment?

> -      (synopsis "Youtube and Invidious front-end for Emacs")
> +      (synopsis "Youtube front-end for Emacs")
>        (description
> -       "This package offers an Emacs interface that allows you to search YouTube
> -or an Invidious instance for a specific query.  The search results are shown
> -as links in an Org mode buffer.  The videos can be opened to a user-defined
> -video player (by default @command{mpv}) or downloaded using @command{yt-dlp}.
> -This package also includes a @code{yt-dlp} front-end.")
> +       "This package provides the ability to scrape YouTube, with the results
> +displayed in a tabulated list.")

The changes to synopsis and description should be mentioned in the
commit log, too.

Please note that I find the new description much less informative. In
particular, I find "scrape YouTube" not being very clear. May you
expound this a bit?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 71991 <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: 71991 <at> debbugs.gnu.org
Cc: Thanos Apollo <public <at> thanosapollo.org>
Subject: [PATCH 2/2] gnu: emacs-yeetube: Update to 2.1.7
Date: Mon,  8 Jul 2024 19:54:26 +0300

* gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.7.
[synopsis]: Remove deprecated invidious functionality
[description]: Rephrase & remove deprecated org-mode functionality

Change-Id: Ib5de9ca8d155740da2a5f7ecdba9b349e366def3
---
 gnu/packages/emacs-xyz.scm | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 97d13e4635..901a5f49a0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -29263,10 +29263,10 @@ (define-public emacs-ytel-show
       (license license:gpl3+))))
 
 (define-public emacs-yeetube
-  (let ((commit "c9721a295f4fd30a44e94b3424151fa8a14d22ae")) ;version bump
+  (let ((commit "5c0a3efd2fb5cc25a6a90741ad198e31fdb15640")) ;version bump
     (package
       (name "emacs-yeetube")
-      (version "2.1.6")
+      (version "2.1.7")
       (source
        (origin
          (method git-fetch)
@@ -29275,7 +29275,7 @@ (define-public emacs-yeetube
                (commit commit)))
          (sha256
           (base32
-           "0lrcs0n30h800sm6py4av44a3fcfgasmj223mnl76q34syyrgz6k"))
+           "0a3pm8cz6yl5s2xnbnjvdwm8mf5hyman419xl4fyyfgwy6vrxp70"))
          (file-name (git-file-name name version))))
       (build-system emacs-build-system)
       (arguments
@@ -29297,13 +29297,12 @@ (define-public emacs-yeetube
       (inputs (list mpv torsocks yt-dlp))
       (propagated-inputs (list emacs-compat))
       (home-page "https://thanosapollo.org/projects/yeetube/")
-      (synopsis "Youtube and Invidious front-end for Emacs")
+      (synopsis "Youtube front-end for Emacs")
       (description
-       "This package offers an Emacs interface that allows you to search YouTube
-or an Invidious instance for a specific query.  The search results are shown
-as links in an Org mode buffer.  The videos can be opened to a user-defined
+       "This package provides the ability to scrape YouTube, with the results
+displayed in a tabulated list format.  The videos can be opened with a user-defined
 video player (by default @command{mpv}) or downloaded using @command{yt-dlp}.
-This package also includes a @code{yt-dlp} front-end.")
+This package also includes a minimal @code{yt-dlp} wrapper.")
       (license license:gpl3+))))
 
 (define-public emacs-org-web-tools
-- 
2.45.2

Message #14 received at 71991 <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: 71991 <at> debbugs.gnu.org
Cc: Thanos Apollo <public <at> thanosapollo.org>
Subject: [PATCH] gnu: emacs-emacsql: Update to 3.1.1-2-29194a6.
Date: Mon,  8 Jul 2024 20:44:33 +0300

* gnu/packages/emacs-xyz.scm (emacs-emacsql): Update to commit
29194a6.

Change-Id: I2b5cb10f62c2a9fe07bdd03a4688a2c4d0435e30
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d5257f16a9..c8c6f6ebd1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -23271,8 +23271,8 @@ (define-public emacs-finalize
   (license license:unlicense)))
 
 (define-public emacs-emacsql
-  (let ((commit "29194a63ede3ee24c7457c2fde03b0f1320ca4b1")
-        (revision "1"))
+  (let ((commit "1abwc7kzlmk6z68glnya6kxffrrqrhgpwrpzqpjc1l179gg1i1rg")
+        (revision "2"))
     (package
       (name "emacs-emacsql")
       (version (git-version "3.1.1" revision commit))

base-commit: 13f0f52314244f08eb9fdd626d907c0c3976e06a
-- 
2.45.2

Message #17 received at 71991 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Thanos Apollo <public <at> thanosapollo.org>, 71991 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#71991] [PATCH] gnu: emacs-emacsql: Update to 3.1.1-2-29194a6.
Date: Mon, 08 Jul 2024 20:34:58 +0200

Am Montag, dem 08.07.2024 um 20:44 +0300 schrieb Thanos Apollo:
> * gnu/packages/emacs-xyz.scm (emacs-emacsql): Update to commit
> 29194a6.
> 
> Change-Id: I2b5cb10f62c2a9fe07bdd03a4688a2c4d0435e30
> ---
>  gnu/packages/emacs-xyz.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index d5257f16a9..c8c6f6ebd1 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -23271,8 +23271,8 @@ (define-public emacs-finalize
>    (license license:unlicense)))
>  
>  (define-public emacs-emacsql
> -  (let ((commit "29194a63ede3ee24c7457c2fde03b0f1320ca4b1")
> -        (revision "1"))
> +  (let ((commit
> "1abwc7kzlmk6z68glnya6kxffrrqrhgpwrpzqpjc1l179gg1i1rg")
> +        (revision "2"))
>      (package
>        (name "emacs-emacsql")
>        (version (git-version "3.1.1" revision commit))
No hash change?  Suspicious.

Also, watch out your bug IDs, it seems you're reusing them
inadvertently.

Cheers

Message #20 received at 71991 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Thanos Apollo <public <at> thanosapollo.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 71991 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#71991] [PATCH] gnu: emacs-emacsql: Update to 3.1.1-2-29194a6.
Date: Mon, 08 Jul 2024 20:37:57 +0200

Hello,

Thanos Apollo <public <at> thanosapollo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-emacsql): Update to commit
> 29194a6.

Thanks, that was quick.

>  (define-public emacs-emacsql
> -  (let ((commit "29194a63ede3ee24c7457c2fde03b0f1320ca4b1")
> -        (revision "1"))
> +  (let ((commit "1abwc7kzlmk6z68glnya6kxffrrqrhgpwrpzqpjc1l179gg1i1rg")
> +        (revision "2"))

The commit hash looks wrong. Did you mix the commit and the sha256 hash?

Regards,
-- 
Nicolas Goaziou

Message #23 received at 71991 <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: 71991 <at> debbugs.gnu.org
Cc: Thanos Apollo <public <at> thanosapollo.org>
Subject: [PATCH] gnu: emacs-emacsql: Update to 3.1.1-2.efddd69.
Date: Mon,  8 Jul 2024 22:06:48 +0300

* gnu/packages/emacs-xyz.scm (emacs-emacsql): Update to commit
efddd69.

Change-Id: Ib9d025fd8bf040fe2458fa54ac40bd16f35795dd
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d5257f16a9..a1851086a2 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -23271,8 +23271,8 @@ (define-public emacs-finalize
   (license license:unlicense)))
 
 (define-public emacs-emacsql
-  (let ((commit "29194a63ede3ee24c7457c2fde03b0f1320ca4b1")
-        (revision "1"))
+  (let ((commit "efddd69c5e69214dbbe921fbf90f938501414894")
+        (revision "2"))
     (package
       (name "emacs-emacsql")
       (version (git-version "3.1.1" revision commit))
@@ -23284,7 +23284,7 @@ (define-public emacs-emacsql
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "14yj53xxqi3009bdj39k2fqwyc896yp2m7gdkgyv47wlkh1xwzxh"))))
+          (base32 "1abwc7kzlmk6z68glnya6kxffrrqrhgpwrpzqpjc1l179gg1i1rg"))))
       (build-system emacs-build-system)
       (arguments
        (list

base-commit: 13f0f52314244f08eb9fdd626d907c0c3976e06a
-- 
2.45.2

Message #26 received at 71991 <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 71991 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#71991] [PATCH] gnu: emacs-emacsql: Update to 3.1.1-2-29194a6.
Date: Mon, 08 Jul 2024 22:09:40 +0300

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:


[...]

> The commit hash looks wrong. Did you mix the commit and the sha256 hash?

Yeap, thanks for catching this!


Cheers,

-- 

Thanos Apollo
 
https://thanosapollo.org

62B7 58D0 F671 9938 BC09 CECA 339F 736C 3A72 0928

Message #31 received at 71991-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Thanos Apollo <public <at> thanosapollo.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 71991-done <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#71991] [PATCH] gnu: emacs-emacsql: Update to 3.1.1-2.efddd69.
Date: Tue, 09 Jul 2024 10:01:29 +0200

Hello,

Thanos Apollo <public <at> thanosapollo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-emacsql): Update to commit
> efddd69.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Message #34 received at 71991-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Thanos Apollo <public <at> thanosapollo.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 71991-done <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#71991] [PATCH 2/2] gnu: emacs-yeetube: Update to 2.1.7
Date: Tue, 09 Jul 2024 10:12:27 +0200

Hello,

Thanos Apollo <public <at> thanosapollo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.7.
> [synopsis]: Remove deprecated invidious functionality
> [description]: Rephrase & remove deprecated org-mode functionality

Applied. Thanks!

The bug numbers were slightly mixed up, but I think all bugs are
properly closed now.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.