GNU bug report logs - #71994
[PATCH] gnu: Add emacs-ob-racket.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71994 in the body.
You can then email your comments to 71994 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-ob-racket.
Date: Mon, 08 Jul 2024 10:57:25 +0100

[Message part 1 (text/plain, inline)]

Dear Guix,

Here's a patch packaging emacs-ob-racket for Guix.

Thanks!

-
Sergiu

[0001-gnu-Add-emacs-ob-racket.patch (text/x-patch, attachment)]

Message #8 received at 71994 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 71994 <at> debbugs.gnu.org
Subject: Re: [bug#71994] [PATCH] gnu: Add emacs-ob-racket.
Date: Mon, 08 Jul 2024 12:51:19 +0200

Hello,

Sergiu Ivanov <sivanov <at> colimite.fr> writes:
>
> Here's a patch packaging emacs-ob-racket for Guix.

Thank you. Some comments follow.

> +(define-public emacs-ob-racket
> +  (let ((commit "c7b7eee58fcde2ad515b72288742e555e7ec7915")
> +	(version "1.3.0")
> +        (revision "0"))
> +    (package
> +      (name "emacs-ob-racket")
> +      (version (git-version version revision commit))

There's a "1.3.0" tag, so you can drop COMMIT and REVISION and use
(version "1.3.0").

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/hasu/emacs-ob-racket")
> +                      (commit commit)))

Here that will be (commit version).

> +                (sha256
> +                 (base32
> +                  "0bqhxi1nikxwc0gyqsnxc7ya2s41vc06w39s24qz64kja8zqzzya"))
> +                (file-name (git-file-name name version))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/hasu/emacs-ob-racket")
> +      (synopsis "Org-babel support for Racket")

Nitpick Org Babel support for Racket

> +      (description
> +       "This package adds spport for working with Racket code blocks with
> +Org-babel in Org-mode.")

Likewise, Org Babel and Org mode.

I know, not every package definition follows that convention, but they
ARE WRONG! ;)

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 71994 <at> debbugs.gnu.org (full text, mbox):

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 71994 <at> debbugs.gnu.org
Subject: Re: [bug#71994] [PATCH] gnu: Add emacs-ob-racket.
Date: Mon, 08 Jul 2024 18:09:48 +0100

[Message part 1 (text/plain, inline)]

Hello Nicolas,

Thank you for your comments!  I am attaching the updated patch to
this mail.


Nicolas Goaziou <mail <at> nicolasgoaziou.fr> [2024-07-08T11:51:19+0100]:
>
> Likewise, Org Babel and Org mode.
>
> I know, not every package definition follows that convention, but they
> ARE WRONG! ;)

I am happy to follow this convention!

I never know myself how to spell Org Babel and Org mode, and if both
were Emacs functions or variables, I would just write org-babel and
org-mode :-D

-
Sergiu

[0001-gnu-Add-emacs-ob-racket.patch (text/x-patch, attachment)]

Message #16 received at 71994-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 71994-done <at> debbugs.gnu.org
Subject: Re: [bug#71994] [PATCH] gnu: Add emacs-ob-racket.
Date: Tue, 09 Jul 2024 10:06:42 +0200

Hello,

Sergiu Ivanov <sivanov <at> colimite.fr> writes:

> Thank you for your comments!  I am attaching the updated patch to
> this mail.

Applied. Thank you!

> I never know myself how to spell Org Babel and Org mode, and if both
> were Emacs functions or variables, I would just write org-babel and
> org-mode :-D

Yes, that's the source of the confusion. Elisp symbols use hyphens, and
it is easy to conflate the language symbol with the concept. But the
Emacs manual is unambiguous about it. For example, its menu contains the
following entry:

  * Major Modes::         Text mode vs. Lisp mode vs. C mode...

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.