GNU bug report logs - #72006
[PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72006 in the body.
You can then email your comments to 72006 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.
Date: Tue,  9 Jul 2024 20:46:23 +0900

* gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision 2.
[arguments]: Add a phase to set default binaries for fd and mpv.
[inputs]: Add fd and mpv.
[propagated-inputs]: Add emacs-consult.

Change-Id: I0e627d3b3ec3e5515ff7da9cd601713840e2a9c7
---
 gnu/packages/emacs-xyz.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 45225f2051..d7b25af21c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3751,7 +3751,7 @@ (define-public emacs-emprise
 
 (define-public emacs-empv
   (let ((commit "8cc9b0a425b6989d30f91bf90e9b09bd00581f07")
-        (revision "1"))
+        (revision "2"))
     (package
       (name "emacs-empv")
       (version (git-version "4.3.0" revision commit))
@@ -3766,7 +3766,16 @@ (define-public emacs-empv
           (base32
            "06dphwj9vi39dbpif3kzp6azs80klh13s9l22a6ddz91kmds2myy"))))
       (build-system emacs-build-system)
-      (propagated-inputs (list emacs-compat emacs-s))
+      (arguments
+       (list
+        #:phases #~(modify-phases %standard-phases
+                     (add-after 'unpack 'set-default-binaries
+                       (lambda* (#:key inputs #:allow-other-keys)
+                         (emacs-substitute-variables "empv.el"
+                           ("empv-fd-binary" (search-input-file inputs "/bin/fd"))
+                           ("empv-mpv-binary" (search-input-file inputs "/bin/mpv"))))))))
+      (inputs (list fd mpv))
+      (propagated-inputs (list emacs-compat emacs-consult emacs-s))
       (home-page "https://github.com/isamert/empv.el")
       (synopsis
        "Emacs multimedia player, media library manager, YouTube frontend")

base-commit: 6b496c071537e399710ff5ec0284f74a44b66c71
prerequisite-patch-id: 7243f4196faacbbb69b65baecf49b488e4c8a910
-- 
2.45.2

Message #10 received at 72006-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 72006-done <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: Re: [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.
Date: Tue, 09 Jul 2024 15:10:19 +0200

Hello,

> * gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision 2.

I skipped that part. It is not necessary, since the patch doesn't modify
the commit hash.

Applied. Thank you!

Regards,
-- 
Nicolas Goaziou

Message #13 received at 72006 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: gemmaro <gemmaro.dev <at> gmail.com>, 72006 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.
Date: Tue, 09 Jul 2024 19:09:43 +0200

Am Dienstag, dem 09.07.2024 um 20:46 +0900 schrieb gemmaro:
> * gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision
> 2.
You don't need to bump the revision to update a recipe.
> [arguments]: Add a phase to set default binaries for fd and mpv.
> [inputs]: Add fd and mpv.
> [propagated-inputs]: Add emacs-consult.
> 
> Change-Id: I0e627d3b3ec3e5515ff7da9cd601713840e2a9c7
> ---
>  gnu/packages/emacs-xyz.scm | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 45225f2051..d7b25af21c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -3751,7 +3751,7 @@ (define-public emacs-emprise
>  
>  (define-public emacs-empv
>    (let ((commit "8cc9b0a425b6989d30f91bf90e9b09bd00581f07")
> -        (revision "1"))
> +        (revision "2"))
>      (package
>        (name "emacs-empv")
>        (version (git-version "4.3.0" revision commit))
> @@ -3766,7 +3766,16 @@ (define-public emacs-empv
>            (base32
>            
> "06dphwj9vi39dbpif3kzp6azs80klh13s9l22a6ddz91kmds2myy"))))
>        (build-system emacs-build-system)
> -      (propagated-inputs (list emacs-compat emacs-s))
> +      (arguments
> +       (list
> +        #:phases #~(modify-phases %standard-phases
> +                     (add-after 'unpack 'set-default-binaries
> +                       (lambda* (#:key inputs #:allow-other-keys)
> +                         (emacs-substitute-variables "empv.el"
> +                           ("empv-fd-binary" (search-input-file
> inputs "/bin/fd"))
> +                           ("empv-mpv-binary" (search-input-file
> inputs "/bin/mpv"))))))))
> +      (inputs (list fd mpv))
> +      (propagated-inputs (list emacs-compat emacs-consult emacs-s))
>        (home-page "https://github.com/isamert/empv.el")
>        (synopsis
>         "Emacs multimedia player, media library manager, YouTube
> frontend")
Otherwise LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.