GNU bug report logs - #72016
[PATCH] gnu: emacs-lsp-mode: Enable plists.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72016 in the body.
You can then email your comments to 72016 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: emacs-lsp-mode: Enable plists.
Date: Tue,  9 Jul 2024 13:52:22 +0200

* gnu/packages/emacs-xyz.scm (emacs-lsp-mode)[arguments]<#:phases>
[enable-plists]: New phase.

Change-Id: I5088954b683b23ab51bd5d6adc09dcc9a1c85ec1
---
 gnu/packages/emacs-xyz.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d5257f16a9..fd04e2432b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -31169,6 +31169,14 @@ (define-public emacs-lsp-mode
               (for-each (lambda (f)
                           (install-file f "."))
                         (find-files "clients/" "\\.el$"))))
+          (add-after 'unpack 'enable-plists
+            (lambda _
+              (substitute* "lsp-protocol.el"
+               ;; This is faster, and it's officially recommended,
+               ;; and it's required by emacs-lsp-booster.
+               ;; See also:
+               ;; <https://emacs-lsp.github.io/lsp-mode/page/performance/>.
+               (("\\(getenv \"LSP_USE_PLISTS\"\\)") "t"))))
           (add-before 'move-clients-libraries 'fix-patch-el-files
             ;; /bin/ksh is only used on macOS, which we don't support, so we
             ;; don't want to add it as input.

base-commit: 13f0f52314244f08eb9fdd626d907c0c3976e06a
-- 
2.45.2

Message #8 received at 72016 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 72016 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#72016] [PATCH] gnu: emacs-lsp-mode: Enable plists.
Date: Thu, 18 Jul 2024 17:03:34 +0200

Hey Danny!

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-lsp-mode)[arguments]<#:phases>
> [enable-plists]: New phase.
>
> Change-Id: I5088954b683b23ab51bd5d6adc09dcc9a1c85ec1
> ---
>  gnu/packages/emacs-xyz.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index d5257f16a9..fd04e2432b 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -31169,6 +31169,14 @@ (define-public emacs-lsp-mode
>                (for-each (lambda (f)
>                            (install-file f "."))
>                          (find-files "clients/" "\\.el$"))))
> +          (add-after 'unpack 'enable-plists
> +            (lambda _
> +              (substitute* "lsp-protocol.el"
> +               ;; This is faster, and it's officially recommended,
> +               ;; and it's required by emacs-lsp-booster.
> +               ;; See also:
> +               ;; <https://emacs-lsp.github.io/lsp-mode/page/performance/>.
> +               (("\\(getenv \"LSP_USE_PLISTS\"\\)") "t"))))

I’m know next to nothing about LSP, but that sounds reasonable to me!

Ludo’.

Message #13 received at 72016-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>, Danny Milosavljevic
 <dannym <at> scratchpost.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 72016-done <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#72016] [PATCH] gnu: emacs-lsp-mode: Enable plists.
Date: Sun, 21 Jul 2024 12:15:33 +0200

Am Donnerstag, dem 18.07.2024 um 17:03 +0200 schrieb Ludovic Courtès:
> Hey Danny!
> 
> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-lsp-mode)[arguments]<#:phases>
> > [enable-plists]: New phase.
> > 
> > Change-Id: I5088954b683b23ab51bd5d6adc09dcc9a1c85ec1
> > ---
> >  gnu/packages/emacs-xyz.scm | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-
> > xyz.scm
> > index d5257f16a9..fd04e2432b 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -31169,6 +31169,14 @@ (define-public emacs-lsp-mode
> >                (for-each (lambda (f)
> >                            (install-file f "."))
> >                          (find-files "clients/" "\\.el$"))))
> > +          (add-after 'unpack 'enable-plists
> > +            (lambda _
> > +              (substitute* "lsp-protocol.el"
> > +               ;; This is faster, and it's officially recommended,
> > +               ;; and it's required by emacs-lsp-booster.
> > +               ;; See also:
> > +               ;;
> > <https://emacs-lsp.github.io/lsp-mode/page/performance/>.
> > +               (("\\(getenv \"LSP_USE_PLISTS\"\\)") "t"))))
> 
> I’m know next to nothing about LSP, but that sounds reasonable to me!
I agree.  Pushed.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.