GNU bug report logs - #72042
[core-updates] Python-gst fails its test suite

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72042 in the body.
You can then email your comments to 72042 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: bug-guix <at> gnu.org
Subject: [core-updates] Python-gst fails its test suite
Date: Wed, 10 Jul 2024 15:37:15 -0400

[Message part 1 (text/plain, inline)]

On core-updates commit 378e1d9b69b030a, python-gst fails its test suite
like this:

------
======================================================================
FAIL: testPropertyMarshalling (test_types.TestFraction)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-gst-1.22.3.drv-0/gst-python-1.22.3/testsuite/common.py", line 98, in tearDown
    self.gcverify()
  File "/tmp/guix-build-python-gst-1.22.3.drv-0/gst-python-1.22.3/testsuite/common.py", line 81, in gcverify
    self.assertFalse(leaked, leaked)
AssertionError: [<__gi__.GstRawVideoParse object at 0x7ffff66a55c0 (GstRawVideoParse at 0x787820)>] is not false : [<__gi__.GstRawVideoParse object at 0x7ffff66a55c0 (GstRawVideoParse at 0x787820)>]

======================================================================
FAIL: testPropertyMarshalling (test_types.TestValueArray)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-gst-1.22.3.drv-0/gst-python-1.22.3/testsuite/common.py", line 98, in tearDown
    self.gcverify()
  File "/tmp/guix-build-python-gst-1.22.3.drv-0/gst-python-1.22.3/testsuite/common.py", line 81, in gcverify
    self.assertFalse(leaked, leaked)
AssertionError: [<__gi__.GstRawVideoParse object at 0x7ffff66a55c0 (GstRawVideoParse at 0x78b6c0)>] is not false : [<__gi__.GstRawVideoParse object at 0x7ffff66a55c0 (GstRawVideoParse at 0x78b6c0)>]

----------------------------------------------------------------------
Ran 32 tests in 1.179s

FAILED (failures=2, errors=32)
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

3/3 Test plugins      OK              0.32s

Summary of Failures:

2/3 Test fundamentals FAIL            1.45s   exit status 1

Ok:                 2   
Expected Fail:      0   
Fail:               1   
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0   

Full log written to /tmp/guix-build-python-gst-1.22.3.drv-0/build/meson-logs/testlog.txt
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "meson" arguments: ("test" "--print-errorlogs" "-t" "0") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `check' failed after 2.9 seconds
command "meson" "test" "--print-errorlogs" "-t" "0" failed with status 1
build process 6 exited with status 256
builder for `/gnu/store/qdqxmq3y1w03d5v3736r5f0cw4wz9alz-python-gst-1.22.3.drv' failed with exit code 1
build of /gnu/store/qdqxmq3y1w03d5v3736r5f0cw4wz9alz-python-gst-1.22.3.drv failed
View build log at '/var/log/guix/drvs/qd/qxmq3y1w03d5v3736r5f0cw4wz9alz-python-gst-1.22.3.drv.gz'.
------

I've attached the testlog.txt. Any ideas?

[testlog.txt (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 72042 <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 72042 <at> debbugs.gnu.org
Subject: Re: [core-updates] Python-gst fails its test suite
Date: Mon, 02 Sep 2024 17:12:22 +0200

Hi,

The issue is here:

  https://gitlab.gnome.org/GNOME/pygobject/-/issues/624

I've tried and upgrading python-pygobject from 3.47.0 (currently on
master) to 3.48.2 (current upstream release) fixes the issue.

Unfortunately python-pygobject has a lot of dependent packages.

  $ guix refresh --list-dependent python-pygobject
  Building the following 2015 packages would ensure 4466 dependent packages are rebuilt: ..

Graft, add a python-pygobject-3.48.2 package or just go for it?

Cheers,
Remco

Message #11 received at 72042 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Remco van 't Veer <remco <at> remworks.net>
Cc: 72042 <at> debbugs.gnu.org
Subject: Re: [core-updates] Python-gst fails its test suite
Date: Mon, 2 Sep 2024 14:18:46 -0400

On Mon, Sep 02, 2024 at 05:12:22PM +0200, Remco van 't Veer wrote:
> The issue is here:
> 
>   https://gitlab.gnome.org/GNOME/pygobject/-/issues/624
> 
> I've tried and upgrading python-pygobject from 3.47.0 (currently on
> master) to 3.48.2 (current upstream release) fixes the issue.

Aha, thanks for finding that information. I wasn't able to find it when
I created this bug.

> Unfortunately python-pygobject has a lot of dependent packages.
> 
>   $ guix refresh --list-dependent python-pygobject
>   Building the following 2015 packages would ensure 4466 dependent packages are rebuilt: ..
> 
> Graft, add a python-pygobject-3.48.2 package or just go for it?

Hm, I don't think it's worth rebuilding 4466 packages on master just to
fix the handful of packages that actually use python-gst.

I wonder if we could create a new package called python-pygobject-3.48.2
and use it for python-gst? And then upgrade pygobject on the python-team
branch? That way we could avoid the rebuilds and avoid a graft.

Message #14 received at 72042 <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: 72042 <at> debbugs.gnu.org,
	Leo Famulari <leo <at> famulari.name>
Cc: Remco van 't Veer <remco <at> remworks.net>
Subject: [PATCH 0/1] introduce python-pygobject-3.48 to fix python-gst build
Date: Mon,  2 Sep 2024 21:38:24 +0200

Like this?

Remco van 't Veer (1):
  gnu: python-gst: Fix build.

 gnu/packages/glib.scm      | 15 +++++++++++++++
 gnu/packages/gstreamer.scm |  3 ++-
 2 files changed, 17 insertions(+), 1 deletion(-)


base-commit: ad7211cfe0cba1b7a97308c0fec941c807c1c1e5
-- 
2.45.2

Message #17 received at 72042 <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: 72042 <at> debbugs.gnu.org,
	Leo Famulari <leo <at> famulari.name>
Cc: Remco van 't Veer <remco <at> remworks.net>
Subject: [PATCH 1/1] gnu: python-gst: Fix build.
Date: Mon,  2 Sep 2024 21:38:25 +0200

* gnu/packages/glib.scm: Add package python-pygobject-3.48.
* gnu/packages/gstreamer.scm (python-gst) [inputs]:
  Use python-pygobject-3.48 to fix tests.

Change-Id: I3038b85db67ff354a6d77708fa4fd7c63aa6732c
---
 gnu/packages/glib.scm      | 15 +++++++++++++++
 gnu/packages/gstreamer.scm |  3 ++-
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index 9827856f32..d6275ea63e 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
 ;;; Copyright © 2023 Saku Laesvuori <saku <at> laesvuori.fi>
 ;;; Copyright © 2024 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2024 Remco van 't Veer <remco <at> remworks.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1077,6 +1078,20 @@ (define-public python-pygobject
      '((upstream-name . "pygobject")))
     (license license:lgpl2.1+)))
 
+(define-public python-pygobject-3.48
+  (package
+    (inherit python-pygobject)
+    (version "3.48.2")
+    (source
+     (origin
+       (inherit (package-source python-pygobject))
+       (uri (string-append "mirror://gnome/sources/pygobject/"
+                           (version-major+minor version)
+                           "/pygobject-" version ".tar.xz"))
+       (sha256
+        (base32
+         "19yii8lydnjw225k4gclhn8hya7caiginqi0mj9a0cdym6sax507"))))))
+
 (define-public perl-glib
   (package
     (name "perl-glib")
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index ad08285181..66978fc2bc 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2020 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2023 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2024 Remco van 't Veer <remco <at> remworks.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1126,7 +1127,7 @@ (define-public python-gst
     (native-inputs
      (list pkg-config python))
     (propagated-inputs
-     (list gst-plugins-base python-pygobject))
+     (list gst-plugins-base python-pygobject-3.48))
     (home-page "https://gstreamer.freedesktop.org/")
     (synopsis "GStreamer GObject Introspection overrides for Python")
     (description
-- 
2.45.2

Message #22 received at 72042-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Remco van 't Veer <remco <at> remworks.net>, 72042-done <at> debbugs.gnu.org, Leo
 Famulari <leo <at> famulari.name>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>,
 Remco van 't Veer <remco <at> remworks.net>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: bug#72042: [PATCH 1/1] gnu: python-gst: Fix build.
Date: Thu, 05 Sep 2024 19:14:23 +0400

[Message part 1 (text/plain, inline)]

On 2024-09-02 21:38, Remco van 't Veer wrote:

> * gnu/packages/glib.scm: Add package python-pygobject-3.48.
> * gnu/packages/gstreamer.scm (python-gst) [inputs]:
>   Use python-pygobject-3.48 to fix tests.
>
> Change-Id: I3038b85db67ff354a6d77708fa4fd7c63aa6732c
> ---
>  gnu/packages/glib.scm      | 15 +++++++++++++++
>  gnu/packages/gstreamer.scm |  3 ++-
>  2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> index 9827856f32..d6275ea63e 100644
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -20,6 +20,7 @@
>  ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
>  ;;; Copyright © 2023 Saku Laesvuori <saku <at> laesvuori.fi>
>  ;;; Copyright © 2024 Zheng Junjie <873216071 <at> qq.com>
> +;;; Copyright © 2024 Remco van 't Veer <remco <at> remworks.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1077,6 +1078,20 @@ (define-public python-pygobject
>       '((upstream-name . "pygobject")))
>      (license license:lgpl2.1+)))
>  
> +(define-public python-pygobject-3.48
> +  (package
> +    (inherit python-pygobject)
> +    (version "3.48.2")
> +    (source
> +     (origin
> +       (inherit (package-source python-pygobject))
> +       (uri (string-append "mirror://gnome/sources/pygobject/"
> +                           (version-major+minor version)
> +                           "/pygobject-" version ".tar.xz"))
> +       (sha256
> +        (base32
> +         "19yii8lydnjw225k4gclhn8hya7caiginqi0mj9a0cdym6sax507"))))))
> +
>  (define-public perl-glib
>    (package
>      (name "perl-glib")
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index ad08285181..66978fc2bc 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -11,6 +11,7 @@
>  ;;; Copyright © 2020 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
>  ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
>  ;;; Copyright © 2023 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2024 Remco van 't Veer <remco <at> remworks.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1126,7 +1127,7 @@ (define-public python-gst
>      (native-inputs
>       (list pkg-config python))
>      (propagated-inputs
> -     (list gst-plugins-base python-pygobject))
> +     (list gst-plugins-base python-pygobject-3.48))
>      (home-page "https://gstreamer.freedesktop.org/")
>      (synopsis "GStreamer GObject Introspection overrides for Python")
>      (description

Thank you!  Applied the fix, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7d2ced8d6d

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 72042-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Andrew Tropin <andrew <at> trop.in>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 72042-done <at> debbugs.gnu.org,
 Remco van 't Veer <remco <at> remworks.net>, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#72042: [PATCH 1/1] gnu: python-gst: Fix build.
Date: Wed, 11 Sep 2024 15:05:07 +0900

Hi,

Andrew Tropin <andrew <at> trop.in> writes:

> On 2024-09-02 21:38, Remco van 't Veer wrote:
>
>> * gnu/packages/glib.scm: Add package python-pygobject-3.48.
>> * gnu/packages/gstreamer.scm (python-gst) [inputs]:
>>   Use python-pygobject-3.48 to fix tests.
>>
>> Change-Id: I3038b85db67ff354a6d77708fa4fd7c63aa6732c

[...]

>> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
>> index ad08285181..66978fc2bc 100644
>> --- a/gnu/packages/gstreamer.scm
>> +++ b/gnu/packages/gstreamer.scm
>> @@ -11,6 +11,7 @@
>>  ;;; Copyright © 2020 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
>>  ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
>>  ;;; Copyright © 2023 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> +;;; Copyright © 2024 Remco van 't Veer <remco <at> remworks.net>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -1126,7 +1127,7 @@ (define-public python-gst
>>      (native-inputs
>>       (list pkg-config python))
>>      (propagated-inputs
>> -     (list gst-plugins-base python-pygobject))
>> +     (list gst-plugins-base python-pygobject-3.48))

It's nice that this fixes the package build, but propagating various
version of Python libraries a road that to leads to problems.  Currently
it's important that propagated things are all compatible together.

I'd suggest trying to update python-gst to see if it works with the
newer python-pygobject instead.

-- 
Thanks,
Maxim

Message #28 received at 72042-done <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>, Leo Famulari <leo <at> famulari.name>,
 72042-done <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: bug#72042: [PATCH 1/1] gnu: python-gst: Fix build.
Date: Wed, 11 Sep 2024 09:29:17 +0200

Hi Maxim,

2024/09/11, Maxim Cournoyer:

> It's nice that this fixes the package build, but propagating various
> version of Python libraries a road that to leads to problems.  Currently
> it's important that propagated things are all compatible together.
>
> I'd suggest trying to update python-gst to see if it works with the
> newer python-pygobject instead.

It does because this is the newer version.  I proposed to do a graft or
just go for the upgrade[1] but python-pygobject has a lot of dependent
packages.

  $ guix refresh --list-dependent python-pygobject
  Building the following 2015 packages would ensure 4466 dependent packages are rebuilt: ..

Should I provide a patch to just go for the newer version?

Remco

Message #31 received at 72042-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Remco van 't Veer <remco <at> remworks.net>, Maxim Cournoyer
 <maxim.cournoyer <at> gmail.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>, Leo Famulari <leo <at> famulari.name>,
 72042-done <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>
Subject: Re: bug#72042: [PATCH 1/1] gnu: python-gst: Fix build.
Date: Wed, 11 Sep 2024 18:59:04 +0200

Am Mittwoch, dem 11.09.2024 um 09:29 +0200 schrieb Remco van 't Veer:
> Hi Maxim,
> 
> 2024/09/11, Maxim Cournoyer:
> 
> > It's nice that this fixes the package build, but propagating
> > various version of Python libraries a road that to leads to
> > problems.  Currently it's important that propagated things are all
> > compatible together.
> > 
> > I'd suggest trying to update python-gst to see if it works with the
> > newer python-pygobject instead.
> 
> It does because this is the newer version.  I proposed to do a graft
> or
> just go for the upgrade[1] but python-pygobject has a lot of
> dependent
> packages.
> 
>   $ guix refresh --list-dependent python-pygobject
>   Building the following 2015 packages would ensure 4466 dependent
> packages are rebuilt: ..
> 
> Should I provide a patch to just go for the newer version?
How many dependents does python-gst have?
Can we patch it to work with the current version?
If not, can sneak in python-gobject-3.48 as a regular input instead of
propagating it?

Perhaps we could even delay this for gnome-team, where massive rebuilds
are less of an issue.

Cheers

Message #34 received at 72042-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>, Leo Famulari <leo <at> famulari.name>,
 72042-done <at> debbugs.gnu.org, Remco van 't Veer <remco <at> remworks.net>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: bug#72042: [PATCH 1/1] gnu: python-gst: Fix build.
Date: Thu, 12 Sep 2024 09:37:21 +0900

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Mittwoch, dem 11.09.2024 um 09:29 +0200 schrieb Remco van 't Veer:
>> Hi Maxim,
>> 
>> 2024/09/11, Maxim Cournoyer:
>> 
>> > It's nice that this fixes the package build, but propagating
>> > various version of Python libraries a road that to leads to
>> > problems.  Currently it's important that propagated things are all
>> > compatible together.
>> > 
>> > I'd suggest trying to update python-gst to see if it works with the
>> > newer python-pygobject instead.
>> 
>> It does because this is the newer version.  I proposed to do a graft
>> or
>> just go for the upgrade[1] but python-pygobject has a lot of
>> dependent
>> packages.
>> 
>>   $ guix refresh --list-dependent python-pygobject
>>   Building the following 2015 packages would ensure 4466 dependent
>> packages are rebuilt: ..
>> 
>> Should I provide a patch to just go for the newer version?
> How many dependents does python-gst have?
> Can we patch it to work with the current version?
> If not, can sneak in python-gobject-3.48 as a regular input instead of
> propagating it?
>
> Perhaps we could even delay this for gnome-team, where massive rebuilds
> are less of an issue.

I'm not in the python-team, but a branch could be set for it if there
isn't one already and an update of python-gst pushed there.  If someone
needs admin access to the Berlin CI to configure jobs I can be of help.

-- 
Thanks,
Maxim

Message #37 received at 72042-done <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, Maxim Cournoyer
 <maxim.cournoyer <at> gmail.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>, Leo Famulari <leo <at> famulari.name>,
 72042-done <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>
Subject: Re: bug#72042: [PATCH 1/1] gnu: python-gst: Fix build.
Date: Thu, 12 Sep 2024 09:04:20 +0200

Hi Liliana and Maxim,

2024/09/11, Liliana Marie Prikler:

> Am Mittwoch, dem 11.09.2024 um 09:29 +0200 schrieb Remco van 't Veer:
>> Hi Maxim,
>> 
>> 2024/09/11, Maxim Cournoyer:
>> 
>> > It's nice that this fixes the package build, but propagating
>> > various version of Python libraries a road that to leads to
>> > problems.  Currently it's important that propagated things are all
>> > compatible together.
>> > 
>> > I'd suggest trying to update python-gst to see if it works with the
>> > newer python-pygobject instead.
>> 
>> It does because this is the newer version.  I proposed to do a graft
>> or
>> just go for the upgrade[1] but python-pygobject has a lot of
>> dependent
>> packages.
>> 
>>   $ guix refresh --list-dependent python-pygobject
>>   Building the following 2015 packages would ensure 4466 dependent
>> packages are rebuilt: ..
>> 
>> Should I provide a patch to just go for the newer version?
> How many dependents does python-gst have?

$ guix refresh --list-dependent python-gst
Building the following 6 packages would ensure 6 dependent packages are rebuilt: cozy <at> 1.2.1 lollypop <at> 1.4.40 quodlibet <at> 4.5.0 gourmet <at> 0.17.4-0.8af29c8 blanket <at> 0.5.0 pitivi <at> 2022.06.0

> Can we patch it to work with the current version?

Probably but I think python-gobject is actually broken now and needs to
be upgraded.  I am not aware of other packages failing because of this
but I think there are.

> If not, can sneak in python-gobject-3.48 as a regular input instead of
> propagating it?

I do not know what that means.

> Perhaps we could even delay this for gnome-team, where massive rebuilds
> are less of an issue.

Yes please?

Also note, that this patch has been merged and the issue has been
closed.  Maybe it should be reopened or a new issue should be opened?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.