GNU bug report logs - #72057
[PATCH] Add python-sacn

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72057 in the body.
You can then email your comments to 72057 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
Subject: [PATCH] Add python-sacn
Date: Thu, 11 Jul 2024 11:20:21 +0200

---
Feel free to remove copyright header, I dont know the custom / rules for that.
Packaging python-sacn to maybe package more of the Open Lighting Project later.
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index e1b2679e59..bbfe7bfdbf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -153,6 +153,7 @@
 ;;; Copyright © 2024 Navid Afkhami <navid.afkhami <at> mdc-berlin.de>
 ;;; Copyright © 2024 TakeV <takev <at> disroot.org>
 ;;; Copyright © 2024 David Elsing <david.elsing <at> posteo.net>
+;;; Copyright © 2024 Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24689,6 +24690,28 @@ (define-public python-rfc6555
      and integration into other projects.")
       (license license:asl2.0))))
 
+(define-public python-sacn
+  (package
+    (name "python-sacn")
+    (version "1.10.0") 
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "sacn" version))
+        (sha256
+          (base32 "02pqfwwx83lgb8nj9p0s6vyi1s7wjgbx9k0bzlyz8qapszzdsr37")))) 
+    (build-system python-build-system)
+    (native-inputs 
+      (list python-pytest))
+    (propagated-inputs
+      (list python-setuptools)) 
+    (home-page "https://github.com/Hundemeier/sacn")
+    (synopsis "A Python library for sending and receiving sACN (Streaming Architecture for Control Networks) data")
+    (description
+      "sACN is a Python library for sending and receiving sACN (Streaming Architecture for Control Networks) data, 
+       a standard protocol used for controlling lighting and other devices over a network.")
+    (license license:expat))) 
+
 (define-public python-bagit
   (package
     (name "python-bagit")

base-commit: 0663668507377a849317b0fff3d72f609c3139c2
-- 
2.45.2

Message #8 received at 72057 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 72057 <at> debbugs.gnu.org
Subject: Small changes required
Date: Thu, 11 Jul 2024 22:36:50 +0200

Hello,

thanks for the patch! It builds, but has a few minor problems,
notably with white space and other formatting issues, see here:
   https://qa.guix.gnu.org/issue/72057
These can also be found by running
   ./pre-inst-env guix lint python-sacn
locally.

Could you prepare a new version and send it following the
instructions at
   https://guix.gnu.org/de/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1
(paragraph starting with: "If you need to send a revised patch...")?

Adding a copyright line is good practice when adding a new package.

Thanks!

Andreas

Message #13 received at 72057-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 72057-done <at> debbugs.gnu.org
Cc: Andreas Enge <andreas <at> enge.fr>, Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
Subject: Re: [PATCH] Add python-sacn
Date: Thu, 11 Jul 2024 15:52:34 -0500

>    https://qa.guix.gnu.org/issue/72057

Hi all,

Thanks for the contributions!

I fixed all the issues and enabled the tests in a separate commit.

See here:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b06e8e1f6796391335a59efccefe110369c9632b

and here:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=91a773a65e2918519d2fb03f5d2726bee08d6186

Closing as done.
-- 
all the best,
jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.